GitLab

Drag and drop does not work on Windows DRT.

* platform/win/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122169

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype.revisionLinksForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.buildLogURLForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122021

* platform/win/TestExpectations: Disable a number of tests broken by the switch to the new
CSS/JS-based media controls.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122168

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-01
Reviewed by Filip Pizlo.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122143

Reviewed by Antti Koivisto.

Reduce the code duplication by extracting dispatchFullScreenChangeOrErrorEvent.

* dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Extracted.
* dom/Document.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=53990

* TestExpectations: Marking as such.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/156725
https://bugs.webkit.org/show_bug.cgi?id=122176

broke all the mismatch tests again (Requested by thorton on
#webkit).

Tools:

* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):

LayoutTests:

* platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Removed.
* platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122166

Reviewed by Jer Noble.

* DerivedSources.make: Uncomment feature flag test.
* WebCore.vcxproj/WebCore.vcxproj: Add new media control implementation files.
Also cleaned up some misplaced files in the project tree.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* WebCore.vcxproj/WebCoreCommon.props: Add missing include path for the
mediacontrols path.
* WebCore.vcxproj/copyForwardingHeaders.cmd: Add Modules/mediacontrols to copied headers.
* rendering/RenderThemeWin.cpp: Add missing include for UserAgentScripts.

WebKitLibraries: [Win] Implement the media controls in JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=122166

Reviewed by Jer Noble.

* win/tools/vsprops/FeatureDefines.props: Activate the
ENABLE_MEDIA_CONTROLS_SCRIPT flag.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122069

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.

* platform/win/COMPtr.h:
(adoptCOM): Added.

Source/WebKit/win: Implemented createWebViewWithRequest in WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122069

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::createWindow):
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchCreatePage):
Pass request url from the NavigationAction to createWebViewWithRequest.

Tools: Implemented createWebViewWithRequest in WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122069

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.

* WinLauncher/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::createWebViewWithRequest): Added.
* WinLauncher/PrintWebUIDelegate.h:
Removed createWebViewWithRequest stub.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122151

Reviewed by Joseph Pecoraro.

Identify if the hovered token is contained within the text selection (if any) and use
the selection as the hovered expression to allow the user to select text and hover it
to see what it evaluates to.

* UserInterface/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightRange):
Check we're trying to highlight a different range before removing the highlight
and applying the new one, this prevents the marked text from flashing if it's
being re-hovered which would easily happen when hovering multiple tokens within
the same selection.

(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
In the case where there is selected text, check whether the hovered token is at least
partially contained within the selection, and if so use the selection text as the
hovered expression to evaluate.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=116515

Reviewed by Darin Adler.

The correct display of navigation items in the ContentBrowser is contingent on
the ContentViewContainer's _backForwardList being up-to-date when the navigation
items are retrieved from it. However, when the main resource changes (in this case
the user refreshes the browser), calls are made to ContentViewContainer's
closeAllContentViewsOfPrototype() which may modify the _backForwardList but doesn't
necessarily notify of a change to the currentContentView since we may be still showing
the same view in case it wasn't directly related to the main resource, for instance
the console log.

We now check if the _backForwardList is changed as a result of calling
closeAllContentViewsOfPrototype() and in that case also dispatch the
CurrentContentViewDidChange event which will restore the correct state
for the back/forward buttons and navigation items of the navigation bar.

* UserInterface/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.closeAllContentViewsOfPrototype):
Track changes to the _backForwardList and dispatch the CurrentContentViewDidChange
event in case such changes happened.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed build fix; The addedFunction and removedFunction arguments to determineChangedTracksFromNewTracksAndOldItems
were reversed, exposing an underlying, existing bug in AudioTrackPrivate and VideoTrack private. Give a default (null)
value to AudioTrackPrivate::m_client and VideoTrackPrivate::m_client and fix the ordering of arguments in
determineChangedTracksFromNewTracksAndOldItems.

* platform/graphics/AudioTrackPrivate.h:
(WebCore::AudioTrackPrivate::AudioTrackPrivate):
* platform/graphics/VideoTrackPrivate.h:
(WebCore::VideoTrackPrivate::VideoTrackPrivate):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::determineChangedTracksFromNewTracksAndOldItems):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122006
<rdar://problem/15095197>

Reviewed by Dean Jackson.

* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
Layer-back the root view in WebKitTestRunner's window, to work around a bug
where the window server snapshot API returns blank snapshots.

Re-landing after r156724, this should not break everything now.

Add a test that ensures that WebKitTestRunner's snapshots are not
completely blank with tiled drawing enabled.

* platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
* platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122152
<rdar://problem/15119384>

Reviewed by Anders Carlsson.

* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(main):
* DumpRenderTree/mac/DumpRenderTreeWindow.h:
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/mac/main.mm:
(main):
Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122140

Reviewed by Darin Adler.
        
Just killing code.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::recordSetLocal):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122122

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/video-track.html

Refactor the methods which query AVAssetTrack and AVPlayerItemTrack into an Impl class, and
use that class to reset the properties of both AudioTrackAVFObjC and the new VideoTrackAVFObjC.

Add new files to project:
* WebCore.xcodeproj/project.pbxproj:

Add the new implementation class, shared by AudioTrackAVFObjC and VideoTrackAVFObjC:
* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h: Added.
(WebCore::AVTrackPrivateAVFObjCImpl::create): Simple factory.
(WebCore::AVTrackPrivateAVFObjCImpl::playerItemTrack): Simple getter.
* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm: Added.
(WebCore::AVTrackPrivateAVFObjCImpl::AVTrackPrivateAVFObjCImpl): Simple constructor.
(WebCore::AVTrackPrivateAVFObjCImpl::enabled): Pass to AVPlayerItemTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::setEnabled): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::audioKind): Distinguish between Alternative and Main content.
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind): Distinguish between Alternative, Main, Caption,
    and Description content.
(WebCore::AVTrackPrivateAVFObjCImpl::id): Pass to AVAssetTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::label): Retrieve the Title metadata in the user's preferred
    language.
(WebCore::AVTrackPrivateAVFObjCImpl::language): Pass to languageForAVAssetTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::languageForAVAssetTrack): Moved from AudioTrackPrivateAVFObjC.
* platform/graphics/avfoundation/VideoTrackPrivateAVF.h: Copied from Source/WebCore/platform/graphics/avfoundation/AudioTrackPrivateAVF.h.
(WebCore::VideoTrackPrivateAVF::kind): Simple getter.
(WebCore::VideoTrackPrivateAVF::id): Ditto.
(WebCore::VideoTrackPrivateAVF::label): Ditto.
(WebCore::VideoTrackPrivateAVF::language): Ditto.
(WebCore::VideoTrackPrivateAVF::setKind): Simple setter.
(WebCore::VideoTrackPrivateAVF::setId): Ditto.
(WebCore::VideoTrackPrivateAVF::setLabel): Ditto.
(WebCore::VideoTrackPrivateAVF::setLanguage): Ditto.
(WebCore::VideoTrackPrivateAVF::VideoTrackPrivateAVF): Simple constructor.
* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
(WebCore::AudioTrackPrivateAVFObjC::setEnabled): Ditto.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Refactor implementation into
    template method determineChangedTracksFromNewTracksAndOldItems().
(WebCore::determineChangedTracksFromNewTracksAndOldItems): Refactored.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks): Pass to determineChangedTracksFromNewTracksAndOldItems.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Changed class hosting
    languageForAVAssetTrack.
* platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp: Added.
(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
(WebCore::VideoTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
(WebCore::VideoTrackPrivateAVFObjC::setSelected): Ditto.
* platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h: Added.
(WebCore::VideoTrackPrivateAVFObjC::create): Simple factory.

LayoutTests:

* media/track/video-track-expected.txt: Added.
* media/track/video-track.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<https://webkit.org/b/122141>

Reviewed by Darin Adler.

Clear out a slew of FIXMEs now that HasMemoryCostMemberFunction
works on classes marked FINAL (fixed in bug 121747.)


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122158

Patch by Szabolcs Dávid <davidsz@inf.u-szeged.hu> on 2013-10-01
Reviewed by Darin Adler.

I changed the name of the URL objects to match with the new class name.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::getProtectionSpace):
(WebCore::ResourceHandleManager::initializeHandle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122046

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-01
Reviewed by Darin Adler.

Source/WebCore:

Test: editing/spelling/spelling.html

* platform/graphics/GraphicsContext.h:
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForDocumentMarker):

LayoutTests:

This patch only rebaselines a single test. I would have rebaselined
the rest of the tests, but they seem to be affected by
webkit.org/b/122146. I don't want to commit incorrect expected results.

* platform/mac/editing/spelling/spelling-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122161

Reviewed by Darin Adler.

* editing/FrameSelection.cpp: Add ENABLE(TEXT_CARET)-guard around shouldStopBlinkingDueToTypingCommand().
* page/EventHandler.cpp: Add !PLATFORM(IOS)-guard around constants cursorUpdateInterval and maximumCursorSize;
also add touch event/gesture event guard around shouldGesturesTriggerActive().
* platform/network/cf/ResourceResponseCFNet.cpp: Remove unused function filenameHasSaneExtension.
* platform/network/mac/ResourceResponseMac.mm: Only define static variables commonHeaderFields when building
without CFNetwork; also remove variable numCommonHeaderFields, instead use WTF_ARRAY_LENGTH(commonHeaderFields)
to compute the size of the fixed-sized array commonHeaderFields.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122162

Reviewed by Darin Adler.

* runtime/GCActivityCallback.cpp: Add !PLATFORM(IOS)-guard around constant pagingTimeOut
as we don't compile the code that uses it on iOS.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122000

Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-01
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/in-band/track-in-band-mkv-chapters.html

* platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h: New class, needed for cues that aren't associated with GstPads.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Check for table of contents messages.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents): Parse table of contents messages into text tracks.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry): Recursive method for parsing all of the TOC entries.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Add the processTableOfContents functions.

LayoutTests:

* media/content/counting-subtitled-srt.mkv: Added chapters metadata.
* media/track/in-band/track-in-band-mkv-chapters-expected.txt: New test, similar to cues-added-one, but uses "chapters" track.
* media/track/in-band/track-in-band-mkv-chapters.html: Same.
* media/in-band-cues.js: Updated tests to handle the new "chapters" track.
* media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt: Same.
* media/track/in-band/track-in-band-kate-ogg-cues-added-once.html: Same.
* media/track/in-band/track-in-band-kate-ogg-mode-expected.txt: Same.
* media/track/in-band/track-in-band-kate-ogg-mode.html: Same.
* media/track/in-band/track-in-band-kate-ogg-style-expected.txt: Same.
* media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt: Same.
* media/track/in-band/track-in-band-kate-ogg-track-order.html: Same.
* media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-cues-added-once.html: Same.
* media/track/in-band/track-in-band-srt-mkv-kind-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-kind.html: Same.
* media/track/in-band/track-in-band-srt-mkv-language-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-language.html: Same.
* media/track/in-band/track-in-band-srt-mkv-mode-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-mode.html: Same.
* media/track/in-band/track-in-band-srt-mkv-style-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-track-order.html: Same.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/win/js/dom/global-constructors-attributes-expected.txt: Removed one
more class (Notification) for a feature turned off for the Windows platform.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/win/js/dom/global-constructors-attributes-expected.txt: Added.
Copy of the platform-independent results file, with items deleted for features
that are currently turned off for the Windows platform.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122159

Reviewed by Noam Rosenthal.

Tell the rendering layer we do not support CSS filters when we do not. This
will make RenderLayer fall back to using its own software implementation.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setFilters):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* css/StyleResolver.cpp:
(WebCore::StyleResolver::createFilterOperations): Rearrange code so this
won't try ot call toCSSPrimitiveValue on a non-primitive-value in the
DROP_SHADOW case.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/gtk/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122153

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-10-01
Reviewed by Allan Sandfeld Jensen.

* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::createDrawingAreaProxy):
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebViewPrivate::createDrawingAreaProxy):
* UIProcess/API/qt/raw/qrawwebview_p_p.h:
* UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::createDrawingAreaProxy):
* UIProcess/qt/QtPageClient.h:
* WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
(WebKit::convertQPixmapToShareableBitmap):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122101

Reviewed by Antti Koivisto.

As a step of clean-up static_cast<> in CSSValues, this patch generates
toCSSFooPrimitiveValue() in order to detect bad casts as well as improves
code readability.

No new tests, no behavior changes.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
* css/CSSPrimitiveValue.h:
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
* css/MediaList.cpp:
(WebCore::reportMediaQueryWarningIfNeeded):
* css/MediaQueryEvaluator.cpp:
(WebCore::numberValue):
(WebCore::orientationMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::computeLength):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
* css/StyleResolver.cpp:
(WebCore::createGridTrackSize):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::hasVariableReference):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore::StyleResolver::parseCustomFilterNumberParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
* css/TransformFunctions.cpp:
(WebCore::transformsForValue):
* css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::computedFontSize):
* editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::legacyFontSize):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::StyleChange::extractTextStyles):
(WebCore::fontWeightIsBold):
(WebCore::isTransparentColorValue):
* editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

I see multiple check-ins with people doing this for some files, but these seem to have been missed.
Maybe some of these are unneeded and can be removed.

My hope is that this might help with some failures seen on the Windows bot.

* platform/blackberry/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/blackberry/js/constructor-length-expected.txt.
* platform/efl/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/efl/js/constructor-length-expected.txt.
* platform/efl/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/efl/js/dom-static-property-for-in-iteration-expected.txt.
* platform/efl/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/efl/js/exception-linenums-in-html-3-expected.png.
* platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/efl/js/global-constructors-attributes-dedicated-worker-expected.txt.
* platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/efl/js/global-constructors-attributes-shared-worker-expected.txt.
* platform/efl/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/efl/js/missing-style-end-tag-js-expected.png.
* platform/efl/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/efl/js/missing-title-end-tag-js-expected.png.
* platform/gtk/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/gtk/js/constructor-length-expected.txt.
* platform/gtk/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/gtk/js/exception-linenums-in-html-3-expected.png.
* platform/gtk/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/gtk/js/missing-style-end-tag-js-expected.png.
* platform/gtk/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/gtk/js/missing-title-end-tag-js-expected.png.
* platform/mac/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/mac/js/exception-linenums-in-html-3-expected.png.
* platform/mac/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/mac/js/missing-style-end-tag-js-expected.png.
* platform/mac/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/mac/js/missing-title-end-tag-js-expected.png.
* platform/qt/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/qt/js/constructor-length-expected.txt.
* platform/qt/js/dom/date-DST-time-cusps-expected.txt: Renamed from LayoutTests/platform/qt/js/date-DST-time-cusps-expected.txt.
* platform/qt/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/qt/js/dom-static-property-for-in-iteration-expected.txt.
* platform/qt/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/qt/js/exception-linenums-in-html-3-expected.png.
* platform/qt/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/qt/js/missing-style-end-tag-js-expected.png.
* platform/qt/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/qt/js/missing-title-end-tag-js-expected.png.
* platform/qt/js/dom/switch-behaviour-expected.txt: Renamed from LayoutTests/platform/qt/js/switch-behaviour-expected.txt.
* platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/win/js/dom-static-property-for-in-iteration-expected.txt.
* platform/win/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/win/js/global-constructors-attributes-dedicated-worker-expected.txt.
* platform/win/js/dom/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/win/js/global-constructors-attributes-shared-worker-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
Four AVFoundation string constants used in this file were new to 10.8.
For older versions of OS X, use hard-coded string constants instead.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

under the platform/gtk-wk1 directory.

* platform/gtk-wk1/js: Added.
* platform/gtk-wk1/js/dom: Added.
* platform/gtk-wk1/js/dom/function-length-expected.txt: Added.
* platform/gtk-wk1/scrollingcoordinator: Added.
* platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
* platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
* platform/gtk/js/dom/function-length-expected.txt: Removed.
* platform/gtk/scrollingcoordinator: Removed.
* platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Removed.
* platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Removed.
* platform/gtk/svg/custom/SVGPoint-matrixTransform-expected.txt:
* platform/gtk/svg/custom/getTransformToElement-expected.txt:
* platform/gtk/svg/custom/text-ctm-expected.txt:
* platform/gtk/svg/custom/text-hit-test-expected.txt:
* platform/gtk/svg/text/append-text-node-to-tspan-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122114

Reviewed by Darin Adler.

After r156590, four IndexedDB interfaces are inheriting from the EventTarget interface. Because of that,
they're now required to have interface-specific JSC wrapping and unwrapping functions generated since the
JSC wrapping and unwrapping functions for the EventTarget interface delegate these operations to these
interface-specific functions. If the functions are not generated and accessible, the EventTarget functions
end up recursively calling themselves.

* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBOpenDBRequest.idl:
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.idl:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122139

Reviewed by Anders Carlsson.

Get rid of more uses of OwnPtr and PassOwnPtr.

Source/WebCore:

* platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::beginPaint):
* platform/graphics/surfaces/GraphicsSurface.h:
* platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
* platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):

Source/WebKit2:

* Shared/API/c/cairo/WKImageCairo.cpp:
(WKImageCreateFromCairoSurface):
* Shared/API/c/qt/WKImageQt.cpp:
(WKImageCreateFromQImage):
* Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::createGraphicsContext):
(WebKit::WebCoordinatedSurface::paintToSurface):
* Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
* Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
* Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::encodeImage):
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createDrawingAreaProxy):
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createDrawingAreaProxy):
* UIProcess/CoordinatedGraphics/WebView.h:
* WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::convertCairoSurfaceToShareableBitmap):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122126

Reviewed by Darin Adler.

Speculative partial fix.

I'm not sure if it's possible to make this test completely controlled without
DOMFrameContentLoaded support - we need to do work when the <video> element is
already present, but playback hasn't started yet. As media documents use autoplay,
there is a race between load and playing events.

* media/click-volume-bar-not-pausing-expected.txt:
* media/click-volume-bar-not-pausing.html:
  - Add video URL after initial content fully loads to avoid races with that.
  - Added some state logging for clarity.
  - Only listen for "playing" event once. If playback already started, we have a
  playing event already queued, and would add another one with pause()/play().


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=121451

Patch by Sam White <samuel_white@apple.com> on 2013-09-30
Reviewed by Chris Fleizach.

Source/WebCore:

Added AXElementBusyChanged notification that posts when aria-busy is toggled. This
enables screen readers to detect busy states without polling the focused element.

Test: platform/mac/accessibility/element-busy-changed.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChanged):
* accessibility/AXObjectCache.h:
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

Added test to verify that elements post AXElementBusyChanged notifications when aria-busy is toggled.

* platform/mac/accessibility/element-busy-changed-expected.txt: Added.
* platform/mac/accessibility/element-busy-changed.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* ewk/ewk_settings.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* GNUmakefile.list.am:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* inspector/InspectorAllInOne.cpp:
* inspector/InstrumentingAgents.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156695 268f45cc-cd09-0410-ab3c-d52691b4dbfc