1. 30 Dec, 2005 19 commits
    • ap's avatar
      - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6289 · 9bbc4e38
      ap authored
              REGRESSION: firstCharacterForRange(0, 0) returns a 0x0 rect
      
              * khtml/editing/visible_text.cpp:
              (khtml::TextIterator::rangeFromLocationAndLength):
              Only special-case (0, 0) ranges for empty documents.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bbc4e38
    • andersca's avatar
      Forgot to commit this · d166e7a8
      andersca authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d166e7a8
    • eseidel's avatar
      Bug #: 6305 · 963be3ff
      eseidel authored
      Submitted by: eseidel
      Reviewed by: ggaren
              Missing CSS Style sheets in one of the XHTML tests in WebCore
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6305
      
              * fast/parser/entities-in-xhtml.xhtml: removed <link> to css sheet
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      963be3ff
    • ggaren's avatar
      Remove conflict marker from ChangeLog · b9fc7fa2
      ggaren authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9fc7fa2
    • ggaren's avatar
      WebCore: · 3d613f1f
      ggaren authored
              Added test case for <rdar://problem/4268278> Submitting a form in onUnload event
              handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]
      
              * manual-tests/onunload-form-submit-crash.html: Added.
      
      WebKit:
      
              Reviewed by Eric.
      
              Manual testcase added:
              WebCore/manual-tests/onunload-form-submit-crash.html
      
              - Fixed <rdar://problem/4268278> Submitting a form in onUnload event
              handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]
      
              The problem is that the form submission in the unload event kicks off
              a new load in the midst of the load that caused the unload event to
              fire in the first place, so the two loads stomp each other.
      
              The solution is to cancel the first load and let the unload handler's
              load win. (Firefox does the same.)
      
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _transitionToCommitted:]): Moved call to -closeURL up
              the call stack to _continueLoadRequest. (See below.) This has the
              side-effect of always firing the unload event, even if the new
              datasource never becomes committed, which seems like a good thing.
      
              (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
              Call -closeURL here, instead of in _transitionToCommitted,  so that the
              unload handler can fire before we initialize any part of the load.
      
              Check provisionalDataSource for nil to discover if the unload event
              kicked off its own load.
      
              Cleared up some coments.
      
              (-[WebFrame _detachFromParent]):
              It turns out that if you close the window instead of just navigating
              to a new page, you get an alternate assertion failure/crash because
              the load kicked off by the unload event handler generates resource
              loader callbacks after the associated WebFrame/WebView has disappeared.
      
              The nifty solution here is just to reverse the order of calls to
              -stopLoading and -closeURL, thus guaranteeing that -stopLoading has the
              last word when you close a window.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d613f1f
    • andersca's avatar
      2005-12-30 Anders Carlsson <andersca@mac.com> · 79f068c6
      andersca authored
              Reviewed by Eric.
      
      		- Update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6297
              XMLSerializer should use createMarkup
      
              * fast/dom/XMLSerializer.html:
              * fast/dom/XMLSerializer-expected.txt:
              Create a document fragment and serialize it.
      
              * fast/dom/dom-parse-serialize.html:
              * fast/dom/dom-parse-serialize-expected.txt:
              Add some entities to attributes and text nodes.
      
              * fast/xsl/xslt-processer-expected.txt:
              Update test results.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79f068c6
    • andersca's avatar
      2005-12-30 Anders Carlsson <andersca@mac.com> · e1be1a16
      andersca authored
              Reviewed by Eric.
      
      		- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6297
      		XMLSerializer should use createMarkup.
      
              * khtml/ecma/xmlserializer.cpp:
              (KJS::XMLSerializerProtoFunc::callAsFunction):
      		Use createMarkup instead of NodeImpl::toString.
      
              * khtml/editing/markup.cpp:
              (khtml::startMarkup):
      		escape attribute values and ignore document fragment nodes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1be1a16
    • mjs's avatar
      No review, just test result update. · bb900e13
      mjs authored
              * tests/mozilla/expected.html: Updated for newly passing test from recent fixes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb900e13
    • eseidel's avatar
      Bug #: 6299 · a55f252f
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              No functional changes, thus no layout test.
      
              Just removes debug NSLog() calls from ksvg2/kcanvas.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6299
      
              * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
              (KCanvasFilterQuartz::prepareFilter):
              (KCanvasFilterQuartz::applyFilter):
              (KCanvasFilterQuartz::getCIFilterStack):
              (KCanvasFilterQuartz::imageForName):
              (KCanvasFEBlendQuartz::getCIFilter):
              (KCanvasFEColorMatrixQuartz::getCIFilter):
              (KCanvasFEGaussianBlurQuartz::getCIFilter):
              * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
              (KCanvasClipperQuartz::applyClip):
              * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
              (KRenderingDeviceContextQuartz::mapFromVisual):
              (KRenderingDeviceContextQuartz::mapToVisual):
              (KRenderingDeviceQuartz::createResource):
              (KRenderingDeviceQuartz::createFilterEffect):
              * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
              (drawShadingWithStyle):
              (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
              * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
              (KRenderingPaintServerPatternQuartz::draw):
              * ksvg2/svg/svgpathparser.cpp:
              (SVGPathParser::parseSVG):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a55f252f
    • andersca's avatar
      2005-12-30 Anders Carlsson <andersca@mac.com> · 2a90f8ff
      andersca authored
              Reviewed by Maciej.
      
      		- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6298
      		Getter setter test is failing
      
              * kjs/object.cpp:
              (KJS::JSObject::put):
      		Rework the getter setter part. We now walk the prototype chain, checking for
      		getter/setter properties and only take the slow path if any are found.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a90f8ff
    • eseidel's avatar
      Bug #: none · a4aa18fc
      eseidel authored
      Submitted by: eseidel
      Reviewed by: No review, just adding a couple missing results.
              One missing pixel test.
              One result which never was updated properly after rounded rect fix:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6157
      
              * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
              * fast/parser/xhtml-alternate-entities-expected.checksum: Added.
              * fast/parser/xhtml-alternate-entities-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4aa18fc
    • mjs's avatar
      Reviewed by Darin, landed by Maciej. · 6b58eda1
      mjs authored
      	- land test case documenting wontfix status for certain overflow/table behavior
      	http://bugzilla.opendarwin.org/show_bug.cgi?id=3505
      
              * fast/overflow/overflow-auto-table-expected.checksum: Added.
              * fast/overflow/overflow-auto-table-expected.png: Added.
              * fast/overflow/overflow-auto-table-expected.txt: Added.
              * fast/overflow/overflow-auto-table.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b58eda1
    • eseidel's avatar
      Bug #: none · 349332ec
      eseidel authored
      Submitted by: eseidel
      Reviewed by: none, just updating stale results
              No review, updating stale results.
              I went over all the interesting ones with mjs and hyatt.
      
              * css2.1/t040304-c64-uri-00-a-g-expected.checksum:
              * css2.1/t040304-c64-uri-00-a-g-expected.png:
              * css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum:
              * css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
              * css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
              * css2.1/t100801-c544-valgn-02-d-agi-expected.png:
              * dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum:
              * dom/xhtml/level2/html/HTMLBaseElement02-expected.png:
              * dom/xhtml/level2/html/frame-expected.checksum:
              * dom/xhtml/level2/html/frame-expected.png:
              * dom/xhtml/level2/html/iframe-expected.checksum:
              * dom/xhtml/level2/html/iframe-expected.png:
              * editing/selection/extend-by-word-002-expected.checksum:
              * editing/selection/extend-by-word-002-expected.png:
              * fast/css/imageTileOpacity-expected.checksum:
              * fast/css/imageTileOpacity-expected.png:
              * fast/forms/001-expected.checksum:
              * fast/forms/001-expected.png:
              * fast/frames/empty-frame-src-expected.checksum:
              * fast/frames/empty-frame-src-expected.png:
              * fast/frames/invalid-expected.checksum:
              * fast/frames/invalid-expected.png:
              * fast/frames/valid-expected.checksum:
              * fast/frames/valid-expected.png:
              * svg/custom/conditional-processing-outside-switch-expected.txt:
              * svg/custom/control-points-for-S-and-T-expected.txt:
              * svg/custom/fill-update-expected.txt:
              * svg/custom/junk-data-expected.txt:
              * svg/custom/missing-xlink-expected.txt:
              * svg/custom/path-bad-data-expected.txt:
              * svg/custom/path-update-expected.txt:
              * svg/custom/simpleCDF-expected.txt:
              * svg/custom/transform-ignore-after-invalid-expected.txt:
              * svg/custom/transform-invalid-expected.txt:
              * svg/custom/transform-with-ending-space-expected.txt:
              * svg/custom/use-forward-refs-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      349332ec
    • mjs's avatar
      No review. · 21d8bcb5
      mjs authored
      	- updated test results for Number.toString() fixes:
      	<http://bugzilla.opendarwin.org/show_bug.cgi?id=6259>
      
              * fast/js/kde/Number-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21d8bcb5
    • mjs's avatar
      Reviewed and committed by Maciej. · b98d7720
      mjs authored
      	- Handle negative, FP numbers with non-10 radix in toString
      	http://bugzilla.opendarwin.org/show_bug.cgi?id=6259
      
              (Merged from KJS, original work by Harri Porten)
      
              * kjs/number_object.cpp:
              (NumberProtoFunc::callAsFunction): rewrote Number.toString(radix) to work with
      	negative numbers, floating point and very large numbers.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b98d7720
    • eseidel's avatar
      Bug #: 6155 · 1ca0b85a
      eseidel authored
      Submitted by: eseidel
      Reviewed by: none, just updating pixel results
              Updating results, after landing color-matching change.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6155
      
              * svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
              * svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
              * svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
              * svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
              * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
              * svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
              * svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
              * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
              * svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
              * svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
              * svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
              * svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
              * svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
              * svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
              * svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
              * svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
              * svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
              * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.checksum:
              * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
              * svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
              * svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
              * svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
              * svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
              * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
              * svg/custom/conditional-processing-outside-switch-expected.checksum:
              * svg/custom/conditional-processing-outside-switch-expected.png:
              * svg/custom/control-points-for-S-and-T-expected.checksum:
              * svg/custom/control-points-for-S-and-T-expected.png:
              * svg/custom/fill-update-expected.checksum:
              * svg/custom/fill-update-expected.png:
              * svg/custom/junk-data-expected.checksum:
              * svg/custom/junk-data-expected.png:
              * svg/custom/missing-xlink-expected.checksum:
              * svg/custom/missing-xlink-expected.png:
              * svg/custom/path-bad-data-expected.checksum:
              * svg/custom/path-bad-data-expected.png:
              * svg/custom/path-update-expected.checksum:
              * svg/custom/path-update-expected.png:
              * svg/custom/simpleCDF-expected.checksum:
              * svg/custom/simpleCDF-expected.png:
              * svg/custom/simpleCDF-expected.txt:
              * svg/custom/transform-ignore-after-invalid-expected.checksum:
              * svg/custom/transform-ignore-after-invalid-expected.png:
              * svg/custom/transform-ignore-after-invalid.svg:
              * svg/custom/transform-invalid-expected.checksum:
              * svg/custom/transform-invalid-expected.png:
              * svg/custom/transform-with-ending-space-expected.checksum:
              * svg/custom/transform-with-ending-space-expected.png:
              * svg/custom/use-forward-refs-expected.checksum:
              * svg/custom/use-forward-refs-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ca0b85a
    • eseidel's avatar
      Bug #: 6157 · 3b8950ef
      eseidel authored
      Submitted by: rob buis
      Reviewed by: eseidel
              WebCore+SVG has some problems with rounded rectangles
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6157
      
              * svg/custom/rounded-rects-expected.checksum: Added.
              * svg/custom/rounded-rects-expected.png: Added.
              * svg/custom/rounded-rects-expected.txt: Added.
              * svg/custom/rounded-rects.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b8950ef
    • mjs's avatar
      Reviewed by Eric, committed by Maciej. · 075676e6
      mjs authored
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6288
                HEAD build broken 12/29/2005
      
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (overrideLayoutOperation): Use previous character from the buffer
              instead of ch which may be uninitialized on the first iteration.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      075676e6
    • eseidel's avatar
      Bug #: none · 91bbfdc6
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              Move WebView width/height logic into DumpRenderTree to support
              running the W3C SVG 1.1 tests along side other tests.  The W3C
              SVG 1.1 tests require a 480x360 view.
      
              * DumpRenderTree/DumpRenderTree.m:
              (main): don't accept width/height
              (dump): override width/height for SVG/W3C
              * Scripts/run-webkit-tests: don't pass width/height
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91bbfdc6
  2. 29 Dec, 2005 21 commits
    • darin's avatar
      LayoutTests: · c230576d
      darin authored
              Reviewed and refined by Darin.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3579
                In-place style-switching is leaving junk behind, messing up styles
      
              * fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
              * fast/css/margin-top-bottom-dynamic-expected.png: Added.
              * fast/css/margin-top-bottom-dynamic-expected.txt: Added.
              * fast/css/margin-top-bottom-dynamic.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3579
                In-place style-switching is leaving junk behind, messing up styles
      
              * khtml/rendering/render_block.h: (khtml::RenderBlock::initMaxMarginValues):
              Set all margin values in all cases.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c230576d
    • eseidel's avatar
      Bug #: none · b990c07f
      eseidel authored
      Submitted by: eseidel
      Reviewed by: No review, only removing dead code.
              * DumpKCanvasTree/DumpKCanvasTree.m: Removed.
              * DumpKCanvasTree/DumpKCanvasTree.xcodeproj/project.pbxproj: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b990c07f
    • eseidel's avatar
      Bug #: 6155 · e79fa87d
      eseidel authored
      Submitted by: eseidel
      Reviewed by: darin
              DumpRenderTree should set a consistent color profile while running
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6155
      
              Creates consistent colormatched renderings on every test machine
              using the only way possible with Tiger APIs: by setting the
              system color profile on the test machine for the duration of the
              tests.  This will (unfortunately) cause colors to change while
              running DumpRenderTree.  This can also cause "permanent" color
              changes to occur if DRT is to crash (SIGSEGV, etc.) while running.
              This is far from ideal, but it's be best way we've found to deal
              with the issue for now.
      
              * DumpRenderTree/DumpRenderTree.m:
              (restoreColorSpace):
              (setDefaultColorProfileToRGB):
              (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e79fa87d
    • eseidel's avatar
      Bug #: 6290 · d67c400f
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              XML documents with "html" in dtd name use XHTML entities when they shouldn't
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6290
      
              * fast/parser/xhtml-alternate-entities-expected.txt: Added.
              * fast/parser/xhtml-alternate-entities.xml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d67c400f
    • eseidel's avatar
      Bug #: 6290 · 1fda09d0
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              XML documents with "html" in dtd name use XHTML entities when they shouldn't
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6290
      
              * khtml/xml/xml_tokenizer.cpp:
              (khtml::externalSubsetHandler): check for exact xhtml types
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fda09d0
    • eseidel's avatar
      Bug #: 6295 · ab66b6b1
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              Close leak in CollectionInfo due to HashMap migration
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6295
      
              * khtml/html/html_miscimpl.cpp:
              (DOM::HTMLCollectionImpl::CollectionInfo::~CollectionInfo):
              * khtml/html/html_miscimpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab66b6b1
    • eseidel's avatar
      Bug #: 6101 · bf437b45
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              Leaks in XSLTProcessorImpl due to early exit in failure case
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6101
      
              * khtml/xsl/xslt_processorimpl.cpp:
              (DOM::xmlDocPtrFromNode): add "shouldDelete" argument
              (DOM::XSLTProcessorImpl::transformToString): delete new'd xmlDoc
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf437b45
    • mjs's avatar
      WebCore: · 6b709be4
      mjs authored
              Reviewed by Eric.
      
              - finished frame traversal cleanup
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6293
      
              * kwq/WebCoreBridge.h: Removed childFrames method from WebCoreBridge protocol
      	since it is not actually used.
      
      WebKit:
      
              Reviewed by Eric.
      
              - finished frame traversal cleanup
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6293
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge childFrames]): Removed (this was unused)
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _removeChild::]): Moved to FrameTraversal category.
              (-[WebFrame _childFrameCount]): New frame traversal method to avoid
      	getting the count from the array directly.
              (-[WebFrame _appendChild:]): Factored out the parts of addChild: that
      	seem directly relevant to adding a child.
              (-[WebFrame _removeChild:]): Moved to FrameTraversal category.
              (-[WebFrame _detachChildren]): Don't deallocate children array because
      	there's no particular need to.
              (-[WebFrame _setDataSource:]): make the assert use _childFrameCount
              (-[WebFrame _opened]):
              (-[WebFrame _checkLoadComplete]): Instead of checking all frames starting
      	from the main frame, check this frame and all ancestors. If a resource
      	for a frame completes, that con only possibly finish loading for that
      	frame and its ancestors, not any other frame in the tree.
      	(-[WebFrame _recursiveCheckLoadComplete]): Removed, no longer needed.
              (-[WebFrame _childFramesMatchItem:]): Get child frame count in the new
      	approved way.
              (-[WebFrame _internalChildFrames]): removed
      	(-[WebFrame _addChild:]): Use _appendChild: for most of the work.
              (-[WebFrame _generateFrameName]): Get child frame count in the new
      	approved way.
              (-[WebFrame _stopLoadingSubframes]): Use new frame traversal mechanisms,
      	upon further consideration there's no need to copy part of the frame tree here.
              (-[WebFrame findFrameNamed:]): Remove extra braces.
              (-[WebFrame childFrames]): Make a new array using the frame traversal methods.
              * WebView.subproj/WebFramePrivate.h: Remove some methods.
              * WebView.subproj/WebMainResourceLoader.m:
              (-[WebMainResourceLoader didReceiveResponse:]): Do _checkLoadComplete on the current
      	frame not the main frame (before there was no difference and now the new version is
      	what is desired).
              * WebView.subproj/WebView.m:
              (-[WebView _finishedLoadingResourceFromDataSource:]): Remove stray space
              (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]): Remove stray spaces
      	and update FIXME comment.
              (-[WebView _receivedError:fromDataSource:]): Remove stray space
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b709be4
    • eseidel's avatar
      Bug #: 6230 · 07480eea
      eseidel authored
      Submitted by: eseidel
      Reviewed by: build fix only.
              File accidentally omitted from previous commit.
      
              Remove QDict from khtml/html
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6230
      
              * khtml/ecma/kjs_html.cpp:
              (KJS::KJS::HTMLCollection::getNamedItems):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07480eea
    • eseidel's avatar
      Bug #: 6230 · 31504afb
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              Remove QDict from khtml/html
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6230
              Uses HashMap instead.
      
              * khtml/html/html_miscimpl.cpp:
              (DOM::HTMLCollectionImpl::CollectionInfo::CollectionInfo):
              (DOM::HTMLCollectionImpl::CollectionInfo::reset):
              (DOM::HTMLCollectionImpl::namedItem):
              (DOM::HTMLCollectionImpl::updateNameCache):
              (DOM::HTMLCollectionImpl::namedItems):
              (DOM::HTMLCollectionImpl::nextNamedItem):
              (DOM::HTMLFormCollectionImpl::nextNamedItemInternal):
              (DOM::HTMLFormCollectionImpl::updateNameCache):
              * khtml/html/html_miscimpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31504afb
    • eseidel's avatar
      Bug #: 6228 · ccbf3d76
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              DOMString/DOMStringImpl/AtomicString need enhancements before replacing QString
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6228
              Added find(), contains(), startsWith() and endsWith() to DOMString
              Uses the above functions throughout the code.
              Small performance boost.
      
              * khtml/css/css_base.cpp:
              (CSSSelector::print):
              * khtml/css/css_ruleimpl.cpp:
              (DOM::CSSImportRuleImpl::init):
              * khtml/css/css_valueimpl.cpp:
              (DOM::CSSStyleDeclarationImpl::setProperty):
              * khtml/css/cssparser.cpp:
              (CSSParser::parseValue):
              (CSSParser::parseDeclaration):
              (CSSParser::parseContent):
              * khtml/css/cssstyleselector.cpp:
              (khtml::CSSStyleSelector::CSSStyleSelector):
              (khtml::CSSStyleSelector::setEncodedURL):
              (khtml::parseUASheet):
              (khtml::cleanpath):
              (khtml::CSSStyleSelector::checkSelector):
              (khtml::CSSStyleSelector::checkOneSelector):
              (khtml::CSSRuleSet::addRulesFromSheet):
              (khtml::CSSStyleSelector::applyProperty):
              * khtml/dom/dom_string.cpp:
              * khtml/dom/dom_string.h:
              (DOM::DOMString::contains):
              (DOM::DOMString::find):
              (DOM::DOMString::startsWith):
              (DOM::DOMString::endsWith):
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLFormElementImpl::parseEnctype):
              * khtml/khtml_part.cpp:
              (KHTMLPart::requestFrame):
              (KHTMLPart::submitForm):
              * khtml/misc/decoder.cpp:
              (Decoder::decode):
              * khtml/xml/dom_atomicstring.h:
              (DOM::AtomicString::length):
              (DOM::AtomicString::operator []):
              (DOM::AtomicString::contains):
              (DOM::AtomicString::find):
              (DOM::AtomicString::startsWith):
              (DOM::AtomicString::endsWith):
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::processHttpEquiv):
              * khtml/xml/dom_stringimpl.cpp:
              (DOM::equal):
              (DOM::equalCaseInsensitive):
              (DOM::DOMStringImpl::find):
              (DOM::DOMStringImpl::endsWith):
              * khtml/xml/dom_stringimpl.h:
              (DOM::DOMStringImpl::startsWith):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccbf3d76
    • eseidel's avatar
      Bug #: 6157 · b401952a
      eseidel authored
      Submitted by: rob buis
      Reviewed by: eseidel
              WebCore+SVG has some problems with rounded rectangles
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6157
      
              * ksvg2/svg/SVGRectElementImpl.cpp:
              (SVGRectElementImpl::toPathData): fixed round rect calculations
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b401952a
    • eseidel's avatar
      Bug #: 4301 · eee032ed
      eseidel authored
      Submitted by: mark rowe
      Reviewed by: eseidel
              http://bugzilla.opendarwin.org/show_bug.cgi?id=4301
              Support HTML entities on pages parsed as XHTML
      
              * fast/parser/entities-in-xhtml-expected.txt: Added.
              * fast/parser/entities-in-xhtml.xhtml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eee032ed
    • ggaren's avatar
      Updated test results for the last few JavaScriptCore patches · 38688496
      ggaren authored
              I checked in.
      
              * ChangeLog:
              * fast/js/array-float-delete-expected.txt: Added.
              * fast/js/kde/Date-expected.txt:
              * fast/js/kde/Number-expected.txt:
              * fast/js/kde/StringObject-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38688496
    • mjs's avatar
      Reviewed by Darin. · 5be51885
      mjs authored
      	- abstract frame traversal in WebFrame more
      	http://bugzilla.opendarwin.org/show_bug.cgi?id=6283
      
      	Rewrote most of the frame traversal code in WebFrame to use DOM-style
      	first/last/next/previous methods, to abstract access better in preparation
      	for moving it down.
      
      	As an added bonus, many formerly recursive methods are now iterative.
      
              * WebKit.xcodeproj/project.pbxproj: Use gnu99 dialect of C, so that
      	variables can be declared in for loop initializers.
      
      	- added new frame traversal methods, to avoid dealing with the children array
      	directly:
      
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _firstChildFrame]): New method.
              (-[WebFrame _lastChildFrame]): New method.
              (-[WebFrame _previousSiblingFrame]): New method.
              (-[WebFrame _nextSiblingFrame]): New method.
              (-[WebFrame _traverseNextFrameStayWithin:]): Like traverseNextNode() in the DOM;
      	uses some of the previous.
      
      	- apply the new methods
      
              (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Rewrite loop
      	to use new traversal methods.
              (-[WebFrame _immediateChildFrameNamed:]): ditto, also added FIXME
              (-[WebFrame _setName:]): Improved comment, removed gratuitous brace
              (-[WebFrame _isDescendantOfFrame:]): Rewrote to chase parent pointers instead
      	of looking in child arrays (duh)
              (-[WebFrame _detachChildren]): Rewrite loop to use new traversal methods,
      	still walk backwards for now.
              (-[WebFrame _closeOldDataSources]): Rewrite using new traversal methods.
              (-[WebFrame _childFramesMatchItem:]): ditto
              (-[WebFrame _defersCallbacksChanged]): ditto
              (-[WebFrame _viewWillMoveToHostWindow:]): ditto
              (-[WebFrame _viewDidMoveToHostWindow]): ditto
              (-[WebFrame _addChild:]): don't use childFrames method
              (-[WebFrame _removeChild:]): Clear out the sibling pointers after unlinking from the list,
      	not obvious if anything needs this but it seems like the right thing to do.
              (-[WebFrame _generateFrameName]): don't bother to nil-check children array, since
      	calling count on nil still gives 0.
              (-[WebFrame _saveDocumentAndScrollState]): Rewrite to use frame traversal methods
              (-[WebFrame _deepLastChildFrame]): renamed from _lastChildFrame, rewrite to use child
      	traversal methods.
              (-[WebFrame _nextFrameWithWrap:]): Use new frame traversal stuff (mostly just
      	a thin wrapper on _traverseNextFrameStayWithin:
              (-[WebFrame _previousFrameWithWrap:]): Use new traversal functions
              (-[WebFrame _numPendingOrLoadingRequests:]): Rewrite loop with new tracrsal functions
              (-[WebFrame _reloadForPluginChanges]): ditto
              (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): ditto
              (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): ditto
              (-[WebFrame _documentViews]): ditto
              (-[WebFrame _updateDrawsBackground]): ditto
              (-[WebFrame _unmarkAllMisspellings]): ditto
              (-[WebFrame _atMostOneFrameHasSelection]): ditto
              (-[WebFrame _findFrameWithSelection]): ditto
              (-[WebFrame _stopLoadingSubframes]): ditto
              (-[WebFrame _subframeIsLoading]): ditto
              (-[WebFrame _descendantFrameNamed:sourceFrame:]): ditto
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5be51885
    • eseidel's avatar
      Bug #: 4301 · c5f7f219
      eseidel authored
      Submitted by: mark rowe
      Reviewed by: eseidel, ggaren, darin
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=4301
              Support HTML entities on pages parsed as XHTML
      
              Added layout tests:
              * fast/parser/entities-in-xhtml.xhtml
      
              * khtml/xml/xml_tokenizer.cpp:
              (khtml::XMLTokenizer::setIsXHTMLDocument): Track whether the XML document is XHTML.
              (khtml::XMLTokenizer::isXHTMLDocument): Ditto.
              (khtml::externalSubsetHandler): Ditto.
              (khtml::XMLTokenizer::finish): Ditto.
              (khtml::getXHTMLEntity): Look up the HTML entity.
              (khtml::getEntityHandler): Look up the HTML entity if this is an XHTML document.
              * khtml/html/kentities.h: Added.
              * khtml/html/kentities.gperf: changed entity to Entity
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5f7f219
    • darin's avatar
      * WebView.subproj/WebFrameView.m: (-[WebFrameViewPrivate dealloc]): · ad050b6a
      darin authored
              Removed unused "draggingTypes" instance variable.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad050b6a
    • ggaren's avatar
      Patch by Maks Orlovich, reviewed and landed by me. · ecfaa4c3
      ggaren authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=6267
              Fix Number.prototype.toFixed/toExponential(undefined)
      
              * kjs/number_object.cpp:
              (NumberProtoFunc::callAsFunction):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecfaa4c3
    • ggaren's avatar
      Patch by Maks Orlovich, Reviewed and landed by me. · d28fe14b
      ggaren authored
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6266
              Minor object naming updates (to match Mozilla, KJS)
      
              * kjs/number_object.cpp:
              * kjs/regexp_object.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d28fe14b
    • ggaren's avatar
      Patch by Maks Orlovich, reviewed by mjs. · c17d9841
      ggaren authored
              This has 2 very minor fixes, covered by KJS testsuite:
              1. Enumerates string indices in property list (with the same bug as array
                 object has in corresponding code). This is a mozilla emulation thing.
              2. Permits properties with integer names in prototypes to be found
      
              * kjs/string_object.cpp:
              (StringInstance::getOwnPropertySlot):
              (StringInstanceImp::propList):
              * kjs/string_object.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c17d9841
    • ggaren's avatar
      forgot to remove the redundant (float) cast, as specified by reviewer · bd8b1c5e
      ggaren authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd8b1c5e