1. 10 Apr, 2013 40 commits
    • andersca@apple.com's avatar
      Remove unneeded headers from FrameLoader.h · 9b9d83ba
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114223
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      Update for WTF changes.
      
      * bytecode/SpeculatedType.h:
      * runtime/JSCJSValue.h:
      
      Source/WebCore:
      
      Remove unneeded headers from FrameLoader.h and add them back into the respective .cpp files where needed.
      
      * dom/Document.cpp:
      * history/CachedFrame.cpp:
      * history/PageCache.cpp:
      * inspector/InspectorResourceAgent.cpp:
      * loader/DocumentLoader.cpp:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      (WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad):
      * loader/FrameLoader.h:
      (WebCore):
      (WebCore::FrameLoader::policyChecker):
      (WebCore::FrameLoader::history):
      (WebCore::FrameLoader::icon):
      * loader/MixedContentChecker.h:
      * loader/icon/IconLoader.cpp:
      * page/History.cpp:
      * page/Page.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * testing/Internals.cpp:
      
      Source/WebKit/blackberry:
      
      Include HistoryController.h from WebCore.
      
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      
      Source/WebKit/mac:
      
      Include HistoryController.h from WebCore.
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      * WebView/WebView.mm:
      
      Source/WebKit/win:
      
      Include HistoryController.h from WebCore.
      
      * WebView.cpp:
      
      Source/WebKit2:
      
      Include HistoryController.h from WebCore.
      
      * WebProcess/Plugins/PDF/SimplePDFPlugin.h:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebPage/WebPage.cpp:
      
      Source/WTF:
      
      * wtf/Forward.h:
      Add PrintStream.
      
      * wtf/HashTable.h:
      Don't include DataLog.h unless DUMP_HASHTABLE_STATS_PER_TABLE is 1.
      
      Tools:
      
      Add back headers implicitly included by other headers.
      
      * WebKitTestRunner/WorkQueueManager.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b9d83ba
    • simon.fraser@apple.com's avatar
      Minor code cleanup in AnimationBase::progress · b53ca408
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114371
      
      Reviewed by Dean Jackson.
      
      Convert some "return; else if" to just "return; if".
      
      * page/animation/AnimationBase.cpp:
      (WebCore::AnimationBase::progress):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b53ca408
    • robert@webkit.org's avatar
      Empty inline continuations should only get lineboxes if the padding applies to... · 19a94343
      robert@webkit.org authored
      Empty inline continuations should only get lineboxes if the padding applies to their side of the inline
      https://bugs.webkit.org/show_bug.cgi?id=113896
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Test: fast/inline/inline-with-empty-inline-continuations.html
      
      Where an empty inline is split across anonymous blocks we should only give lineboxes to the 'sides' of the
      inline that have borders, padding or margin.
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::shouldApplyStartBorderPaddingOrMargin):
      (WebCore):
      (WebCore::shouldApplyEndBorderPaddingOrMargin):
      (WebCore::hasInlineDirectionBordersPaddingOrMargin):
      (WebCore::alwaysRequiresLineBox):
      
      LayoutTests:
      
      * fast/inline/inline-with-empty-inline-continuations-expected.txt: Added.
      * fast/inline/inline-with-empty-inline-continuations.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19a94343
    • zoltan@webkit.org's avatar
      [CSS Exclusions] Increasing padding does not correctly layout child blocks · 98ce026c
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112929
      
      Reviewed by David Hyatt.
      
      If a child block has changed dimension inside a shape and it has affected the block siblings
      we need to relayout the content inside the shape.
      
      Source/WebCore:
      
      Test: fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout): Add condition for dimension change.
      (WebCore::RenderBlock::layoutBlock): Call updateRegionsAndExclusionsAfterChildLayout with the new parameter.
      * rendering/RenderBlock.h:
      (RenderBlock): Add extra parameter to updateRegionsAndExclusionsAfterChildLayout(...)
      
      LayoutTests:
      
      * fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98ce026c
    • ggaren@apple.com's avatar
      Removed bitrotted TimeoutChecker code · 285b5e22
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114336
      
      Reviewed by Alexey Proskuryakov.
      
      ../JavaScriptCore: 
      
      This mechanism hasn't worked for a while.
      
      MarkL is working on a new version of this feature with a distinct
      implementation.
      
      * API/APIShims.h:
      (JSC::APIEntryShim::~APIEntryShim):
      (JSC::APIEntryShim::init):
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * dfg/DFGGPRInfo.h:
      * jit/JIT.cpp:
      * jit/JIT.h:
      * jit/JITStubs.cpp:
      * jit/JITStubs.h:
      * jit/JSInterfaceJIT.h:
      (JSInterfaceJIT):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalData.h:
      * runtime/JSGlobalObject.cpp:
      * runtime/JSONObject.cpp:
      (JSC::Stringifier::appendStringifiedValue):
      (JSC::Walker::walk):
      * runtime/TimeoutChecker.cpp: Removed.
      * runtime/TimeoutChecker.h: Removed.
      
      ../WebCore: 
      
      This mechanism hasn't worked for a while.
      
      MarkL is working on a new version of this feature with a distinct
      implementation.
      
      * bindings/js/JSCallbackData.cpp:
      (WebCore::JSCallbackData::invokeCallback):
      * bindings/js/JSCustomXPathNSResolver.cpp:
      (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::commonJSGlobalData):
      * bindings/js/JSErrorHandler.cpp:
      (WebCore::JSErrorHandler::handleEvent):
      * bindings/js/JSEventListener.cpp:
      (WebCore::JSEventListener::handleEvent):
      * bindings/js/JSMutationCallback.cpp:
      (WebCore::JSMutationCallback::call):
      * bindings/js/ScheduledAction.cpp:
      (WebCore::ScheduledAction::executeFunctionInContext):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::evaluateInWorld):
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::CloneBase::CloneBase):
      (WebCore::CloneSerializer::serialize):
      (WebCore::CloneDeserializer::deserialize):
      * bindings/js/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::evaluate):
      * bindings/objc/WebScriptObject.mm:
      (-[WebScriptObject callWebScriptMethod:withArguments:]):
      (-[WebScriptObject evaluateWebScript:]):
      
      ../WebKit/blackberry: 
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPage::setTimeoutForJavaScriptExecution):
      
      ../WebKit/mac: 
      
      This mechanism hasn't worked for a while.
      
      MarkL is working on a new version of this feature with a distinct
      implementation.
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::evaluate):
      
      ../WebKit/qt: 
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::createDocumentLoader):
      
      ../WebKit2: 
      
      This mechanism hasn't worked for a while.
      
      MarkL is working on a new version of this feature with a distinct
      implementation.
      
      * WebProcess/Plugins/Netscape/NPJSObject.cpp:
      (WebKit::NPJSObject::construct):
      (WebKit::NPJSObject::invoke):
      * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
      (WebKit::NPRuntimeObjectMap::evaluate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      285b5e22
    • paroga@webkit.org's avatar
      Replace ENABLE_JAVASCRIPT_DEBUGGER preprocessor statements in IDL files with Conditional attribute · 7fad2f8a
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114352
      
      Reviewed by Timothy Hatcher.
      
      The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
      
      * page/Console.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fad2f8a
    • achicu@adobe.com's avatar
      Layers with opacity and blur filters are reported as opaque to the compositor · 0d1c0698
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114295
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Test: compositing/contents-opaque/filter.html
      
      Some filters like opacity and blur might still trigger transparency in the layer, even though the
      background is opaque. I've added the special case in RenderLayer::backgroundIsKnownToBeOpaqueInRect to check
      for filters that might have transparency. Note that this special case is required only for software drawn
      filters, as the transparency is going to be backed in the GraphicsLayer content. Composited filters can
      figure it out in the compositor.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
      
      LayoutTests:
      
      Added test to check for blur and opacity filters drawn in software mode which needs
      to force the layer report non-opaque to the compositor.
      
      * compositing/contents-opaque/filter-expected.txt: Added.
      * compositing/contents-opaque/filter.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d1c0698
    • commit-queue@webkit.org's avatar
      [Texmap] In certain situations nested blending with overflow:hidden displays clipped results · 3be5b2fd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114290
      
      Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-10
      Reviewed by Allan Sandfeld Jensen.
      
      Source/WebCore:
      
      Always apply the clip when binding a surface, even if it hasn't changed.
      Otherwise when binding a nested surface and rebinding its container surface,
      the clip wouldn't apply.
      
      Test: compositing/overlap-blending/nested-overlap-overflow.html
      
      * platform/graphics/texmap/TextureMapperGL.cpp:
      (WebCore::BitmapTextureGL::bind):
      
      LayoutTests:
      
      Added a ref-test that exposes an issue with TextureMapper overlap blending when composited.
      This ref-test does not show correct results on Mac, skipped in TestExpectations and created a bug.
      
      * compositing/overlap-blending/nested-overlap-overflow-expected.html: Added.
      * compositing/overlap-blending/nested-overlap-overflow.html: Added.
      * platform/mac/TestExpectations: Skipped new tests and created bug.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3be5b2fd
    • mrowe@apple.com's avatar
      I should know better than to lie in ChangeLog entries. · 69063d3d
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69063d3d
    • mrowe@apple.com's avatar
      <rdar://problem/13617144> WKNavigationData needs to expose the destination of the navigation · 611baa75
      mrowe@apple.com authored
      Introduce WKNavigationDataCopyNavigationDestinationURL to access the destination of the navigation.
      
      Reviewed by Darin Adler.
      
      * UIProcess/API/C/WKNavigationData.cpp:
      (WKNavigationDataCopyURL): Add a note about returning the URL from the original request for sake of
      backwards-compatibility.
      (WKNavigationDataCopyNavigationDestinationURL): Return the URL from our underlying WebNavigationDataStore.
      * UIProcess/API/C/WKNavigationData.h:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::updateGlobalHistory): Store the current URL in to the WebNavigationDataStore
      object. WKNavigationData can retrieve the value that we were previously storing here via the originalRequest.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      611baa75
    • mrowe@apple.com's avatar
      <rdar://problem/13617104> WKPageCopySessionState needs to provide more context... · e9b60189
      mrowe@apple.com authored
      <rdar://problem/13617104> WKPageCopySessionState needs to provide more context to the filter callback
      
      Introduce a new value type for WKPageSessionStateFilterCallback that represents the passing
      of whole WKBackForwardListItemRefs to the filter callback. This allows clients to consider
      more than the original URL of the item when filtering entries from the session state.
      
      Reviewed by Darin Adler.
      
      * UIProcess/API/C/WKPage.cpp:
      (WKPageGetSessionBackForwardListItemValueType): Return a static string representing our new value type.
      * UIProcess/API/C/WKPage.h:
      * UIProcess/cf/WebBackForwardListCF.cpp:
      (WebKit::WebBackForwardList::createCFDictionaryRepresentation): Call the filter function with each of the
      possible value types in turn, respecting the first false value, if any, that is returned.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9b60189
    • antti@apple.com's avatar
      Use minimal tiles during live resize · 0ba95fa8
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114364
      
      Reviewed by Darin Adler.
      
      We currently update non-visible speculative tiles during resizing. We should just drop them.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::willStartLiveResize):
      (WebCore::FrameView::willEndLiveResize):
      * page/FrameView.h:
      * rendering/RenderLayerBacking.cpp:
      (WebCore::computeTileCoverage):
              
          Use minimal coverage in live resize state.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ba95fa8
    • zandobersek@gmail.com's avatar
      [GTK] Include a crash-fixing patch for the at-spi2-atk dependency · d2eebaf3
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114365
      
      Reviewed by Martin Robinson.
      
      Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
      The patch addresses crashes in the tally_event_reply method. It is already committed into the
      at-spi2-atk source tree and will be available with the next stable release, after which the
      patch should be removed and the dependency version bumped.
      
      * gtk/jhbuild.modules:
      * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2eebaf3
    • oliver@apple.com's avatar
      REGRESSION (r148073): WebKit Nightly r148082 crashes on launch in JSObjectSetPrivate · 89afc95e
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114341
      
      Reviewed by Alexey Proskuryakov.
      
      Make JSObjectSetPrivate use uncheckedToJS as some clients
      clear their private data during finalization for some reason.
      
      * API/JSObjectRef.cpp:
      (JSObjectSetPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89afc95e
    • commit-queue@webkit.org's avatar
      Blob content type normalization. · 684fac8f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111380
      
      Patch by Victor Costan <costan@gmail.com> on 2013-04-10
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      Tests: http/tests/fast/files/blob-constructor.js
             http/tests/fileapi/xhr-send-form-data-filename-escaping.html
             http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html
      
      * WebCore.exp.in: exported Blob::isNormalizedContentType()
      * bindings/js/JSBlobCustom.cpp:
      (WebCore::JSBlobConstructor::constructJSBlob): remove checks on Blob type, BlobBuilder will normalize it
      * fileapi/Blob.cpp:
      (BlobType): utilities for normalizing a Blob's type according to the File API spec
      (WebCore::BlobType::isValid): content type validity checks in the File API spec
      (WebCore::BlobType::normalize): implements the normalization rules in the File API spec
      (WebCore::BlobType::isNormalized): useful for ASSERTing that a Blob type has been normalized
      (WebCore): implement Blob type normalization according to the File API spec
      (WebCore::Blob::Blob): normalize the Blob type in the data URL
      (WebCore::Blob::slice): normalize the Blob type argument
      * fileapi/Blob.h:
      (BlobType): utilities for normalizing a Blob's type according to the File API spec
      (WebCore::Blob::create): assert that the deserialized Blob's type was normalized
      * fileapi/File.cpp:
      (WebCore::createBlobDataForFileWithType): assert that the File's MIME type is a normalized Blob type
      * fileapi/WebKitBlobBuilder.cpp:
      (WebCore::BlobBuilder::getBlob): normalize the Blob's type before building it
      * platform/network/BlobData.h:
      (WebCore::BlobData::setContentType): assert that the Blob type has been normalized
      * platform/network/FormData.cpp:
      (WebCore::FormData::appendKeyValuePairItems): assert that Blob's type has been normalized
      * platform/network/FormDataBuilder.cpp:
      (WebCore::FormDataBuilder::addContentTypeToMultiPartHeader): assert that the Content-Type field is normalized
      * xml/XMLHttpRequest.cpp: when responseType is blob, normalize Content-Type before passing to Blob constructor
      
      LayoutTests:
      
      * http/tests/fast/files/script-tests/blob-constructor.js: added/updated test cases for Blob type normalization
      * http/tests/fast/files/blob-constructor-expected.txt: added/updated test cases for Blob type normalization
      * http/tests/fileapi/xhr-send-form-data-filename-escaping-expected.txt: Added.
      * http/tests/fileapi/xhr-send-form-data-filename-escaping.html: Added.
      * http/tests/fileapi/xhr-send-form-data-mimetype-normalization-expected.txt: Added.
      * http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html: Added.
      * http/tests/local/formdata/resources/send-form-data-common.js:
      (dumpResponse): return the HTTP response text so it can be used in JS test code
      (sendFormData): passthrough the HTTP response text returned by dumpResponse()
      (testSendingFormData): passthrough the HTTP response text returned by dumpResponse()
      * http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt: updated expectation for invalid Content-Type
      * http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt: updated expectation for invalid Content-Type
      * http/tests/xmlhttprequest/post-blob-content-type-tests.js: updated expectation for invalid Content-Type
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      684fac8f
    • simon.fraser@apple.com's avatar
      Rebaseline four tiled drawing tests affeted by r148049. · f1c46275
      simon.fraser@apple.com authored
      Move results from platform/mac/platform/mac-wk2/tiled-drawing to  platform/mac-wk2/tiled-drawing
      
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed/four-bars-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt:
      * platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt:
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Removed.
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Removed.
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Removed.
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Removed.
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Removed.
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Removed.
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Removed.
      * platform/mac/platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1c46275
    • bfulgham@webkit.org's avatar
      [WinCairo] Unreviewed build fix. Correct DropBox download link. · 3c42ab1f
      bfulgham@webkit.org authored
      * Scripts/update-webkit-wincairo-libs: Revise download URL to
      match change in DropBox server behavior.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c42ab1f
    • timothy_horton@apple.com's avatar
      TileController doesn't remove tiles when the view is resized, leading to stale content · c8ac10ce
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114323
      <rdar://problem/13520671>
      
      Reviewed by Simon Fraser.
      
      Ensure that tiles are removed if the view shrinks, so that they are not displayed
      with stale content if the view later grows again (they will not be repainted by WebCore
      while out-of-view).
      
      * platform/graphics/ca/mac/TileController.h:
      * platform/graphics/ca/mac/TileController.mm:
      (WebCore::TileController::revalidateTiles):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8ac10ce
    • jberlin@webkit.org's avatar
      Update the localizable strings file. · 4bff3db1
      jberlin@webkit.org authored
      Rubber-stamped by Dan Bernstein.
      
      * English.lproj/Localizable.strings:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bff3db1
    • paroga@webkit.org's avatar
      Replace ENABLE_CHANNEL_MESSAGING preprocessor statements in IDL files with Conditional attribute · 121ea959
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114346
      
      Reviewed by Geoffrey Garen.
      
      The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
      
      * page/DOMWindow.idl:
      * workers/WorkerContext.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      121ea959
    • eric.carlson@apple.com's avatar
      Update all float attributes in HTMLMediaElement to double · ffd4ecb5
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113615
      
      Reviewed by Geoffrey Garen
      Patch by Aaron Colwell
      
      No new tests. Primary behavior doesn't change. Just time, playbackRate, and volume precision.
      All existing LayoutTests/media tests still pass.
      
      * WebCore.exp.in: Remove function that no longer need to be exported.
      
      * html/HTMLMediaElement.cpp: Change all float attributes to double.
      * html/HTMLMediaElement.h: Ditto.
      * html/HTMLMediaElement.idl: Ditto.
      * html/MediaController.cpp: Ditto.
      * html/MediaController.h: Ditto.
      * html/MediaControllerInterface.h: Ditto.
      * html/TimeRanges.cpp: Ditto.
      * html/TimeRanges.idl: Ditto.
      * html/shadow/MediaControlElementTypes.cpp: Ditto.
      * html/shadow/MediaControlElementTypes.h: Ditto.
      * html/shadow/MediaControlElements.cpp: Ditto.
      * html/shadow/MediaControlElements.h: Ditto.
      * html/shadow/MediaControls.cpp: Ditto.
      * html/shadow/MediaControlsApple.cpp: Ditto.
      * html/shadow/MediaControlsBlackBerry.cpp: Ditto.
      * html/shadow/MediaControlsBlackBerry.h: Ditto.
      * html/shadow/MediaControlsGtk.cpp: Ditto.
      * html/track/TextTrackCue.cpp: Ditto.
      * html/track/TextTrackCue.h: Ditto.
      * platform/Clock.h: Ditto.
      * platform/ClockGeneric.cpp: Ditto.
      * platform/ClockGeneric.h: Ditto.
      * platform/graphics/MediaPlayer.cpp: Ditto.
      * platform/graphics/MediaPlayer.h: Ditto.
      * platform/graphics/MediaPlayerPrivate.h: Ditto.
      * platform/mac/PlatformClockCA.cpp: Ditto.
      * platform/mac/PlatformClockCA.h: Ditto.
      * platform/mac/PlatformClockCM.h: Ditto.
      * platform/mac/PlatformClockCM.mm: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffd4ecb5
    • paroga@webkit.org's avatar
      Replace ENABLE_MICRODATA preprocessor statements in IDL files with Conditional attribute · 1fda612f
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114349
      
      Reviewed by Geoffrey Garen.
      
      The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
      
      * dom/Document.idl:
      * html/HTMLElement.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fda612f
    • rakuco@webkit.org's avatar
      REGRESSION(r148034): IconDatabase::updateIconRecord crashes with null iconData and iconBitmap. · 2672e512
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114356
      
      Reviewed by Tim Horton.
      
      When loading an icon fails (for example, when a non-existent URI is
      passed to the loader), updateIconRecord can be called with both
      iconData and iconBitmap having no data.
      
      This used to be fine before r148034, but causes an assertion now.
      
      No new tests, existing tests such as fast/encoding/mispositioned-meta.html
      were crashing.
      
      * loader/icon/IconDatabase.cpp:
      (WebCore::IconDatabase::updateIconRecord): Change the ASSERT() to check
      for a NAND condition that only fails if both iconData and iconBitmap
      are not 0.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2672e512
    • ggaren@apple.com's avatar
      Removed an annoying message from svn-create-patch · 15e62fc5
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114332
      
      Reviewed by Alexey Proskuryakov.
      
      I see this message basically every time I write a patch, so it must not
      be true.
      
      * Scripts/svn-create-patch:
      (generateDiff):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15e62fc5
    • commit-queue@webkit.org's avatar
      [Qt] Add API in QWebSettings for setting the CSS media type · 93a2cf79
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113853
      
      Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-10
      Reviewed by Jocelyn Turcotte.
      
      * Api/qwebsettings.cpp:
      (QWebSettingsPrivate):
      (QWebSettingsPrivate::apply):
      (QWebSettings::setCSSMediaType):
      (QWebSettings::cssMediaType):
      * Api/qwebsettings.h:
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::overrideMediaType):
      * tests/qwebpage/tst_qwebpage.cpp:
      (tst_QWebPage):
      (tst_QWebPage::cssMediaTypeGlobalSetting):
      (tst_QWebPage::cssMediaTypePageSetting):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93a2cf79
    • commit-queue@webkit.org's avatar
      [Texmap] Update a dirty region which is not covered with keepRect. · 8265e4dd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113752
      
      Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-04-10
      Reviewed by Jocelyn Turcotte.
      
      There can be a dirty region which is not covered with keepRect.
      However the dirty could be inside the tile area. In this case,
      currently we ignore the dirty by intersecting with keepRect
      and the dirty region will not be invalidated until the tile is
      recreated. We must expand the keep rect to its intersecting tiles
      to make sure that the dirty region is applied to existing tiles.
      
      No tests needed, change is unobservable.
      
      * platform/graphics/TiledBackingStore.cpp:
      (WebCore::TiledBackingStore::invalidate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8265e4dd
    • l.gombos@samsung.com's avatar
      Remove ENABLE_3D_PLUGIN · e8394844
      l.gombos@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=108002
      
      Source/WebCore:
      
      Remove ENABLE_3D_PLUGIN, it was only used by Chromium.
      
      Reviewed by Antti Koivisto.
      
      No new tests, removing dead code.
      
      * loader/SubframeLoader.cpp:
      (WebCore::SubframeLoader::loadPlugin):
      
      Source/WTF:
      
      Reviewed by Antti Koivisto.
      
      Remove ENABLE_3D_PLUGIN, it was only used by Chromium.
      
      * wtf/FeatureDefines.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8394844
    • abucur@adobe.com's avatar
      [CSS Regions] Add tests for lists and counters · 916ff16b
      abucur@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103975
      
      Reviewed by Antti Koivisto.
      
      Lists and counters work correctly with regions since r148026 (http://trac.webkit.org/changeset/148026).
      This patch adds W3C formatted ref tests to our battery.
      
      * fast/regions/counters/extract-list-items-001-expected.html: Added.
      * fast/regions/counters/extract-list-items-001.html: Added.
      * fast/regions/counters/extract-list-items-002-expected.html: Added.
      * fast/regions/counters/extract-list-items-002.html: Added.
      * fast/regions/counters/extract-list-items-003-expected.html: Added.
      * fast/regions/counters/extract-list-items-003.html: Added.
      * fast/regions/counters/extract-list-items-004-expected.html: Added.
      * fast/regions/counters/extract-list-items-004.html: Added.
      * fast/regions/counters/extract-list-items-005-expected.html: Added.
      * fast/regions/counters/extract-list-items-005.html: Added.
      * fast/regions/counters/extract-list-items-006-expected.html: Added.
      * fast/regions/counters/extract-list-items-006.html: Added.
      * fast/regions/counters/extract-list-items-007-expected.html: Added.
      * fast/regions/counters/extract-list-items-007.html: Added.
      * fast/regions/counters/extract-list-items-008-expected.html: Added.
      * fast/regions/counters/extract-list-items-008.html: Added.
      * fast/regions/counters/extract-list-items-009-expected.html: Added.
      * fast/regions/counters/extract-list-items-009.html: Added.
      * fast/regions/counters/extract-list-items-010-expected.html: Added.
      * fast/regions/counters/extract-list-items-010.html: Added.
      * fast/regions/counters/extract-list-items-011-expected.html: Added.
      * fast/regions/counters/extract-list-items-011.html: Added.
      * fast/regions/counters/extract-list-items-012-expected.html: Added.
      * fast/regions/counters/extract-list-items-012.html: Added.
      * fast/regions/counters/extract-list-items-013-expected.html: Added.
      * fast/regions/counters/extract-list-items-013.html: Added.
      * fast/regions/counters/extract-list-items-014-expected.html: Added.
      * fast/regions/counters/extract-list-items-014.html: Added.
      * fast/regions/counters/extract-list-items-015-expected.html: Added.
      * fast/regions/counters/extract-list-items-015.html: Added.
      * fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Added.
      * fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Added.
      * fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Added.
      * fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Added.
      * fast/regions/counters/extract-numbered-paragraphs-expected.html: Added.
      * fast/regions/counters/extract-numbered-paragraphs.html: Added.
      * fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Added.
      * fast/regions/counters/extract-numbered-spans-display-only-some.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-001.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-002.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-003.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Added.
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Added.
      * fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Added.
      * fast/regions/counters/extract-unordered-lists-in-regions.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      916ff16b
    • zarvai@inf.u-szeged.hu's avatar
      [Qt][WK2] Unreviewed gardening. Rebaselining after r148049. · a7d844b7
      zarvai@inf.u-szeged.hu authored
      * platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7d844b7
    • commit-queue@webkit.org's avatar
      [Texmap] Hierarchy of layers with opacity may result in wrong blending. · ec0e9961
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113732
      
      Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-10
      Reviewed by Allan Sandfeld Jensen.
      
      Source/WebCore:
      
      This is a combination of three issues with nested intermediate surfaces:
      - glScissor inside an intermediate surface should not be mirrored.
      - The current surface should be passed to the next surface in paintOptions.
      - When clipping for the non-overlap region, the containing surface offset
      should be applied.
      
      Though the changes are separate, they cannot be tested separately as neither
      fixes a testable case on its own.
      
      Tests: compositing/overlap-blending/nested-non-overlap-clipping.html
             compositing/overlap-blending/nested-overlap.html
      
      * platform/graphics/texmap/TextureMapperGL.cpp:
      (WebCore::TextureMapperGL::ClipStack::reset):
      (WebCore::TextureMapperGL::ClipStack::apply):
      (WebCore::TextureMapperGL::beginPainting):
      (WebCore::BitmapTextureGL::clearIfNeeded):
      * platform/graphics/texmap/TextureMapperGL.h:
      (ClipStack):
          Do not mirror the scissor clip when painting to an FBO.
          Also a minor refactor to avoid reading the viewport values from the driver.
      
      * platform/graphics/texmap/TextureMapperLayer.cpp:
      (WebCore::TextureMapperLayer::paintUsingOverlapRegions):
          Apply the offset when clipping for a non-overlap region.
      (WebCore::TextureMapperLayer::paintIntoSurface):
          Make sure the current surface is passed to the next one.
      
      LayoutTests:
      
      Added two ref-tests for nested composited overlaps.
      This ref-test does not work on Mac due to a slight mismatch opacity value on CoreAnimation.
      A new bug has been posted, and TestExpectations has been updated.
      
      * compositing/overlap-blending/nested-non-overlap-clipping-expected.html: Added.
      * compositing/overlap-blending/nested-non-overlap-clipping.html: Added.
      * compositing/overlap-blending/nested-overlap-expected.html: Added.
      * compositing/overlap-blending/nested-overlap.html: Added.
      * platform/mac/TestExpectations: Skipped new tests and created bug.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec0e9961
    • antti@apple.com's avatar
      Create fewer tiles when page is loading · 40d6724d
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114294
      
      Source/WebCore:
      
      Reviewed by Anders Carlsson.
      
      We currently create speculative tiles immediately. Page is often changing rapidly during loading and
      keeping the speculative tiles up to date creates extra work.
      
      Tests: platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html
             platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html
      
             * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::loadProgressingStatusChanged):
      * page/FrameView.cpp:
      (WebCore::FrameView::adjustTiledBackingCoverage):
      (WebCore::FrameView::setWasScrolledByUser):
      
          User scrolling enables speculative tiling no matter what the load status.
      
      * page/FrameView.h:
      * rendering/RenderLayerBacking.cpp:
      (WebCore::computeTileCoverage):
      (WebCore::RenderLayerBacking::adjustTiledBackingCoverage):
      
          Cover only the viewport during loading.
      
      LayoutTests:
      
      Reviewed by Anders Carlsson.
      
      Reduced initial tile counts and new tests for speculative tiles.
      
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt: Added.
      * platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html: Added.
      * platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt: Added.
      * platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html: Added.
      * platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
      * platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
      * platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
      * platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40d6724d
    • mario@webkit.org's avatar
      [GTK] Add support for Page Visibility · 41e5cc3b
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97324
      
      Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-04-10
      Reviewed by Sam Weinig.
      
      .:
      
      Page Visibility has been enabled for GTK port.
      New GTK unittest has been added.
      
      * Source/autotools/SetupWebKitFeatures.m4:
      
      Source/WebKit/gtk:
      
      Implemented access to page visibility API for GTK test runner.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::setPageVisibility):
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      
      Source/WebKit2:
      
      Added new unittest to test page visibility using GTK Widget visibility API.
      
      * UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
      (testWebViewPageVisibility):
      (beforeAll):
      * UIProcess/API/gtk/tests/WebViewTest.cpp:
      (WebViewTest::showInWindow):
      * UIProcess/API/gtk/tests/WebViewTest.h:
      
      Tools:
      
      Implemented test runner API for page visibility layout tests.
      
      * DumpRenderTree/gtk/TestRunnerGtk.cpp:
      (TestRunner::resetPageVisibility):
      (TestRunner::setPageVisibility):
      * Scripts/webkitperl/FeatureList.pm:
      
      LayoutTests:
      
      * platform/gtk/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41e5cc3b
    • commit-queue@webkit.org's avatar
      [BlackBerry] RenderThemeBlackBerry: get rid of all the SKIA code · 13fcde37
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114339
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-10
      Reviewed by Carlos Garcia Campos.
      
      * platform/blackberry/RenderThemeBlackBerry.cpp:
      (WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
      (WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
      (WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
      (WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderThumb):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13fcde37
    • rakuco@webkit.org's avatar
      [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription(). · 3acc9573
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114342
      
      Reviewed by Gyuyoung Kim.
      
      Commit 148033 only added an implementation for the Mac port, which made
      other ports fail most tests since loading the injected bundle failed
      with a missing symbol.
      
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::AccessibilityUIElement::pathDescription):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3acc9573
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Rebaselining after r148049. · e7791e28
      zarvai@inf.u-szeged.hu authored
      * platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt: Removed.
      * platform/qt/compositing/iframes/page-cache-layer-tree-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt.
      * platform/qt/fast/multicol/shadow-breaking-expected.txt:
      * platform/qt/svg/css/composite-shadow-text-expected.png:
      * platform/qt/svg/css/composite-shadow-text-expected.txt:
      * platform/qt/svg/css/group-with-shadow-expected.txt:
      * platform/qt/svg/css/path-with-shadow-expected.txt:
      * platform/qt/svg/css/shadow-and-opacity-expected.txt:
      * platform/qt/svg/css/shadow-breaking-expected.png: Added.
      * platform/qt/svg/css/text-shadow-multiple-expected.txt:
      * platform/qt/transitions/svg-text-shadow-transition-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7791e28
    • commit-queue@webkit.org's avatar
      [EFL] Add spell checking option to MiniBrowser · 8cb64237
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114282
      
      Patch by Artur Moryc <a.moryc@samsung.com> on 2013-04-10
      Reviewed by Ryosuke Niwa.
      
      Spell checking is enabled by adding a flag (t/text-checking)
      with launching MiniBrowser.
      
      * MiniBrowser/efl/main.c:
      (window_create):
      (elm_main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cb64237
    • zandobersek@gmail.com's avatar
      REGRESSION (r146518): WebKit2APITests/TestInspector is failing · 0424aab5
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113281
      
      Reviewed by Darin Adler.
      
      Source/WebKit2: 
      
      Changes to the WebInspectorProxy opening processing in r146518 caused the change in how the GTK-specific
      WebInspectorProxy code operates, specifically the 'bring-to-front' signal is not emitted anymore when opening the
      inspector due to the WebInspectorProxy::bringToFront method now only bringing the inspector window to front if it exists
      and opening it (and thus unable to bring it to front) otherwise.
      
      Closing of the inspector through the didClose method is now done immediately after sending the WebInspector::Close()
      message to the WebProcess rather than waiting for the WebProcess to communicate back the order of closing. Due to this
      the relevant code in the test cases had to be changed to not run the loop but rather just check that the closing was
      successful.
      
      (InspectorTest::InspectorTest): Remove the initialization of the now redundant m_quitOnBringToFront member variable.
      (InspectorTest::bringToFront): Quit the loop without checking the removed member variable.
      (InspectorTest::closed): Do not quit the loop as it is not run anymore.
      (InspectorTest::showIdle): A helper method that asynchronously calls the webkit_web_inspector_show method, removing some
      unnecessary complexity about under what exact circumstances to quit the loop in open-window/bring-to-front callbacks.
      (InspectorTest::show): Replaces the showAndWaitUntilFinished method, adding an idle invocation of the showIdle helper
      method and running the loop.
      (InspectorTest::close): Formerly closeAndWaitUntilClosed, now does not run the loop anymore as there's no need for it.
      (testInspectorDefault): Only the window opening event is now expected upon showing the inspector for the first time.
      Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
      InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
      (CustomInspectorTest::destroyWindow): Formerly destroyWindowAndWaitUntilClosed, the closing is not asynchronous anymore
      so the loop is not run.
      (testInspectorManualAttachDetach): Only the window opening event is now expected upon showing the inspector for the first time.
      Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
      InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
      (testInspectorCustomContainerDestroyed): Adjusting callsites to use InspectorTest::show and CustomInspectorTest::destroyWindow
      instead of InspectorTest::showAndWaitUntilFinished and CustomInspectorTest::destroyWindowAndWaitUntilClosed.
      * UIProcess/WebInspectorProxy.cpp:
      (WebKit::WebInspectorProxy::show): When showing a connected WebInspectorProxy, call the bringToFront method which will
      open the inspector if it's not yet visible or bring it to the front otherwise. 
      
      Tools: 
      
      * Scripts/run-gtk-tests:
      (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0424aab5
    • zandobersek@gmail.com's avatar
      [GTK][WK2] Implement WebInspectorProxy::platformInspectedWindowWidth · e2309c42
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113498
      
      Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-10
      Reviewed by Martin Robinson.
      
      The method was introduced in r147004.
      
      * UIProcess/API/gtk/tests/TestInspector.cpp: Specify the gMinimumAttachedInspectorWidth variable, reflecting the value
      of WebInspectorProxy::minimumAttachedWidth. Use it as the width to which the inspected view should be resized in
      InspectorTest::resizeViewAndAttach.
      * UIProcess/gtk/WebInspectorProxyGtk.cpp:
      (WebKit::WebInspectorProxy::platformInspectedWindowHeight): Use the gtk_widget_get_allocated_height method to return the
      widget height.
      (WebKit::WebInspectorProxy::platformInspectedWindowWidth): Newly implemented, similarly uses the
      gtk_widget_get_allocated_width method to return the widget width.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2309c42
    • zandobersek@gmail.com's avatar
      REGRESSION (r147719): Failures in two a11y tests on GTK · fef2dd63
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114259
      
      Reviewed by Ryosuke Niwa.
      
      No new tests - covered by existing tests.
      
      Partially revert r147719, restoring the possible creation of the AXObject cache 
      and the subsequent call to its handleFocusedUIElementChanged method. Removing this
      code caused regressions in accessibility tests on the GTK port, so the comment about
      the AXObject cache is adjusted accordingly.
      
      * dom/Document.cpp:
      (WebCore::Document::setFocusedNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fef2dd63
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. Rebaselining after r148049. · 3d9a3e90
      zandobersek@gmail.com authored
      * platform/gtk/fast/multicol/shadow-breaking-expected.txt:
      * platform/gtk/svg/css/composite-shadow-text-expected.txt:
      * platform/gtk/svg/css/group-with-shadow-expected.txt:
      * platform/gtk/svg/css/path-with-shadow-expected.txt:
      * platform/gtk/svg/css/shadow-and-opacity-expected.txt:
      * platform/gtk/svg/css/shadow-changes-expected.txt:
      * platform/gtk/svg/css/text-gradient-shadow-expected.txt:
      * platform/gtk/svg/css/text-shadow-multiple-expected.txt:
      * platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt:
      * platform/gtk/transitions/svg-text-shadow-transition-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d9a3e90