1. 04 Nov, 2008 5 commits
    • andersca@apple.com's avatar
      2008-11-04 Anders Carlsson <andersca@apple.com> · 9b4c9743
      andersca@apple.com authored
              Reviewed by Kevin Decker.
              
              https://bugs.webkit.org/show_bug.cgi?id=22065
              
              Remove some old, unused plug-in code.
              
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
              (-[WebBaseNetscapePluginView start]):
              (-[WebBaseNetscapePluginView setVariable:value:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b4c9743
    • simon.fraser@apple.com's avatar
      2008-11-04 Simon Fraser <simon.fraser@apple.com> · c65d3288
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt
      
              https://bugs.webkit.org/show_bug.cgi?id=21941
      
              Rename absolutePosition() to localToAbsolute(), and add the ability
              to optionally take transforms into account (which will eventually be the
              default behavior).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c65d3288
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · c5e3f1b1
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=22030
              Make EventNames usable from multiple threads
      
              * platform/text/AtomicString.cpp:
              (WebCore::stringTable):
              (WebCore::AtomicString::add):
              (WebCore::AtomicString::remove):
              (WebCore::AtomicString::find):
              (WebCore::AtomicString::init):
              * platform/text/AtomicString.h:
              Atomic string table is now per-thread. Individual strings cannot be shared between threads,
              so global AtomicString constants cannot be used from threads other than the main one.
      
              * dom/EventNames.cpp:
              (WebCore::EventNames::EventNames):
              (WebCore::eventNames):
              (WebCore::EventNames::init):
              * dom/EventNames.h:
              Made EventNames a ThreadSpecific struct. Individual event names are now accessed as
              eventNames().fooEvent, not EventNames::fooEvent. This makes EventNames usable from all
              threads.
      
              * <Many files>: Access event names via eventNames() function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5e3f1b1
    • cwzwarich@webkit.org's avatar
      2008-11-04 Cameron Zwarich <zwarich@apple.com> · d39a1fcf
      cwzwarich@webkit.org authored
              Reviewed by Mark Rowe.
      
              Delete unused forwarding headers.
      
              WebCore:
      
              * ForwardingHeaders/kjs/Activation.h: Removed.
              * ForwardingHeaders/kjs/Register.h: Removed.
              * ForwardingHeaders/kjs/RegisterID.h: Removed.
      
              WebKit/mac:
      
              * ForwardingHeaders/kjs/string_object.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d39a1fcf
    • cwzwarich@webkit.org's avatar
      2008-11-03 Cameron Zwarich <zwarich@apple.com> · b91210c0
      cwzwarich@webkit.org authored
              Rubber-stamped by Maciej Stachowiak.
      
              Move more files into the runtime subdirectory of JavaScriptCore.
      
              JavaScriptCore:
      
              * API/JSBase.cpp:
              * API/JSCallbackConstructor.cpp:
              * API/JSCallbackFunction.cpp:
              * API/JSClassRef.cpp:
              * API/OpaqueJSString.cpp:
              * GNUmakefile.am:
              * JavaScriptCore.pri:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * JavaScriptCoreSources.bkl:
              * kjs/AllInOneFile.cpp:
              * kjs/ArgList.cpp: Removed.
              * kjs/ArgList.h: Removed.
              * kjs/Arguments.cpp: Removed.
              * kjs/Arguments.h: Removed.
              * kjs/BatchedTransitionOptimizer.h: Removed.
              * kjs/CollectorHeapIterator.h: Removed.
              * kjs/CommonIdentifiers.cpp: Removed.
              * kjs/CommonIdentifiers.h: Removed.
              * kjs/ExecState.cpp: Removed.
              * kjs/ExecState.h: Removed.
              * kjs/GetterSetter.cpp: Removed.
              * kjs/GetterSetter.h: Removed.
              * kjs/InitializeThreading.cpp: Removed.
              * kjs/InitializeThreading.h: Removed.
              * kjs/JSActivation.cpp: Removed.
              * kjs/JSActivation.h: Removed.
              * kjs/JSGlobalData.cpp: Removed.
              * kjs/JSGlobalData.h: Removed.
              * kjs/JSLock.cpp: Removed.
              * kjs/JSLock.h: Removed.
              * kjs/JSStaticScopeObject.cpp: Removed.
              * kjs/JSStaticScopeObject.h: Removed.
              * kjs/JSType.h: Removed.
              * kjs/PropertyNameArray.cpp: Removed.
              * kjs/PropertyNameArray.h: Removed.
              * kjs/ScopeChain.cpp: Removed.
              * kjs/ScopeChain.h: Removed.
              * kjs/ScopeChainMark.h: Removed.
              * kjs/SymbolTable.h: Removed.
              * kjs/Tracing.d: Removed.
              * kjs/Tracing.h: Removed.
              * runtime/ArgList.cpp: Copied from kjs/ArgList.cpp.
              * runtime/ArgList.h: Copied from kjs/ArgList.h.
              * runtime/Arguments.cpp: Copied from kjs/Arguments.cpp.
              * runtime/Arguments.h: Copied from kjs/Arguments.h.
              * runtime/BatchedTransitionOptimizer.h: Copied from kjs/BatchedTransitionOptimizer.h.
              * runtime/CollectorHeapIterator.h: Copied from kjs/CollectorHeapIterator.h.
              * runtime/CommonIdentifiers.cpp: Copied from kjs/CommonIdentifiers.cpp.
              * runtime/CommonIdentifiers.h: Copied from kjs/CommonIdentifiers.h.
              * runtime/ExecState.cpp: Copied from kjs/ExecState.cpp.
              * runtime/ExecState.h: Copied from kjs/ExecState.h.
              * runtime/GetterSetter.cpp: Copied from kjs/GetterSetter.cpp.
              * runtime/GetterSetter.h: Copied from kjs/GetterSetter.h.
              * runtime/InitializeThreading.cpp: Copied from kjs/InitializeThreading.cpp.
              * runtime/InitializeThreading.h: Copied from kjs/InitializeThreading.h.
              * runtime/JSActivation.cpp: Copied from kjs/JSActivation.cpp.
              * runtime/JSActivation.h: Copied from kjs/JSActivation.h.
              * runtime/JSGlobalData.cpp: Copied from kjs/JSGlobalData.cpp.
              * runtime/JSGlobalData.h: Copied from kjs/JSGlobalData.h.
              * runtime/JSLock.cpp: Copied from kjs/JSLock.cpp.
              * runtime/JSLock.h: Copied from kjs/JSLock.h.
              * runtime/JSStaticScopeObject.cpp: Copied from kjs/JSStaticScopeObject.cpp.
              * runtime/JSStaticScopeObject.h: Copied from kjs/JSStaticScopeObject.h.
              * runtime/JSType.h: Copied from kjs/JSType.h.
              * runtime/PropertyNameArray.cpp: Copied from kjs/PropertyNameArray.cpp.
              * runtime/PropertyNameArray.h: Copied from kjs/PropertyNameArray.h.
              * runtime/ScopeChain.cpp: Copied from kjs/ScopeChain.cpp.
              * runtime/ScopeChain.h: Copied from kjs/ScopeChain.h.
              * runtime/ScopeChainMark.h: Copied from kjs/ScopeChainMark.h.
              * runtime/SymbolTable.h: Copied from kjs/SymbolTable.h.
              * runtime/Tracing.d: Copied from kjs/Tracing.d.
              * runtime/Tracing.h: Copied from kjs/Tracing.h.
      
              WebCore:
      
              * ForwardingHeaders/kjs/ArgList.h: Removed.
              * ForwardingHeaders/kjs/CollectorHeapIterator.h: Removed.
              * ForwardingHeaders/kjs/ExecState.h: Removed.
              * ForwardingHeaders/kjs/InitializeThreading.h: Removed.
              * ForwardingHeaders/kjs/JSGlobalData.h: Removed.
              * ForwardingHeaders/kjs/JSLock.h: Removed.
              * ForwardingHeaders/kjs/SymbolTable.h: Removed.
              * ForwardingHeaders/runtime/ArgList.h: Copied from ForwardingHeaders/kjs/ArgList.h.
              * ForwardingHeaders/runtime/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/CollectorHeapIterator.h.
              * ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
              * ForwardingHeaders/runtime/InitializeThreading.h: Copied from ForwardingHeaders/kjs/InitializeThreading.h.
              * ForwardingHeaders/runtime/JSGlobalData.h: Copied from ForwardingHeaders/kjs/JSGlobalData.h.
              * ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
              * ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
              * bindings/js/GCController.cpp:
              * bindings/js/JSCustomPositionCallback.cpp:
              * bindings/js/JSCustomPositionErrorCallback.cpp:
              * bindings/js/JSCustomSQLStatementCallback.cpp:
              * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
              * bindings/js/JSCustomSQLTransactionCallback.cpp:
              * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
              * bindings/js/JSCustomVoidCallback.cpp:
              * bindings/js/JSCustomXPathNSResolver.cpp:
              * bindings/js/JSDOMWindowBase.cpp:
              * bindings/js/JSEventCustom.cpp:
              * bindings/js/JSEventListener.cpp:
              * bindings/js/JSNodeFilterCondition.cpp:
              * bindings/js/ScheduledAction.cpp:
              * bindings/js/ScriptController.cpp:
              * bindings/js/ScriptControllerMac.mm:
              * bindings/objc/WebScriptObject.mm:
              * bridge/NP_jsobject.cpp:
              * bridge/c/c_class.cpp:
              * bridge/c/c_instance.cpp:
              * bridge/c/c_runtime.cpp:
              * bridge/c/c_utility.cpp:
              * bridge/jni/jni_class.cpp:
              * bridge/jni/jni_instance.cpp:
              * bridge/jni/jni_jsobject.mm:
              * bridge/jni/jni_objc.mm:
              * bridge/jni/jni_runtime.cpp:
              * bridge/jni/jni_runtime.h:
              * bridge/jni/jni_utility.cpp:
              * bridge/npruntime.cpp:
              * bridge/objc/objc_instance.mm:
              * bridge/objc/objc_runtime.mm:
              * bridge/objc/objc_utility.mm:
              * bridge/runtime.cpp:
              * dom/Document.cpp:
              * dom/Node.cpp:
              * dom/NodeFilter.cpp:
              * dom/NodeIterator.cpp:
              * dom/TreeWalker.cpp:
              * history/CachedPage.cpp:
              * inspector/InspectorController.cpp:
              * inspector/JavaScriptCallFrame.cpp:
              * inspector/JavaScriptCallFrame.h:
              * inspector/JavaScriptDebugServer.cpp:
              * inspector/JavaScriptProfileNode.cpp:
              * loader/FrameLoader.cpp:
              * loader/icon/IconDatabase.cpp:
              * page/Console.cpp:
              * page/Page.cpp:
              * page/mac/FrameMac.mm:
              * plugins/PluginView.cpp:
              * plugins/gtk/PluginViewGtk.cpp:
              * plugins/qt/PluginViewQt.cpp:
              * plugins/win/PluginViewWin.cpp:
              * storage/Database.cpp:
              * xml/XMLHttpRequest.cpp:
      
              WebKit/gtk:
      
              * webkit/webkitprivate.cpp:
      
              WebKit/mac:
      
              * ForwardingHeaders/kjs/JSLock.h: Removed.
              * ForwardingHeaders/kjs/SymbolTable.h: Removed.
              * ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
              * ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
              * Misc/WebCoreStatistics.mm:
              * Plugins/WebBaseNetscapePluginStream.mm:
              * Plugins/WebBaseNetscapePluginView.mm:
              * Plugins/WebPluginController.mm:
              * WebView/WebFrame.mm:
              * WebView/WebScriptDebugDelegate.mm:
              * WebView/WebView.mm:
      
              WebKit/qt:
      
              * Api/qwebpage.cpp:
      
              WebKit/win:
      
              * WebJavaScriptCollector.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b91210c0
  2. 03 Nov, 2008 3 commits
    • mrowe@apple.com's avatar
      Fix the 64-bit build. · 748e44d4
      mrowe@apple.com authored
      Pull the frequently-made check for drawingModel == NPDrawingModelQuickDraw out into a
      helper function to avoid #ifdef'ing all of the new places that this check is made.
      
      A few other #ifdef's are moved inside functions to allow their call sites to remain #ifdef-free,
      and we rely on the compiler to optimise out the check (which will always be false in 64-bit) instead.
      
      * Plugins/WebBaseNetscapePluginView.mm:
      (isDrawingModelQuickDraw):
      (-[WebBaseNetscapePluginView fixWindowPort]):
      (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
      (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
      (-[WebBaseNetscapePluginView updateAndSetWindow]):
      (-[WebBaseNetscapePluginView start]):
      (-[WebBaseNetscapePluginView tellQuickTimeToChill]):
      (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
      (-[WebBaseNetscapePluginView _viewHasMoved]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      748e44d4
    • mjs@apple.com's avatar
      2008-11-03 Maciej Stachowiak <mjs@apple.com> · e618cf50
      mjs@apple.com authored
              Reviewed by Kevin Decker.
              
              - fix release build (and unitialized variable for CG drawing model!)
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): initialize portState in all code paths
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e618cf50
    • kdecker@apple.com's avatar
      Reviewed by Anders Carlsson. · eb4eabb2
      kdecker@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=22053
              
              This patch adds initial support for the NPDrawingModelCoreAnimation drawing model. 
                      
              * Plugins/WebBaseNetscapePluginView.h: Added _layer ivar.
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation.
              (-[WebBaseNetscapePluginView restorePortState:]): Ditto.
              (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): Slightly refactored a small block of code which with the PortState.
              Plug-ins using the NPDrawingModelCoreAnimation drawing model have no PortState. 
              (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation
              (-[WebBaseNetscapePluginView updateAndSetWindow]):  Ditto.
              (-[WebBaseNetscapePluginView setWindowIfNecessary]): Ditto.
              (-[WebBaseNetscapePluginView start]): If the plug-in is a plug-in using the Core Animation model, request a layer from it.
              (-[WebBaseNetscapePluginView drawRect:]): Return early for NPDrawingModelCoreAnimation plug-ins.
              (-[WebBaseNetscapePluginView getVariable:value:]): Tell plug-ins running on post-Tiger systems WebKit supports
               NPDrawingModelCoreAnimation.
              (-[WebBaseNetscapePluginView setVariable:value:]): Added the new NPDrawingModelCoreAnimation case, which initializes drawingMode.
              (-[WebBaseNetscapePluginView _viewHasMoved]): Reworded the conditional call to updateAndSetWindow to be specific to 
              CoreGraphics and QuickDraw plug-ins.
      
              Reviewed by Anders Carlsson.
      
              https://bugs.webkit.org/show_bug.cgi?id=22053
      
              Added additional support needed for the NPDrawingModelCoreAnimation drawing model. 
      
              * bridge/npapi.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb4eabb2
  3. 31 Oct, 2008 6 commits
  4. 30 Oct, 2008 2 commits
    • cwzwarich@webkit.org's avatar
      2008-10-30 Cameron Zwarich <zwarich@apple.com> · a691b5af
      cwzwarich@webkit.org authored
              Rubber-stamped by Sam Weinig.
      
              Create a debugger directory in JavaScriptCore and move the relevant
              files to it.
      
              JavaScriptCore:
      
              * GNUmakefile.am:
              * JavaScriptCore.pri:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * VM/CodeBlock.cpp:
              * VM/CodeGenerator.h:
              * VM/Machine.cpp:
              * debugger: Added.
              * debugger/Debugger.cpp: Copied from kjs/debugger.cpp.
              * debugger/Debugger.h: Copied from kjs/debugger.h.
              * debugger/DebuggerCallFrame.cpp: Copied from kjs/DebuggerCallFrame.cpp.
              * debugger/DebuggerCallFrame.h: Copied from kjs/DebuggerCallFrame.h.
              * kjs/AllInOneFile.cpp:
              * kjs/DebuggerCallFrame.cpp: Removed.
              * kjs/DebuggerCallFrame.h: Removed.
              * kjs/Parser.cpp:
              * kjs/Parser.h:
              * kjs/debugger.cpp: Removed.
              * kjs/debugger.h: Removed.
              * kjs/interpreter.cpp:
              * kjs/nodes.cpp:
              * runtime/FunctionConstructor.cpp:
              * runtime/JSGlobalObject.cpp:
      
              WebCore:
      
              * ForwardingHeaders/debugger: Added.
              * ForwardingHeaders/debugger/Debugger.h: Copied from ForwardingHeaders/kjs/debugger.h.
              * ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
              * ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
              * ForwardingHeaders/kjs/debugger.h: Removed.
              * WebCore.pro:
              * bindings/js/ScriptController.cpp:
              * inspector/JavaScriptCallFrame.cpp:
              * inspector/JavaScriptCallFrame.h:
              * inspector/JavaScriptDebugServer.cpp:
              * inspector/JavaScriptDebugServer.h:
      
              WebKit/mac:
      
              * ForwardingHeaders/debugger: Added.
              * ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
              * ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
              * WebView/WebScriptDebugDelegate.mm:
              * WebView/WebScriptDebugger.h:
              * WebView/WebScriptDebugger.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a691b5af
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · cd79e263
      andersca@apple.com authored
              Reviewed by Kevin Decker.
      
              * Plugins/WebBaseNetscapePluginStream.h:
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::WebNetscapePluginStream):
              (WebNetscapePluginStream::~WebNetscapePluginStream):
              (WebNetscapePluginStream::start):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd79e263
  5. 29 Oct, 2008 5 commits
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · 9afaff46
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove an unused forward class declaration.
              
              * Plugins/WebBaseNetscapePluginView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9afaff46
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · 4558c152
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove WebBaseNetscapePluginViewInternal.h and WebBaseNetscapePluginViewPrivate.h.
      
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginViewInternal.h: Removed.
              * Plugins/WebBaseNetscapePluginViewPrivate.h: Removed.
              * Plugins/WebNetscapePluginEventHandler.mm:
              * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
              * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
              * Plugins/npapi.mm:
              * WebView/WebHTMLView.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4558c152
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · e2b89383
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove WebNetscapePluginEmbeddedView, it adds nothing extra now. 
              
              Remove WebNetscapePlugInStreamLoaderClient since WebNetscapePluginStream is the client now.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              * Plugins/WebBaseNetscapePluginStream.mm:
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebKitPluginContainerView.h:
              * Plugins/WebNetscapePluginEmbeddedView.h: Removed.
              * Plugins/WebNetscapePluginEmbeddedView.mm: Removed.
              * Plugins/WebNetscapePluginEventHandler.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (NetscapePluginWidget::NetscapePluginWidget):
              (NetscapePluginWidget::handleEvent):
              (WebFrameLoaderClient::createPlugin):
              * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Removed.
              * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Removed.
              * WebView/WebHTMLView.mm:
              (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2b89383
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · cd46164f
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove the WebBaseNetscapePluginStream Objective-C object.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              (WebNetscapePluginStream::create):
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::WebNetscapePluginStream):
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
              (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd46164f
    • beidson@apple.com's avatar
      2008-10-29 Brady Eidson <beidson@apple.com> · 31e1eb47
      beidson@apple.com authored
              Reviewed by Sam Weinig
      
              https://bugs.webkit.org/show_bug.cgi?id=21952
              
              Address an outstanding FIXME by removing unused SPI
      
              * History/WebHistory.mm:
              (-[WebHistory _addItemForURL:title:]): Fold addItem: into this method
      
              * History/WebHistoryPrivate.h: Removed unused/unneccessary SPI
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31e1eb47
  6. 28 Oct, 2008 5 commits
    • justin.garcia@apple.com's avatar
      WebCore: · 2876864e
      justin.garcia@apple.com authored
      2008-10-28  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
      
              <rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored
      
              * editing/Editor.cpp:
              (WebCore::Editor::ignoreSpelling): Remove misspelling markers from the word.
              (WebCore::Editor::learnSpelling): Added a FIXME about <rdar://problem/5396072>, which 
              will probably require a change more complicated than just marking the learned word as 
              misspelled.  I'll address it with a separate patch.
              * editing/EditorCommand.cpp:
              (WebCore::executeIgnoreSpelling): Added.
              (WebCore::CommandEntry::): Added an entry for IgnoreSpelling.
      
      WebKit/mac:
      
      2008-10-28  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
              
              <rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored
      
              * WebView/WebHTMLView.mm: IgnoreSpelling is now a WebCore command.  That command handles
              calling back into WebKit to perform the cross platform work that was removed in this change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2876864e
    • cwzwarich@webkit.org's avatar
      2008-10-28 Cameron Zwarich <zwarich@apple.com> · ba054bbd
      cwzwarich@webkit.org authored
              Reviewed by Mark Rowe.
      
              Move ForwardingHeaders to their correct location after the creation of
              the runtime directory in JavaScriptCore.
      
              WebCore:
      
              * ForwardingHeaders/kjs/ArrayPrototype.h: Removed.
              * ForwardingHeaders/kjs/BooleanObject.h: Removed.
              * ForwardingHeaders/kjs/CallData.h: Removed.
              * ForwardingHeaders/kjs/ConstructData.h: Removed.
              * ForwardingHeaders/kjs/DateInstance.h: Removed.
              * ForwardingHeaders/kjs/Error.h: Removed.
              * ForwardingHeaders/kjs/FunctionConstructor.h: Removed.
              * ForwardingHeaders/kjs/FunctionPrototype.h: Removed.
              * ForwardingHeaders/kjs/InternalFunction.h: Removed.
              * ForwardingHeaders/kjs/JSArray.h: Removed.
              * ForwardingHeaders/kjs/JSFunction.h: Removed.
              * ForwardingHeaders/kjs/JSGlobalObject.h: Removed.
              * ForwardingHeaders/kjs/JSNumberCell.h: Removed.
              * ForwardingHeaders/kjs/JSObject.h: Removed.
              * ForwardingHeaders/kjs/JSString.h: Removed.
              * ForwardingHeaders/kjs/JSValue.h: Removed.
              * ForwardingHeaders/kjs/ObjectPrototype.h: Removed.
              * ForwardingHeaders/kjs/PropertyMap.h: Removed.
              * ForwardingHeaders/kjs/PrototypeFunction.h: Removed.
              * ForwardingHeaders/kjs/StringObject.h: Removed.
              * ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
              * ForwardingHeaders/kjs/StringPrototype.h: Removed.
              * ForwardingHeaders/kjs/StructureID.h: Removed.
              * ForwardingHeaders/runtime: Added.
              * ForwardingHeaders/runtime/ArrayPrototype.h: Copied from ForwardingHeaders/kjs/ArrayPrototype.h.
              * ForwardingHeaders/runtime/BooleanObject.h: Copied from ForwardingHeaders/kjs/BooleanObject.h.
              * ForwardingHeaders/runtime/CallData.h: Copied from ForwardingHeaders/kjs/CallData.h.
              * ForwardingHeaders/runtime/ConstructData.h: Copied from ForwardingHeaders/kjs/ConstructData.h.
              * ForwardingHeaders/runtime/DateInstance.h: Copied from ForwardingHeaders/kjs/DateInstance.h.
              * ForwardingHeaders/runtime/Error.h: Copied from ForwardingHeaders/kjs/Error.h.
              * ForwardingHeaders/runtime/FunctionConstructor.h: Copied from ForwardingHeaders/kjs/FunctionConstructor.h.
              * ForwardingHeaders/runtime/FunctionPrototype.h: Copied from ForwardingHeaders/kjs/FunctionPrototype.h.
              * ForwardingHeaders/runtime/InternalFunction.h: Copied from ForwardingHeaders/kjs/InternalFunction.h.
              * ForwardingHeaders/runtime/JSArray.h: Copied from ForwardingHeaders/kjs/JSArray.h.
              * ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
              * ForwardingHeaders/runtime/JSGlobalObject.h: Copied from ForwardingHeaders/kjs/JSGlobalObject.h.
              * ForwardingHeaders/runtime/JSNumberCell.h: Copied from ForwardingHeaders/kjs/JSNumberCell.h.
              * ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
              * ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
              * ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
              * ForwardingHeaders/runtime/ObjectPrototype.h: Copied from ForwardingHeaders/kjs/ObjectPrototype.h.
              * ForwardingHeaders/runtime/PropertyMap.h: Copied from ForwardingHeaders/kjs/PropertyMap.h.
              * ForwardingHeaders/runtime/PrototypeFunction.h: Copied from ForwardingHeaders/kjs/PrototypeFunction.h.
              * ForwardingHeaders/runtime/StringObject.h: Copied from ForwardingHeaders/kjs/StringObject.h.
              * ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h.
              * ForwardingHeaders/runtime/StringPrototype.h: Copied from ForwardingHeaders/kjs/StringPrototype.h.
              * ForwardingHeaders/runtime/StructureID.h: Copied from ForwardingHeaders/kjs/StructureID.h.
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
              * bindings/js/JSClipboardCustom.cpp:
              * bindings/js/JSConsoleCustom.cpp:
              * bindings/js/JSCustomPositionCallback.h:
              * bindings/js/JSCustomPositionErrorCallback.h:
              * bindings/js/JSCustomSQLStatementCallback.h:
              * bindings/js/JSCustomSQLStatementErrorCallback.h:
              * bindings/js/JSCustomSQLTransactionErrorCallback.h:
              * bindings/js/JSCustomVoidCallback.h:
              * bindings/js/JSCustomXPathNSResolver.h:
              * bindings/js/JSDOMBinding.cpp:
              * bindings/js/JSDOMBinding.h:
              * bindings/js/JSDOMGlobalObject.h:
              * bindings/js/JSDOMWindowBase.cpp:
              * bindings/js/JSDOMWindowCustom.cpp:
              * bindings/js/JSDOMWindowShell.cpp:
              * bindings/js/JSDatabaseCustom.cpp:
              * bindings/js/JSEventListener.cpp:
              * bindings/js/JSEventTarget.h:
              * bindings/js/JSHTMLDocumentCustom.cpp:
              * bindings/js/JSHistoryCustom.cpp:
              * bindings/js/JSInspectedObjectWrapper.cpp:
              * bindings/js/JSJavaScriptCallFrameCustom.cpp:
              * bindings/js/JSLocationCustom.cpp:
              * bindings/js/JSNodeFilterCondition.h:
              * bindings/js/JSQuarantinedObjectWrapper.cpp:
              * bindings/js/JSQuarantinedObjectWrapper.h:
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
              * bindings/objc/WebScriptObject.mm:
              * bindings/objc/WebScriptObjectPrivate.h:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bridge/NP_jsobject.cpp:
              * bridge/c/c_instance.cpp:
              * bridge/c/c_utility.cpp:
              * bridge/c/c_utility.h:
              * bridge/jni/jni_instance.cpp:
              * bridge/jni/jni_jsobject.h:
              * bridge/jni/jni_jsobject.mm:
              * bridge/jni/jni_runtime.cpp:
              * bridge/jni/jni_utility.cpp:
              * bridge/jni/jni_utility.h:
              * bridge/objc/objc_instance.mm:
              * bridge/objc/objc_runtime.h:
              * bridge/objc/objc_runtime.mm:
              * bridge/objc/objc_utility.h:
              * bridge/objc/objc_utility.mm:
              * bridge/runtime.h:
              * bridge/runtime_array.cpp:
              * bridge/runtime_array.h:
              * bridge/runtime_method.cpp:
              * bridge/runtime_method.h:
              * bridge/runtime_object.cpp:
              * bridge/runtime_object.h:
              * bridge/runtime_root.cpp:
              * inspector/JavaScriptCallFrame.cpp:
              * inspector/JavaScriptProfile.cpp:
              * inspector/JavaScriptProfile.h:
              * inspector/JavaScriptProfileNode.cpp:
              * inspector/JavaScriptProfileNode.h:
              * loader/FrameLoader.cpp:
              * page/Console.cpp:
              * plugins/PluginView.cpp:
              * plugins/gtk/PluginViewGtk.cpp:
              * plugins/qt/PluginViewQt.cpp:
              * plugins/win/PluginViewWin.cpp:
      
              WebKit/mac:
      
              * ForwardingHeaders/kjs/JSFunction.h: Removed.
              * ForwardingHeaders/kjs/JSObject.h: Removed.
              * ForwardingHeaders/kjs/JSString.h: Removed.
              * ForwardingHeaders/kjs/JSValue.h: Removed.
              * ForwardingHeaders/runtime: Added.
              * ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
              * ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
              * ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
              * ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
              * WebView/WebScriptDebugDelegate.mm:
              * WebView/WebScriptDebugger.mm:
              * WebView/WebView.mm:
      
              WebKit/win:
      
              * WebScriptCallFrame.h:
      
              WebKit/wx:
      
              * WebFrame.cpp:
              * WebView.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba054bbd
    • adele@apple.com's avatar
      WebCore: · dfda2f4f
      adele@apple.com authored
      2008-10-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by John Sullivan.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
              "files" string for multifile uploads needs to be localized
      
              * page/mac/WebCoreViewFactory.h:
              * platform/LocalizedStrings.h:
              * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
              * platform/gtk/LocalizedStringsGtk.cpp: (WebCore::multipleFileUploadText):
              * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth):
              * platform/mac/LocalizedStringsMac.mm: (WebCore::multipleFileUploadText):
              * platform/qt/Localizations.cpp: (WebCore::multipleFileUploadText):
              * platform/wx/LocalizedStringsWx.cpp: (WebCore::multipleFileUploadText):
      
      WebKit:
      
      2008-10-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by John Sullivan.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
              "files" string for multifile uploads needs to be localized
      
              * English.lproj/Localizable.strings: Updated with new string.
      
      WebKit/mac:
      
      2008-10-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by John Sullivan.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
              "files" string for multifile uploads needs to be localized
      
              * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory multipleFileUploadTextForNumberOfFiles:]):
              Added.
      
      WebKit/win:
      
      2008-10-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by John Sullivan.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
              "files" string for multifile uploads needs to be localized
      
              * WebCoreLocalizedStrings.cpp: (multipleFileUploadText):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfda2f4f
    • timothy@apple.com's avatar
      Make the JavaScript profiler opt-in, so it does not slow down JavaScript all the time. · 7dec1b92
      timothy@apple.com authored
      Make the Profiles panel in the Web Inspector have an enable screen.
      Profiling now needs to be enabled before console.profile() works.
      
      WebCore:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Make the Profiles panel in the Web Inspector have an enable screen.
              Profiling now needs to be enabled before console.profile() works.
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * English.lproj/localizedStrings.js: New strings.
              * WebCore.base.exp: New and changed exports.
              * WebCore.vcproj/WebCore.vcproj: Add the PanelEnablerView.js file.
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::supportsProfiling): Call InspectorController:profilerEnabled.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController): Initialize the m_startProfiling
              Timer to call InspectorController::startUserInitiatedProfiling.
              (WebCore::InspectorController::startUserInitiatedProfilingSoon): Start a one-shot timer
              that calls InspectorController::startUserInitiatedProfiling.
              (WebCore::InspectorController::startUserInitiatedProfiling): Recompile all JavaScript
              and enable the profiler if the profiler was not enabled.
              (WebCore::InspectorController::stopUserInitiatedProfiling): Rearrange code for readability.
              (WebCore::InspectorController::enableProfiler): Recompile all the JavaScript functions
              if the skipRecompile argument is false. Call the profilerWasEnabled script function.
              (WebCore::InspectorController::disableProfiler): Recompile all the JavaScript functions.
              Call the profilerWasEnabled script function.
              (WebCore::InspectorController::disableDebugger): Set m_attachDebuggerWhenShown to false,
              so it won't be started later.
              * inspector/InspectorController.h:
              (WebCore::InspectorController::profilerEnabled): Return enabled() && m_profilerEnabled.
              * inspector/front-end/Images/debuggingButtons.png: Remove.
              * inspector/front-end/Images/enableButtons.png: Added.
              * inspector/front-end/Images/profilesSilhouette.png: Added.
              * inspector/front-end/Images/scriptsSilhouette.png: Added.
              * inspector/front-end/PanelEnablerView.js: Added.
              (WebInspector.PanelEnablerView):
              (WebInspector.PanelEnablerView.prototype._enableButtonCicked): Fire the "enable clicked"
              event so listeners can do their thing.
              (WebInspector.PanelEnablerView.prototype._windowResized): Test if the icon should be hidden.
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel): Create the PanelEnablerView and the strings needed for it.
              (WebInspector.ProfilesPanel.prototype.get statusBarItems): Include the enableToggleButton.
              (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): Call reset and populateInterface.
              (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): Call reset.
              (WebInspector.ProfilesPanel.prototype.reset): Call _updateInterface.
              (WebInspector.ProfilesPanel.prototype.setRecordingProfile): Moved in the code, no changes.
              (WebInspector.ProfilesPanel.prototype._updateInterface): Update the toggle button and
              show/hide other buttons. Also show/hide the PanelEnablerView.
              (WebInspector.ProfilesPanel.prototype._enableProfiling): Call _toggleProfiling if not enabled.
              (WebInspector.ProfilesPanel.prototype._toggleProfiling): Call InspectorController's
              disableProfiler or enableProfiler.
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel): Replace the overlay element with a PanelEnablerView. Replace the
              debuggingButton with the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype.get statusBarItems): Replace the debuggingButton with
              the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Hide/show the pauseOnExceptionButton
              when needed. Replace the overlay element with a PanelEnablerView. Replace the debuggingButton
              with the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype._enableDebugging): Call _toggleDebugging when not enabled.
              (WebInspector.ScriptsPanel.prototype._toggleDebugging): Remove the call to _clearInterface,
              since reset is called from debuggerWasEnabled and debuggerWasDisabled.
              * inspector/front-end/View.js: Inherit from WebInspector.Object.
              * inspector/front-end/WebKit.qrc: Add the PanelEnablerView.js file.
              * inspector/front-end/inspector.css: New styles for the PanelEnablerView.
              * inspector/front-end/inspector.html: Add the PanelEnablerView.js file.
              * inspector/front-end/inspector.js:
              (WebInspector.profilerWasEnabled): Added. Calls the ProfilesPanel.
              (WebInspector.profilerWasDisabled): Ditto.
              * page/Console.cpp:
              (WebCore::Console::error): Remove null check for m_frame, since m_frame isn't used.
              (WebCore::Console::info): Ditto.
              (WebCore::Console::log): Ditto.
              (WebCore::Console::assertCondition): Ditto.
              (WebCore::Console::dirxml): Remove null check for m_frame and use this->page().
              (WebCore::Console::count): Ditto.
              (WebCore::Console::profile): Return early if InspectorController::profilerEnabled is false.
              (WebCore::Console::profileEnd): Ditto.
              (WebCore::Console::warn): Remove null check for m_frame, since m_frame isn't used.
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Remove initialization of m_didInitializeDeveloperExtrasEnabled.
              (WebCore::Settings::setDeveloperExtrasEnabled): Remove code that recompiled functions.
              Now just sets the member boolean.
              * page/Settings.h: Remove m_didInitializeDeveloperExtrasEnabled.
      
      WebKit/mac:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add WebInspector methods to enable the profiler.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * WebInspector/WebInspector.h:
              * WebInspector/WebInspector.mm:
              (-[WebInspector isJavaScriptProfilingEnabled]): Added. Calls InspectorController::profilerEnabled.
              (-[WebInspector setJavaScriptProfilingEnabled:]): Added. Call InspectorController's disableProfiler
              or enableProfiler methods.
      
      WebKit/win:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add IWebInspector methods to enable the profiler.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * WebInspector.cpp:
              (WebInspector::isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled.
              (WebInspector::setJavaScriptProfilingEnabled): Added. Call InspectorController's disableProfiler
              or enableProfiler methods.
              * WebInspector.h:
      
      WebKitTools:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add support for enabling the profiler, so the profiling tests can continue
              work now that the profiler is not always enabled.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
              * DumpRenderTree/LayoutTestController.cpp:
              (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
              (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
      
      LayoutTests:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Update profiler tests to opt-in to profiling and clean up the output.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it
              does not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * fast/profiler/anonymous-event-handler-expected.txt:
              * fast/profiler/anonymous-event-handler.html:
              * fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
              * fast/profiler/anonymous-function-called-from-different-contexts.html:
              * fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
              * fast/profiler/anonymous-function-calls-built-in-functions.html:
              * fast/profiler/anonymous-function-calls-eval-expected.txt:
              * fast/profiler/anonymous-function-calls-eval.html:
              * fast/profiler/apply-expected.txt:
              * fast/profiler/apply.html:
              * fast/profiler/built-in-function-calls-anonymous-expected.txt:
              * fast/profiler/built-in-function-calls-anonymous.html:
              * fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
              * fast/profiler/built-in-function-calls-user-defined-function.html:
              * fast/profiler/call-expected.txt:
              * fast/profiler/call-nodelist-as-function-expected.txt:
              * fast/profiler/call-nodelist-as-function.html:
              * fast/profiler/call.html:
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt:
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
              * fast/profiler/compare-multiple-profiles-expected.txt:
              * fast/profiler/compare-multiple-profiles.html:
              * fast/profiler/constructor-expected.txt:
              * fast/profiler/constructor.html:
              * fast/profiler/dead-time-expected.txt:
              * fast/profiler/dead-time.html:
              * fast/profiler/document-dot-write-expected.txt:
              * fast/profiler/document-dot-write.html:
              * fast/profiler/event-handler-expected.txt:
              * fast/profiler/event-handler.html:
              * fast/profiler/execution-context-and-eval-on-same-line-expected.txt:
              * fast/profiler/execution-context-and-eval-on-same-line.html:
              * fast/profiler/heavy-view-expected.txt:
              * fast/profiler/heavy-view.html:
              * fast/profiler/inline-event-handler-expected.txt:
              * fast/profiler/inline-event-handler.html:
              * fast/profiler/many-calls-in-the-same-scope-expected.txt:
              * fast/profiler/many-calls-in-the-same-scope.html:
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
              * fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
              * fast/profiler/multiple-and-different-scoped-function-calls.html:
              * fast/profiler/multiple-frames-expected.txt:
              * fast/profiler/multiple-frames.html:
              * fast/profiler/nested-anonymous-functon-expected.txt:
              * fast/profiler/nested-anonymous-functon.html:
              * fast/profiler/nested-start-and-stop-profiler-expected.txt:
              * fast/profiler/nested-start-and-stop-profiler.html:
              * fast/profiler/no-execution-context-expected.txt:
              * fast/profiler/no-execution-context.html:
              * fast/profiler/one-execution-context-expected.txt:
              * fast/profiler/one-execution-context.html:
              * fast/profiler/profile-calls-in-included-file-expected.txt:
              * fast/profiler/profile-calls-in-included-file.html:
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt:
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
              * fast/profiler/profiling-from-a-nested-location-expected.txt:
              * fast/profiler/profiling-from-a-nested-location.html:
              * fast/profiler/resources/profiler-test-JS-resources.js:
              (endTest): Remove some whitespace.
              (insertGivenText): Hide the output of this method, sicne it is not important to the test.
              (insertNewText): Ditto.
              (printHeavyProfilesDataWithoutTime): Output plain text an not console.log.
              (printProfilesDataWithoutTime): Ditto.
              (printProfileNodeWithoutTime): Ditto.
              * fast/profiler/simple-event-call-expected.txt:
              * fast/profiler/simple-event-call.html:
              * fast/profiler/simple-no-level-change-expected.txt:
              * fast/profiler/simple-no-level-change.html:
              * fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
              * fast/profiler/start-and-stop-profiler-multiple-times.html:
              * fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt:
              * fast/profiler/start-and-stop-profiling-in-the-same-function.html:
              * fast/profiler/start-but-dont-stop-profiling-expected.txt:
              * fast/profiler/start-but-dont-stop-profiling.html:
              * fast/profiler/stop-profiling-after-setTimeout-expected.txt:
              * fast/profiler/stop-profiling-after-setTimeout.html:
              * fast/profiler/stop-then-function-call-expected.txt:
              * fast/profiler/stop-then-function-call.html:
              * fast/profiler/throw-exception-from-eval-expected.txt:
              * fast/profiler/throw-exception-from-eval.html:
              * fast/profiler/two-execution-contexts-expected.txt:
              * fast/profiler/two-execution-contexts.html:
              * fast/profiler/user-defined-function-calls-built-in-functions-expected.txt:
              * fast/profiler/user-defined-function-calls-built-in-functions.html:
              * fast/profiler/window-dot-eval-expected.txt:
              * fast/profiler/window-dot-eval.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dec1b92
    • timothy@apple.com's avatar
      Rename a few methods related to attaching and detaching the debugger. Also... · 0a8972d0
      timothy@apple.com authored
      Rename a few methods related to attaching and detaching the debugger. Also adds stub methods for enabling and disabling the profiler.
      
      WebCore:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Rename a few methods related to attaching and detaching the debugger. Also
              adds stub methods for enabling and disabling the profiler.
      
              * Rename attachDebugger to enableDebugger.
              * Rename detachDebugger to disableDebugger.
              * Rename the debuggerAttached getter to debuggerEnabled.
              * Rename the debuggerAttached callback to debuggerWasEnabled.
              * Rename the debuggerDetached callback to debuggerWasDisabled.
      
              Reviewed by Darin Adler.
      
              * WebCore.base.exp:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::setWindowVisible):
              (WebCore::InspectorController::windowScriptObjectAvailable):
              (WebCore::InspectorController::close):
              (WebCore::InspectorController::enableProfiler):
              (WebCore::InspectorController::disableProfiler):
              (WebCore::InspectorController::enableDebugger):
              (WebCore::InspectorController::disableDebugger):
              (WebCore::InspectorController::pauseInDebugger):
              (WebCore::InspectorController::resumeDebugger):
              (WebCore::InspectorController::stepOverStatementInDebugger):
              (WebCore::InspectorController::stepIntoStatementInDebugger):
              (WebCore::InspectorController::stepOutOfFunctionInDebugger):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::profilerEnabled):
              (WebCore::InspectorController::debuggerEnabled):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
              * inspector/front-end/Object.js:
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype.get statusBarItems):
              (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
              (WebInspector.ScriptsPanel.prototype.debuggerWasDetached):
              (WebInspector.ScriptsPanel.prototype.reset):
              (WebInspector.ScriptsPanel.prototype.canShowResource):
              (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
              (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
              * inspector/front-end/View.js:
              * inspector/front-end/inspector.css:
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector.addResource):
              (WebInspector.debuggerWasEnabled):
              (WebInspector.debuggerWasDisabled):
      
      WebKit/mac:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Rename a few methods related to attaching and detaching the debugger.
      
              * Rename attachDebugger to enableDebugger.
              * Rename detachDebugger to disableDebugger.
              * Rename the debuggerAttached getter to debuggerEnabled.
      
              Reviewed by Darin Adler.
      
              * WebInspector/WebInspector.mm:
              (-[WebInspector isDebuggingJavaScript]):
              (-[WebInspector startDebuggingJavaScript:]):
              (-[WebInspector stopDebuggingJavaScript:]):
      
      WebKit/win:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Rename a few methods related to attaching and detaching the debugger.
      
              * Rename attachDebugger to enableDebugger.
              * Rename detachDebugger to disableDebugger.
              * Rename the debuggerAttached getter to debuggerEnabled.
      
              Reviewed by Darin Adler.
      
              * WebInspector.cpp:
              (WebInspector::isDebuggingJavaScript):
              (WebInspector::toggleDebuggingJavaScript):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a8972d0
  7. 27 Oct, 2008 6 commits
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · 503b58d2
      andersca@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Use the C++ stream object for JS requests as well.
              
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
              (-[WebBaseNetscapePluginView destroyStream:reason:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      503b58d2
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · 208b92ff
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
              
              Use the C++ stream object in WebBaseNetscapePluginView. Use a HashSet of RefPtrs to keep track of the streams.
              
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::~WebNetscapePluginStream):
              (WebNetscapePluginStream::setPlugin):
              (WebNetscapePluginStream::startStream):
              (WebNetscapePluginStream::destroyStream):
              (WebNetscapePluginStream::destroyStreamWithReason):
              (WebNetscapePluginStream::cancelLoadAndDestroyStreamWithError):
              (WebNetscapePluginStream::deliverData):
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView stop]):
              (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
              (-[WebBaseNetscapePluginView disconnectStream:]):
              (-[WebBaseNetscapePluginView dealloc]):
              (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
              (-[WebBaseNetscapePluginView pluginView:receivedData:]):
              (-[WebBaseNetscapePluginView pluginView:receivedError:]):
              (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]):
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      208b92ff
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · 9c716837
      andersca@apple.com authored
              Reviewed by Mitz Pettel.
              
              Move code from dealloc and finalize to the WebNetscapePluginStream destructor.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::~WebNetscapePluginStream):
              (-[WebBaseNetscapePluginStream dealloc]):
              (-[WebBaseNetscapePluginStream finalize]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c716837
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · e695a406
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Get rid of WebNetscapePlugInStreamLoaderClient, the plug-in stream is its own client.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::WebNetscapePluginStream):
              (-[WebBaseNetscapePluginStream dealloc]):
              (-[WebBaseNetscapePluginStream finalize]):
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView pluginView:receivedError:]):
              (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]):
              (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
              (-[WebBaseNetscapePluginView destroyStream:reason:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e695a406
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · 922a50eb
      andersca@apple.com authored
              Reviewed by Darin Adler.
      
              Change the Obj-C init methods to simply call WebNetscapePluginStream::create.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              (WebNetscapePluginStream::create):
              * Plugins/WebBaseNetscapePluginStream.mm:
              (-[WebBaseNetscapePluginStream initWithFrameLoader:]):
              (WebNetscapePluginStream::WebNetscapePluginStream):
              (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      922a50eb
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · 71d0d106
      andersca@apple.com authored
              Reviewed by Kevin Decker.
      
              Convert more code over to C++.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              (WebNetscapePluginStream::plugin):
              (WebNetscapePluginStream::setRequestURL):
              Convert to C++.
      
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::start):
              (WebNetscapePluginStream::stop):
              Ditto.
              
              (WebNetscapePluginStream::startStreamWithResponse):
              Ditto.
              
              (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
              Call the C++ version.
              
              (-[WebBaseNetscapePluginStream impl]):
              New accessor for the C++ class.
              
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView pluginView:receivedData:]):
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
              (-[WebBaseNetscapePluginView destroyStream:reason:]):
              Call the C++ methods.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71d0d106
  8. 25 Oct, 2008 1 commit
    • weinig@apple.com's avatar
      WebCore: · d75fed72
      weinig@apple.com authored
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              Move file choosing into WebKit ChromeClient.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::runOpenPanel):
              * page/Chrome.cpp:
              (WebCore::Chrome::runOpenPanel):
              * page/Chrome.h:
              * page/ChromeClient.h:
              * page/mac/ChromeMac.mm:
              * platform/FileChooser.h:
              * platform/mac/FileChooserMac.mm:
              * platform/qt/FileChooserQt.cpp:
              * platform/win/FileChooserWin.cpp:
              * platform/wx/TemporaryLinkStubs.cpp:
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::click):
      
      WebKit/gtk:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::runOpenPanel):
              * WebCoreSupport/ChromeClientGtk.h:
      
      WebKit/mac:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::runOpenPanel):
      
      WebKit/qt:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::runOpenPanel):
              * WebCoreSupport/ChromeClientQt.h:
      
      WebKit/win:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::runOpenPanel):
              * WebCoreSupport/WebChromeClient.h:
      
      WebKit/wx:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::runOpenPanel):
              * WebKitSupport/ChromeClientWx.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d75fed72
  9. 24 Oct, 2008 6 commits
    • andersca@apple.com's avatar
      2008-10-24 Anders Carlsson <andersca@apple.com> · 6e12c0d6
      andersca@apple.com authored
              Fix Tiger build.
              
              * WebView/WebUIDelegate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e12c0d6
    • andersca@apple.com's avatar
      WebCore: · 4348c6a8
      andersca@apple.com authored
      2008-10-24  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
      
              <rdar://problem/5440917> Support NPN_Construct
                      
              * WebCore.NPAPI.exp:
              Export _NPN_Construct.
              
              * bridge/NP_jsobject.cpp:
              (_NPN_Construct):
              Implement this.
              
              * bridge/c/c_instance.cpp:
              (JSC::Bindings::CInstance::supportsConstruct):
              (JSC::Bindings::CInstance::invokeConstruct):
              Have this call the appropriate NPClass method.
              
              * bridge/npruntime.h:
              Add NPN_Construct.
      
              * bridge/npruntime_impl.h:
              Add _NPN_Construct.
              
              * bridge/runtime.h:
              (JSC::Bindings::Instance::supportsConstruct):
              (JSC::Bindings::Instance::invokeConstruct):
              New methods.
              
              * bridge/runtime_object.cpp:
              (JSC::callRuntimeConstructor):
              Call the native instance.
              
              (JSC::RuntimeObjectImp::getConstructData):
              Implement this.
              
              * bridge/runtime_object.h:
              Add new method declarations.
              
              * plugins/gtk/PluginPackageGtk.cpp:
              (WebCore::PluginPackage::load):
              * plugins/qt/PluginPackageQt.cpp:
              (WebCore::PluginPackage::load):
              * plugins/win/PluginPackageWin.cpp:
              (WebCore::PluginPackage::load):
              Initialize m_pluginFuncs.construct.
      
      WebKit/mac:
      
      2008-10-24  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
      
              <rdar://problem/5440917> Support NPN_Construct
              
              Set construct.
              
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage load]):
      
      WebKitTools:
      
      2008-10-24  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
              
              <rdar://problem/5440917> Support NPN_Construct
              
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
              (testCallback):
              Fix a memory leak.
              
              (testConstruct):
              New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
              
              (pluginInvoke):
              Handle testConstruct.
              
              * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
              (testGetProperty):
              Add objectPointer property.
              
              (testEnumerate):
              Only enumerate the two first properties.
              
              (testConstruct):
              Add a simple construct implementation that just returns the test object.
      
      LayoutTests:
      
      2008-10-24  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
      
              <rdar://problem/5440917> Support NPN_Construct
              
              Add testcase.
              
              * plugins/netscape-construct-expected.txt: Added.
              * plugins/netscape-construct.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4348c6a8
    • mrowe@apple.com's avatar
      <rdar://problem/6119711> Remove the dependency on Foundation's private... · d71d3ff4
      mrowe@apple.com authored
      <rdar://problem/6119711> Remove the dependency on Foundation's private __COCOA_FORMAL_PROTOCOLS__ define.
      
      Rubber-stamped by Tim Hatcher.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d71d3ff4
    • adele@apple.com's avatar
      WebCore: · 497541bd
      adele@apple.com authored
      2008-10-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
      
              This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
              This is consistent with the direction HTML5 will be going in the future.
      
              The initial implementation here will show "n files" as the text next to the control when multiple files are selected.  You can view
              the individual files in a tooltip for now.  Improvements to this control will come later.  
      
              Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.  
              These FileList Files can also be sent in an XMLHTTPRequest.
      
              * manual-tests/post-multi-file-upload.html: Added.
              * manual-tests/resources/multiFileResources: Added.
              * manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
              * manual-tests/resources/multiFileResources/testFile1.html: Added.
              * manual-tests/resources/multiFileResources/testFile2.html: Added.
              * manual-tests/resources/multiFileResources/testFile3.html: Added.
      
              * WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute.
              (WebCore::HTMLInputElement::value): Added comments.  The HTML5 spec says that value shouldn't apply for the file upload control,
              but we don't want to break the behavior for existing websites that may rely on this.
              (WebCore::HTMLInputElement::setValue): ditto.
              (WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead.
              (WebCore::HTMLInputElement::setFileListFromRenderer): Added. 
              * html/HTMLInputElement.h:
      
              * page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.
      
              * page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.
      
              * platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer.
              (WebCore::FileChooser::FileChooser):
              (WebCore::FileChooser::create):
              (WebCore::FileChooser::clear):
              (WebCore::FileChooser::chooseFile):
              (WebCore::FileChooser::chooseFiles):
              (WebCore::FileChooser::chooseIcon):
              * platform/FileChooser.h:
              (WebCore::FileChooser::filePaths):
              (WebCore::FileChooser::allowsMultipleFiles):
      
              * platform/graphics/Icon.h:
              * platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
              * platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
              * platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
              * platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.
      
              * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):  Updated to deal with new filenames vector.
              * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
              * platform/qt/FileChooserQt.cpp:
              (WebCore::FileChooser::openFileChooser):
              (WebCore::FileChooser::basenameForWidth):
              * platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
      
              * platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle):
              Removed unnecessary assertion.  This can get hit when connectionDidFinishLoading and cancel
              both get called for the same ResourceHandle.  This getting called twice has no negative effect.
      
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::valueChanged):  Calls setFileListFromRenderer.
              (WebCore::RenderFileUploadControl::allowsMultipleFiles):  Added.
              (WebCore::RenderFileUploadControl::updateFromElement):  Uses the new filenames call from FileChooser.
              (WebCore::RenderFileUploadControl::receiveDroppedFiles):  Updated to support multiple files.
              * rendering/RenderFileUploadControl.h:
      
      WebKit/mac:
      
      2008-10-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKit part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::runOpenPanel):
              (-[WebOpenPanelResultListener chooseFilenames:]):
              * WebView/WebUIDelegate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      497541bd
    • timothy@apple.com's avatar
      Add a mechanism to store and retrieve preferences for the Web Inspector. · f454001b
      timothy@apple.com authored
      WebCore:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Add a mechanism to ask the InspectorClient for key/value setting pairs.
              These settings can be strings, numbers, booleans or string vectors. The
              settings are also bridged to and from JavaScript.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebCore.base.exp: Expose the String CFStringRef constructor.
              * inspector/InspectorClient.h:
              (WebCore::InspectorClient::populateSetting): Added, pure virtual.
              (WebCore::InspectorClient::storeSetting): Ditto.
              (WebCore::InspectorClient::removeSetting): Ditto.
              * inspector/InspectorController.cpp:
              (WebCore::setting): Calls InspectorController::setting and wraps the result in script types.
              (WebCore::setSetting): Calls InspectorController::setSetting after converting from script types.
              (WebCore::InspectorController::InspectorController): Increment a global static
              to track the number of live InspectorControllers.
              (WebCore::InspectorController::~InspectorController): Decrement the global static
              that tracks the number of live InspectorControllers. Delete the setting cache if there
              are no more live controllers.
              (WebCore::InspectorController::setting): Check the cache and return the setting from there,
              otherwise make a new Setting and ask the client to populate it.
              (WebCore::InspectorController::setSetting): Change the cache and ask the client to store it.
              (WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting
              to the InspectorController script class.
              * inspector/InspectorController.h:
              (WebCore::InspectorController::Setting::Setting):
              (WebCore::InspectorController::Setting::operator=):
              (WebCore::InspectorController::Setting::type): Return m_type.
              (WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct.
              (WebCore::InspectorController::Setting::stringVector): Return m_stringVector.
              Assert the type is correct.
              (WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double.
              Assert the type is correct.
              (WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer.
              Assert the type is correct.
              (WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean.
              Assert the type is correct.
              (WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right
              field and the type.
              * loader/EmptyClients.h:
              (WebCore::EmptyInspectorClient::populateSetting): Added, empty method.
              (WebCore::EmptyInspectorClient::storeSetting): Ditto.
              (WebCore::EmptyInspectorClient::removeSetting): Ditto.
      
      WebKit:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Implement new InspectorClient methods to work with Settings.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebKit.xcodeproj/project.pbxproj: Add the new InspectorClientCF.cpp file.
      
      WebKit/gtk:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Stub out new InspectorClient methods.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebCoreSupport/InspectorClientGtk.cpp:
              (WebKit::InspectorClient::populateSetting): Not implemented.
              (WebKit::InspectorClient::storeSetting): Ditto.
              (WebKit::InspectorClient::removeSetting): Ditto.
              * WebCoreSupport/InspectorClientGtk.h:
      
      WebKit/mac:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Implement new InspectorClient methods to work with Settings.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebCoreSupport/WebInspectorClient.h: Add the new methods and
              guard the ObjC parts of the header.
      
      WebKit/qt:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Stub out new InspectorClient methods.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebCoreSupport/InspectorClientQt.cpp:
              (WebCore::InspectorClientQt::populateSetting): Not implemented.
              (WebCore::InspectorClientQt::storeSetting): Ditto.
              (WebCore::InspectorClientQt::removeSetting): Ditto.
              * WebCoreSupport/InspectorClientQt.h:
      
      WebKit/win:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Implement new InspectorClient methods to work with Settings.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Adam Roben.
      
              * WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
              * WebCoreSupport/WebInspectorClient.h: Add the new methods.
      
      WebKit/wx:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Stub out new InspectorClient methods.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebKitSupport/InspectorClientWx.cpp:
              (WebCore::InspectorClient::populateSetting): Not implemented.
              (WebCore::InspectorClient::storeSetting): Ditto.
              (WebCore::InspectorClient::removeSetting): Ditto.
              * WebKitSupport/InspectorClientWx.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f454001b
    • darin@apple.com's avatar
      JavaScriptCore: · 44331f8b
      darin@apple.com authored
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * API/APICast.h:
              * API/JSCallbackConstructor.h:
              * API/JSCallbackFunction.cpp:
              * API/JSCallbackFunction.h:
              * API/JSCallbackObject.h:
              * API/JSCallbackObjectFunctions.h:
              * API/JSContextRef.cpp:
              * API/JSObjectRef.cpp:
              * API/JSValueRef.cpp:
              * VM/CTI.cpp:
              * VM/CTI.h:
              * VM/CodeBlock.cpp:
              * VM/CodeBlock.h:
              * VM/CodeGenerator.cpp:
              * VM/CodeGenerator.h:
              * VM/ExceptionHelpers.cpp:
              * VM/ExceptionHelpers.h:
              * VM/JSPropertyNameIterator.cpp:
              * VM/JSPropertyNameIterator.h:
              * VM/Machine.cpp:
              * VM/Machine.h:
              * VM/Register.h:
              * kjs/ArgList.cpp:
              * kjs/ArgList.h:
              * kjs/Arguments.cpp:
              * kjs/Arguments.h:
              * kjs/ArrayConstructor.cpp:
              * kjs/ArrayPrototype.cpp:
              * kjs/BooleanConstructor.cpp:
              * kjs/BooleanConstructor.h:
              * kjs/BooleanObject.h:
              * kjs/BooleanPrototype.cpp:
              * kjs/CallData.cpp:
              * kjs/CallData.h:
              * kjs/ConstructData.cpp:
              * kjs/ConstructData.h:
              * kjs/DateConstructor.cpp:
              * kjs/DateInstance.h:
              * kjs/DatePrototype.cpp:
              * kjs/DatePrototype.h:
              * kjs/DebuggerCallFrame.cpp:
              * kjs/DebuggerCallFrame.h:
              * kjs/ErrorConstructor.cpp:
              * kjs/ErrorPrototype.cpp:
              * kjs/ExecState.cpp:
              * kjs/ExecState.h:
              * kjs/FunctionConstructor.cpp:
              * kjs/FunctionPrototype.cpp:
              * kjs/FunctionPrototype.h:
              * kjs/GetterSetter.cpp:
              * kjs/GetterSetter.h:
              * kjs/InternalFunction.h:
              * kjs/JSActivation.cpp:
              * kjs/JSActivation.h:
              * kjs/JSArray.cpp:
              * kjs/JSArray.h:
              * kjs/JSCell.cpp:
              * kjs/JSCell.h:
              * kjs/JSFunction.cpp:
              * kjs/JSFunction.h:
              * kjs/JSGlobalData.h:
              * kjs/JSGlobalObject.cpp:
              * kjs/JSGlobalObject.h:
              * kjs/JSGlobalObjectFunctions.cpp:
              * kjs/JSGlobalObjectFunctions.h:
              * kjs/JSImmediate.cpp:
              * kjs/JSImmediate.h:
              * kjs/JSNotAnObject.cpp:
              * kjs/JSNotAnObject.h:
              * kjs/JSNumberCell.cpp:
              * kjs/JSNumberCell.h:
              * kjs/JSObject.cpp:
              * kjs/JSObject.h:
              * kjs/JSStaticScopeObject.cpp:
              * kjs/JSStaticScopeObject.h:
              * kjs/JSString.cpp:
              * kjs/JSString.h:
              * kjs/JSValue.h:
              * kjs/JSVariableObject.h:
              * kjs/JSWrapperObject.h:
              * kjs/MathObject.cpp:
              * kjs/MathObject.h:
              * kjs/NativeErrorConstructor.cpp:
              * kjs/NumberConstructor.cpp:
              * kjs/NumberConstructor.h:
              * kjs/NumberObject.cpp:
              * kjs/NumberObject.h:
              * kjs/NumberPrototype.cpp:
              * kjs/ObjectConstructor.cpp:
              * kjs/ObjectPrototype.cpp:
              * kjs/ObjectPrototype.h:
              * kjs/PropertyMap.h:
              * kjs/PropertySlot.cpp:
              * kjs/PropertySlot.h:
              * kjs/RegExpConstructor.cpp:
              * kjs/RegExpConstructor.h:
              * kjs/RegExpMatchesArray.h:
              * kjs/RegExpObject.cpp:
              * kjs/RegExpObject.h:
              * kjs/RegExpPrototype.cpp:
              * kjs/Shell.cpp:
              * kjs/StringConstructor.cpp:
              * kjs/StringObject.cpp:
              * kjs/StringObject.h:
              * kjs/StringObjectThatMasqueradesAsUndefined.h:
              * kjs/StringPrototype.cpp:
              * kjs/StructureID.cpp:
              * kjs/StructureID.h:
              * kjs/collector.cpp:
              * kjs/collector.h:
              * kjs/completion.h:
              * kjs/grammar.y:
              * kjs/interpreter.cpp:
              * kjs/interpreter.h:
              * kjs/lookup.cpp:
              * kjs/lookup.h:
              * kjs/nodes.h:
              * kjs/operations.cpp:
              * kjs/operations.h:
              * kjs/protect.h:
              * profiler/ProfileGenerator.cpp:
              * profiler/Profiler.cpp:
              * profiler/Profiler.h:
              Use JSValue* instead of JSValuePtr.
      
      JavaScriptGlue:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * JSObject.cpp:
              (nativeCallFunction):
              * JSUtils.cpp:
              (KJSValueToJSObject):
              (JSObjectKJSValue):
              (KJSValueToCFTypeInternal):
              (KJSValueToCFType):
              * JSUtils.h:
              * JSValueWrapper.cpp:
              (JSValueWrapper::JSValueWrapper):
              (JSValueWrapper::GetValue):
              (JSValueWrapper::JSObjectCopyProperty):
              (JSValueWrapper::JSObjectSetProperty):
              (JSValueWrapper::JSObjectCallFunction):
              * JSValueWrapper.h:
              * UserObjectImp.cpp:
              (UserObjectImp::callAsFunction):
              (UserObjectImp::userObjectGetter):
              (UserObjectImp::getOwnPropertySlot):
              (UserObjectImp::put):
              (UserObjectImp::toPrimitive):
              * UserObjectImp.h:
              (UserObjectImp::createStructureID):
              Use JSValue* instead of JSValuePtr.
      
      WebCore:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * bindings/js/JSAttrCustom.cpp:
              * bindings/js/JSCSSRuleCustom.cpp:
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              * bindings/js/JSCSSValueCustom.cpp:
              * bindings/js/JSCanvasPixelArrayCustom.h:
              * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
              * bindings/js/JSClipboardCustom.cpp:
              * bindings/js/JSConsoleCustom.cpp:
              * bindings/js/JSCustomSQLStatementCallback.cpp:
              * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
              * bindings/js/JSCustomSQLTransactionCallback.cpp:
              * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
              * bindings/js/JSCustomVoidCallback.cpp:
              * bindings/js/JSCustomVoidCallback.h:
              * bindings/js/JSCustomXPathNSResolver.cpp:
              * bindings/js/JSCustomXPathNSResolver.h:
              * bindings/js/JSDOMApplicationCacheCustom.cpp:
              * bindings/js/JSDOMBinding.cpp:
              * bindings/js/JSDOMBinding.h:
              * bindings/js/JSDOMWindowBase.cpp:
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/JSDOMWindowCustom.cpp:
              * bindings/js/JSDOMWindowCustom.h:
              * bindings/js/JSDOMWindowShell.cpp:
              * bindings/js/JSDOMWindowShell.h:
              * bindings/js/JSDatabaseCustom.cpp:
              * bindings/js/JSDedicatedWorkerCustom.cpp:
              * bindings/js/JSDocumentCustom.cpp:
              * bindings/js/JSElementCustom.cpp:
              * bindings/js/JSEventCustom.cpp:
              * bindings/js/JSEventListener.cpp:
              * bindings/js/JSEventTarget.cpp:
              * bindings/js/JSEventTarget.h:
              * bindings/js/JSEventTargetBase.h:
              * bindings/js/JSEventTargetNodeCustom.cpp:
              * bindings/js/JSHTMLAllCollection.h:
              * bindings/js/JSHTMLAppletElementCustom.cpp:
              * bindings/js/JSHTMLCollectionCustom.cpp:
              * bindings/js/JSHTMLDocumentCustom.cpp:
              * bindings/js/JSHTMLEmbedElementCustom.cpp:
              * bindings/js/JSHTMLFormElementCustom.cpp:
              * bindings/js/JSHTMLFrameElementCustom.cpp:
              * bindings/js/JSHTMLFrameSetElementCustom.cpp:
              * bindings/js/JSHTMLIFrameElementCustom.cpp:
              * bindings/js/JSHTMLInputElementCustom.cpp:
              * bindings/js/JSHTMLObjectElementCustom.cpp:
              * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
              * bindings/js/JSHTMLSelectElementCustom.cpp:
              * bindings/js/JSHTMLSelectElementCustom.h:
              * bindings/js/JSHistoryCustom.cpp:
              * bindings/js/JSImageDataCustom.cpp:
              * bindings/js/JSInspectedObjectWrapper.cpp:
              * bindings/js/JSInspectedObjectWrapper.h:
              * bindings/js/JSInspectorCallbackWrapper.cpp:
              * bindings/js/JSInspectorCallbackWrapper.h:
              * bindings/js/JSJavaScriptCallFrameCustom.cpp:
              * bindings/js/JSLocationCustom.cpp:
              * bindings/js/JSMessagePortCustom.cpp:
              * bindings/js/JSMimeTypeArrayCustom.cpp:
              * bindings/js/JSNamedNodeMapCustom.cpp:
              * bindings/js/JSNamedNodesCollection.cpp:
              * bindings/js/JSNamedNodesCollection.h:
              * bindings/js/JSNavigatorCustom.cpp:
              * bindings/js/JSNodeCustom.cpp:
              * bindings/js/JSNodeFilterCondition.cpp:
              * bindings/js/JSNodeFilterCondition.h:
              * bindings/js/JSNodeFilterCustom.cpp:
              * bindings/js/JSNodeIteratorCustom.cpp:
              * bindings/js/JSNodeListCustom.cpp:
              * bindings/js/JSPluginArrayCustom.cpp:
              * bindings/js/JSPluginCustom.cpp:
              * bindings/js/JSPluginElementFunctions.cpp:
              * bindings/js/JSPluginElementFunctions.h:
              * bindings/js/JSQuarantinedObjectWrapper.cpp:
              * bindings/js/JSQuarantinedObjectWrapper.h:
              * bindings/js/JSRGBColor.cpp:
              * bindings/js/JSRGBColor.h:
              * bindings/js/JSSQLResultSetRowListCustom.cpp:
              * bindings/js/JSSQLTransactionCustom.cpp:
              * bindings/js/JSSVGElementInstanceCustom.cpp:
              * bindings/js/JSSVGLengthCustom.cpp:
              * bindings/js/JSSVGMatrixCustom.cpp:
              * bindings/js/JSSVGPathSegCustom.cpp:
              * bindings/js/JSSVGPathSegListCustom.cpp:
              * bindings/js/JSSVGPointListCustom.cpp:
              * bindings/js/JSSVGTransformListCustom.cpp:
              * bindings/js/JSStorageCustom.cpp:
              * bindings/js/JSStyleSheetCustom.cpp:
              * bindings/js/JSStyleSheetListCustom.cpp:
              * bindings/js/JSTextCustom.cpp:
              * bindings/js/JSTreeWalkerCustom.cpp:
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
              * bindings/js/JSXSLTProcessorCustom.cpp:
              * bindings/js/ScheduledAction.cpp:
              * bindings/js/ScheduledAction.h:
              * bindings/js/ScriptController.cpp:
              * bindings/js/ScriptController.h:
              * bindings/objc/WebScriptObject.mm:
              * bindings/objc/WebScriptObjectPrivate.h:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bridge/NP_jsobject.cpp:
              * bridge/c/c_instance.cpp:
              * bridge/c/c_instance.h:
              * bridge/c/c_runtime.cpp:
              * bridge/c/c_runtime.h:
              * bridge/c/c_utility.cpp:
              * bridge/c/c_utility.h:
              * bridge/jni/jni_instance.cpp:
              * bridge/jni/jni_instance.h:
              * bridge/jni/jni_jsobject.h:
              * bridge/jni/jni_jsobject.mm:
              * bridge/jni/jni_objc.mm:
              * bridge/jni/jni_runtime.cpp:
              * bridge/jni/jni_runtime.h:
              * bridge/jni/jni_utility.cpp:
              * bridge/jni/jni_utility.h:
              * bridge/objc/WebScriptObject.h:
              * bridge/objc/objc_class.h:
              * bridge/objc/objc_class.mm:
              * bridge/objc/objc_instance.h:
              * bridge/objc/objc_instance.mm:
              * bridge/objc/objc_runtime.h:
              * bridge/objc/objc_runtime.mm:
              * bridge/objc/objc_utility.h:
              * bridge/objc/objc_utility.mm:
              * bridge/qt/qt_class.cpp:
              * bridge/qt/qt_class.h:
              * bridge/qt/qt_instance.cpp:
              * bridge/qt/qt_instance.h:
              * bridge/qt/qt_runtime.cpp:
              * bridge/qt/qt_runtime.h:
              * bridge/runtime.cpp:
              * bridge/runtime.h:
              * bridge/runtime_array.cpp:
              * bridge/runtime_array.h:
              * bridge/runtime_method.cpp:
              * bridge/runtime_method.h:
              * bridge/runtime_object.cpp:
              * bridge/runtime_object.h:
              * bridge/testqtbindings.cpp:
              * inspector/JavaScriptCallFrame.cpp:
              * inspector/JavaScriptCallFrame.h:
              * inspector/JavaScriptProfile.cpp:
              * inspector/JavaScriptProfile.h:
              * inspector/JavaScriptProfileNode.cpp:
              * inspector/JavaScriptProfileNode.h:
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              * page/Console.cpp:
              * page/Console.h:
              * plugins/MimeTypeArray.h:
              * plugins/Plugin.h:
              * plugins/PluginArray.h:
              * plugins/PluginView.cpp:
              * xml/XMLHttpRequest.cpp:
              Use JSValue* instead of JSValuePtr.
      
      WebKit/mac:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * WebView/WebFrame.mm:
              (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
              * WebView/WebScriptDebugDelegate.mm:
              (-[WebScriptCallFrame _convertValueToObjcValue:]):
              (-[WebScriptCallFrame exception]):
              (-[WebScriptCallFrame evaluateWebScript:]):
              * WebView/WebView.mm:
              (aeDescFromJSValue):
              (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
              Use JSValue* instead of JSValuePtr.
      
      WebKit/qt:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * Api/qwebframe.cpp:
              (QWebFrame::evaluateJavaScript): Use JSValue* instead of JSValuePtr.
      
      WebKit/win:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * WebScriptCallFrame.cpp:
              (WebScriptCallFrame::jsValueToString):
              (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
              (WebScriptCallFrame::valueForVariable):
              (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
              * WebScriptCallFrame.h:
              * WebView.cpp:
              (WebView::stringByEvaluatingJavaScriptFromString):
              Use JSValue* instead of JSValuePtr.
      
      WebKit/wx:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * WebFrame.cpp: (wxWebFrame::RunScript): Use JSValue* instead of JSValuePtr.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44331f8b
  10. 23 Oct, 2008 1 commit