Commits · 9b4c97433fa67eadfdc1eba6a06952b5e81e4721 · App_Technologies / webkit

04 Nov, 2008 7 commits

2008-11-04 Anders Carlsson <andersca@apple.com> · 9b4c9743

andersca@apple.com authored Nov 04, 2008

        Reviewed by Kevin Decker.
        
        https://bugs.webkit.org/show_bug.cgi?id=22065
        
        Remove some old, unused plug-in code.
        
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView setVariable:value:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9b4c9743

2008-11-04 Simon Fraser <simon.fraser@apple.com> · c65d3288

simon.fraser@apple.com authored Nov 04, 2008

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=21941

        Rename absolutePosition() to localToAbsolute(), and add the ability
        to optionally take transforms into account (which will eventually be the
        default behavior).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c65d3288

WebCore: · b8b5aa1d

hausmann@webkit.org authored Nov 04, 2008

    2008-11-03  Yael Aharon  <yael.aharon@nokia.com>

            Reviewed by Simon Hausmann.

            Add methods for getting and setting user data on History Item.
            This change is limited to QT port only. Tests were added in
            the patch for https://bugs.webkit.org/show_bug.cgi?id=21864.

            Minor change by Simon: made the functions inline and added a missing
            const.

WebKit/qt:
    2008-10-24  Yael Aharon <yael.aharon@nokia.com>

            Reviewed by Simon Hausmann.

            Add userData() and setUserData() to QWebHistoryItem.
            Add setMaximumItemCount() and maximumItemCount() to QWebHistory.
            Add currentItemIndex() to QWebHistory.

            See also https://bugs.webkit.org/show_bug.cgi?id=21864

            Small cleanup by Simon (docs and forward declaration of QWebHistoryItem in qwebframe.h)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b8b5aa1d

Reviewed by Darin Adler. · c5e3f1b1

ap@webkit.org authored Nov 04, 2008

        https://bugs.webkit.org/show_bug.cgi?id=22030
        Make EventNames usable from multiple threads

        * platform/text/AtomicString.cpp:
        (WebCore::stringTable):
        (WebCore::AtomicString::add):
        (WebCore::AtomicString::remove):
        (WebCore::AtomicString::find):
        (WebCore::AtomicString::init):
        * platform/text/AtomicString.h:
        Atomic string table is now per-thread. Individual strings cannot be shared between threads,
        so global AtomicString constants cannot be used from threads other than the main one.

        * dom/EventNames.cpp:
        (WebCore::EventNames::EventNames):
        (WebCore::eventNames):
        (WebCore::EventNames::init):
        * dom/EventNames.h:
        Made EventNames a ThreadSpecific struct. Individual event names are now accessed as
        eventNames().fooEvent, not EventNames::fooEvent. This makes EventNames usable from all
        threads.

        * <Many files>: Access event names via eventNames() function.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c5e3f1b1

2008-11-04 Cameron Zwarich <zwarich@apple.com> · d39a1fcf

cwzwarich@webkit.org authored Nov 04, 2008

        Reviewed by Mark Rowe.

        Delete unused forwarding headers.

        WebCore:

        * ForwardingHeaders/kjs/Activation.h: Removed.
        * ForwardingHeaders/kjs/Register.h: Removed.
        * ForwardingHeaders/kjs/RegisterID.h: Removed.

        WebKit/mac:

        * ForwardingHeaders/kjs/string_object.h: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d39a1fcf

2008-11-03 Cameron Zwarich <zwarich@apple.com> · b91210c0

cwzwarich@webkit.org authored Nov 04, 2008

        Rubber-stamped by Maciej Stachowiak.

        Move more files into the runtime subdirectory of JavaScriptCore.

        JavaScriptCore:

        * API/JSBase.cpp:
        * API/JSCallbackConstructor.cpp:
        * API/JSCallbackFunction.cpp:
        * API/JSClassRef.cpp:
        * API/OpaqueJSString.cpp:
        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/ArgList.cpp: Removed.
        * kjs/ArgList.h: Removed.
        * kjs/Arguments.cpp: Removed.
        * kjs/Arguments.h: Removed.
        * kjs/BatchedTransitionOptimizer.h: Removed.
        * kjs/CollectorHeapIterator.h: Removed.
        * kjs/CommonIdentifiers.cpp: Removed.
        * kjs/CommonIdentifiers.h: Removed.
        * kjs/ExecState.cpp: Removed.
        * kjs/ExecState.h: Removed.
        * kjs/GetterSetter.cpp: Removed.
        * kjs/GetterSetter.h: Removed.
        * kjs/InitializeThreading.cpp: Removed.
        * kjs/InitializeThreading.h: Removed.
        * kjs/JSActivation.cpp: Removed.
        * kjs/JSActivation.h: Removed.
        * kjs/JSGlobalData.cpp: Removed.
        * kjs/JSGlobalData.h: Removed.
        * kjs/JSLock.cpp: Removed.
        * kjs/JSLock.h: Removed.
        * kjs/JSStaticScopeObject.cpp: Removed.
        * kjs/JSStaticScopeObject.h: Removed.
        * kjs/JSType.h: Removed.
        * kjs/PropertyNameArray.cpp: Removed.
        * kjs/PropertyNameArray.h: Removed.
        * kjs/ScopeChain.cpp: Removed.
        * kjs/ScopeChain.h: Removed.
        * kjs/ScopeChainMark.h: Removed.
        * kjs/SymbolTable.h: Removed.
        * kjs/Tracing.d: Removed.
        * kjs/Tracing.h: Removed.
        * runtime/ArgList.cpp: Copied from kjs/ArgList.cpp.
        * runtime/ArgList.h: Copied from kjs/ArgList.h.
        * runtime/Arguments.cpp: Copied from kjs/Arguments.cpp.
        * runtime/Arguments.h: Copied from kjs/Arguments.h.
        * runtime/BatchedTransitionOptimizer.h: Copied from kjs/BatchedTransitionOptimizer.h.
        * runtime/CollectorHeapIterator.h: Copied from kjs/CollectorHeapIterator.h.
        * runtime/CommonIdentifiers.cpp: Copied from kjs/CommonIdentifiers.cpp.
        * runtime/CommonIdentifiers.h: Copied from kjs/CommonIdentifiers.h.
        * runtime/ExecState.cpp: Copied from kjs/ExecState.cpp.
        * runtime/ExecState.h: Copied from kjs/ExecState.h.
        * runtime/GetterSetter.cpp: Copied from kjs/GetterSetter.cpp.
        * runtime/GetterSetter.h: Copied from kjs/GetterSetter.h.
        * runtime/InitializeThreading.cpp: Copied from kjs/InitializeThreading.cpp.
        * runtime/InitializeThreading.h: Copied from kjs/InitializeThreading.h.
        * runtime/JSActivation.cpp: Copied from kjs/JSActivation.cpp.
        * runtime/JSActivation.h: Copied from kjs/JSActivation.h.
        * runtime/JSGlobalData.cpp: Copied from kjs/JSGlobalData.cpp.
        * runtime/JSGlobalData.h: Copied from kjs/JSGlobalData.h.
        * runtime/JSLock.cpp: Copied from kjs/JSLock.cpp.
        * runtime/JSLock.h: Copied from kjs/JSLock.h.
        * runtime/JSStaticScopeObject.cpp: Copied from kjs/JSStaticScopeObject.cpp.
        * runtime/JSStaticScopeObject.h: Copied from kjs/JSStaticScopeObject.h.
        * runtime/JSType.h: Copied from kjs/JSType.h.
        * runtime/PropertyNameArray.cpp: Copied from kjs/PropertyNameArray.cpp.
        * runtime/PropertyNameArray.h: Copied from kjs/PropertyNameArray.h.
        * runtime/ScopeChain.cpp: Copied from kjs/ScopeChain.cpp.
        * runtime/ScopeChain.h: Copied from kjs/ScopeChain.h.
        * runtime/ScopeChainMark.h: Copied from kjs/ScopeChainMark.h.
        * runtime/SymbolTable.h: Copied from kjs/SymbolTable.h.
        * runtime/Tracing.d: Copied from kjs/Tracing.d.
        * runtime/Tracing.h: Copied from kjs/Tracing.h.

        WebCore:

        * ForwardingHeaders/kjs/ArgList.h: Removed.
        * ForwardingHeaders/kjs/CollectorHeapIterator.h: Removed.
        * ForwardingHeaders/kjs/ExecState.h: Removed.
        * ForwardingHeaders/kjs/InitializeThreading.h: Removed.
        * ForwardingHeaders/kjs/JSGlobalData.h: Removed.
        * ForwardingHeaders/kjs/JSLock.h: Removed.
        * ForwardingHeaders/kjs/SymbolTable.h: Removed.
        * ForwardingHeaders/runtime/ArgList.h: Copied from ForwardingHeaders/kjs/ArgList.h.
        * ForwardingHeaders/runtime/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/CollectorHeapIterator.h.
        * ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
        * ForwardingHeaders/runtime/InitializeThreading.h: Copied from ForwardingHeaders/kjs/InitializeThreading.h.
        * ForwardingHeaders/runtime/JSGlobalData.h: Copied from ForwardingHeaders/kjs/JSGlobalData.h.
        * ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
        * ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
        * bindings/js/GCController.cpp:
        * bindings/js/JSCustomPositionCallback.cpp:
        * bindings/js/JSCustomPositionErrorCallback.cpp:
        * bindings/js/JSCustomSQLStatementCallback.cpp:
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
        * bindings/js/JSCustomVoidCallback.cpp:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSEventCustom.cpp:
        * bindings/js/JSEventListener.cpp:
        * bindings/js/JSNodeFilterCondition.cpp:
        * bindings/js/ScheduledAction.cpp:
        * bindings/js/ScriptController.cpp:
        * bindings/js/ScriptControllerMac.mm:
        * bindings/objc/WebScriptObject.mm:
        * bridge/NP_jsobject.cpp:
        * bridge/c/c_class.cpp:
        * bridge/c/c_instance.cpp:
        * bridge/c/c_runtime.cpp:
        * bridge/c/c_utility.cpp:
        * bridge/jni/jni_class.cpp:
        * bridge/jni/jni_instance.cpp:
        * bridge/jni/jni_jsobject.mm:
        * bridge/jni/jni_objc.mm:
        * bridge/jni/jni_runtime.cpp:
        * bridge/jni/jni_runtime.h:
        * bridge/jni/jni_utility.cpp:
        * bridge/npruntime.cpp:
        * bridge/objc/objc_instance.mm:
        * bridge/objc/objc_runtime.mm:
        * bridge/objc/objc_utility.mm:
        * bridge/runtime.cpp:
        * dom/Document.cpp:
        * dom/Node.cpp:
        * dom/NodeFilter.cpp:
        * dom/NodeIterator.cpp:
        * dom/TreeWalker.cpp:
        * history/CachedPage.cpp:
        * inspector/InspectorController.cpp:
        * inspector/JavaScriptCallFrame.cpp:
        * inspector/JavaScriptCallFrame.h:
        * inspector/JavaScriptDebugServer.cpp:
        * inspector/JavaScriptProfileNode.cpp:
        * loader/FrameLoader.cpp:
        * loader/icon/IconDatabase.cpp:
        * page/Console.cpp:
        * page/Page.cpp:
        * page/mac/FrameMac.mm:
        * plugins/PluginView.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        * plugins/qt/PluginViewQt.cpp:
        * plugins/win/PluginViewWin.cpp:
        * storage/Database.cpp:
        * xml/XMLHttpRequest.cpp:

        WebKit/gtk:

        * webkit/webkitprivate.cpp:

        WebKit/mac:

        * ForwardingHeaders/kjs/JSLock.h: Removed.
        * ForwardingHeaders/kjs/SymbolTable.h: Removed.
        * ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
        * ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
        * Misc/WebCoreStatistics.mm:
        * Plugins/WebBaseNetscapePluginStream.mm:
        * Plugins/WebBaseNetscapePluginView.mm:
        * Plugins/WebPluginController.mm:
        * WebView/WebFrame.mm:
        * WebView/WebScriptDebugDelegate.mm:
        * WebView/WebView.mm:

        WebKit/qt:

        * Api/qwebpage.cpp:

        WebKit/win:

        * WebJavaScriptCollector.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b91210c0

Reviewed by Steve Falkenburg. · f6778904

mitz@apple.com authored Nov 04, 2008

        - implement WebMutableURLRequest::setHTTPShouldHandleCookies()
        - add and implement WebMutableURLRequest::mutableCopy()

        * Interfaces/IWebURLRequest.idl:
        * WebMutableURLRequest.cpp:
        (WebMutableURLRequest::setHTTPShouldHandleCookies):
        (WebMutableURLRequest::mutableCopy):
        * WebMutableURLRequest.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f6778904

03 Nov, 2008 6 commits

Fix the 64-bit build. · 748e44d4

mrowe@apple.com authored Nov 04, 2008

Pull the frequently-made check for drawingModel == NPDrawingModelQuickDraw out into a
helper function to avoid #ifdef'ing all of the new places that this check is made.

A few other #ifdef's are moved inside functions to allow their call sites to remain #ifdef-free,
and we rely on the compiler to optimise out the check (which will always be false in 64-bit) instead.

* Plugins/WebBaseNetscapePluginView.mm:
(isDrawingModelQuickDraw):
(-[WebBaseNetscapePluginView fixWindowPort]):
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
(-[WebBaseNetscapePluginView updateAndSetWindow]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView tellQuickTimeToChill]):
(-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
(-[WebBaseNetscapePluginView _viewHasMoved]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

748e44d4

2008-11-03 Maciej Stachowiak <mjs@apple.com> · e618cf50

mjs@apple.com authored Nov 04, 2008

        Reviewed by Kevin Decker.
        
        - fix release build (and unitialized variable for CG drawing model!)

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): initialize portState in all code paths



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e618cf50

Reviewed by Anders Carlsson. · eb4eabb2

kdecker@apple.com authored Nov 03, 2008

        https://bugs.webkit.org/show_bug.cgi?id=22053
        
        This patch adds initial support for the NPDrawingModelCoreAnimation drawing model. 
                
        * Plugins/WebBaseNetscapePluginView.h: Added _layer ivar.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation.
        (-[WebBaseNetscapePluginView restorePortState:]): Ditto.
        (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): Slightly refactored a small block of code which with the PortState.
        Plug-ins using the NPDrawingModelCoreAnimation drawing model have no PortState. 
        (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation
        (-[WebBaseNetscapePluginView updateAndSetWindow]):  Ditto.
        (-[WebBaseNetscapePluginView setWindowIfNecessary]): Ditto.
        (-[WebBaseNetscapePluginView start]): If the plug-in is a plug-in using the Core Animation model, request a layer from it.
        (-[WebBaseNetscapePluginView drawRect:]): Return early for NPDrawingModelCoreAnimation plug-ins.
        (-[WebBaseNetscapePluginView getVariable:value:]): Tell plug-ins running on post-Tiger systems WebKit supports
         NPDrawingModelCoreAnimation.
        (-[WebBaseNetscapePluginView setVariable:value:]): Added the new NPDrawingModelCoreAnimation case, which initializes drawingMode.
        (-[WebBaseNetscapePluginView _viewHasMoved]): Reworded the conditional call to updateAndSetWindow to be specific to 
        CoreGraphics and QuickDraw plug-ins.

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=22053

        Added additional support needed for the NPDrawingModelCoreAnimation drawing model. 

        * bridge/npapi.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

eb4eabb2

2008-11-03 Alp Toker <alp@nuanti.com> · 058b2a95

alp@webkit.org authored Nov 03, 2008

        Reviewed by Holger Freyther.

        Deprecate flawed webkit_web_frame_new() function. This would never
        have worked properly when used outside WebCore since Frame::create()
        can only be called without an owner element once in the lifetime of a
        Page and would result in assertions, leaks and an unusable WebView
        instance.

        Frame creation may be exposed in API some time later via the DOM
        binding but probably not in the WebKit GTK+ core API.

        * webkit/webkitwebframe.cpp:
        * webkit/webkitwebframe.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

058b2a95

2008-11-03 Alp Toker <alp@nuanti.com> · ced59bb6

alp@webkit.org authored Nov 03, 2008

        Reviewed by Holger Freyther.

        Redundant scrollbars appear in frames where they shouldn't be visible
        eg. embedded Google adverts.

        Call setCanHaveScrollbars() when necessary. The Mac and Win ports
        already have this but it was missing in FrameLoaderClientGtk.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ced59bb6

2008-11-03 Alp Toker <alp@nuanti.com> · 308791d4

alp@webkit.org authored Nov 03, 2008

        Rubber-stamped by Holger Freyther.

        Sync WebKit GTK+ default UA version string to 528.5+. (We're still
        doing this manually!)

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::composeUserAgent):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

308791d4

31 Oct, 2008 11 commits

2008-10-31 Cameron Zwarich <zwarich@apple.com> · 7d328d5f

cwzwarich@webkit.org authored Nov 01, 2008

        Reviewed by Darin Adler.

        Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
        <https://bugs.webkit.org/show_bug.cgi?id=22019>

        The JSC::Interpreter::shouldPrintExceptions() function is not used at
        all in JavaScriptCore, so it should be moved to WebCore::Console, its
        only user.

        JavaScriptCore:

        * JavaScriptCore.exp:
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:

        WebCore:

        * WebCore.base.exp:
        * page/Console.cpp:
        (WebCore::printToStandardOut):
        (WebCore::Console::shouldPrintExceptions):
        (WebCore::Console::setShouldPrintExceptions):
        * page/Console.h:

        WebKit/mac:

        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics shouldPrintExceptions]):
        (+[WebCoreStatistics setShouldPrintExceptions:]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7d328d5f

Reviewed by Mark Rowe. · 354387a2

christian@webkit.org authored Nov 01, 2008

http://bugs.webkit.org/show_bug.cgi?id=22018
enable-developer-extras doesn't toggle WebInspector

* webkit/webkitwebview.cpp:
Add missing 'if' in notification for 'enable-developer-extras'.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

354387a2

WebCore: · b7f8848d

mitz@apple.com authored Oct 31, 2008

        Reviewed by John Sullivan.

        - WebCore part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

        * dom/Document.cpp:
        (WebCore::Document::cookie): Added checking if cookies are disabled.
        (WebCore::Document::setCookie): Ditto.
        * page/Navigator.cpp:
        (WebCore::Navigator::cookieEnabled): Ditto.
        * page/Page.cpp:
        (WebCore::Page::Page): Initialize m_cookieEnabled to true.
        * page/Page.h:
        (WebCore::Page::cookieEnabled): Added.
        (WebCore::Page::setCookieEnabled): Added.

WebKit/mac:

        Reviewed by John Sullivan.

        - WebKit/mac part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

        * WebView/WebView.mm:
        (-[WebView _cookieEnabled]):
        (-[WebView _setCookieEnabled:]):
        * WebView/WebViewPrivate.h:

WebKit/win:

        Reviewed by John Sullivan.

        - WebKit/win part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

        * Interfaces/IWebViewPrivate.idl:
        * WebView.cpp:
        (WebView::setCookieEnabled):
        (WebView::cookieEnabled):
        * WebView.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b7f8848d

WebCore: · ae80b36e

adele@apple.com authored Oct 31, 2008

2008-10-31  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        WebCore Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
        https://bugs.webkit.org/show_bug.cgi?id=22008

        * platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon): 
        Rename newIconForFile and newIconForFiles to createIconForFile and createIconForFiles.
        * platform/graphics/Icon.h: ditto.
        * platform/graphics/gtk/IconGtk.cpp:
        (WebCore::Icon::createIconForFile): ditto.
        (WebCore::Icon::createIconForFiles): ditto.
        * platform/graphics/mac/IconMac.mm:
        (WebCore::Icon::createIconForFile): ditto.
        (WebCore::Icon::createIconForFiles): ditto.
        * platform/graphics/qt/IconQt.cpp:
        (WebCore::Icon::createIconForFile): ditto.
        (WebCore::Icon::createIconForFiles): ditto.
        * platform/wx/TemporaryLinkStubs.cpp:
        (Icon::createIconForFile): ditto.
        (Icon::createIconForFiles): d...

ae80b36e

2008-10-31 Anders Carlsson <andersca@apple.com> · 21b18256

andersca@apple.com authored Oct 31, 2008

        Reviewed by Kevin Decker.

        Move WebNetscapePluginEventHandler classes to a subgroup of Netscape Plug-Ins.
        
        * WebKit.xcodeproj/project.pbxproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

21b18256

A couple wxMSW build fixes. · 8ca114ef

kevino@webkit.org authored Oct 31, 2008


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8ca114ef

Expand that name! · fa290c84

beidson@apple.com authored Oct 31, 2008



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fa290c84

2008-10-31 Brady Eidson <beidson@apple.com> · eecc8283

beidson@apple.com authored Oct 31, 2008

        Reviewed by Darin

        [WebHistory setLastVisitedTimeInterval:forItem] was internal to WebHistory.mm and 
        completely unused.  Nuke it!

        * History/WebHistory.mm:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

eecc8283

2008-10-31 Darin Adler <darin@apple.com> · 89b67884

darin@apple.com authored Oct 31, 2008

        - try to fix build

        * WebView.cpp:
        (WebView::setCacheModel): Roll out the part of my last change
        that involved no longer using wkCopyFoundationCacheDirectory.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

89b67884

Bug 22002: AX: scroll bars show should not appear in AX hierarchy when... · 2c534eaf

cfleizach@apple.com authored Oct 31, 2008

Bug 22002: AX: scroll bars show should not appear in AX hierarchy when WebFrameView does not allow scrolling
https://bugs.webkit.org/show_bug.cgi?id=22002

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2c534eaf

Explicitly default to building for only the native architecture in debug and release builds. · 222bc73e

mrowe@apple.com authored Oct 31, 2008

Reviewed by Jon Homeycutt.

* Configurations/DebugRelease.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

222bc73e

30 Oct, 2008 7 commits

2008-10-30 Cameron Zwarich <zwarich@apple.com> · a691b5af

cwzwarich@webkit.org authored Oct 31, 2008

        Rubber-stamped by Sam Weinig.

        Create a debugger directory in JavaScriptCore and move the relevant
        files to it.

        JavaScriptCore:

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * VM/CodeBlock.cpp:
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        * debugger: Added.
        * debugger/Debugger.cpp: Copied from kjs/debugger.cpp.
        * debugger/Debugger.h: Copied from kjs/debugger.h.
        * debugger/DebuggerCallFrame.cpp: Copied from kjs/DebuggerCallFrame.cpp.
        * debugger/DebuggerCallFrame.h: Copied from kjs/DebuggerCallFrame.h.
        * kjs/AllInOneFile.cpp:
        * kjs/DebuggerCallFrame.cpp: Removed.
        * kjs/DebuggerCallFrame.h: Removed.
        * kjs/Parser.cpp:
        * kjs/Parser.h:
        * kjs/debugger.cpp: Removed.
        * kjs/debugger.h: Removed.
        * kjs/interpreter.cpp:
        * kjs/nodes.cpp:
        * runtime/FunctionConstructor.cpp:
        * runtime/JSGlobalObject.cpp:

        WebCore:

        * ForwardingHeaders/debugger: Added.
        * ForwardingHeaders/debugger/Debugger.h: Copied from ForwardingHeaders/kjs/debugger.h.
        * ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
        * ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
        * ForwardingHeaders/kjs/debugger.h: Removed.
        * WebCore.pro:
        * bindings/js/ScriptController.cpp:
        * inspector/JavaScriptCallFrame.cpp:
        * inspector/JavaScriptCallFrame.h:
        * inspector/JavaScriptDebugServer.cpp:
        * inspector/JavaScriptDebugServer.h:

        WebKit/mac:

        * ForwardingHeaders/debugger: Added.
        * ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
        * ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
        * WebView/WebScriptDebugDelegate.mm:
        * WebView/WebScriptDebugger.h:
        * WebView/WebScriptDebugger.mm:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a691b5af

2008-10-30 Darin Adler <darin@apple.com> · 37db7a30

darin@apple.com authored Oct 30, 2008

        Reviewed by Sam Weinig.

        - https://bugs.webkit.org/show_bug.cgi?id=21986
          <rdar://problem/6294285> adopt CFURLCopySharedURLCache

        * WebView.cpp:
        (WebView::setCacheModel): Use CFURLCopySharedURLCache if present.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

37db7a30

Reviewed by Sam Weinig. · 2714fcd5

mitz@apple.com authored Oct 30, 2008

        - export WTFReportAssertionFailureWithMessage()

        * WebKit.vcproj/WebKit_debug.def:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2714fcd5

2008-10-30 Alp Toker <alp@nuanti.com> · 6fa6f4b3

alp@webkit.org authored Oct 30, 2008

        Reviewed by Dave Hyatt.

        Fix GIF animations. WebCore will not update animated GIFs if
        the WebView is marked offscreen so we need to call
        frameView->setParentVisible() when necessary like the Mac and Win
        ports do. Regression was introduced around r37155 during the
        HostWindow refactor.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6fa6f4b3

2008-10-29 Anders Carlsson <andersca@apple.com> · cd79e263

andersca@apple.com authored Oct 30, 2008

        Reviewed by Kevin Decker.

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        (WebNetscapePluginStream::~WebNetscapePluginStream):
        (WebNetscapePluginStream::start):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cd79e263

2008-10-30 Alp Toker <alp@nuanti.com> · bb133e2f

alp@webkit.org authored Oct 30, 2008

        Rubber-stamped by Holger Freyther.

        Fix typo in recently added web inspector signal. dettach -> detach.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::detachWindow):
        * webkit/webkitwebinspector.cpp:
        (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bb133e2f

2008-10-30 Alp Toker <alp@nuanti.com> · 1ad44177

alp@webkit.org authored Oct 30, 2008

Bump WebKit GTK+ version to 1.0.3.

Fix version comments for the web inspector added in r37982. Available
since 1.0.3, not 1.0.2.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1ad44177

29 Oct, 2008 9 commits

JavaScriptCore: · 621341ba

sfalken@apple.com authored Oct 30, 2008

2008-10-29 Steve Falkenburg <sfalken@apple.com>

<rdar://problem/6326563> Crash on launch

For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.

Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
the explicit lock/unlock functions, we can avoid this.

Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.

Reviewed by Darin Adler.

* wtf/Threading.h:
(WTF::lockAtomicallyInitializedStaticMutex):
(WTF::unlockAtomicallyInitializedStaticMutex):
* wtf/ThreadingWin.cpp:
(WTF::lockAtomicallyInitializedStaticMutex):
(WTF::unlockAtomicallyInitializedStaticMutex):

WebKit/win:

2008-10-29 Steve Falkenburg <sfalken@apple.com>

<rdar://problem/6326563> Crash on launch

For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.

Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.

Reviewed by Darin Adler.

* WebKit.vcproj/WebKit.def:
* WebKit.vcproj/WebKit_debug.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

621341ba

2008-10-29 Matt Lilek <webkit@mattlilek.com> · 835b1c74

pewtermoose@webkit.org authored Oct 30, 2008

        Not reviewed, build fix.

        * WebKit.xcodeproj/project.pbxproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

835b1c74

2008-10-29 Anders Carlsson <andersca@apple.com> · 9afaff46

andersca@apple.com authored Oct 30, 2008

        Reviewed by Sam Weinig.

        Remove an unused forward class declaration.
        
        * Plugins/WebBaseNetscapePluginView.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9afaff46

2008-10-29 Anders Carlsson <andersca@apple.com> · 4558c152

andersca@apple.com authored Oct 30, 2008

        Reviewed by Sam Weinig.

        Remove WebBaseNetscapePluginViewInternal.h and WebBaseNetscapePluginViewPrivate.h.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginViewInternal.h: Removed.
        * Plugins/WebBaseNetscapePluginViewPrivate.h: Removed.
        * Plugins/WebNetscapePluginEventHandler.mm:
        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        * Plugins/npapi.mm:
        * WebView/WebHTMLView.mm:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4558c152

2008-10-29 Anders Carlsson <andersca@apple.com> · e2b89383

andersca@apple.com authored Oct 29, 2008

        Reviewed by Sam Weinig.

        Remove WebNetscapePluginEmbeddedView, it adds nothing extra now. 
        
        Remove WebNetscapePlugInStreamLoaderClient since WebNetscapePluginStream is the client now.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebKitPluginContainerView.h:
        * Plugins/WebNetscapePluginEmbeddedView.h: Removed.
        * Plugins/WebNetscapePluginEmbeddedView.mm: Removed.
        * Plugins/WebNetscapePluginEventHandler.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (NetscapePluginWidget::NetscapePluginWidget):
        (NetscapePluginWidget::handleEvent):
        (WebFrameLoaderClient::createPlugin):
        * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Removed.
        * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Removed.
        * WebView/WebHTMLView.mm:
        (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e2b89383

2008-10-29 Anders Carlsson <andersca@apple.com> · cd46164f

andersca@apple.com authored Oct 29, 2008

        Reviewed by Sam Weinig.

        Remove the WebBaseNetscapePluginStream Objective-C object.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        (WebNetscapePluginStream::create):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cd46164f

2008-10-29 Gustavo Noronha Silva <gns@gnome.org> · bcca41db

zecke@webkit.org authored Oct 29, 2008

        Reviewed by Holger Freyther.

        Added all the files that need to be installed for the Inspector to
        work.

WebCore/ChangeLog:
2008-10-29  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed and slightly changed by Holger Freyther.

        Added all the files that need to be installed for the Inspector to
        work.

        * GNUmakefile.am: Invoke the shell to get the files.

WebKit/gtk:
2008-10-29  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed and slightly changed by Holger Freyther.

        Implemented a new WebKitWebInspector class to provide a GObject
        API for the Web Inspector. Also implemented InspectorClient.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::notifyWebViewDestroyed):
        (WebKit::InspectorClient::InspectorClient):
        (WebKit::InspectorClient::inspectorDestroyed):
        (WebKit::InspectorClient::webViewDestroyed):
        (WebKit::InspectorClient::createPage):
        (WebKit::InspectorClient::showWindow):
        (WebKit::InspectorClient::closeWindow):
        (WebKit::InspectorClient::attachWindow):
        (WebKit::InspectorClient::detachWindow):
        (WebKit::InspectorClient::inspectedURLChanged):
        * WebCoreSupport/InspectorClientGtk.h:
        * webkit/webkit.h:
        * webkit/webkit-marshal.list:
        * webkit/webkitdefines.h:
        * webkit/webkitprivate.h:
        * webkit/webkitwebinspector.cpp: Added.
        (_WebKitWebInspectorPrivate::webkit_inspect_web_view_request_handled):
        (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
        (_WebKitWebInspectorPrivate::webkit_web_inspector_init):
        (_WebKitWebInspectorPrivate::webkit_web_inspector_finalize):
        (_WebKitWebInspectorPrivate::webkit_web_inspector_set_property):
        (_WebKitWebInspectorPrivate::webkit_web_inspector_get_property):
        (_WebKitWebInspectorPrivate::webkit_web_inspector_set_web_view):
        * webkit/webkitwebinspector.h: Added.
        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        * webkit/webkitwebview.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bcca41db

2008-10-29 Jon Honeycutt <jhoneycutt@apple.com> · fa3ac1af

jhoneycutt@apple.com authored Oct 29, 2008

        Export atomicallyInitializedStaticMutex.

        Rubber-stamped by Steve Falkenburg.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fa3ac1af

wx build fixes after addition of runtime and ImageBuffer changes. · ce2e48a5
kevino@webkit.org authored Oct 29, 2008
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
ce2e48a5