1. 13 Dec, 2010 36 commits
    • mdelaney@apple.com's avatar
      2010-12-09 Matthew Delaney <mdelaney@apple.com> · 9b16ce29
      mdelaney@apple.com authored
              Reviewed by Simon Fraser.
      
              Adopt new CG API for canvas
              https://bugs.webkit.org/show_bug.cgi?id=50591
      
              * WebCoreSupport/WebSystemInterface.mm:
      2010-12-09  Matthew Delaney  <mdelaney@apple.com>
      
              Reviewed by Simon Fraser.
      
              Adopt new CG API for canvas
              https://bugs.webkit.org/show_bug.cgi?id=50591
      
              No new tests. All current layout tests are sufficient.
      
              * html/HTMLCanvasElement.cpp: Add in accelerateRendering flag for imagebuffer creation.
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::isAccelerated): Always return true if using CA on new platforms.
              (WebCore::CanvasRenderingContext2D::drawTextInternal): Use accelerateRendering for imagebuffer.
              * platform/graphics/ImageBuffer.h:
              (WebCore::ImageBuffer::create): Plumb through new flag.
              * platform/graphics/cairo/ImageBufferCairo.cpp: Update method sig.
              * platform/graphics/cg/ImageBufferCG.cpp: Switch off of accelerateRendering flag for new accelerated paths.
              * platform/graphics/cg/ImageBufferData.h: Add in surface ref
              * platform/graphics/haiku/ImageBufferHaiku.cpp: Update method sig.
              * platform/graphics/qt/ImageBufferQt.cpp: ^^
              * platform/graphics/skia/ImageBufferSkia.cpp: ^^
              * platform/graphics/wince/ImageBufferWinCE.cpp: ^^
              * platform/graphics/wx/ImageBufferWx.cpp: ^^
              * platform/mac/WebCoreSystemInterface.h: Add new method sigs
              * platform/mac/WebCoreSystemInterface.mm: ^^
              * rendering/RenderLayerBacking.cpp:
              * rendering/RenderLayerCompositor.cpp: Set acceleratesDrawing for canvas backings.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b16ce29
    • commit-queue@webkit.org's avatar
      2010-12-13 Alex Bredariol Grilo <abgrilo@profusion.mobi> · 8582ca50
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              Remove one row/column of renderers.
              https://bugs.webkit.org/show_bug.cgi?id=50456
      
              This changes the algorithm in a way that it will require one less column
              and row of renderers to fill the viewport. The direct result of this is
              that now less tiles need to be rendered at once when displaying the
              viewport.
      
              * ewk/ewk_tiled_backing_store.c:
              (_ewk_tiled_backing_store_smart_add):
              (_ewk_tiled_backing_store_recalc_renderers):
              (_ewk_tiled_backing_store_view_wrap_up):
              (_ewk_tiled_backing_store_view_wrap_down):
              (_ewk_tiled_backing_store_view_wrap_left):
              (_ewk_tiled_backing_store_view_wrap_right):
              (_ewk_tiled_backing_store_smart_calculate_offset_force):
              (_ewk_tiled_backing_store_smart_calculate_offset):
              (_ewk_tiled_backing_store_smart_calculate):
              (_ewk_tiled_backing_store_zoom_set_internal):
              (ewk_tiled_backing_store_zoom_weak_set):
              (ewk_tiled_backing_store_fix_offsets):
              (ewk_tiled_backing_store_flush):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8582ca50
    • commit-queue@webkit.org's avatar
      2010-12-13 Benjamin Kalman <kalman@chromium.org> · 4890d068
      commit-queue@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Shift-End does not select to the end of the line
              https://bugs.webkit.org/show_bug.cgi?id=50610
      
              * editing/selection/extend-to-line-boundary-expected.txt: Added.
              * editing/selection/extend-to-line-boundary.html: Added.
      2010-12-13  Benjamin Kalman  <kalman@chromium.org>
      
              Reviewed by Ojan Vafai.
      
              Shift-End does not select to the end of the line
              https://bugs.webkit.org/show_bug.cgi?id=50610
      
              Test: editing/selection/extend-to-line-boundary.html
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::positionForPlatform): Use visibleStart/visibleEnd rather than
              start/end.
              (WebCore::SelectionController::modifyExtendingForward):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4890d068
    • pfeldman@chromium.org's avatar
      2010-12-13 Pavel Feldman <pfeldman@chromium.org> · 01eaecaf
      pfeldman@chromium.org authored
              Not reviewed: rebaseline chromium xss tests for window.onerror.
      
              * platform/chromium-linux/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
              * platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
              * platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
              * platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
              * platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
              * platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
              * platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
              * platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
              * platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01eaecaf
    • aroben@apple.com's avatar
      Windows build fix after r73914 · 1feef410
      aroben@apple.com authored
      * WebCore.vcproj/WebCore.vcproj: Fix malformed XML.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1feef410
    • yurys@chromium.org's avatar
      2010-12-13 Yury Semikhatsky <yurys@chromium.org> · 0c8f115d
      yurys@chromium.org authored
              Unreviewed. Qt build fix.
      
              * dom/ScriptExecutionContext.cpp:
              (WebCore::ScriptExecutionContext::ScriptExecutionContext):
              * dom/ScriptExecutionContext.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c8f115d
    • commit-queue@webkit.org's avatar
      2010-12-13 John Knottenbelt <jknotten@chromium.org> · cac3905f
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              Fix layout test dom/fast/Geolocation/permission-denied-already-error.html for client-based Geolocation
              https://bugs.webkit.org/show_bug.cgi?id=50920
      
              * fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cac3905f
    • mario@webkit.org's avatar
      2010-12-13 Mario Sanchez Prada <msanchez@igalia.com> · a9d36ce2
      mario@webkit.org authored
              Reviewed by Xan Lopez.
      
              [Gtk] Additional support is needed for caret browsing
              https://bugs.webkit.org/show_bug.cgi?id=25526
      
              New layout test to check the "MoveTo{Beginninng|End}OfDocument"
              commands when caret browsing is enabled.
      
              * platform/gtk/editing/selection/caret-mode-document-begin-end-expected.txt: Added.
              * platform/gtk/editing/selection/caret-mode-document-begin-end.html: Added.
      2010-12-13  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [Gtk] Additional support is needed for caret browsing
              https://bugs.webkit.org/show_bug.cgi?id=25526
      
              Enable "MoveTo{Beginninng|End}OfDocument" commands when caret
              browsing is enabled.
      
              This change impacts the GTK-port only as caret browsing is a
              feature only used in that platform so far.
      
              Test: platform/gtk/editing/selection/caret-mode-document-begin-end.html
      
              * editing/EditorCommand.cpp:
              (WebCore::createCommandMap): Enable the commads when in caret browsing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9d36ce2
    • yurys@chromium.org's avatar
      2010-12-13 Yury Semikhatsky <yurys@chromium.org> · 89848885
      yurys@chromium.org authored
              Unreviewed. Qt build fix.
      
              * dom/Event.cpp:
              (WebCore::Event::isErrorEvent):
              * dom/Event.h: remove ENABLE(WORKERS) guard since ErrorEvent is now used not
              only in workers.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89848885
    • loislo@chromium.org's avatar
      2010-12-13 Ilya Tikhonovsky <loislo@chromium.org> · 2c950cf3
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * inspector/Inspector.idl:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::didParseSource):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::resetState):
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMAgent.prototype.didCommitLoad):
              * inspector/front-end/Database.js:
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel):
              (WebInspector.DebuggerModel.prototype.pausedScript):
              (WebInspector.DebuggerModel.prototype.resumedScript):
              (WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown):
              (WebInspector.DebuggerModel.prototype.debuggerWasEnabled):
              (WebInspector.DebuggerModel.prototype.debuggerWasDisabled):
              (WebInspector.DebuggerModel.prototype.parsedScriptSource):
              (WebInspector.DebuggerModel.prototype.failedToParseScriptSource):
              (WebInspector.DebuggerModel.prototype.didCreateWorker):
              (WebInspector.DebuggerModel.prototype.didDestroyWorker):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
              (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceManager):
              (WebInspector.ResourceManager.prototype._unbindResourceURL):
              (WebInspector.ResourceManager.prototype.updateDOMStorage):
              (WebInspector.ResourceManager.prototype.updateApplicationCacheStatus):
              (WebInspector.ResourceManager.prototype.didGetFileSystemPath):
              (WebInspector.ResourceManager.prototype.didGetFileSystemError):
              (WebInspector.ResourceManager.prototype.didGetFileSystemDisabled):
              (WebInspector.ResourceManager.prototype.updateNetworkState):
              (WebInspector.ResourceManager.prototype.addDOMStorage):
              (WebInspector.ResourceManager.prototype.selectDOMStorage):
              (WebInspector.ResourceManager.prototype.addDatabase):
              (WebInspector.ResourceManager.prototype.selectDatabase):
              (WebInspector.ResourceManager.prototype.sqlTransactionSucceeded):
              (WebInspector.ResourceManager.prototype.sqlTransactionFailed):
              * inspector/front-end/WorkersSidebarPane.js:
              (WebInspector.Worker):
              * inspector/front-end/inspector.js:
      
      2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * src/js/Tests.js:
              (.TestSuite.prototype._waitForScriptPause):
              (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
              (.TestSuite.prototype._waitUntilScriptsAreParsed):
      
      2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
              (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
              (initialize_DebuggerTest.InspectorTest.showScriptSource):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c950cf3
    • yurys@chromium.org's avatar
      2010-12-13 Yury Semikhatsky <yurys@chromium.org> · d9e7cfb3
      yurys@chromium.org authored
              Unreviewed. Qt build fix. 
      
              * dom/ErrorEvent.cpp:
              * dom/ErrorEvent.h: remove ENABLE(WORKERS) guard since ErrorEvent is now used not
              only in workers.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9e7cfb3
    • yurys@chromium.org's avatar
      2010-12-13 Yury Semikhatsky <yurys@chromium.org> · 68b2822e
      yurys@chromium.org authored
              Reviewed by Adam Barth.
      
              WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
              https://bugs.webkit.org/show_bug.cgi?id=8519
      
              Uncaught exceptions are propagated to window.onerror hander if one is present.
              The handler is expected to be a function accepting three arguments: error message,
              resource url and line number where the exception occured.
      
              * fast/events/resources/window-onerror.js: Added.
              (throwException):
              * fast/events/window-onerror1-expected.txt: Added.
              * fast/events/window-onerror1.html: Added.
              * fast/events/window-onerror10-expected.txt: Added.
              * fast/events/window-onerror10.html: Added.
              * fast/events/window-onerror11-expected.txt: Added.
              * fast/events/window-onerror11.html: Added.
              * fast/events/window-onerror2-expected.txt: Added.
              * fast/events/window-onerror2.html: Added.
              * fast/events/window-onerror3-expected.txt: Added.
              * fast/events/window-onerror3.html: Added.
              * fast/events/window-onerror4-expected.txt: Added.
              * fast/events/window-onerror4.html: Added.
              * fast/events/window-onerror5-expected.txt: Added.
              * fast/events/window-onerror5.html: Added.
              * fast/events/window-onerror6-expected.txt: Added.
              * fast/events/window-onerror6.html: Added.
              * fast/events/window-onerror7-expected.txt: Added.
              * fast/events/window-onerror7.html: Added.
              * fast/events/window-onerror8-expected.txt: Added.
              * fast/events/window-onerror8.html: Added.
              * fast/events/window-onerror9-expected.txt: Added.
              * fast/events/window-onerror9.html: Added.
              * fast/workers/worker-script-error-expected.txt:
              * http/tests/security/resources/onerror-iframe.html: Added.
              * http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
              * http/tests/security/window-onerror-exception-in-iframe.html: Added.
              * platform/chromium-win/fast/workers/worker-script-error-expected.txt:
              * platform/chromium/fast/events/window-onerror1-expected.txt: Added.
              * platform/chromium/fast/events/window-onerror10-expected.txt: Added.
              * platform/chromium/fast/events/window-onerror11-expected.txt: Added.
              * platform/chromium/fast/events/window-onerror2-expected.txt: Added.
              * platform/chromium/fast/events/window-onerror3-expected.txt: Added.
              * platform/chromium/fast/events/window-onerror4-expected.txt: Added.
              * platform/chromium/fast/events/window-onerror5-expected.txt: Added.
              * platform/chromium/fast/events/window-onerror6-expected.txt: Added.
              * platform/chromium/fast/events/window-onerror7-expected.txt: Added.
              * platform/chromium/fast/events/window-onerror8-expected.txt: Added.
              * platform/chromium/fast/events/window-onerror9-expected.txt: Added.
              * platform/chromium/http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
              * platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
              * platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
              * userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
              * userscripts/window-onerror-for-isolated-world-1.html: Added.
              * userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
              * userscripts/window-onerror-for-isolated-world-2.html: Added.
      2010-12-13  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Adam Barth.
      
              WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
              https://bugs.webkit.org/show_bug.cgi?id=8519
      
              Uncaught exceptions are propagated to window.onerror hander if one is present.
              The handler is expected to be a function accepting three arguments: error message,
              resource url and line number where the exception occured.
      
              It was decided to dispatch ErrorEvent to all listeners/handlers no matter if they
              were created in the same isolated world where the exception occured or not.
      
              Tests: fast/events/window-onerror1.html
                     fast/events/window-onerror10.html
                     fast/events/window-onerror11.html
                     fast/events/window-onerror2.html
                     fast/events/window-onerror3.html
                     fast/events/window-onerror4.html
                     fast/events/window-onerror5.html
                     fast/events/window-onerror6.html
                     fast/events/window-onerror7.html
                     fast/events/window-onerror8.html
                     fast/events/window-onerror9.html
                     http/tests/security/window-onerror-exception-in-iframe.html
                     userscripts/window-onerror-for-isolated-world-1.html
                     userscripts/window-onerror-for-isolated-world-2.html
      
              * Android.jscbindings.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.order:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::reportException):
              * bindings/js/JSErrorHandler.cpp: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.cpp.
              (WebCore::JSErrorHandler::JSErrorHandler):
              (WebCore::JSErrorHandler::~JSErrorHandler):
              (WebCore::JSErrorHandler::handleEvent):
              * bindings/js/JSErrorHandler.h: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
              (WebCore::JSErrorHandler::create):
              (WebCore::createJSErrorHandler):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/V8ConsoleMessage.cpp:
              (WebCore::V8ConsoleMessage::dispatchNow):
              (WebCore::V8ConsoleMessage::handler): the method was changed to use generic WebCore exception
              reporting mechanism which is also used by JSC bindings.
              * bindings/v8/V8ConsoleMessage.h:
              * bindings/v8/V8WindowErrorHandler.cpp: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
              (WebCore::V8WindowErrorHandler::V8WindowErrorHandler):
              (WebCore::V8WindowErrorHandler::callListenerFunction):
              * bindings/v8/V8WindowErrorHandler.h: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
              (WebCore::V8WindowErrorHandler::create):
              * bindings/v8/WorkerContextExecutionProxy.cpp:
              (WebCore::v8MessageHandler):
              * bindings/v8/WorkerScriptController.cpp:
              (WebCore::WorkerScriptController::evaluate):
              * dom/Document.cpp:
              (WebCore::Document::errorEventTarget):
              (WebCore::Document::logExceptionToConsole):
              * dom/Document.h:
              * dom/ScriptExecutionContext.cpp:
              (WebCore::ScriptExecutionContext::PendingException::PendingException):
              (WebCore::ScriptExecutionContext::ScriptExecutionContext):
              (WebCore::ScriptExecutionContext::reportException): this method is not virtual anymore to
              ensure that error event dispatching algorithm is the same in WorkerContext and in Document.
              (WebCore::ScriptExecutionContext::dispatchErrorEvent):
              * dom/ScriptExecutionContext.h:
              * workers/DefaultSharedWorkerRepository.cpp:
              (WebCore::postExceptionTask):
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::WorkerContext):
              (WebCore::WorkerContext::errorEventTarget):
              (WebCore::WorkerContext::logExceptionToConsole):
              * workers/WorkerContext.h:
              * workers/WorkerMessagingProxy.cpp:
              (WebCore::WorkerExceptionTask::performTask):
      2010-12-13  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Adam Barth.
      
              WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
              https://bugs.webkit.org/show_bug.cgi?id=8519
      
              Uncaught exceptions are propagated to window.onerror hander if one is present.
              The handler is expected to be a function accepting three arguments: error message,
              resource url and line number where the exception occured.
      
              * src/WebWorkerClientImpl.cpp:
              (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
              (WebKit::WebWorkerClientImpl::postExceptionToWorkerObjectTask):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68b2822e
    • apavlov@chromium.org's avatar
      2010-12-08 Alexander Pavlov <apavlov@chromium.org> · 1faa001a
      apavlov@chromium.org authored
              Reviewed by Joseph Pecoraro.
      
              Web Inspector: Enable CSS property editing name/value-wise (like Firebug does)
              https://bugs.webkit.org/show_bug.cgi?id=50565
      
              For CSS property editing, the property name and value have become two fields separated
              by a colon (rather than one field containing the full property text.) A user can tab
              between the name and value fields forward and backward. A colon typed in the name field
              and a semicolon in the value field (unless found inside a string) act as a Tab and focus
              the next editable field (while applying the entire property value.)
      
              Now a user can tab through all editable styles for an element, even across rule boundaries.
      
              WebCore:
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint):
              * inspector/front-end/DataGrid.js:
              (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
              (WebInspector.DataGrid.prototype._startEditing):
              * inspector/front-end/ElementsTreeOutline.js:
              (WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
              (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
              (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
              (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
              * inspector/front-end/MetricsSidebarPane.js:
              (WebInspector.MetricsSidebarPane.prototype.startEditing):
              * inspector/front-end/ObjectPropertiesSection.js:
              (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
              * inspector/front-end/Section.js:
              (WebInspector.Section):
              (WebInspector.Section.prototype.get subtitleAsTextForTest):
              (WebInspector.Section.prototype.get nextSibling):
              (WebInspector.Section.prototype.get previousSibling):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._editBreakpointCondition):
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylePropertiesSection.prototype.nextEditableSibling):
              (WebInspector.StylePropertiesSection.prototype.previousEditableSibling):
              (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
              (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
              (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
              (WebInspector.StylePropertyTreeElement.prototype.):
              (WebInspector.StylePropertyTreeElement.prototype):
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextViewer.prototype._handleDoubleClick):
              * inspector/front-end/WatchExpressionsSidebarPane.js:
              (WebInspector.WatchExpressionTreeElement.prototype.startEditing):
              * inspector/front-end/inspector.css:
              (.child-editing):
              * inspector/front-end/inspector.js:
              (WebInspector.startEditing.defaultFinishHandler):
              (WebInspector.startEditing):
              * inspector/front-end/treeoutline.js:
              (TreeElement.prototype.select):
      
              LayoutTests:
              * inspector/console-dir.html:
              * inspector/styles-add-blank-property.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1faa001a
    • yael.aharon@nokia.com's avatar
      Unreviewed. · b3e168d3
      yael.aharon@nokia.com authored
      Added svn propery eol-style. Patches to this file fail to apply on Windows EWS bot.
      
      * accessibility/AccessibilityAllInOne.cpp: Added property svn:eol-style.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3e168d3
    • commit-queue@webkit.org's avatar
      2010-12-13 W. James MacLean <wjmaclean@chromium.org> · 7e72aca6
      commit-queue@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              Remove unnecessary pixel results, use platform-independent text results, re Changeset 72802
              https://bugs.webkit.org/show_bug.cgi?id=50233
      
              Remove redundant, platform-specific test results.
      
              * platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.txt: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.txt: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.txt: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.txt: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.txt: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-1-expected.txt: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-2-expected.txt: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-3-expected.txt: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-4-expected.txt: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-5-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e72aca6
    • loislo@chromium.org's avatar
      2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com> · 19f95c35
      loislo@chromium.org authored
              Unreviewed, rolling out r73898.
              http://trac.webkit.org/changeset/73898
              https://bugs.webkit.org/show_bug.cgi?id=50919
      
              FileSystem and Database API's were broken (Requested by loislo
              on #webkit).
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
              (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
              (initialize_DebuggerTest.InspectorTest.showScriptSource):
      2010-12-13  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73898.
              http://trac.webkit.org/changeset/73898
              https://bugs.webkit.org/show_bug.cgi?id=50919
      
              FileSystem and Database API's were broken (Requested by loislo
              on #webkit).
      
              * inspector/Inspector.idl:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::didParseSource):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::resetState):
              * inspector/front-end/DOMAgent.js:
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel):
              (WebInspector.DebuggerModel.prototype.debuggerPaused):
              (WebInspector.DebuggerModel.prototype.debuggerResumed):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceManager):
              (WebInspector.ResourceManager.prototype._registerNotifyHandlers):
              (WebInspector.ResourceManager.prototype._unbindResourceURL):
              * inspector/front-end/inspector.js:
              (WebInspector.addDatabase):
              (WebInspector.addDOMStorage):
              (WebInspector.updateDOMStorage):
              (WebInspector.updateApplicationCacheStatus):
              (WebInspector.didGetFileSystemPath):
              (WebInspector.didGetFileSystemError):
              (WebInspector.didGetFileSystemDisabled):
              (WebInspector.updateNetworkState):
              (WebInspector.attachDebuggerWhenShown):
              (WebInspector.debuggerWasEnabled):
              (WebInspector.debuggerWasDisabled):
              (WebInspector.profilerWasEnabled):
              (WebInspector.profilerWasDisabled):
              (WebInspector.parsedScriptSource):
              (WebInspector.restoredBreakpoint):
              (WebInspector.failedToParseScriptSource):
              (WebInspector.pausedScript):
              (WebInspector.resumedScript):
              (WebInspector.resetProfilesPanel):
              (WebInspector.didCommitLoad):
              (WebInspector.addProfileHeader):
              (WebInspector.setRecordingProfile):
              (WebInspector.addHeapSnapshotChunk):
              (WebInspector.finishHeapSnapshot):
      2010-12-13  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73898.
              http://trac.webkit.org/changeset/73898
              https://bugs.webkit.org/show_bug.cgi?id=50919
      
              FileSystem and Database API's were broken (Requested by loislo
              on #webkit).
      
              * src/js/Tests.js:
              (.TestSuite.prototype._waitForScriptPause):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19f95c35
    • paroga@webkit.org's avatar
      2010-12-13 Patrick Gansterer <paroga@webkit.org> · b216c8e3
      paroga@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              Add revlink to BuildBot status
              https://bugs.webkit.org/show_bug.cgi?id=50914
      
              This adds a hyperlink to trac changeset on the revision numbers.
      
              * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b216c8e3
    • antonm@chromium.org's avatar
      2010-12-13 Anton Muhin <antonm@chromium.org> · 17227a3a
      antonm@chromium.org authored
              Reviewed by Pavel Feldman.
      
              [v8] More CSS wrappers GC work: keep document's style sheets, style sheet and css rule lists' items in proper object groups
              https://bugs.webkit.org/show_bug.cgi?id=50828
      
              * bindings/v8/DOMData.h:
              (WebCore::DOMData::WrapperMapObjectRemover::visitDOMWrapper):
              (WebCore::DOMData::removeObjectsFromWrapperMap):
              * bindings/v8/DOMDataStore.h:
              (WebCore::ChunkedTable::visit):
              (WebCore::ChunkedTable::visitEntries):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visit):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
              * bindings/v8/V8DOMMap.cpp:
              (WebCore::removeAllDOMObjectsInCurrentThread):
              (WebCore::visitDOMNodesInCurrentThread):
              (WebCore::visitDOMObjectsInCurrentThread):
              (WebCore::visitActiveDOMObjectsInCurrentThread):
              (WebCore::visitDOMSVGElementInstancesInCurrentThread):
              * bindings/v8/V8DOMMap.h:
              (WebCore::WeakReferenceMap::visit):
              * bindings/v8/V8GCController.cpp:
              (WebCore::DOMObjectVisitor::visitDOMWrapper):
              (WebCore::EnsureWeakDOMNodeVisitor::visitDOMWrapper):
              (WebCore::GCPrologueVisitor::visitDOMWrapper):
              (WebCore::NodeGrouperVisitor::visitDOMWrapper):
              (WebCore::NodeGrouperVisitor::applyGrouping):
              (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
              (WebCore::GCEpilogueVisitor::visitDOMWrapper):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17227a3a
    • commit-queue@webkit.org's avatar
      2010-12-13 Carlos Garcia Campos <cgarcia@igalia.com> · 2ce8d914
      commit-queue@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Do not use GET_PRIVATE macros
              https://bugs.webkit.org/show_bug.cgi?id=50915
      
              GET_PRIVATE macros are slow and should only be used in the object
              init() method.
      
              * WebCoreSupport/ContextMenuClientGtk.cpp:
              (WebKit::inputMethodsMenuItem):
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::postProgressFinishedNotification):
              (WebKit::FrameLoaderClient::setTitle):
              (WebKit::FrameLoaderClient::dispatchCreatePage):
              (WebKit::postCommitFrameViewSetup):
              * webkit/webkitdownload.cpp:
              (webkit_download_init):
              * webkit/webkitgeolocationpolicydecision.cpp:
              (webkit_geolocation_policy_decision_init):
              * webkit/webkithittestresult.cpp:
              (webkit_hit_test_result_init):
              * webkit/webkitnetworkrequest.cpp:
              (webkit_network_request_init):
              * webkit/webkitsecurityorigin.cpp:
              (webkit_security_origin_init):
              * webkit/webkitsecurityoriginprivate.h:
              * webkit/webkitviewportattributes.cpp:
              (webkit_viewport_attributes_init):
              * webkit/webkitwebbackforwardlist.cpp:
              (webkit_web_back_forward_list_init):
              * webkit/webkitwebdatabase.cpp:
              (webkit_web_database_init):
              * webkit/webkitwebdatasource.cpp:
              (webkit_web_data_source_init):
              * webkit/webkitwebframe.cpp:
              (webkit_web_frame_init):
              (webkit_web_frame_new):
              * webkit/webkitwebframeprivate.h:
              * webkit/webkitwebhistoryitem.cpp:
              (webkit_web_history_item_init):
              * webkit/webkitwebinspector.cpp:
              (webkit_web_inspector_init):
              * webkit/webkitwebnavigationaction.cpp:
              (webkit_web_navigation_action_init):
              * webkit/webkitwebplugin.cpp:
              (webkit_web_plugin_init):
              * webkit/webkitwebplugindatabase.cpp:
              (webkit_web_plugin_database_init):
              * webkit/webkitwebplugindatabaseprivate.h:
              * webkit/webkitwebpluginprivate.h:
              * webkit/webkitwebpolicydecision.cpp:
              (webkit_web_policy_decision_init):
              * webkit/webkitwebresource.cpp:
              (webkit_web_resource_init):
              * webkit/webkitwebresourceprivate.h:
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_init):
              * webkit/webkitwebview.cpp:
              (PopupMenuPositionFunc):
              (webkit_web_view_forward_context_menu_event):
              (webkit_web_view_drag_end):
              (webkit_web_view_drag_data_get):
              (webkit_web_view_query_tooltip):
              (webkit_web_view_init):
              * webkit/webkitwebwindowfeatures.cpp:
              (webkit_web_window_features_init):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ce8d914
    • abecsi@webkit.org's avatar
      2010-12-13 Andras Becsi <abecsi@webkit.org> · 7ae981c9
      abecsi@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              [Qt][WK2] Fix build if WebKitTools are not available
              https://bugs.webkit.org/show_bug.cgi?id=50242
      
              * DerivedSources.pro: add new DerivedSources.pro to SUBDIRS.
      2010-12-13  Andras Becsi  <abecsi@webkit.org>
      
              Reviewed by Csaba Osztrogonác.
      
              [Qt][WK2] Fix build if WebKitTools are not available
              https://bugs.webkit.org/show_bug.cgi?id=50242
      
              * DerivedSources.pro: Remove dependency to WebKitTools.
              * Scripts/generate-forwarding-headers.pl: Moved from WebKitTools/Scripts/generate-forwarding-headers.pl.
      2010-12-13  Andras Becsi  <abecsi@webkit.org>
      
              Reviewed by Csaba Osztrogonác.
      
              [Qt][WK2] Fix build if WebKitTools are not available
              https://bugs.webkit.org/show_bug.cgi?id=50242
      
              * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
              * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
              * MiniBrowser/DerivedSources.pro: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ae981c9
    • zherczeg@webkit.org's avatar
      Unreviewed build fix for r73894. · 0473a745
      zherczeg@webkit.org authored
      SVGFEImage should also check its hasResult() in its apply().
      
      * svg/graphics/filters/SVGFEImage.cpp:
      (WebCore::FEImage::apply):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0473a745
    • abecsi@webkit.org's avatar
      2010-12-13 Peter Varga <pvarga@inf.u-szeged.hu> · c9c81959
      abecsi@webkit.org authored
              Reviewed by Gavin Barraclough.
      
              Reduce the size of the RegexStackSpaceForBackTrackInfoParentheses in YARR
              https://bugs.webkit.org/show_bug.cgi?id=49385
      
              Remove the BackTrackInfoParentheses struct prevBegin and prevEnd members.
      
              * yarr/RegexInterpreter.cpp:
              (JSC::Yarr::Interpreter::matchParentheses):
              (JSC::Yarr::Interpreter::backtrackParentheses):
              * yarr/RegexPattern.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9c81959
    • ossy@webkit.org's avatar
      Unreviewed. · 594da2e1
      ossy@webkit.org authored
      [Qt] fast/loader/user-stylesheet-fast-path.html fails
      https://bugs.webkit.org/show_bug.cgi?id=50911
      
      * platform/qt/Skipped: Add the failing test until fix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      594da2e1
    • pfeldman@chromium.org's avatar
      2010-12-13 Pavel Feldman <pfeldman@chromium.org> · 936ced0c
      pfeldman@chromium.org authored
              Not reviewed. Updated chromium gpu test expectations.
      
              * platform/chromium-gpu/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      936ced0c
    • pfeldman@chromium.org's avatar
      2010-12-13 Pavel Feldman <pfeldman@chromium.org> · e216cd41
      pfeldman@chromium.org authored
              Not reviewed. Updated chromium test expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e216cd41
    • loislo@chromium.org's avatar
      2010-12-13 Ilya Tikhonovsky <loislo@chromium.org> · 21577ea9
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * inspector/Inspector.idl:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::didParseSource):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::resetState):
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMAgent.prototype.didCommitLoad):
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel):
              (WebInspector.DebuggerModel.prototype.pausedScript):
              (WebInspector.DebuggerModel.prototype.resumedScript):
              (WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown):
              (WebInspector.DebuggerModel.prototype.debuggerWasEnabled):
              (WebInspector.DebuggerModel.prototype.debuggerWasDisabled):
              (WebInspector.DebuggerModel.prototype.parsedScriptSource):
              (WebInspector.DebuggerModel.prototype.failedToParseScriptSource):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype.addHeapSnapshots):
              (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
              (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceManager):
              (WebInspector.ResourceManager.prototype._unbindResourceURL):
              (WebInspector.ResourceManager.prototype.updateDOMStorage):
              (WebInspector.ResourceManager.prototype.updateApplicationCacheStatus):
              (WebInspector.ResourceManager.prototype.didGetFileSystemPath):
              (WebInspector.ResourceManager.prototype.didGetFileSystemError):
              (WebInspector.ResourceManager.prototype.didGetFileSystemDisabled):
              (WebInspector.ResourceManager.prototype.updateNetworkState):
              (WebInspector.ResourceManager.prototype.addDatabase):
              (WebInspector.ResourceManager.prototype.addDOMStorage):
              * inspector/front-end/inspector.js:
      
      2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * src/js/Tests.js:
              (.TestSuite.prototype._waitForScriptPause):
      
      2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
              (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
              (initialize_DebuggerTest.InspectorTest.showScriptSource):
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21577ea9
    • pfeldman@chromium.org's avatar
      2010-12-13 Pavel Feldman <pfeldman@chromium.org> · 1b46a724
      pfeldman@chromium.org authored
              Not reviewed. Updated chromium test expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b46a724
    • pfeldman@chromium.org's avatar
      2010-12-13 Pavel Feldman <pfeldman@chromium.org> · 22692cd1
      pfeldman@chromium.org authored
              Not reviewed. Updated chromium test expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22692cd1
    • eric@webkit.org's avatar
      2010-12-13 Eric Seidel <eric@webkit.org> · df3b8be7
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              EWS Queues should remove orpahned pyc files before starting
              https://bugs.webkit.org/show_bug.cgi?id=50904
      
              A previous check added a platform.py which caused
              EWS bots on some platforms to hit an import exception.
              The platform.py file was removed in a subsequent commit, but
              the EWS bots in question stayed stuck.  This change will
              fix those bots once restarted (and prevent this in the future).
      
              I also went ahead and unified start-queue and start-commit-queue
              since they were nearly identical.  I also added bot_id support
              to both force all EWSes to have bot ids as well as get rid of the one
              remaining reason why I had my own copies of these scripts.
              Hopefully this will be enough to get all the other bot admins
              (ahem, Adam, ahem) to move to using these checked in copies as well.
      
              * EWSTools/start-commit-queue.sh: Removed.
              * EWSTools/start-queue.sh:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df3b8be7
    • zherczeg@webkit.org's avatar
      Better result passing in filter primitives · 2cc3139b
      zherczeg@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49907
      
      Reviewed by Dirk Schulze.
      
      SVG filter primitives can use the output of other filters. The
      input and output format of a filter can be a premultiplied or
      unmultiplied RGBA array, or an image buffer. All filter
      primitive results were converted to image buffers before, which
      could be an unecessary (and really costly) operation, if
      a filter expects its input in the same format as the output
      of the input filter primitive. This overhead is removed by
      this patch. All apply() methods are updated according to this
      new filter primitive interface.
      
      Filters do not generate their results twice (or more) anymore,
      when their apply() called multiple times.
      
      The existing tests cover this feature.
      
      * manual-tests/svg-filter-animation.svg: Added.
      * platform/graphics/filters/FEBlend.cpp:
      (WebCore::FEBlend::apply):
      * platform/graphics/filters/FEColorMatrix.cpp:
      (WebCore::FEColorMatrix::apply):
      * platform/graphics/filters/FEComponentTransfer.cpp:
      (WebCore::FEComponentTransfer::apply):
      * platform/graphics/filters/FEComposite.cpp:
      (WebCore::FEComposite::apply):
      * platform/graphics/filters/FEConvolveMatrix.cpp:
      (WebCore::FEConvolveMatrix::apply):
      * platform/graphics/filters/FEDisplacementMap.cpp:
      (WebCore::FEDisplacementMap::apply):
      * platform/graphics/filters/FEFlood.cpp:
      (WebCore::FEFlood::apply):
      * platform/graphics/filters/FEGaussianBlur.cpp:
      (WebCore::FEGaussianBlur::apply):
      * platform/graphics/filters/FELighting.cpp:
      (WebCore::FELighting::apply):
      * platform/graphics/filters/FEMerge.cpp:
      (WebCore::FEMerge::apply):
      * platform/graphics/filters/FEMerge.h:
      * platform/graphics/filters/FEMorphology.cpp:
      (WebCore::FEMorphology::apply):
      * platform/graphics/filters/FEOffset.cpp:
      (WebCore::FEOffset::apply):
      * platform/graphics/filters/FETile.cpp:
      (WebCore::FETile::apply):
      * platform/graphics/filters/FETurbulence.cpp:
      (WebCore::FETurbulence::apply):
      * platform/graphics/filters/FilterEffect.cpp:
      (WebCore::FilterEffect::requestedRegionOfInputImageData):
      (WebCore::FilterEffect::asImageBuffer):
      (WebCore::FilterEffect::asUnmultipliedImage):
      (WebCore::FilterEffect::asPremultipliedImage):
      (WebCore::FilterEffect::copyImageBytes):
      (WebCore::FilterEffect::copyUnmultipliedImage):
      (WebCore::FilterEffect::copyPremultipliedImage):
      (WebCore::FilterEffect::createImageBufferResult):
      (WebCore::FilterEffect::createUnmultipliedImageResult):
      (WebCore::FilterEffect::createPremultipliedImageResult):
      * platform/graphics/filters/FilterEffect.h:
      (WebCore::FilterEffect::hasResult):
      * platform/graphics/filters/SourceAlpha.cpp:
      (WebCore::SourceAlpha::apply):
      * platform/graphics/filters/SourceGraphic.cpp:
      (WebCore::SourceGraphic::apply):
      * platform/graphics/filters/SourceGraphic.h:
      * rendering/RenderSVGResourceFilter.cpp:
      (WebCore::RenderSVGResourceFilter::postApplyResource):
      * svg/graphics/filters/SVGFEImage.cpp:
      (WebCore::FEImage::apply):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cc3139b
    • paroga@webkit.org's avatar
      2010-12-13 Patrick Gansterer <paroga@webkit.org> · fd9d0d7b
      paroga@webkit.org authored
              Reviewed by Eric Seidel.
      
              Move user stylesheet test into platform independent directory
              https://bugs.webkit.org/show_bug.cgi?id=47335
      
              There is nothing platform specific in the test, so move it out of the mac directory.
      
              * fast/loader/user-stylesheet-fast-path-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt.
              * fast/loader/user-stylesheet-fast-path.html: Copied from LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html.
              * platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt: Removed.
              * platform/mac/fast/loader/user-stylesheet-fast-path.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd9d0d7b
    • ossy@webkit.org's avatar
      Unreviewed. · 9e10c897
      ossy@webkit.org authored
      WebCore: 
      
      * WebCore.pro: Remove non-existant loader/Request.h from build system.
      
      WebKit2: 
      
      * WebKit2.pro: Remove non-existant Shared/DrawingAreaBase.h from build system.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e10c897
    • morrita@google.com's avatar
      2010-12-13 MORITA Hajime <morrita@google.com> · a70cbb62
      morrita@google.com authored
              Unreviewed expectation update.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a70cbb62
    • commit-queue@webkit.org's avatar
      2010-12-13 Noel Gordon <noel.gordon@gmail.com> · 0458085c
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [chromium] Reduce canvas.toDataURL("image/jpeg") run-time cost by 10%
              https://bugs.webkit.org/show_bug.cgi?id=50804
      
              Follow on from r73173, unroll the SkUnPreMultiply::PMColorToColor() call
              viz., compute the unpremultiplatcion in-place. This reduces the run-time
              cost of jpeg encoding by 10-15% for my image test set.
      
              No new tests: canvas.toDataURL() is covered by existing tests.
      
              * platform/image-encoders/skia/JPEGImageEncoder.cpp:
              (WebCore::preMultipliedBGRAtoRGB):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0458085c
    • commit-queue@webkit.org's avatar
      2010-12-13 Helder Correia <helder@sencha.com> · 240961ae
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Qt] StillImage::draw() should use ContextShadow
              https://bugs.webkit.org/show_bug.cgi?id=50849
      
              The branch that checks for a shadow requirement in StillImage::draw()
              is executed when drawing a canvas onto a canvas with
              ctx1.drawImage(canvas2, x, y). The current implementation supports
              solid shadows only. And if transformations are present, the offset gets
              transformed as well. Thus, ContextShadow must be used instead in order
              to support blur and correct offset transformations.
      
              * fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
              * fast/canvas/canvas-draw-canvas-on-canvas-shadow.html: Added.
              * fast/canvas/script-tests/canvas-draw-canvas-on-canvas-shadow.js: Added.
      2010-12-13  Helder Correia  <helder@sencha.com>
      
              Reviewed by Eric Seidel.
      
              [Qt] StillImage::draw() should use ContextShadow
              https://bugs.webkit.org/show_bug.cgi?id=50849
      
              The branch that checks for a shadow requirement in StillImage::draw()
              is executed when drawing a canvas onto a canvas with
              ctx1.drawImage(canvas2, x, y). The current implementation supports
              solid shadows only. And if transformations are present, the offset gets
              transformed as well. Thus, ContextShadow must be used instead in order
              to support blur and correct offset transformations.
      
              Test: fast/canvas/canvas-draw-canvas-on-canvas-shadow.html
      
              * platform/graphics/qt/StillImageQt.cpp:
              (WebCore::StillImage::draw):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      240961ae
    • jhoneycutt@apple.com's avatar
      Unreviewed build fix. · 362d5d17
      jhoneycutt@apple.com authored
      * editing/EditingAllInOne.cpp:
      Add new file to the all-in-one.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      362d5d17
  2. 12 Dec, 2010 4 commits
    • jhoneycutt@apple.com's avatar
      Unreviewed build fix. · c155011a
      jhoneycutt@apple.com authored
      * WebCore.vcproj/WebCore.vcproj:
      Remove accidentally-committed conflict marker.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c155011a
    • morrita@google.com's avatar
      2010-10-28 MORITA Hajime <morrita@google.com> · 7a18feed
      morrita@google.com authored
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              * editing/spelling/script-tests/spellcheck-paste.js: Added.
              * editing/spelling/spellcheck-paste.html: Added.
              * editing/spelling/spellcheck-paste-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac-leopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              - Introduced SpellChecker class to encapsulate asynchronous spell
                checker state: sequence id, requesting text and target node.
                This is also the first step to decompose spell-check related
                code to a separate class.
              - Added EditorClient::isAsynchronousSpellCheckingEnabled()
                to use async spellcheck API on the platform.
                These APIs are touched by SpellChecker.
              - Used SpellChecker to check a pasted test. Text to check is
                collected from the subtree under the editingRoot.
              - Added Setting::m_asynchronousSpellCheckingEnabled to control
                async spell checking.
      
              Test: editing/spelling/spellcheck-paste.html
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/DocumentMarkerController.cpp:
              (WebCore::DocumentMarkerController::showMarkers):
              (showDocumentMarkers):
              * dom/DocumentMarkerController.h:
              * dom/PositionIterator.cpp:
              (WebCore::PositionIterator::setOffsetInLeafNode):
              * dom/PositionIterator.h:
              * editing/Editor.cpp:
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::Editor):
              (WebCore::findFirstMarkable):
              (WebCore::Editor::selectionStartHasSpellingMarkerFor):
              * editing/Editor.h:
              (WebCore::Editor::spellChecker):
              * editing/SpellChecker.cpp: Added.
              (WebCore::SpellChecker::SpellChecker):
              (WebCore::SpellChecker::~SpellChecker):
              (WebCore::SpellChecker::initRequest):
              (WebCore::SpellChecker::clearRequest):
              (WebCore::SpellChecker::isAsynchronousEnabled):
              (WebCore::SpellChecker::canCheckAsynchronously):
              (WebCore::SpellChecker::isBusy):
              (WebCore::SpellChecker::isValid):
              (WebCore::SpellChecker::isCheckable):
              (WebCore::SpellChecker::requestCheckingFor):
              (WebCore::forwardIterator):
              (WebCore::SpellChecker::didCheck):
              * editing/SpellChecker.h: Added.
              (WebCore::SpellCheckingResult::SpellCheckingResult):
              (WebCore::SpellCheckingResult::type):
              (WebCore::SpellCheckingResult::location):
              (WebCore::SpellCheckingResult::length):
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::requestCheckingOfString):
              * page/EditorClient.h:
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h:
              (WebCore::Settings::setAsynchronousSpellCheckingEnabled):
              (WebCore::Settings::asynchronousSpellCheckingEnabled):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * src/EditorClientImpl.h:
              (WebKit::EditorClientImpl::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientEfl.h:
              (WebCore::EditorClientEfl::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientGtk.h:
              (WebKit::EditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientHaiku.h:
              (WebCore::EditorClientHaiku::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added asynchronous spell checking API to WebEditorClient using
              -[NSSpellChecker requestCheckingOfString].
              Note that WebEditorSpellCheckResponder is a small class to receive
              requested spell-checking result. Note that this feature is
              disabled at default.
      
              Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
              enable the feature from LayoutTestController.
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
              (-[WebEditorSpellCheckResponder perform]):
              (toCoreSpellingResult):
              (-[WebEditorSpellCheckResponder WTF::WebCore::]):
              (WebEditorClient::requestCheckingOfString):
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
              (-[WebPreferences asynchronousSpellCheckingEnabled]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientQt.h:
              (WebCore::EditorClientQt::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientWinCE.h:
              (WebKit::EditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebKitSupport/EditorClientWx.h:
              (WebCore::EditorClientWx::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::requestCheckingOfString):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
              to control the setting.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setAsynchronousSpellCheckingEnabledCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a18feed
    • tonikitoo@webkit.org's avatar
      2010-12-09 Antonio Gomes <agomes@rim.com> · 237c1ea4
      tonikitoo@webkit.org authored
              Reviewed by Daniel Bates.
      
              Spatial Navigation: code clean up (part II)
              https://bugs.webkit.org/show_bug.cgi?id=50666
      
              No new tests needed.
      
              * page/FocusController.cpp: Removed static declaration of updateFocusCandidateIfNeeded() from
              the top of FocusController.cpp, and added the 'static' keyword where the function is implemented;
              * page/SpatialNavigation.cpp: In FocusCandidate constructor, renamed 'n' to 'node', and added an assert to it;
              (WebCore::FocusCandidate::FocusCandidate):
              (WebCore::virtualRectForAreaElementAndDirection): Added an assert to 'node';
              * page/SpatialNavigation.h:I reordered the declaration of some methods in order to group related ones;
              Removed isScrollableContainerNode() function declaration since it is not used outside SpatialNavigation.cpp;
              And removed the declaration of isNodeDeepDescendantOfDocument() since it does not exist anymore.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      237c1ea4
    • bweinstein@apple.com's avatar
      WebKit2: Implement WebInspector::localizedStringsURL on Windows · b0a37b0b
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50896
              
      Reviewed by Tim Hatcher.
      
      Find the localized strings file using CFBundleCopyResourceURL.
      
      * WebProcess/WebPage/win/WebInspectorWin.cpp:
      (WebKit::WebInspector::localizedStringsURL):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0a37b0b