- 17 Aug, 2010 12 commits
-
-
xan@webkit.org authored
Reviewed by Gustavo Noronha. [GTK] Fix wrapping of core Events in the bindings https://bugs.webkit.org/show_bug.cgi?id=44095 Return the proper GObject type instead of hardcoding WebKitDOMEvent for all Event types. * bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::handleEvent): * bindings/gobject/WebKitDOMBinding.cpp: (WebKit::kit): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Reviewed by Gustavo Noronha. Revert supposed build-fix which was in fact reverting a previous build fix which was correct (oh dear). * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vestbo@webkit.org authored
Reviewed by Antonio Gomes. * platform/graphics/qt/MediaPlayerPrivateQt.cpp: * platform/graphics/qt/MediaPlayerPrivateQt.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vestbo@webkit.org authored
Reviewed by Antonio Gomes. This ensures we get correct size-hints from QtMultimedia, as well as the media states Buffering and Buffered instead of Loading and Loaded, which we use to transition into MediaPlayer::HaveEnoughData. * platform/graphics/qt/MediaPlayerPrivateQt.cpp: * platform/graphics/qt/MediaPlayerPrivateQt.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Shinichiro Hamaji. Avoid uninitialized memory read in StringImpl::find(). REGRESSION(r65468): Crashes in StringImpl::find https://bugs.webkit.org/show_bug.cgi?id=44099 * wtf/text/StringImpl.cpp: (WTF::StringImpl::find): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vestbo@webkit.org authored
Reviewed by Kenneth Christiansen. https://bugs.webkit.org/show_bug.cgi?id=35427 * css/mediaControlsQt.css: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vestbo@webkit.org authored
Reviewed by Kenneth Christiansen. * WebCoreSupport/ChromeClientQt.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: upstream Chromium console tests https://bugs.webkit.org/show_bug.cgi?id=44057 * inspector/console-eval-expected.txt: Added. * inspector/console-eval-global-expected.txt: Added. * inspector/console-eval-global.html: Added. * inspector/console-eval.html: Added. * platform/chromium/inspector/console-eval-global-expected.txt: Added. 2010-08-17 Yury Semikhatsky <yurys@chromium.org> Reviewed by Pavel Feldman. Web Inspector: upstream Chromium console tests and remove a couple of tests that have already been covered with layout tests. https://bugs.webkit.org/show_bug.cgi?id=44057 * src/js/Tests.js: (.TestSuite.prototype.testConsoleEval): (.TestSuite.prototype.testConsoleLog): (.TestSuite.prototype.testEvalGlobal): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Ariya Hidayat. [Qt] tests whose bug was closed but are still skipped https://bugs.webkit.org/show_bug.cgi?id=44068 Enable tests whose bugs have been fixed already: https://bugs.webkit.org/show_bug.cgi?id=35350 (fixed) https://bugs.webkit.org/show_bug.cgi?id=28952 (fixed) https://bugs.webkit.org/show_bug.cgi?id=38502 (see discussion at the end) https://bugs.webkit.org/show_bug.cgi?id=38604 (fixed) * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ariya@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Reduce the size of the shadow buffer to the clip region https://bugs.webkit.org/show_bug.cgi?id=44091 Instead of allocating the buffer image (for the blur support) as big as the rectangle which casts the shadow, we limit the size to the current clip region. * platform/graphics/qt/ContextShadow.cpp: (WebCore::ContextShadow::drawShadowRect): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs@apple.com authored
Rubber stamped by Sam Weinig. * platform/mac-wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Reviewed by Martin Robinson. [GStreamer] media/invalid-media-url-crash.html fails https://bugs.webkit.org/show_bug.cgi?id=42960 Implemented two ResourceHandleClient callbacks that need to notify downstream GStreamer elements of errors while accessing the resource. * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::wasBlocked): (StreamingClient::cannotShowURL): LayoutTests: 2010-08-17 Philippe Normand <pnormand@igalia.com> Reviewed by Martin Robinson. [GStreamer] media/invalid-media-url-crash.html fails https://bugs.webkit.org/show_bug.cgi?id=42960 * platform/gtk/Skipped: Unskip fixed test git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 16 Aug, 2010 28 commits
-
-
kinuko@chromium.org authored
Unreviewed; attempt to fix Chromium Windows build. * public/WebFileUtilities.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jhoneycutt@apple.com authored
PluginInfoStore are implemented on Windows. Reviewed by Sam Weinig. * Platform/win/SharedMemoryWin.cpp: Disable not implemented warnings. * UIProcess/Plugins/win/PluginInfoStoreWin.cpp: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Unreviewed test expectation update. Update Chromium test expectations. https://bugs.webkit.org/show_bug.cgi?id=44090 * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kinuko@chromium.org authored
Reviewed by Jian Li. [chromium] Prepare to rename WebFileSystem interface to WebFileUtilities https://bugs.webkit.org/show_bug.cgi?id=44077 We are going to have an implementation for HTML5 FileSystem API and it would probably be less confusing to use the name "WebFileSystem" for an WebKit API for the HTML5 API. This patch adds WebFileUtilities interface that is meant to replace the existing WebFileSystem. * WebKit.gyp: * public/WebFileSystem.h: * public/WebFileUtilities.h: Added. * public/WebKitClient.h: (WebKit::WebKitClient::fileUtilities): Added. * src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::fileExists): (WebCore::ChromiumBridge::deleteFile): (WebCore::ChromiumBridge::deleteEmptyDirectory): (WebCore::ChromiumBridge::getFileSize): (WebCore::ChromiumBridge::getFileModificationTime): (WebCore::ChromiumBridge::directoryName): (WebCore::ChromiumBridge::pathByAppendingComponent): (WebCore::ChromiumBridge::makeAllDirectories): (WebCore::ChromiumBridge::getAbsolutePath): (WebCore::ChromiumBridge::isDirectory): (WebCore::ChromiumBridge::filePathToURL): (WebCore::ChromiumBridge::openFile): (WebCore::ChromiumBridge::closeFile): (WebCore::ChromiumBridge::seekFile): (WebCore::ChromiumBridge::truncateFile): (WebCore::ChromiumBridge::readFromFile): (WebCore::ChromiumBridge::writeToFile): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kinuko@chromium.org authored
Unreviewed; build fix attempt for Windows. * DefaultDownloadDelegate.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jhoneycutt@apple.com authored
Rubber-stamped by Sam Weinig. * platform/mac-wk2/Skipped: * platform/win-wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Rubber stamped by Sam Weinig * runtime/UString.h: (JSC::UStringHash::hash): (JSC::UStringHash::equal): (WTF::): * wtf/text/WTFString.h: (WTF::): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Rubber stamped by Sam Weinig JavaScriptCore: * profiler/CallIdentifier.h: * profiler/ProfileNode.h: * runtime/DateConversion.cpp: * runtime/Identifier.h: (JSC::IdentifierRepHash::hash): * runtime/RegExpCache.h: * runtime/RegExpKey.h: * runtime/UString.cpp: (JSC::UString::substr): * runtime/UString.h: * wtf/text/WTFString.h: WebCore: * dom/ScriptExecutionContext.h: * loader/appcache/ApplicationCache.cpp: WebKit2: * WebProcess/Plugins/Netscape/NetscapePlugin.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Ariya Hidayat. [Qt] REGRESSION: editing/selection/shrink-selection-after-shift-pagedown.html fails after 56567 https://bugs.webkit.org/show_bug.cgi?id=36628 Just enabling the test, it's not failing anymore. * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Ariya Hidayat. [Qt] qt/Skipped needs cleanup on outdaded comments https://bugs.webkit.org/show_bug.cgi?id=44066 Minor improvements/fixes to the list of Skipped Qt tests - move bug reference to the right place (#35145) - remove outdated bug reference (#32922) - move inspector testcase to the right place - add reference to bug closed on qt-4.7 (QTBUG-9618) * platform/qt/Skipped: cleanups only, no logical changes git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andreas.kling@nokia.com authored
Reviewed by Darin Adler. CSS: Add fast-path for rgba() color parsing https://bugs.webkit.org/show_bug.cgi?id=42965 Test: fast/canvas/rgba-parsing.html * css/CSSParser.cpp: (WebCore::CSSParser::parseColor): Extended with support for rgba(). (WebCore::parseAlphaValue): Added, parses an alpha value using WTF::strtod() (if necessary) and clamps between 0 and 1. (WebCore::isTenthAlpha): 2010-08-16 Andreas Kling <andreas.kling@nokia.com> Reviewed by Darin Adler. CSS: Add fast-path for rgba() color parsing https://bugs.webkit.org/show_bug.cgi?id=42965 Add a test of rgba() color parsing. * fast/canvas/rgba-parsing-expected.txt: Added. * fast/canvas/rgba-parsing.html: Added. * fast/canvas/script-tests/rgba-parsing.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kinuko@chromium.org authored
Reviewed by Dumitru Daniliuc. Add idl and mock classes for FileSystem API's {File,Directory}Entry and related interfaces https://bugs.webkit.org/show_bug.cgi?id=43993 Adding DirectoryEntry, DirectoryReader, EntriesCallback and FileEntry as defined in HTML5 FileSystem API. http://dev.w3.org/2009/dap/file-system/file-dir-sys.html Also adding Makefile entries for idl and mock classes added in changeset 64414 (except for Android platforms). Tests will be added when we add underlying implementation. * CMakeLists.txt: * DerivedSources.cpp: * DerivedSources.make: * GNUmakefile.am: * WebCore.gypi: * WebCore.pri: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * storage/DOMFileSystem.cpp: (WebCore::DOMFileSystem::root): * storage/DOMFileSystem.h: * storage/DOMFileSystem.idl: * storage/DirectoryEntry.cpp: Added. * storage/DirectoryEntry.h: Added. * storage/DirectoryEntry.idl: Added. * storage/DirectoryReader.cpp: Added. * storage/DirectoryReader.h: Added. * storage/DirectoryReader.idl: Added. * storage/EntriesCallback.h: Added. * storage/EntriesCallback.idl: Added. * storage/EntryArray.cpp: Added. * storage/EntryArray.h: Added. * storage/EntryArray.idl: Added. * storage/Entry.cpp: (WebCore::Entry::Entry): (WebCore::Entry::getMetadata): (WebCore::Entry::moveTo): (WebCore::Entry::copyTo): (WebCore::Entry::remove): (WebCore::Entry::getParent): * storage/Entry.h: (WebCore::Entry::isFile): (WebCore::Entry::isDirectory): * storage/Entry.idl: * storage/FileEntry.cpp: Added. * storage/FileEntry.h: Added. * storage/FileEntry.idl: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Reviewed by Mark Rowe. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andreas.kling@nokia.com authored
Reviewed by Ariya Hidayat. [Qt] Path::closeSubpath() should only close the last subpath if it has >1 point https://bugs.webkit.org/show_bug.cgi?id=44061 Spec link: http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-closepath Test: fast/canvas/canvas-closePath-single-point.html * platform/graphics/Path.h: Add a Qt-only member to track the last subpath. * platform/graphics/qt/PathQt.cpp: (WebCore::Path::closeSubpath): Only close the last subpath if it has more than 1 point. Otherwise behave as moveTo(first point in last subpath) (WebCore::Path::Path): (WebCore::Path::operator=): (WebCore::Path::moveTo): (WebCore::Path::transform): 2010-08-16 Andreas Kling <andreas.kling@nokia.com> Reviewed by Ariya Hidayat. [Qt] Path::closeSubpath() should only close the last subpath if it has >1 point https://bugs.webkit.org/show_bug.cgi?id=44061 Add a test to verify behavior of closePath() when path has only 1 point. * fast/canvas/canvas-closePath-single-point-expected.txt: Added. * fast/canvas/canvas-closePath-single-point.html: Added. * fast/canvas/script-tests/canvas-closePath-single-point.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
japhet@chromium.org authored
Unreviewed, build fix. Don't include TilingDataTest.cpp, since it doesn't compile on mac. * WebKit.gyp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
japhet@chromium.org authored
Unreviewed, Chromium expectations update. Mark 3 tests failing on Chromium Win/Linux after r65449. They appear to have same root cause as bugs.webkit.org/show_bug.cgi?id=43912. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
japhet@chromium.org authored
Unreviewed, Chromium mac build fix (with help from jamesr). * platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
These methods have a couple of problems with their interface, and implementation. Reviewed by Sam Weinig These methods take and int index, and return an int - however this is problematic since on 64-bit string indices may have a full 32-bit range. This spills out into surrounding code, which unsafely casts string indices from unsigned to int. Code checking the result of these methods check for a mix of "== -1", "< 0", and "== notFound". Clean this up by changing these methods to take an unsigned starting index, and return a size_t. with a failed match indicated by notFound. reverseFind also has a special meaning for the starting index argument, in that a negative index is interpreted as an offset back from the end of the string. Remove this functionality, in the (1!) case where it is used we should just calculate the offset by subtracting from the string's length. The implementation has a few problems too. The code is not in webkit style, in using assorted abbreviations in variable names, and implementations of similar find methods with differing argument types were unnecessarily inconsistent. When find is passed const char* data the string would be handled as latin1 (zero extended to UTF-16) for all characters but the first; this is sign extended. Case-insensitive find is broken for unicode strings; the hashing optimization is not unicode safe, and could result in false negatives. Unify UString find methods to match String. JavaScriptCore: * JavaScriptCore.exp: * bytecode/CodeBlock.cpp: (JSC::escapeQuotes): * bytecompiler/NodesCodegen.cpp: (JSC::substitute): * runtime/JSString.cpp: (JSC::JSString::replaceCharacter): * runtime/RegExp.cpp: (JSC::RegExp::RegExp): * runtime/RegExpKey.h: (JSC::RegExpKey::getFlagsValue): * runtime/StringPrototype.cpp: (JSC::substituteBackreferencesSlow): (JSC::substituteBackreferences): (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncSplit): * runtime/UString.cpp: * runtime/UString.h: (JSC::UString::find): (JSC::UString::reverseFind): * wtf/text/AtomicString.h: (WTF::AtomicString::find): * wtf/text/StringImpl.cpp: (WTF::StringImpl::find): (WTF::StringImpl::findCaseInsensitive): (WTF::StringImpl::reverseFind): (WTF::StringImpl::reverseFindCaseInsensitive): (WTF::StringImpl::endsWith): (WTF::StringImpl::replace): * wtf/text/StringImpl.h: (WTF::StringImpl::startsWith): * wtf/text/WTFString.cpp: (WTF::String::split): * wtf/text/WTFString.h: (WTF::String::find): (WTF::String::reverseFind): (WTF::String::findCaseInsensitive): (WTF::String::reverseFindCaseInsensitive): (WTF::String::contains): (WTF::find): (WTF::reverseFind): WebCore: * css/CSSSelector.cpp: (WebCore::CSSSelector::RareData::parseNth): * css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::setProperty): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): * dom/Document.cpp: (WebCore::Document::getImageMap): * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::inputText): * editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): * editing/TextIterator.cpp: (WebCore::TextIterator::handleTextBox): * editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): * editing/markup.cpp: (WebCore::fillContainerFromString): (WebCore::createFragmentFromText): * html/File.cpp: (WebCore::File::Init): * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setHost): * html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): * html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::isPlaceholderEmpty): * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::performSearch): * loader/CrossOriginPreflightResultCache.cpp: (WebCore::parseAccessControlAllowList): * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase): * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::parseHeader): (WebCore::parseHeaders): * loader/icon/IconFetcher.cpp: (WebCore::parseIconLink): * page/DOMWindow.cpp: (WebCore::DOMWindow::parseModalDialogFeatures): * page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::createFromDatabaseIdentifier): * page/UserContentURLPattern.cpp: (WebCore::UserContentURLPattern::parse): * page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest): * platform/ContentType.cpp: (WebCore::ContentType::parameter): (WebCore::ContentType::type): * platform/KURL.cpp: (WebCore::KURL::lastPathComponent): (WebCore::KURL::setProtocol): (WebCore::decodeURLEscapeSequences): (WebCore::substituteBackslashes): (WebCore::mimeTypeFromDataURL): * platform/Length.cpp: (WebCore::newCoordsArray): (WebCore::newLengthArray): * platform/LinkHash.cpp: (WebCore::findSlashDotDotSlash): (WebCore::findSlashSlash): (WebCore::findSlashDotSlash): (WebCore::cleanPath): * platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForPath): * platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLAsLocal): * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): * platform/mac/DragImageMac.mm: (WebCore::createDragImageIconForCachedImage): * platform/network/CredentialStorage.cpp: (WebCore::protectionSpaceMapKeyFromURL): (WebCore::findDefaultProtectionSpaceForURL): * platform/network/HTTPParsers.cpp: (WebCore::skipWhiteSpace): (WebCore::skipToken): (WebCore::parseHTTPRefresh): (WebCore::filenameFromHTTPContentDisposition): (WebCore::findCharsetInMediaType): (WebCore::parseXSSProtectionHeader): (WebCore::extractReasonPhraseFromHTTPStatusLine): * platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::isAttachment): (WebCore::parseCacheHeader): * rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::updateWidget): * storage/Entry.cpp: (WebCore::Entry::Entry): * svg/SVGFont.cpp: (WebCore::isCompatibleGlyph): * svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget): * svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::parseClockValue): (WebCore::SVGSMILElement::parseCondition): * xml/XPathFunctions.cpp: (WebCore::XPath::FunSubstringBefore::evaluate): (WebCore::XPath::FunSubstringAfter::evaluate): (WebCore::XPath::FunTranslate::evaluate): (WebCore::XPath::FunLang::evaluate): * xml/XPathParser.cpp: (WebCore::XPath::Parser::expandQName): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Reviewed by Tony Chang. REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium https://bugs.webkit.org/show_bug.cgi?id=44070 The crash was caused by start or end node being removed in pushDownInlineStyleAroundNode. It made start and end orphaned, and caused s.node() to be detached from the document. Fixed the crash by using nodes passed to pushDownInlineStyleAroundNode for start and end if the original start and end are orphaned because pushDownInlineStyleAroundNode won't prune targetNode. Test: editing/pasteboard/smart-paste-003-trailing-whitespace.html * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyle): 2010-08-16 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Tony Chang. REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium https://bugs.webkit.org/show_bug.cgi?id=44070 The bug only reproduced on Windows when trailing space is selected only on Windows. Added a crash test to copy & paste a word with trailing space. * editing/pasteboard/smart-paste-003-trailing-whitespace-expected.txt: Added. * editing/pasteboard/smart-paste-003-trailing-whitespace.html: Added. * platform/chromium/test_expectations.txt: editing/pasteboard/smart-paste-003.html and smart-paste-004.html should not crash. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
* Shared/win/CommandLineWin.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Reviewed by Gavin Barraclough. * Platform/Module.cpp: * Platform/Module.h: * Shared/CommandLine.h: * Shared/WebCoreArgumentCoders.h: * Shared/WebEvent.h: * Shared/WebNavigationDataStore.h: * Shared/WebPreferencesStore.h: * Shared/WebString.h: * Shared/WebURL.h: * Shared/mac/CommandLineMac.cpp: * Shared/qt/UpdateChunk.cpp: * UIProcess/API/C/WKContext.cpp: * UIProcess/API/C/cf/WKStringCF.cpp: * UIProcess/API/C/cf/WKURLCF.cpp: * UIProcess/API/cpp/qt/WKStringQt.cpp: * UIProcess/API/cpp/qt/WKURLQt.cpp: * UIProcess/API/mac/PageClientImpl.mm: * UIProcess/API/qt/qgraphicswkview.cpp: * UIProcess/Launcher/mac/ProcessLauncherMac.mm: * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: * UIProcess/Launcher/win/ProcessLauncherWin.cpp: * UIProcess/WebBackForwardListItem.cpp: * UIProcess/WebBackForwardListItem.h: * UIProcess/WebContext.h: * UIProcess/WebContextInjectedBundleClient.cpp: * UIProcess/WebFrameProxy.cpp: * UIProcess/WebFrameProxy.h: * UIProcess/WebPageProxy.h: * UIProcess/WebPolicyClient.cpp: * UIProcess/WebProcessProxy.cpp: * UIProcess/WebUIClient.cpp: * UIProcess/win/WebView.cpp: * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: * WebProcess/InjectedBundle/InjectedBundle.h: * WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp: * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: * WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: * WebProcess/Plugins/JSNPObject.cpp: * WebProcess/Plugins/NPJSObject.cpp: * WebProcess/Plugins/Netscape/NetscapePluginModule.cpp: * WebProcess/Plugins/Netscape/NetscapePluginModule.h: * WebProcess/WebCoreSupport/WebChromeClient.h: * WebProcess/WebKitMain.cpp: * WebProcess/win/WebProcessMainWin.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
japhet@chromium.org authored
Chromium win rebaseline + test expectations tweaks. * platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
<rdar://problem/8261812> https://bugs.webkit.org/show_bug.cgi?id=44072 Reviewed by Gavin Barraclough. Conversion from WKURLRef to CFRURLRef was breaking on URLs using characters such as '{'. * UIProcess/API/C/cf/WKURLCF.cpp: (WKURLCopyCFURL): Use code similar to that found in KURLCFNet.cpp for conversion. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-