GitLab

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Mark Rowe.

* building/tools.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

thread, permanently slowing down JavaScript
        
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.

Removed the optional lock from Heap::protect, Heap::unprotect, and friends,
since WebCore no longer uses it.

* JavaScriptCore.exp:
* runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):
* runtime/Collector.h:

WebCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.

Changed callback objects to use a standard helper object. The helper
object ASSERTs that it is deleted on the main thread, so no lock is
required when unprotecting its members. It also centralizes some previously
duplicated code.
        
Callback objects that might be deleted on a secondary thread use
callOnMainThread to delete their helper objects on the main thread.

* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCallbackData.cpp: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.
(WebCore::JSCallbackData::deleteData):
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSCallbackData.h: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.
(WebCore::JSCallbackData::JSCallbackData):
(WebCore::JSCallbackData::~JSCallbackData):
(WebCore::JSCallbackData::callback):
* bindings/js/JSCustomPositionCallback.cpp:
(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):
* bindings/js/JSCustomPositionCallback.h:
* bindings/js/JSCustomPositionErrorCallback.cpp:
(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):
* bindings/js/JSCustomPositionErrorCallback.h:
* bindings/js/JSCustomSQLStatementCallback.cpp:
(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::~JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):
* bindings/js/JSCustomSQLStatementCallback.h:
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::~JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
* bindings/js/JSCustomSQLStatementErrorCallback.h:
* bindings/js/JSCustomSQLTransactionCallback.cpp:
(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):
* bindings/js/JSCustomSQLTransactionCallback.h:
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::~JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
* bindings/js/JSCustomSQLTransactionErrorCallback.h:
* bindings/js/JSCustomVoidCallback.cpp:
(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::~JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::handleEvent):
* bindings/js/JSCustomVoidCallback.h:
* storage/Database.cpp:
(WebCore::Database::Database):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dave Levin.

        Fix StringImpl::m_buffer
        https://bugs.webkit.org/show_bug.cgi?id=30189

        Fix my previous StringImpl patch to avoid using an indefinite-length array member,
        since MSVC doesn't like it. Instead, go back to offsetting by sizeof(StringImpl).

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::StringImpl):
        (WebCore::StringImpl::createUninitialized):
        * platform/text/StringImpl.h:
        (WebCore::StringImpl::bufferIsInternal):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=30145

Patch by Aaron Boodman <aa@chromium.org> on 2009-10-07
Reviewed by Adam Barth.

WebCore: 

* bindings/v8/ScriptController.cpp:
Replace evaluateInNewIsolatedWorld() withe evaluateInIsolatedWorld(id).
(WebCore::ScriptController::evaluateInIsolatedWorld):
* bindings/v8/ScriptController.h: Ditto.
* bindings/v8/V8Proxy.cpp: Ditto.
(WebCore::V8Proxy::~V8Proxy): Dittio.
(WebCore::V8Proxy::evaluateInIsolatedWorld): Ditto.
* bindings/v8/V8Proxy.h: Ditto.
* bindings/v8/V8IsolatedWorld.cpp:
Add support for controlling lifetime of a world, rather than relying on GC.
(WebCore::V8IsolatedWorld::contextWeakReferenceCallback): Ditto.
(WebCore::V8IsolatedWorld::V8IsolatedWorld): Ditto.
(WebCore::V8IsolatedWorld::destroy): Ditto.
* bindings/v8/V8IsolatedWorld.h: Ditto.

LayoutTests: 

* http/tests/security/isolatedWorld/iframe.html: Added.
* http/tests/security/isolatedWorld/world-reuse-expected.txt: Added.
* http/tests/security/isolatedWorld/world-reuse.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<rdar://problem/7285293> and https://webkit.org/b/29904

Reviewed by Darin Adler.

WebKit/mac: 

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::setTitle):
* WebView/WebDelegateImplementationCaching.h:
* WebView/WebHistoryDelegate.h:
* WebView/WebView.mm:
(-[WebView _cacheHistoryDelegateImplementations]):

WebKitTools: 

* DumpRenderTree/mac/HistoryDelegate.mm:
(-[HistoryDelegate webView:updateHistoryTitle:forURL:]):

LayoutTests: 

* http/tests/globalhistory/history-delegate-basic-title-expected.txt: Added.
* http/tests/globalhistory/history-delegate-basic-title.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-07
* platform/text/StringImpl.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=30178
rdar://problem/6544670

Patch by Darin Adler <darin@apple.com> on 2009-10-07
Reviewed by John Sullivan.

* Misc/WebNSFileManagerExtras.m:
(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
Call _web_URLByRemovingUserInfo on the passed in URL string after converting
it to a URL, and then convert it back to a string.

* Misc/WebNSURLExtras.h: Added _web_URLByRemovingUserInfo.
* Misc/WebNSURLExtras.mm: Removed unused WebKitURLComponents struct.
(-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Renamed to be
clearer on what this does.
(-[NSURL _webkit_URLByRemovingFragment]): Changed to call new name.
(-[NSURL _webkit_URLByRemovingResourceSpecifier]): Ditto.
(-[NSURL _web_URLByRemovingComponentAndSubsequentCharacter:]): Added.
(-[NSURL _web_URLByRemovingUserInfo]): Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Optimization of StringImpl:
        - Remove unnecessary m_bufferIsInternal member (saves 4 bytes). Instead, check whether
          m_data points to just past the end of the object's members.
        - copy() and createWithTerminatingNullCharacter() create the string in a single malloc
          block instead of 2 (saves ~20 bytes and considerable CPU cycles, increases locality).
        - Move m_length next to m_hash to save 4 bytes of padding in 64-bit builds.

        https://bugs.webkit.org/show_bug.cgi?id=29500

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::StringImpl): Re-ordered members.
        (WebCore::StringImpl::~StringImpl): Change to is-buffer-internal check.
        (WebCore::StringImpl::createUninitialized): Use new m_buffer member instead of sizeof()
            to ensure chars are copied to correct location.
        (WebCore::StringImpl::createWithTerminatingNullCharacter): Make sure copy is created
            in a single malloc block.
        (WebCore::StringImpl::threadsafeCopy): Make sure copy is created in a single malloc block.
        (WebCore::StringImpl::crossThreadString): Make sure copy is created in a single malloc block.
        (WebCore::StringImpl::sharedBuffer): Change to is-buffer-internal check.
        * platform/text/StringImpl.h:
        (WebCore::StringImpl::startsWith): Just fixed a confusing param name.
        (WebCore::StringImpl::bufferIsInternal): Changed member var into accessor method.
        (WebCore::StringImpl::m_data): Repositioned for optimal member packing in 64-bit.
        (WebCore::StringImpl::m_buffer): Added to provide an explicit location for where internal buffer goes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Make Dan Bernstein happy.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dan Bernstein.

        Avoid Obj-C message dispatch when possible by storing accessed objects
        in local variables.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dan Bernstein.

        Animation stalls for a few seconds partway through
        https://bugs.webkit.org/show_bug.cgi?id=30182

        Make sure that we only call -disableScreenUpdatesUntilFlush when a window
        update is actually going to happen, otherwise screen updates are disabled
        for too long.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=30102
        And
        <rdar://problem/5015957>
        
        Fixes an issue (in the Windows build) where the cursor does not change to the
        not-allowed cursor when the drag-and-drop operation is not allowed.
        
        The allowed effects in WebDragClient::startDrag are hard-coded to be 
        DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of 
        allowed drop effects should be determined by the allowed operations of the
        drag source.
        
        We cannot test this using DRT because DRT looks at the programmatic drop 
        cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy.
        That is, there is a discrepancy in the Windows build between the Windows API-based 
        drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer 
        to determine the cursor, a manual test is needed.

        * WebCoreSupport/WebDragClient.cpp:
        (draggingSourceOperationMaskToDragCursors): Added method.
        (WebDragClient::startDrag):
2009-10-07  Daniel Bates  <dbates@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=30102
        And
        <rdar://problem/5015957>
        
        Manual test to confirm that the not-allowed cursor is shown for an
        invalid drag-and-drop operation.
        
        We cannot test this using DRT because of a discrepancy between the Windows
        API-based drop effect and the WebKit drop effect. See bug #24731 for more
        details.

        * manual-tests/drag-cursor-notallowed.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed.  Remove some folks from committers.py who were listed on
        the WebKit Team wiki page but who weren't actually listed as commit+.
        At some point, we should coorelate this list with the committers
        mailing list.

        * Scripts/modules/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed.  Import a bunch of committers from the WebKit Team page on
        the wiki into committers.py.

        * Scripts/modules/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Roben.

        Windows-specific baselines for some new tests.

        * platform/win/fast/css/large-number-round-trip-expected.txt: Added.
        * platform/win/fast/css/opacity-float-expected.txt: Copied from LayoutTests/fast/css/opacity-float-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Timothy Hatcher.

        Fixes <http://webkit.org/b/30104>.
        Inspector should show cookies of sub-resources on the page.
        
        This function implements showing cookies for all sub-resources of a page.
        When the page is loaded, it populates the Storage Panel with a list of all
        domains that were loaded as part of the full page load (iframes, ads, etc).
        When the user selects one of the domains, the inspector calls back into the
        controller, and the controller combines all of the cookies from that domain
        into a list, and sends that list is sent back to the controller to render.
        
        A domain now needs to be passed into CookieItemsView, and CookieSidebarTreeElement.
        
        As a result of a previous patch, we now have detailed cookie information for
        both Windows on CFNetwork and Mac. Additionally, this patch provides deleteCookie
        support on Windows.

        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/js/ScriptObject.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getCookies):
        (WebCore::InspectorBackend::deleteCookie):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::getCookies):
        (WebCore::InspectorController::buildArrayForCookies):
        (WebCore::InspectorController::buildObjectForCookie):
        (WebCore::InspectorController::deleteCookie):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addCookieDomainForDocument):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView):
        (WebInspector.CookieItemsView.prototype.update):
        (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.Cookies.getCookiesAsync):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel):
        (WebInspector.StoragePanel.prototype.reset):
        (WebInspector.StoragePanel.prototype.addCookieDomain):
        (WebInspector.StoragePanel.prototype.showCookies):
        (WebInspector.CookieSidebarTreeElement):
        (WebInspector.CookieSidebarTreeElement.prototype.onselect):
        * inspector/front-end/inspector.js:
        (WebInspector.addCookieDomain):
        * platform/Cookie.h:
        (WebCore::CookieHash::hash):
        (WebCore::CookieHash::equal):
        (WTF::):
        * platform/network/win/CookieJarCFNetWin.cpp:
        (WebCore::deleteCookie):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Timothy Hatcher.

        Web Inspector: Add ScriptObject::set(const char*, unsigned).

        https://bugs.webkit.org/show_bug.cgi?id=30104

        * bindings/v8/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/v8/ScriptObject.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed.  Added Aaron Boodman to committers.py.

        * Scripts/modules/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Provide implementation of new BitmapImage::create that was
added in @r49060.

* platform/graphics/win/ImageCairoWin.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Carlson.

        Refactor RenderThemeChromiumMac and RenderThemeChromiumSkia to render media controls using GraphicsContext.

        Design was based on existing RenderMediaControls.cpp used by RenderThemeSafari/Win.

        https://bugs.webkit.org/show_bug.cgi?id=29987

        Covered by existing layout tests as no new functionality was introduced.

        * WebCore.gypi: Added RenderMediaControlsChromium.cpp/h.
        * css/mediaControlsChromium.css: Tweaked media slider position and border style.
        * rendering/MediaControlElements.cpp:
        (WebCore::toParentMediaElement): Taken from RenderMediaControls.
        (WebCore::MediaControlElement::rendererIsNeeded): Don't call shouldRenderMediaControlPart() if element has no appearance.
        (WebCore::MediaControlInputElement::rendererIsNeeded): Ditto.
        * rendering/RenderMediaControls.cpp: Moved parentMediaElement() to MediaControlElements.
        * rendering/RenderMediaControlsChromium.cpp: Added.
        (WebCore::platformResource): Helper to load and cache media control image resources.
        (WebCore::mediaSliderThumbImage): Implementation refactored from RenderThemeChromiumMac/Skia.
        (WebCore::mediaVolumeSliderThumbImage): Ditto.
        (WebCore::paintMediaButton): Ditto.
        (WebCore::paintMediaMuteButton): Ditto.
        (WebCore::paintMediaPlayButton): Ditto.
        (WebCore::paintMediaSlider): Ditto.
        (WebCore::paintMediaSliderThumb): Ditto.
        (WebCore::paintMediaVolumeSlider): Ditto.
        (WebCore::paintMediaVolumeSliderThumb): Ditto.
        (WebCore::paintMediaTimelineContainer): Ditto.
        (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Ditto.
        (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Same
        (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
        * rendering/RenderMediaControlsChromium.h: Added.
        * rendering/RenderThemeChromiumMac.h:
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): Implementation delegated to RenderMediaControlsChromium.
        (WebCore::RenderThemeChromiumMac::shouldRenderMediaControlPart): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): Ditto.
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::paintMediaControlsBackground): Implementation delegated to RenderMediaControlsChromium.
        (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack): Ditto.
        (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): Ditto.
        (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize): Ditto.
        (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): Ditto.
        (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): Ditto.
        (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): Ditto.
        (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): Ditto.
        (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Adam Roben.

Added fast/dom/beforeload/flash-before-load.html

* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidget):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<rdar://problem/7281553> Extra information in UA causes problems with gmail

Reviewed by Darin Adler.

* WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Fraser.

        Add a currently-failing test exhibiting the problem in
        https://bugs.webkit.org/show_bug.cgi?id=20674:

        When converting very large or small numbers back to strings, exponential
        notation is used, so a value like 90010000px is returned from
        getComputedStyle() as 9.001e+07px.

        9.001e+07px does not parse, so such a value cannot be round-tripped.

        This is a particular problem with tranformation matrices, which can often
        contain very large or small numbers.

        (Test written by Simon Fraser; I've just made it a committable patch.)

        * fast/css/large-number-round-trip-expected.txt: Added.
        * fast/css/large-number-round-trip.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Layout test for verifying that LC_NUMERIC setting doesn't affect
        the way CSS properties are stringified.
        https://bugs.webkit.org/show_bug.cgi?id=18994

        * fast/css/opacity-float-expected.txt: Added.
        * fast/css/opacity-float.html: Added.
2009-10-07  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        Add API to LayoutTestController for re/setting the system locale.
        https://bugs.webkit.org/show_bug.cgi?id=18994

        * DumpRenderTree/LayoutTestController.cpp:
        (setLocaleCallback):
        (LayoutTestController::staticFunctions):
        (LayoutTestController::setLocale):
        * DumpRenderTree/LayoutTestController.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        [V8] Protect JS listener object from GC while clearing a property on it.
        See http://crbug.com/23780.
        https://bugs.webkit.org/show_bug.cgi?id=30137

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::~V8AbstractEventListener):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rubber-stamped by Eric Seidel.

        Allow custom memory allocation control for WebCore's CachedResourceClient class
        https://bugs.webkit.org/show_bug.cgi?id=30165

        Inherits CachedResourceClient class from FastAllocBase because (its
        child class) CSSFontFaceSource has been instantiated by 'new' in WebCore/css/CSSFontFaceSource.h:46.

        * loader/CachedResourceClient.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

                                                                                        
        Reviewed by Darin Adler.

        Allow custom memory allocation control for WebCore's IdentifierRep
        https://bugs.webkit.org/show_bug.cgi?id=30159

        Inherits IdentifierRep class from FastAllocBase because it has been
        instantiated by 'new' in WebCore/bridge/IdentifierRep.cpp:61.

        * bridge/IdentifierRep.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Allow custom memory allocation control for JavaScriptCore's IdentifierArena
        https://bugs.webkit.org/show_bug.cgi?id=30158

        Inherits IdentifierArena class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/parser/ParserArena.cpp:36.

        * parser/ParserArena.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        Fetch pointers to C++ DOM window immediately from holder
        object (do not search prototype chain for proper JS wrapper).
        https://bugs.webkit.org/show_bug.cgi?id=29031

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::createNewContext):
        (WebCore::V8Proxy::installDOMWindow):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):
        (WebCore::INDEXED_PROPERTY_GETTER):
        (WebCore::NAMED_PROPERTY_GETTER):
        (WebCore::NAMED_ACCESS_CHECK):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fixes <http://webkit.org/b/30171>
fast/dom/Window/window-postmessage-clone.html fails on Windows

Reviewed by Anders Carlsson.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Removed the export of DateInstance::info from here.

* runtime/DateInstance.h: Use JS_EXPORTDATA to export
DateInstance::info, which is the required way of exporting data on
Windows.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Jan Alonzo.

        [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
        https://bugs.webkit.org/show_bug.cgi?id=29689

        Build fix by adding -lfontconfig for DumpRenderTree.

        * GNUmakefile.am:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Hausmann.

        [Qt] Get rid of useless loadFailed signal in QGraphicsWebView
        https://bugs.webkit.org/show_bug.cgi?id=30166

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::_q_doLoadFinished):
        * Api/qgraphicswebview.h:
        * QGVLauncher/main.cpp:
        (MainWindow::init):
        (MainWindow::loadFinished):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

This typo was introduced in the build fix in r49213.

Fixes <http://webkit.org/b/30168> REGRESSION (r49213):
http/tests/plugins/local-geturl-from-remote.html is failing on Windows

Reviewed by Sam Weinig.

* plugins/PluginView.cpp:
(WebCore::PluginView::load): Removed a comma operator that was making
a condition always evaluate to true.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49244 268f45cc-cd09-0410-ab3c-d52691b4dbfc