Commits · 996df13558372fad02d45050279920d991d80631 · App_Technologies / webkit

14 Jun, 2007 15 commits

Add quite a bit of keyboard handling in editing and non-editing mode for · 996df135

staikos authored Jun 15, 2007

QtWebKit, as well as some focus fixes.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

996df135

Fix Windows build. · 12b7163a

andersca authored Jun 14, 2007

        
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::canPut):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12b7163a

Fix for missing text in non-English Windows installs. · 8b28373d

hyatt authored Jun 14, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8b28373d

JavaScriptCore: · 2b1d0661

andersca authored Jun 14, 2007

        Reviewed by Darin.

        <rdar://problem/5103077> 
        Crash at _NPN_ReleaseObject when quitting page at http://eshop.macsales.com/shop/ModBook
        
        <rdar://problem/5183692>
        http://bugs.webkit.org/show_bug.cgi?id=13547
        REGRESSION: Crash in _NPN_ReleaseObject when closing Safari on nba.com (13547)
        
        <rdar://problem/5261499>
        CrashTracer: [USER] 75 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::CInstance::~CInstance + 40
        
        Have the root object track all live instances of RuntimeObjectImp. When invalidating 
        the root object, also invalidate all live runtime objects by zeroing out their instance ivar.
        This prevents instances from outliving their plug-ins which lead to crashes.
        
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertValueToNPVariant):
        * bindings/jni/jni_jsobject.cpp:
        (JavaJSObject::convertValueToJObject):
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::convertValueToJValue):
        * bindings/objc/objc_runtime.mm:
        (ObjcFallbackObjectImp::callAsFunction):
        * bindings/runtime_array.cpp:
        (RuntimeArray::RuntimeArray):
        * bindings/runtime_array.h:
        (KJS::RuntimeArray::getConcreteArray):
        * bindings/runtime_method.cpp:
        (RuntimeMethod::callAsFunction):
        * bindings/runtime_method.h:
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::RuntimeObjectImp):
        (RuntimeObjectImp::~RuntimeObjectImp):
        (RuntimeObjectImp::invalidate):
        (RuntimeObjectImp::fallbackObjectGetter):
        (RuntimeObjectImp::fieldGetter):
        (RuntimeObjectImp::methodGetter):
        (RuntimeObjectImp::getOwnPropertySlot):
        (RuntimeObjectImp::put):
        (RuntimeObjectImp::canPut):
        (RuntimeObjectImp::defaultValue):
        (RuntimeObjectImp::implementsCall):
        (RuntimeObjectImp::callAsFunction):
        (RuntimeObjectImp::getPropertyNames):
        (RuntimeObjectImp::throwInvalidAccessError):
        * bindings/runtime_object.h:
        * bindings/runtime_root.cpp:
        (KJS::Bindings::RootObject::invalidate):
        (KJS::Bindings::RootObject::addRuntimeObject):
        (KJS::Bindings::RootObject::removeRuntimeObject):
        * bindings/runtime_root.h:

LayoutTests:

        Reviewed by Darin.

        Add test that manipulates plug-in script objects after the plug-in has been destroyed.
        
        * plugins/netscape-destroy-plugin-script-objects-expected.txt: Added.
        * plugins/netscape-destroy-plugin-script-objects.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2b1d0661

Reviewed by Brady. · 04411e84

weinig authored Jun 14, 2007

        Update set of files to download for cygwin to include
        diffutils and regenerate the zip file.  This should fix
        an issue on vista where svn-create-patch doesn't work.

        * CygwinDownloader/cygwin-downloader.py:
        * CygwinDownloader/cygwin-downloader.zip:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

04411e84

Reviewed by Geoff. · 80ee144a

andersca authored Jun 14, 2007

        Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
        for a given plug-in.

        * WebCore.exp:
        * page/Frame.cpp:
        (WebCore::Frame::cleanupScriptObjectsForPlugin):
        * page/Frame.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

80ee144a

Reviewed by Geoff. · 1d23cad5

andersca authored Jun 14, 2007

        Call cleanupScriptObjectsForPlugin on the frame after destroying the plug-in.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView _destroyPlugin]):
        * Plugins/WebPluginController.mm:
        (-[WebPluginController destroyPlugin:]):
        (-[WebPluginController destroyAllPlugins]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1d23cad5

2007-06-14 Mark Rowe <mrowe@apple.com> · 74e7f3d5

bdash authored Jun 14, 2007

        Update script to match new nightly.webkit.org infrastructure.

        * BuildSlaveSupport/build-launcher-dmg:  Upload to the live web server, not the caching proxy.  Let the server know it's a Mac build.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

74e7f3d5

Reviewed by Geoff. · 3d8fcbf7

andersca authored Jun 14, 2007

        <rdar://problem/5211677>
        -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
        
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::requestObject):
        If the object is a Java MIME type and Java is disabled, don't load the plug-in.
        
        * platform/MimeTypeRegistry.cpp:
        (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
        Clean this up and add another applet MIME type.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3d8fcbf7

Implement the javascript dialogs and file chooser dialog, along with some · 5a566224
staikos authored Jun 14, 2007
```
cleanups.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
5a566224
Add missing null-init of pointer (will fix an upcoming crash) · a7ac083f
staikos authored Jun 14, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
a7ac083f

JavaScriptCore: · bde934c5

andersca authored Jun 14, 2007

        Reviewed by Mitz.

        <rdar://problem/5244948>
        Safari keeps on complaining about slow script playing NBC TV video (14133)

        http://bugs.webkit.org/show_bug.cgi?id=14133
        Runaway JavaScript timer fires when spinning around in Google Maps street view

        Make sure to start and stop the timeout checker around calls to JS.
        
        * bindings/NP_jsobject.cpp:
        (_NPN_InvokeDefault):
        (_NPN_Invoke):
        (_NPN_Evaluate):
        * bindings/jni/jni_jsobject.cpp:
        (JavaJSObject::call):
        (JavaJSObject::eval):

WebCore:

        Reviewed by Mitz.

        <rdar://problem/5244948>
        Safari keeps on complaining about slow script playing NBC TV video (14133)

        http://bugs.webkit.org/show_bug.cgi?id=14133
        Runaway JavaScript timer fires when spinning around in Google Maps street view

        Make sure to start and stop the timeout checker around calls to JS.

        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bde934c5

Removed QWebHistoryItem::parent() as it is not implemented and WebCore's · f4535dde

hausmann authored Jun 14, 2007

HistoryItem itself doesn't seem to have a parent pointer either.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f4535dde

Make it possible to copy QWebHistoryItem objects. · d4e38836

hausmann authored Jun 14, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d4e38836

Fix mod-by-zero crash when typeahead is triggered on an empty select. · 4fb87ca3
staikos authored Jun 14, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
4fb87ca3

13 Jun, 2007 25 commits

JavaScriptCore: · 21368dd4

darin authored Jun 14, 2007

        Reviewed by Mark Rowe.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14132
          array sort with > 10000 elements sets elements > 10000 undefined

        Test: fast/js/sort-large-array.html

        * kjs/array_instance.h: Replaced pushUndefinedObjectsToEnd with
        compactForSorting, and removed ExecState parameters.

        * kjs/array_object.cpp:
        (ArrayInstance::sort): Changed to call compactForSorting.
        (ArrayInstance::compactForSorting): Do the get and delete of the
        properties directly on the property map instead of using public
        calls from JSObject. The public calls would just read the undefined
        values from the compacted sort results array!

LayoutTests:

        Reviewed by Mark Rowe.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14132
          array sort with > 10000 elements sets elements > 10000 undefined

        * fast/js/resources/sort-large-array.js: Added.
        * fast/js/sort-large-array-expected.txt: Added.
        * fast/js/sort-large-array.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

21368dd4

Fix a crash when a request from the plugin resulted · 897f34f2

lars authored Jun 14, 2007

        in a HTTP redirect.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

897f34f2

Work around a bug in Qt's QHttp implementation and · 30e48ce7

lars authored Jun 14, 2007

        get web pages to load again.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

30e48ce7

Fix Mac OS X build · 15fafbe4

staikos authored Jun 14, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15fafbe4

missed this in my last checkin - obsolete line · bfd5b69c

staikos authored Jun 14, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bfd5b69c

Compile without trying to link ourself. · c62cabb5

staikos authored Jun 14, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c62cabb5

Disable FastMalloc for the Qt build and make sure we · cc7d55ce

lars authored Jun 14, 2007

don't reimplement the global new/delete operators
when using the system malloc.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cc7d55ce

Reviewed by Kevin Decker. · a5dc917c

darin authored Jun 14, 2007

        - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
          +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)

        * platform/mac/WebFontCache.mm:
        (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
        Took out the auto-activation code.
        (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
        then calls NSFont to trigger activation if that returned nil, then calls
        internalFontWithFamily again.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a5dc917c

JavaScriptCore: · 89c5d677

andersca authored Jun 14, 2007

        Reviewed by Geoff.

        Make sure that bindings instances get correct root objects.
        
        * JavaScriptCore.exp:
        * bindings/NP_jsobject.cpp:
        (listFromVariantArgs):
        (_NPN_InvokeDefault):
        (_NPN_Invoke):
        (_NPN_SetProperty):
        * bindings/c/c_instance.cpp:
        (KJS::Bindings::CInstance::invokeMethod):
        (KJS::Bindings::CInstance::invokeDefaultMethod):
        * bindings/c/c_runtime.cpp:
        (KJS::Bindings::CField::valueFromInstance):
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertNPVariantToValue):
        * bindings/c/c_utility.h:
        * bindings/objc/objc_instance.mm:
        (ObjcInstance::invokeMethod):
        (ObjcInstance::invokeDefaultMethod):
        (ObjcInstance::getValueOfUndefinedField):
        * bindings/objc/objc_runtime.mm:
        (ObjcField::valueFromInstance):
        (ObjcArray::valueAt):
        * bindings/objc/objc_utility.h:
        * bindings/objc/objc_utility.mm:
        (KJS::Bindings::convertObjcValueToValue):
        * bindings/runtime.h:

WebCore:

        Reviewed by Geoff.

        Pass the root object to methods that end up creating new ObjcInstance objects.
        
        * bindings/objc/WebScriptObject.mm:
        (listFromNSArray):
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):
        (-[WebScriptObject setValue:forKey:]):
        (-[WebScriptObject valueForKey:]):
        (-[WebScriptObject removeWebScriptKey:]):
        (-[WebScriptObject setWebScriptValueAtIndex:value:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

89c5d677

Reviewed by Darin. · 8b2606e4

andersca authored Jun 13, 2007

        <rdar://problem/5267992>
        Make sure an alert doesn't allow loading to continue inside a script.
        
        Make sure to defer all loads where it's possible for a second main loop to be running.
        
        * page/Chrome.cpp:
        (WebCore::Chrome::runModal):
        (WebCore::Chrome::runBeforeUnloadConfirmPanel):
        (WebCore::Chrome::runJavaScriptAlert):
        (WebCore::Chrome::runJavaScriptConfirm):
        (WebCore::Chrome::runJavaScriptPrompt):
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
        
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::setDefersLoading):
        Implement this.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8b2606e4

Reviewed by Adele Peterson · 534741b0

sullivan authored Jun 13, 2007

        
        - fixed <rdar://problem/5267607> Clicking the "Save to Downloads" button in 
          PDF overlay too soon results in corrupt file

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        Just beep if the document isn't available yet, since trying to save it as a file
        really isn't a good idea.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

534741b0

2007-06-13 Alp Toker <alp.toker@collabora.co.uk> · 3cb4d7c6

bdash authored Jun 13, 2007

        Reviewed by Rob.

        http://bugs.webkit.org/show_bug.cgi?id=14060
        Cairo SVG support

        * WebCore.pro: Add new files to the build.
        * platform/graphics/svg/SVGPaintServerPattern.h:
        * platform/graphics/svg/SVGPaintServerSolid.h:
        * platform/graphics/svg/cairo: Added.
        * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
        (WebCore::RenderPath::strokeContains):
        (WebCore::RenderPath::strokeBBox):
        * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
        (WebCore::SVGPaintServer::draw):
        (WebCore::SVGPaintServer::teardown):
        (WebCore::SVGPaintServer::renderPath):
        * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
        (WebCore::SVGPaintServerGradient::setup):
        * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
        (WebCore::SVGPaintServerPattern::setup):
        * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
        (WebCore::SVGPaintServerSolid::setup):
        * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
        (WebCore::SVGResourceClipper::applyClip):
        * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
        (WebCore::SVGResourceMasker::applyMask):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3cb4d7c6

Fix the build: WebKitQt is now called QtWebKit · c14b0062