1. 28 Aug, 2013 1 commit
  2. 27 Aug, 2013 1 commit
    • commit-queue@webkit.org's avatar
      [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation · 018efa13
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119883
      
      Tools:
      
      Implemented the notification listener for AccessibilityUIElement. The signal is generated
      by AXObjectCache::postPlatformNotification() and received by axObjectEventListener().
      axObjectEventListener will then invoke JSObjectCallAsFunction() with the respective
      callback function. The global callback function and callbacks for specific elements are
      stored in a HashMap in AccessibilityCallbacksAtk.cpp.
      
      Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-08-27
      Reviewed by Chris Fleizach.
      
      * DumpRenderTree/AccessibilityUIElement.h: Added a notification handler for GTK+
      * DumpRenderTree/atk/AccessibilityCallbacks.h: Added addAccessibilityNotificationListener()
      and removeAccessibilityNotificationListener()
      * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
      (axObjectEventListener): Call JS callback for global notification or for a specific element
      (disconnectAccessibilityCallbacks): Only disconnect if logging is off and there is no
      notification handler
      (addAccessibilityNotificationHandler): Add notification listener to the list
      (removeAccessibilityNotificationHandler): Remove notification listener from the list
      * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
      (AccessibilityController::setLogAccessibilityEvents): Set logging off before disconnecting
      * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
      (AccessibilityNotificationHandler::AccessibilityNotificationHandler): Create handler
      (AccessibilityNotificationHandler::~AccessibilityNotificationHandler): Destroy handler.
      Remove handler from the list and disconnect callbacks
      (AccessibilityNotificationHandler::setNotificationFunctionCallback): Set the notification
      callback and connect callbacks to signals
      * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Added.
      (AccessibilityNotificationHandler::setPlatformElement): Set platform element
      (AccessibilityNotificationHandler::platformElement): Get platform element
      (AccessibilityNotificationHandler::notificationFunctionCallback): Get notification callback
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (AccessibilityUIElement::addNotificationListener): Create notification handler, set the
      platform element and the notification callback
      (AccessibilityUIElement::removeNotificationListener):
      * DumpRenderTree/efl/CMakeLists.txt: Added AccessibilityNotificationHandlerAtk.cpp/h
      * GNUmakefile.am: Added AccessibilityNotificationHandlerAtk.cpp/h
      
      LayoutTests:
      
      Unskipped the checkbox notification test in a11y and added the expected results.
      
      Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-08-27
      Reviewed by Chris Fleizach.
      
      * platform/gtk/TestExpectations: Unskipped the checkbox notification test in a11y.
      * platform/gtk/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      018efa13
  3. 11 Feb, 2013 1 commit
    • commit-queue@webkit.org's avatar
      [GTK][EFL] Shares WebKit-GTK's DumpRenderTree accessibility implementation with other Webkit ports · 12f598a5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105007
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-02-11
      Reviewed by Martin Robinson.
      
      Shares specific ATK's accessibility implementation.
      Keeps platform specific methods in EFL and GTK's directories.
      
      * DumpRenderTree/atk/AccessibilityCallbacks.h: Renamed from Tools/DumpRenderTree/gtk/AccessibilityCallbacks.h.
      * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Renamed from Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp.
      (printAccessibilityEvent):
      (axObjectEventListener):
      (connectAccessibilityCallbacks):
      (disconnectAccessibilityCallbacks):
      * DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
      (AccessibilityController::AccessibilityController):
      (AccessibilityController::~AccessibilityController):
      (AccessibilityController::elementAtPoint):
      (AccessibilityController::setLogFocusEvents):
      (AccessibilityController::setLogScrollingStartEvents):
      (AccessibilityController::setLogValueChangeEvents):
      (AccessibilityController::setLogAccessibilityEvents):
      (AccessibilityController::addNotificationListener):
      (AccessibilityController::removeNotificationListener):
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp.
      (coreAttributeToAtkAttribute):
      (roleToString):
      (replaceCharactersForResults):
      (AccessibilityUIElement::AccessibilityUIElement):
      (AccessibilityUIElement::~AccessibilityUIElement):
      (AccessibilityUIElement::getLinkedUIElements):
      (AccessibilityUIElement::getDocumentLinks):
      (AccessibilityUIElement::getChildren):
      (AccessibilityUIElement::getChildrenWithRange):
      (AccessibilityUIElement::rowCount):
      (AccessibilityUIElement::columnCount):
      (AccessibilityUIElement::childrenCount):
      (AccessibilityUIElement::elementAtPoint):
      (AccessibilityUIElement::linkedUIElementAtIndex):
      (AccessibilityUIElement::getChildAtIndex):
      (AccessibilityUIElement::indexOfChild):
      (attributeSetToString):
      (AccessibilityUIElement::allAttributes):
      (AccessibilityUIElement::attributesOfLinkedUIElements):
      (AccessibilityUIElement::attributesOfDocumentLinks):
      (AccessibilityUIElement::titleUIElement):
      (AccessibilityUIElement::parentElement):
      (AccessibilityUIElement::attributesOfChildren):
      (AccessibilityUIElement::parameterizedAttributeNames):
      (AccessibilityUIElement::role):
      (AccessibilityUIElement::subrole):
      (AccessibilityUIElement::roleDescription):
      (AccessibilityUIElement::title):
      (AccessibilityUIElement::description):
      (AccessibilityUIElement::stringValue):
      (AccessibilityUIElement::language):
      (AccessibilityUIElement::x):
      (AccessibilityUIElement::y):
      (AccessibilityUIElement::width):
      (AccessibilityUIElement::height):
      (AccessibilityUIElement::clickPointX):
      (AccessibilityUIElement::clickPointY):
      (AccessibilityUIElement::orientation):
      (AccessibilityUIElement::intValue):
      (AccessibilityUIElement::minValue):
      (AccessibilityUIElement::maxValue):
      (AccessibilityUIElement::valueDescription):
      (checkElementState):
      (AccessibilityUIElement::isEnabled):
      (AccessibilityUIElement::insertionPointLineNumber):
      (AccessibilityUIElement::isPressActionSupported):
      (AccessibilityUIElement::isIncrementActionSupported):
      (AccessibilityUIElement::isDecrementActionSupported):
      (AccessibilityUIElement::isRequired):
      (AccessibilityUIElement::isFocused):
      (AccessibilityUIElement::isSelected):
      (AccessibilityUIElement::hierarchicalLevel):
      (AccessibilityUIElement::ariaIsGrabbed):
      (AccessibilityUIElement::ariaDropEffects):
      (AccessibilityUIElement::isExpanded):
      (AccessibilityUIElement::isChecked):
      (AccessibilityUIElement::attributesOfColumnHeaders):
      (AccessibilityUIElement::attributesOfRowHeaders):
      (AccessibilityUIElement::attributesOfColumns):
      (AccessibilityUIElement::attributesOfRows):
      (AccessibilityUIElement::attributesOfVisibleCells):
      (AccessibilityUIElement::attributesOfHeader):
      (AccessibilityUIElement::indexInTable):
      (indexRangeInTable):
      (AccessibilityUIElement::rowIndexRange):
      (AccessibilityUIElement::columnIndexRange):
      (AccessibilityUIElement::lineForIndex):
      (AccessibilityUIElement::boundsForRange):
      (AccessibilityUIElement::stringForRange):
      (AccessibilityUIElement::attributedStringForRange):
      (AccessibilityUIElement::attributedStringRangeIsMisspelled):
      (AccessibilityUIElement::uiElementForSearchPredicate):
      (AccessibilityUIElement::cellForColumnAndRow):
      (AccessibilityUIElement::selectedTextRange):
      (AccessibilityUIElement::setSelectedTextRange):
      (AccessibilityUIElement::stringAttributeValue):
      (AccessibilityUIElement::numberAttributeValue):
      (AccessibilityUIElement::boolAttributeValue):
      (AccessibilityUIElement::isAttributeSettable):
      (AccessibilityUIElement::isAttributeSupported):
      (alterCurrentValue):
      (AccessibilityUIElement::increment):
      (AccessibilityUIElement::decrement):
      (AccessibilityUIElement::press):
      (AccessibilityUIElement::showMenu):
      (AccessibilityUIElement::disclosedRowAtIndex):
      (AccessibilityUIElement::ariaOwnsElementAtIndex):
      (AccessibilityUIElement::ariaFlowToElementAtIndex):
      (AccessibilityUIElement::selectedRowAtIndex):
      (AccessibilityUIElement::rowAtIndex):
      (AccessibilityUIElement::disclosedByRow):
      (AccessibilityUIElement::accessibilityValue):
      (AccessibilityUIElement::documentEncoding):
      (AccessibilityUIElement::documentURI):
      (AccessibilityUIElement::url):
      (AccessibilityUIElement::addNotificationListener):
      (AccessibilityUIElement::removeNotificationListener):
      (AccessibilityUIElement::isFocusable):
      (AccessibilityUIElement::isSelectable):
      (AccessibilityUIElement::isMultiSelectable):
      (AccessibilityUIElement::isSelectedOptionActive):
      (AccessibilityUIElement::isVisible):
      (AccessibilityUIElement::isOffScreen):
      (AccessibilityUIElement::isCollapsed):
      (AccessibilityUIElement::isIgnored):
      (AccessibilityUIElement::hasPopup):
      (AccessibilityUIElement::takeFocus):
      (AccessibilityUIElement::takeSelection):
      (AccessibilityUIElement::addSelection):
      (AccessibilityUIElement::removeSelection):
      (AccessibilityUIElement::scrollToMakeVisible):
      (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
      (AccessibilityUIElement::scrollToGlobalPoint):
      * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers, libraries, new sources.
      * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
      (AccessibilityController::focusedElement):
      (AccessibilityController::rootElement):
      (AccessibilityController::accessibleElementById):
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      (AccessibilityUIElement::helpText):
      * GNUmakefile.am: Adds renamed sources.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12f598a5
  4. 22 Mar, 2012 1 commit
    • carlosgc@webkit.org's avatar
      [GTK] Use the angle-bracket form to include wtf headers · 40a6dd61
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81884
      
      Patch by Carlos Garcia Campos <cgarcia@bb-webkit-rel-64.local.igalia.com> on 2012-03-22
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      Use #include <wtf/foo> instead of #include "foo".
      
      * platform/graphics/freetype/FontPlatformData.h:
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      * platform/gtk/DataObjectGtk.h:
      * platform/network/ResourceHandleInternal.h:
      * platform/network/soup/SocketStreamHandleSoup.cpp:
      
      Source/WebKit/gtk:
      
      Use #include <wtf/foo> instead of #include "foo".
      
      * WebCoreSupport/DocumentLoaderGtk.cpp:
      * WebCoreSupport/DragClientGtk.h:
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      * WebCoreSupport/FullscreenVideoController.h:
      * WebCoreSupport/GeolocationClientGtk.h:
      * WebCoreSupport/InspectorClientGtk.h:
      * WebCoreSupport/TextCheckerClientGtk.cpp:
      * WebCoreSupport/TextCheckerClientGtk.h:
      * webkit/webkitdownload.cpp:
      * webkit/webkitfavicondatabase.cpp:
      * webkit/webkitglobals.cpp:
      * webkit/webkithittestresult.cpp:
      * webkit/webkitnetworkrequest.cpp:
      * webkit/webkitnetworkresponse.cpp:
      * webkit/webkitspellcheckerenchant.cpp:
      * webkit/webkitwebdatasourceprivate.h:
      * webkit/webkitwebsettings.cpp:
      * webkit/webkitwebsettingsprivate.h:
      * webkit/webkitwebviewprivate.h:
      
      Source/WebKit2:
      
      Use #include <wtf/foo> instead of #include <JavaScriptCore/foo>.
      
      * UIProcess/API/gtk/tests/TestMain.h:
      * UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
      
      Tools:
      
      Use #include <wtf/foo> instead of #include "foo".
      
      * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      * DumpRenderTree/gtk/EditingCallbacks.cpp:
      * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
      * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@111696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40a6dd61
  5. 20 Jan, 2012 1 commit
  6. 04 Dec, 2011 1 commit
    • mario@webkit.org's avatar
      Source/WebKit/gtk: Removing document related events from DRT · 07479f66
      mario@webkit.org authored
      [GTK] Don't log document events in DRT
      https://bugs.webkit.org/show_bug.cgi?id=73746
      
      Reviewed by Martin Robinson.
      
      New unit test to check events when reloading a document. This
      replaces the former document-reload-events.html layout test.
      
      * tests/testatk.c:
      (updateLoadingEventsResult): New, updates a global variable to
      allow checking later on that the right signals were emmitted.
      (documentLoadingEventCallback): New, global listener for load-complete
      and reload signals over the document object (the web area).
      (testWebkitAtkDocumentLoadingEvents): New unit test, globally
      connects to document-related signals and check they are properly
      emitted when reloading the web view.
      (main): Added new test.
      
      Tools: [GTK] Don't log document events in DRT
      https://bugs.webkit.org/show_bug.cgi?id=73746
      
      Reviewed by Martin Robinson.
      
      Stop connecting globally to document-related events.
      
      * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
      (connectAccessibilityCallbacks): Removed connections.
      (disconnectAccessibilityCallbacks): Removed disconnections.
      
      LayoutTests: [GTK] Don't log document events in DRT
      https://bugs.webkit.org/show_bug.cgi?id=73746
      
      Reviewed by Martin Robinson.
      
      Unskip passing test, remove other transformed into a unit test and
      rebaseline expectations now we stopped logging document events.
      
      * platform/gtk/Skipped: Removed two skipped tests.
      * platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Rebaselined
      * platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Ditto.
      * platform/gtk/accessibility/document-reload-events-expected.txt: Removed.
      * platform/gtk/accessibility/document-reload-events.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07479f66
  7. 23 Mar, 2011 1 commit
  8. 10 Feb, 2011 1 commit
    • mario@webkit.org's avatar
      2011-02-10 Mario Sanchez Prada <msanchez@igalia.com> · 1a0d80ad
      mario@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Log signals from AtkDocument interface also in AccessibilityController
              https://bugs.webkit.org/show_bug.cgi?id=54198
      
              Trace AtkDocument's signals emission through AccessibilityController.
      
              Also, taken the code related to adding and removing global
              listeners for ATK signals out to a separate file, for the sake of
              clarity and to ease future additions.
      
              * DumpRenderTree/gtk/AccessibilityCallbacks.h: Added.
              * DumpRenderTree/gtk/AccessibilityCallbacks.cpp: Added
              (printAccessibilityEvent): Print information about an event.
              (axObjectEventListener): Global listener for AtkObject's signals.
              (axDocumentEventListener): Global listener for AtkDocument's signals.
              (connectAccessibilityCallbacks): Connect all global listeners.
              (disconnectAccessibilityCallbacks): Disconnect all global listeners.
      
              * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
              (AccessibilityController::setLogAccessibilityEvents): Call to
              connectAccessibilityCallbacks and disconnectAccessibilityCallbacks.
      
              * GNUmakefile.am: Added new files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a0d80ad