1. 13 Aug, 2013 34 commits
    • ch.dumez@sisa.samsung.com's avatar
      NodeList.item() does not behave according to specification · 98e7eeb2
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119722
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Make NodeList.item() indexed getter behave according to specification:
      http://dom.spec.whatwg.org/#nodelist
      
      Namely, we no longer throw if the index is negative (meaning the
      [IsIndex] extended attribute is dropped) and the argument is now
      mandatory.
      
      This behavior is consistent with both IE10 and Firefox and since
      recently Blink.
      
      Test: fast/dom/nodelist-item-parameter.html
      
      * dom/NodeList.idl:
      
      LayoutTests:
      
      Add a layout test to check that the NodeList.item() indexed getter's
      argument is properly validated. Also, update the following test case now
      that the argument is mandatory:
      fast/dom/non-numeric-values-numeric-parameters.html
      
      * fast/dom/nodelist-item-parameter-expected.txt: Added.
      * fast/dom/nodelist-item-parameter.html: Added.
      * fast/dom/non-numeric-values-numeric-parameters-expected.txt:
      * fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98e7eeb2
    • oliver@apple.com's avatar
      Harden executeConstruct against incorrect return types from host functions · 04bbde04
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119757
      
      Reviewed by Mark Hahnenberg.
      
      Add logic to guard against bogus return types.  There doesn't seem to be any
      class in webkit that does this wrong, but the typed array stubs in debug JSC
      do exhibit this bad behaviour.
      
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::executeConstruct):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04bbde04
    • andersca@apple.com's avatar
      Fix build. · 88555b5c
      andersca@apple.com authored
      * WebCore.exp.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88555b5c
    • allan.jensen@digia.com's avatar
      REGRESSION(SUBPIXEL_LAYOUT) Composited layers can cause one pixel shifts · d5cbc754
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115304
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Accelerated layers can cause blocks at subpixel offsets to shift because
      accumulated subpixel offsets are lost between each layers.
      
      To solve this layer bounds are now calculated in LayoutUnits, and their
      subpixel offset saved so it can be used to ensure correct pixel-snapping
      during painting.
      
      Test: fast/sub-pixel/sub-pixel-composited-layers.html
      
      * WebCore.exp.in:
      * inspector/InspectorLayerTreeAgent.cpp:
      (WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
      * platform/graphics/LayoutPoint.h:
      (WebCore::LayoutPoint::fraction):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::setupClipPath):
      (WebCore::RenderLayer::setupFilters):
      (WebCore::RenderLayer::paintLayerContents):
      (WebCore::RenderLayer::calculateLayerBounds):
      * rendering/RenderLayer.h:
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateCompositedBounds):
      (WebCore::RenderLayerBacking::updateAfterWidgetResize):
      (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
      (WebCore::RenderLayerBacking::resetContentsRect):
      (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer):
      (WebCore::RenderLayerBacking::contentsBox):
      (WebCore::RenderLayerBacking::backgroundBox):
      (WebCore::RenderLayerBacking::paintIntoLayer):
      (WebCore::RenderLayerBacking::paintContents):
      (WebCore::RenderLayerBacking::compositedBounds):
      (WebCore::RenderLayerBacking::setCompositedBounds):
      * rendering/RenderLayerBacking.h:
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::logLayerInfo):
      (WebCore::RenderLayerCompositor::calculateCompositedBounds):
      * rendering/RenderLayerCompositor.h:
      * rendering/RenderTreeAsText.cpp:
      (WebCore::operator<<):
      * rendering/RenderTreeAsText.h:
      
      LayoutTests:
      
      * fast/sub-pixel/sub-pixel-composited-layers-expected.html: Added.
      * fast/sub-pixel/sub-pixel-composited-layers.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5cbc754
    • zandobersek@gmail.com's avatar
      [Autotools] Unicode's CFLAGS enforce -D_FORTIFY_SOURCE=2, -D_REENTRANT=1,... · f18ab334
      zandobersek@gmail.com authored
      [Autotools] Unicode's CFLAGS enforce -D_FORTIFY_SOURCE=2, -D_REENTRANT=1, causing faulty Clang builds
      https://bugs.webkit.org/show_bug.cgi?id=119685
      
      Reviewed by Gustavo Noronha Silva.
      
      icu-config includes '-D_FORTIFY_SOURCE=2 -D_REENTRANT=1' when printing out C preprocessor flags that are used
      as the C compiler flags to avoid other unwanted compiler options. This causes problems when building optimized
      builds with Clang because of a bug in that compiler:
      http://llvm.org/bugs/show_bug.cgi?id=16821
      
      To avoid that, the C preprocessor search flags, as printed by `icu-config --cppflags-searchpath` are now used
      the Unicode dependency's C compiler flags, avoiding unconditionally specifying the two macros.
      
      To adjust for that, the `-pthread` flag is added to the global CFLAGS and CXXFLAGS variables, ensuring
      the _REENTRANT define is set to 1 and declaring the flag globally instead of relying on Glib dependency's
      C compiler flags to do so for us. -D_FORTIFY_SOURCE=2 is only added to the CFLAGS and CXXFLAGS variables if
      the compiler in use is gcc or g++, preventing the Clang builds to malfunction.
      
      * Source/autotools/FindDependencies.m4:
      * Source/autotools/SetupCompilerFlags.m4:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f18ab334
    • zandobersek@gmail.com's avatar
      [Autotools] Don't compare $CC, $CXX to exact compiler names · c1aaaea0
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119683
      
      Reviewed by Gustavo Noronha Silva.
      
      Instead of comparing $CC and $CXX to exact compiler names (like 'gcc', 'clang++' etc.),
      use the compiler version checks to also specify the broader compiler collection of which
      the used compiler is a member of. This avoids failures in some border-line cases where
      the user would still use either a GCC or a Clang compiler but provide it through a symbolic
      link that was specified via the CC/CXX environment variables.
      
      * Source/autotools/CheckSystemAndBasicDependencies.m4: Store the detected C/C++ compiler collection
      in c_compiler/cxx_compiler. Throw an error if no supported compiler was found.
      * Source/autotools/SetupCompilerFlags.m4: Test for a specific compiler by checking against
      c_compiler/cxx_compiler rather than CC/CXX values.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1aaaea0
    • commit-queue@webkit.org's avatar
      [Curl] Possible infinite loop while downloading. · 85ee948c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119744
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-08-13
      Reviewed by Darin Adler.
      
      If adding/removing curl handles fails, the download thread
      can end up in an endless loop trying to update the curl handle list.
      
      * platform/network/curl/CurlDownload.cpp:
      (WebCore::CurlDownloadManager::updateHandleList): Avoid infinite loop by ignoring return value.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85ee948c
    • ch.dumez@sisa.samsung.com's avatar
      HTMLSelectElement.item() does not behave according to specification · 64a2fa50
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119738
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Make HTMLSelectElement.item() behave according to specification:
      http://www.w3.org/TR/html51/forms.html#dom-select-item
      http://dom.spec.whatwg.org/#dom-htmlcollection-item
      
      Namely, we no longer throw if the offset argument is negative. Also,
      the argument is now mandatory.
      
      IE10, Firefox and Blink do not throw when HTMLSelectElement.item() is
      called with a negative value (as per the specification).
      
      The argument is mandatory in Firefox and Blink, but optional in IE10
      (it returns null when called without argument). This looks like a bug
      in IE because other item() getters' argument is usually mandatory in IE
      (e.g. NodeList.item()).
      
      Test: fast/dom/HTMLSelectElement/select-element-item-argument.html
      
      * html/HTMLSelectElement.idl:
      
      LayoutTests:
      
      Add a new layout test to check that the HTMLSelectElement.item() indexed getter's
      parameter is correctly validated.
      Also update fast/dom/non-numeric-values-numeric-parameters.html now that the
      argument is mandatory.
      
      * fast/dom/HTMLSelectElement/select-element-item-argument-expected.txt: Added.
      * fast/dom/HTMLSelectElement/select-element-item-argument.html: Added.
      * fast/dom/non-numeric-values-numeric-parameters-expected.txt:
      * fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64a2fa50
    • ch.dumez@sisa.samsung.com's avatar
      On request error, always fire events on the XMLHttpRequestUpload before the XMLHttpRequest · 205dab32
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119714
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      On request error, fire events on the XMLHttpRequestUpload object before the XMLHttpRequest
      object as per the latest specification:
      http://xhr.spec.whatwg.org/#request-error
      
      This specification change was made in Sept 2010:
      http://dev.w3.org/cvsweb/2006/webapi/XMLHttpRequest-2/Overview.src.html.diff?r1=1.138;r2=1.139;f=h
      
      It addresses the following comment:
      http://lists.w3.org/Archives/Public/public-webapps/2010JulSep/0777.html
      
      IE10 and since recently Blink behave according to specification but WebKit was firing the
      events on the XMLHttpRequest object BEFORE the XMLHttpRequestUpload object in case of
      'network error' or 'abort error'. WebKit was however behaving according to specification
      in case of 'timeout error', which was inconsistent.
      
      Test: http/tests/xmlhttprequest/upload-request-error-event-order.html
      
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::networkError):
      (WebCore::XMLHttpRequest::abortError):
      
      LayoutTests:
      
      Add a layout test to validate the order in which the events are fired in case
      of a xhr request error. Also update an existing test which was relying on the
      outdated firing order.
      
      * http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt:
      * http/tests/xmlhttprequest/simple-cross-origin-progress-events.html:
      * http/tests/xmlhttprequest/upload-request-error-event-order-expected.txt: Added.
      * http/tests/xmlhttprequest/upload-request-error-event-order.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      205dab32
    • ch.dumez@sisa.samsung.com's avatar
      Simplify RadioNodeList's anonymous indexed getter · 7340ea89
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119725
      
      Reviewed by Darin Adler.
      
      Simplify RadioNodeList's anonymous indexed getter by dropping [IsIndex]
      IDL extended attribute from its parameter and making it mandatory.
      
      This change has strictly no impact on the generated bindings code
      but it simplifies the IDL.
      
      No new test, no behavior change.
      
      * html/RadioNodeList.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7340ea89
    • allan.jensen@digia.com's avatar
      [Qt] Fix C++11 build with gcc 4.4 and 4.5 · 9081187b
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119736
      
      Reviewed by Anders Carlsson.
      
      Don't force C++11 mode off anymore.
      
      * Target.pri:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9081187b
    • rakuco@webkit.org's avatar
      [EFL][DRT] Simplify call to reverseFind() · 80b26826
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119746
      
      Reviewed by Christophe Dumez.
      
      Follow-up to r153977.
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (pathSuitableForTestResult): Instead of defining a static variable
      that's only used in a single place, pass '/' to reverseFind() directly.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80b26826
    • commit-queue@webkit.org's avatar
      [GTK] close the volume slider when the media control panel is hidden · 6385b615
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119062
      
      Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2013-08-13
      Reviewed by Gustavo Noronha Silva.
      
      It's not obvious how to close the volume slider on webkitGtk.
      The volume slider should close if the control panel is hidden.
      
      * html/shadow/MediaControlsGtk.cpp:
      (WebCore::MediaControlsGtk::makeTransparent):
      * html/shadow/MediaControlsGtk.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6385b615
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Rebase tests after r153901 and r153915. Skip failing tests. · ba11246f
      zarvai@inf.u-szeged.hu authored
      Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-08-13
      
      * platform/qt-5.0-wk2/TestExpectations:
      * platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png: Removed.
      * platform/qt-5.0/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Removed.
      * platform/qt/TestExpectations:
      * platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Added.
      * platform/qt/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png:
      * platform/qt/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba11246f
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r152563. · 642575b2
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/152563
      https://bugs.webkit.org/show_bug.cgi?id=119740
      
      causes random crashes (Requested by carewolf on #webkit).
      
      * platform/graphics/qt/FontCacheQt.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      642575b2
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 3890bb42
      zandobersek@gmail.com authored
      * platform/gtk/TestExpectations: Simplify test failure expectations to remove various lint failures,
      also removing a couple of expectations for tests that are passing in the process.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3890bb42
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 5e05af5d
      zandobersek@gmail.com authored
      * platform/gtk/fast/repaint/caret-jump-between-nodes-expected.txt: Added. Rebaselining after r153815.
      * platform/gtk/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png: Rebaselining after r153901.
      * platform/gtk/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e05af5d
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 7d32f466
      zandobersek@gmail.com authored
      * platform/gtk/TestExpectations: Add failure expectations for various failing tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d32f466
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Skipping new fails. · b35425a1
      zarvai@inf.u-szeged.hu authored
      Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-08-13
      
      * platform/qt-5.0-wk1/TestExpectations:
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b35425a1
    • abucur@adobe.com's avatar
      Unreviewed. · de330072
      abucur@adobe.com authored
      Fix the build after http://trac.webkit.org/changeset/153990.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateShapesBeforeBlockLayout): Add the default return value if CSS Shapes are disabled.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de330072
    • a.bah@samsung.com's avatar
      Adding testcase for verifying editing behavior for up/down caret movement between lines. · 33d62de8
      a.bah@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119511
      
      Reviewed by Ryosuke Niwa.
      
      * editing/selection/verify-editing-behavior-for-line-granularity-expected.txt: Added.
      * editing/selection/verify-editing-behavior-for-line-granularity.html: Added.
      Layout testcase added for verifying that the up/down caret movement between
      lines is similar to the default text editor behavior on various platforms.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33d62de8
    • berto@igalia.com's avatar
      [GTK] Closing inspector window crashes wk · c55ca377
      berto@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=110865
      
      Reviewed by Carlos Garcia Campos.
      
      Source/WebKit/gtk:
      
      Deleting priv->corePage during the destruction of a webView will
      trigger the deletion of InspectorFrontendClient. However that
      object is supposed to handle the webView's destroy signal first in
      order to do the necessary cleanup.
      
      The solution is to wait until webkit_web_view_dispose finishes
      before deleting priv->corePage.
      
      * webkit/webkitwebview.cpp:
      (webkit_web_view_dispose):
      
      Tools:
      
      Disconnect all signal handlers if the inspector window is
      destroyed.
      
      * GtkLauncher/LauncherInspectorWindow.c:
      (inspectorWindowDestroyed):
      (launcherInspectorWindowNew):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c55ca377
    • abucur@adobe.com's avatar
      [CSS Regions] Compute correct region ranges for boxes · 33159da0
      abucur@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116296
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      The patch extends the region ranges implementation with the following behavior:
      - the range of a box is always included in the range of its containing block (even for floats); this will simplify how overflow
      is propagated to the regions and it should later change on a case by case basis.
      - if the range of a box is not correctly estimated before the layout it will be marked for relayout; this is necessary to correctly
      position boxes that overflow naturally, like floats.
      - all the boxes have a range now, not only the blocks.
      - regionAtBlockOffset can clamp to a box.
      - an unsplittable box has a region range of a single region, the one where the box top falls into.
      
      When the layout of a child box starts it tries to give an estimate based on the maximal height of the box. After the layout,
      if the estimation was wrong, the box is relaid out. For example, if a block with a float is laid out in a region but the float
      overflows in the next region a relayout is needed for the float so it can be positioned relative to the containing block
      region (this step can be optimized by making a layout pass only for the children that don't have the region range enclosed in the
      containing block range).
      
      Tests: fast/regions/bottom-overflow-out-of-first-region-absolute.html
             fast/regions/float-pushed-width-change-2.html
             fast/regions/scrollable-paragraph-unsplittable.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateShapesBeforeBlockLayout): Doesn't do anything for regions now.
      (WebCore::RenderBlock::updateShapesAfterBlockLayout): Doesn't do anything for regions now.
      (WebCore::RenderBlock::relayoutToAvoidWidows): The layout to avoid widows. Widows use the line index to determine the break point,
      not the RootLineBox pointer as before. This is necessary to prevent stale pointers in further layouts.
      (WebCore::RenderBlock::layoutBlock):
      (WebCore::RenderBlock::layoutBlockChild):
      (WebCore::RenderBlock::layoutPositionedObjects):
      (WebCore::RenderBlock::markForPaginationRelayoutIfNeeded): Relayout for widows during layoutBlock(). Don't wait to exit the block layout.
      (WebCore::RenderBlock::positionNewFloats):
      (WebCore::RenderBlock::hasNextPage):
      (WebCore::RenderBlock::applyBeforeBreak):
      (WebCore::RenderBlock::applyAfterBreak):
      (WebCore::RenderBlock::setPageBreak):
      (WebCore::RenderBlock::updateMinimumPageHeight):
      (WebCore::RenderBlock::regionAtBlockOffset): This function can now clamp at a box.
      (WebCore::RenderBlock::computeRegionRangeForBoxChild): Calculate the box region range using the box height.
      (WebCore::RenderBlock::estimateRegionRangeForBoxChild): Estimate the box region range using a huge height for the box.
      (WebCore::RenderBlock::updateRegionRangeForBoxChild): Determine the final region range of a box.
      * rendering/RenderBlock.h:
      (WebCore::RenderBlock::logicalWidthForChild):
      (WebCore::RenderBlock::logicalHeightForChild):
      (WebCore::RenderBlock::logicalTopForChild):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::layoutInlineChildren):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::clampToStartAndEndRegions):
      (WebCore::RenderBox::borderBoxRectInRegion):
      * rendering/RenderBox.h:
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::layoutBlock):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::validateRegions):
      (WebCore::RenderFlowThread::regionAtBlockOffset):
      (WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent):
      (WebCore::RenderFlowThread::pageLogicalTopForOffset):
      (WebCore::RenderFlowThread::pageLogicalWidthForOffset):
      (WebCore::RenderFlowThread::pageLogicalHeightForOffset):
      (WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset):
      (WebCore::RenderFlowThread::mapFromFlowToRegion):
      (WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
      (WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
      (WebCore::RenderFlowThread::clearRenderBoxRegionInfoAndCustomStyle):
      (WebCore::RenderFlowThread::setRegionRangeForBox):
      (WebCore::RenderFlowThread::applyBreakAfterContent):
      (WebCore::RenderFlowThread::addForcedRegionBreak):
      * rendering/RenderFlowThread.h:
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::layoutBlock):
      * rendering/RenderMultiColumnFlowThread.cpp:
      (WebCore::RenderMultiColumnFlowThread::setPageBreak):
      (WebCore::RenderMultiColumnFlowThread::updateMinimumPageHeight):
      * rendering/RenderMultiColumnFlowThread.h:
      
      LayoutTests:
      
      Tests for the changes in how region ranges are computed and applied.
      
      * fast/regions/bottom-overflow-out-of-first-region-absolute-expected.html: Added.
      * fast/regions/bottom-overflow-out-of-first-region-absolute.html: Added.
      * fast/regions/float-pushed-width-change-2-expected.html: Copied from LayoutTests/fast/regions/float-pushed-width-change-expected.html.
      * fast/regions/float-pushed-width-change-2.html: Copied from LayoutTests/fast/regions/float-pushed-width-change.html.
      * fast/regions/float-pushed-width-change-expected.html:
      * fast/regions/float-pushed-width-change.html:
      * fast/regions/scrollable-paragraph-unsplittable-expected.html: Added.
      * fast/regions/scrollable-paragraph-unsplittable.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33159da0
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · cc7d8bd9
      zandobersek@gmail.com authored
      * platform/gtk/editing/caret/caret-color-expected.txt: Rebaselining after r152612.
      * platform/gtk/fast/js/dom-static-property-for-in-iteration-expected.txt: Rebaselining after r153772.
      * platform/gtk/fast/js/global-constructors-attributes-expected.txt: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc7d8bd9
    • rniwa@webkit.org's avatar
      One more speculative Windows build fix after r153978. · 4b6473d5
      rniwa@webkit.org authored
      * page/win/DragControllerWin.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b6473d5
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · da59fd6b
      zandobersek@gmail.com authored
      Rebaselining after r153647.
      
      * platform/gtk/fast/css/input-search-padding-expected.txt:
      * platform/gtk/fast/css/text-overflow-input-expected.txt:
      * platform/gtk/fast/forms/box-shadow-override-expected.txt:
      * platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
      * platform/gtk/fast/forms/input-appearance-height-expected.txt:
      * platform/gtk/fast/forms/placeholder-position-expected.txt:
      * platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
      * platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
      * platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
      * platform/gtk/fast/forms/search-rtl-expected.txt:
      * platform/gtk/fast/forms/search-size-with-decorations-expected.txt: Added.
      * platform/gtk/fast/forms/search-styled-expected.txt:
      * platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
      * platform/gtk/fast/forms/searchfield-heights-expected.txt:
      * platform/gtk/fast/repaint/search-field-cancel-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da59fd6b
    • gyuyoung.kim@samsung.com's avatar
      Update scheme list according to latest specification · f483399d
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119510
      
      Reviewed by Christophe Dumez.
      
      New schemes are added to it additionally. Those are bitcoin, im, ircs and wtai.
      As additional work, scheme order is listed to be sync with spec.
      
      Spec: http://www.w3.org/html/wg/drafts/html/master/webappapis.html#custom-handlers
      
      Source/WebCore:
      
      Test: fast/dom/register-protocol-handler.html
            fast/dom/unregister-protocol-handler.html
      
      * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
      (WebCore::initProtocolHandlerWhitelist):
      
      LayoutTests:
      
      * fast/dom/register-protocol-handler-expected.txt:
      * fast/dom/register-protocol-handler.html:
      * fast/dom/unregister-protocol-handler-expected.txt:
      * fast/dom/unregister-protocol-handler.html:
      * platform/efl/fast/dom/register-protocol-handler-expected.txt:
      * platform/efl/fast/dom/unregister-protocol-handler-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f483399d
    • rniwa@webkit.org's avatar
      Yet another Windows build fix attempt after r153978. · 4d4c3225
      rniwa@webkit.org authored
      * page/win/DragControllerWin.cpp:
      (WebCore::DragController::declareAndWriteDragImage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d4c3225
    • rniwa@webkit.org's avatar
      Another Windows build fix attempt after r153978. · 6356f9bc
      rniwa@webkit.org authored
      * page/win/DragControllerWin.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6356f9bc
    • rniwa@webkit.org's avatar
      Windows build fix attempt after r153978. · 3769bfdc
      rniwa@webkit.org authored
      * page/win/DragControllerWin.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3769bfdc
    • rniwa@webkit.org's avatar
      Fix null dereference in HTMLAnchorElement::sendPings when frame is not attached to a page · 074d1c18
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119716
      
      Reviewed by Darin Adler.
      
      Add a regression test for r153975.
      
      * fast/html/detach-frame-while-clicking-on-anchor-with-ping-expected.txt: Added.
      * fast/html/detach-frame-while-clicking-on-anchor-with-ping.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      074d1c18
    • zandobersek@gmail.com's avatar
      ASSERTION FAILED: type() == Percent in WebCore::Length::percent · 45106692
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116715
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Allow the Calculated type in the Length::percent method that returns the Length's
      float value. This reflects the changes in r110148 that adjusted the Length::isPercent
      method to return true for Length objects of either Percent or Calculated type.
      
      Test: fast/css/calculated-length-as-percent-crash.html
      
      * platform/Length.h:
      (WebCore::Length::percent): Assert that Length::isPercent is true when Length::percent
      is called, ensuring the Length's type is either Percent or Calculated.
      
      LayoutTests: 
      
      Add the test case, as produced by the Fuzzinator, that was causing assertions
      in Length::percent due to Length objects of the Calculated type not being treated
      as holding a proper percent value in that method, despite Length::isPercent
      returning true for Length objects of either Percent or the Calculated type.
      
      * fast/css/calculated-length-as-percent-crash-expected.txt: Added.
      * fast/css/calculated-length-as-percent-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45106692
    • mitz@apple.com's avatar
      extract-localizable-strings output is not suited for parsing by Xcode · 683713c0
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119728
      
      Reviewed by Darin Adler.
      
      Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
      removed “ERROR” since messages that refer to a line in a file are shown as error by default,
      added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
      with 0).
      
      * Scripts/extract-localizable-strings:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      683713c0
    • zandobersek@gmail.com's avatar
      [Autotools] Adjust the help string for the configure's --enable-optimizations flag · 902a91c5
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119682
      
      Reviewed by Martin Robinson.
      
      * Source/autotools/ReadCommandLineArguments.m4: Remove the 'GCC only' part of the help
      string for the --enable-optimizations flag. This is not true and can lead to confusion
      since the optimizations can be applied when compiling with Clang as well.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      902a91c5
  2. 12 Aug, 2013 6 commits
    • darin@apple.com's avatar
      Move Clipboard::declareAndWriteDragImage to DragController · 5ae15617
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117683
      
      Reviewed by Brent Fulgham.
      
      * dom/Clipboard.h: Removed declareAndWriteDragImage.
      
      * page/DragController.cpp:
      (WebCore::selectImageBeforeDragging): Half of the old prepareClipboardForImageDrag
      is now refactored into this function.
      (WebCore::DragController::startDrag): Where we called prepareClipboardForImageDrag,
      instead call selectImageBeforeDragging and declareAndWriteDragImage. This is needed
      because declareAndWriteDragImage needs to be a member function, for Mac at least.
      
      * page/DragController.h: Added declareAndWriteDragImage.
      
      * page/efl/DragControllerEfl.cpp:
      (WebCore::DragController::declareAndWriteDragImage): Added empty placeholder.
      It would be better to delete this file rather than having these placeholders.
      I don't think EFL actually has drag support, and it makes work to have to keep
      source files up to date that are really unused.
      
      * page/gtk/DragControllerGtk.cpp:
      (WebCore::DragController::declareAndWriteDragImage): Added. Calls Pasteboard::writeImage.
      * page/mac/DragControllerMac.mm:
      (WebCore::DragController::declareAndWriteDragImage): Added. Calls to DragClient, which
      does the work.
      * page/qt/DragControllerQt.cpp:
      (WebCore::DragController::declareAndWriteDragImage): Added. Calls Pasteboard::writeImage.
      * page/win/DragControllerWin.cpp:
      (WebCore::DragController::declareAndWriteDragImage): Added. Uses Pasteboard functions to
      do the work.
      
      * platform/Clipboard.h: Changed the pasteboard function to return a non-const reference.
      For now, it's not clear what const will mean for pasteboards, and it's currently not
      possible to write to a const pasteboard, which we need to do in the new
      DragController::declareAndWriteDragImage functions.
      
      * platform/Pasteboard.h: Added a new writeMarkup function, implemented only for Windows
      at this time.
      
      * platform/efl/ClipboardEfl.cpp: Deleted declareAndWriteDragImage.
      * platform/gtk/ClipboardGtk.cpp: Ditto.
      * platform/ios/ClipboardIOS.h: Ditto.
      * platform/ios/ClipboardIOS.mm: Ditto.
      * platform/mac/ClipboardMac.mm: Ditto.
      * platform/qt/ClipboardQt.cpp: Ditto.
      * platform/win/ClipboardWin.cpp: Ditto.
      
      * platform/win/PasteboardWin.cpp:
      (WebCore::Pasteboard::writePlainTextToDataObject): Took out a pointless line of code.
      (WebCore::Pasteboard::writeMarkup): Added. Currently implemented only for Windows.
      This factors out a significant piece of DragController::declareAndWriteDragImage,
      and will probably be handy for other platforms later.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ae15617
    • ryuan.choi@samsung.com's avatar
      [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT · bd6c5771
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119585
      
      Reviewed by Gyuyoung Kim.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::provisionalURL):
      Implemented to pass provisionalURL of main frame to DumpRenderTreeChrome.
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      
      Tools:
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (pathSuitableForTestResult):
      Return path string that's relative to main frame URL, or just file name if
      the resource is not in the same directory subtree.
      Referenced WebKitTestRunner code in r153852.
      (descriptionSuitableForTestResult):
      (DumpRenderTreeChrome::onFrameRedirectRequested):
      (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd6c5771
    • mitz@apple.com's avatar
      extract-localizable-strings doesn't know how to verify an existing strings file · ba4baefc
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119704
      
      Reviewed by Darin Adler.
      
      * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
      exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
      exceptions file name to omitting the --exceptions option. Added a --skip option, changing
      the way directories to skip are specified from prefixing the directory with a “-” to
      specifying it with --skip.
      Finally, added a --verify option. When specified, the strings file is not written to, but
      instead read in and checked for consistency with the comments, keys and values derived from
      the source files and the exceptions file. Missing keys, unused keys, mismatching values and
      mismatching comments are reported as errors.
      * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
      directories to skip and no exceptions file.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba4baefc
    • rniwa@webkit.org's avatar
      Fix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist · 8fcb3d52
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119716
      
      Reviewed by Darin Adler.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/d5783da353ab783e9994b8fbecd91880be5192a1
      
      No new tests since the test in the Blink change doesn't reproduce crash on WebKit.
      
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::sendPings):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fcb3d52
    • seokju@webkit.org's avatar
      Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() · 7a88c7aa
      seokju@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119710
      
      Reviewed by Darin Adler.
      
      No behavior change, no new tests needed.
      
      * rendering/RenderObject.cpp: Remove unused parameter warning.
      (WebCore::shouldRepaintFixedBackgroundsOnScroll):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a88c7aa
    • ap@apple.com's avatar
      http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac · f8c414e3
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=85522
      
      Reviewed by Andy Estes.
      
      Source/WebCore:
      
      Drive-by FIXMEs and trivial fixes for WebCore issues I noticed while working
      on this bug. No behavior change expected.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::submitForm):
      (WebCore::FrameLoader::findFrameForNavigation):
      * loader/NavigationScheduler.cpp:
      (WebCore::ScheduledFormSubmission::fire):
      
      Tools:
      
      * DumpRenderTree/mac/UIDelegate.mm:
      (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
      when already done with a test. We already had this check in all UI delegate functions,
      except for -webView:addMessageToConsole:withSource: somehow.
      
      LayoutTests:
      
      * http/tests/security/sandboxed-iframe-form-top-expected.txt: Console logging got
      improved while this test was marked as skipped or flaky, updating the results.
      
      * platform/mac/TestExpectations: Removed sandboxed-iframe-form-top.html, this test
      no longer leaks output into later ones. The test was erroneously marked as flaky
      instead of skipped, but now it's good.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8c414e3