- 18 Mar, 2007 18 commits
-
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
Reviewed by aroben * css/html4.css: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
Move frame borders out of WebKit and into WebCore. Reviewed by aroben, olliej * bridge/mac/FrameViewMac.mm: * css/html4.css: * html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::HTMLFrameSetElement): (WebCore::HTMLFrameSetElement::mapToEntry): (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::attach): * html/HTMLFrameSetElement.h: (WebCore::HTMLFrameSetElement::hasBorderColor): * page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): * page/FrameView.h: * page/mac/WebCoreFrameBridge.h: * platform/graphics/IntRect.h: (WebCore::IntRect::topLeft): (WebCore::IntRect::topRight): (WebCore::IntRect::bottomLeft): (WebCore::IntRect::bottomRight): * rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared): * rendering/RenderFrameSet.cpp: (WebCore::borderStartEdgeColor): (WebCore::borderEndEdgeColor): (WebCore::RenderFrameSet::paintColumnBorder): (WebCore::RenderFrameSet::paintRowBorder): (WebCore::RenderFrameSet::paint): * rendering/RenderFrameSet.h: * rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::viewCleared): * rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle): WebKit: Move frame borders out of WebKit and into WebCore. Reviewed by aroben, olliej * WebCoreSupport/WebFrameBridge.mm: * WebKit.xcodeproj/project.pbxproj: * WebView/WebFrameView.mm: (-[WebFrameView drawRect:]): (-[WebFrameView setFrameSize:]): * WebView/WebFrameViewInternal.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 17 Mar, 2007 10 commits
-
-
hyatt authored
Make onload do an explicit paint when a top-level document is ready (to ensure that a first paint always happens before any timers set by the onload can fire). Reviewed by aroben * dom/Document.cpp: (WebCore::Document::implicitClose): * platform/ScrollView.h: * platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::update): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
Fixed <rdar://problem/5070967> REGRESSION (r20211): Repro crash when closing View Source window I award myself 0 points, and may God have mercy on my soul. * bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kjk authored
* platform/gdk/TemporaryLinkStubs.cpp: (Pasteboard::writeURL): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
Fix tiny PLT regression. Don't examine the border/background data for RenderImage when images change unless we actually have a border/background. Reviewed by Brady * rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sullivan authored
Discovered while working on <rdar://problem/5070334> that many WebView calls will crash if called after -[WebView close] has executed because _private->page is deferenced after it's been set to 0. It might be silly/wrong to call these methods after -close, but obviously it shouldn't crash. Made each use of _private->page robust against nil-dereferencing. * WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView _updateWebCoreSettingsFromPreferences:]): (-[WebView _setDashboardBehavior:to:]): (-[WebView _dashboardBehavior:]): (-[WebView goBack]): (-[WebView goForward]): (-[WebView goToBackForwardItem:]): (-[WebView canGoBack]): (-[WebView canGoForward]): (-[WebView setTabKeyCyclesThroughElements:]): (-[WebView tabKeyCyclesThroughElements]): (-[WebView setEditable:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann authored
Fixes: http://bugs.webkit.org/show_bug.cgi?id=13046 (CSS styles on hover and focus are broken for <use>) Fixes: http://bugs.webkit.org/show_bug.cgi?id=12838 (SVG <use> CSS styles broken) Added test: svg/custom/use-css-events.svg In general this fixes the peepo.co.uk website. Forgot to pass the actual StyleChange to the recalcStyle() function, when calling it on the shadow tree root element. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
Reviewed by Mark Rowe. Made Version.xcconfig smarter when building for different configurations. Now uses the 522+ OpenSource version for Debug and Release, while using the full 522.4 version for Production builds. The system prefix is also computed based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard. * Configurations/JavaScriptCore.xcconfig: * Configurations/Version.xcconfig: JavaScriptGlue: Reviewed by Mark Rowe. Made Version.xcconfig smarter when building for different configurations. Now uses the 522+ OpenSource version for Debug and Release, while using the full 522.4 version for Production builds. The system prefix is also computed based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard. * Configurations/JavaScriptGlue.xcconfig: * Configurations/Version.xcconfig: WebCore: Reviewed by Mark Rowe. Made Version.xcconfig smarter when building for different configurations. Now uses the 522+ OpenSource version for Debug and Release, while using the full 522.4 version for Production builds. The system prefix is also computed based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard. * Configurations/Version.xcconfig: * Configurations/WebCore.xcconfig: WebKit: Reviewed by Mark Rowe. Made Version.xcconfig smarter when building for different configurations. Now uses the 522+ OpenSource version for Debug and Release, while using the full 522.4 version for Production builds. The system prefix is also computed based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard. * Configurations/Version.xcconfig: * Configurations/WebKit.xcconfig: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti authored
Reviewed by Adele. Test for http://bugs.webkit.org/show_bug.cgi?id=12595 REGRESSION: Can't add item to cart at lnt.com (JS type error) <rdar://problem/4722863> Expanded version of Darin's test case. * fast/forms/old-names-expected.txt: Added. * fast/forms/old-names.html: Added. WebCore: Reviewed by Adele. Fix http://bugs.webkit.org/show_bug.cgi?id=12595 REGRESSION: Can't add item to cart at lnt.com (JS type error) <rdar://problem/4722863> Emulate Firefox behavior where form elements accessed by a name can be accessed with that name later even if the name changes or even if element is removed from the document. This is loosely based on Darin's earlier patch for the same problem but is much less expansive. It takes somewhat different approach to more closely mimic Firefox behavior. Includes expanded test case. * bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::canGetItemsForName): Use new the HTMLFormElement::getNamedElements() method (WebCore::JSHTMLFormElement::nameGetter): Use new the HTMLFormElement::getNamedElements() method * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::elementForAlias): (WebCore::HTMLFormElement::addElementAlias): Maintain a map of known element aliases (WebCore::HTMLFormElement::getNamedElements): Get a list of elements matching the name, based both their current names and known aliases (earlier names). Keep the alias list in sync. * html/HTMLFormElement.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
Reviewed by Hyatt. Updated test for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox http://bugs.webkit.org/show_bug.cgi?id=12725 * fast/forms/listbox-onchange-expected.txt: * fast/forms/listbox-onchange.html: WebCore: Reviewed by Hyatt. Fix for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox http://bugs.webkit.org/show_bug.cgi?id=12725 Test: updated fast/forms/listbox-onchange.html Added HTMLSelectElement::saveLastSelection that is called before changing a selection that could result in onChange being called. m_lastOnChangeIndex and m_lastOnChangeSelection no longer have to be up-to date all the time, they just have to be up-to-date before we execute an action that may trigger onChange. * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelectedState): Added. The HTMLSelectElement will only set an option's selected state with this method. This ensures that notifyOptionSelected won't get called when the call originates from the select element. * html/HTMLOptionElement.h: * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): Calls setSelectedState. (WebCore::HTMLSelectElement::setSelectedIndex): ditto. Don't update the last selection variables here. Scroll to the new selection. The scrolling call used to only be in notifyOptionSelected. There's no reason we shouldn't scroll when the selection is set through the HTMLSelectElement. (WebCore::HTMLSelectElement::setValue): Call setSelectedIndex to update all options selected state. (WebCore::HTMLSelectElement::restoreState): Call setSelectedState. (WebCore::HTMLSelectElement::selectAll): Call saveLastSelection before making the selection, and calling onChange. (WebCore::HTMLSelectElement::recalcListItems): Call setSelectedState. Don't need to save selection here anymore, since it will get saved before we call onChange. (WebCore::HTMLSelectElement::reset): ditto. (WebCore::HTMLSelectElement::dispatchFocusEvent): Added. Call saveLastSelection for menu lists, since onChange can be fired on blur. (WebCore::HTMLSelectElement::dispatchBlurEvent): Call menuListOnChange. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Call saveLastSelection before showing the popup window. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Call saveLastSelection during mousedown (to prepare for an onchange during mouseup, or after autoscroll). (WebCore::HTMLSelectElement::updateListBoxSelection): Call setSelectedState. (WebCore::HTMLSelectElement::menuListOnChange): Added. Compares the m_lastOnChangeIndex to the selectedIndex(). (WebCore::HTMLSelectElement::listBoxOnChange): Move the m_lastOnChangeSelection creation to saveLastSelection. (WebCore::HTMLSelectElement::saveLastSelection): Added. Sets m_lastOnChangeIndex or m_lastOnChangeSelection. * html/HTMLSelectElement.h: * platform/PopupMenu.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 16 Mar, 2007 12 commits
-
-
oliver authored
Reviewed by Hyatt. WebCore: The old canSaveAsWebArchive call was necessary as stand alone images used to be rendered by ImageDocument. Fixes rdar://problem/5061252 * dom/Clipboard.cpp: * dom/Clipboard.h: (WebCore::Clipboard::setDragHasStarted): * page/DragClient.h: (WebCore::DragClient::declareAndWriteDragImage): * platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::declareAndWriteDragImage): WebKit: * WebCoreSupport/WebDragClient.h: * WebCoreSupport/WebDragClient.mm: (WebDragClient::declareAndWriteDragImage): * WebKit.xcodeproj/project.pbxproj: LayoutTests: Updating layout test to allow stand alone image to be dragged into a content editable div * fast/events/standalone-image-drag-to-editable-expected.checksum: * fast/events/standalone-image-drag-to-editable-expected.png: * fast/events/standalone-im...
-
andersca authored
<rdar://problem/4869095> default content type changed for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget) * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson authored
Updated layouttest results because I added a window property * fast/dom/Window/window-properties-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson authored
Update the hash table header for Window object properties * bindings/js/kjs_window.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson authored
Reviewed by Anders <rdar://problem/5061826> and http://bugs.webkit.org/show_bug.cgi?id=12863 Implement window.stop() * http/tests/misc/window-dot-stop-expected.txt: Added. * http/tests/misc/window-dot-stop.html: Added. WebCore: Reviewed by Anders <rdar://problem/5061826> and http://bugs.webkit.org/show_bug.cgi?id=12863 Implement window.stop() * bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Add case Window::Stop * bindings/js/kjs_window.h: (KJS::Window::): Add "Stop" git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
to a HashCountedSet so that multiple refs and derefs are allowed. Fix RenderImage so that if it has the same image used as a background/border and as the foreground that it will repaint properly (can be tested using border-image and a foreground image). Optimize list marker so that it doesn't waste time in the base class method, since list markers don't support background or border images. Reviewed by andersca * ChangeLog: * loader/CachedResource.cpp: (WebCore::CachedResource::ref): * loader/CachedResource.h: * loader/CachedResourceClientWalker.cpp: (WebCore::CachedResourceClientWalker::CachedResourceClientWalker): * loader/CachedResourceClientWalker.h: * rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): * rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
to a HashCountedSet so that multiple refs and derefs are allowed. Fix RenderImage so that if it has the same image used as a background/border and as the foreground that it will repaint properly (can be tested using border-image and a foreground image). Optimize list marker so that it doesn't waste time in the base class method, since list markers don't support background or border images. Reviewed by andersca * ChangeLog: * loader/CachedResource.cpp: (WebCore::CachedResource::ref): * loader/CachedResource.h: * loader/CachedResourceClientWalker.cpp: (WebCore::CachedResourceClientWalker::CachedResourceClientWalker): * loader/CachedResourceClientWalker.h: * rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): * rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
Fixed <rdar://problem/5065399> REGRESSION: leaks in Frame::bindingRootObject seen on buildbot The problem was that we were initializing the same WebScriptObject twice. This caused it to leak its original set of ivars. I think some refactoring could prevent this situation from arising in the first place, but I'm just adding a check at the call site for now, to do the simplest thing. * bindings/objc/WebScriptObject.mm: (-[WebScriptObject _setImp:originRootObject:rootObject:]): Added ASSERTs against multiple calls. * bindings/objc/WebScriptObjectPrivate.h: Renamed _initializeWithObjectImp to setImp because "init" vs "initialize" was a too subtle indication that one was a Cocoa initializer and one was not. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-