1. 13 Oct, 2013 26 commits
    • mrowe@apple.com's avatar
      Roll deps^H^H^H^HChangeLogs. · 98d05b62
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98d05b62
    • berto@igalia.com's avatar
      Unreviewed GTK gardening. · 83dbb479
      berto@igalia.com authored
      * platform/gtk-wk2/TestExpectations:
      Add bug number to the failing animation tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83dbb479
    • akling@apple.com's avatar
      RenderLayerBacking should have RenderLayer& backpointer. · c68fe759
      akling@apple.com authored
      <https://webkit.org/b/122731>
      
      Reviewed by Anders Carlsson.
      
      RenderLayerBacking is always owned by a RenderLayer and so should
      store its backpointer in a reference.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c68fe759
    • commit-queue@webkit.org's avatar
      Removing input-file-entries.html from TestExpectation · 8db91a8a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122674
      
      Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-13
      Reviewed by Anders Carlsson.
      
      input-file-entries.html has been removed in
      changeset 156692. so removing references to this file.
      
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      * platform/wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8db91a8a
    • andersca@apple.com's avatar
      Try to fix the Lion build. · dbfe1293
      andersca@apple.com authored
      * Configurations/JavaScriptCore.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbfe1293
    • darin@apple.com's avatar
      Make element predicates and type casts work more consistently on more types · 57264685
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122718
      
      Reviewed by Antti Koivisto.
      
      * dom/ContainerNodeAlgorithms.cpp:
      (WebCore::assertConnectedSubrameCountIsConsistent):
      * dom/ContainerNodeAlgorithms.h:
      (WebCore::ChildFrameDisconnector::collectFrameOwners):
      Updated for name change.
      
      * dom/Document.cpp:
      (WebCore::Document::adoptNode): Use a reference instead of a pointer.
      (WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Updated for
      typecast name change and also to cast a reference, since we don't overload
      for pointers.
      (WebCore::Document::updateHoverActiveState): Ditto.
      
      * dom/Element.h: Made the isElementOfType functions take references instead
      of pointers. Also use const in the type template argument. These changes go
      hand in hand with the changes in the generated code and all the classes.
      Also use a bit of nullptr.
      
      * dom/ElementIterator.h:
      (WebCore::findElementAncestorOfType): Got rid of the ElementTypeWithConst
      naming since this works with or without const. Added const to the call site
      for isElementOfType, because it works that way now.
      
      * dom/ElementTraversal.h:
      (WebCore::Traversal::firstChildTemplate): Add const to the type when calling
      isElementOfType. Along with the corresponding changes, this makes these
      templates work for const types.
      (WebCore::Traversal::lastChildTemplate): Ditto.
      (WebCore::Traversal::firstWithinTemplate): Ditto.
      (WebCore::Traversal::lastWithinTemplate): Ditto.
      (WebCore::Traversal::nextTemplate): Ditto.
      (WebCore::Traversal::previousTemplate): Ditto.
      (WebCore::Traversal::nextSiblingTemplate): Ditto.
      (WebCore::Traversal::previousSiblingTemplate): Ditto.
      (WebCore::Traversal::nextSkippingChildrenTemplate): Ditto.
      
      * dom/Node.cpp:
      (WebCore::Node::handleLocalEvents): Check isElementNode and then call the
      isDisabledFormControl member function, since we no longer have a helper that
      takes a node.
      (WebCore::Node::willRespondToMouseMoveEvents): Ditto.
      (WebCore::Node::willRespondToMouseClickEvents): Ditto.
      (WebCore::Node::willRespondToTouchEvents): Ditto.
      
      * dom/PseudoElement.h: Use some nullptr. Added an isPseudoElement function
      that the ELEMENT_TYPE_CASTS macro can use, and also used that macro to make
      the toPseudoElement functions instead of a hand-written local variant.
      
      * dom/make_names.pl:
      (printTypeHelpers): Added unimplemented versions of the element predicate
      functions that return void to catch unnecessary runtime checks of types
      that are already known at compile time. Added assertions to the pointer
      overloads of the predicates. Maybe later we can delete them. Added const
      to the isElementOf template arguments to make these work with both const
      and non-const. Put overloads in a consistent order, most specific class
      first, then less specific. Changed isElementOfType to take references
      rather than pointers.
      
      * editing/Editor.cpp:
      (WebCore::Editor::selectionForCommand): Updated to pass a reference.
      (WebCore::Editor::setBaseWritingDirection): Ditto.
      (WebCore::findFirstMarkable): Ditto.
      
      * html/FormAssociatedElement.h: Tweaked a comment.
      
      * html/HTMLBodyElement.cpp:
      (WebCore::HTMLBodyElement::insertedInto): Updated for name change and to
      pass a reference.
      
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::translate): Removed FIXME and const_cast since the
      problem is fixed.
      (WebCore::HTMLElement::directionality): Use a reference.
      
      * html/HTMLElement.h: Use const in the type of the isElementOfType functions.
      Use references for all the arguments, not pointers.
      
      * html/HTMLFieldSetElement.cpp:
      (WebCore::HTMLFieldSetElement::refreshElementsIfNeeded): Use documentVersion
      instead of docVersion for local variable name. Use elementDescendants instead
      of elementTraversal.
      (WebCore::HTMLFieldSetElement::length): Use length instead of len for name.
      
      * html/HTMLFormControlElement.h: Put predicates into the standard format and
      did them on single lines. Added ELEMENT_TYPE_CASTS so we get standard casts.
      * html/HTMLFrameElementBase.h: Ditto.
      * html/HTMLFrameOwnerElement.h: Ditto, but changed the name to match the class,
      so it's now isHTMLFrameOwnerElement and toHTMLFrameOwnerElement.
      
      * html/HTMLLabelElement.cpp:
      (WebCore::nodeAsSupportedLabelableElement): Updated to use references.
      
      * html/HTMLMediaElement.h: Put predicates into the standard format and did
      them on single lines. Added ELEMENT_TYPE_CASTS so we get standard casts.
      * html/HTMLPlugInElement.h: Ditto. Also marked isPluginElement FINAL.
      * html/HTMLPlugInImageElement.h: Ditto.
      * html/HTMLTableCellElement.cpp: Removed old hand-written cast functions.
      * html/HTMLTableCellElement.h: Did same predicate and ELEMENT_TYPE_CASTS
      changes. Also fixed up the ordering of functions in the class.
      
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::enclosingTextFormControl): Updated to use references and nullptr.
      
      * html/HTMLTextFormControlElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
      
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::removedFrom): Call isHTMLMediaElement by its new name.
      
      * html/LabelableElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
      
      * html/track/WebVTTElement.h: Made isWebVTTElement private. Changed the argument
      type of setLanguage to const AtomicString& to avoid excess reference count churn.
      Did the predicate and type casts thing.
      
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::create): Update for name changes and use references.
      
      * mathml/MathMLElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
      
      * page/FocusController.cpp:
      (WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
      (WebCore::FocusController::advanceFocusInDocumentOrder):
      * page/PageSerializer.cpp:
      (WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
      Update for name change.
      
      * platform/Pasteboard.h: Removed unneeded forward declaration.
      
      * rendering/RenderWidget.h: Updated for name change.
      
      * rendering/svg/RenderSVGResourceFilter.cpp:
      (WebCore::RenderSVGResourceFilter::buildPrimitives): Use element iterator
      and nullptr.
      
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::defaultEventHandler): Update for name changes.
      
      * svg/SVGAnimateElement.cpp:
      (WebCore::isSVGAnimateElement): Moved here since we don't want to inline such
      a long list of tag names.
      
      * svg/SVGAnimateElement.h: Marked a lot more virtual functions OVERRIDE.
      Did predicate and ELEMENT_TYPE_CASTS changes, but did not make the predicate
      be inlined.
      
      * svg/SVGElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
      * svg/SVGFilterPrimitiveStandardAttributes.h: Ditto.
      
      * svg/SVGGradientElement.cpp:
      (WebCore::isSVGGradientElement): Moved here since we don't want to inline
      the two tag names.
      
      * svg/SVGGradientElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
      * svg/SVGGraphicsElement.h: Ditto.
      
      * svg/SVGImageElement.cpp:
      (WebCore::SVGImageElement::SVGImageElement): Took out assertion, since it
      was asserting the class of the obejct we just created.
      
      * svg/SVGPolyElement.cpp:
      (WebCore::isSVGPolyElement): Moved here since we don't want to inline the
      two tag names.
      
      * svg/SVGPolyElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
      * svg/SVGTextContentElement.h: Ditto.
      
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::connectConditions): Update for name changes,
      to use references and nullptr, and to get rid of a non-helpful local.
      
      * svg/animation/SVGSMILElement.h: Added a virtual function to check if a
      given SVGElement is an SVGSMILElement so we don't have to check a long list
      of tag names instead. Also did the predicate and ELEMENT_TYPE_CASTS changes.
      
      * testing/Internals.cpp:
      (WebCore::Internals::visiblePlaceholder): Updated to use references.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57264685
    • andersca@apple.com's avatar
      Change callOnMainThread to take an std::function · c253c446
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122698
      
      Reviewed by Darin Adler.
      
      This will let us pass anything that can be converted to an std::function (including lambdas and
      WTF::Function objects) to callOnMainThread.
      
      * wtf/MainThread.cpp:
      (WTF::callOnMainThread):
      * wtf/MainThread.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c253c446
    • antti@apple.com's avatar
      Text::renderer() should return RenderText · e9c90169
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122729
      
      Reviewed by Andreas Kling.
              
      Tighten typing.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9c90169
    • akling@apple.com's avatar
      Devirtualize RenderView::viewRect(). · eaab3bdb
      akling@apple.com authored
      <https://webkit.org/b/122730>
      
      Reviewed by Antti Koivisto.
      
      There's no need for viewRect() to be a virtual RenderObject function.
      The single call site that didn't already access it through RenderView
      can just go via view().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaab3bdb
    • akling@apple.com's avatar
      Move setPseudoStyle() to RenderImage (from RenderElement.) · 0b5763fb
      akling@apple.com authored
      <https://webkit.org/b/122726>
      
      Reviewed by Antti Koivisto.
      
      Only RenderImages ever use setPseudoStyle() so move it there and
      remove the non-image codepath.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b5763fb
    • akling@apple.com's avatar
      CTTE: RenderSlider always has an HTMLInputElement. · ceef1ea6
      akling@apple.com authored
      <https://webkit.org/b/122728>
      
      Reviewed by Anders Carlsson.
      
      This renderer is never anonymous and always has a corresponding
      HTMLInputElement. Tighten this up by having the constructor take
      the element by reference, and override element() with a stronger
      return type.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ceef1ea6
    • akling@apple.com's avatar
      Remove two unused AX functions for getting a FrameView*. · 932046d6
      akling@apple.com authored
      <https://webkit.org/b/122724>
      
      Reviewed by Anders Carlsson.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      932046d6
    • antti@apple.com's avatar
      Add traverseNextSkippingChildren to ElementIterators · ff79c8e6
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122727
      
      Reviewed by Andreas Kling.
      
      Also switch some code using ElementTraversal over to iterators.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff79c8e6
    • antti@apple.com's avatar
      Rename InlineBox::remove() to removeFromParent · 48e1064c
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122725
      
      Reviewed by Andreas Kling.
      
      Also make it clear from the code that all InlineTextBoxes have behavesLikeText set.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48e1064c
    • antti@apple.com's avatar
      Make absoluteQuads/Rects functions return Vectors · 61c4cde8
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122722
      
      Reviewed by Andreas Kling.
      
      * dom/Document.cpp:
      (WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale):
      (WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale):
                  
          Take RenderStyle instead of RenderObject
      
      * dom/Document.h:
      * dom/Element.cpp:
      (WebCore::Element::getClientRects):
      (WebCore::Element::getBoundingClientRect):
      * dom/Range.cpp:
      (WebCore::Range::textRects):
      (WebCore::Range::textQuads):
      (WebCore::Range::getBorderAndTextQuads):
                  
          Adapt to the changes.
      
      * rendering/RenderObject.h:
              
          Removed unnecessary adjustFloatQuad/RectForAbsoluteZoom functions, inline code to
          adjustFloatQuads/RectForScrollAndAbsoluteZoomAndFrameScale.
      
      * rendering/RenderText.cpp:
      (WebCore::RenderText::absoluteRects):
      (WebCore::RenderText::absoluteRectsForRange):
      (WebCore::RenderText::absoluteQuadsClippedToEllipsis):
      (WebCore::RenderText::absoluteQuads):
      (WebCore::RenderText::absoluteQuadsForRange):
      * rendering/RenderText.h:
      * rendering/RenderTextLineBoxes.cpp:
      (WebCore::RenderTextLineBoxes::absoluteRects):
      (WebCore::RenderTextLineBoxes::absoluteRectsForRange):
      (WebCore::RenderTextLineBoxes::absoluteQuads):
      (WebCore::RenderTextLineBoxes::absoluteQuadsForRange):
      * rendering/RenderTextLineBoxes.h:
              
          Use return value instead of an out-arg, except for the virtual versions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61c4cde8
    • akling@apple.com's avatar
      LiveNodeList: rootNode() and document() should return references. · e2f4c741
      akling@apple.com authored
      <https://webkit.org/b/122720>
      
      Reviewed by Antti Koivisto.
      
      Tighten up this code a bit by having rootNode() and document()
      return references. Also replaced some handwritten traversal
      with a call to Node::lastDescendant().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2f4c741
    • akling@apple.com's avatar
      Document::createRenderTree() should assert that there is no arena. · a02d2a23
      akling@apple.com authored
      <https://webkit.org/b/122723>
      
      Reviewed by Antti Koivisto.
      
      Calling createRenderTree() with a RenderArena already in place would
      be a programming error.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a02d2a23
    • akling@apple.com's avatar
      Remove dead ENABLE(CUSTOM_ELEMENTS) code. · 33675388
      akling@apple.com authored
      <https://webkit.org/b/122721>
      
      Reviewed by Antti Koivisto.
      
      There are no ports building with this flag since April and the code
      has bitrotted since. Remove it for now. If someone wants to resurrect
      the feature someday, getting back to this point is trivial.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33675388
    • antti@apple.com's avatar
      Move absoluteRects/Quads to RenderTextLineBoxes · 48945b19
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122706
      
      Reviewed by Andreas Kling.
      
      * rendering/RenderTextLineBoxes.cpp:
      (WebCore::RenderTextLineBoxes::absoluteRects):
      (WebCore::RenderTextLineBoxes::absoluteRectsForRange):
      (WebCore::RenderTextLineBoxes::absoluteQuads):
      (WebCore::RenderTextLineBoxes::absoluteQuadsForRange):
              
          These move.
      
      (WebCore::RenderTextLineBoxes::selectionRectForRange):
      (WebCore::RenderTextLineBoxes::setSelectionState):
              
          Also moved a few smaller functions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48945b19
    • akling@apple.com's avatar
      Remove dead code hiding behind ENABLE(TOUCH_EVENT_TRACKING). · 73c1aefb
      akling@apple.com authored
      <https://webkit.org/b/122719>
      
      Reviewed by Antti Koivisto.
      
      Nobody is building with this flag, and it has broken-looking code
      behind it anyway. Nuke from orbit.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73c1aefb
    • akling@apple.com's avatar
      RenderLayer: Check SVG bit instead of element namespace in isTransparent(). · 6a1e1086
      akling@apple.com authored
      <https://webkit.org/b/118171>
      
      Reviewed by Darin Adler.
      
      Replace the (virtual) namespaceURI() check with an isSVGElement() bit check.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::isTransparent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a1e1086
    • ap@apple.com's avatar
      Remove Chromium specific code from flakiness dashboard · 7d55a3e7
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122714
      
      Reviewed by Sam Weinig.
      
      Also removed code related to GPU tests and virtual suites.
      "Fallbacks map" was chromium only too, not sure why they needed special handling there.
      
      * TestResultServer/model/jsonresults_unittest.py:
      * TestResultServer/static-dashboards/builders.js:
      * TestResultServer/static-dashboards/dashboard_base.js:
      * TestResultServer/static-dashboards/flakiness_dashboard.html:
      * TestResultServer/static-dashboards/flakiness_dashboard.js:
      * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
      * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
      * TestResultServer/static-dashboards/history.js:
      * TestResultServer/static-dashboards/loader.js:
      * TestResultServer/static-dashboards/ui.js:
      * TestResultServer/templates/uploadform.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d55a3e7
    • darin@apple.com's avatar
      Use nullptr in Document.cpp · cb214332
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122715
      
      Reviewed by Sam Weinig.
      
      * dom/Document.cpp:
      (WebCore::widgetForElement):
      (WebCore::Document::Document):
      (WebCore::Document::~Document):
      (WebCore::Document::dropChildren):
      (WebCore::Document::getElementByAccessKey):
      (WebCore::Document::doctype):
      (WebCore::Document::createElement):
      (WebCore::Document::createElementNS):
      (WebCore::Document::registerElement):
      (WebCore::Document::createCDATASection):
      (WebCore::Document::createProcessingInstruction):
      (WebCore::Document::createEntityReference):
      (WebCore::Document::importNode):
      (WebCore::Document::adoptNode):
      (WebCore::Document::webkitGetNamedFlows):
      (WebCore::Document::elementFromPoint):
      (WebCore::Document::caretRangeFromPoint):
      (WebCore::Document::setTitle):
      (WebCore::Document::removeTitle):
      (WebCore::Document::view):
      (WebCore::Document::page):
      (WebCore::Document::settings):
      (WebCore::Document::createNodeIterator):
      (WebCore::Document::createTreeWalker):
      (WebCore::Document::updateStyleIfNeeded):
      (WebCore::Document::styleForElementIgnoringPendingStylesheets):
      (WebCore::Document::disconnectFromFrame):
      (WebCore::Document::destroyRenderTree):
      (WebCore::Document::existingAXObjectCache):
      (WebCore::Document::axObjectCache):
      (WebCore::Document::scriptableDocumentParser):
      (WebCore::Document::body):
      (WebCore::Document::head):
      (WebCore::Document::processBaseElement):
      (WebCore::Document::findUnsafeParentScrollPropagationBoundary):
      (WebCore::Document::cloneNode):
      (WebCore::Document::styleResolverChanged):
      (WebCore::Document::removeFocusedNodeOfSubtree):
      (WebCore::Document::setFocusedElement):
      (WebCore::Document::getWindowAttributeEventListener):
      (WebCore::Document::createEvent):
      (WebCore::Document::getOverrideStyle):
      (WebCore::Document::ownerElement):
      (WebCore::Document::setInPageCache):
      (WebCore::Document::parentDocument):
      (WebCore::Document::createAttributeNS):
      (WebCore::Document::initSecurityContext):
      (WebCore::Document::resetHiddenFocusElementTimer):
      (WebCore::Document::getCSSCanvasContext):
      (WebCore::Document::enqueuePopstateEvent):
      (WebCore::Document::takeAnyMediaCanStartListener):
      (WebCore::Document::requestFullScreenForElement):
      (WebCore::Document::webkitExitFullscreen):
      (WebCore::Document::webkitWillEnterFullScreenForElement):
      (WebCore::Document::webkitDidExitFullScreenForElement):
      (WebCore::Document::fullScreenRendererDestroyed):
      (WebCore::Document::webkitPointerLockElement):
      (WebCore::Document::seamlessParentIFrame):
      (WebCore::Document::loader):
      (WebCore::eventTargetElementForDocument):
      (WebCore::nearestCommonHoverAncestor):
      (WebCore::Document::ensureTemplateDocument):
      Use nullptr in many places we were using 0.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb214332
    • darin@apple.com's avatar
      Get rid of the toHTMLElement helper for casting FormAssociatedElement to HTMLElement · ad14cd29
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122713
      
      Reviewed by Sam Weinig.
      
      Source/WebCore:
      
      Since we are using the function name toHTMLElement for casting to an HTMLElement
      from a Node or Element, it's awkward to also use it for a quite different type of
      type conversion on a FormAssociatedElement. We already have an asHTMLElement member
      function, so lets use that.
      
      * html/DOMFormData.cpp:
      (WebCore::DOMFormData::DOMFormData): Use references instead of pointers, and
      asHTMLElement instead of toHTMLElement.
      
      * html/FormAssociatedElement.cpp: Made FormAttributeTargetObserver FINAL, made
      its private inheritance explicit, made its constructor public so we can use it
      with make_unique and got rid of its creation function. Also use reference instead
      of a pointer.
      (WebCore::FormAssociatedElement::FormAssociatedElement): Use nullptr.
      (WebCore::FormAssociatedElement::~FormAssociatedElement): Ditto.
      (WebCore::FormAssociatedElement::didMoveToNewDocument): Use asHTMLElement instead
      of toHTMLElement and use a reference instead of a pointer.
      (WebCore::FormAssociatedElement::insertedInto): Ditto.
      (WebCore::FormAssociatedElement::removedFrom): Ditto.
      (WebCore::FormAssociatedElement::formRemovedFromTree): Ditto.
      (WebCore::FormAssociatedElement::resetFormOwner): Ditto.
      (WebCore::FormAssociatedElement::formAttributeChanged): Ditto.
      (WebCore::FormAssociatedElement::customError): Ditto.
      (WebCore::FormAssociatedElement::resetFormAttributeTargetObserver): Use make_unique
      instead of create here.
      (WebCore::FormAssociatedElement::name): Use asHTMLElement.
      (WebCore::FormAttributeTargetObserver::FormAttributeTargetObserver): Ditto.
      (WebCore::FormAttributeTargetObserver::idTargetChanged): Updated since m_element is
      now a reference.
      
      * html/FormAssociatedElement.h: Removed some unneeded class declarations.
      Made isFormAssociatedElement const. Use std::unique_ptr instead of OwnPtr.
      
      * html/FormNamedItem.h: Made asHTMLElement return a reference, and overloaded it
      for both const and non-const. Made isFormAssociatedElement const.
      
      * html/HTMLFormControlElement.h: Updated for FormNamedItem changes. Removed an
      unneeded class declaration.
      
      * html/HTMLFormControlsCollection.cpp:
      (WebCore::HTMLFormControlsCollection::virtualItemAfter): Use references, asHTMLElement,
      and nullptr.
      (WebCore::firstNamedItem): Ditto.
      (WebCore::HTMLFormControlsCollection::namedItem): Ditto.
      (WebCore::HTMLFormControlsCollection::updateNameCache): Ditto.
      
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::validateInteractively): Use asHTMLElement and references.
      (WebCore::HTMLFormElement::getTextFieldValues): Ditto.
      (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Ditto.
      (WebCore::HTMLFormElement::formElementIndex): Ditto.
      (WebCore::HTMLFormElement::assertItemCanBeInPastNamesMap): Ditto.
      (WebCore::HTMLFormElement::elementFromPastNamesMap): Ditto, and nullptr.
      
      * html/HTMLImageElement.h: Updated for FormNamedItem changes.
      * html/HTMLObjectElement.h: Ditto.
      
      * loader/FormSubmission.cpp:
      (WebCore::FormSubmission::create): Use asHTMLElement and references.
      
      Source/WebKit/blackberry:
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::updateFormState): Use asHTMLElement.
      
      Source/WebKit/mac:
      
      * WebView/WebHTMLRepresentation.mm:
      (-[WebHTMLRepresentation elementWithName:inForm:]): Use asHTMLElement.
      (-[WebHTMLRepresentation controlsInForm:]): Ditto.
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::controlsInForm): Use asHTMLElement.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad14cd29
    • darin@apple.com's avatar
      Use nullptr instead of 0 in TreeScope.cpp · 2c54773c
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122711
      
      Reviewed by Andreas Kling.
      
      * dom/TreeScope.cpp:
      (WebCore::TreeScope::TreeScope):
      (WebCore::TreeScope::~TreeScope):
      (WebCore::TreeScope::clearDocumentScope):
      (WebCore::TreeScope::getElementById):
      (WebCore::TreeScope::getAllElementsById):
      (WebCore::TreeScope::getElementByName):
      (WebCore::TreeScope::ancestorInThisScope):
      (WebCore::TreeScope::getImageMap):
      (WebCore::nodeFromPoint):
      (WebCore::TreeScope::labelElementForId):
      (WebCore::TreeScope::getSelection):
      (WebCore::TreeScope::findAnchor):
      (WebCore::focusedFrameOwnerElement):
      (WebCore::TreeScope::focusedElement):
      (WebCore::commonTreeScope):
      Use a lot more nullptr, and also rewrite one while loop as a for loop.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c54773c
    • darin@apple.com's avatar
      Remove the not-much-used isShadowHost function from Element.h · ba0b127c
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122710
      
      Reviewed by Andreas Kling.
      
      * dom/Element.h: Removed isShadowHost, which just checks if shadowRoot is null.
      
      * page/FocusController.cpp:
      (WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost): Added
      individual assertions instead of just asserting isShadowHost.
      (WebCore::FocusNavigationScope::focusNavigationScopeOwnedByIFrame): Broke an
      assertion with && in it into two assertions.
      (WebCore::hasCustomFocusLogic): Changed argument type to be Element& and take
      a reference instead of a pointer.
      (WebCore::isNonFocusableShadowHost): Made arguments references instead of pointers.
      Replaced isShadowHost check with a direct check of whether shadowRoot returns null
      or not, which seems nearly as clear.
      (WebCore::isFocusableShadowHost): Ditto.
      (WebCore::adjustedTabIndex): Ditto.
      (WebCore::shouldVisit): Ditto.
      (WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
      Updated for changes above.
      (WebCore::FocusController::advanceFocusInDocumentOrder): Ditto. Also some nullptr.
      (WebCore::FocusController::findFocusableElementAcrossFocusScope): Ditto.
      (WebCore::FocusController::findFocusableElementRecursively): Ditto.
      (WebCore::FocusController::findElementWithExactTabIndex): Ditto.
      (WebCore::nextElementWithGreaterTabIndex): Ditto.
      (WebCore::previousElementWithLowerTabIndex): Ditto.
      (WebCore::FocusController::nextFocusableElement): Ditto.
      (WebCore::FocusController::previousFocusableElement): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba0b127c
  2. 12 Oct, 2013 14 commits
    • darin@apple.com's avatar
      Move querySelector from Node to ContainerNode and use references instead of pointers · 57dcb165
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122709
      
      Reviewed by Anders Carlsson.
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::querySelector): Moved here from Node. Pass a reference instead
      of a pointer to SelectorQuery. Changed return types to RefPtr and raw pointer instead of
      PassRefPtr.
      (WebCore::ContainerNode::querySelectorAll): Ditto.
      * dom/ContainerNode.h: Added the new functions.
      
      * dom/Element.cpp:
      (WebCore::Element::webkitMatchesSelector): Use && instead of an if statement and a reference rather than
      a pointer.
      
      * dom/Node.cpp: Sorted includes, removed SelectorQuery.h, removed the querySelector functions.
      (WebCore::Node::ownerDocument): Use document instead of doc and nullptr instead of 0.
      * dom/Node.h: Removed the querySelector functions.
      
      * dom/SelectorQuery.cpp:
      (WebCore::SelectorDataList::selectorMatches): Take references instead of pointers.
      (WebCore::SelectorDataList::matches): Ditto.
      (WebCore::SelectorDataList::queryAll): Return a RefPtr instead of PassRefPtr.
      (WebCore::SelectorDataList::queryFirst): Ditto. Also use nullptr.
      (WebCore::selectorForIdLookup): Take references instead of pointers.
      (WebCore::isTreeScopeRoot): Ditto.
      (WebCore::SelectorDataList::executeFastPathForIdSelector): Ditto.
      (WebCore::isSingleTagNameSelector): Ditto.
      (WebCore::elementsForLocalName): Ditto. Also use iterators instead of traversal.
      (WebCore::anyElement): Ditto.
      (WebCore::SelectorDataList::executeSingleTagNameSelectorData): Ditto.
      (WebCore::isSingleClassNameSelector): Ditto.
      (WebCore::SelectorDataList::executeSingleClassNameSelectorData): Ditto.
      (WebCore::SelectorDataList::executeSingleSelectorData): Ditto.
      (WebCore::SelectorDataList::executeSingleMultiSelectorData): Ditto.
      (WebCore::SelectorDataList::execute): Ditto.
      (WebCore::SelectorQueryCache::add): Ditto.
      
      * dom/SelectorQuery.h: Update to use ContainerNode, references, and RefPtr and raw pointers
      rather than PassRefPtr.
      
      * dom/TreeScope.cpp:
      (WebCore::TreeScope::getElementById): Use nullptr instead of 0.
      (WebCore::TreeScope::getAllElementsById): Ditto.
      (WebCore::TreeScope::getElementByName): Ditto.
      (WebCore::TreeScope::ancestorInThisScope): Ditto.
      
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::assertNode): Use nullptr instead of 0.
      (WebCore::InspectorDOMAgent::assertDocument): Ditto.
      (WebCore::InspectorDOMAgent::assertElement): Ditto. Also use isElementNode instead of nodeType.
      (WebCore::InspectorDOMAgent::assertEditableNode): Use nullptr instead of 0.
      (WebCore::InspectorDOMAgent::assertEditableElement): Ditto.
      (WebCore::InspectorDOMAgent::getDocument): Use document instead of doc.
      (WebCore::InspectorDOMAgent::querySelector): Changed to pass a ContainerNode.
      (WebCore::InspectorDOMAgent::querySelectorAll): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57dcb165
    • darin@apple.com's avatar
      Move code to find elements in slider shadow tree into RangeInputType class,... · 95bc682f
      darin@apple.com authored
      Move code to find elements in slider shadow tree into RangeInputType class, since it creates that tree
      https://bugs.webkit.org/show_bug.cgi?id=122708
      
      Reviewed by Anders Carlsson.
      
      * accessibility/AccessibilitySlider.cpp:
      (WebCore::AccessibilitySliderThumb::elementRect): Use HTMLInputElement::sliderThumbElement
      to find the thumb, rather than using the sliderThumbElementOf function.
      
      * html/InputType.h: Use nullptr instead of 0. Tweak formatting a bit.
      
      * html/RangeInputType.cpp:
      (WebCore::RangeInputType::handleMouseDownEvent): Use typedSliderThumbElement function.
      (WebCore::RangeInputType::handleTouchEvent): Ditto.
      (WebCore::RangeInputType::createShadowSubtree): Fixed assertion to match the code below.
      (WebCore::RangeInputType::sliderTrackElement): Moved next to the createShadowSubtree function
      since it is finding an element in that subtree. Changed to do the work here instead of calling
      a function in another file.
      (WebCore::RangeInputType::typedSliderThumbElement): Added. Finds the slider thumb element,
      and returns it as a reference with a specific type.
      (WebCore::RangeInputType::sliderThumbElement): Changed to call typedSliderThumbElement, loosening
      the type, and returning a pointer Changed to call typedSliderThumbElement, loosening
      the type, and returning a pointer.
      (WebCore::RangeInputType::minOrMaxAttributeChanged): Use typedSliderThumbElement.
      (WebCore::RangeInputType::setValue): Ditto.
      (WebCore::RangeInputType::listAttributeTargetChanged): Ditto.
      
      * html/RangeInputType.h: Marked the class FINAL. Tweaked formatting a bit.
      Added the typedSliderThumbElement function.
      
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::setPositionFromPoint): Call the HTMLInputElement::sliderTrackElement
      function instead of having the input element's shadow subtree hierarchy hard-coded here.
      (WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Moved here from the header,
      since it's a virtual function that won't be inlined.
      
      * html/shadow/SliderThumbElement.h: Removed unneeded forward declarations. Made more virtual
      functions private and added more OVERRIDE. Removed the toSliderThumbElement, sliderThumbElementOf,
      and sliderTrackElementOf functions.
      
      * rendering/RenderSlider.cpp:
      (WebCore::RenderSlider::layout): Use HTMLInputElement::sliderThumbElement.
      (WebCore::RenderSlider::inDragMode): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95bc682f
    • darin@apple.com's avatar
      Remove unneeded extra memory allocation and indirection for ValidityState · b8bc197f
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122705
      
      Reviewed by Anders Carlsson.
      
      * CMakeLists.txt: Removed ValidityState.cpp.
      * GNUmakefile.list.am: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      
      * html/FormAssociatedElement.cpp: Removed ValidityState.h include and the
      FormAssociatedElement::validity function. That function is now an inline
      in the ValidityState.h header.
      
      * html/FormAssociatedElement.h: Added badInput function, the only function
      from the ValidityState interface that was not already present here. Removed
      m_validityState.
      
      * html/HTMLFormControlElement.cpp: Removed include of ValidityState.h.
      (WebCore::HTMLFormControlElement::isValidFormControlElement): Use the valid
      function directly instead of indirectly through the validity state.
      (WebCore::HTMLFormControlElement::setNeedsValidityCheck): Ditto.
      
      * html/ValidityState.cpp: Removed.
      
      * html/ValidityState.h: Removed the body of the ValidityState class and
      made it effectively a "typedef" for FormAssociatedElement. It's actually
      a derived class that adds no members, which is not quite right but will
      work just fine for this.
      (WebCore::FormAssociatedElement::validity): Implemented; just returns the
      FormAssociatedElement, which the bindings expose as a ValidityState.
      
      * html/ValidityState.idl: Use SkipVTableValidation instead of
      ImplementationLacksVTable because FormAssociatedElement does have a vtable.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8bc197f
    • aroben@webkit.org's avatar
      WebViews inside OS X screen savers have large caches, but should not · 1d298a0d
      aroben@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122604
      
      We use WebCacheModelDocumentViewer by default for apps linked against
      modern WebKit, and WebCacheModelDocumentBrowser for apps linked
      against legacy WebKit. ScreenSaverEngine.app doesn't link against
      WebKit at all, and thus falls into the legacy case by accident because
      NSVersionOfLinkTimeLibrary("WebKit") returns -1.
      
      But WebViews inside screen savers are almost certainly not being used
      as browsers, so this large-ish cache specified by
      WebCacheModelDocumentBrowser is wasteful. This is likely true for all
      apps that don't directly link against WebKit, so now we use
      WebCacheModelDocumentViewer by default for those apps.
      
      Reviewed by Darin Adler.
      
      * WebView/WebPreferences.mm:
      (cacheModelForMainBundle): Use WebCacheModelDocumentViewer by default
      for apps that don't link against WebKit directly. Also converted to
      use @autoreleasepool {} and early returns while I was in here.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d298a0d
    • darin@apple.com's avatar
      Rename toParentMediaElement to parentMediaElement, since it's not a type cast · 635cf32b
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122707
      
      Reviewed by Eric Carlson.
      
      * accessibility/AccessibilityMediaControls.cpp:
      (WebCore::AccessibilityMediaControlsContainer::controllingVideoElement): Call the
      function by its new name, and also remove unnecessary type casting.
      
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::parentMediaElement): Renamed from toParentMediaElement. Changed to use
      nullptr. Removed an unnecessary null check.
      
      * html/shadow/MediaControlElementTypes.h: Renamed from toParentMediaElement.
      Changed the argument to the RenderObject overload to be a reference rather than
      a pointer since it doesn't handle null.
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler):
      (WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):
      (WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
      (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
      (WebCore::MediaControlTextTrackContainerElement::updateDisplay):
      (WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
      (WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation):
      (WebCore::MediaControlTextTrackContainerElement::updateSizes):
      (WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
      Updated to use the new name. Also use nullptr.
      
      * html/shadow/MediaControlsBlackBerry.cpp:
      (WebCore::MediaControlFullscreenFullscreenButtonElement::defaultEventHandler):
      Updated to use the new name.
      
      * platform/blackberry/RenderThemeBlackBerry.cpp:
      (WebCore::determineFullScreenMultiplier):
      (WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
      (WebCore::RenderThemeBlackBerry::paintMediaPlayButton):
      (WebCore::RenderThemeBlackBerry::paintMediaRewindButton):
      (WebCore::RenderThemeBlackBerry::paintMediaMuteButton):
      (WebCore::RenderThemeBlackBerry::paintMediaFullscreenButton):
      (WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
      (WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
      Updated to use the new name.
      
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintMediaSliderTrack):
      Updated to use the new name.
      
      * platform/gtk/RenderThemeGtk.cpp:
      (WebCore::RenderThemeGtk::paintMediaSliderTrack):
      (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):
      Updated to use the new name.
      
      * rendering/RenderMediaControls.cpp:
      (WebCore::RenderMediaControls::paintMediaControlsPart):
      Call the function by its new name and with a reference instead of a pointer.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      635cf32b
    • antti@apple.com's avatar
      Move positionForPoint to RenderTextLineBoxes · 419a1fdb
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122703
      
      Reviewed by Andreas Kling.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      419a1fdb
    • akling@apple.com's avatar
      Remove unused ScrollingCoordinator hooks. · e51bc86f
      akling@apple.com authored
      <https://webkit.org/b/122701>
      
      Reviewed by Anders Carlsson.
      
      Remove leftover ScrollingCoordinator hooks that were only used
      by the Chromium port.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e51bc86f
    • zandobersek@gmail.com's avatar
      [Soup] The NeverDestroyed<std::unique_ptr<NetworkStorageSession>> variable in... · 13d4deed
      zandobersek@gmail.com authored
      [Soup] The NeverDestroyed<std::unique_ptr<NetworkStorageSession>> variable in defaultSession() should be static
      https://bugs.webkit.org/show_bug.cgi?id=122700
      
      Reviewed by Anders Carlsson.
      
      * platform/network/soup/NetworkStorageSessionSoup.cpp:
      (WebCore::defaultSession): The NeverDestroyed variable should be static to avoid its reinitialization every time
      the function is called. This was exposed by r157337 and should fix the subsequent crashes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13d4deed
    • antti@apple.com's avatar
      Move line dirtying code to RenderTextLineBoxes · 2d7354d6
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122699
      
      Reviewed by Andreas Kling.
      
      * rendering/RenderTextLineBoxes.cpp:
      (WebCore::RenderTextLineBoxes::removeAllFromParent):
              
          Also moved the removal loop.
      
      (WebCore::RenderTextLineBoxes::dirtyAll):
      (WebCore::RenderTextLineBoxes::dirtyRange):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d7354d6
    • antti@apple.com's avatar
      Move more code to RenderTextLineBoxes · 8a0fab37
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122697
      
      Reviewed by Andreas Kling.
      
      * rendering/RenderTextLineBoxes.cpp:
      (WebCore::RenderTextLineBoxes::boundingBox):
      (WebCore::RenderTextLineBoxes::visualOverflowBoundingBox):
      (WebCore::RenderTextLineBoxes::hasRenderedText):
      (WebCore::RenderTextLineBoxes::caretMinOffset):
      (WebCore::RenderTextLineBoxes::caretMaxOffset):
              
          Moved these.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a0fab37
    • ap@apple.com's avatar
      Add a feature define for SubtleCrypto · 7ff3fdfb
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122683
      
      Reviewed by Anders Carlsson.
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ff3fdfb
    • akling@apple.com's avatar
      Generate tighter isFooElement() functions for HTML elements. · 574242e1
      akling@apple.com authored
      <https://webkit.org/b/122696>
      
      Reviewed by Antti Koivisto.
      
      Specialize HTML element type checking helpers to only compare the
      localName and not the fully qualified tag name.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      574242e1
    • akling@apple.com's avatar
      Replace static cast ASSERTs with ASSERT_WITH_SECURITY_IMPLICATION · 670fea1d
      akling@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120803
      
      Patch by Jessica Pease <jessica_n_pease@apple.com> on 2013-09-27
      Reviewed by Andreas Kling.
      
      No new tests because we're just changing assertions.
      
      Source/WebCore:
      
      * accessibility/AccessibilityMockObject.h:
      (WebCore::toAccessibilityMockObject):
      * bindings/js/JSCanvasRenderingContextCustom.cpp:
      (WebCore::toJS):
      * bindings/js/ScheduledAction.cpp:
      (WebCore::ScheduledAction::execute):
      * css/CSSGradientValue.cpp:
      (WebCore::CSSGradientValue::image):
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
      * dom/Element.cpp:
      (WebCore::Element::elementRareData):
      (WebCore::Element::synchronizeAttribute):
      * dom/FocusEvent.h:
      (WebCore::toFocusEvent):
      * dom/MouseEvent.h:
      (WebCore::toMouseEvent):
      * dom/Node.cpp:
      (WebCore::Node::rareData):
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::ensureMutableInlineStyle):
      * dom/TouchEvent.h:
      (WebCore::toTouchEvent):
      * editing/CompositeEditCommand.h:
      (WebCore::toCompositeEditCommand):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):
      * html/track/AudioTrack.h:
      (WebCore::toAudioTrack):
      * html/track/TextTrack.h:
      (WebCore::toTextTrack):
      * html/track/VideoTrack.h:
      (WebCore::toVideoTrack):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
      * loader/cache/CachedResourceClientWalker.h:
      (WebCore::CachedResourceClientWalker::next):
      * page/FrameView.h:
      (WebCore::toFrameView):
      * rendering/InlineBox.cpp:
      (WebCore::InlineBox::root):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::createLineBoxesFromBidiRuns):
      * rendering/svg/SVGPathData.cpp:
      (WebCore::updatePathFromEllipseElement):
      (WebCore::updatePathFromLineElement):
      (WebCore::updatePathFromPolygonElement):
      (WebCore::updatePathFromPolylineElement):
      * workers/WorkerMessagingProxy.cpp:
      (WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::document):
      
      Source/WebKit2:
      
      * Shared/Plugins/NPObjectProxy.h:
      (WebKit::NPObjectProxy::toNPObjectProxy):
      * WebProcess/Plugins/Netscape/NPJSObject.h:
      (WebKit::NPJSObject::toNPJSObject):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      670fea1d
    • akling@apple.com's avatar
      Replace bounds checking ASSERTs with ASSERT_WITH_SECURITY_IMPLICATION · 2207aeb7
      akling@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120893
      
      Patch by Jessica Pease <jessica_n_pease@apple.com> on 2013-09-06
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      * Modules/indexeddb/IDBKeyPath.cpp:
      (WebCore::IDBKeyPathLexer::lex):
      * Modules/indexeddb/IDBLevelDBCoding.cpp:
      (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      (WebCore::cssPropertyIDForJSCSSPropertyName):
      * css/CSSFontSelector.cpp:
      (WebCore::compareFontFaces):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::rewriteSpecifiers):
      * html/HTMLCollection.cpp:
      (WebCore::traverseMatchingElementsForwardToOffset):
      (WebCore::LiveNodeListBase::traverseChildNodeListForwardToOffset):
      (WebCore::HTMLCollection::traverseForwardToOffset):
      * html/HTMLFontElement.cpp:
      (WebCore::parseFontSize):
      * html/parser/HTMLParserIdioms.cpp:
      (WebCore::parseHTMLIntegerInternal):
      (WebCore::parseHTMLNonNegativeIntegerInternal):
      * inspector/InspectorStyleSheet.h:
      (WebCore::InspectorStyleProperty::setRawTextFromStyleDeclaration):
      * platform/graphics/StringTruncator.cpp:
      (WebCore::centerTruncateToBuffer):
      (WebCore::rightTruncateToBuffer):
      (WebCore::truncateString):
      * platform/graphics/TextRun.h:
      (WebCore::TextRun::subRun):
      * platform/text/BidiRunList.h:
      (WebCore::::reverseRuns):
      * rendering/svg/SVGInlineTextBox.cpp:
      (WebCore::SVGInlineTextBox::selectionRectForTextFragment):
      (WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
      * rendering/svg/SVGTextChunkBuilder.cpp:
      (WebCore::SVGTextChunkBuilder::buildTextChunks):
      * rendering/svg/SVGTextLayoutEngine.cpp:
      (WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):
      * rendering/svg/SVGTextQuery.cpp:
      (WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
      * svg/SVGAnimationElement.cpp:
      (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
      * svg/SVGPathByteStreamSource.h:
      (WebCore::SVGPathByteStreamSource::readType):
      
      Source/WebKit2:
      
      * Shared/Plugins/PluginQuirks.h:
      (WebKit::PluginQuirks::add):
      
      Source/WTF:
      
      * wtf/BumpPointerAllocator.h:
      (WTF::BumpPointerPool::ensureCapacity):
      (WTF::BumpPointerPool::alloc):
      (WTF::BumpPointerPool::ensureCapacityCrossPool):
      * wtf/FastMalloc.cpp:
      (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
      * wtf/StringPrintStream.cpp:
      (WTF::StringPrintStream::increaseSize):
      * wtf/dtoa/utils.h:
      (WTF::double_conversion::BufferReference::SubBufferReference):
      * wtf/text/WTFString.cpp:
      (WTF::String::fromUTF8):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2207aeb7