1. 03 Oct, 2012 2 commits
    • commit-queue@webkit.org's avatar
      WebImage::framesFromData should skip corrupted frames · 98c74958
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98214
      
      Patch by Peter Kotwicz <pkotwicz@google.com> on 2012-10-03
      Reviewed by Adam Barth.
      
      WebImage::framesFromData() should only return bitmaps for valid frames
      of a .ico file.
      
      * src/WebImageSkia.cpp:
      (WebKit::WebImage::framesFromData):
      * tests/WebImageTest.cpp:
      (WebKit::TEST):
      (WebKit):
      * tests/data/valid_header_missing_bitmap.ico: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98c74958
    • yurys@chromium.org's avatar
      Provide memory instrumentation for HashCountedSet · 4d3e1731
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98138
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Replaced addHashCountedSet calls with addMember that now automatically
      detects HashCountedSet and calls appropriate routine.
      
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
      * loader/cache/CachedResource.cpp:
      
      Source/WebKit/chromium:
      
      Added unit test for HashCountedSet memory instrumentation.
      
      * tests/MemoryInstrumentationTest.cpp:
      
      Source/WTF:
      
      Added memory instrumentation for HashCountedSet.
      
      Extracted common routines for collecting memory info for an iterable sequence.
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/MemoryInstrumentation.h:
      (WTF):
      * wtf/MemoryInstrumentationHashCountedSet.h: Copied from Source/WTF/wtf/MemoryInstrumentationHashSet.h.
      (WTF):
      (WTF::reportMemoryUsage):
      * wtf/MemoryInstrumentationHashMap.h:
      (WTF::reportMemoryUsage):
      * wtf/MemoryInstrumentationHashSet.h:
      * wtf/MemoryInstrumentationSequence.h: Copied from Source/WTF/wtf/MemoryInstrumentationHashMap.h.
      (WTF):
      (WTF::SequenceMemoryInstrumentationTraits::reportMemoryUsage):
      (WTF::reportSequenceMemoryUsage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d3e1731
  2. 02 Oct, 2012 10 commits
    • tkent@chromium.org's avatar
      [Chromium-Win] Implement LocaleWin::dateFormat · c934c4b0
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98117
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      http://trac.webkit.org/changeset/130127 introduced
      Localizer::dateFormat, and this is its implementation for LocaleICU
      classs. The code is going to be used when
      ENABLE_INPUT_MULTIPLE_FIELDS_UI is enabled.
      
      Tests: Added a new test to WebKit/chromium/tests/LocaleWinTest.cpp.
      
      * platform/text/LocaleWin.cpp:
      (WebCore::parseDateFormat):
      Fix a continuous apostrophes parsing bug; "abc''''def" produced "abc'''def"
      (WebCore::appendAsLDMLLiteral):
      A helper function to make a literal string for LDML.
      (WebCore::convertWindowsDateFormatToLDML):
      Creates an LDML format from a parsed date format tokens.
      (WebCore::LocaleWin::dateFormat):
      Implemented. This uses convertWindowsDateFormatToLDML.
      (WebCore::LocaleWin::dateFormat):
      Added for testing. The source windows format is specified as a function
      argument.
      * platform/text/LocaleWin.h:
      (LocaleWin): Declare m_dateFormat and dateFormat().
      
      Source/WebKit/chromium:
      
      * tests/LocaleWinTest.cpp:
      (TEST_F): Add tests for LocaleWin::dateFormat.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c934c4b0
    • simon.fraser@apple.com's avatar
      Source/JavaScriptCore: == Rolled over to ChangeLog-2012-10-02 == · eec26cbc
      simon.fraser@apple.com authored
      Source/WebCore: == Rolled over to ChangeLog-2012-10-02 ==
      
      Source/WebKit/chromium: == Rolled over to ChangeLog-2012-10-02 ==
      
      Source/WebKit/mac: == Rolled over to ChangeLog-2012-10-02 ==
      
      Source/WebKit2: == Rolled over to ChangeLog-2012-10-02 ==
      
      Tools: == Rolled over to ChangeLog-2012-10-02 ==
      
      LayoutTests: == Rolled over to ChangeLog-2012-10-02 ==
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eec26cbc
    • commit-queue@webkit.org's avatar
      [chromium] Make sure the touch-points in the touch-events have the correct state. · a9ce63e5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98110
      
      Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-02
      Reviewed by Adam Barth.
      
      Source/WebKit/chromium:
      
      It is necessary for the WebTouchPoints in the reconstructed WebTouchEvent
      to have the correct state. Without this change, the states were always
      unknown.
      
      * src/WebInputEventConversion.cpp:
      (WebKit::toWebTouchPointState):
      (WebKit):
      (WebKit::addTouchPoints):
      (WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
      
      Tools:
      
      TestWebPlugin can now be configured to print out some details about
      events. For now, details for only touch events are printed. This is
      used to verify that touch-points in the touch-events are properly
      set.
      
      * DumpRenderTree/chromium/TestWebPlugin.cpp:
      (pointState):
      (printTouchList):
      (printEventDetails):
      (TestWebPlugin::TestWebPlugin):
      (TestWebPlugin::handleInputEvent):
      * DumpRenderTree/chromium/TestWebPlugin.h:
      (TestWebPlugin):
      
      LayoutTests:
      
      * platform/chromium/plugins/touch-events-details-expected.txt: Added.
      * platform/chromium/plugins/touch-events-details.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9ce63e5
    • commit-queue@webkit.org's avatar
      WebDocument doesn't export document language to outside users. · b166c95b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98066
      
      Patch by Brian White <bcwhite@chromium.org> on 2012-10-02
      Reviewed by Adam Barth.
      
      Chromium uses the document language to offer translation.  It's been doing
      its own detection of this property but it would be better to get it from
      existing extraction code.
      
      * public/WebDocument.h:
      (WebDocument):
      * src/WebDocument.cpp:
      (WebKit::WebDocument::contentLanguage):
      (WebKit):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b166c95b
    • vangelis@chromium.org's avatar
      Remove call to FinishAllRendering when in force-compositing-mode. · 85b6f2c7
      vangelis@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98111
      
      It's not needed and makes the renderer synchronously wait for a glFinish
      to happen in the gpu process.
      
      Reviewed by James Robinson.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      (WebKit):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85b6f2c7
    • loislo@chromium.org's avatar
      Web Inspector: NMI make String* instrumentation non intrusive · 506e5c28
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97964
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      MemoryInstrumentationString.h include was added.
      
      * dom/WebCoreMemoryInstrumentation.h:
      
      Source/WebKit/chromium:
      
      The expectations were fixed because old instrumentation had wrong detector for BufferInternal type of storage.
      
      * tests/MemoryInstrumentationTest.cpp:
      (WebCore::TEST):
      
      Source/WTF:
      
      MemoryInstrumentationString.h was added.
      Intrusive instrumentation was removed.
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/MemoryInstrumentation.h:
      (WTF):
      * wtf/MemoryInstrumentationString.h: Added.
      (WTF):
      (WTF::reportMemoryUsage):
      * wtf/text/AtomicString.cpp:
      (WTF):
      * wtf/text/AtomicString.h:
      (AtomicString):
      * wtf/text/CString.h:
      (WTF::CStringBuffer::length):
      * wtf/text/StringImpl.cpp:
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::usesInternalBuffer):
      (WTF::StringImpl::baseString):
      (StringImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      506e5c28
    • jochen@chromium.org's avatar
      Use correct gtest macros for tests for true/false · 567642f4
      jochen@chromium.org authored
      Unreviewed build-fix.
      
      Using EXPECT_EQ(true, ...) makes clang trip when it tries to convert
      true to a pointer. Tests should use EXPECT_TRUE instead.
      
      * tests/WebFrameTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      567642f4
    • caseq@chromium.org's avatar
      Unreviewed, rolling out r130129. · f7d05cdc
      caseq@chromium.org authored
      http://trac.webkit.org/changeset/130129
      https://bugs.webkit.org/show_bug.cgi?id=98125
      
      broke 4 webkit_unit_tests
      (MemoryInstrumentationTest.hashMapWith*) (Requested by caseq
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-02
      
      Source/WebCore:
      
      * dom/WebCoreMemoryInstrumentation.h:
      * platform/KURL.cpp:
      * platform/KURLGoogle.cpp:
      * platform/PlatformMemoryInstrumentation.h:
      
      Source/WebKit/chromium:
      
      * tests/MemoryInstrumentationTest.cpp:
      
      Source/WTF:
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/MemoryInstrumentation.h:
      (WTF):
      * wtf/MemoryInstrumentationString.h: Removed.
      * wtf/text/AtomicString.cpp:
      (WTF::AtomicString::reportMemoryUsage):
      (WTF):
      * wtf/text/AtomicString.h:
      (AtomicString):
      * wtf/text/CString.h:
      (WTF::CStringBuffer::length):
      (CStringBuffer):
      (WTF::CStringBuffer::reportMemoryUsage):
      (CString):
      (WTF::CString::reportMemoryUsage):
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::reportMemoryUsage):
      (WTF):
      * wtf/text/StringImpl.h:
      (StringImpl):
      * wtf/text/WTFString.cpp:
      (WTF::String::reportMemoryUsage):
      (WTF):
      * wtf/text/WTFString.h:
      (String):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7d05cdc
    • loislo@chromium.org's avatar
      Web Inspector: NMI make String* instrumentation non intrusive · 888dff0b
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97964
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      MemoryInstrumentationString.h include was added.
      
      * dom/WebCoreMemoryInstrumentation.h:
      
      Source/WebKit/chromium:
      
      The expectations were fixed because old instrumentation had wrong detector for BufferInternal type of storage.
      
      * tests/MemoryInstrumentationTest.cpp:
      (WebCore::TEST):
      
      Source/WTF:
      
      MemoryInstrumentationString.h was added.
      Intrusive instrumentation was removed.
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/MemoryInstrumentation.h:
      (WTF):
      * wtf/MemoryInstrumentationString.h: Added.
      (WTF):
      (WTF::reportMemoryUsage):
      * wtf/text/AtomicString.cpp:
      (WTF):
      * wtf/text/AtomicString.h:
      (AtomicString):
      * wtf/text/CString.h:
      (WTF::CStringBuffer::length):
      * wtf/text/StringImpl.cpp:
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::usesInternalBuffer):
      (WTF::StringImpl::baseString):
      (StringImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      888dff0b
    • yosin@chromium.org's avatar
      REGRESSION(r130116): Need to update DateTimeFormatTest · 10031bf2
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98120
      
      Reviewed by Kent Tamura.
      
      This patch updates test cases for week of month and week of year type
      specifiers in DateTimeFormat class. This tests should be updated
      within r130116.
      
      * tests/DateTimeFormatTest.cpp:
      (TEST_F): Changed test cases for changes of enum field value changes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10031bf2
  3. 01 Oct, 2012 5 commits
    • keishi@webkit.org's avatar
      Calendar picker should use zero as default step base · 2fb5b7de
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97976
      
      Reviewed by Kent Tamura.
      
      .:
      
      * ManualTests/forms/calendar-picker.html: Added stepBase parameters.
      
      Source/WebCore:
      
      Calendar picker should be using zero as default step base for input type=date.
      The spec says to use zero unless specified otherwise.
      Since input type=week has another default step base, I am adding step base
      to DateTimeChooserParameters.
      
      Test: fast/forms/date/calendar-picker-with-step.html
      
      * Resources/pagepopups/calendarPicker.js:
      (handleArgumentsTimeout):
      (CalendarPicker):
      (CalendarPicker.prototype.stepMismatch): Use the new this.stepBase.
      * html/shadow/PickerIndicatorElement.cpp:
      (WebCore::PickerIndicatorElement::openPopup): Gets step base from step range.
      * platform/DateTimeChooser.h:
      (DateTimeChooserParameters): Added stepBase.
      
      Source/WebKit/chromium:
      
      * src/DateTimeChooserImpl.cpp:
      (WebKit::DateTimeChooserImpl::writeDocument): stepBase needs 11 digits of precision when setting maximum possible date.
      
      LayoutTests:
      
      * fast/forms/date/calendar-picker-with-step-expected.txt: Renamed from LayoutTests/fast/forms/date/calendar-picker-appearance-with-step-expected.txt.
      * fast/forms/date/calendar-picker-with-step.html: Renamed from LayoutTests/fast/forms/date/calendar-picker-appearance-with-step.html. Renamed because this does not test apeparance.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fb5b7de
    • jsbell@chromium.org's avatar
      Source/WebCore: IndexedDB: Fire error rather than raising on request creation... · 27455051
      jsbell@chromium.org authored
      Source/WebCore: IndexedDB: Fire error rather than raising on request creation if transaction aborts asynchronously.
      https://bugs.webkit.org/show_bug.cgi?id=93054
      
      Reviewed by Tony Chang.
      
      All IDB data operations are asynchronous, producing IDBRequest objects. This was implemented
      by passing all data from the front-end to the back-end synchronously, and synchronously
      returning an exception code back if the request was invalid. Previous changes have moved
      request validation to the front-end except for the case of the back-end transaction having
      asynchronously aborted in the mean time.
      
      To eliminate that case (which would allow front-end to back-end communication to be
      asynchronous in multi-process ports), change from returning an exception code to relying on
      the front-end to abort the request when the abort event finally arrives.
      
      The difference would be noticeable in scripts - in a multi-process environment:
      
      var request1 = store.get(0);
      request1.onerror = errorHandler; // (A)
      // (B)
      var request2 = store.get(0); // (C)
      request2.onerror = errorHandler; // (D)
      
      If the transaction back-end were to asynchronously abort at exactly point (B), then prior to
      this patch an exception would be thrown at (C). With this patch, no exception but (D) would
      fire, same as (A).
      
      The back-end explicitly fires an error callback as well, as intermediate layers may rely on
      this to stop tracking the pending callback.
      
      No new layout tests - change is not observable in single-process ports.
      Added webkit_unit_test IDBRequestTest.AbortErrorAfterAbort to verify that IDBRequest
      is resilient to this pattern, but it was previous.
      
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::advance): Back end should never fail a request.
      (WebCore::IDBCursor::continueFunction): Ditto.
      (WebCore::IDBCursor::deleteFunction): Ditto, and also move "is key cursor" test
      here from back-end.
      * Modules/indexeddb/IDBCursorBackendImpl.cpp:
      (WebCore::IDBCursorBackendImpl::continueFunction): Change from EC to firing error.
      (WebCore::IDBCursorBackendImpl::advance): Ditto.
      (WebCore::IDBCursorBackendImpl::deleteFunction): Ditto, and remove test moved to FE.
      (WebCore::IDBCursorBackendImpl::prefetchContinue): Ditto.
      * Modules/indexeddb/IDBDatabaseError.cpp:
      (WebCore::IDBDatabaseError::create): Add overload that looks up message via code.
      (WebCore::IDBDatabaseError::IDBDatabaseError): Look up message via exception table.
      * Modules/indexeddb/IDBDatabaseException.h: Add getErrorDescription.
      * Modules/indexeddb/IDBDatabaseException.cpp: Implementation of getErrorDescription.
      * Modules/indexeddb/IDBIndex.cpp:
      (WebCore::IDBIndex::openCursor): Back end should never fail a request.
      (WebCore::IDBIndex::count): Ditto.
      (WebCore::IDBIndex::openKeyCursor): Ditto.
      (WebCore::IDBIndex::get): Ditto.
      (WebCore::IDBIndex::getKey): Ditto.
      * Modules/indexeddb/IDBIndexBackendImpl.cpp:
      (WebCore::IDBIndexBackendImpl::openCursor): Change from EC to firing error.
      (WebCore::IDBIndexBackendImpl::openKeyCursor): Ditto.
      (WebCore::IDBIndexBackendImpl::count): Ditto.
      (WebCore::IDBIndexBackendImpl::get): Ditto.
      (WebCore::IDBIndexBackendImpl::getKey): Ditto.
      * Modules/indexeddb/IDBObjectStore.cpp:
      (WebCore::IDBObjectStore::get): Back end should never fail a request.
      (WebCore::IDBObjectStore::put): Ditto.
      (WebCore::IDBObjectStore::deleteFunction): Ditto.
      (WebCore::IDBObjectStore::clear): Ditto.
      (WebCore): Ditto.
      (WebCore::IDBObjectStore::openCursor): Ditto.
      (WebCore::IDBObjectStore::count): Ditto.
      * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
      (WebCore::IDBObjectStoreBackendImpl::get): Change from EC to firing error.
      (WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys): Ditto.
      (WebCore):
      (WebCore::IDBObjectStoreBackendImpl::deleteFunction): Ditto.
      (WebCore::IDBObjectStoreBackendImpl::clear): Ditto.
      (WebCore::IDBObjectStoreBackendImpl::openCursor): Ditto.
      (WebCore::IDBObjectStoreBackendImpl::count): Ditto.
      
      Source/WebKit/chromium: IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
      https://bugs.webkit.org/show_bug.cgi?id=94757
      
      Reviewed by Tony Chang.
      
      * tests/IDBRequestTest.cpp: Ensure IDBRequest can handle Error after abort.
      (WebCore::TEST): Added AbortAfter
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27455051
    • loislo@chromium.org's avatar
      Unreviewed single line compilation fix for Canary Debug Mac. · 38203d07
      loislo@chromium.org authored
      * tests/MemoryInstrumentationTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38203d07
    • yurys@chromium.org's avatar
      Web Inspector: provide memory instrumentation for HashMap · 9c990164
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98005
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Updated all call sites of MemoryInstrumentation::addHashMap to use generic
      method of reporting memory footprint instead.
      
      * bindings/v8/ScopedDOMDataStore.cpp:
      * bindings/v8/V8Binding.cpp:
      (WebCore::StringCache::reportMemoryUsage):
      * bindings/v8/V8DOMMap.h:
      * bindings/v8/V8PerIsolateData.cpp:
      (WebCore::V8PerIsolateData::reportMemoryUsage):
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
      * css/PropertySetCSSStyleDeclaration.cpp:
      (WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * css/StyleSheetContents.cpp:
      (WebCore::StyleSheetContents::reportMemoryUsage):
      * dom/Document.cpp:
      (WebCore::Document::reportMemoryUsage):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::reportMemoryUsage):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::reportMemoryUsage):
      * loader/cache/MemoryCache.cpp:
      (WebCore::MemoryCache::reportMemoryUsage):
      * platform/network/ResourceRequestBase.cpp:
      (WebCore::ResourceRequestBase::reportMemoryUsage):
      * platform/network/ResourceResponseBase.cpp:
      (WebCore::ResourceResponseBase::reportMemoryUsage):
      * rendering/style/StyleRareNonInheritedData.cpp:
      
      Source/WebKit/chromium:
      
      Added unit tests for HashMap memory instrumentation.
      
      * tests/MemoryInstrumentationTest.cpp:
      (WTF):
      
      Source/WTF:
      
      Extracted HashMap memory instrumentation into its own file. The map's content
      elements will be automatically traversed if their types are supported
      by the memory instrumentation. No need to call special method for hash map
      fields any more.
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * wtf/MemoryInstrumentation.h:
      (MemoryInstrumentation):
      (WTF):
      * wtf/MemoryInstrumentationHashMap.h: Added.
      (WTF):
      (WTF::SequenceMemoryInstrumentationTraits::reportMemoryUsage):
      (WTF::reportMemoryUsage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c990164
    • apavlov@chromium.org's avatar
      Web Inspector: [Device Metrics] Remove the gutter overlay moving its... · aa967739
      apavlov@chromium.org authored
      Web Inspector: [Device Metrics] Remove the gutter overlay moving its functionality into the InspectorOverlay
      https://bugs.webkit.org/show_bug.cgi?id=97799
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Re-applying r129746 with test flakiness fixed.
      
      In order to reduce the amount of port-specific code, the gutter overlay painted in the device metrics emulation mode
      has been replaced by the respective functionality in the HTML-based InspectorOverlay in WebCore. The InspectorOverlay
      now covers the entire WebView rather than the FrameView only.
      
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::webViewResized):
      (WebCore):
      * inspector/InspectorController.h:
      (WebCore):
      (InspectorController):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::InspectorOverlay):
      (WebCore::InspectorOverlay::paint):
      (WebCore::InspectorOverlay::resize):
      (WebCore):
      (WebCore::InspectorOverlay::update):
      (WebCore::InspectorOverlay::drawGutter):
      (WebCore::InspectorOverlay::reset):
      * inspector/InspectorOverlay.h:
      (InspectorOverlay):
      * inspector/InspectorOverlayPage.html: Introduce the gutter painting functionality previously found in the Chromium's
      DeviceMetricsSupport class, which used to implement WebPageOverlay.
      
      Source/WebKit/chromium:
      
      - Dispatch the webViewResized() event on InspectorController, which is necessary to update the InspectorOverlay.
      - Remove the gutter overlay painting code.
      
      * src/WebDevToolsAgentImpl.cpp:
      (WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
      (WebKit::DeviceMetricsSupport::~DeviceMetricsSupport):
      (WebKit::WebDevToolsAgentImpl::attach):
      (WebKit::WebDevToolsAgentImpl::webViewResized):
      (WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
      * src/WebDevToolsAgentImpl.h:
      (WebDevToolsAgentImpl):
      * src/WebDevToolsAgentPrivate.h:
      (WebDevToolsAgentPrivate):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::resize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa967739
  4. 28 Sep, 2012 15 commits
    • jianli@chromium.org's avatar
      Add draggable property to WebDraggableRegion. · a48c0164
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97950
      
      Reviewed by Adam Barth.
      
      This needs to be done before we can land the patch to use new syntax for
      draggable regions. This is because Chromium side code cannot enable
      the changes to support new syntax side by side when this property is
      not present.
      
      * public/WebDraggableRegion.h:
      (WebDraggableRegion):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a48c0164
    • abarth@webkit.org's avatar
      [Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits... · 4065b083
      abarth@webkit.org authored
      [Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits from FrameDestructionObserver
      https://bugs.webkit.org/show_bug.cgi?id=97934
      
      Reviewed by James Robinson.
      
      After http://trac.webkit.org/changeset/129910, WebFrameImpl inherits
      from FrameDestructionObserver, which means it no longer need to manage
      its own weak pointer to WebCore::Frame.
      
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::frameLoaderDestroyed):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::WebFrameImpl):
      (WebKit::WebFrameImpl::setWebCoreFrame):
      * src/WebFrameImpl.h:
      (WebKit::WebFrameImpl::frameView):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4065b083
    • schenney@chromium.org's avatar
      Unreviewed Chromium Win build fix. · 03d1b41c
      schenney@chromium.org authored
      * src/WebViewImpl.cpp: Added "f" on initializers for floats.
      (WebKit):
      * tests/WebFrameTest.cpp: Added "f" on initializers for floats.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03d1b41c
    • commit-queue@webkit.org's avatar
      [Chromium]Add DoubleTap gesture · f786cc57
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90316
      
      Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-09-28
      Reviewed by Adam Barth.
      
      Added doubleTapGesture implementation and hooked it to an already present function computeScaleAndScrollForHitRect. Added 2 new tests and changed one based on the new implementation.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::WebViewImpl):
      (WebKit::WebViewImpl::handleGestureEvent):
      (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
      (WebKit::WebViewImpl::animateZoomAroundPoint):
      (WebKit::WebViewImpl::didCommitLoad):
      (WebKit::WebViewImpl::applyScrollAndScale):
      * src/WebViewImpl.h:
      (WebViewImpl):
      * tests/WebFrameTest.cpp:
      * tests/data/get_multiple_divs_for_auto_zoom_test.html: Added.
      * tests/data/get_scale_bounds_check_for_auto_zoom_test.html: Added.
      * tests/data/get_scale_for_auto_zoom_into_div_test.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f786cc57
    • abarth@webkit.org's avatar
      [Chromium] WebFrameImpl.cpp could use a style cleanup · c5de6127
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97924
      
      Reviewed by Dimitri Glazkov.
      
      This file is very old and contains a large number of style errors that
      are confusing folks contributing new code to this file. Most of these
      styles are Chromium-isms that crept in when the file was forked in the
      Chromium repository.
      
      * src/WebFrameImpl.cpp:
      (WebKit):
      (WebKit::frameContentAsPlainText):
      (ChromePrintContext):
      (WebKit::ChromePrintContext::spoolPage):
      (WebKit::ChromePrintContext::spoolAllPagesWithBoundaries):
      (ChromePluginPrintContext):
      (WebKit::ChromePluginPrintContext::spoolPage):
      (WebKit::WebFrameImpl::DeferredScopeStringMatches::DeferredScopeStringMatches):
      (WebKit::WebFrameImpl::DeferredScopeStringMatches::doTimeout):
      (WebKit::WebFrame::fromFrameOwnerElement):
      (WebKit::WebFrameImpl::uniqueName):
      (WebKit::WebFrameImpl::assignedName):
      (WebKit::WebFrameImpl::setName):
      (WebKit::WebFrameImpl::iconURLs):
      (WebKit::WebFrameImpl::scrollOffset):
      (WebKit::WebFrameImpl::minimumScrollOffset):
      (WebKit::WebFrameImpl::maximumScrollOffset):
      (WebKit::WebFrameImpl::contentsPreferredWidth):
      (WebKit::WebFrameImpl::documentElementScrollHeight):
      (WebKit::WebFrameImpl::hasHorizontalScrollbar):
      (WebKit::WebFrameImpl::hasVerticalScrollbar):
      (WebKit::WebFrameImpl::opener):
      (WebKit::WebFrameImpl::setOpener):
      (WebKit::WebFrameImpl::parent):
      (WebKit::WebFrameImpl::top):
      (WebKit::WebFrameImpl::firstChild):
      (WebKit::WebFrameImpl::lastChild):
      (WebKit::WebFrameImpl::nextSibling):
      (WebKit::WebFrameImpl::previousSibling):
      (WebKit::WebFrameImpl::traverseNext):
      (WebKit::WebFrameImpl::traversePrevious):
      (WebKit::WebFrameImpl::findChildByName):
      (WebKit::WebFrameImpl::findChildByExpression):
      (WebKit::WebFrameImpl::document):
      (WebKit::WebFrameImpl::performance):
      (WebKit::WebFrameImpl::windowObject):
      (WebKit::WebFrameImpl::bindToWindowObject):
      (WebKit::WebFrameImpl::executeScript):
      (WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
      (WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
      (WebKit::WebFrameImpl::collectGarbage):
      (WebKit::WebFrameImpl::checkIfRunInsecureContent):
      (WebKit::WebFrameImpl::executeScriptAndReturnValue):
      (WebKit::WebFrameImpl::callFunctionEvenIfScriptDisabled):
      (WebKit::WebFrameImpl::mainWorldScriptContext):
      (WebKit::WebFrameImpl::createFileSystem):
      (WebKit::WebFrameImpl::createSerializableFileSystem):
      (WebKit::WebFrameImpl::createFileEntry):
      (WebKit::WebFrameImpl::reload):
      (WebKit::WebFrameImpl::reloadWithOverrideURL):
      (WebKit::WebFrameImpl::loadRequest):
      (WebKit::WebFrameImpl::loadHistoryItem):
      (WebKit::WebFrameImpl::loadData):
      (WebKit::WebFrameImpl::loadHTMLString):
      (WebKit::WebFrameImpl::isLoading):
      (WebKit::WebFrameImpl::stopLoading):
      (WebKit::WebFrameImpl::provisionalDataSource):
      (WebKit::WebFrameImpl::dataSource):
      (WebKit::WebFrameImpl::previousHistoryItem):
      (WebKit::WebFrameImpl::currentHistoryItem):
      (WebKit::WebFrameImpl::enableViewSourceMode):
      (WebKit::WebFrameImpl::isViewSourceModeEnabled):
      (WebKit::WebFrameImpl::setReferrerForRequest):
      (WebKit::WebFrameImpl::dispatchWillSendRequest):
      (WebKit::WebFrameImpl::commitDocumentData):
      (WebKit::WebFrameImpl::insertText):
      (WebKit::WebFrameImpl::setMarkedText):
      (WebKit::WebFrameImpl::firstRectForCharacterRange):
      (WebKit::WebFrameImpl::executeCommand):
      (WebKit::WebFrameImpl::requestTextChecking):
      (WebKit::WebFrameImpl::selectWordAroundPosition):
      (WebKit::WebFrameImpl::selectRange):
      (WebKit::WebFrameImpl::visiblePositionForWindowPoint):
      (WebKit::WebFrameImpl::printBegin):
      (WebKit::WebFrameImpl::getPrintPageShrink):
      (WebKit::WebFrameImpl::printPage):
      (WebKit::WebFrameImpl::printEnd):
      (WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):
      (WebKit::WebFrameImpl::pageSizeAndMarginsInPixels):
      (WebKit::WebFrameImpl::pageProperty):
      (WebKit::WebFrameImpl::find):
      (WebKit::WebFrameImpl::scopeStringMatches):
      (WebKit::WebFrameImpl::reportFindInPageSelection):
      (WebKit::WebFrameImpl::sendOrientationChangeEvent):
      (WebKit::WebFrameImpl::addEventListener):
      (WebKit::WebFrameImpl::removeEventListener):
      (WebKit::WebFrameImpl::dispatchEvent):
      (WebKit::WebFrameImpl::dispatchMessageEventWithOriginCheck):
      (WebKit::WebFrameImpl::isActiveMatchFrameValid):
      (WebKit::WebFrameImpl::deliverIntent):
      (WebKit::WebFrameImpl::contentAsText):
      (WebKit::WebFrameImpl::contentAsMarkup):
      (WebKit::WebFrameImpl::renderTreeAsText):
      (WebKit::WebFrameImpl::printPagesWithBoundaries):
      (WebKit::WebFrameImpl::selectionBoundsRect):
      (WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor):
      (WebKit::WebFrameImpl::layerTreeAsText):
      (WebKit::WebFrameImpl::initializeAsMainFrame):
      (WebKit::WebFrameImpl::createChildFrame):
      (WebKit::WebFrameImpl::createFrameView):
      (WebKit::WebFrameImpl::fromFrame):
      (WebKit::WebFrameImpl::fromFrameOwnerElement):
      (WebKit::WebFrameImpl::viewImpl):
      (WebKit::WebFrameImpl::setCanHaveScrollbars):
      (WebKit::WebFrameImpl::setMarkerActive):
      (WebKit::WebFrameImpl::ordinalOfFirstMatchForFrame):
      (WebKit::WebFrameImpl::scopeStringMatchesSoon):
      (WebKit::WebFrameImpl::callScopeStringMatches):
      (WebKit::WebFrameImpl::invalidateIfNecessary):
      (WebKit::WebFrameImpl::loadJavaScriptURL):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5de6127
    • tkent@chromium.org's avatar
      Add parseDateTime, formatDateTime, and dateFormatText to Localizer · 3001fd18
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97885
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      This is a preparation to remove LocalizedData.h.
      
      Add the following pure virtual member functions to Localizer.
        parseDateTime
        formatDateTime
        dateFormatText.
      
      We rename existing parse/format functions for type=date in Locale*
      classes, and extend their functionality so that they support other
      date/time types. They override the new functions of Localizer.
      
      No new tests. This should not change any behavior.
      
      * platform/text/Localizer.h:
      (Localizer): Add parseDateTime, formatDateTime, and dateFormatText.
      
      * platform/text/LocaleICU.h:
      (LocaleICU):
      - Rename parseLocalizedDate to parseDateTime
      - Add type argument to parseDateTime
      - Rename formatLocalizedDate to formatDateTime
      - Rename localizedDateFormatText to dateFormatText
      - Make parseDateTime/formatDateTime/dateFormatText virtual.
      * platform/text/LocaleICU.cpp:
      (WebCore::LocaleICU::parseDateTime):
      Renamed. Reject non-date types.
      (WebCore::LocaleICU::formatDateTime): ditto.
      (WebCore::LocaleICU::dateFormatText): Renamed.
      * platform/text/LocalizedDateICU.cpp: Moved some code to LocaleICU.cpp.
      (WebCore::parseLocalizedDate):
      (WebCore::formatLocalizedDate):
      
      * platform/text/LocaleNone.cpp:
      Add empty implementations of parseDateTime, formatDateTime, and
      dateFormatText.
      (LocaleNone):
      (WebCore::LocaleNone::parseDateTime):
      (WebCore::LocaleNone::formatDateTime):
      (WebCore::LocaleNone::dateFormatText):
      
      * platform/text/LocaleWin.h:
      (LocaleWin):
      - Rename parseDate to parseDateTime
      - Add type argument to parseDateTime
      - Rename formatDate to formatDateTime
      - Make parseDateTime/formatDateTime/dateFormatText virtual.
      * platform/text/LocaleWin.cpp:
      (WebCore::LocaleWin::parseDateTime):
      Renamed. Reject non-date types.
      (WebCore::LocaleWin::formatDateTime): ditto.
      * platform/text/LocalizedDateWin.cpp: Moved some code to LocaleWin.cpp.
      (WebCore::parseLocalizedDate):
      (WebCore::formatLocalizedDate):
      
      * platform/text/mac/LocaleMac.h:
      (LocaleMac):
      - Rename parseDate to parseDateTime
      - Add type argument to parseDateTime
      - Rename formatDate to formatDateTime
      - Make parseDateTime/formatDateTime/dateFormatText virtual.
      * platform/text/mac/LocaleMac.mm:
      (WebCore::LocaleMac::parseDateTime):
      Renamed. Reject non-date types.
      (WebCore::LocaleMac::formatDateTime): ditto.
      * platform/text/mac/LocalizedDateMac.cpp: Moved some code to LocaleMac.mm.
      (WebCore::parseLocalizedDate):
      (WebCore::formatLocalizedDate):
      
      Source/WebKit/chromium:
      
      * tests/LocaleMacTest.cpp: Follow renaming of LocaleMac functions.
      (LocaleMacTest::formatDate):
      (LocaleMacTest::parseDate):
      * tests/LocaleWinTest.cpp: Follow renaming of LocaleWin functions.
      (LocaleWinTest::formatDate):
      (LocaleWinTest::parseDate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3001fd18
    • leandrogracia@chromium.org's avatar
      [Chromium] Fix the find-in-page implementation for detaching frames. · 7a42f48f
      leandrogracia@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97807
      
      Reviewed by Adam Barth.
      
      Follow-up of 97688. Introduces proper test coverage for the find-in-page
      feature in detaching/detached frame situations, fixing a few crashes and
      ensuring that a final reply is always sent.
      
      * public/WebNode.h:
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::find):
      (WebKit::WebFrameImpl::scopeStringMatches):
      (WebKit::WebFrameImpl::flushCurrentScopingEffort):
      (WebKit):
      (WebKit::WebFrameImpl::finishCurrentScopingEffort):
      (WebKit::WebFrameImpl::cancelPendingScopingEffort):
      (WebKit::WebFrameImpl::WebFrameImpl):
      (WebKit::WebFrameImpl::setWebCoreFrame):
      (WebKit::WebFrameImpl::initializeAsMainFrame):
      (WebKit::WebFrameImpl::createChildFrame):
      (WebKit::WebFrameImpl::shouldScopeMatches):
      (WebKit::WebFrameImpl::willDetachPage):
      * src/WebFrameImpl.h:
      (WebFrameImpl):
      * src/WebNode.cpp:
      (WebKit::WebNode::remove):
      (WebKit):
      * tests/WebFrameTest.cpp:
      * tests/data/find_in_page.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a42f48f
    • tkent@chromium.org's avatar
      Clean up Localizer-related functions · 24b1fce0
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97899
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      - Rename Document::getLocalizer to getCachedLocalizer
      - Add default argument to getCachedLocalizer
      - Add Element::localizer to reduce code size
      - Rename DateTimeNumericFieldElement::localizer to localizerForOwner to
        avoid conflict with Element::localizer
      - Add Localizer::createDefault to improve code readability
      
      No new tests. This shouldn't make any behavior change.
      
      * dom/Document.h:
      (Document): Rename getLocalizer to getCachedLocalizer, and add default
      argument.
      * dom/Document.cpp:
      (WebCore::Document::getCachedLocalizer): ditto.
      
      * dom/Element.h:
      (Element): Add localizer function.
      * dom/Element.cpp:
      (WebCore::Element::localizer): Added
      
      * html/shadow/DateTimeNumericFieldElement.h:
      (DateTimeNumericFieldElement): Rename localizer to localizerForOwner.
      * html/shadow/DateTimeNumericFieldElement.cpp: ditto.
      (WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
      (WebCore::DateTimeNumericFieldElement::localizerForOwner):
      (WebCore::DateTimeNumericFieldElement::value):
      
      * platform/text/Localizer.h:
      (Localizer): Add createDefault
      (WebCore::Localizer::createDefault): Implemented.
      
      * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue):
      Use Element::localizer.
      * html/NumberInputType.cpp:
      (WebCore::NumberInputType::localizeValue): ditto.
      (WebCore::NumberInputType::convertFromVisibleValue): ditto.
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/ColorPickerClient.cpp:
      (WebCore::ColorPickerClient::localizer): Follow Document::getLocalizer renaming.
      * WebCoreSupport/DatePickerClient.cpp:
      (WebCore::SelectPopupClient::localizer): ditto.
      * WebCoreSupport/SelectPopupClient.cpp:
      (WebCore::SelectPopupClient::localizer): ditto.
      
      Source/WebKit/chromium:
      
      * src/ColorChooserUIController.cpp:
      (WebKit::ColorChooserUIController::ColorChooserUIController):
      Use Localizer::createDefault
      * src/DateTimeChooserImpl.cpp:
      (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24b1fce0
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r129882. · b42fae0e
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/129882
      https://bugs.webkit.org/show_bug.cgi?id=97913
      
      Repaint is incorrect on many tests (Requested by schenney on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-28
      
      Source/WebCore:
      
      * inspector/InspectorController.cpp:
      * inspector/InspectorController.h:
      (WebCore):
      (InspectorController):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::paint):
      (WebCore::InspectorOverlay::update):
      (WebCore::buildObjectForPoint):
      (WebCore::buildArrayForQuad):
      (WebCore::buildObjectForHighlight):
      (WebCore::InspectorOverlay::reset):
      * inspector/InspectorOverlay.h:
      (InspectorOverlay):
      * inspector/InspectorOverlayPage.html:
      
      Source/WebKit/chromium:
      
      * src/WebDevToolsAgentImpl.cpp:
      (OverlayZOrders):
      (WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
      (WebKit::DeviceMetricsSupport::~DeviceMetricsSupport):
      (WebKit::DeviceMetricsSupport::restore):
      (WebKit::DeviceMetricsSupport::paintPageOverlay):
      (DeviceMetricsSupport):
      (WebKit::WebDevToolsAgentImpl::attach):
      (WebKit::WebDevToolsAgentImpl::webViewResized):
      (WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
      * src/WebDevToolsAgentImpl.h:
      (WebDevToolsAgentImpl):
      * src/WebDevToolsAgentPrivate.h:
      (WebDevToolsAgentPrivate):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::resize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b42fae0e
    • haraken@chromium.org's avatar
      Unreviewed, rolling out r129825. · e6f8abdb
      haraken@chromium.org authored
      http://trac.webkit.org/changeset/129825
      https://bugs.webkit.org/show_bug.cgi?id=97474
      
      DOMWindow.resizeTo() is broken. Asked by Mark Pilgrim.
      
      Source/Platform:
      
      * Platform.gypi:
      * chromium/public/WebScreenInfo.h: Removed.
      
      Source/WebCore:
      
      * WebCore.gypi:
      * platform/Widget.h:
      * platform/chromium/PageClientChromium.h: Removed.
      * platform/chromium/PlatformScreenChromium.cpp:
      (WebCore::screenHorizontalDPI):
      (WebCore::screenVerticalDPI):
      (WebCore::screenDepth):
      (WebCore::screenDepthPerComponent):
      (WebCore::screenIsMonochrome):
      (WebCore::screenRect):
      (WebCore::screenAvailableRect):
      * platform/chromium/PlatformSupport.h:
      (PlatformSupport):
      
      Source/WebKit/chromium:
      
      * public/WebScreenInfo.h:
      (WebKit):
      (WebScreenInfo):
      (WebKit::WebScreenInfo::WebScreenInfo):
      * src/ChromeClientImpl.cpp:
      * src/ChromeClientImpl.h:
      (WebKit):
      (WebKit::ChromeClientImpl::platformPageClient):
      (ChromeClientImpl):
      * src/PlatformSupport.cpp:
      (WebCore::toWebWidgetClient):
      (WebCore):
      (WebCore::PlatformSupport::screenHorizontalDPI):
      (WebCore::PlatformSupport::screenVerticalDPI):
      (WebCore::PlatformSupport::screenDepth):
      (WebCore::PlatformSupport::screenDepthPerComponent):
      (WebCore::PlatformSupport::screenIsMonochrome):
      (WebCore::PlatformSupport::screenRect):
      (WebCore::PlatformSupport::screenAvailableRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6f8abdb
    • apavlov@chromium.org's avatar
      Web Inspector: [Device Metrics] Remove the gutter overlay moving its... · 14475ceb
      apavlov@chromium.org authored
      Web Inspector: [Device Metrics] Remove the gutter overlay moving its functionality into the InspectorOverlay
      https://bugs.webkit.org/show_bug.cgi?id=97799
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      In order to reduce the amount of port-specific code, the gutter overlay painted in the device metrics emulation mode
      has been replaced by the respective functionality in the HTML-based InspectorOverlay in WebCore. The InspectorOverlay
      now covers the entire WebView rather than the FrameView only.
      
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::webViewResized):
      (WebCore):
      * inspector/InspectorController.h:
      (WebCore):
      (InspectorController):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::InspectorOverlay):
      (WebCore::InspectorOverlay::paint):
      (WebCore::InspectorOverlay::resize):
      (WebCore):
      (WebCore::InspectorOverlay::update):
      (WebCore::InspectorOverlay::drawGutter):
      (WebCore::InspectorOverlay::reset):
      * inspector/InspectorOverlay.h:
      (InspectorOverlay):
      * inspector/InspectorOverlayPage.html: Introduce the gutter painting functionality previously found in the Chromium's
      DeviceMetricsSupport class, which used to implement WebPageOverlay.
      
      Source/WebKit/chromium:
      
      - Dispatch the webViewResized() event on InspectorController, which is necessary to update the InspectorOverlay.
      - Remove the gutter overlay painting code.
      
      * src/WebDevToolsAgentImpl.cpp:
      (WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
      (WebKit::DeviceMetricsSupport::~DeviceMetricsSupport):
      (WebKit::WebDevToolsAgentImpl::attach):
      (WebKit::WebDevToolsAgentImpl::webViewResized):
      (WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
      * src/WebDevToolsAgentImpl.h:
      (WebDevToolsAgentImpl):
      * src/WebDevToolsAgentPrivate.h:
      (WebDevToolsAgentPrivate):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::resize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14475ceb
    • pfeldman@chromium.org's avatar
      Web Inspector: [chromium] remove devtools_frontend.zip · 6b11900a
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97650
      
      Reviewed by Yury Semikhatsky.
      
      This change removes the devtools_frontend zip generation and migrates to proper resource bundle for debug mode creation.
      
      * WebKit.gyp:
      * scripts/generate_devtools_zip.py: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b11900a
    • yurys@chromium.org's avatar
      Web Inspector: make HashSet memory instrumentation non-intrusive · 93d59a3a
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97879
      
      Reviewed by Vsevolod Vlasov.
      
      Source/WebKit/chromium:
      
      Update the test for HashSet memory instrumentation. We don't add
      HashSet's private objects into the set of visited objects any more
      and should update the expectation accordingly.
      
      * tests/MemoryInstrumentationTest.cpp:
      (WebCore::TEST):
      
      Source/WTF:
      
      Removed reportMemoryUsage declarations as a friend of HashSet and HashTable. Also
      removed MemoryInstrumentationHashTable which is not needed if we don't have
      access to HashSet's guts.
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/HashSet.h:
      (WTF):
      (HashSet):
      * wtf/HashTable.h:
      (HashTable):
      * wtf/MemoryInstrumentation.h:
      (WTF::MemoryClassInfo::addPrivateBuffer):
      * wtf/MemoryInstrumentationHashSet.h:
      (WTF::reportMemoryUsage):
      * wtf/MemoryInstrumentationHashTable.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93d59a3a
    • tkent@chromium.org's avatar
      Use Localizer in PagePopupController · 5aa94b50
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97862
      
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      No new tests. This doesn't change any behavior.
      
      * page/PagePopupClient.h:
      (WebCore):
      (PagePopupClient): Add "localizer" member function.
      * page/PagePopupController.cpp:
      (WebCore::PagePopupController::localizeNumberString):
      Use a Localizer object provided by PagePopupClient.
      
      Source/WebKit/blackberry:
      
      We need to implement PagePopupClient::localizer. These clients know the
      host elements. Localizer implementations get Localizer objects from the
      owner documents of the elements for the browser locale.
      
      * WebCoreSupport/ColorPickerClient.cpp:
      (WebCore::ColorPickerClient::localizer): Added.
      * WebCoreSupport/ColorPickerClient.h:
      (ColorPickerClient): Declare "localizer."
      * WebCoreSupport/DatePickerClient.cpp:
      (WebCore::SelectPopupClient::localizer): Added.
      * WebCoreSupport/DatePickerClient.h:
      (DatePickerClient): Declare "localizer."
      * WebCoreSupport/SelectPopupClient.cpp:
      (WebCore::SelectPopupClient::localizer): Added.
      * WebCoreSupport/SelectPopupClient.h:
      (SelectPopupClient): Declare "localizer."
      
      Source/WebKit/chromium:
      
      We need to implement PagePopupClient::localizer. The current
      implementations of localizer functions always return Localizer objects
      for the browser locale. It's ok because other locale-dependent stuff in
      PagePopup uses the browser locale, not element locale. We might want to
      update this behavior later for testing i18n behavior in PagePopup.
      
      * src/ColorChooserUIController.cpp:
      (WebKit::ColorChooserUIController::ColorChooserUIController):
      Initialize m_localizer with the browser default locale.
      (WebKit::ColorChooserUIController::localizer):
      Returns m_localizer.
      * src/ColorChooserUIController.h:
      (ColorChooserUIController): Declare localizer function and m_localizer.
      
      * src/DateTimeChooserImpl.cpp:
      (WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
      Initialize m_localizer with the browser default locale.
      (WebKit::DateTimeChooserImpl::localizer):
      Returns m_localizer.
      * src/DateTimeChooserImpl.h:
      (DateTimeChooserImpl): Declare localizer function and m_localizer.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5aa94b50
    • tkent@chromium.org's avatar
      Switch monthLabels, weekDayShortLabels, and firstDayOfWeek to Localizer · 89183614
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97874
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      No new tests. This change shouldn't change any behavior.
      
      * platform/text/Localizer.h:
      (Localizer): Add monthLabels, weekDayShortLabels, and firstDayOfWeek.
      * platform/text/LocalizedDate.h:
      (WebCore): Remove them.
      * platform/text/LocalizedDateICU.cpp:
      (WebCore::localizedDateFormatText): ditto.
      * platform/text/LocalizedDateWin.cpp:
      (WebCore::localizedDateFormatText): ditto.
      * platform/text/mac/LocalizedDateMac.cpp:
      (WebCore::localizedDateFormatText): ditto.
      
      * platform/text/LocaleICU.h:
      (LocaleICU): Add virtual and OVERRIDE.
      * platform/text/LocaleWin.h:
      (LocaleWin):
      - Add virtual and OVERRIDE.
      - Move the content of firstDayOfWeek to LocaleWin.cpp because inline
      definition of a virtual function is not efficient.
      * platform/text/LocaleWin.cpp:
      (WebCore::LocaleWin::firstDayOfWeek): See above.
      * platform/text/mac/LocaleMac.h:
      (LocaleMac): Add virtual and OVERRIDE.
      
      Source/WebKit/chromium:
      
      * src/DateTimeChooserImpl.cpp:
      (WebKit::DateTimeChooserImpl::writeDocument):
      Use Localizer for the browser locale.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89183614
  5. 27 Sep, 2012 8 commits