1. 24 Oct, 2008 2 commits
  2. 23 Oct, 2008 1 commit
    • mitz@apple.com's avatar
      WebCore: · 83d2e872
      mitz@apple.com authored
              Reviewed by Sam Weinig with no hesitation.
      
              - fix the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
                <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering
      
              Test: fast/text/bidi-embedding-pop-and-push-same.html
      
              * platform/text/BidiResolver.h:
              (WebCore::BidiResolver::embed): Changed to only add the embedding
              operation to a vector of pending operations.
      
              (WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Added. Moved the
              code that used to be in the PDF case of embed() here, except the part
              that sets the context.
      
              (WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Added. Moved the
              code that used to be in the non-PDF case of embed() here, except the
              part the sets the context.
      
              (WebCore::BidiResolver::commitExplicitEmbedding): Added. Processes the
              explicit embedding operations in the vector by creating an updated
              context and determining the old and new embedding levels. If the levels
              are not the same, calls {lower,raise}ExplicitEmbeddingLevel(). Always
              sets the context to the new one.
      
              (WebCore::BidiResolver::createBidiRunsForLine): Added calls to
              commitExplicitEmbedding() after calling embed() and after calling
              increment().
      
              * rendering/bidi.cpp:
              (WebCore::bidiFirst): Added calls to commitExplicitEmbedding() because
              this function increments the resolver.
      
              (WebCore::RenderBlock::skipLeadingWhitespace): Ditto.
      
      LayoutTests:
      
              Reviewed by Sam Weinig with no hesitation.
      
              - test for the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
                <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering
      
              * fast/text/bidi-embedding-pop-and-push-same.html: Added.
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83d2e872
  3. 17 Oct, 2008 1 commit
    • pam@chromium.org's avatar
      2008-10-17 Pamela Greene <pam@chromium.org> · 9e076f28
      pam@chromium.org authored
              Add a number of new tests.
              See https://bugs.webkit.org/show_bug.cgi?id=21407
      
              Reviewed by Alexey Proskuryakov.
      
              * fast/css/border-height.html: Added.
              * fast/dom/Window/orphaned-frame-access-expected.txt: Added.
              * fast/dom/Window/orphaned-frame-access.html: Added.
              * fast/forms/image-border.html: Added.
              * fast/forms/input-field-text-truncated.html: Added.
              * fast/forms/input-type-text-min-width.html: Added.
              * fast/forms/textarea-scrollbar-height-expected.txt: Added.
              * fast/forms/textarea-scrollbar-height.html: Added.
              * fast/forms/textarea-width.html: Added.
              * fast/overflow/overflow_hidden.html: Added.
              * fast/parser/resources/xml-declaration-missing-ending-mark.xml: Added.
              * fast/parser/xml-declaration-missing-ending-mark-expected.txt: Added.
              * fast/parser/xml-declaration-missing-ending-mark.html: Added.
              * fast/text/international/hindi-spacing.html: Added.
              * http/tests/misc/crash-multiple-family-fontface-expected.txt: Added.
              * http/tests/misc/crash-multiple-family-fontface.html: Added.
              * platform/mac/fast/css/border-height-expected.checksum: Added.
              * platform/mac/fast/css/border-height-expected.png: Added.
              * platform/mac/fast/css/border-height-expected.txt: Added.
              * platform/mac/fast/forms/image-border-expected.checksum: Added.
              * platform/mac/fast/forms/image-border-expected.png: Added.
              * platform/mac/fast/forms/image-border-expected.txt: Added.
              * platform/mac/fast/forms/input-field-text-truncated-expected.checksum: Added.
              * platform/mac/fast/forms/input-field-text-truncated-expected.png: Added.
              * platform/mac/fast/forms/input-field-text-truncated-expected.txt: Added.
              * platform/mac/fast/forms/input-type-text-min-width-expected.checksum: Added.
              * platform/mac/fast/forms/input-type-text-min-width-expected.png: Added.
              * platform/mac/fast/forms/input-type-text-min-width-expected.txt: Added.
              * platform/mac/fast/forms/textarea-width-expected.checksum: Added.
              * platform/mac/fast/forms/textarea-width-expected.png: Added.
              * platform/mac/fast/forms/textarea-width-expected.txt: Added.
              * platform/mac/fast/overflow/overflow_hidden-expected.checksum: Added.
              * platform/mac/fast/overflow/overflow_hidden-expected.png: Added.
              * platform/mac/fast/overflow/overflow_hidden-expected.txt: Added.
              * platform/mac/fast/text/international/hindi-spacing-expected.checksum: Added.
              * platform/mac/fast/text/international/hindi-spacing-expected.png: Added.
              * platform/mac/fast/text/international/hindi-spacing-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e076f28
  4. 14 Oct, 2008 1 commit
    • hyatt@apple.com's avatar
      WebCore: · bf26cc09
      hyatt@apple.com authored
      2008-10-14  David Hyatt  <hyatt@apple.com>
      
              https://bugs.webkit.org/show_bug.cgi?id=21595
      
              Clean up background and overflow propagation from the body to the viewport.  Make it match the
              latest CSS2.1 spec thinking.
      
              Reviewed by Adam Roben
      
              Added many tests at fast/body-propagation/.  These are Simon Pieters' tests of propagation handling
              (available at http://simon.html5.org/test/css/magic-body/).
      
              * dom/Document.cpp:
              (WebCore::Document::body):
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::styleDidChange):
              (WebCore::RenderBox::paintRootBoxDecorations):
              (WebCore::RenderBox::paintBoxDecorations):
              (WebCore::RenderBox::repaintLayerRectsForImage):
      
      LayoutTests:
      
      2008-10-14  David Hyatt  <hyatt@apple.com>
      
              Add layout tests for body propagation of overflow and background to the viewport.
      
              Reviewed by Adam Roben
      
              * fast/body-propagation: Added.
              * fast/body-propagation/background-color: Added.
              * fast/body-propagation/background-color/001-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/001.html: Added.
              * fast/body-propagation/background-color/002-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/002.html: Added.
              * fast/body-propagation/background-color/003-declarative.xhtml: Added.
              * fast/body-propagation/background-color/003-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/003.html: Added.
              * fast/body-propagation/background-color/004-declarative.xhtml: Added.
              * fast/body-propagation/background-color/004-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/004.html: Added.
              * fast/body-propagation/background-color/005-declarative.xhtml: Added.
              * fast/body-propagation/background-color/005-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/005.html: Added.
              * fast/body-propagation/background-color/006-declarative.xhtml: Added.
              * fast/body-propagation/background-color/006-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/006.html: Added.
              * fast/body-propagation/background-color/007-declarative.xhtml: Added.
              * fast/body-propagation/background-color/007-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/007.html: Added.
              * fast/body-propagation/background-color/008-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/008.html: Added.
              * fast/body-propagation/background-image: Added.
              * fast/body-propagation/background-image/001-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/001.html: Added.
              * fast/body-propagation/background-image/002-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/002.html: Added.
              * fast/body-propagation/background-image/003-declarative.xhtml: Added.
              * fast/body-propagation/background-image/003-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/003.html: Added.
              * fast/body-propagation/background-image/004-declarative.xhtml: Added.
              * fast/body-propagation/background-image/004-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/004.html: Added.
              * fast/body-propagation/background-image/005-declarative.xhtml: Added.
              * fast/body-propagation/background-image/005-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/005.html: Added.
              * fast/body-propagation/background-image/006-declarative.xhtml: Added.
              * fast/body-propagation/background-image/006-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/006.html: Added.
              * fast/body-propagation/background-image/007-declarative.xhtml: Added.
              * fast/body-propagation/background-image/007-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/007.html: Added.
              * fast/body-propagation/background-image/008-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/008.html: Added.
              * fast/body-propagation/background-image/009-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/009.html: Added.
              * fast/body-propagation/background-image/010-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/010.html: Added.
              * fast/body-propagation/background-image/resources: Added.
              * fast/body-propagation/background-image/resources/lime.png: Added.
              * fast/body-propagation/background-image/resources/red.png: Added.
              * fast/body-propagation/background-image/resources/white.png: Added.
              * fast/body-propagation/background-image/resources/yellow.png: Added.
              * fast/body-propagation/overflow: Added.
              * fast/body-propagation/overflow/001-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/001.html: Added.
              * fast/body-propagation/overflow/002-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/002.html: Added.
              * fast/body-propagation/overflow/003-declarative.xhtml: Added.
              * fast/body-propagation/overflow/003-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/003.html: Added.
              * fast/body-propagation/overflow/004-declarative.xhtml: Added.
              * fast/body-propagation/overflow/004-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/004.html: Added.
              * fast/body-propagation/overflow/005-declarative.xhtml: Added.
              * fast/body-propagation/overflow/005-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/005.html: Added.
              * fast/body-propagation/overflow/006-declarative.xhtml: Added.
              * fast/body-propagation/overflow/006-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/006.html: Added.
              * fast/body-propagation/overflow/007-declarative.xhtml: Added.
              * fast/body-propagation/overflow/007-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/007.html: Added.
              * platform/mac/fast/body-propagation: Added.
              * platform/mac/fast/body-propagation/background-color: Added.
              * platform/mac/fast/body-propagation/background-color/001-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/001-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/001-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/001-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/001-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/001-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/002-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/002-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/002-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/002-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/002-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/002-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/003-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/003-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/003-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/003-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/003-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/003-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/003-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/003-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/003-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/004-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/004-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/004-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/004-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/004-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/004-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/004-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/004-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/004-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/005-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/005-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/005-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/005-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/005-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/005-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/005-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/005-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/005-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/006-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/006-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/006-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/006-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/006-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/006-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/006-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/006-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/006-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/007-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/007-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/007-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/007-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/007-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/007-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/007-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/007-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/007-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/008-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/008-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/008-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/008-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/008-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/008-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image: Added.
              * platform/mac/fast/body-propagation/background-image/001-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/001-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/001-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/001-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/001-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/001-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/002-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/002-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/002-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/002-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/002-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/002-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/003-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/003-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/003-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/003-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/003-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/003-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/003-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/003-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/003-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/004-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/004-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/004-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/004-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/004-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/004-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/004-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/004-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/004-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/005-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/005-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/005-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/005-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/005-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/005-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/005-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/005-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/005-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/006-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/006-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/006-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/006-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/006-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/006-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/006-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/006-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/006-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/007-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/007-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/007-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/007-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/007-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/007-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/007-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/007-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/007-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/008-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/008-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/008-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/008-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/008-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/008-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/009-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/009-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/009-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/009-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/009-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/009-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/010-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/010-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/010-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/010-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/010-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/010-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow: Added.
              * platform/mac/fast/body-propagation/overflow/001-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/001-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/001-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/001-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/001-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/001-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/002-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/002-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/002-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/003-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/003-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/003-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/003-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/003-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/004-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/004-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/004-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/004-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/004-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/005-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/005-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/005-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/005-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/005-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/005-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/005-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/005-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/005-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/006-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/006-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/006-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/006-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/006-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/006-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/006-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/006-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/006-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/007-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/007-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/007-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/007-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/007-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf26cc09
  5. 12 Oct, 2008 2 commits
    • darin@apple.com's avatar
      2008-10-12 Pamela Greene <pam@chromium.org> · 15c150b8
      darin@apple.com authored
              Reviewed by Darin Adler.
      
              - https://bugs.webkit.org/show_bug.cgi?id=21523
      
              Add tests to cover more gradient edge cases: missing endpoints, only
              endpoints, only one stop.
      
              * fast/canvas/fillrect_gradient.html:
              * platform/mac/fast/canvas/fillrect_gradient-expected.checksum:
              * platform/mac/fast/canvas/fillrect_gradient-expected.png:
              * platform/mac/fast/canvas/fillrect_gradient-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15c150b8
    • darin@apple.com's avatar
      WebCore: · ad096cad
      darin@apple.com authored
      2008-10-12  Glenn Wilson  <gwilson@google.com>
      
              Reviewed by Darin Adler.
      
              - https://bugs.webkit.org/show_bug.cgi?id=20461
      
              Added feature to allow multi-line inputs into text fields.
              HTMLInputElement would cut the set text at the first 'system' character,
              so it would truncate at the first carriage return or newline.
              This fix modifies that behavior to truncate at any non-space system character
              but changes \r, \n, and \r\n to a single space.
      
              Tests: editing/pasteboard/paste-multiline-text-input.html
                     
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::constrainValue):
      
      LayoutTests:
      
      2008-10-12  Glenn Wilson  <gwilson@google.com>
      
              Reviewed by Darin Adler.
      
              - https://bugs.webkit.org/show_bug.cgi?id=20461
      
              Added new test to verify that the user can cut and paste multiple lines of text
              into a single line text field.
      
              * fast/forms/paste-multiline-text-input-expected.txt: Added.
              * fast/forms/paste-multiline-text-input.html: Added.
              * fast/forms/input-truncate-newline-expected.txt: Removed.
              * fast/forms/input-truncate-newline.html: Removed.
      
              * fast/forms/8250-expected.txt: Added.
              * fast/forms/8250.html: Updated test to be text-only and expect new results.
              * platform/mac/fast/forms/8250-expected.checksum: Removed.
              * platform/mac/fast/forms/8250-expected.png: Removed.
              * platform/mac/fast/forms/8250-expected.txt: Removed.
              * platform/qt/fast/forms/8250-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad096cad
  6. 10 Oct, 2008 1 commit
  7. 09 Oct, 2008 1 commit
    • eric@webkit.org's avatar
      Reviewed by Oliver Hunt. · 3df115dc
      eric@webkit.org authored
              Fix transformed patterns
              https://bugs.webkit.org/show_bug.cgi?id=21498
      
              Test: fast/canvas/patternfill-repeat.html
      
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::setStrokePattern):
              (WebCore::GraphicsContext::setFillPattern):
              (WebCore::GraphicsContext::setStrokeGradient):
              (WebCore::GraphicsContext::setFillGradient):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::applyStrokePattern):
              (WebCore::applyFillPattern):
              (WebCore::GraphicsContext::drawPath):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::fillRect):
              * platform/graphics/qt/GraphicsContextQt.cpp:
              * platform/graphics/wx/GraphicsContextWx.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3df115dc
  8. 03 Oct, 2008 1 commit
  9. 02 Oct, 2008 1 commit
    • adele@apple.com's avatar
      WebCore: · f022590e
      adele@apple.com authored
      2008-10-02  Adele Peterson  <adele@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21299
              REGRESSION: <input> color specified in inline style applies to placeholder
      
              I recently added a pseudo-class for the placeholder, but that can be overridden by inline style changes.  A pseudo-element
              is more appropriate.  This change adds "-webkit-input-placeholder".
      
              * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
              Added definition for "-webkit-input-placeholder" pseudo element.
              * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoInputPlaceholder.
              * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              Added case for PseudoInputPlaceholder.
              * css/html4.css: Added rule for -webkit-input-placeholder pseudo-element.
              * rendering/style/RenderStyle.h: (WebCore::RenderStyle::): Added INPUT_PLACEHOLDER.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::setValue): Check that its a text field before calling updatePlaceholderVisibility.
              (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
              (WebCore::HTMLInputElement::updatePlaceholderVisibility): Instead of calling setChanged(), call updatePlaceholderVisibility on the renderer.
              setChanged wouldn't actually trigger setStyle since the style for the input element won't actually change.
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::createInnerTextStyle): Get the pseudoStyle when the placeholder is visible.
              (WebCore::RenderTextControl::updatePlaceholderVisibility): Sets the style on the inner text block, and calls updateFromElement so
              the text will be updated correctly.
              * rendering/RenderTextControl.h:
      
      LayoutTests:
      
      2008-10-02  Adele Peterson  <adele@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Update tests for https://bugs.webkit.org/show_bug.cgi?id=21299
              REGRESSION: <input> color specified in inline style applies to placeholder
      
              * fast/forms/placeholder-pseudo-style.html:
              * platform/mac/fast/forms/password-placeholder-expected.txt:
              * platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f022590e
  10. 30 Sep, 2008 1 commit
    • adele@apple.com's avatar
      WebCore: · ed74a6ef
      adele@apple.com authored
      2008-09-30  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21227
              <rdar://problem/6222134> add a way to set color for input placeholder text
      
              Test: fast/forms/placeholder-pseudo-style.html
      
              This change adds "-webkit-input-placeholder-mode" as a pseudo class that can be used to style
              input elements when they are displaying the placeholder text.
      
              * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Add case for inputPlaceholderMode.
              * css/CSSSelector.h: (WebCore::CSSSelector::): Add PseudoInputPlaceholderMode.
              * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              Add check for PseudoInputPlaceholderMode that asks the node if placeholderShouldBeVisible is true.
              * css/html4.css: Add rule to make placeholder text default to darkGray.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::init): Initialize m_placeholderShouldBeVisible.
              (WebCore::HTMLInputElement::dispatchFocusEvent): Call updatePlaceholderVisibility.
              (WebCore::HTMLInputElement::dispatchBlurEvent): ditto.
              (WebCore::HTMLInputElement::parseMappedAttribute): ditto.
              (WebCore::HTMLInputElement::setValue): ditto.
              (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
              (WebCore::HTMLInputElement::updatePlaceholderVisibility): Sets m_placeholderShouldBeVisible based on the current value and the focus state.
               This calculation used to be done in the renderer, but since the node knows everything about the state, it can make that decision, and the
               renderer will just ask the node if it should draw the placeholder.
              * html/HTMLInputElement.h: (WebCore::HTMLInputElement::placeholderShouldBeVisible):
      
              * rendering/RenderTextControl.cpp:
              (WebCore::disabledTextColor): Moved to the top of the file.  If there's not very much contrast between the disabled color and the background color,
              just leave the text color alone.  We don't want to change a good contrast color scheme so that it has really bad contrast.
              If the the contrast was already poor, then it doesn't do any good to change it to a different poor contrast color scheme.
              (WebCore::RenderTextControl::createInnerTextStyle): If the node says the placeholder should be visible, prepare by overriding the text security to be "none".
              This can only happen as a result of either a setStyle call (which will be followed by a call to updateFromElement) or from createSubtreeIfNeeded, which
              is called directly from updateFromElement.  updateFromElement will immediately update the text displayed.
              (WebCore::RenderTextControl::updateFromElement): If the placeholder visibility has changed, update the text that is displayed.
              (WebCore::RenderTextControl::forwardEvent): Remove calls to update the placeholder state.  This is now done in HTMLInputElement.
              * rendering/RenderTextControl.h:
      
      LayoutTests:
      
      2008-09-30  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Tests for https://bugs.webkit.org/show_bug.cgi?id=21227
              <rdar://problem/6222134> add a way to set color for input placeholder text
      
              * fast/forms/password-placeholder-text-security.html: Added.
              * fast/forms/placeholder-pseudo-style.html: Added.
              * platform/mac/fast/forms/password-placeholder-text-security-expected.checksum: Added.
              * platform/mac/fast/forms/password-placeholder-text-security-expected.png: Added.
              * platform/mac/fast/forms/password-placeholder-text-security-expected.txt: Added.
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum: Added.
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.png: Added.
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.txt: Added.
      
              Updated results. The placeholder color is now reflected on the RenderTextControl, not just on an inner element.
      
              * platform/mac/fast/forms/input-disabled-color-expected.checksum:
              * platform/mac/fast/forms/input-disabled-color-expected.png:
              * platform/mac/fast/forms/input-disabled-color-expected.txt:
              * platform/mac/fast/forms/password-placeholder-expected.checksum:
              * platform/mac/fast/forms/password-placeholder-expected.png:
              * platform/mac/fast/forms/password-placeholder-expected.txt:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.png:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed74a6ef
  11. 24 Sep, 2008 1 commit
  12. 19 Sep, 2008 3 commits
    • bdakin@apple.com's avatar
      WebCore: · 5b0a3b2b
      bdakin@apple.com authored
      2008-09-19  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Fix for <rdar://problem/6231308> crash in AutoTableLayout
      
              The code assumes later on that a TableSection's grid's row vector 
              will never be empty. So make 1 the minimum number of columns.
      
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::ensureRows):
      
      LayoutTests:
      
      2008-09-19  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Test for <rdar://problem/6231308> crash in AutoTableLayout
      
              * fast/table/empty-row-crash.html: Added.
              * platform/mac/fast/table/empty-row-crash-expected.checksum: Added.
              * platform/mac/fast/table/empty-row-crash-expected.png: Added.
              * platform/mac/fast/table/empty-row-crash-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b0a3b2b
    • hyatt@apple.com's avatar
      WebCore: · 2d7bdf78
      hyatt@apple.com authored
      2008-09-19  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Sam Weinig
      
              https://bugs.webkit.org/show_bug.cgi?id=20941
      
              Incorrect height calculation for replaced element inside nested
              positioned elements (where the inner has a percentage height and
              the outer implicitly has a fixed height because of explicit top/bottom
              values).
      
              Added fast/block/positioning/replaced-inside-top-bottom.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::availableHeightUsing):
      
      LayoutTests:
      
      2008-09-19  David Hyatt  <hyatt@apple.com>
      
              Fix for bug 20941.
      
              Reviewed by Sam Weinig
      
              * fast/block/positioning/replaced-inside-fixed-top-bottom.html: Added.
              * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Added.
              * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
              * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d7bdf78
    • darin@apple.com's avatar
      JavaScriptCore: · c9aea831
      darin@apple.com authored
      2008-09-18  Darin Adler  <darin@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              - part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
                make each distinct C++ class get a distinct JSC::Structure
      
              * kjs/lookup.h: Removed things here that were used only in WebCore:
              cacheGlobalObject, JSC_DEFINE_PROTOTYPE, JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE,
              and JSC_IMPLEMENT_PROTOTYPE.
      
      WebCore:
      
      2008-09-18  Darin Adler  <darin@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              - part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
                make each distinct C++ class get a distinct JSC::Structure
      
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              (WebCore::JSCSSStyleDeclaration::customPut): Use setDOMException
              instead of DOMExceptionTranslator.
      
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::getCachedDOMObjectWrapper): Updated function name.
              (WebCore::cacheDOMObjectWrapper): Ditto.
              (WebCore::forgetDOMObject): Ditto.
              (WebCore::getCachedDOMNodeWrapper): Ditto.
              (WebCore::forgetDOMNode): Ditto.
              (WebCore::cacheDOMNodeWrapper): Ditto.
              (WebCore::forgetAllDOMNodesForDocument): Ditto.
              (WebCore::markDOMNodesForDocument): Ditto.
              (WebCore::updateDOMNodeDocument): Ditto.
              (WebCore::getCachedDOMStructure): Added.
              (WebCore::createDOMStructure): Ditto.
      
              * bindings/js/JSDOMBinding.h: Get rid of the ScriptInterpreter
              class and replace the static member functions with non-member
              functions. Added many other functions for getting at structures,
              prototypes, wrappers, and creating them. Also moved the
              cacheGlobalObject function here from JavaScriptCore; eventually
              I'll remove that once I get rid of the remaining callers. Also
              removed the DOMExceptionTranslator class.
      
              * bindings/js/JSDOMWindowBase.h: Added JSDOMStructureMap type,
              and put one of those maps in each window.
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::markDOMObjectWrapper): Updated for function name change.
              (WebCore::JSDOMWindow::mark): Added code to mark all the structures
              in the structure map.
      
              * bindings/js/JSEventTargetNode.cpp:
              (WebCore::JSEventTargetNode::JSEventTargetNode): Changed to take
              a structure instead of a prototype.
              * bindings/js/JSEventTargetNode.h: Ditto.
              * bindings/js/JSHTMLAllCollection.h:
              (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Ditto.
      
              * bindings/js/JSHTMLInputElementBase.cpp:
              (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Removed
              use of the JSC_IMPLEMENT_PROTOTYPE macro, and changed to take a
              structure instead of a prototype.
              * bindings/js/JSHTMLInputElementBase.h: Removed use of the
              JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro, and changed constructor
              to take a structure instead of a prototype. Created a dummy prototype
              class that causes the HTMLInputElement prototype to have the
              HTMLElement prototype.
      
              * bindings/scripts/CodeGeneratorJS.pm: Change constructors to take
              structures instead of prototypes. Changed the prototype self function
              to use the getDOMPrototype function -- later we can eliminate it and
              have callers invoke getDOMPrototype directly instead. Updated other
              functions that have name changes. Added code to generate the
              createPrototype member function. Changed use of cacheGlobalObject to
              get it from the WebCore namespace instead of the JSC namespace.
              Changed cacheDOMObject calls to use getDOMObjectWrapper instead.
      
              * dom/Document.cpp:
              (WebCore::Document::~Document): Updated for name change and also
              removed unnecessary JSLock use -- there's no need to lock around this.
              * dom/Node.cpp:
              (WebCore::Node::setDocument): Ditto.
      
              * dom/make_names.pl: Changed to use CREATE_DOM_NODE_WRAPPER macro
              instead of calling new directly.
      
              * bindings/js/JSCSSRuleCustom.cpp:
              (WebCore::toJS): Updated for function name changes and used the
              CREATE_DOM_OBJECT_WRAPPER macro.
              * bindings/js/JSCSSValueCustom.cpp:
              (WebCore::toJS): Ditto.
              * bindings/js/JSCanvasPixelArrayCustom.cpp:
              (WebCore::toJS): Ditto.
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::mark): Ditto.
              (WebCore::toJS): Ditto.
              * bindings/js/JSElementCustom.cpp:
              (WebCore::toJSNewlyCreated): Ditto.
              * bindings/js/JSEventCustom.cpp:
              (WebCore::toJS): Ditto.
              * bindings/js/JSEventTargetBase.cpp:
              (WebCore::jsEventTargetDispatchEvent): Use setDOMException instead
              of DOMExceptionTranslator.
              (WebCore::toJS): Updated for function name changes and used the
              CREATE_DOM_OBJECT_WRAPPER macro.
              * bindings/js/JSHTMLCollectionCustom.cpp:
              (WebCore::toJS): Ditto.
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::JSNode::mark): Ditto.
              (WebCore::createWrapper): Ditto.
              (WebCore::toJS): Ditto.
              * bindings/js/JSSVGPathSegCustom.cpp:
              (WebCore::toJS): Ditto.
              * bindings/js/JSStyleSheetCustom.cpp:
              (WebCore::toJS): Ditto.
              (WebCore::JSStyleSheet::mark): Ditto.
              * bindings/js/JSTextCustom.cpp:
              (WebCore::toJSNewlyCreated): Ditto.
              * bindings/js/JSXMLHttpRequestConstructor.cpp:
              (WebCore::constructXMLHttpRequest): Ditto.
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::mark): Ditto.
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
              (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
              * bindings/js/JSXSLTProcessorConstructor.cpp:
              (WebCore::constructXSLTProcessor): Ditto.
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::finishedWithEvent): Ditto.
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
              (WebCore::XMLHttpRequest::dropProtection): Ditto.
      
      LayoutTests:
      
      2008-09-18  Darin Adler  <darin@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              * platform/mac/fast/dom/wrapper-classes-expected.txt: Update results to
              reflect correct prototype for CSSStyleRule.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9aea831
  13. 16 Sep, 2008 2 commits
    • mitz@apple.com's avatar
      WebCore: · d9462a52
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=15129
                <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
      
              Covered by fast/repaint/4776765.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock): Avoid repainting this object if it
              did not have layout in the beginning.
              (WebCore::RenderBlock::layoutBlockChildren): If a child did not have
              layout in the beginning, repaint it in its new position, to compensate
              for the above (regardless of whether it "moved").
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::checkForRepaintDuringLayout): Added a comment
              about generalizing this fix in the future.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - updated results for https://bugs.webkit.org/show_bug.cgi?id=15129
                <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
      
              * platform/mac/fast/repaint/4776765-expected.checksum:
              * platform/mac/fast/repaint/4776765-expected.png:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9462a52
    • mitz@apple.com's avatar
      WebCore: · 6d92520b
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=15384
                Div does not notice when grandparent changes height
      
              Test: fast/block/basic/quirk-percent-height-grandchild.html
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=20714
                Resizing Gmail inbox vertically results in whitespace at the bottom of the window
      
              Test: fast/replaced/percent-height-in-anonymous-block.html
      
              Added a two-way mapping between boxes with percentage heights and
              their non-parent ancestors up to the one the height is computed relative
              to. In quirks mode (the first bug), this can be any number of containing
              block with auto height. In strict mode (the second bug) this can be
              the containing block of an anonymous block containing a replaced
              element.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::~RenderBlock): Added code to remove the all the
              mapping to/from this block to percentage-height descendants.
              (WebCore::RenderBlock::layoutBlockChildren): Added code to mark
              percentage-height descendants (and their containing block ancestry chain
              up to this block) for layout. This ensures that those descendants whose
              height depends on the height of this block (or an ancestor) are updated.
              (WebCore::RenderBlock::addPercentHeightDescendant): Added. Establishes
              a two-way mapping between this block and the given box.
              (WebCore::RenderBlock::removePercentHeightDescendant): Added. Removes
              all the mapping to/from this box.
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::setStyle): Added calls to
              removePercentHeightDescendant() when style changes and the box
              previously had a percentage height. An exception is when the style
              change does not require layout, in which case the box still has
              a percentage height and the mappings are valid. In all other cases,
              any required mappings will be (re-)established during layout.
              (WebCore::RenderBox::destroy): Added a call to
              removePercentHeightDescendant.
              (WebCore::RenderBox::calcPercentageHeight): Added code that, in quirks
              mode, if a higher-than-parent containing block is affecting the box's
              height, creates a mapping between the box and that block.
              (WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over
              anonymous containing blocks, if any, and when that happens, use
              addPercentHeightDescendant() to ensure that the non-anonymous block
              is aware of the dependent percent-height box.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test for https://bugs.webkit.org/show_bug.cgi?id=15384
                Div does not notice when grandparent changes height
      
              - test for https://bugs.webkit.org/show_bug.cgi?id=20714
                Resizing Gmail inbox vertically results in whitespace at the bottom of the window
      
              * fast/block/basic/quirk-percent-height-grandchild.html: Added.
              * fast/replaced/percent-height-in-anonymous-block.html: Added.
              * platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.checksum: Added.
              * platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.png: Added.
              * platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.txt: Added.
              * platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.checksum: Added.
              * platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.png: Added.
              * platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d92520b
  14. 14 Sep, 2008 1 commit
  15. 13 Sep, 2008 1 commit
    • mitz@apple.com's avatar
      WebCore: · b3d2288a
      mitz@apple.com authored
              Reviewed by Sam Weinig.
      
              - use the LastResort font for missing glyphs instead of showing the
                primary font's missing glyph
      
              Test: platform/mac/fast/text/last-resort-font.html
      
              * platform/graphics/mac/FontCacheMac.mm:
              (WebCore::FontCache::getFontDataForCharacters): Changed to return the
              last resort font if a substitute font cannot be found.
              (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated
              comment (the user's preferred standard font is included in the search
              thanks to code in FontCache::getFontData()) and changed to return the
              LastResort font.  
      
      LayoutTests:
      
              Reviewed by Sam Weinig.
      
              - test that the LastResort font is used for missing glyphs rather than
                the primary font's missing glyph
      
              * platform/mac/fast/text/last-resort-font-expected.checksum: Added.
              * platform/mac/fast/text/last-resort-font-expected.png: Added.
              * platform/mac/fast/text/last-resort-font-expected.txt: Added.
              * platform/mac/fast/text/last-resort-font.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3d2288a
  16. 04 Sep, 2008 2 commits
    • mitz@apple.com's avatar
      WebCore: · 20268544
      mitz@apple.com authored
              Reviewed by Beth Dakin.
      
              - fix <rdar://problem/6198514> Changing a button's opacity triggers relayout
      
              Test: fast/repaint/button-spurious-layout-hint.html
      
              * rendering/RenderButton.cpp:
              (WebCore::RenderButton::setStyle): Reset the inner block's style box
              flex to 0 to avoid getting a spurious layout hint. 
      
      LayoutTests:
      
              Reviewed by Beth Dakin.
      
              - pixel test for <rdar://problem/6198514> Changing a button's opacity triggers relayout
      
              * fast/repaint/button-spurious-layout-hint.html: Added.
              * platform/mac/fast/repaint/button-spurious-layout-hint-expected.checksum: Added.
              * platform/mac/fast/repaint/button-spurious-layout-hint-expected.png: Added.
              * platform/mac/fast/repaint/button-spurious-layout-hint-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20268544
    • mitz@apple.com's avatar
      WebCore: · 89557c51
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=19717
                <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
              positioned movement only case, call
              tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
              layout if that fails.
              (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
              * rendering/RenderBox.h:
              (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
              layoutDoingPositionedMovementOnly to this, and made this function
              check if the width changed. If it did, return, leaving the object
              dirty. The caller can then call layout(). The width can change even
              in the "positioned movement only" case if the object is shrink-to-fit
              and the available width constraint is met. (This was the case in the
              bug).
              * rendering/RenderObject.h:
              (WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
              Renamed layoutDoingPositionedMovementOnly() to this.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test for https://bugs.webkit.org/show_bug.cgi?id=19717
                <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
      
              * fast/block/positioning/move-with-auto-width.html: Added.
              * platform/mac/fast/block/positioning/move-with-auto-width-expected.checksum: Added.
              * platform/mac/fast/block/positioning/move-with-auto-width-expected.png: Added.
              * platform/mac/fast/block/positioning/move-with-auto-width-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89557c51
  17. 03 Sep, 2008 4 commits
    • hyatt@apple.com's avatar
      WebCore: · 4b38ed82
      hyatt@apple.com authored
      2008-09-03  David Hyatt  <hyatt@apple.com>
      
              Fix for bug 18203, right floats should be allowed to overflow past the left border edge.
      
              Reviewed by Darin (ages ago)
      
              Added fast/block/float/clamped-right-float.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::positionNewFloats):
      
      LayoutTests:
      
      2008-09-03  David Hyatt  <hyatt@apple.com>
      
              Fix for bug 18203.
      
              Reviewed by Darin (ages ago).
      
              * fast/block/float/clamped-right-float.html: Added.
              * platform/mac/fast/block/float/clamped-right-float-expected.checksum: Added.
              * platform/mac/fast/block/float/clamped-right-float-expected.png: Added.
              * platform/mac/fast/block/float/clamped-right-float-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b38ed82
    • hyatt@apple.com's avatar
      WebCore: · afe62056
      hyatt@apple.com authored
      2008-09-02  David Hyatt  <hyatt@apple.com>
      
              Add support for canvas text drawing APIs.
      
              Reviewed by olliej
      
              Tests added as fast/canvas/canvas-text-*.html
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
              (WebCore::JSCanvasRenderingContext2D::fillText):
              (WebCore::JSCanvasRenderingContext2D::strokeText):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::initForStyleResolve):
              (WebCore::CSSStyleSelector::applyPropertyToStyle):
              * css/CSSStyleSelector.h:
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::State::State):
              (WebCore::CanvasRenderingContext2D::font):
              (WebCore::CanvasRenderingContext2D::setFont):
              (WebCore::CanvasRenderingContext2D::textAlign):
              (WebCore::CanvasRenderingContext2D::setTextAlign):
              (WebCore::CanvasRenderingContext2D::textBaseline):
              (WebCore::CanvasRenderingContext2D::setTextBaseline):
              (WebCore::CanvasRenderingContext2D::fillText):
              (WebCore::CanvasRenderingContext2D::strokeText):
              (WebCore::CanvasRenderingContext2D::measureText):
              (WebCore::CanvasRenderingContext2D::drawTextInternal):
              (WebCore::CanvasRenderingContext2D::accessFont):
              * html/CanvasRenderingContext2D.h:
              * html/CanvasRenderingContext2D.idl:
              * html/TextMetrics.h: Added.
              (WebCore::TextMetrics::create):
              (WebCore::TextMetrics::width):
              (WebCore::TextMetrics::setWidth):
              (WebCore::TextMetrics::TextMetrics):
              * html/TextMetrics.idl: Added.
              * platform/graphics/Font.cpp:
              (WebCore::Font::lineGap):
              * platform/graphics/Font.h:
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::drawBidiText):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/GraphicsTypes.cpp:
              (WebCore::textAlignName):
              (WebCore::parseTextAlign):
              (WebCore::textBaselineName):
              (WebCore::parseTextBaseline):
              * platform/graphics/GraphicsTypes.h:
              (WebCore::):
      
      LayoutTests:
      
      2008-09-02  David Hyatt  <hyatt@apple.com>
      
              Add support for the canvas text APIs.
      
              Reviewed by olliej
      
              * fast/canvas/canvas-text-alignment.html: Added.
              * fast/canvas/canvas-text-baseline.html: Added.
              * platform/mac/fast/canvas/canvas-text-alignment-expected.checksum: Added.
              * platform/mac/fast/canvas/canvas-text-alignment-expected.png: Added.
              * platform/mac/fast/canvas/canvas-text-alignment-expected.txt: Added.
              * platform/mac/fast/canvas/canvas-text-baseline-expected.checksum: Added.
              * platform/mac/fast/canvas/canvas-text-baseline-expected.png: Added.
              * platform/mac/fast/canvas/canvas-text-baseline-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afe62056
    • adele@apple.com's avatar
      WebCore: · 643616bc
      adele@apple.com authored
      2008-09-03  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Test: fast/forms/search-display-none-cancel-button.html
      
              Allow display:none to work on a search field's cancel button.  Prepare for adding more style-ability for the results button too.
      
              * css/html4.css: Set display:inline-block for these buttons.  Now they can be overridden by a web author.
      
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
              (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly.  This is now done in html4.css.
              (WebCore::RenderTextControl::createCancelButtonStyle): ditto.
              (WebCore::RenderTextControl::createSubtreeIfNeeded):
              Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
              (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
              (WebCore::RenderTextControl::subtreeHasChanged): ditto.
              (WebCore::RenderTextControl::calcHeight): ditto.
              (WebCore::RenderTextControl::nodeAtPoint): ditto.
              (WebCore::RenderTextControl::layout): ditto.
              (WebCore::RenderTextControl::calcPrefWidths): ditto.
              (WebCore::RenderTextControl::clientPaddingLeft): ditto.
              (WebCore::RenderTextControl::clientPaddingRight): ditto.
      
              * rendering/TextControlInnerElements.cpp:
              (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
              (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
              (WebCore::TextControlInnerElement::attachInnerElement): Added.
               This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
              (WebCore::TextControlInnerTextElement::createRenderer): Added.  Creates a RenderTextControlInnerBlock.
              * rendering/TextControlInnerElements.h:
      
      LayoutTests:
      
      2008-09-03  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Test that display:none works on a search field's cancel button.
      
              * fast/forms/search-display-none-cancel-button.html: Added.
              * platform/mac/fast/forms/search-display-none-cancel-button-expected.checksum: Added.
              * platform/mac/fast/forms/search-display-none-cancel-button-expected.png: Added.
              * platform/mac/fast/forms/search-display-none-cancel-button-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      643616bc
    • mrowe@apple.com's avatar
      2008-09-02 Robert Blaut <webkit@blaut.biz> · e344ad00
      mrowe@apple.com authored
              Reviewed by Geoff Garen.
      
              Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
              Misplaced elements should not close DL lists.
      
              Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleError):
      
      2008-09-02  Robert Blaut  <webkit@blaut.biz>
      
              Reviewed by Geoff Garen.
      
              Test for <https://bugs.webkit.org/show_bug.cgi?id=16913>
              Misplaced elements should not close DL lists.
      
              * fast/invalid/test-case-tr-th-td-should-not-close-dl-list-expected.txt: Added.
              * fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html: Added.
              * platform/mac/fast/invalid/missing-dl-end-tag-expected.checksum:
              * platform/mac/fast/invalid/missing-dl-end-tag-expected.png:
              * platform/mac/fast/invalid/missing-dl-end-tag-expected.txt:
              * platform/mac/fast/invalid/missing-dt-end-tag-expected.checksum:
              * platform/mac/fast/invalid/missing-dt-end-tag-expected.png:
              * platform/mac/fast/invalid/missing-dt-end-tag-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e344ad00
  18. 23 Aug, 2008 1 commit
    • mitz@apple.com's avatar
      WebCore: · 57a2f48f
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
      
              Test: fast/table/vertical-align-baseline.html
      
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
              baseline of the first table row, if there is one, -1 otherwise.
              * rendering/RenderTable.h:
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::baselinePosition): Changed to follow the
              CSS2.1 definition of the baseline of a table cell.
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
              the baseline of the first row in the section.
              * rendering/RenderTableSection.h:
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test and updated results for <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
      
              * fast/table/vertical-align-baseline.html: Added.
              * platform/mac/fast/table/form-with-table-style-expected.checksum:
              * platform/mac/fast/table/form-with-table-style-expected.png:
              * platform/mac/fast/table/form-with-table-style-expected.txt:
              * platform/mac/fast/table/vertical-align-baseline-expected.checksum: Added.
              * platform/mac/fast/table/vertical-align-baseline-expected.png: Added.
              * platform/mac/fast/table/vertical-align-baseline-expected.txt: Added.
              * platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:
              * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
              * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
              * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57a2f48f
  19. 22 Aug, 2008 1 commit
    • mitz@apple.com's avatar
      WebCore: · 9befc87e
      mitz@apple.com authored
              Reviewed by Jon Honeycutt and Alexey Proskuryakov.
      
              - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
      
              Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
      
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
              ascent and 100% to its reported descent.
      
      LayoutTests:
      
              Reviewed by Jon Honeycutt and Alexey Proskuryakov.
      
              - test for <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
      
              * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Added.
              * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
              * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
              * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9befc87e
  20. 18 Aug, 2008 3 commits
    • mitz@apple.com's avatar
      WebCore: · 12404d8a
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
      
              Test: fast/replaced/max-width-percent.html
      
              Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
              When false, max-width is not factored into the
              calculation.
              Changed RenderReplaced and subclasses' calcPrefWidths() to call
              calcReplacedWidth(false) and then apply max-width only if it has a
              fixed, positive value.
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcReplacedWidth):
              * rendering/RenderBox.h:
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::calcReplacedWidth):
              (WebCore::RenderImage::calcPrefWidths): 
              * rendering/RenderImage.h:
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::calcPrefWidths):
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::calcPrefWidths):
              * rendering/RenderVideo.cpp:
              (WebCore::RenderVideo::calcReplacedWidth):
              (WebCore::RenderVideo::calcPrefWidths):
              * rendering/RenderVideo.h:
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test for <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
      
              * fast/replaced/max-width-percent.html: Added.
              * platform/mac/fast/replaced/max-width-percent-expected.checksum: Added.
              * platform/mac/fast/replaced/max-width-percent-expected.png: Added.
              * platform/mac/fast/replaced/max-width-percent-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12404d8a
    • simon.fraser@apple.com's avatar
      Make transition_shorthand_parsing.html a text-only test. · 360301f1
      simon.fraser@apple.com authored
              * fast/css/transition_shorthand_parsing-expected.txt: Added.
              * fast/css/transition_shorthand_parsing.html:
              * platform/mac/fast/css/transition_shorthand_parsing-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      360301f1
    • simon.fraser@apple.com's avatar
      Reviewed by Dave Hyatt · 6040db39
      simon.fraser@apple.com authored
              Need to make sure we have an Animation in the AnimationList
              before setting the initial value.
              https://bugs.webkit.org/show_bug.cgi?id=20408
      
              Test: fast/css/transition_shorthand_parsing.html
      
              * css/CSSStyleSelector.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6040db39
  21. 14 Aug, 2008 2 commits
  22. 12 Aug, 2008 1 commit
    • mitz@apple.com's avatar
      WebCore: · 1e09cd78
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=19348
                <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
      
              Test: fast/frames/frameset-style-recalc.html
      
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base
              class implementation after marking for layout.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for https://bugs.webkit.org/show_bug.cgi?id=19348
                <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
      
              * fast/frames/frameset-style-recalc.html: Added.
              * platform/mac/fast/frames/frameset-style-recalc-expected.checksum: Added.
              * platform/mac/fast/frames/frameset-style-recalc-expected.png: Added.
              * platform/mac/fast/frames/frameset-style-recalc-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e09cd78
  23. 11 Aug, 2008 1 commit
    • mitz@apple.com's avatar
      WebCore: · 3f0060f8
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
      
              Test: fast/css/counters/invalidate-cached-counter-node.html
      
              * rendering/RenderContainer.cpp:
              (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all
              RenderCounters in :before and :after content.
              * rendering/RenderContainer.h:
              * rendering/RenderCounter.cpp:
              (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this
              to match the RenderObject method.
              (WebCore::RenderCounter::invalidate): Added. Resets the cached
              CounterNode and invalidates the object's layout and preferred widths.
              (WebCore::destroyCounterNodeChildren): Added a call to
              invalidateCounters().
              * rendering/RenderCounter.h:
              * rendering/RenderObject.h:
              (WebCore::RenderObject::invalidateCounters):
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
      
              * fast/css/counters/invalidate-cached-counter-node.html: Added.
              * platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.checksum: Added.
              * platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.png: Added.
              * platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f0060f8
  24. 06 Aug, 2008 1 commit
    • ddkilzer@apple.com's avatar
      WebCore: · d5bccb54
      ddkilzer@apple.com authored
              Images using QT plugin do not display correctly
      
              <https://bugs.webkit.org/show_bug.cgi?id=9214>
              <rdar://problem/5683413>
      
              Reviewed by Darin.
      
              Tests: fast/images/embed-image.html
                     fast/images/object-image.html
      
              Use RenderImage instead of RenderPartObject for a renderer when
              the <embed> tag references an image.  Extract common code from
              HTMLEmbedElement and HTMLObjectElement into HTMLPlugInImageElement.
      
              * WebCore.xcodeproj/project.pbxproj: Added new source files.
      
              * html/HTMLEmbedElement.cpp: Cleaned up #include statements.
              (WebCore::HTMLEmbedElement::HTMLEmbedElement): Extend
              HTMLPlugInImageElement which extends HTMLPlugInElement.
              (WebCore::HTMLEmbedElement::parseMappedAttribute): Split codeAttr
              and srcAttr cases.  Create or clear HTMLImageLoader as needed for
              srcAttr.
              (WebCore::HTMLEmbedElement::rendererIsNeeded): Use
              HTMLPlugInElement::rendererIsNeeded() for images.
              (WebCore::HTMLEmbedElement::createRenderer): Create a
              RenderImage instead of a RenderPartObject for images.
              (WebCore::HTMLEmbedElement::attach): Create HTMLImageLoader,
              load image and populate RenderImage for images.
              (WebCore::HTMLEmbedElement::updateWidget): Don't call
              RenderPartObject::updateWidget() for images.
              (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added.
              * html/HTMLEmbedElement.h: Removed unneeded namespace and class
              declarations.  Extend HTMLPlugInImageElement which extends
              HTMLPlugInElement.
              (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added.
              (WebCore::HTMLEmbedElement::serviceType): Moved to
              HTMLPlugInImageElement.
              (WebCore::HTMLEmbedElement::url): Ditto.
      
              * html/HTMLObjectElement.cpp: Cleaned up #include statements.
              (WebCore::HTMLObjectElement::attach): Removed local variable.
              (WebCore::HTMLObjectElement::isImageType): Moved to
              HTMLPlugInImageElement.
              * html/HTMLObjectElement.h: Extend HTMLPlugInImageElement which
              extends HTMLPlugInElement.
              (WebCore::HTMLObjectElement::isImageType): Moved to
              HTMLPlugInImageElement.
              (WebCore::HTMLObjectElement::serviceType): Ditto.
              (WebCore::HTMLObjectElement::url): Ditto.
      
              * html/HTMLPlugInImageElement.cpp: Added.
              (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Added.
              (WebCore::HTMLPlugInImageElement::~HTMLPlugInImageElement): Added.
              (WebCore::HTMLPlugInImageElement::isImageType): Moved from
              HTMLObjectElement.
              * html/HTMLPlugInImageElement.h: Added.
              (WebCore::HTMLPlugInImageElement::isImageType): Added from
              HTMLObjectElement.
              (WebCore::HTMLPlugInImageElement::serviceType): Ditto.
              (WebCore::HTMLPlugInImageElement::url): Ditto.
      
              * rendering/HitTestResult.cpp:
              (WebCore::HitTestResult::absoluteImageURL): Return urlString
              for embed elements with images.
      
      LayoutTests:
      
              Images using QT plugin do not display correctly
      
              <https://bugs.webkit.org/show_bug.cgi?id=9214>
              <rdar://problem/5683413>
      
              Reviewed by Darin.
      
              Test images rendered by both embed and object elements.
      
              * fast/images/embed-image.html: Added.
              * fast/images/object-image.html: Added.
              * platform/mac/fast/images/embed-image-expected.checksum: Added.
              * platform/mac/fast/images/embed-image-expected.png: Added.
              * platform/mac/fast/images/embed-image-expected.txt: Added.
              * platform/mac/fast/images/object-image-expected.checksum: Added.
              * platform/mac/fast/images/object-image-expected.png: Added.
              * platform/mac/fast/images/object-image-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5bccb54
  25. 29 Jul, 2008 4 commits
    • mitz@apple.com's avatar
      WebCore: · 3fce1b33
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com
      
              Test: fast/overflow/float-in-relpositioned.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::lowestPosition): Add this block's relative offset
              to floats' and positioned objects' lowest position.
              (WebCore::RenderBlock::rightmostPosition): Ditto.
              (WebCore::RenderBlock::leftmostPosition): Ditto.
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::lowestPosition): Removed redundant test.
              (WebCore::RenderBox::rightmostPosition): Ditto.
              (WebCore::RenderBox::leftmostPosition): Ditto.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test, updated test and results for <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com
      
              * fast/overflow/float-in-relpositioned.html: Added.
              * fast/repaint/containing-block-position-change.html: Changed to avoid
              a full repaint due to a scroll bar appearing.
              * platform/mac/fast/clip/015-expected.txt:
              * platform/mac/fast/overflow/float-in-relpositioned-expected.checksum: Added.
              * platform/mac/fast/overflow/float-in-relpositioned-expected.png: Added.
              * platform/mac/fast/overflow/float-in-relpositioned-expected.txt: Added.
              * platform/mac/fast/repaint/clipped-relative-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fce1b33
    • mitz@apple.com's avatar
      WebCore: · 72cc551d
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/6048566> Repaint original element's position, not its offset position
      
              Test: fast/repaint/layout-state-relative.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::absolutePosition): Changed the LayoutState-enabled
              code path to account for the object's relative offset.
              (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - repaint test for <rdar://problem/6048566> Repaint original element's position, not its offset position
      
              * fast/repaint/layout-state-relative.html: Added.
              * platform/mac/fast/repaint/layout-state-relative-expected.checksum: Added.
              * platform/mac/fast/repaint/layout-state-relative-expected.png: Added.
              * platform/mac/fast/repaint/layout-state-relative-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72cc551d
    • hyatt@apple.com's avatar
      · 88d618bf
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88d618bf
    • hyatt@apple.com's avatar
      2008-07-29 David Hyatt <hyatt@apple.com> · 41445e75
      hyatt@apple.com authored
              Add a layout test for using multiple variable declaration blocks in a single style rule.
      
              * fast/css/variables/alternate-syntax/multiple-blocks-test.html: Added.
              * fast/css/variables/multiple-blocks-test.html: Added.
              * platform/mac/fast/css/variables/multiple-blocks-test-expected.checksum: Added.
              * platform/mac/fast/css/variables/multiple-blocks-test-expected.png: Added.
              * platform/mac/fast/css/variables/multiple-blocks-test-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41445e75