1. 24 Oct, 2008 2 commits
  2. 23 Oct, 2008 4 commits
    • kmccullough@apple.com's avatar
      2008-10-23 Kevin McCullough <kmccullough@apple.com> · b7fd8c75
      kmccullough@apple.com authored
              Forgot to remove the tests from the skipped lists, this should have been
              apart of the last checkin.
      
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7fd8c75
    • mitz@apple.com's avatar
      WebCore: · 83d2e872
      mitz@apple.com authored
              Reviewed by Sam Weinig with no hesitation.
      
              - fix the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
                <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering
      
              Test: fast/text/bidi-embedding-pop-and-push-same.html
      
              * platform/text/BidiResolver.h:
              (WebCore::BidiResolver::embed): Changed to only add the embedding
              operation to a vector of pending operations.
      
              (WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Added. Moved the
              code that used to be in the PDF case of embed() here, except the part
              that sets the context.
      
              (WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Added. Moved the
              code that used to be in the non-PDF case of embed() here, except the
              part the sets the context.
      
              (WebCore::BidiResolver::commitExplicitEmbedding): Added. Processes the
              explicit embedding operations in the vector by creating an updated
              context and determining the old and new embedding levels. If the levels
              are not the same, calls {lower,raise}ExplicitEmbeddingLevel(). Always
              sets the context to the new one.
      
              (WebCore::BidiResolver::createBidiRunsForLine): Added calls to
              commitExplicitEmbedding() after calling embed() and after calling
              increment().
      
              * rendering/bidi.cpp:
              (WebCore::bidiFirst): Added calls to commitExplicitEmbedding() because
              this function increments the resolver.
      
              (WebCore::RenderBlock::skipLeadingWhitespace): Ditto.
      
      LayoutTests:
      
              Reviewed by Sam Weinig with no hesitation.
      
              - test for the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
                <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering
      
              * fast/text/bidi-embedding-pop-and-push-same.html: Added.
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83d2e872
    • darin@apple.com's avatar
      2008-10-23 Darin Adler <darin@apple.com> · bce3fd68
      darin@apple.com authored
              - try to get buildbot green again
      
              * platform/gtk/Skipped: Added fast/profiler.
              * platform/mac/Skipped: Fixed typo: fast/profiler, not fast/profile.
              * platform/qt/Skipped: Added fast/profiler.
              * platform/win/Skipped: Fixed typo: fast/profiler, not fast/profile.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bce3fd68
    • kmccullough@apple.com's avatar
      WebCore: · d7e4bf7f
      kmccullough@apple.com authored
      2008-10-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Tim Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=21817
              Bug 21817: Manual profiler tests should be made into layout tests
      
              -Moving the tests before diffing so that it's clear what changed.
      
              * manual-tests/inspector/profiler-test-anonymous-event-handler.html: Removed.
              * manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html: Removed.
              * manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html: Removed.
              * manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html: Removed.
              * manual-tests/inspector/profiler-test-apply.html: Removed.
              * manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html: Removed.
              * manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html: Removed.
              * manual-tests/inspector/profiler-test-call-nodelist-as-function.html: Removed.
              * manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
              * manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Removed.
              * manual-tests/inspector/profiler-test-constructor.html: Removed.
              * manual-tests/inspector/profiler-test-dead-time.html: Removed.
              * manual-tests/inspector/profiler-test-deep-recursion.html: Removed.
              * manual-tests/inspector/profiler-test-document-dot-write.html: Removed.
              * manual-tests/inspector/profiler-test-event-handler.html: Removed.
              * manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html: Removed.
              * manual-tests/inspector/profiler-test-heavy-view.html: Removed.
              * manual-tests/inspector/profiler-test-inline-event-handler.html: Removed.
              * manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html: Removed.
              * manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html: Removed.
              * manual-tests/inspector/profiler-test-multiple-frames.html: Removed.
              * manual-tests/inspector/profiler-test-multiple-windows.html: Removed.
              * manual-tests/inspector/profiler-test-nested-anonymous-functon.html: Removed.
              * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html: Removed.
              * manual-tests/inspector/profiler-test-no-execution-context.html: Removed.
              * manual-tests/inspector/profiler-test-one-execution-context.html: Removed.
              * manual-tests/inspector/profiler-test-profile-calls-in-included-file.html: Removed.
              * manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
              * manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html: Removed.
              * manual-tests/inspector/profiler-test-simple-event-call.html: Removed.
              * manual-tests/inspector/profiler-test-simple-no-level-change.html: Removed.
              * manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html: Removed.
              * manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Removed.
              * manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Removed.
              * manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Removed.
              * manual-tests/inspector/profiler-test-stop-then-function-call.html: Removed.
              * manual-tests/inspector/profiler-test-throw-exception-from-eval.html: Removed.
              * manual-tests/inspector/profiler-test-two-execution-contexts.html: Removed.
              * manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html: Removed.
              * manual-tests/inspector/profiler-test-window-dot-eval.html: Removed.
              * manual-tests/inspector/resources/other-frame.html: Removed.
              * manual-tests/inspector/resources/other-window.html: Removed.
              * manual-tests/inspector/resources/profiler-test-JS-resources.js: Removed.
      
      LayoutTests:
      
      2008-10-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Tim Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=21817
              Bug 21817: Manual profiler tests should be made into layout tests
      
              -Moving the tests before diffing so that it's clear what changed.
      
              * platform/mac/Skipped: Skipping until the new files are in place.
              * platform/win/Skipped:
              * fast/profiler: Added.
              * fast/profiler/anonymous-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-event-handler.html.
              * fast/profiler/anonymous-function-called-from-different-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html.
              * fast/profiler/anonymous-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html.
              * fast/profiler/anonymous-function-calls-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html.
              * fast/profiler/apply.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-apply.html.
              * fast/profiler/built-in-function-calls-anonymous.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html.
              * fast/profiler/built-in-function-calls-user-defined-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html.
              * fast/profiler/call-nodelist-as-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-call-nodelist-as-function.html.
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html.
              * fast/profiler/compare-multiple-profiles.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-compare-multiple-profiles.html.
              * fast/profiler/constructor.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-constructor.html.
              * fast/profiler/dead-time.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-dead-time.html.
              * fast/profiler/deep-recursion.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-deep-recursion.html.
              * fast/profiler/document-dot-write.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-document-dot-write.html.
              * fast/profiler/event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-event-handler.html.
              * fast/profiler/execution-context-and-eval-on-same-line.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html.
              * fast/profiler/heavy-view.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-heavy-view.html.
              * fast/profiler/inline-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-inline-event-handler.html.
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html.
              * fast/profiler/multiple-and-different-scoped-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html.
              * fast/profiler/multiple-frames.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-frames.html.
              * fast/profiler/multiple-windows.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-windows.html.
              * fast/profiler/nested-anonymous-functon.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-anonymous-functon.html.
              * fast/profiler/nested-start-and-stop-profiler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html.
              * fast/profiler/no-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-no-execution-context.html.
              * fast/profiler/one-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-one-execution-context.html.
              * fast/profiler/profile-calls-in-included-file.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profile-calls-in-included-file.html.
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html.
              * fast/profiler/profiling-from-a-nested-location.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html.
              * fast/profiler/resources: Added.
              * fast/profiler/resources/other-frame.html: Copied from ../WebCore/manual-tests/inspector/resources/other-frame.html.
              * fast/profiler/resources/other-window.html: Copied from ../WebCore/manual-tests/inspector/resources/other-window.html.
              * fast/profiler/resources/profiler-test-JS-resources.js: Copied from ../WebCore/manual-tests/inspector/resources/profiler-test-JS-resources.js.
              * fast/profiler/simple-event-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-event-call.html.
              * fast/profiler/simple-no-level-change.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-no-level-change.html.
              * fast/profiler/start-and-stop-profiler-multiple-times.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html.
              * fast/profiler/start-and-stop-profiling-in-the-same-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html.
              * fast/profiler/start-but-dont-stop-profiling.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html.
              * fast/profiler/stop-profiling-after-setTimeout.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html.
              * fast/profiler/stop-then-function-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-then-function-call.html.
              * fast/profiler/throw-exception-from-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-throw-exception-from-eval.html.
              * fast/profiler/two-execution-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-two-execution-contexts.html.
              * fast/profiler/user-defined-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html.
              * fast/profiler/window-dot-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-window-dot-eval.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7e4bf7f
  3. 17 Oct, 2008 1 commit
    • pam@chromium.org's avatar
      2008-10-17 Pamela Greene <pam@chromium.org> · 9e076f28
      pam@chromium.org authored
              Add a number of new tests.
              See https://bugs.webkit.org/show_bug.cgi?id=21407
      
              Reviewed by Alexey Proskuryakov.
      
              * fast/css/border-height.html: Added.
              * fast/dom/Window/orphaned-frame-access-expected.txt: Added.
              * fast/dom/Window/orphaned-frame-access.html: Added.
              * fast/forms/image-border.html: Added.
              * fast/forms/input-field-text-truncated.html: Added.
              * fast/forms/input-type-text-min-width.html: Added.
              * fast/forms/textarea-scrollbar-height-expected.txt: Added.
              * fast/forms/textarea-scrollbar-height.html: Added.
              * fast/forms/textarea-width.html: Added.
              * fast/overflow/overflow_hidden.html: Added.
              * fast/parser/resources/xml-declaration-missing-ending-mark.xml: Added.
              * fast/parser/xml-declaration-missing-ending-mark-expected.txt: Added.
              * fast/parser/xml-declaration-missing-ending-mark.html: Added.
              * fast/text/international/hindi-spacing.html: Added.
              * http/tests/misc/crash-multiple-family-fontface-expected.txt: Added.
              * http/tests/misc/crash-multiple-family-fontface.html: Added.
              * platform/mac/fast/css/border-height-expected.checksum: Added.
              * platform/mac/fast/css/border-height-expected.png: Added.
              * platform/mac/fast/css/border-height-expected.txt: Added.
              * platform/mac/fast/forms/image-border-expected.checksum: Added.
              * platform/mac/fast/forms/image-border-expected.png: Added.
              * platform/mac/fast/forms/image-border-expected.txt: Added.
              * platform/mac/fast/forms/input-field-text-truncated-expected.checksum: Added.
              * platform/mac/fast/forms/input-field-text-truncated-expected.png: Added.
              * platform/mac/fast/forms/input-field-text-truncated-expected.txt: Added.
              * platform/mac/fast/forms/input-type-text-min-width-expected.checksum: Added.
              * platform/mac/fast/forms/input-type-text-min-width-expected.png: Added.
              * platform/mac/fast/forms/input-type-text-min-width-expected.txt: Added.
              * platform/mac/fast/forms/textarea-width-expected.checksum: Added.
              * platform/mac/fast/forms/textarea-width-expected.png: Added.
              * platform/mac/fast/forms/textarea-width-expected.txt: Added.
              * platform/mac/fast/overflow/overflow_hidden-expected.checksum: Added.
              * platform/mac/fast/overflow/overflow_hidden-expected.png: Added.
              * platform/mac/fast/overflow/overflow_hidden-expected.txt: Added.
              * platform/mac/fast/text/international/hindi-spacing-expected.checksum: Added.
              * platform/mac/fast/text/international/hindi-spacing-expected.png: Added.
              * platform/mac/fast/text/international/hindi-spacing-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e076f28
  4. 14 Oct, 2008 1 commit
    • hyatt@apple.com's avatar
      WebCore: · bf26cc09
      hyatt@apple.com authored
      2008-10-14  David Hyatt  <hyatt@apple.com>
      
              https://bugs.webkit.org/show_bug.cgi?id=21595
      
              Clean up background and overflow propagation from the body to the viewport.  Make it match the
              latest CSS2.1 spec thinking.
      
              Reviewed by Adam Roben
      
              Added many tests at fast/body-propagation/.  These are Simon Pieters' tests of propagation handling
              (available at http://simon.html5.org/test/css/magic-body/).
      
              * dom/Document.cpp:
              (WebCore::Document::body):
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::styleDidChange):
              (WebCore::RenderBox::paintRootBoxDecorations):
              (WebCore::RenderBox::paintBoxDecorations):
              (WebCore::RenderBox::repaintLayerRectsForImage):
      
      LayoutTests:
      
      2008-10-14  David Hyatt  <hyatt@apple.com>
      
              Add layout tests for body propagation of overflow and background to the viewport.
      
              Reviewed by Adam Roben
      
              * fast/body-propagation: Added.
              * fast/body-propagation/background-color: Added.
              * fast/body-propagation/background-color/001-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/001.html: Added.
              * fast/body-propagation/background-color/002-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/002.html: Added.
              * fast/body-propagation/background-color/003-declarative.xhtml: Added.
              * fast/body-propagation/background-color/003-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/003.html: Added.
              * fast/body-propagation/background-color/004-declarative.xhtml: Added.
              * fast/body-propagation/background-color/004-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/004.html: Added.
              * fast/body-propagation/background-color/005-declarative.xhtml: Added.
              * fast/body-propagation/background-color/005-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/005.html: Added.
              * fast/body-propagation/background-color/006-declarative.xhtml: Added.
              * fast/body-propagation/background-color/006-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/006.html: Added.
              * fast/body-propagation/background-color/007-declarative.xhtml: Added.
              * fast/body-propagation/background-color/007-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/007.html: Added.
              * fast/body-propagation/background-color/008-xhtml.xhtml: Added.
              * fast/body-propagation/background-color/008.html: Added.
              * fast/body-propagation/background-image: Added.
              * fast/body-propagation/background-image/001-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/001.html: Added.
              * fast/body-propagation/background-image/002-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/002.html: Added.
              * fast/body-propagation/background-image/003-declarative.xhtml: Added.
              * fast/body-propagation/background-image/003-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/003.html: Added.
              * fast/body-propagation/background-image/004-declarative.xhtml: Added.
              * fast/body-propagation/background-image/004-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/004.html: Added.
              * fast/body-propagation/background-image/005-declarative.xhtml: Added.
              * fast/body-propagation/background-image/005-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/005.html: Added.
              * fast/body-propagation/background-image/006-declarative.xhtml: Added.
              * fast/body-propagation/background-image/006-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/006.html: Added.
              * fast/body-propagation/background-image/007-declarative.xhtml: Added.
              * fast/body-propagation/background-image/007-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/007.html: Added.
              * fast/body-propagation/background-image/008-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/008.html: Added.
              * fast/body-propagation/background-image/009-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/009.html: Added.
              * fast/body-propagation/background-image/010-xhtml.xhtml: Added.
              * fast/body-propagation/background-image/010.html: Added.
              * fast/body-propagation/background-image/resources: Added.
              * fast/body-propagation/background-image/resources/lime.png: Added.
              * fast/body-propagation/background-image/resources/red.png: Added.
              * fast/body-propagation/background-image/resources/white.png: Added.
              * fast/body-propagation/background-image/resources/yellow.png: Added.
              * fast/body-propagation/overflow: Added.
              * fast/body-propagation/overflow/001-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/001.html: Added.
              * fast/body-propagation/overflow/002-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/002.html: Added.
              * fast/body-propagation/overflow/003-declarative.xhtml: Added.
              * fast/body-propagation/overflow/003-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/003.html: Added.
              * fast/body-propagation/overflow/004-declarative.xhtml: Added.
              * fast/body-propagation/overflow/004-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/004.html: Added.
              * fast/body-propagation/overflow/005-declarative.xhtml: Added.
              * fast/body-propagation/overflow/005-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/005.html: Added.
              * fast/body-propagation/overflow/006-declarative.xhtml: Added.
              * fast/body-propagation/overflow/006-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/006.html: Added.
              * fast/body-propagation/overflow/007-declarative.xhtml: Added.
              * fast/body-propagation/overflow/007-xhtml.xhtml: Added.
              * fast/body-propagation/overflow/007.html: Added.
              * platform/mac/fast/body-propagation: Added.
              * platform/mac/fast/body-propagation/background-color: Added.
              * platform/mac/fast/body-propagation/background-color/001-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/001-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/001-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/001-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/001-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/001-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/002-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/002-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/002-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/002-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/002-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/002-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/003-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/003-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/003-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/003-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/003-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/003-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/003-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/003-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/003-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/004-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/004-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/004-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/004-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/004-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/004-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/004-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/004-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/004-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/005-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/005-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/005-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/005-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/005-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/005-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/005-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/005-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/005-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/006-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/006-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/006-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/006-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/006-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/006-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/006-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/006-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/006-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/007-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/007-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/007-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/007-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/007-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/007-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/007-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/007-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/007-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/008-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/008-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/008-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-color/008-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-color/008-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-color/008-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image: Added.
              * platform/mac/fast/body-propagation/background-image/001-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/001-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/001-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/001-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/001-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/001-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/002-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/002-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/002-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/002-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/002-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/002-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/003-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/003-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/003-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/003-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/003-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/003-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/003-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/003-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/003-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/004-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/004-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/004-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/004-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/004-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/004-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/004-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/004-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/004-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/005-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/005-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/005-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/005-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/005-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/005-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/005-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/005-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/005-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/006-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/006-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/006-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/006-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/006-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/006-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/006-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/006-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/006-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/007-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/007-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/007-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/007-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/007-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/007-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/007-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/007-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/007-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/008-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/008-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/008-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/008-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/008-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/008-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/009-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/009-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/009-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/009-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/009-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/009-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/010-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/010-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/010-expected.txt: Added.
              * platform/mac/fast/body-propagation/background-image/010-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/background-image/010-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/background-image/010-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow: Added.
              * platform/mac/fast/body-propagation/overflow/001-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/001-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/001-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/001-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/001-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/001-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/002-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/002-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/002-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/003-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/003-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/003-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/003-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/003-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/004-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/004-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/004-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/004-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/004-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/005-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/005-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/005-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/005-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/005-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/005-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/005-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/005-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/005-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/006-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/006-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/006-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/006-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/006-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/006-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/006-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/006-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/006-xhtml-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/007-declarative-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/007-declarative-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/007-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/007-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/007-expected.txt: Added.
              * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum: Added.
              * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png: Added.
              * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf26cc09
  5. 13 Oct, 2008 2 commits
    • hyatt@apple.com's avatar
      WebCore: · 456dd87f
      hyatt@apple.com authored
      2008-10-13  David Hyatt  <hyatt@apple.com>
      
              Make RenderListBox work with CSS scrollbars.  Refactoring this code to support creation/destruction in
              the same way RenderLayer does also fixes a bug where the PLT would assert on the next-to-last page (no
              idea how to make a test case for that, though, since I couldn't repro without running the whole PLT).
      
              Reviewed by Tim Hatcher
      
              Added scrollbars/listbox-scrollbar-combinations.html
      
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::~RenderListBox):
              (WebCore::RenderListBox::updateFromElement):
              (WebCore::RenderListBox::createScrollbar):
              (WebCore::RenderListBox::destroyScrollbar):
              (WebCore::RenderListBox::setHasVerticalScrollbar):
              * rendering/RenderListBox.h:
      
      LayoutTests:
      
      2008-10-13  David Hyatt  <hyatt@apple.com>
      
              Add test case for custom CSS listbox scrollbars.
      
              Reviewed by Tim Hatcher
      
              * platform/mac/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
              * platform/mac/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
              * platform/mac/scrollbars/listbox-scrollbar-combinations-expected.txt: Added.
              * scrollbars/listbox-scrollbar-combinations.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      456dd87f
    • timothy@apple.com's avatar
      Adds an complex styled scrollbar test that exercises all... · 3cd5ad92
      timothy@apple.com authored
              Adds an complex styled scrollbar test that exercises all pseudo-elements and pseudo-classes.
              Also uses positive and negative margins on the scrollbar track and track pieces.
              Tests all the combinations of scrollbars for overflow elements, with and without resizers.
      
              Rubber-stamped by Dave Hyatt.
      
              * platform/mac/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
              * platform/mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
              * platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt: Added.
              * scrollbars/overflow-scrollbar-combinations.html: Added.
              * scrollbars/resources: Added.
              * scrollbars/resources/corner-inactive.png: Added.
              * scrollbars/resources/corner.png: Added.
              * scrollbars/resources/horizontal-button-active.png: Added.
              * scrollbars/resources/horizontal-button-background-active.png: Added.
              * scrollbars/resources/horizontal-button-background-hover.png: Added.
              * scrollbars/resources/horizontal-button-background-inactive.png: Added.
              * scrollbars/resources/horizontal-button-background.png: Added.
              * scrollbars/resources/horizontal-button-hover.png: Added.
              * scrollbars/resources/horizontal-button-inactive.png: Added.
              * scrollbars/resources/horizontal-button.png: Added.
              * scrollbars/resources/horizontal-decrement-arrow.png: Added.
              * scrollbars/resources/horizontal-increment-arrow.png: Added.
              * scrollbars/resources/horizontal-thumb-active.png: Added.
              * scrollbars/resources/horizontal-thumb-hover.png: Added.
              * scrollbars/resources/horizontal-thumb-inactive.png: Added.
              * scrollbars/resources/horizontal-thumb.png: Added.
              * scrollbars/resources/horizontal-track-active.png: Added.
              * scrollbars/resources/horizontal-track-disabled.png: Added.
              * scrollbars/resources/horizontal-track-hover.png: Added.
              * scrollbars/resources/horizontal-track.png: Added.
              * scrollbars/resources/resizer-inactive.png: Added.
              * scrollbars/resources/resizer.png: Added.
              * scrollbars/resources/vertical-button-active.png: Added.
              * scrollbars/resources/vertical-button-background-active.png: Added.
              * scrollbars/resources/vertical-button-background-hover.png: Added.
              * scrollbars/resources/vertical-button-background-inactive.png: Added.
              * scrollbars/resources/vertical-button-background.png: Added.
              * scrollbars/resources/vertical-button-hover.png: Added.
              * scrollbars/resources/vertical-button-inactive.png: Added.
              * scrollbars/resources/vertical-button.png: Added.
              * scrollbars/resources/vertical-decrement-arrow.png: Added.
              * scrollbars/resources/vertical-increment-arrow.png: Added.
              * scrollbars/resources/vertical-thumb-active.png: Added.
              * scrollbars/resources/vertical-thumb-hover.png: Added.
              * scrollbars/resources/vertical-thumb-inactive.png: Added.
              * scrollbars/resources/vertical-thumb.png: Added.
              * scrollbars/resources/vertical-track-active.png: Added.
              * scrollbars/resources/vertical-track-disabled.png: Added.
              * scrollbars/resources/vertical-track-hover.png: Added.
              * scrollbars/resources/vertical-track.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cd5ad92
  6. 12 Oct, 2008 3 commits
    • darin@apple.com's avatar
      2008-10-12 Pamela Greene <pam@chromium.org> · 15c150b8
      darin@apple.com authored
              Reviewed by Darin Adler.
      
              - https://bugs.webkit.org/show_bug.cgi?id=21523
      
              Add tests to cover more gradient edge cases: missing endpoints, only
              endpoints, only one stop.
      
              * fast/canvas/fillrect_gradient.html:
              * platform/mac/fast/canvas/fillrect_gradient-expected.checksum:
              * platform/mac/fast/canvas/fillrect_gradient-expected.png:
              * platform/mac/fast/canvas/fillrect_gradient-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15c150b8
    • abarth@webkit.org's avatar
      2008-10-12 Pamela Greene <pam@chromium.org> · 230141c6
      abarth@webkit.org authored
              Fix a race condition by waiting for all create functions to be called
              before terminating.
              See https://bugs.webkit.org/show_bug.cgi?id=21531
      
              Reviewed by Darin Adler.
              Landed by Adam Barth.
      
              * platform/mac/svg/carto.net/window-expected.checksum:
              * platform/mac/svg/carto.net/window-expected.png:
              * platform/mac/svg/carto.net/window-expected.txt:
              * svg/carto.net/window.svg:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      230141c6
    • darin@apple.com's avatar
      WebCore: · ad096cad
      darin@apple.com authored
      2008-10-12  Glenn Wilson  <gwilson@google.com>
      
              Reviewed by Darin Adler.
      
              - https://bugs.webkit.org/show_bug.cgi?id=20461
      
              Added feature to allow multi-line inputs into text fields.
              HTMLInputElement would cut the set text at the first 'system' character,
              so it would truncate at the first carriage return or newline.
              This fix modifies that behavior to truncate at any non-space system character
              but changes \r, \n, and \r\n to a single space.
      
              Tests: editing/pasteboard/paste-multiline-text-input.html
                     
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::constrainValue):
      
      LayoutTests:
      
      2008-10-12  Glenn Wilson  <gwilson@google.com>
      
              Reviewed by Darin Adler.
      
              - https://bugs.webkit.org/show_bug.cgi?id=20461
      
              Added new test to verify that the user can cut and paste multiple lines of text
              into a single line text field.
      
              * fast/forms/paste-multiline-text-input-expected.txt: Added.
              * fast/forms/paste-multiline-text-input.html: Added.
              * fast/forms/input-truncate-newline-expected.txt: Removed.
              * fast/forms/input-truncate-newline.html: Removed.
      
              * fast/forms/8250-expected.txt: Added.
              * fast/forms/8250.html: Updated test to be text-only and expect new results.
              * platform/mac/fast/forms/8250-expected.checksum: Removed.
              * platform/mac/fast/forms/8250-expected.png: Removed.
              * platform/mac/fast/forms/8250-expected.txt: Removed.
              * platform/qt/fast/forms/8250-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad096cad
  7. 10 Oct, 2008 3 commits
    • timothy@apple.com's avatar
      Fixes a regression with input search fields, where the placeholder text · c1df5735
      timothy@apple.com authored
              would not be updated when the value of the placeholder attribute changed.
      
              https://bugs.webkit.org/show_bug.cgi?id=21521
      
              Reviewed by Adele Peterson.
      
              Test: fast/forms/search-placeholder-value-changed.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute): Pass true for the
              placeholderValueChanged parameter of updatePlaceholderVisibility.
              (WebCore::HTMLInputElement::updatePlaceholderVisibility): Add parameter
              for placeholderValueChanged that informs the method that the value changed.
              * html/HTMLInputElement.h: Add the placeholderValueChanged to the
              updatePlaceholderVisibility method. Made it default to false.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1df5735
    • hyatt@apple.com's avatar
      WebCore: · 676ab7fa
      hyatt@apple.com authored
      2008-10-10  David Hyatt  <hyatt@apple.com>
      
              https://bugs.webkit.org/show_bug.cgi?id=21522
      
              Support increment/decrement/start/end on scrollbars.  Allows a fully functional scrollbar to be
              created.  (Just :hover/:active left to finish it up.)
      
              Reviewed by Adam Roben
      
              Added scrollbars/scrollbar-buttons.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
      
      LayoutTests:
      
      2008-10-10  David Hyatt  <hyatt@apple.com>
      
              Add test for scrollbar buttons and track supporting increment/decrement/start/end.
      
              Reviewed by Adam Roben
      
              * platform/mac/scrollbars/scrollbar-buttons-expected.checksum: Added.
              * platform/mac/scrollbars/scrollbar-buttons-expected.png: Added.
              * platform/mac/scrollbars/scrollbar-buttons-expected.txt: Added.
              * scrollbars/scrollbar-buttons.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      676ab7fa
    • hyatt@apple.com's avatar
      WebCore: · e3803263
      hyatt@apple.com authored
      2008-10-09  David Hyatt  <hyatt@apple.com>
      
              Add support for scrollbar orientation as a pseudoclass.  Add support for whether or not the scrollbar
              is active as well.
      
              Reviewed by Tim Hatcher
      
              Added scrollbars/scrollbar-orientation.html
      
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
              * platform/Scrollbar.cpp:
              (WebCore::Scrollbar::isWindowActive):
              * platform/Scrollbar.h:
              * rendering/RenderScrollbar.cpp:
              (WebCore::RenderScrollbar::paint):
              (WebCore::RenderScrollbar::partForStyleResolve):
              * rendering/RenderScrollbar.h:
      
      LayoutTests:
      
      2008-10-09  David Hyatt  <hyatt@apple.com>
      
              Add layout test for scrollbars honoring orientation and window active state.
      
              Reviewed by Tim Hatcher
      
              * platform/mac/scrollbars/scrollbar-orientation-expected.checksum: Added.
              * platform/mac/scrollbars/scrollbar-orientation-expected.png: Added.
              * platform/mac/scrollbars/scrollbar-orientation-expected.txt: Added.
              * scrollbars/scrollbar-orientation.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3803263
  8. 09 Oct, 2008 3 commits
    • hyatt@apple.com's avatar
      WebCore: · e784a798
      hyatt@apple.com authored
      2008-10-09  David Hyatt  <hyatt@apple.com>
      
              Add support for pseudo classes on scrollbar pseudo elements.  As an initial proof of concept only
              :enabled/:disabled are supported.  More pseudo classes will follow quickly now that this works.
      
              Reviewed by Tim Hatcher
      
              Added scrollbars/disabled-scrollbar.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
              * css/CSSStyleSelector.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::getPseudoStyle):
              * rendering/RenderObject.h:
              * rendering/RenderScrollbar.cpp:
              (WebCore::RenderScrollbar::setEnabled):
              (WebCore::RenderScrollbar::scrollbarForStyleResolve):
              (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
              (WebCore::RenderScrollbar::paintPart):
              * rendering/RenderScrollbar.h:
      
      LayoutTests:
      
      2008-10-09  David Hyatt  <hyatt@apple.com>
      
              Add test case for disabled scrollbars.
      
              Reviewed by Tim Hatcher
      
              * platform/mac/scrollbars/disabled-scrollbar-expected.checksum: Added.
              * platform/mac/scrollbars/disabled-scrollbar-expected.png: Added.
              * platform/mac/scrollbars/disabled-scrollbar-expected.txt: Added.
              * scrollbars/disabled-scrollbar.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e784a798
    • hyatt@apple.com's avatar
      WebCore: · 2e4835da
      hyatt@apple.com authored
      2008-10-09  David Hyatt  <hyatt@apple.com>
      
              https://bugs.webkit.org/show_bug.cgi?id=21446
      
              This patch gets CSS scrollbars up and limping.  There's no way to distinguish between states or between
              orientation and back vs. forward on the buttons, but it's a start.
      
              Reviewed by Oliver Hunt
      
              Added scrollbars/basic-scrollbar.html
      
              * WebCore.xcodeproj/project.pbxproj:
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              * platform/ScrollTypes.h:
              (WebCore::):
              * platform/Scrollbar.h:
              (WebCore::Scrollbar::styleChanged):
              * platform/ScrollbarThemeComposite.cpp:
              (WebCore::ScrollbarThemeComposite::paint):
              (WebCore::ScrollbarThemeComposite::splitTrack):
              * platform/ScrollbarThemeComposite.h:
              (WebCore::ScrollbarThemeComposite::paintScrollbarBackground):
              (WebCore::ScrollbarThemeComposite::paintTrackBackground):
              (WebCore::ScrollbarThemeComposite::paintTrackPiece):
              * platform/win/ScrollbarThemeSafari.cpp:
              (WebCore::ScrollbarThemeSafari::paintTrackBackground):
              * platform/win/ScrollbarThemeSafari.h:
              * platform/win/ScrollbarThemeWin.cpp:
              (WebCore::ScrollbarThemeWin::paintTrack):
              * platform/win/ScrollbarThemeWin.h:
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::createScrollbar):
              (WebCore::RenderLayer::styleChanged):
              * rendering/RenderScrollbar.cpp: Added.
              (WebCore::RenderScrollbar::createCustomScrollbar):
              (WebCore::RenderScrollbar::RenderScrollbar):
              (WebCore::RenderScrollbar::~RenderScrollbar):
              (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
              (WebCore::RenderScrollbar::updateScrollbarParts):
              (WebCore::RenderScrollbar::updateScrollbarPart):
              (WebCore::RenderScrollbar::paintPart):
              (WebCore::RenderScrollbar::buttonRect):
              (WebCore::RenderScrollbar::minimumThumbLength):
              * rendering/RenderScrollbar.h: Added.
              (WebCore::RenderScrollbar::styleChanged):
              (WebCore::RenderScrollbar::owningRenderer):
              * rendering/RenderScrollbarPart.cpp: Added.
              (WebCore::RenderScrollbarPart::RenderScrollbarPart):
              (WebCore::RenderScrollbarPart::~RenderScrollbarPart):
              (WebCore::RenderScrollbarPart::layout):
              (WebCore::RenderScrollbarPart::layoutHorizontalPart):
              (WebCore::RenderScrollbarPart::layoutVerticalPart):
              (WebCore::calcScrollbarThicknessUsing):
              (WebCore::RenderScrollbarPart::computeScrollbarWidth):
              (WebCore::RenderScrollbarPart::computeScrollbarHeight):
              (WebCore::RenderScrollbarPart::calcPrefWidths):
              (WebCore::RenderScrollbarPart::setStyle):
              * rendering/RenderScrollbarPart.h: Added.
              (WebCore::RenderScrollbarPart::renderName):
              (WebCore::RenderScrollbarPart::requiresLayer):
              * rendering/RenderScrollbarTheme.cpp: Added.
              (WebCore::RenderScrollbarTheme::renderScrollbarTheme):
              (WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis):
              (WebCore::RenderScrollbarTheme::hasButtons):
              (WebCore::RenderScrollbarTheme::hasThumb):
              (WebCore::RenderScrollbarTheme::minimumThumbLength):
              (WebCore::RenderScrollbarTheme::backButtonRect):
              (WebCore::RenderScrollbarTheme::forwardButtonRect):
              (WebCore::RenderScrollbarTheme::trackRect):
              (WebCore::RenderScrollbarTheme::paintScrollCorner):
              (WebCore::RenderScrollbarTheme::paintScrollbarBackground):
              (WebCore::RenderScrollbarTheme::paintTrackBackground):
              (WebCore::RenderScrollbarTheme::paintTrackPiece):
              (WebCore::RenderScrollbarTheme::paintButton):
              (WebCore::RenderScrollbarTheme::paintThumb):
              * rendering/RenderScrollbarTheme.h: Added.
              (WebCore::RenderScrollbarTheme::~RenderScrollbarTheme):
              (WebCore::RenderScrollbarTheme::scrollbarThickness):
              (WebCore::RenderScrollbarTheme::buttonsPlacement):
              (WebCore::RenderScrollbarTheme::supportsControlTints):
              (WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
              (WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay):
              (WebCore::RenderScrollbarTheme::autoscrollTimerDelay):
              (WebCore::RenderScrollbarTheme::registerScrollbar):
              (WebCore::RenderScrollbarTheme::unregisterScrollbar):
              * rendering/style/RenderStyle.h:
              (WebCore::RenderStyle::):
      
      LayoutTests:
      
      2008-10-09  David Hyatt  <hyatt@apple.com>
      
              Land layout test for CSS scrollbars.
      
              Reviewed by Oliver Hunt
      
              * platform/mac/scrollbars: Added.
              * platform/mac/scrollbars/basic-scrollbar-expected.checksum: Added.
              * platform/mac/scrollbars/basic-scrollbar-expected.png: Added.
              * platform/mac/scrollbars/basic-scrollbar-expected.txt: Added.
              * scrollbars: Added.
              * scrollbars/basic-scrollbar.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e4835da
    • eric@webkit.org's avatar
      Reviewed by Oliver Hunt. · 3df115dc
      eric@webkit.org authored
              Fix transformed patterns
              https://bugs.webkit.org/show_bug.cgi?id=21498
      
              Test: fast/canvas/patternfill-repeat.html
      
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::setStrokePattern):
              (WebCore::GraphicsContext::setFillPattern):
              (WebCore::GraphicsContext::setStrokeGradient):
              (WebCore::GraphicsContext::setFillGradient):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::applyStrokePattern):
              (WebCore::applyFillPattern):
              (WebCore::GraphicsContext::drawPath):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::fillRect):
              * platform/graphics/qt/GraphicsContextQt.cpp:
              * platform/graphics/wx/GraphicsContextWx.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3df115dc
  9. 08 Oct, 2008 2 commits
    • zimmermann@webkit.org's avatar
      Reviewed by Oliver Hunt & Sam Weining. · abd88452
      zimmermann@webkit.org authored
       Fixes: https://bugs.webkit.org/show_bug.cgi?id=15413 (SVGElementInstance does not implement EventTarget)
       Fixes: https://bugs.webkit.org/show_bug.cgi?id=15430 (SVGElementInstances should rebuild themselves lazily)
       Fixes: https://bugs.webkit.org/show_bug.cgi?id=20550 (SVGUseElement.setAttribute crashes Safari)
      
       Rebuild SVG use element shadow tree lazily. Mark SVGElementInstance with the "needsUpdate" flag.
       Next time SVGUseElement::recalcStyle is invoked (ie. via Document::updateDocumentsRendering()) the
       use tree is rebuild.
      
       Make SVGElementInstance a real EventTarget, as the SVG specification demands.
       When dispatching events to a shadow tree element of a use element, the associated SVGElementInstance
       is used as event target. The SVGElementInstance, the shadow tree element and the corresponding element
       share an event listener list. Every event listener change on the SVGElementInstance object is forwared
       to the corresponding element. Each change marks the SVGElementInstance tree dirty, and causes a reclone.
       Each event listener defined via attributes (onclick/onkeydown/...) is copied from the correspondingElement
       to the shadow tree element - through the cloneNode calls - if the use element's shadow tree gets rebuild.
       Each listener, dynamically created using addEventListener, gets copied to the corersponding element as well.
      
       Now that the target/currentTarget properties of the Events are correct, event bubbling works as expected,
       see resources/use-instanceRoot-event-bubbling.js for details.
      
       Tests: svg/custom/use-elementInstance-event-target.svg (reenabled)
              svg/custom/use-elementInstance-methods.svg (reenabled)
              svg/custom/use-setAttribute-crash.svg (covers bug 20550)
              svg/custom/use-instanceRoot-as-event-target.xhtml (covers bug 15413)
              svg/custom/use-instanceRoot-event-bubbling.xhtml (covers bug 15413)
              svg/custom/use-instanceRoot-event-listeners.xhtml (covers bug 15413 & 15430)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abd88452
    • eric@webkit.org's avatar
      Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt. · 4966e4a0
      eric@webkit.org authored
              svgElement.className.baseValue = "foo" does not work
              https://bugs.webkit.org/show_bug.cgi?id=20651
      
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::classAttributeChanged):
              (WebCore::StyledElement::parseMappedAttribute):
              * dom/StyledElement.h:
              * svg/SVGStyledElement.cpp:
              (WebCore::SVGStyledElement::svgAttributeChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4966e4a0
  10. 07 Oct, 2008 2 commits
  11. 06 Oct, 2008 1 commit
  12. 03 Oct, 2008 1 commit
  13. 02 Oct, 2008 2 commits
    • adele@apple.com's avatar
      WebCore: · f022590e
      adele@apple.com authored
      2008-10-02  Adele Peterson  <adele@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21299
              REGRESSION: <input> color specified in inline style applies to placeholder
      
              I recently added a pseudo-class for the placeholder, but that can be overridden by inline style changes.  A pseudo-element
              is more appropriate.  This change adds "-webkit-input-placeholder".
      
              * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
              Added definition for "-webkit-input-placeholder" pseudo element.
              * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoInputPlaceholder.
              * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              Added case for PseudoInputPlaceholder.
              * css/html4.css: Added rule for -webkit-input-placeholder pseudo-element.
              * rendering/style/RenderStyle.h: (WebCore::RenderStyle::): Added INPUT_PLACEHOLDER.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::setValue): Check that its a text field before calling updatePlaceholderVisibility.
              (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
              (WebCore::HTMLInputElement::updatePlaceholderVisibility): Instead of calling setChanged(), call updatePlaceholderVisibility on the renderer.
              setChanged wouldn't actually trigger setStyle since the style for the input element won't actually change.
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::createInnerTextStyle): Get the pseudoStyle when the placeholder is visible.
              (WebCore::RenderTextControl::updatePlaceholderVisibility): Sets the style on the inner text block, and calls updateFromElement so
              the text will be updated correctly.
              * rendering/RenderTextControl.h:
      
      LayoutTests:
      
      2008-10-02  Adele Peterson  <adele@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Update tests for https://bugs.webkit.org/show_bug.cgi?id=21299
              REGRESSION: <input> color specified in inline style applies to placeholder
      
              * fast/forms/placeholder-pseudo-style.html:
              * platform/mac/fast/forms/password-placeholder-expected.txt:
              * platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f022590e
    • brettw@chromium.org's avatar
      Reviewed by Sam Weinig. · 83eadccd
      brettw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=21292
      
      Revert the changes to enclosingIntRect made in r12530 since the new code
      doesn't round correctly.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83eadccd
  14. 30 Sep, 2008 1 commit
    • adele@apple.com's avatar
      WebCore: · ed74a6ef
      adele@apple.com authored
      2008-09-30  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21227
              <rdar://problem/6222134> add a way to set color for input placeholder text
      
              Test: fast/forms/placeholder-pseudo-style.html
      
              This change adds "-webkit-input-placeholder-mode" as a pseudo class that can be used to style
              input elements when they are displaying the placeholder text.
      
              * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Add case for inputPlaceholderMode.
              * css/CSSSelector.h: (WebCore::CSSSelector::): Add PseudoInputPlaceholderMode.
              * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              Add check for PseudoInputPlaceholderMode that asks the node if placeholderShouldBeVisible is true.
              * css/html4.css: Add rule to make placeholder text default to darkGray.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::init): Initialize m_placeholderShouldBeVisible.
              (WebCore::HTMLInputElement::dispatchFocusEvent): Call updatePlaceholderVisibility.
              (WebCore::HTMLInputElement::dispatchBlurEvent): ditto.
              (WebCore::HTMLInputElement::parseMappedAttribute): ditto.
              (WebCore::HTMLInputElement::setValue): ditto.
              (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
              (WebCore::HTMLInputElement::updatePlaceholderVisibility): Sets m_placeholderShouldBeVisible based on the current value and the focus state.
               This calculation used to be done in the renderer, but since the node knows everything about the state, it can make that decision, and the
               renderer will just ask the node if it should draw the placeholder.
              * html/HTMLInputElement.h: (WebCore::HTMLInputElement::placeholderShouldBeVisible):
      
              * rendering/RenderTextControl.cpp:
              (WebCore::disabledTextColor): Moved to the top of the file.  If there's not very much contrast between the disabled color and the background color,
              just leave the text color alone.  We don't want to change a good contrast color scheme so that it has really bad contrast.
              If the the contrast was already poor, then it doesn't do any good to change it to a different poor contrast color scheme.
              (WebCore::RenderTextControl::createInnerTextStyle): If the node says the placeholder should be visible, prepare by overriding the text security to be "none".
              This can only happen as a result of either a setStyle call (which will be followed by a call to updateFromElement) or from createSubtreeIfNeeded, which
              is called directly from updateFromElement.  updateFromElement will immediately update the text displayed.
              (WebCore::RenderTextControl::updateFromElement): If the placeholder visibility has changed, update the text that is displayed.
              (WebCore::RenderTextControl::forwardEvent): Remove calls to update the placeholder state.  This is now done in HTMLInputElement.
              * rendering/RenderTextControl.h:
      
      LayoutTests:
      
      2008-09-30  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Tests for https://bugs.webkit.org/show_bug.cgi?id=21227
              <rdar://problem/6222134> add a way to set color for input placeholder text
      
              * fast/forms/password-placeholder-text-security.html: Added.
              * fast/forms/placeholder-pseudo-style.html: Added.
              * platform/mac/fast/forms/password-placeholder-text-security-expected.checksum: Added.
              * platform/mac/fast/forms/password-placeholder-text-security-expected.png: Added.
              * platform/mac/fast/forms/password-placeholder-text-security-expected.txt: Added.
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum: Added.
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.png: Added.
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.txt: Added.
      
              Updated results. The placeholder color is now reflected on the RenderTextControl, not just on an inner element.
      
              * platform/mac/fast/forms/input-disabled-color-expected.checksum:
              * platform/mac/fast/forms/input-disabled-color-expected.png:
              * platform/mac/fast/forms/input-disabled-color-expected.txt:
              * platform/mac/fast/forms/password-placeholder-expected.checksum:
              * platform/mac/fast/forms/password-placeholder-expected.png:
              * platform/mac/fast/forms/password-placeholder-expected.txt:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.png:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed74a6ef
  15. 26 Sep, 2008 1 commit
  16. 24 Sep, 2008 3 commits
    • weinig@apple.com's avatar
      JavaScriptCore: · ab8f8bc4
      weinig@apple.com authored
      2008-09-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Darin Adler.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
              <rdar://problem/6243534>
              Crash below Function.apply when using a runtime array as the argument list
      
              Test: plugins/bindings-array-apply-crash.html
      
              * kjs/FunctionPrototype.cpp:
              (JSC::functionProtoFuncApply): Revert to the slow case if the object inherits from 
              JSArray (via ClassInfo) but is not a JSArray.
      
      WebKitTools:
      
      2008-09-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Darin Adler.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
              <rdar://problem/6243534>
              Crash below Function.apply when using a runtime array as the argument list
      
              Add method to ObjCController to return a runtime array.
      
              * DumpRenderTree/mac/ObjCController.m:
              (+[ObjCController isSelectorExcludedFromWebScript:]):
              (+[ObjCController webScriptNameForSelector:]):
              (-[ObjCController testArray]):
      
      LayoutTests:
      
      2008-09-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Darin Adler.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=21080
              <rdar://problem/6243534>
              Crash below Function.apply when using a runtime array as the argument list
      
              * platform/mac/plugins/bindings-array-apply-crash-expected.txt: Added.
              * platform/mac/plugins/bindings-array-apply-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab8f8bc4
    • mitz@apple.com's avatar
      WebCore: · 0cb3dffa
      mitz@apple.com authored
      2008-09-24  Jeremy Moskovich  <jeremy@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              Test: editing/spelling/inline_spelling_markers.html
              
              - https://bugs.webkit.org/show_bug.cgi?id=20092
              Spelling markers positioned incorrectly in RTL text
      
              Measure spelling markers with selectionRectForText() to fix RTL.
      
              This patch also fixes hit-testing for spelling marker tool tips,
              which used to work only on the first line.
      
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
      
      LayoutTests:
      
      2008-09-24  Jeremy Moskovich  <jeremy@chromium.org>
      
              Reviewed by Dan Bernstein.
              
              - https://bugs.webkit.org/show_bug.cgi?id=20092
              Spelling markers positioned incorrectly in RTL text
      
              * editing/spelling/inline_spelling_markers.html: Added.
              * platform/mac/editing/spelling/inline_spelling_markers-expected.checksum: Added.
              * platform/mac/editing/spelling/inline_spelling_markers-expected.png: Added.
              * platform/mac/editing/spelling/inline_spelling_markers-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cb3dffa
    • hyatt@apple.com's avatar
      2008-09-24 David Hyatt <hyatt@apple.com> · e77b7d43
      hyatt@apple.com authored
              Turn off support for CSS variables.
      
              * ChangeLog:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::createVariablesRule):
              (WebCore::CSSParser::addVariable):
              (WebCore::CSSParser::addVariableDeclarationBlock):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e77b7d43
  17. 19 Sep, 2008 4 commits
    • zimmermann@webkit.org's avatar
      Reviewed by Antti & Eric. · 50e33c7a
      zimmermann@webkit.org authored
      Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
      
      Finish HTMLScriptElement / SVGScriptElement unification.
      SVG <script> support is complete now, full SVGLoad event
      respecting the influence of the externalResourcesRequired attribute
      as well as SVGError event support. All other features shared with HTML.
      
      Tests: fast/dom/HTMLScriptElement/script-reexecution.html
             svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg
             svg/dom/SVGScriptElement/script-load-and-error-events.svg
             svg/dom/SVGScriptElement/script-reexecution.svg
             svg/dom/SVGScriptElement/script-set-href.svg
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50e33c7a
    • bdakin@apple.com's avatar
      WebCore: · 5b0a3b2b
      bdakin@apple.com authored
      2008-09-19  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Fix for <rdar://problem/6231308> crash in AutoTableLayout
      
              The code assumes later on that a TableSection's grid's row vector 
              will never be empty. So make 1 the minimum number of columns.
      
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::ensureRows):
      
      LayoutTests:
      
      2008-09-19  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Test for <rdar://problem/6231308> crash in AutoTableLayout
      
              * fast/table/empty-row-crash.html: Added.
              * platform/mac/fast/table/empty-row-crash-expected.checksum: Added.
              * platform/mac/fast/table/empty-row-crash-expected.png: Added.
              * platform/mac/fast/table/empty-row-crash-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b0a3b2b
    • hyatt@apple.com's avatar
      WebCore: · 2d7bdf78
      hyatt@apple.com authored
      2008-09-19  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Sam Weinig
      
              https://bugs.webkit.org/show_bug.cgi?id=20941
      
              Incorrect height calculation for replaced element inside nested
              positioned elements (where the inner has a percentage height and
              the outer implicitly has a fixed height because of explicit top/bottom
              values).
      
              Added fast/block/positioning/replaced-inside-top-bottom.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::availableHeightUsing):
      
      LayoutTests:
      
      2008-09-19  David Hyatt  <hyatt@apple.com>
      
              Fix for bug 20941.
      
              Reviewed by Sam Weinig
      
              * fast/block/positioning/replaced-inside-fixed-top-bottom.html: Added.
              * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Added.
              * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
              * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d7bdf78
    • darin@apple.com's avatar
      JavaScriptCore: · c9aea831
      darin@apple.com authored
      2008-09-18  Darin Adler  <darin@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              - part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
                make each distinct C++ class get a distinct JSC::Structure
      
              * kjs/lookup.h: Removed things here that were used only in WebCore:
              cacheGlobalObject, JSC_DEFINE_PROTOTYPE, JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE,
              and JSC_IMPLEMENT_PROTOTYPE.
      
      WebCore:
      
      2008-09-18  Darin Adler  <darin@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              - part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
                make each distinct C++ class get a distinct JSC::Structure
      
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              (WebCore::JSCSSStyleDeclaration::customPut): Use setDOMException
              instead of DOMExceptionTranslator.
      
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::getCachedDOMObjectWrapper): Updated function name.
              (WebCore::cacheDOMObjectWrapper): Ditto.
              (WebCore::forgetDOMObject): Ditto.
              (WebCore::getCachedDOMNodeWrapper): Ditto.
              (WebCore::forgetDOMNode): Ditto.
              (WebCore::cacheDOMNodeWrapper): Ditto.
              (WebCore::forgetAllDOMNodesForDocument): Ditto.
              (WebCore::markDOMNodesForDocument): Ditto.
              (WebCore::updateDOMNodeDocument): Ditto.
              (WebCore::getCachedDOMStructure): Added.
              (WebCore::createDOMStructure): Ditto.
      
              * bindings/js/JSDOMBinding.h: Get rid of the ScriptInterpreter
              class and replace the static member functions with non-member
              functions. Added many other functions for getting at structures,
              prototypes, wrappers, and creating them. Also moved the
              cacheGlobalObject function here from JavaScriptCore; eventually
              I'll remove that once I get rid of the remaining callers. Also
              removed the DOMExceptionTranslator class.
      
              * bindings/js/JSDOMWindowBase.h: Added JSDOMStructureMap type,
              and put one of those maps in each window.
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::markDOMObjectWrapper): Updated for function name change.
              (WebCore::JSDOMWindow::mark): Added code to mark all the structures
              in the structure map.
      
              * bindings/js/JSEventTargetNode.cpp:
              (WebCore::JSEventTargetNode::JSEventTargetNode): Changed to take
              a structure instead of a prototype.
              * bindings/js/JSEventTargetNode.h: Ditto.
              * bindings/js/JSHTMLAllCollection.h:
              (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Ditto.
      
              * bindings/js/JSHTMLInputElementBase.cpp:
              (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Removed
              use of the JSC_IMPLEMENT_PROTOTYPE macro, and changed to take a
              structure instead of a prototype.
              * bindings/js/JSHTMLInputElementBase.h: Removed use of the
              JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro, and changed constructor
              to take a structure instead of a prototype. Created a dummy prototype
              class that causes the HTMLInputElement prototype to have the
              HTMLElement prototype.
      
              * bindings/scripts/CodeGeneratorJS.pm: Change constructors to take
              structures instead of prototypes. Changed the prototype self function
              to use the getDOMPrototype function -- later we can eliminate it and
              have callers invoke getDOMPrototype directly instead. Updated other
              functions that have name changes. Added code to generate the
              createPrototype member function. Changed use of cacheGlobalObject to
              get it from the WebCore namespace instead of the JSC namespace.
              Changed cacheDOMObject calls to use getDOMObjectWrapper instead.
      
              * dom/Document.cpp:
              (WebCore::Document::~Document): Updated for name change and also
              removed unnecessary JSLock use -- there's no need to lock around this.
              * dom/Node.cpp:
              (WebCore::Node::setDocument): Ditto.
      
              * dom/make_names.pl: Changed to use CREATE_DOM_NODE_WRAPPER macro
              instead of calling new directly.
      
              * bindings/js/JSCSSRuleCustom.cpp:
              (WebCore::toJS): Updated for function name changes and used the
              CREATE_DOM_OBJECT_WRAPPER macro.
              * bindings/js/JSCSSValueCustom.cpp:
              (WebCore::toJS): Ditto.
              * bindings/js/JSCanvasPixelArrayCustom.cpp:
              (WebCore::toJS): Ditto.
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::mark): Ditto.
              (WebCore::toJS): Ditto.
              * bindings/js/JSElementCustom.cpp:
              (WebCore::toJSNewlyCreated): Ditto.
              * bindings/js/JSEventCustom.cpp:
              (WebCore::toJS): Ditto.
              * bindings/js/JSEventTargetBase.cpp:
              (WebCore::jsEventTargetDispatchEvent): Use setDOMException instead
              of DOMExceptionTranslator.
              (WebCore::toJS): Updated for function name changes and used the
              CREATE_DOM_OBJECT_WRAPPER macro.
              * bindings/js/JSHTMLCollectionCustom.cpp:
              (WebCore::toJS): Ditto.
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::JSNode::mark): Ditto.
              (WebCore::createWrapper): Ditto.
              (WebCore::toJS): Ditto.
              * bindings/js/JSSVGPathSegCustom.cpp:
              (WebCore::toJS): Ditto.
              * bindings/js/JSStyleSheetCustom.cpp:
              (WebCore::toJS): Ditto.
              (WebCore::JSStyleSheet::mark): Ditto.
              * bindings/js/JSTextCustom.cpp:
              (WebCore::toJSNewlyCreated): Ditto.
              * bindings/js/JSXMLHttpRequestConstructor.cpp:
              (WebCore::constructXMLHttpRequest): Ditto.
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::mark): Ditto.
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
              (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
              * bindings/js/JSXSLTProcessorConstructor.cpp:
              (WebCore::constructXSLTProcessor): Ditto.
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::finishedWithEvent): Ditto.
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
              (WebCore::XMLHttpRequest::dropProtection): Ditto.
      
      LayoutTests:
      
      2008-09-18  Darin Adler  <darin@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              * platform/mac/fast/dom/wrapper-classes-expected.txt: Update results to
              reflect correct prototype for CSSStyleRule.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9aea831
  18. 17 Sep, 2008 1 commit
    • simon.fraser@apple.com's avatar
      2008-09-17 Simon Fraser <simon.fraser@apple.com> · 4b603c17
      simon.fraser@apple.com authored
              Add pixel test expecteds for transform tests.
      
              * platform/mac/transforms/2d/compound-transforms-vs-containers-expected.checksum: Added.
              * platform/mac/transforms/2d/compound-transforms-vs-containers-expected.png: Added.
              * platform/mac/transforms/2d/transform-borderbox-expected.checksum: Added.
              * platform/mac/transforms/2d/transform-borderbox-expected.png: Added.
              * platform/mac/transforms/2d/transform-origin-borderbox-expected.checksum: Added.
              * platform/mac/transforms/2d/transform-origin-borderbox-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b603c17
  19. 16 Sep, 2008 3 commits
    • beidson@apple.com's avatar
      2008-09-16 Brady Eidson <beidson@apple.com> · 1388e43b
      beidson@apple.com authored
              Reviewed by Sam Weinig
      
              Update layout test results for tests changed by http://trac.webkit.org/changeset/35799
             
              * platform/mac-leopard/security/block-test-expected.txt:
              * platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
              * security/block-test-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1388e43b
    • mitz@apple.com's avatar
      WebCore: · d9462a52
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=15129
                <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
      
              Covered by fast/repaint/4776765.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock): Avoid repainting this object if it
              did not have layout in the beginning.
              (WebCore::RenderBlock::layoutBlockChildren): If a child did not have
              layout in the beginning, repaint it in its new position, to compensate
              for the above (regardless of whether it "moved").
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::checkForRepaintDuringLayout): Added a comment
              about generalizing this fix in the future.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - updated results for https://bugs.webkit.org/show_bug.cgi?id=15129
                <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
      
              * platform/mac/fast/repaint/4776765-expected.checksum:
              * platform/mac/fast/repaint/4776765-expected.png:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9462a52
    • mitz@apple.com's avatar
      WebCore: · 6d92520b
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=15384
                Div does not notice when grandparent changes height
      
              Test: fast/block/basic/quirk-percent-height-grandchild.html
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=20714
                Resizing Gmail inbox vertically results in whitespace at the bottom of the window
      
              Test: fast/replaced/percent-height-in-anonymous-block.html
      
              Added a two-way mapping between boxes with percentage heights and
              their non-parent ancestors up to the one the height is computed relative
              to. In quirks mode (the first bug), this can be any number of containing
              block with auto height. In strict mode (the second bug) this can be
              the containing block of an anonymous block containing a replaced
              element.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::~RenderBlock): Added code to remove the all the
              mapping to/from this block to percentage-height descendants.
              (WebCore::RenderBlock::layoutBlockChildren): Added code to mark
              percentage-height descendants (and their containing block ancestry chain
              up to this block) for layout. This ensures that those descendants whose
              height depends on the height of this block (or an ancestor) are updated.
              (WebCore::RenderBlock::addPercentHeightDescendant): Added. Establishes
              a two-way mapping between this block and the given box.
              (WebCore::RenderBlock::removePercentHeightDescendant): Added. Removes
              all the mapping to/from this box.
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::setStyle): Added calls to
              removePercentHeightDescendant() when style changes and the box
              previously had a percentage height. An exception is when the style
              change does not require layout, in which case the box still has
              a percentage height and the mappings are valid. In all other cases,
              any required mappings will be (re-)established during layout.
              (WebCore::RenderBox::destroy): Added a call to
              removePercentHeightDescendant.
              (WebCore::RenderBox::calcPercentageHeight): Added code that, in quirks
              mode, if a higher-than-parent containing block is affecting the box's
              height, creates a mapping between the box and that block.
              (WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over
              anonymous containing blocks, if any, and when that happens, use
              addPercentHeightDescendant() to ensure that the non-anonymous block
              is aware of the dependent percent-height box.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test for https://bugs.webkit.org/show_bug.cgi?id=15384
                Div does not notice when grandparent changes height
      
              - test for https://bugs.webkit.org/show_bug.cgi?id=20714
                Resizing Gmail inbox vertically results in whitespace at the bottom of the window
      
              * fast/block/basic/quirk-percent-height-grandchild.html: Added.
              * fast/replaced/percent-height-in-anonymous-block.html: Added.
              * platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.checksum: Added.
              * platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.png: Added.
              * platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.txt: Added.
              * platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.checksum: Added.
              * platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.png: Added.
              * platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d92520b