GitLab

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=21858

        Add additional CSSRule types to the DOM-wrapper tests.

        * fast/dom/resources/wrapper-identity-base.js:
        * fast/dom/wrapper-identity-expected.txt:
        * platform/mac/fast/dom/objc-wrapper-identity-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=21818

        Add HashTraits for AtomicString so that AtomicString can be used as
        the key for a HashMap or HashSet.

        * GNUmakefile.am: add AtomicStringHash.h
        * WebCore.vcproj/WebCore.vcproj: add AtomicStringHash.h
        * WebCore.xcodeproj/project.pbxproj: add AtomicStringHash.h
        * platform/text/AtomicString.h:
        (WebCore::AtomicString::AtomicString):
        (WebCore::AtomicString::isHashTableDeletedValue):
            specialize DefaultHash for AtomicString to use AtomicStringHash
        * platform/text/AtomicStringHash.h: Added.
        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::StringImpl):
            compute the hash up-front for the empty string
        * platform/text/StringImpl.h:
        (WebCore::StringImpl::existingHash):
            method to get the hash without a test and branch, for callers like
            AtomicStringHash who can guarantee that the hash has already been computed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Sam Weinig

        https://bugs.webkit.org/show_bug.cgi?id=21857

        Add WebKitCSSKeyframeRule and WebKitCSSKeyframesRule to the
        switch in _wrapCSSRule.

        * bindings/objc/DOMCSS.mm:
        (+[DOMCSSRule _wrapCSSRule:WebCore::]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * plugins/PluginView.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Sam Weinig.

        - fix https://bugs.webkit.org/show_bug.cgi?id=21851
          <rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height

        Test: fast/replaced/percent-height-in-anonymous-block-widget.html

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy): Copied code added to
        RenderBox::destroy() in r36513 into this function.

LayoutTests:

        Reviewed by Sam Weinig.

        - test for https://bugs.webkit.org/show_bug.cgi?id=21851
          <rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height

        * fast/replaced/percent-height-in-anonymous-block-widget.html: Added.
        * platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.checksum: Added.
        * platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.png: Added.
        * platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Add a mechanism to ask the InspectorClient for key/value setting pairs.
        These settings can be strings, numbers, booleans or string vectors. The
        settings are also bridged to and from JavaScript.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebCore.base.exp: Expose the String CFStringRef constructor.
        * inspector/InspectorClient.h:
        (WebCore::InspectorClient::populateSetting): Added, pure virtual.
        (WebCore::InspectorClient::storeSetting): Ditto.
        (WebCore::InspectorClient::removeSetting): Ditto.
        * inspector/InspectorController.cpp:
        (WebCore::setting): Calls InspectorController::setting and wraps the result in script types.
        (WebCore::setSetting): Calls InspectorController::setSetting after converting from script types.
        (WebCore::InspectorController::InspectorController): Increment a global static
        to track the number of live InspectorControllers.
        (WebCore::InspectorController::~InspectorController): Decrement the global static
        that tracks the number of live InspectorControllers. Delete the setting cache if there
        are no more live controllers.
        (WebCore::InspectorController::setting): Check the cache and return the setting from there,
        otherwise make a new Setting and ask the client to populate it.
        (WebCore::InspectorController::setSetting): Change the cache and ask the client to store it.
        (WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting
        to the InspectorController script class.
        * inspector/InspectorController.h:
        (WebCore::InspectorController::Setting::Setting):
        (WebCore::InspectorController::Setting::operator=):
        (WebCore::InspectorController::Setting::type): Return m_type.
        (WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct.
        (WebCore::InspectorController::Setting::stringVector): Return m_stringVector.
        Assert the type is correct.
        (WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double.
        Assert the type is correct.
        (WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer.
        Assert the type is correct.
        (WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean.
        Assert the type is correct.
        (WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right
        field and the type.
        * loader/EmptyClients.h:
        (WebCore::EmptyInspectorClient::populateSetting): Added, empty method.
        (WebCore::EmptyInspectorClient::storeSetting): Ditto.
        (WebCore::EmptyInspectorClient::removeSetting): Ditto.

WebKit:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Implement new InspectorClient methods to work with Settings.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebKit.xcodeproj/project.pbxproj: Add the new InspectorClientCF.cpp file.

WebKit/gtk:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Stub out new InspectorClient methods.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::populateSetting): Not implemented.
        (WebKit::InspectorClient::storeSetting): Ditto.
        (WebKit::InspectorClient::removeSetting): Ditto.
        * WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Implement new InspectorClient methods to work with Settings.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebCoreSupport/WebInspectorClient.h: Add the new methods and
        guard the ObjC parts of the header.

WebKit/qt:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Stub out new InspectorClient methods.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::populateSetting): Not implemented.
        (WebCore::InspectorClientQt::storeSetting): Ditto.
        (WebCore::InspectorClientQt::removeSetting): Ditto.
        * WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Implement new InspectorClient methods to work with Settings.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Adam Roben.

        * WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
        * WebCoreSupport/WebInspectorClient.h: Add the new methods.

WebKit/wx:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Stub out new InspectorClient methods.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebKitSupport/InspectorClientWx.cpp:
        (WebCore::InspectorClient::populateSetting): Not implemented.
        (WebCore::InspectorClient::storeSetting): Ditto.
        (WebCore::InspectorClient::removeSetting): Ditto.
        * WebKitSupport/InspectorClientWx.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        <https://bugs.webkit.org/show_bug.cgi?id=21850>

        Reviewed by Adam Roben.

        * Scripts/svn-apply: Save end-of-line characters when stripping them
        off each line of a patch so that they may be restored after
        processing the line.
        * Scripts/svn-unapply: Ditto.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Sam Weinig.

        Remove some C-style casts.

        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-10-24  Darin Adler  <darin@apple.com>

        - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

        * API/APICast.h:
        * API/JSCallbackConstructor.h:
        * API/JSCallbackFunction.cpp:
        * API/JSCallbackFunction.h:
        * API/JSCallbackObject.h:
        * API/JSCallbackObjectFunctions.h:
        * API/JSContextRef.cpp:
        * API/JSObjectRef.cpp:
        * API/JSValueRef.cpp:
        * VM/CTI.cpp:
        * VM/CTI.h:
        * VM/CodeBlock.cpp:
        * VM/CodeBlock.h:
        * VM/CodeGenerator.cpp:
        * VM/CodeGenerator.h:
        * VM/ExceptionHelpers.cpp:
        * VM/ExceptionHelpers.h:
        * VM/JSPropertyNameIterator.cpp:
        * VM/JSPropertyNameIterator.h:
        * VM/Machine.cpp:
        * VM/Machine.h:
        * VM/Register.h:
        * kjs/ArgList.cpp:
        * kjs/ArgList.h:
        * kjs/Arguments.cpp:
        * kjs/Arguments.h:
        * kjs/ArrayConstructor.cpp:
        * kjs/ArrayPrototype.cpp:
        * kjs/Boo...

        Fix the Qt build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Hausmann.

        Invalid history entries could cause a crash in QT Webkit

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptCore:

        Rolled out r37840.

        * wtf/Platform.h:

WebCore:

        Rolled out r37840 and r37841.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSCustomPositionCallback.cpp: Removed.
        * bindings/js/JSCustomPositionCallback.h: Removed.
        * bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
        * bindings/js/JSCustomPositionErrorCallback.h: Removed.
        * bindings/js/JSDOMBinding.cpp:
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::markDOMObjectWrapper):
        * bindings/js/JSGeolocationCustom.cpp: Removed.
        * bindings/js/JSNavigatorCustom.cpp:
        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):
        * page/Geolocation.cpp: Removed.
        * page/Geolocation.h: Removed.
        * page/Geolocation.idl: Removed.
        * page/Geoposition.cpp: Removed.
        * page/Geoposition.h: Removed.
        * page/Geoposition.idl: Removed.
        * page/Navigator.cpp:
        (WebCore::Navigator::disconnectFrame):
        * page/Navigator.h:
        * page/Navigator.idl:
        * page/PositionCallback.h: Removed.
        * page/PositionCallback.idl: Removed.
        * page/PositionError.h: Removed.
        * page/PositionError.idl: Removed.
        * page/PositionErrorCallback.h: Removed.
        * page/PositionErrorCallback.idl: Removed.
        * page/PositionOptions.h: Removed.
        * page/PositionOptions.idl: Removed.
        * platform/GeolocationService.cpp: Removed.
        * platform/GeolocationService.h: Removed.

LayoutTests:

        Rolled out r37840.

        * geolocation/geolocation-not-implemented-expected.txt: Removed.
        * geolocation/geolocation-not-implemented.html: Removed.
        * geolocation/geolocation-test.js: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * GNUmakefile.am: Added new *.idl files that were missing.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-10-23  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21475
        
        Provide support for the Geolocation API
        
        http://dev.w3.org/geo/api/spec-source.html

        * wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0

WebCore:

2008-10-23  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21475
        
        Provide support for the Geolocation API
        
        http://dev.w3.org/geo/api/spec-source.html

        Test: geolocation/geolocation-not-implemented.html

        * DerivedSources.make:
        * GNUmakefile.am: Added Geolocation support
        * WebCore.pro: Added Geolocation support
        * WebCore.vcproj/WebCore.vcproj: Added Geolocation support
        * WebCore.xcodeproj/project.pbxproj: Added Geolocation support
        * WebCoreSources.bkl: Added Geolocation support
        * bindings/js/JSCustomPositionCallback.cpp: Added.
        (WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
        (WebCore::JSCustomPositionCallback::handleEvent):
        * bindings/js/JSCustomPositionCallback.h: Added.
        (WebCore::JSCustomPositionCallback::create):
        * bindings/js/JSCustomPositionErrorCallback.cpp: Added.
        (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
        (WebCore::JSCustomPositionErrorCallback::handleEvent):
        * bindings/js/JSCustomPositionErrorCallback.h: Added.
        (WebCore::JSCustomPositionErrorCallback::create):
        * bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom
        (WebCore::markDOMObjectWrapper):
        * bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
        * bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
        * bindings/js/JSGeolocationCustom.cpp: Added.
        (WebCore::JSGeolocation::getCurrentPosition):
        (WebCore::JSGeolocation::watchPosition):
        * bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation
        (WebCore::JSNavigator::mark):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        (WebCore::Document::setUsingGeolocation):
        (WebCore::Document::usingGeolocation):
        * loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation
        (WebCore::FrameLoader::canCachePage):
        * page/Geolocation.cpp: Added.
        (WebCore::Geolocation::GeoNotifier::GeoNotifier):
        (WebCore::Geolocation::GeoNotifier::timerFired):
        (WebCore::Geolocation::Geolocation):
        (WebCore::Geolocation::disconnectFrame):
        (WebCore::Geolocation::getCurrentPosition):
        (WebCore::Geolocation::watchPosition):
        (WebCore::Geolocation::clearWatch):
        (WebCore::Geolocation::stopUpdatingIfEmpty):
        (WebCore::Geolocation::sendErrorToOneShots):
        (WebCore::Geolocation::sendErrorToWatchers):
        (WebCore::Geolocation::sendPositionToOneShots):
        (WebCore::Geolocation::sendPositionToWatchers):
        (WebCore::Geolocation::handleError):
        (WebCore::Geolocation::geolocationServicePositionChanged):
        (WebCore::Geolocation::geolocationServiceErrorOccurred):
        * page/Geolocation.h: Added.
        (WebCore::Geolocation::create):
        (WebCore::Geolocation::~Geolocation):
        (WebCore::Geolocation::lastPosition):
        (WebCore::Geolocation::GeoNotifier::create):
        * page/Geolocation.idl: Added.
        * page/Geoposition.cpp: Added.
        (WebCore::Geoposition::toString):
        * page/Geoposition.h: Added.
        (WebCore::Geoposition::create):
        (WebCore::Geoposition::latitude):
        (WebCore::Geoposition::longitude):
        (WebCore::Geoposition::altitude):
        (WebCore::Geoposition::accuracy):
        (WebCore::Geoposition::altitudeAccuracy):
        (WebCore::Geoposition::heading):
        (WebCore::Geoposition::velocity):
        (WebCore::Geoposition::timestamp):
        (WebCore::Geoposition::Geoposition):
        * page/Geoposition.idl: Added.
        * page/Navigator.cpp:
        (WebCore::Navigator::disconnectFrame): disconnect Geolocation
        (WebCore::Navigator::geolocation): accessor for Geolocation
        * page/Navigator.h:
        (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
        * page/Navigator.idl: accessor for Geolocation
        * page/PositionCallback.h: Added.
        (WebCore::PositionCallback::~PositionCallback):
        * page/PositionCallback.idl: Added.
        * page/PositionError.h: Added.
        (WebCore::PositionError::):
        (WebCore::PositionError::create):
        (WebCore::PositionError::code):
        (WebCore::PositionError::message):
        (WebCore::PositionError::PositionError):
        * page/PositionError.idl: Added.
        * page/PositionErrorCallback.h: Added.
        (WebCore::PositionErrorCallback::~PositionErrorCallback):
        * page/PositionErrorCallback.idl: Added.
        * page/PositionOptions.h: Added.
        (WebCore::PositionOptions::create):
        (WebCore::PositionOptions::enableHighAccuracy):
        (WebCore::PositionOptions::setEnableHighAccuracy):
        (WebCore::PositionOptions::timeout):
        (WebCore::PositionOptions::setTimeout):
        (WebCore::PositionOptions::PositionOptions):
        * page/PositionOptions.idl: Added.
        * platform/GeolocationService.cpp: Added.
        (WebCore::GeolocationService::GeolocationService):
        (WebCore::GeolocationService::positionChanged):
        (WebCore::GeolocationService::errorOccurred):
        * platform/GeolocationService.h: Added.
        (WebCore::GeolocationServiceClient::~GeolocationServiceClient):
        (WebCore::GeolocationServiceClient::geolocationServicePositionChanged):
        (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred):
        (WebCore::GeolocationService::~GeolocationService):

LayoutTests:

2008-10-23  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21475
        
        Provide support for the Geolocation API
        
        http://dev.w3.org/geo/api/spec-source.html

        Tests to verify Geolocation isn't implemented (so that it didn't leak into 
        WebCore for platforms that do not support it).

        * geolocation: Added.
        * geolocation/geolocation-not-implemented-expected.txt: Added.
        * geolocation/geolocation-not-implemented.html: Added.
        * geolocation/geolocation-test.js: Added.
        (reset):
        (hanged):
        (watchPositionAndEnd):
        (watchPosition._positionCallback):
        (watchPosition):
        (watchPositionTestAndEnd):
        (watchPositionAndFail):
        (watchPositionAndTest._positionCallback):
        (watchPositionAndTest):
        (getCurrentPositionAndEnd):
        (getCurrentPosition._positionCallback):
        (getCurrentPosition):
        (getCurrentPositionTestAndEnd):
        (getCurrentPositionAndFail):
        (getCurrentPositionAndTest._positionCallback):
        (getCurrentPositionAndTest):
        (endTest):
        (relativeURL):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix typo in comment in previous commit. GTK -> GLIB

        * platform/gtk/guriescape.c:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=21824
        [GTK] FileSystem abstraction uses features from Glib 2.16

        Wrap g_uri_unescape_string() to fix building with pre-2.16 Glib

        * platform/gtk/guriescape.c:
        (unescape_character):
        (_webcore_g_uri_unescape_segment):
        (_webcore_g_uri_unescape_string):
        * platform/gtk/guriescape.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix Gtk build typo introduced in http://trac.webkit.org/changeset/37826.

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        m_frame null checked but then dereferenced
        https://bugs.webkit.org/show_bug.cgi?id=21845

        This error was found using a static analysis tool, and so I do not know
        how to produce a null m_frame on entry to this method.  Hence, I have
        not included a regression test.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::allowDHTMLDrag): Add an early return.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rubber stamped by Mark Rowe.

        -Skipping the profiler tests until we know why they fail on tiger:
        <rdar://problem/6316530> Profiler tests fail on tiger

        * platform/mac-tiger/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptCore:

        Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10

        <https://bugs.webkit.org/show_bug.cgi?id=21832>

        Reviewed by Sam Weinig.

        * pcre/dftables: Use imported tempfile() from File::Temp instead of
        'new File::Temp' to make the script work with Perl 5.10.

WebKitTools:

        Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10

        <https://bugs.webkit.org/show_bug.cgi?id=21832>

        Reviewed by Sam Weinig.

        * Scripts/bisect-builds: Use imported tempfile() from File::Temp
        instead of 'new File::Temp' to make the script work with Perl 5.10.
        * Scripts/sort-Xcode-project-file: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Oliver Hunt.

        Fix hideous pathological case performance when looking up repatch info, bug #21727.

        When repatching JIT code to optimize we look up records providing information about
        the generated code (also used to track recsources used in linking to be later released). 
        The lookup was being performed using a linear scan of all such records.

        (1) Split up the different types of reptach information.  This means we can search them
            separately, and in some cases should reduce their size.
        (2) In the case of property accesses, search with a binary chop over the data.
        (3) In the case of calls, pass a pointer to the repatch info into the relink function.

        * VM/CTI.cpp:
        (JSC::CTI::CTI):
        (JSC::CTI::compileOpCall):
        (JSC::CTI::privateCompileMainPass):
        (JSC::CTI::privateCompileSlowCases):
        (JSC::CTI::privateCompile):
        (JSC::CTI::unlinkCall):
        (JSC::CTI::linkCall):
        * VM/CTI.h:
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        (JSC::CodeBlock::~CodeBlock):
        (JSC::CodeBlock::unlinkCallers):
        (JSC::CodeBlock::derefStructureIDs):
        * VM/CodeBlock.h:
        (JSC::StructureStubInfo::StructureStubInfo):
        (JSC::CallLinkInfo::CallLinkInfo):
        (JSC::CallLinkInfo::setUnlinked):
        (JSC::CallLinkInfo::isLinked):
        (JSC::getStructureStubInfoReturnLocation):
        (JSC::binaryChop):
        (JSC::CodeBlock::addCaller):
        (JSC::CodeBlock::getStubInfo):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitResolve):
        (JSC::CodeGenerator::emitGetById):
        (JSC::CodeGenerator::emitPutById):
        (JSC::CodeGenerator::emitCall):
        (JSC::CodeGenerator::emitConstruct):
        * VM/Machine.cpp:
        (JSC::Machine::cti_vm_lazyLinkCall):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Forgot to remove the tests from the skipped lists, this should have been
        apart of the last checkin.

        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Tim Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=21817
        Bug 21817: Manual profiler tests should be made into layout tests

        - Added the expected results for the profiler tests and removed the
        tests from the skipped list.
        - Also removed two tests that were accidentally checked in previously.
        - Also changed the text on the tests to be more apparent how to run them
        manually.

        * fast/profiler/anonymous-event-handler-expected.txt: Added.
        * fast/profiler/anonymous-event-handler.html:
        * fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Added.
        * fast/profiler/anonymous-function-called-from-different-contexts.html:
        * fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Added.
        * fast/profiler/anonymous-function-calls-built-in-functions.html:
        * fast/profiler/anonymous-function-calls-eval-expected.txt: Added.
        * fast/profiler/anonymous-function-calls-eval.html:
        * fast/profiler/apply-expected.txt: Added.
        * fast/profiler/apply.html:
        * fast/profiler/built-in-function-calls-anonymous-expected.txt: Added.
        * fast/profiler/built-in-function-calls-anonymous.html:
        * fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Added.
        * fast/profiler/built-in-function-calls-user-defined-function.html:
        * fast/profiler/call-expected.txt: Added.
        * fast/profiler/call-nodelist-as-function-expected.txt: Added.
        * fast/profiler/call-nodelist-as-function.html:
        * fast/profiler/call.html: Added.
        * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Added.
        * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
        * fast/profiler/compare-multiple-profiles-expected.txt: Added.
        * fast/profiler/compare-multiple-profiles.html:
        * fast/profiler/constructor-expected.txt: Added.
        * fast/profiler/constructor.html:
        * fast/profiler/dead-time-expected.txt: Added.
        * fast/profiler/dead-time.html:
        * fast/profiler/deep-recursion.html: Removed.
        * fast/profiler/document-dot-write-expected.txt: Added.
        * fast/profiler/document-dot-write.html:
        * fast/profiler/event-handler-expected.txt: Added.
        * fast/profiler/event-handler.html:
        * fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Added.
        * fast/profiler/execution-context-and-eval-on-same-line.html:
        * fast/profiler/heavy-view-expected.txt: Added.
        * fast/profiler/heavy-view.html:
        * fast/profiler/inline-event-handler-expected.txt: Added.
        * fast/profiler/inline-event-handler.html:
        * fast/profiler/many-calls-in-the-same-scope-expected.txt: Added.
        * fast/profiler/many-calls-in-the-same-scope.html: Added.
        * fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Added.
        * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
        * fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Added.
        * fast/profiler/multiple-and-different-scoped-function-calls.html:
        * fast/profiler/multiple-frames-expected.txt: Added.
        * fast/profiler/multiple-frames.html:
        * fast/profiler/multiple-windows.html: Removed.
        * fast/profiler/nested-anonymous-functon-expected.txt: Added.
        * fast/profiler/nested-anonymous-functon.html:
        * fast/profiler/nested-start-and-stop-profiler-expected.txt: Added.
        * fast/profiler/nested-start-and-stop-profiler.html:
        * fast/profiler/no-execution-context-expected.txt: Added.
        * fast/profiler/no-execution-context.html:
        * fast/profiler/one-execution-context-expected.txt: Added.
        * fast/profiler/one-execution-context.html:
        * fast/profiler/profile-calls-in-included-file-expected.txt: Added.
        * fast/profiler/profile-calls-in-included-file.html:
        * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Added.
        * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
        * fast/profiler/profiling-from-a-nested-location-expected.txt: Added.
        * fast/profiler/profiling-from-a-nested-location.html:
        * fast/profiler/simple-event-call-expected.txt: Added.
        * fast/profiler/simple-event-call.html:
        * fast/profiler/simple-no-level-change-expected.txt: Added.
        * fast/profiler/simple-no-level-change.html:
        * fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Added.
        * fast/profiler/start-and-stop-profiler-multiple-times.html:
        * fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Added.
        * fast/profiler/start-and-stop-profiling-in-the-same-function.html:
        * fast/profiler/start-but-dont-stop-profiling-expected.txt: Added.
        * fast/profiler/start-but-dont-stop-profiling.html:
        * fast/profiler/stop-profiling-after-setTimeout-expected.txt: Added.
        * fast/profiler/stop-profiling-after-setTimeout.html:
        * fast/profiler/stop-then-function-call-expected.txt: Added.
        * fast/profiler/stop-then-function-call.html:
        * fast/profiler/throw-exception-from-eval-expected.txt: Added.
        * fast/profiler/throw-exception-from-eval.html:
        * fast/profiler/two-execution-contexts-expected.txt: Added.
        * fast/profiler/two-execution-contexts.html:
        * fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Added.
        * fast/profiler/user-defined-function-calls-built-in-functions.html:
        * fast/profiler/window-dot-eval-expected.txt: Added.
        * fast/profiler/window-dot-eval.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Sam Weinig with no hesitation.

        - fix the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
          <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering

        Test: fast/text/bidi-embedding-pop-and-push-same.html

        * platform/text/BidiResolver.h:
        (WebCore::BidiResolver::embed): Changed to only add the embedding
        operation to a vector of pending operations.

        (WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Added. Moved the
        code that used to be in the PDF case of embed() here, except the part
        that sets the context.

        (WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Added. Moved the
        code that used to be in the non-PDF case of embed() here, except the
        part the sets the context.

        (WebCore::BidiResolver::commitExplicitEmbedding): Added. Processes the
        explicit embedding operations in the vector by creating an updated
        context and determining the old and new embedding levels. If the levels
        are not the same, calls {lower,raise}ExplicitEmbeddingLevel(). Always
        sets the context to the new one.

        (WebCore::BidiResolver::createBidiRunsForLine): Added calls to
        commitExplicitEmbedding() after calling embed() and after calling
        increment().

        * rendering/bidi.cpp:
        (WebCore::bidiFirst): Added calls to commitExplicitEmbedding() because
        this function increments the resolver.

        (WebCore::RenderBlock::skipLeadingWhitespace): Ditto.

LayoutTests:

        Reviewed by Sam Weinig with no hesitation.

        - test for the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
          <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering

        * fast/text/bidi-embedding-pop-and-push-same.html: Added.
        * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
        * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
        * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Gtk build fix. Not reviewed.

        Add DNSCurl and DNSSoup to the Gtk build

        * GNUmakefile.am:
        * platform/gtk/TemporaryLinkStubs.cpp:
        * platform/network/soup/DNSSoup.cpp: Copied from WebCore/platform/network/curl/DNSCurl.cpp.
        (WebCore::prefetchDNS):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Un-break the Darwin build.

        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        * platform/graphics/cg/ImageCG.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Fix forward decls to be struct instead of class.
        https://bugs.webkit.org/show_bug.cgi?id=21838

        * rendering/style/StyleRareInheritedData.h:
        * rendering/style/StyleRareNonInheritedData.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Oliver Hunt.

        * platform/network/curl/ResourceRequest.h:  A better implementation
          of CFURLRequest, rather than void*.  This gives better compatibility 
          with the WebKit.idl interface.
        (WebCore::ResourceRequest::cfURLRequest):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Tim Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=21817
        Bug 21817: Manual profiler tests should be made into layout tests

        - Here are the changes to the tests.  The most significant part is the
        change to profiler-test-JS-resources.js where endTest will now notify
        the layout test controller if it was waiting and call the print function
        to iterate over all of the profiles and log their structure.
        - Most of these tests changed to include the layoutTestController, use
        endTest() or call the print function directly if there was some reason
        that they could not use endTest().

        * fast/profiler/resources/profiler-test-JS-resources.js:
        (endTest): Stop any waits and print the profile information.
        (printHeavyProfilesDataWithoutTime): Print all profile information in 
        heavy view, without time.
        (printProfilesDataWithoutTime): Print all profile information in tree
        view, without time.
        (printProfileNodeWithoutTime): Print a profile node's informmation and
        all of it's children's information.
        * fast/profiler/anonymous-event-handler.html:
        * fast/profiler/anonymous-function-called-from-different-contexts.html:
        * fast/profiler/anonymous-function-calls-built-in-functions.html:
        * fast/profiler/anonymous-function-calls-eval.html:
        * fast/profiler/apply.html:
        * fast/profiler/built-in-function-calls-anonymous.html:
        * fast/profiler/built-in-function-calls-user-defined-function.html:
        * fast/profiler/call-nodelist-as-function.html:
        * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
        * fast/profiler/compare-multiple-profiles.html:
        * fast/profiler/constructor.html:
        * fast/profiler/dead-time.html:
        * fast/profiler/deep-recursion.html:
        * fast/profiler/document-dot-write.html:
        * fast/profiler/event-handler.html:
        * fast/profiler/execution-context-and-eval-on-same-line.html:
        * fast/profiler/heavy-view.html:
        * fast/profiler/inline-event-handler.html:
        * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
        * fast/profiler/multiple-and-different-scoped-function-calls.html:
        * fast/profiler/multiple-frames.html:
        * fast/profiler/nested-anonymous-functon.html:
        * fast/profiler/nested-start-and-stop-profiler.html:
        * fast/profiler/no-execution-context.html:
        * fast/profiler/one-execution-context.html:
        * fast/profiler/profile-calls-in-included-file.html:
        * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
        * fast/profiler/profiling-from-a-nested-location.html:
        * fast/profiler/simple-event-call.html:
        * fast/profiler/simple-no-level-change.html:
        * fast/profiler/start-and-stop-profiler-multiple-times.html:
        * fast/profiler/start-and-stop-profiling-in-the-same-function.html:
        * fast/profiler/start-but-dont-stop-profiling.html:
        * fast/profiler/stop-profiling-after-setTimeout.html:
        * fast/profiler/stop-then-function-call.html:
        * fast/profiler/throw-exception-from-eval.html:
        * fast/profiler/two-execution-contexts.html:
        * fast/profiler/user-defined-function-calls-built-in-functions.html:
        * fast/profiler/window-dot-eval.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        PLATFORM(CHROMIUM) uses CG the same way PLATFORM(MAC) does so fix
        ifdefs to reflect that.

        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        * platform/graphics/cg/ImageCG.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-10-23  Peter Kasting  <pkasting@google.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=21833
        Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).

        * wtf/Platform.h:

WebCore:

2008-10-23  Peter Kasting  <pkasting@google.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=21833
        Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        (WebCore::InspectorController::close):
        * inspector/InspectorController.h:
        * page/Page.cpp:
        (WebCore::Page::Page):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        <https://bugs.webkit.org/show_bug.cgi?id=21831>

        Reviewed by Sam Weinig.

        * kjs/create_hash_table: Escaped square brackets so that Perl 5.10
        doesn't try to use @nameEntries.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - try to get buildbot green again

        * platform/gtk/Skipped: Added fast/profiler.
        * platform/mac/Skipped: Fixed typo: fast/profiler, not fast/profile.
        * platform/qt/Skipped: Added fast/profiler.
        * platform/win/Skipped: Fixed typo: fast/profiler, not fast/profile.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Forgot to actually check these files in from last time :(

        * fast/profiler: Added.
        * fast/profiler/anonymous-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-event-handler.html.
        * fast/profiler/anonymous-function-called-from-different-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html.
        * fast/profiler/anonymous-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html.
        * fast/profiler/anonymous-function-calls-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html.
        * fast/profiler/apply.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-apply.html.
        * fast/profiler/built-in-function-calls-anonymous.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html.
        * fast/profiler/built-in-function-calls-user-defined-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html.
        * fast/profiler/call-nodelist-as-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-call-nodelist-as-function.html.
        * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html.
        * fast/profiler/compare-multiple-profiles.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-compare-multiple-profiles.html.
        * fast/profiler/constructor.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-constructor.html.
        * fast/profiler/dead-time.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-dead-time.html.
        * fast/profiler/deep-recursion.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-deep-recursion.html.
        * fast/profiler/document-dot-write.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-document-dot-write.html.
        * fast/profiler/event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-event-handler.html.
        * fast/profiler/execution-context-and-eval-on-same-line.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html.
        * fast/profiler/heavy-view.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-heavy-view.html.
        * fast/profiler/inline-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-inline-event-handler.html.
        * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html.
        * fast/profiler/multiple-and-different-scoped-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html.
        * fast/profiler/multiple-frames.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-frames.html.
        * fast/profiler/multiple-windows.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-windows.html.
        * fast/profiler/nested-anonymous-functon.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-anonymous-functon.html.
        * fast/profiler/nested-start-and-stop-profiler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html.
        * fast/profiler/no-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-no-execution-context.html.
        * fast/profiler/one-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-one-execution-context.html.
        * fast/profiler/profile-calls-in-included-file.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profile-calls-in-included-file.html.
        * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html.
        * fast/profiler/profiling-from-a-nested-location.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html.
        * fast/profiler/resources: Added.
        * fast/profiler/resources/other-frame.html: Copied from ../WebCore/manual-tests/inspector/resources/other-frame.html.
        * fast/profiler/resources/other-window.html: Copied from ../WebCore/manual-tests/inspector/resources/other-window.html.
        * fast/profiler/resources/profiler-test-JS-resources.js: Copied from ../WebCore/manual-tests/inspector/resources/profiler-test-JS-resources.js.
        * fast/profiler/simple-event-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-event-call.html.
        * fast/profiler/simple-no-level-change.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-no-level-change.html.
        * fast/profiler/start-and-stop-profiler-multiple-times.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html.
        * fast/profiler/start-and-stop-profiling-in-the-same-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html.
        * fast/profiler/start-but-dont-stop-profiling.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html.
        * fast/profiler/stop-profiling-after-setTimeout.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html.
        * fast/profiler/stop-then-function-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-then-function-call.html.
        * fast/profiler/throw-exception-from-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-throw-exception-from-eval.html.
        * fast/profiler/two-execution-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-two-execution-contexts.html.
        * fast/profiler/user-defined-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html.
        * fast/profiler/window-dot-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-window-dot-eval.html.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-10-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=21817
        Bug 21817: Manual profiler tests should be made into layout tests

        -Moving the tests before diffing so that it's clear what changed.

        * manual-tests/inspector/profiler-test-anonymous-event-handler.html: Removed.
        * manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html: Removed.
        * manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html: Removed.
        * manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html: Removed.
        * manual-tests/inspector/profiler-test-apply.html: Removed.
        * manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html: Removed.
        * manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html: Removed.
        * manual-tests/inspector/profiler-test-call-nodelist-as-function.html: Removed.
        * manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
        * manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Removed.
        * manual-tests/inspector/profiler-test-constructor.html: Removed.
        * manual-tests/inspector/profiler-test-dead-time.html: Removed.
        * manual-tests/inspector/profiler-test-deep-recursion.html: Removed.
        * manual-tests/inspector/profiler-test-document-dot-write.html: Removed.
        * manual-tests/inspector/profiler-test-event-handler.html: Removed.
        * manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html: Removed.
        * manual-tests/inspector/profiler-test-heavy-view.html: Removed.
        * manual-tests/inspector/profiler-test-inline-event-handler.html: Removed.
        * manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html: Removed.
        * manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html: Removed.
        * manual-tests/inspector/profiler-test-multiple-frames.html: Removed.
        * manual-tests/inspector/profiler-test-multiple-windows.html: Removed.
        * manual-tests/inspector/profiler-test-nested-anonymous-functon.html: Removed.
        * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html: Removed.
        * manual-tests/inspector/profiler-test-no-execution-context.html: Removed.
        * manual-tests/inspector/profiler-test-one-execution-context.html: Removed.
        * manual-tests/inspector/profiler-test-profile-calls-in-included-file.html: Removed.
        * manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
        * manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html: Removed.
        * manual-tests/inspector/profiler-test-simple-event-call.html: Removed.
        * manual-tests/inspector/profiler-test-simple-no-level-change.html: Removed.
        * manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html: Removed.
        * manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Removed.
        * manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Removed.
        * manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Removed.
        * manual-tests/inspector/profiler-test-stop-then-function-call.html: Removed.
        * manual-tests/inspector/profiler-test-throw-exception-from-eval.html: Removed.
        * manual-tests/inspector/profiler-test-two-execution-contexts.html: Removed.
        * manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html: Removed.
        * manual-tests/inspector/profiler-test-window-dot-eval.html: Removed.
        * manual-tests/inspector/resources/other-frame.html: Removed.
        * manual-tests/inspector/resources/other-window.html: Removed.
        * manual-tests/inspector/resources/profiler-test-JS-resources.js: Removed.

LayoutTests:

2008-10-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=21817
        Bug 21817: Manual profiler tests should be made into layout tests

        -Moving the tests before diffing so that it's clear what changed.

        * platform/mac/Skipped: Skipping until the new files are in place.
        * platform/win/Skipped:
        * fast/profiler: Added.
        * fast/profiler/anonymous-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-event-handler.html.
        * fast/profiler/anonymous-function-called-from-different-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html.
        * fast/profiler/anonymous-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html.
        * fast/profiler/anonymous-function-calls-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html.
        * fast/profiler/apply.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-apply.html.
        * fast/profiler/built-in-function-calls-anonymous.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html.
        * fast/profiler/built-in-function-calls-user-defined-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html.
        * fast/profiler/call-nodelist-as-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-call-nodelist-as-function.html.
        * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html.
        * fast/profiler/compare-multiple-profiles.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-compare-multiple-profiles.html.
        * fast/profiler/constructor.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-constructor.html.
        * fast/profiler/dead-time.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-dead-time.html.
        * fast/profiler/deep-recursion.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-deep-recursion.html.
        * fast/profiler/document-dot-write.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-document-dot-write.html.
        * fast/profiler/event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-event-handler.html.
        * fast/profiler/execution-context-and-eval-on-same-line.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html.
        * fast/profiler/heavy-view.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-heavy-view.html.
        * fast/profiler/inline-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-inline-event-handler.html.
        * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html.
        * fast/profiler/multiple-and-different-scoped-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html.
        * fast/profiler/multiple-frames.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-frames.html.
        * fast/profiler/multiple-windows.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-windows.html.
        * fast/profiler/nested-anonymous-functon.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-anonymous-functon.html.
        * fast/profiler/nested-start-and-stop-profiler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html.
        * fast/profiler/no-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-no-execution-context.html.
        * fast/profiler/one-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-one-execution-context.html.
        * fast/profiler/profile-calls-in-included-file.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profile-calls-in-included-file.html.
        * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html.
        * fast/profiler/profiling-from-a-nested-location.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html.
        * fast/profiler/resources: Added.
        * fast/profiler/resources/other-frame.html: Copied from ../WebCore/manual-tests/inspector/resources/other-frame.html.
        * fast/profiler/resources/other-window.html: Copied from ../WebCore/manual-tests/inspector/resources/other-window.html.
        * fast/profiler/resources/profiler-test-JS-resources.js: Copied from ../WebCore/manual-tests/inspector/resources/profiler-test-JS-resources.js.
        * fast/profiler/simple-event-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-event-call.html.
        * fast/profiler/simple-no-level-change.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-no-level-change.html.
        * fast/profiler/start-and-stop-profiler-multiple-times.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html.
        * fast/profiler/start-and-stop-profiling-in-the-same-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html.
        * fast/profiler/start-but-dont-stop-profiling.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html.
        * fast/profiler/stop-profiling-after-setTimeout.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html.
        * fast/profiler/stop-then-function-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-then-function-call.html.
        * fast/profiler/throw-exception-from-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-throw-exception-from-eval.html.
        * fast/profiler/two-execution-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-two-execution-contexts.html.
        * fast/profiler/user-defined-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html.
        * fast/profiler/window-dot-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-window-dot-eval.html.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by John Sullivan.

        Fix <rdar://problem/6306513> by adding a workaround for <rdar://problem/6304600>.

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21826

        Add accessor for SecurityOrigin::m_domainWasSetInDOM.

        * page/SecurityOrigin.h:
        (WebCore::SecurityOrigin::domainWasSetInDOM):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix Bug 21401: Comments field on "Review Patch" page should be initially filled with quoted patch

        <https://bugs.webkit.org/show_bug.cgi?id=21401>

        Reviewed by Dave Hyatt.

        * attachment.cgi:
        (edit): Retrieve the attachment data from the database instead of just
        its length. When the attachment is a patch, create a quotedpatch
        template variable that contains the patch data with each line
        prepended with "> ".
        * template/en/custom/attachment/reviewform.html.tmpl:
          - Changed the comments field to have a monospace font
          - Added an "Enter comments below:" caption above the comments field
            to make it clearer that this is where comments should go, now that
            the comments field is not initially empty
          - Fill the comments field with the quoted patch

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-10-23  Darin Adler  <darin@apple.com>

        - roll out https://bugs.webkit.org/show_bug.cgi?id=21732
          to remove the JSValuePtr class, to fix two problems

            1) slowness under MSVC, since it doesn't handle a
               class with a single pointer in it as efficiently
               as a pointer

            2) uninitialized pointers in Vector

        * JavaScriptCore.exp: Updated.

        * API/APICast.h:
        (toRef):
        * VM/CTI.cpp:
        (JSC::CTI::asInteger):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::addConstant):
        * VM/CodeGenerator.h:
        (JSC::CodeGenerator::JSValueHashTraits::constructDeletedValue):
        (JSC::CodeGenerator::JSValueHashTraits::isDeletedValue):
        * VM/Machine.cpp:
        (JSC::Machine::cti_op_add):
        (JSC::Machine::cti_op_pre_inc):
        (JSC::Machine::cti_op_get_by_id):
        (JSC::Machine::cti_op_get_by_id_second):
        (JSC::Machine::cti_op_get_by_id_generic):
        (JSC::Machine::cti_op_get_by_id_fail):
        (JSC::Machine::cti_op_instanceof):
        (JSC::Machine::cti_op_del_by_id):
        (JSC::Machine::cti_op_mul):
        (JSC::Machine::cti_op_call_NotJSFunction):
        (JSC::Machine::cti_op_resolve):
        (JSC::Machine::cti_op_construct_NotJSConstruct):
        (JSC::Machine::cti_op_get_by_val):
        (JSC::Machine::cti_op_sub):
        (JSC::Machine::cti_op_lesseq):
        (JSC::Machine::cti_op_negate):
        (JSC::Machine::cti_op_resolve_base):
        (JSC::Machine::cti_op_resolve_skip):
        (JSC::Machine::cti_op_resolve_global):
        (JSC::Machine::cti_op_div):
        (JSC::Machine::cti_op_pre_dec):
        (JSC::Machine::cti_op_not):
        (JSC::Machine::cti_op_eq):
        (JSC::Machine::cti_op_lshift):
        (JSC::Machine::cti_op_bitand):
        (JSC::Machine::cti_op_rshift):
        (JSC::Machine::cti_op_bitnot):
        (JSC::Machine::cti_op_mod):
        (JSC::Machine::cti_op_less):
        (JSC::Machine::cti_op_neq):
        (JSC::Machine::cti_op_urshift):
        (JSC::Machine::cti_op_bitxor):
        (JSC::Machine::cti_op_bitor):
        (JSC::Machine::cti_op_call_eval):
        (JSC::Machine::cti_op_throw):
        (JSC::Machine::cti_op_next_pname):
        (JSC::Machine::cti_op_typeof):
        (JSC::Machine::cti_op_is_undefined):
        (JSC::Machine::cti_op_is_boolean):
        (JSC::Machine::cti_op_is_number):
        (JSC::Machine::cti_op_is_string):
        (JSC::Machine::cti_op_is_object):
        (JSC::Machine::cti_op_is_function):
        (JSC::Machine::cti_op_stricteq):
        (JSC::Machine::cti_op_nstricteq):
        (JSC::Machine::cti_op_to_jsnumber):
        (JSC::Machine::cti_op_in):
        (JSC::Machine::cti_op_del_by_val):
        (JSC::Machine::cti_vm_throw):
        Removed calls to payload functions.

        * VM/Register.h:
        (JSC::Register::Register): Removed overload for JSCell and call
        to payload function.

        * kjs/JSCell.h: Changed JSCell to derive from JSValue again.
        Removed JSValuePtr constructor.
        (JSC::asCell): Changed cast from reinterpret_cast to static_cast.

        * kjs/JSImmediate.h: Removed JSValuePtr class. Added typedef back.

        * kjs/JSValue.h:
        (JSC::JSValue::JSValue): Added empty protected inline constructor back.
        (JSC::JSValue::~JSValue): Same for destructor.
        Removed == and != operator for JSValuePtr.

        * kjs/PropertySlot.h:
        (JSC::PropertySlot::PropertySlot): Chnaged argument to const JSValue*
        and added a const_cast.

        * kjs/protect.h: Removed overloads and specialization for JSValuePtr.

JavaScriptGlue:

2008-10-23  Darin Adler  <darin@apple.com>

        - roll out https://bugs.webkit.org/show_bug.cgi?id=21732

        * JSValueWrapper.cpp:
        (JSValueWrapper::GetValue): Added missing call to .get().
        * JSValueWrapper.h: ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.

WebCore:

2008-10-23  Darin Adler  <darin@apple.com>

        - roll out https://bugs.webkit.org/show_bug.cgi?id=21732

        * bindings/js/ScheduledAction.h:
        * inspector/InspectorController.cpp:
        ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37812 268f45cc-cd09-0410-ab3c-d52691b4dbfc