1. 18 Jan, 2014 24 commits
    • andersca@apple.com's avatar
      Remove support for the viewsource attribute · 98ae35b6
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127232
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      The 'viewsource' attribute on frames is nonstandard, not used by anyone (the inspector has
      its own syntax highlighting) and not audited.
      
      This patch removes parsing of the viewsource attribute and the associated tests. A subsequent
      patch will remove the code as well.
      
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::parseAttribute):
      
      Source/WTF:
      
      * wtf/FeatureDefines.h:
      
      LayoutTests:
      
      * .gitattributes:
      * fast/frames/resources/viewsource-fake-image-file.png: Removed.
      * fast/frames/resources/viewsource-frame-1.html: Removed.
      * fast/frames/resources/viewsource-frame-2.html: Removed.
      * fast/frames/resources/viewsource-frame-3.html: Removed.
      * fast/frames/resources/viewsource-frame-4.html: Removed.
      * fast/frames/resources/viewsource-frame-5.html: Removed.
      * fast/frames/resources/viewsource-frame-unfinished-script.html: Removed.
      * fast/frames/resources/viewsource-frame-unfinished-textarea.html: Removed.
      * fast/frames/viewsource-attribute.html: Removed.
      * fast/frames/viewsource-empty-attribute-value-expected.txt: Removed.
      * fast/frames/viewsource-empty-attribute-value.html: Removed.
      * fast/frames/viewsource-linebreak-expected.txt: Removed.
      * fast/frames/viewsource-linebreak.html: Removed.
      * fast/frames/viewsource-link-on-href-value-expected.txt: Removed.
      * fast/frames/viewsource-link-on-href-value.html: Removed.
      * fast/frames/viewsource-on-image-file.html: Removed.
      * fast/frames/viewsource-plain-text-tags-expected.txt: Removed.
      * fast/frames/viewsource-plain-text-tags.html: Removed.
      * fast/frames/viewsource-unfinished-tags-expected.txt: Removed.
      * fast/frames/viewsource-unfinished-tags.html: Removed.
      * fast/frames/viewsource-xml-expected.txt: Removed.
      * fast/frames/viewsource-xml.html: Removed.
      * http/tests/security/resources/view-source-no-refresh.php: Removed.
      * http/tests/security/view-source-javascript-url-in-document-expected.txt: Removed.
      * http/tests/security/view-source-javascript-url-in-document.html: Removed.
      * http/tests/security/view-source-no-javascript-url-expected.txt: Removed.
      * http/tests/security/view-source-no-javascript-url.html: Removed.
      * http/tests/security/view-source-no-refresh-expected.txt: Removed.
      * http/tests/security/view-source-no-refresh.html: Removed.
      * platform/efl/fast/frames/viewsource-attribute-expected.png: Removed.
      * platform/efl/fast/frames/viewsource-attribute-expected.txt: Removed.
      * platform/efl/fast/frames/viewsource-on-image-file-expected.png: Removed.
      * platform/efl/fast/frames/viewsource-on-image-file-expected.txt: Removed.
      * platform/mac/fast/frames/viewsource-attribute-expected.png: Removed.
      * platform/mac/fast/frames/viewsource-attribute-expected.txt: Removed.
      * platform/mac/fast/frames/viewsource-on-image-file-expected.png: Removed.
      * platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Removed.
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98ae35b6
    • commit-queue@webkit.org's avatar
      Flesh out session APIs (still not enabled at API level). · f31e4690
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126918
      
      Patch by Martin Hock <mhock@apple.com> on 2014-01-18
      Reviewed by Alexey Proskuryakov.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * NetworkProcess/NetworkConnectionToWebProcess.cpp:
      (WebKit::storageSession):
      (WebKit::NetworkConnectionToWebProcess::startDownload):
      (WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
      (WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
      (WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
      (WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
      (WebKit::NetworkConnectionToWebProcess::getRawCookies):
      (WebKit::NetworkConnectionToWebProcess::deleteCookie):
      * NetworkProcess/NetworkConnectionToWebProcess.h:
      * NetworkProcess/NetworkConnectionToWebProcess.messages.in:
      * NetworkProcess/NetworkProcess.cpp:
      (WebKit::NetworkProcess::initializeNetworkProcess):
      (WebKit::NetworkProcess::ensurePrivateBrowsingSession):
      (WebKit::NetworkProcess::destroyPrivateBrowsingSession):
      * NetworkProcess/NetworkProcess.h:
      * NetworkProcess/NetworkProcess.messages.in:
      * NetworkProcess/RemoteNetworkingContext.h:
      * NetworkProcess/mac/RemoteNetworkingContext.mm:
      (WebKit::RemoteNetworkingContext::storageSession):
      (WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
      * NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:
      (WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
      * Shared/SessionTracker.cpp: Copied from Source/WebKit2/UIProcess/APISession.cpp.
      (WebKit::sessionMap):
      (WebKit::identifierBase):
      (WebKit::SessionTracker::getSessionMap):
      (WebKit::SessionTracker::getIdentifierBase):
      (WebKit::SessionTracker::session):
      (WebKit::SessionTracker::destroySession):
      (WebKit::SessionTracker::setIdentifierBase):
      * Shared/SessionTracker.h: Copied from Source/WebKit2/UIProcess/APISession.h.
      (WebKit::SessionTracker::isEphemeralID):
      * Shared/mac/CookieStorageShim.cpp:
      (WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
      * UIProcess/APISession.cpp:
      (API::generateID):
      (API::Session::defaultSession):
      (API::Session::legacyPrivateSession):
      (API::Session::Session):
      (API::Session::create):
      (API::Session::isEphemeral):
      (API::Session::getID):
      * UIProcess/APISession.h:
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
      (WebKit::WebContext::createNewWebProcess):
      (WebKit::WebContext::createWebPage):
      * UIProcess/WebContext.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::create):
      (WebKit::WebPageProxy::WebPageProxy):
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::sessionID):
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::createWebPage):
      * UIProcess/WebProcessProxy.h:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setPrivateBrowsingEnabled):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::legacySessionID):
      (WebKit::WebPlatformStrategies::cookiesForDOM):
      (WebKit::WebPlatformStrategies::setCookiesFromDOM):
      (WebKit::WebPlatformStrategies::cookiesEnabled):
      (WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
      (WebKit::WebPlatformStrategies::getRawCookies):
      (WebKit::WebPlatformStrategies::deleteCookie):
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      (WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
      (WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
      (WebKit::WebFrameNetworkingContext::storageSession):
      * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
      (WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
      (WebKit::WebFrameNetworkingContext::storageSession):
      * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess):
      (WebKit::WebProcess::ensurePrivateBrowsingSession):
      (WebKit::WebProcess::destroyPrivateBrowsingSession):
      * WebProcess/WebProcess.h:
      * WebProcess/WebProcess.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f31e4690
    • mark.lam@apple.com's avatar
      Add a hasBreakpointFlag arg to the op_debug bytecode. · 31fc87e2
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127230.
      
      Reviewed by Geoffrey Garen.
      
      This is in anticipation of upcoming changes to support bytecode level
      breakpoints. This patch adds the flag to the op_debug bytecode and
      initializes it, but does not use it yet.
      
      * bytecode/Opcode.h:
      (JSC::padOpcodeName):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitDebugHook):
      * llint/LowLevelInterpreter.asm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31fc87e2
    • andersca@apple.com's avatar
      XMLTreeViewer shouldn't use the view source mode · 8fb478db
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127229
      
      Reviewed by Andreas Kling.
      
      Add the relevant styles from view-source.css to XMLViewer.css.
      
      * xml/XMLTreeViewer.cpp:
      (WebCore::XMLTreeViewer::transformDocumentToTreeView):
      * xml/XMLViewer.css:
      (body):
      (.comment):
      (.tag):
      (.attribute-name):
      (.attribute-value):
      * xml/XMLViewer.js:
      (createComment):
      (createTag):
      (createAttribute):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fb478db
    • bburg@apple.com's avatar
      Another build fix attempt for Windows and EFL WebKit1. · a024b90a
      bburg@apple.com authored
      Source/WebKit:
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      Source/WebKit/efl:
      
      * ewk/ewk_paint_context.cpp:
      (ewk_paint_context_paint_contents):
      * ewk/ewk_view.cpp:
      (_ewk_view_smart_repaints_process):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a024b90a
    • bburg@apple.com's avatar
      Unreviewed build fix attempt for Windows. · 157e2231
      bburg@apple.com authored
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      157e2231
    • berto@igalia.com's avatar
      JavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN) · 440848ac
      berto@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=99683
      
      Reviewed by Anders Carlsson.
      
      * jit/ThunkGenerators.cpp:
      * tools/CodeProfile.cpp:
      (JSC::symbolName):
      (JSC::CodeProfile::sample):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      440848ac
    • akling@apple.com's avatar
      Remove unused "touchDragDropEnabled" setting. · ceb7f9ee
      akling@apple.com authored
      <https://webkit.org/b/127227>
      
      Reviewed by Sam Weinig.
      
      * page/Settings.in:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ceb7f9ee
    • bburg@apple.com's avatar
      Web Inspector: Page should use std::unique_ptr for InspectorController · 9efd2cdf
      bburg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127068
      
      Reviewed by Joseph Pecoraro.
      
      Source/WebCore:
      
      Make Page and WorkerGlobalScope keep a std::unique_ptr to InspectorController
      and WorkerInspectorController. Store page references and return controller
      references where possible.
      
      Convert call sites to use an InspectorController reference.
      Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
      Convert InspectorOverlay to keep Page references.
      
      * WebCore.exp.in:
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::supportsProfiling):
      (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
      * dom/Node.cpp:
      (WebCore::Node::inspect):
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::inspectedPageDestroyed):
      (WebCore::InspectorController::setInspectorFrontendClient):
      (WebCore::InspectorController::hasInspectorFrontendClient):
      (WebCore::InspectorController::connectFrontend):
      (WebCore::InspectorController::disconnectFrontend):
      (WebCore::InspectorController::inspectedPage):
      (WebCore::InspectorController::developerExtrasEnabled):
      * inspector/InspectorController.h:
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::canAttachWindow):
      (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
      (WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
      (WebCore::InspectorFrontendClientLocal::openInNewTab):
      (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::InspectorOverlay):
      (WebCore::InspectorOverlay::getHighlight):
      (WebCore::InspectorOverlay::highlightQuad):
      (WebCore::InspectorOverlay::update):
      (WebCore::InspectorOverlay::buildObjectForHighlightedNode):
      (WebCore::InspectorOverlay::drawQuadHighlight):
      (WebCore::InspectorOverlay::overlayPage):
      (WebCore::InspectorOverlay::reset):
      * inspector/InspectorOverlay.h:
      * inspector/InstrumentingAgents.cpp:
      (WebCore::instrumentationForPage): remove null checks.
      (WebCore::instrumentationForWorkerGlobalScope): remove null checks.
      * inspector/WorkerInspectorController.cpp:
      (WebCore::WorkerInspectorController::WorkerInspectorController):
      (WebCore::WorkerInspectorController::connectFrontend):
      (WebCore::WorkerInspectorController::disconnectFrontend):
      * inspector/WorkerInspectorController.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
      (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::showContextMenu):
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::addInspectElementItem):
      * page/FrameView.cpp:
      (WebCore::FrameView::sendResizeEventIfNeeded):
      * page/Page.cpp:
      (WebCore::Page::Page):
      * page/Page.h:
      (WebCore::Page::inspectorController):
      * page/PageDebuggable.cpp:
      (WebCore::PageDebuggable::hasLocalDebugger):
      (WebCore::PageDebuggable::parentProcessIdentifier):
      (WebCore::PageDebuggable::connect):
      (WebCore::PageDebuggable::disconnect):
      (WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend):
      (WebCore::PageDebuggable::setIndicating):
      * platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
      (WebCore::CompositingCoordinator::syncDisplayState):
      * testing/Internals.cpp:
      (WebCore::Internals::resetToConsistentState):
      (WebCore::Internals::inspectorHighlightRects):
      (WebCore::Internals::inspectorHighlightObject):
      (WebCore::Internals::emitInspectorDidBeginFrame):
      (WebCore::Internals::emitInspectorDidCancelFrame):
      (WebCore::Internals::openDummyInspectorFrontend):
      (WebCore::Internals::closeDummyInspectorFrontend):
      (WebCore::Internals::setInspectorResourcesDataSizeLimits):
      (WebCore::Internals::setJavaScriptProfilingEnabled):
      * workers/WorkerGlobalScope.cpp:
      (WebCore::WorkerGlobalScope::WorkerGlobalScope):
      * workers/WorkerGlobalScope.h: remove clearInspector().
      (WebCore::WorkerGlobalScope::workerInspectorController):
      * workers/WorkerMessagingProxy.cpp:
      (WebCore::connectToWorkerGlobalScopeInspectorTask):
      (WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
      (WebCore::dispatchOnInspectorBackendTask):
      * workers/WorkerThread.cpp:
      (WebCore::WorkerThreadShutdownFinishTask::performTask):
      
      Source/WebKit/efl:
      
      Convert call sites to use a InspectorController reference.
      Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::evaluateInWebInspector):
      * WebCoreSupport/InspectorClientEfl.cpp:
      (WebCore::InspectorClientEfl::openInspectorFrontend):
      * ewk/ewk_view.cpp:
      (ewk_view_inspector_show):
      (ewk_view_inspector_close):
      
      Source/WebKit/gtk:
      
      Convert call sites to use a InspectorController reference.
      Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::paintWebView):
      * WebCoreSupport/InspectorClientGtk.cpp:
      (WebKit::InspectorClient::openInspectorFrontend):
      * webkit/webkitwebinspector.cpp:
      (webkit_web_inspector_set_property):
      (webkit_web_inspector_get_property):
      (webkit_web_inspector_show):
      (webkit_web_inspector_inspect_node):
      (webkit_web_inspector_inspect_coordinates):
      (webkit_web_inspector_close):
      (webkit_web_inspector_execute_script):
      
      Source/WebKit/mac:
      
      Convert call sites to use a InspectorController reference.
      Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
      
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorClient::openInspectorFrontend):
      (-[WebInspectorWindowController destroyInspectorView:]):
      * WebInspector/WebInspector.mm:
      (-[WebInspector showWindow]):
      (-[WebInspector isJavaScriptProfilingEnabled]):
      (-[WebInspector setJavaScriptProfilingEnabled:]):
      (-[WebInspector close:]):
      (-[WebInspector evaluateInFrontend:callId:script:]):
      * WebInspector/WebNodeHighlighter.mm:
      (-[WebNodeHighlighter highlight]):
      
      Source/WebKit/win:
      
      Convert call sites to use a InspectorController reference.
      
      * WebCoreSupport/WebInspectorClient.cpp:
      (WebInspectorClient::openInspectorFrontend):
      (WebInspectorFrontendClient::destroyInspectorView):
      (WebInspectorFrontendClient::onClose):
      * WebInspector.cpp:
      (WebInspector::show):
      (WebInspector::close):
      (WebInspector::isJavaScriptProfilingEnabled):
      (WebInspector::setJavaScriptProfilingEnabled):
      (WebInspector::evaluateInFrontend):
      * WebNodeHighlight.cpp:
      (WebNodeHighlight::update):
      
      Source/WebKit2:
      
      Convert call sites to use a InspectorController reference.
      
      * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
      (WebKit::WebInspectorClient::drawRect):
      * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
      (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
      (WebKit::WebInspectorFrontendClient::closeWindow):
      * WebProcess/WebPage/WebInspector.cpp:
      (WebKit::WebInspector::createInspectorPage):
      (WebKit::WebInspector::show):
      (WebKit::WebInspector::close):
      (WebKit::WebInspector::evaluateScriptForTest):
      (WebKit::WebInspector::showConsole):
      (WebKit::WebInspector::showResources):
      (WebKit::WebInspector::showMainResourceForFrame):
      (WebKit::WebInspector::startJavaScriptDebugging):
      (WebKit::WebInspector::stopJavaScriptDebugging):
      (WebKit::WebInspector::setJavaScriptProfilingEnabled):
      (WebKit::WebInspector::startJavaScriptProfiling):
      (WebKit::WebInspector::stopJavaScriptProfiling):
      (WebKit::WebInspector::startPageProfiling):
      (WebKit::WebInspector::stopPageProfiling):
      (WebKit::WebInspector::dispatchMessageFromRemoteFrontend):
      (WebKit::WebInspector::remoteFrontendConnected):
      (WebKit::WebInspector::remoteFrontendDisconnected):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9efd2cdf
    • ap@apple.com's avatar
      build.webkit.org/dashboard should have image diff links in test results popovers · ce799f77
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127188
      
      Reviewed by Timothy Hatcher.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
      (Buildbot.prototype.layoutTestImagesURLForIteration):
      (Buildbot.prototype.layoutTestImageDiffURLForIteration):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
      (BuildbotIteration.prototype.loadLayoutTestResults):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
      (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
      (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
      (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce799f77
    • ap@apple.com's avatar
      media/video-size.html is flaky · 6b7db955
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124932
      
      * platform/efl/TestExpectations:
      * platform/TestExpectations:
      Moving flakiness expectation to cross-platform file, as it also fails on Mac in the same way.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b7db955
    • ap@apple.com's avatar
      media/video-display-aspect-ratio.html fails · 4e6a3857
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=35297
      
      * platform/mac/TestExpectations: Marking as flaky.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e6a3857
    • andersca@apple.com's avatar
      Remove ENABLE_THREADED_HTML_PARSER defines everywhere · 910d4806
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127225
      
      Reviewed by Andreas Kling.
      
      This concludes the removal of over 8.8 million lines of threaded parser code.
      
      .:
      
      * Source/autotools/SetupWebKitFeatures.m4:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WTF:
      
      * wtf/FeatureDefines.h:
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      910d4806
    • commit-queue@webkit.org's avatar
      Make WKRenderingProgressEvents a shareable API. · d6024263
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127213
      
      Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-18
      Reviewed by Dan Bernstein.
      
      Move WKRenderingProgressEvents from UIProcess to Shared, so that an inject bundle
      could also use this enum when listening to layout milestones.
      
      * Shared/API/Cocoa/WKRenderingProgressEvents.h: Added.
      (NS_OPTIONS):
      * Shared/API/Cocoa/WKRenderingProgressEventsInternal.h: Added.
      (renderingProgressEvents):
      * UIProcess/API/Cocoa/WKBrowsingContextController.h: Move WKRenderingProgressEvents to Shared/API/Cocoa/WKRenderingProgressEvents.h.
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm: Move renderingProgressEvents() to WKRenderingProgressEventsInternal.h.
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Add
          webProcessPlugInBrowserContextController:renderingProgressDidChange: to load delegate.
      * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
      (didLayout):
      (setUpPageLoaderClient): Also listen to didLayout callback for layout milestones.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6024263
    • andersca@apple.com's avatar
      Remove the remaining threaded parser code · d91e6a57
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127224
      
      Reviewed by Andreas Kling.
      
      * dom/Document.cpp:
      (WebCore::Document::decrementActiveParserCount):
      * html/parser/AtomicHTMLToken.h:
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::HTMLDocumentParser):
      (WebCore::HTMLDocumentParser::detach):
      (WebCore::HTMLDocumentParser::stopParsing):
      (WebCore::HTMLDocumentParser::prepareToStopParsing):
      (WebCore::HTMLDocumentParser::resumeParsingAfterYield):
      (WebCore::HTMLDocumentParser::forcePlaintextForTextDocument):
      (WebCore::HTMLDocumentParser::insert):
      (WebCore::HTMLDocumentParser::append):
      (WebCore::HTMLDocumentParser::end):
      (WebCore::HTMLDocumentParser::finish):
      (WebCore::HTMLDocumentParser::textPosition):
      (WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
      * html/parser/HTMLDocumentParser.h:
      * html/parser/HTMLParserIdioms.cpp:
      * html/parser/HTMLParserIdioms.h:
      * html/parser/HTMLTokenizer.cpp:
      * html/parser/HTMLTokenizer.h:
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::isLoading):
      (WebCore::DocumentLoader::checkLoadComplete):
      * page/Settings.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d91e6a57
    • andersca@apple.com's avatar
      Remove threaded parser code from the preload scanners · c7250bab
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127222
      
      Reviewed by Andreas Kling.
      
      * html/parser/CSSPreloadScanner.cpp:
      (WebCore::CSSPreloadScanner::CSSPreloadScanner):
      Use nullptr.
      
      (WebCore::CSSPreloadScanner::scan):
      Move scanCommon here and simplify the code.
      
      * html/parser/CSSPreloadScanner.h:
      Remove scanCommon.
      
      * html/parser/HTMLPreloadScanner.cpp:
      (WebCore::TokenPreloadScanner::tagIdFor):
      TagId is a strong enum now, update enum values.
      
      (WebCore::TokenPreloadScanner::initiatorFor):
      Ditto.
      
      (WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
      Ditto.
      
      (WebCore::TokenPreloadScanner::StartTagScanner::match):
      Indent this.
      
      (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
      TagId is a strong enum now, update enum values.
      
      (WebCore::TokenPreloadScanner::StartTagScanner::charset):
      Ditto.
      
      (WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
      Ditto.
      
      (WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
      Ditto.
      
      (WebCore::TokenPreloadScanner::scan):
      Merge scan and scanCommon.
      
      * html/parser/HTMLPreloadScanner.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7250bab
    • mark.lam@apple.com's avatar
      Adding UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn().. · 440584f1
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127127.
      
      Reviewed by Geoffrey Garen.
      
      In order to implement bytecode level breakpoints, we need a mechanism
      for computing the best fit op_debug bytecode offset for any valid given
      line and column value in the source. The "best fit" op_debug bytecode
      in this case is defined below in the comment for
      UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn().
      
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::opDebugBytecodeOffsetForLineAndColumn):
      - Convert the line and column to unlinked line and column values and
        pass them to UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn()
        to do the real work.
      
      * bytecode/CodeBlock.h:
      * bytecode/LineColumnInfo.h: Added.
      (JSC::LineColumnInfo::operator <):
      (JSC::LineColumnInfo::LineColumnPair::LineColumnPair):
      (JSC::LineColumnInfo::operator ==):
      (JSC::LineColumnInfo::operator !=):
      (JSC::LineColumnInfo::operator <=):
      (JSC::LineColumnInfo::operator >):
      (JSC::LineColumnInfo::operator >=):
      * bytecode/LineInfo.h: Removed.
      
      * bytecode/UnlinkedCodeBlock.cpp:
      (JSC::UnlinkedCodeBlock::decodeExpressionRangeLineAndColumn):
      - Factored this out of expressionRangeForBytecodeOffset() so that it can
        be called from multiple places.
      (JSC::dumpLineColumnEntry):
      (JSC::UnlinkedCodeBlock::dumpExpressionRangeInfo):
      (JSC::UnlinkedCodeBlock::dumpOpDebugLineColumnInfoList):
      - Some dumpers for debugging use only.
      (JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
      (JSC::UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn):
      - Finds the earliest op_debug bytecode whose line and column matches the
        specified line and column values. If an exact match is not found, then
        finds the nearest op_debug bytecode that precedes the specified line
        and column values. If there are more than one op_debug at that preceding
        line and column value, then the earliest of those op_debug bytecodes will
        be be selected. The offset of the selected bytecode will be returned.
      
        We want the earliest one because when we have multiple op_debug bytecodes
        that map to a given line and column, a debugger user would expect to break
        on the first one and step through the rest thereafter if needed.
      
      (JSC::compareLineColumnInfo):
      (JSC::UnlinkedCodeBlock::opDebugLineColumnInfoList):
      - Creates the sorted opDebugLineColumnInfoList on demand. This list is
        stored in the UnlinkedCodeBlock's rareData.
      * bytecode/UnlinkedCodeBlock.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      440584f1
    • akling@apple.com's avatar
      Remove Nix files from WebCore · 4041f1f2
      akling@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127176
      
      Patch by Lauro Neto <lauro.neto@openbossa.org> on 2014-01-18
      Reviewed by Anders Carlsson.
      
      .:
      
      * Source/cmake/OptionsNix.cmake: Removed.
      
      Source/WebCore:
      
      * PlatformNix.cmake: Removed.
      * css/mediaControlsNix.css: Removed.
      * css/mediaControlsNixFullscreen.css: Removed.
      * editing/nix/EditorNix.cpp: Removed.
      * page/nix/EventHandlerNix.cpp: Removed.
      * platform/audio/nix/AudioBusNix.cpp: Removed.
      * platform/audio/nix/AudioDestinationNix.cpp: Removed.
      * platform/audio/nix/AudioDestinationNix.h: Removed.
      * platform/audio/nix/FFTFrameNix.cpp: Removed.
      * platform/graphics/nix/IconNix.cpp: Removed.
      * platform/graphics/nix/ImageNix.cpp: Removed.
      * platform/nix/CursorNix.cpp: Removed.
      * platform/nix/DragDataNix.cpp: Removed.
      * platform/nix/DragImageNix.cpp: Removed.
      * platform/nix/ErrorsNix.cpp: Removed.
      * platform/nix/ErrorsNix.h: Removed.
      * platform/nix/FileSystemNix.cpp: Removed.
      * platform/nix/GamepadsNix.cpp: Removed.
      * platform/nix/LanguageNix.cpp: Removed.
      * platform/nix/LocalizedStringsNix.cpp: Removed.
      * platform/nix/MIMETypeRegistryNix.cpp: Removed.
      * platform/nix/NixKeyboardUtilities.cpp: Removed.
      * platform/nix/NixKeyboardUtilities.h: Removed.
      * platform/nix/PasteboardNix.cpp: Removed.
      * platform/nix/PlatformKeyboardEventNix.cpp: Removed.
      * platform/nix/PlatformScreenNix.cpp: Removed.
      * platform/nix/RenderThemeNix.cpp: Removed.
      * platform/nix/RenderThemeNix.h: Removed.
      * platform/nix/ScrollbarThemeNix.cpp: Removed.
      * platform/nix/ScrollbarThemeNix.h: Removed.
      * platform/nix/SharedTimerNix.cpp: Removed.
      * platform/nix/SoundNix.cpp: Removed.
      * platform/nix/TemporaryLinkStubs.cpp: Removed.
      * platform/nix/WidgetNix.cpp: Removed.
      * platform/nix/support/MultiChannelPCMData.cpp: Removed.
      * platform/text/nix/TextBreakIteratorInternalICUNix.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4041f1f2
    • andersca@apple.com's avatar
      Remove DocumentParser::pinToMainThread() and related code · 7256f67f
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127221
      
      Reviewed by Andreas Kling.
      
      * dom/Document.cpp:
      (WebCore::Document::setContent):
      * dom/DocumentParser.h:
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::HTMLDocumentParser):
      * html/parser/HTMLDocumentParser.h:
      * html/parser/HTMLParserOptions.cpp:
      (WebCore::HTMLParserOptions::HTMLParserOptions):
      * html/parser/HTMLParserOptions.h:
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processEndTag):
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::replaceDocument):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7256f67f
    • andersca@apple.com's avatar
      Remove HTMLParserThread · 67fbf72f
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127220
      
      Reviewed by Andreas Kling.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * html/parser/HTMLDocumentParser.cpp:
      * html/parser/HTMLParserThread.cpp: Removed.
      * html/parser/HTMLParserThread.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67fbf72f
    • akling@apple.com's avatar
      GC soon after responding to fake memory pressure. · 2da4d079
      akling@apple.com authored
      <https://webkit.org/b/127210>
      
      Ask JSC to garbage collect "soon" after handling the fake memory
      pressure signal on Mac. This seems to stabilize the post-pressure
      numbers on Membuster3 a bit on my laptop. The difference is mostly
      made up of JSC::CodeBlock objects.
      
      Reviewed by Geoffrey Garen.
      
      * platform/mac/MemoryPressureHandlerMac.mm:
      (WebCore::MemoryPressureHandler::install):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2da4d079
    • andersca@apple.com's avatar
      Remove files only used by the threaded HTML parser · 480a5088
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127219
      <rdar://problem/13331277>
      
      Reviewed by Andreas Kling.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * html/parser/AtomicHTMLToken.h:
      * html/parser/BackgroundHTMLInputStream.cpp: Removed.
      * html/parser/BackgroundHTMLInputStream.h: Removed.
      * html/parser/BackgroundHTMLParser.cpp: Removed.
      * html/parser/BackgroundHTMLParser.h: Removed.
      * html/parser/CompactHTMLToken.cpp: Removed.
      * html/parser/CompactHTMLToken.h: Removed.
      * html/parser/HTMLDocumentParser.cpp:
      * html/parser/HTMLDocumentParser.h:
      * html/parser/HTMLIdentifier.cpp: Removed.
      * html/parser/HTMLIdentifier.h: Removed.
      * html/parser/HTMLParserIdioms.h:
      * html/parser/HTMLPreloadScanner.h:
      * html/parser/HTMLTreeBuilderSimulator.cpp: Removed.
      * html/parser/HTMLTreeBuilderSimulator.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      480a5088
    • zandobersek@gmail.com's avatar
      Inspector scripts are not compatible with Python v3 · 5b9e8cd6
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127128
      
      Reviewed by Benjamin Poulain.
      
      * inspector/scripts/generate-combined-inspector-json.py: Turn print statements into print function calls.
      * inspector/scripts/jsmin.py: Try importing the StringIO class from the StringIO module (which will work for
      Python v2) or, on import error, import the class from the io module (which will work for Python v3).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b9e8cd6
    • zandobersek@gmail.com's avatar
      [GTK] Bump the minimum required Clang version to 3.3 · fafa5dd7
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127178
      
      Reviewed by Martin Robinson.
      
      * Source/autotools/CheckSystemAndBasicDependencies.m4: Require Clang 3.3 or later when using the Clang compiler to
      build the GTK port. Building with Clang 3.2 doesn't work anymore and there's no point in fixing that, as we should
      support the latest two versions of Clang (3.3 and 3.4), just like we do with GCC (4.7 and 4.8).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fafa5dd7
  2. 17 Jan, 2014 16 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r162237 and r162241. · 61452451
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/162237
      http://trac.webkit.org/changeset/162241
      https://bugs.webkit.org/show_bug.cgi?id=127216
      
      Broke lots of API tests (Requested by ap on #webkit).
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * NetworkProcess/NetworkConnectionToWebProcess.cpp:
      (WebKit::storageSession):
      (WebKit::NetworkConnectionToWebProcess::startDownload):
      (WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
      (WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
      (WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
      (WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
      (WebKit::NetworkConnectionToWebProcess::getRawCookies):
      (WebKit::NetworkConnectionToWebProcess::deleteCookie):
      * NetworkProcess/NetworkConnectionToWebProcess.h:
      * NetworkProcess/NetworkConnectionToWebProcess.messages.in:
      * NetworkProcess/NetworkProcess.cpp:
      (WebKit::NetworkProcess::initializeNetworkProcess):
      (WebKit::NetworkProcess::ensurePrivateBrowsingSession):
      (WebKit::NetworkProcess::destroyPrivateBrowsingSession):
      * NetworkProcess/NetworkProcess.h:
      * NetworkProcess/NetworkProcess.messages.in:
      * NetworkProcess/RemoteNetworkingContext.h:
      * NetworkProcess/mac/RemoteNetworkingContext.mm:
      (WebKit::privateBrowsingStorageSession):
      (WebKit::RemoteNetworkingContext::storageSession):
      (WebKit::RemoteNetworkingContext::privateBrowsingSession):
      (WebKit::privateBrowsingStorageSessionIdentifierBase):
      (WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
      (WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
      (WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
      * NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:
      (WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
      (WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
      (WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
      (WebKit::RemoteNetworkingContext::privateBrowsingSession):
      * Shared/SessionTracker.cpp: Removed.
      * Shared/SessionTracker.h: Removed.
      * UIProcess/APISession.cpp:
      (API::Session::Session):
      (API::Session::create):
      (API::Session::isEphemeral):
      * UIProcess/APISession.h:
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
      (WebKit::WebContext::createNewWebProcess):
      (WebKit::WebContext::createWebPage):
      * UIProcess/WebContext.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::create):
      (WebKit::WebPageProxy::WebPageProxy):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::createWebPage):
      * UIProcess/WebProcessProxy.h:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setPrivateBrowsingEnabled):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::WebPlatformStrategies::cookiesForDOM):
      (WebKit::WebPlatformStrategies::setCookiesFromDOM):
      (WebKit::WebPlatformStrategies::cookiesEnabled):
      (WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
      (WebKit::WebPlatformStrategies::getRawCookies):
      (WebKit::WebPlatformStrategies::deleteCookie):
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      (WebKit::privateSession):
      (WebKit::identifierBase):
      (WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
      (WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
      (WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
      (WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
      (WebKit::WebFrameNetworkingContext::storageSession):
      * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
      (WebKit::privateSession):
      (WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
      (WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
      (WebKit::WebFrameNetworkingContext::storageSession):
      * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess):
      (WebKit::WebProcess::ensurePrivateBrowsingSession):
      (WebKit::WebProcess::destroyPrivateBrowsingSession):
      * WebProcess/WebProcess.h:
      * WebProcess/WebProcess.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61452451
    • mrobinson@webkit.org's avatar
      Build fix for the CMake GTK+ build · 6b0f9efb
      mrobinson@webkit.org authored
      * PlatformGTK.cmake: We need to include ProgressTrackerClientGtk in the source list.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b0f9efb
    • ryuan.choi@samsung.com's avatar
      Unreviewed build fix on EFL port after r162237 · 3aa1f965
      ryuan.choi@samsung.com authored
      The EFL port disabled NETWORK_PROCESS yet and use -Werror=unused-function.
      
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      Guarded legacySessionID with ENABLE(NETWORK_PROCESS)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3aa1f965
    • akling@apple.com's avatar
      Micro-optimize RenderBoxModelObject::computedCSSPadding(). · cede7abc
      akling@apple.com authored
      <https://webkit.org/b/127208>
      
      Make computedCSSPadding() take the Length as a const reference
      to avoid creating a temporary copy. This was showing up (0.2%)
      on DoYouEvenBench.
      
      Reviewed by Anders Carlsson.
      
      * rendering/RenderBoxModelObject.h:
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::computedCSSPadding):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cede7abc
    • commit-queue@webkit.org's avatar
      Flesh out session APIs (still not enabled at API level). · 5e2a9e85
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126918
      
      Patch by Martin Hock <mhock@apple.com> on 2014-01-17
      Reviewed by Alexey Proskuryakov.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * NetworkProcess/NetworkConnectionToWebProcess.cpp:
      (WebKit::storageSession):
      (WebKit::NetworkConnectionToWebProcess::startDownload):
      (WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
      (WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
      (WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
      (WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
      (WebKit::NetworkConnectionToWebProcess::getRawCookies):
      (WebKit::NetworkConnectionToWebProcess::deleteCookie):
      * NetworkProcess/NetworkConnectionToWebProcess.h:
      * NetworkProcess/NetworkConnectionToWebProcess.messages.in:
      * NetworkProcess/NetworkProcess.cpp:
      (WebKit::NetworkProcess::initializeNetworkProcess):
      (WebKit::NetworkProcess::ensurePrivateBrowsingSession):
      (WebKit::NetworkProcess::destroyPrivateBrowsingSession):
      * NetworkProcess/NetworkProcess.h:
      * NetworkProcess/NetworkProcess.messages.in:
      * NetworkProcess/RemoteNetworkingContext.h:
      * NetworkProcess/mac/RemoteNetworkingContext.mm:
      (WebKit::RemoteNetworkingContext::storageSession):
      (WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
      * NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:
      (WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
      * Shared/SessionTracker.cpp: Copied from Source/WebKit2/UIProcess/APISession.cpp.
      (WebKit::sessionMap):
      (WebKit::identifierBase):
      (WebKit::SessionTracker::getSessionMap):
      (WebKit::SessionTracker::getIdentifierBase):
      (WebKit::SessionTracker::session):
      (WebKit::SessionTracker::destroySession):
      (WebKit::SessionTracker::setIdentifierBase):
      * Shared/SessionTracker.h: Copied from Source/WebKit2/UIProcess/APISession.h.
      (WebKit::SessionTracker::isEphemeralID):
      * UIProcess/APISession.cpp:
      (API::generateID):
      (API::Session::defaultSession):
      (API::Session::legacyPrivateSession):
      (API::Session::Session):
      (API::Session::create):
      (API::Session::isEphemeral):
      (API::Session::getID):
      * UIProcess/APISession.h:
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
      (WebKit::WebContext::createNewWebProcess):
      (WebKit::WebContext::createWebPage):
      * UIProcess/WebContext.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::create):
      (WebKit::WebPageProxy::WebPageProxy):
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::sessionID):
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::createWebPage):
      * UIProcess/WebProcessProxy.h:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setPrivateBrowsingEnabled):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::legacySessionID):
      (WebKit::WebPlatformStrategies::cookiesForDOM):
      (WebKit::WebPlatformStrategies::setCookiesFromDOM):
      (WebKit::WebPlatformStrategies::cookiesEnabled):
      (WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
      (WebKit::WebPlatformStrategies::getRawCookies):
      (WebKit::WebPlatformStrategies::deleteCookie):
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      (WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
      (WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
      (WebKit::WebFrameNetworkingContext::storageSession):
      * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
      (WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
      (WebKit::WebFrameNetworkingContext::storageSession):
      * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess):
      (WebKit::WebProcess::ensurePrivateBrowsingSession):
      (WebKit::WebProcess::destroyPrivateBrowsingSession):
      * WebProcess/WebProcess.h:
      * WebProcess/WebProcess.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e2a9e85
    • ap@apple.com's avatar
      build.webkit.org/dashboard should have diff links in test results popovers · fe95f55e
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126986
      
      Reviewed by Tim Horton.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
      (Buildbot.prototype.layoutTestCrashLogURLForIteration):
      (Buildbot.prototype.layoutTestStderrURLForIteration):
      (Buildbot.prototype.layoutTestDiffURLForIteration):
      (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
      (BuildbotIteration.prototype.loadLayoutTestResults):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
      (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe95f55e
    • andersca@apple.com's avatar
      Add a callOnMainThreadAndWait variant in SocketStreamHandle · 1556da93
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127180
      
      Reviewed by Geoffrey Garen.
      
      Source/WebCore:
      
      WTF::callOnMainThreadAndWait was only used inside SocketStreamHandleCFNet.cpp,
      so add an improved version there which is implemented in terms of callOnMainThread and
      with the bonus of handling spurious wake-ups correctly (the old version didn't).
      
      * platform/network/cf/SocketStreamHandle.h:
      * platform/network/cf/SocketStreamHandleCFNet.cpp:
      (WebCore::callOnMainThreadAndWait):
      (WebCore::SocketStreamHandle::pacExecutionCallback):
      (WebCore::SocketStreamHandle::readStreamCallback):
      (WebCore::SocketStreamHandle::writeStreamCallback):
      
      Source/WTF:
      
      Remove callOnMainThreadAndWait from WTF.
      
      * wtf/MainThread.cpp:
      * wtf/MainThread.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1556da93
    • andersca@apple.com's avatar
      Clean up PageCache classes · e776c2f9
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127202
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::~CachedFrameBase):
      (WebCore::CachedFrame::CachedFrame):
      (WebCore::CachedFrame::clear):
      (WebCore::CachedFrame::setCachedFramePlatformData):
      * history/CachedFrame.h:
      * history/CachedPage.cpp:
      (WebCore::CachedPage::CachedPage):
      * history/CachedPage.h:
      * history/HistoryItem.h:
      (WebCore::HistoryItem::isInPageCache):
      * history/PageCache.cpp:
      (WebCore::PageCache::add):
      (WebCore::PageCache::take):
      (WebCore::PageCache::remove):
      * history/PageCache.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::commitProvisionalLoad):
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::invalidateCurrentItemCachedPage):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::savePlatformDataToCachedFrame):
      (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::savePlatformDataToCachedFrame):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e776c2f9
    • aestes@apple.com's avatar
      Work around a preprocessor warning in mediaControlsApple.js · 44c64d1b
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127204
      
      Reviewed by Dan Bernstein.
      
      * Modules/mediacontrols/mediaControlsApple.js: Changed '' to String().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44c64d1b
    • dbates@webkit.org's avatar
      Fix the iOS build after <http://trac.webkit.org/changeset/162184> · 940199fe
      dbates@webkit.org authored
      (https://bugs.webkit.org/show_bug.cgi?id=126856)
      
      Remove symbol for WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(unsigned short const*, int).
      Add symbol for WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(WTF::StringView).
      
      * WebCore.exp.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      940199fe
    • akling@apple.com's avatar
      Remove unused TOUCH_ADJUSTMENT code. · ded59a65
      akling@apple.com authored
      <https://webkit.org/b/127181>
      
      Source/WebCore:
      
      There are no ports using the ENABLE(TOUCH_ADJUSTMENT) feature
      anymore, so nuke it from orbit.
      
      Reviewed by Anders Carlsson.
      
      * page/EventHandler.cpp:
      * page/EventHandler.h:
      * page/Settings.in:
      * page/TouchAdjustment.cpp: Removed.
      * page/TouchAdjustment.h: Removed.
      * testing/Internals.cpp:
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      Reviewed by Anders Carlsson.
      
      * WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp:
      (WebKit::WebPage::findZoomableAreaForPoint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ded59a65
    • bdakin@apple.com's avatar
      Need a way to test the tile cache with margins enabled · d99f20e7
      bdakin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127194
      -and corresponding-
      <rdar://problem/15571327>
      
      Reviewed by Tim Horton.
      
      Source/WebCore: 
      
      This patch adds a new function to InternalSettings that will allow layout tests to 
      flip the setting Settings::setBackgroundShouldExtendBeyondPage(). This patch also         
      makes changing that setting take effect immediately. 
      
      To make this setting dynamic, we can no longer generate the Setting function, so 
      we have to export the symbol manually.
      * WebCore.exp.in:
      
      This new function on FrameView will call into RenderLayerBacking to add or remove 
      margins.
      * page/FrameView.cpp:
      (WebCore::FrameView::setBackgroundExtendsBeyondPage):
      * page/FrameView.h:
      
      Again, we’re no longer using the boiler-plate generated Setting functions, so now 
      we can call into FrameView to make the background extend.
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore::Settings::setBackgroundShouldExtendBeyondPage):
      * page/Settings.h:
      (WebCore::Settings::backgroundShouldExtendBeyondPage):
      * page/Settings.in:
      
      Whenever tile margins are set, call setNeedsRevalidateTiles() to make the change 
      dynamic.
      * platform/graphics/ca/mac/TileController.mm:
      (WebCore::TileController::setTileMargins):
      
      Move the call to TiledBacking::setTileMargins() into a helper function so that the 
      same code can be used for FrameView.
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::RenderLayerBacking):
      (WebCore::RenderLayerBacking::setTiledBackingHasMargins):
      * rendering/RenderLayerBacking.h:
      
      New InternalSetting.
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::setBackgroundShouldExtendBeyondPage):
      * testing/InternalSettings.h:
      * testing/InternalSettings.idl:
      
      Source/WebKit: 
      
      Attempt to keep Windows building.
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      LayoutTests: 
      
      * platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles-expected.txt: Added.
      * platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d99f20e7
    • andersca@apple.com's avatar
      Fix build. · e081beec
      andersca@apple.com authored
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e081beec
    • matthew_hanson@apple.com's avatar
      Add the bare minimum support for branches to the bot-watchers dashboard · 8ed1eb6b
      matthew_hanson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127124
      
      This patch simply introduces the notion of branches into the bot-watchers dashboard.
      Subsequent patches will build functionality on top of this simple bit of infrastructure.
      
      Reviewed by Timothy Hatcher.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
      (BuildbotQueue): store the branch property in the BuildbotQueue constructor
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
      Initialize the Dashboard.Branch object
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ed1eb6b
    • andersca@apple.com's avatar
      Remove another unused FrameLoaderClient callback · 6a60daad
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127192
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      FrameLoaderClient::dispatchDocumentElementAvailable() was only used by the Chromium port, so remove it.
      
      * html/ImageDocument.cpp:
      (WebCore::ImageDocument::createDocumentStructure):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocumentParser::createDocumentStructure):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
      * loader/EmptyClients.h:
      * loader/FrameLoader.cpp:
      * loader/FrameLoader.h:
      * loader/FrameLoaderClient.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::XMLDocumentParser::startElementNs):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      * WebCoreSupport/FrameLoaderClientEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      * WebCoreSupport/FrameLoaderClientGtk.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebCoreSupport/WebFrameLoaderClient.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      * WebCoreSupport/FrameLoaderClientWinCE.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a60daad
    • andersca@apple.com's avatar
      Remove FrameLoaderClient::didPerformFirstNavigation() · e56e359f
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127191
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      * loader/EmptyClients.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      * loader/FrameLoader.h:
      * loader/FrameLoaderClient.h:
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::updateBackForwardListClippedAtTarget):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e56e359f