1. 14 Nov, 2008 32 commits
    • bolsinga@apple.com's avatar
      Reviewed by Darin Adler. · 97e42c46
      bolsinga@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=21810
              Remove use of static C++ objects that are destroyed at exit time (destructors)
      
              Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid 
              exit-time destructor. Update code that was changed to fix this issue that ran 
              into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference 
              in gcc build 5465). Also typdefs for template types needed to be added in some 
              cases so the type could make it through the macro successfully.
      
              Basically code of the form:
              static T m;
              becomes:
              DEFINE_STATIC_LOCAL(T, m, ());
      
              Also any code of the form:
              static T& m = *new T;
              also becomes:
              DEFINE_STATIC_LOCAL(T, m, ());
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97e42c46
    • mitz@apple.com's avatar
      - attempt to fix the Qt build · ddf9b8cc
      mitz@apple.com authored
              * platform/qt/Localizations.cpp:
              (WebCore::contextMenuItemTagTextDirectionMenu): Added. Maybe this string
              needs to go somewhere else in addition to here.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddf9b8cc
    • mitz@apple.com's avatar
      - try to fix the Windows build · dea538aa
      mitz@apple.com authored
              * WebCoreLocalizedStrings.cpp:
              (WebCore::contextMenuItemTagTextDirectionMenu): Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dea538aa
    • kevino@webkit.org's avatar
      wx build (and buildbot) fix. · 66e6bed0
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66e6bed0
    • barraclough@apple.com's avatar
      2008-11-14 Gavin Barraclough <barraclough@apple.com> · a5524518
      barraclough@apple.com authored
              Reviewed by Geoff Garen.
      
              Geoff has this wacky notion that emitGetArg and emitPutArg should be related to
              doing the same thing.  Crazy.
              
              Rename the methods for accessing virtual registers to say 'VirtualRegister' in the
              name, and those for setting up the arguments for CTI methods to contain 'CTIArg'.
      
              * VM/CTI.cpp:
              (JSC::CTI::emitGetVirtualRegister):
              (JSC::CTI::emitGetVirtualRegisters):
              (JSC::CTI::emitPutCTIArgFromVirtualRegister):
              (JSC::CTI::emitPutCTIArg):
              (JSC::CTI::emitGetCTIArg):
              (JSC::CTI::emitPutCTIArgConstant):
              (JSC::CTI::emitPutVirtualRegister):
              (JSC::CTI::compileOpCallSetupArgs):
              (JSC::CTI::compileOpCallEvalSetupArgs):
              (JSC::CTI::compileOpConstructSetupArgs):
              (JSC::CTI::compileOpCall):
              (JSC::CTI::compileOpStrictEq):
              (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
              (JSC::CTI::compileBinaryArithOp):
              (JSC::CTI::compileBinaryArithOpSlowCase):
              (JSC::CTI::privateCompileMainPass):
              (JSC::CTI::privateCompileSlowCases):
              (JSC::CTI::privateCompileCTIMachineTrampolines):
              * VM/CTI.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5524518
    • bolsinga@apple.com's avatar
      Reviewed by Antti Koivisto · ae33071c
      bolsinga@apple.com authored
              Fix potential build break by adding StdLibExtras.h
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae33071c
    • barraclough@apple.com's avatar
      2008-11-14 Gavin Barraclough <barraclough@apple.com> · 1bab56df
      barraclough@apple.com authored
              Reviewed by Geoff Garen.
      
              Generate less code for the slow cases of op_call and op_construct.
              https://bugs.webkit.org/show_bug.cgi?id=22272
      
              1% progression on v8 tests.
      
              * VM/CTI.cpp:
              (JSC::CTI::emitRetrieveArg):
              (JSC::CTI::emitNakedCall):
              (JSC::CTI::compileOpCallInitializeCallFrame):
              (JSC::CTI::compileOpCall):
              (JSC::CTI::privateCompileSlowCases):
              (JSC::CTI::privateCompileCTIMachineTrampolines):
              * VM/CTI.h:
              * VM/CodeBlock.h:
              (JSC::getCallLinkInfoReturnLocation):
              (JSC::CodeBlock::getCallLinkInfo):
              * VM/Machine.cpp:
              (JSC::Machine::Machine):
              (JSC::Machine::cti_vm_dontLazyLinkCall):
              (JSC::Machine::cti_vm_lazyLinkCall):
              * VM/Machine.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bab56df
    • bolsinga@apple.com's avatar
      Reviewed by Darin Alder. · 446be430
      bolsinga@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=21810
              Remove use of static C++ objects that are destroyed at exit time (destructors)
      
              Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid 
              exit-time destructor. Update code that was changed to fix this issue that ran 
              into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference 
              in gcc build 5465). Also typdefs for template types needed to be added in some 
              cases so the type could make it through the macro successfully.
      
              Basically code of the form:
              static T m;
              becomes:
              DEFINE_STATIC_LOCAL(T, m, ());
      
              Also any code of the form:
              static T& m = *new T;
              also becomes:
              DEFINE_STATIC_LOCAL(T, m, ());
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      446be430
    • mitz@apple.com's avatar
      WebCore: · d6ceec82
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - <rdar://problem/6234307> Support action methods for setting and clearing character-level directionality
              - WebCore part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate
      
              * WebCore.base.exp: Exported
              WebCore::Settings::setTextDirectionSubmenuInclusionBehavior().
      
              * editing/ApplyStyleCommand.cpp:
              (StyleChange::init): Changed to always include the direction property
              in the result if the unicode-bidi property is included.
              (ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Added. Finds the
              highest ancestor of the given node that establishes bidi embedding. If
              that embedding agrees with the given allowed direction, finds the
              second-highest embedding ancestor. Splits all nodes through that
              ancestor. If the highest embedding ancestor did not need to be split,
              it is returned.
              (ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Added. Removes
              bidi embedding attributes and styles from all ancestors of the given
              node up to its enclosing block or the given node.
              (ApplyStyleCommand::applyInlineStyle): Added code to handle the
              unicode-bidi property. Applying style the includes this property
              involves removing all bidi embedding in effect, except  for one-level
              embedding that agrees with the desired embedding, then applying the
              desired embedding where it is not already in effect.
              (ApplyStyleCommand::applyInlineStyleToRange): Factored out from
              applyInlineStyle().
              (ApplyStyleCommand::removeHTMLBidiEmbeddingStyle): Added. Removed the
              "dir" attribute if necessary and the element if it becomes an unstyled
              style span.
              (ApplyStyleCommand::removeCSSStyle): Changed to remove the direction
              property when removing the unicode-bidi property.
              (ApplyStyleCommand::removeInlineStyle): Added a call to
              removeHTMLBidiEmbeddingStyle().
      
              * editing/ApplyStyleCommand.h:
              * editing/Editor.cpp:
              (Editor::textDirectionForSelection): Added. Returns the character-level
              writing direction of the selection if it is uniform and simple (at most
              one level of embedding).
              (Editor::hasBidiSelection): Added. Returns true if the selection lies
              entirely within a single block, and that block has direction:rtl or
              contains any inline boxes with non-zero bidi embedding level.
      
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (stateTextWritingDirection): Added this helper function for deciding
              the state of Text Direction submenu items.
              (executeMakeTextWritingDirectionLeftToRight): Added. Applies
              "unicode-bidi: embed; direction: ltr;".
              (executeMakeTextWritingDirectionNatural): Added. Applies
              "unicode-bidi: normal;"
              (executeMakeTextWritingDirectionRightToLeft): Added. Applies
              "unicode-bidi: embed; direction: rtl;".
              (stateTextWritingDirectionLeftToRight): Added.
              (stateTextWritingDirectionNatural): Added.
              (stateTextWritingDirectionRightToLeft): Added.
              (createCommandMap): Added "MakeTextWritingDirectionLeftToRight",
              "MakeTextWritingDirectionNatural",
              and "MakeTextWritingDirectionRightToLeft".
      
              * editing/InsertTextCommand.cpp:
              (InsertTextCommand::input): Added code to maintain the unicode-bidi
              and direction properties in the typing style. Even if they have the
              same values as the computed style at the caret, they need to be included
              in the typing style so that inserted text will not inherit any nested
              embedding.
      
              * page/ContextMenuController.cpp:
              (ContextMenuController::contextMenuItemSelected): Added calls to
              the editor for the text direction menu items.
      
              * page/Frame.cpp
              (Frame::computeAndSetTypingStyle): Added code to maintain the
              unicode-bidi and direction properties in the typing style.
      
              * page/Settings.cpp:
              (Settings::setTextDirectionSubmenuInclusionBehavior): Added this setter.
      
              * page/Settings.h: Added a TextDirectionSubmenuInclusionBehavior enum,
              an m_textDirectionSubmenuInclusionBehavior member, and accessors.
      
              * page/mac/WebCoreViewFactory.h:
              * platform/ContextMenu.cpp:
              (WebCore::createAndAppendTextDirectionSubMenu): Added.
              (ContextMenu::populate): Added the Text Direction submenu item based on
              the inclusion behavior and the existence of a bidi selection.
              (ContextMenu::checkOrEnableIfNeeded): Added code for the text direction
              menu items.
      
              * platform/ContextMenuItem.h:
              * platform/LocalizedStrings.h: Declared
              contextMenuItemTagTextDirectionMenu().
      
              * platform/mac/LocalizedStringsMac.mm: Defined
              contextMenuItemTagTextDirectionMenu().
      
              * rendering/RenderBlock.cpp:
              (RenderBlock::containsNonZeroBidiLevel): Added.
              * rendering/RenderBlock.h:
      
      WebKit:
      
              Reviewed by Darin Adler.
      
              - part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate
      
              * English.lproj/Localizable.strings: Added the Text Direction submenu
              title.
      
      WebKit/mac:
      
              Reviewed by Darin Adler.
      
              - <rdar://problem/6234333> Implement action methods for setting and clearing character-level directionality
              - part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate
      
              * WebCoreSupport/WebViewFactory.mm:
              (-[WebViewFactory contextMenuItemTagTextDirectionMenu]): Added.
              * WebView/WebFrame.mm:
              (core): Added a convertor from WebTextDirectionSubmenuInclusionBehavior
              to WebCore::TextDirectionSubmenuInclusionBehavior.
              * WebView/WebFrameInternal.h:
              * WebView/WebHTMLView.mm:
              Added makeTextWritingDirectionLeftToRight:,
              makeTextWritingDirectionNatural: and
              makeTextWritingDirectionRightToLeft: using the WEBCORE_COMMAND macro.
              * WebView/WebPreferenceKeysPrivate.h:
              Added WebKitTextDirectionSubmenuInclusionBehaviorPreferenceKey.
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]): Set the default Text Direction
              submenu inclusion behavior to never include.
              (-[WebPreferences textDirectionSubmenuInclusionBehavior]): Added this
              accessor.
              (-[WebPreferences setTextDirectionSubmenuInclusionBehavior:]): Ditto.
              * WebView/WebPreferencesPrivate.h: Defined the
              WebTextDirectionSubmenuInclusionBehavior enum and declared
              accessors.
              * WebView/WebUIDelegatePrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Added code to transfer
              the Text Direction submenu inclusion behavior preference to WebCore
              settings.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6ceec82
    • bolsinga@apple.com's avatar
      Reviewed by Darin Adler. · f504550c
      bolsinga@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=22264
              Need to update to latest Geolocation spec (13 November 2008)
              
              Update to new error code constants and values.
      
              * page/Geolocation.cpp: Use new named ErrorCode enums
              (WebCore::Geolocation::GeoNotifier::timerFired):
              (WebCore::Geolocation::getCurrentPosition):
              (WebCore::Geolocation::watchPosition):
              * page/PositionError.h: Have ErrorCode enum names match new error constant names and values
              (WebCore::PositionError::):
              * page/PositionError.idl: Add new named error constants
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f504550c
    • bdakin@apple.com's avatar
      WebCore: · f6ce38cf
      bdakin@apple.com authored
      2008-11-14  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Justin Garcia.
      
              Fix (again) for <rdar://problem/5089327> Too much indentation when 
              pasting quoted paragraphs
      
              This patch goes back to Justin's original approach to fix this bug, 
              written in revision 38273. That fix was mostly rolled out by 
              revision 38310 because of styling issues created by the addition of 
              extra blockquote nodes. This patch again goes back to Justin's 
              original fix because of cases we discovered the newer fix could not 
              possibly cover. This version of the patch minimizes the styling 
              issues of extra blockquotes by opting into the merge start code. 
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::hasMatchingQuoteLevel): We want shouldMergeStart to 
              return true when the quoting level of the end of the inserted 
              content matches the quoting level of the end of the existing 
              content.
              (WebCore::ReplaceSelectionCommand::shouldMergeStart): Now calls 
              hasMatchingQuoteLevel
              (WebCore::ReplaceSelectionCommand::doApply):
      
      LayoutTests:
      
      2008-11-14  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Justin Garcia.
      
              Tests for <rdar://problem/5089327> Too much indentation when 
              pasting quoted paragraphs
      
              New test:
              * editing/pasteboard/paste-blockquote-into-blockquote-4.html: 
              Added.
              * platform/mac/editing/pasteboard/paste-blockquote-into-
              blockquote-4-expected.checksum: Added.
              * platform/mac/editing/pasteboard/paste-blockquote-into-
              blockquote-4-expected.png: Added.
              * platform/mac/editing/pasteboard/paste-blockquote-into-
              blockquote-4-expected.txt: Added.
      
              Changes results for existing tests:
              * platform/mac/editing/pasteboard/merge-end-blockquote-
              expected.checksum:
              * platform/mac/editing/pasteboard/merge-end-blockquote-
              expected.png:
              * platform/mac/editing/pasteboard/merge-end-blockquote-
              expected.txt:
              * platform/mac/editing/pasteboard/paste-blockquote-into-
              blockquote-2-expected.txt:
              * platform/mac/editing/pasteboard/paste-blockquote-into-
              blockquote-3-expected.txt:
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-
              expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6ce38cf
    • weinig@apple.com's avatar
      2008-11-13 Sam Weinig <sam@webkit.org> · 8a866598
      weinig@apple.com authored
              Reviewed by Darin Adler
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=22269
              Reduce PropertyMap usage
      
              From observation of StructureID statistics, it became clear that many
              StructureID's were not being used as StructureIDs themselves, but rather
              only being necessary as links in the transition chain.  Acknowledging this
              and that PropertyMaps stored in StructureIDs can be treated as caches, that
              is that they can be reconstructed on demand, it became clear that we could
              reduce the memory consumption of StructureIDs by only keeping PropertyMaps
              for the StructureIDs that need them the most.
      
              The specific strategy used to reduce the number of StructureIDs with
              PropertyMaps is to take the previous StructureIDs PropertyMap when initially
              transitioning (addPropertyTransition) from it and clearing out the pointer 
              in the process.  The next time we need to do the same transition, for instance
              repeated calls to the same constructor, we use the new addPropertyTransitionToExistingStructure
              first, which allows us not to need the PropertyMap to determine if the property
              exists already, since a transition to that property would require it not already
              be present in the StructureID.  Should there be no transition, the PropertyMap
              can be constructed on demand (via materializePropertyMap) to determine if the put is a 
              replace or a transition to a new StructureID.
      
              Reduces memory use on Membuster head test (30 pages open) by ~15MB.
      
              * JavaScriptCore.exp:
              * runtime/JSObject.h:
              (JSC::JSObject::putDirect): First use addPropertyTransitionToExistingStructure
              so that we can avoid building the PropertyMap on subsequent similar object
              creations.
              * runtime/PropertyMapHashTable.h:
              (JSC::PropertyMapEntry::PropertyMapEntry): Add version of constructor which takes
              all values to be used when lazily building the PropertyMap. 
              * runtime/StructureID.cpp:
              (JSC::StructureID::dumpStatistics): Add statistics on the number of StructureIDs
              with PropertyMaps.
              (JSC::StructureID::StructureID): Rename m_cachedTransistionOffset to m_offset
              (JSC::isPowerOf2):
              (JSC::nextPowerOf2):
              (JSC::sizeForKeyCount): Returns the expected size of a PropertyMap for a key count.
              (JSC::StructureID::materializePropertyMap): Builds the PropertyMap out of its previous pointer chain.
              (JSC::StructureID::addPropertyTransitionToExistingStructure): Only transitions if there is a
              an existing transition.
              (JSC::StructureID::addPropertyTransition): Instead of always copying the ProperyMap, try and take
              it from it previous pointer.
              (JSC::StructureID::removePropertyTransition): Simplify by calling toDictionaryTransition() to do
              transition work.
              (JSC::StructureID::changePrototypeTransition): Build the PropertyMap if necessary before transitioning
              because once you have transitioned, you will not be able to reconstruct it afterwards as there is no
              previous pointer, pinning the ProperyMap as well.
              (JSC::StructureID::getterSetterTransition): Ditto.
              (JSC::StructureID::toDictionaryTransition): Pin the PropertyMap so that it is not destroyed on further transitions.
              (JSC::StructureID::fromDictionaryTransition): We can only transition back from a dictionary transition if there
              are no deleted offsets.
              (JSC::StructureID::addPropertyWithoutTransition): Build PropertyMap on demands and pin.
              (JSC::StructureID::removePropertyWithoutTransition): Ditto.
              (JSC::StructureID::get): Build on demand.
              (JSC::StructureID::createPropertyMapHashTable): Add version of create that takes a size
              for on demand building.
              (JSC::StructureID::expandPropertyMapHashTable):
              (JSC::StructureID::rehashPropertyMapHashTable):
              (JSC::StructureID::getEnumerablePropertyNamesInternal): Build PropertyMap on demand.
              * runtime/StructureID.h:
              (JSC::StructureID::propertyStorageSize): Account for StructureIDs without PropertyMaps.
              (JSC::StructureID::isEmpty): Ditto.
              (JSC::StructureID::materializePropertyMapIfNecessary):
              (JSC::StructureID::get): Build PropertyMap on demand
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a866598
    • alp@webkit.org's avatar
      2008-11-14 Alp Toker <alp@nuanti.com> · 3c017c06
      alp@webkit.org authored
              GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
      
              Fixes Debian bug #505723
              http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
      
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c017c06
    • eric@webkit.org's avatar
      Reviewed by Eric Seidel. · 0dd61067
      eric@webkit.org authored
              Made SVGResourceClipper platform independent.
              https://bugs.webkit.org/show_bug.cgi?id=21444
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::clipPath):
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::clipPath):
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::addPath):
              (WebCore::GraphicsContext::clipPath):
              * svg/graphics/SVGResourceClipper.cpp:
              (WebCore::SVGResourceClipper::applyClip):
              * svg/graphics/cairo/SVGResourceClipperCairo.cpp: Removed.
              * svg/graphics/cg/SVGResourceClipperCg.cpp: Removed.
              * svg/graphics/qt/SVGResourceClipperQt.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dd61067
    • antti@apple.com's avatar
      2008-11-14 Antti Koivisto <antti@apple.com> · c633dca3
      antti@apple.com authored
              Reviewed by Anders Carlsson.
      
              Combine loadFrameRequestWithFormState to loadFrameRequestWithFormAndValues.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
              * loader/FrameLoader.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c633dca3
    • weinig@apple.com's avatar
      2008-11-14 Sam Weinig <sam@webkit.org> · d7fe7484
      weinig@apple.com authored
              Reviewed by Eric Seidel.
      
              Remove unneeded forward declaration.
      
              * plugins/Plugin.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7fe7484
    • darin@apple.com's avatar
      2008-11-14 Darin Adler <darin@apple.com> · f8d3d23e
      darin@apple.com authored
              Reviewed by Mark Rowe.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=22222
                selectKeyViewPrecedingView: with document view that can't be first responder
                makes WebFrameView be first responder
      
              * WebView/WebFrameView.mm: (-[WebFrameView becomeFirstResponder]):
              Moved the acceptsFirstResponder special case inside the if statement so it won't
              run in the "selecting previous" case. Also removed the "just before shipping Tiger"
              code that doesn't need to be here any more.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8d3d23e
    • hausmann@webkit.org's avatar
      2008-10-24 Yael Aharon <yael.aharon@nokia.com> · 5f70a731
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Added some basic unit tests for the public database API.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f70a731
    • hausmann@webkit.org's avatar
      2008-11-14 Simon Hausmann <hausmann@webkit.org> · b0284c12
      hausmann@webkit.org authored
              Fix the Qt build, add missing export macros for the new classes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0284c12
    • darin@chromium.org's avatar
      2008-11-14 Darin Fisher <darin@chromium.org> · 53564935
      darin@chromium.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=22251
              HTMLCanvasElement.cpp unnecessarily includes runtime/Interpreter.h
      
              * html/HTMLCanvasElement.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53564935
    • hausmann@webkit.org's avatar
      2008-11-14 Csaba Osztrogonac <oszi@inf.u-szeged.hu> · 39032970
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              <https://bugs.webkit.org/show_bug.cgi?id=21500>
      
              JavaScriptCore build with -O3 flag instead of -O2 (gcc).
              2.02% speedup on SunSpider (Qt-port on Linux)
              1.10% speedup on V8 (Qt-port on Linux)
              3.45% speedup on WindScorpion (Qt-port on Linux)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39032970
    • hausmann@webkit.org's avatar
      2008-11-14 Krishna <krishnamurty.podipireddy@nokia.com> · 48c1fd94
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Fix hanging DRT with Qt.
      
              https://bugs.webkit.org/show_bug.cgi?id=22209
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48c1fd94
    • hausmann@webkit.org's avatar
      WebCore: · 430f7fe5
      hausmann@webkit.org authored
          2008-11-14  Yael Aharon  <yael.aharon@nokia.com>
      
                  Reviewed by Simon Hausmann.
      
                  Add new files from the Qt port to the build.
      
                  * WebCore.pro:
      
      WebKit/qt:
      
          2008-10-24  Yael Aharon <yael.aharon@nokia.com>
      
                  Reviewed by Simon Hausmann.
      
                  Adding public API to provide access to the security origin
                  (QWebSecurityOrigin) and the databases used for the offline
                  storage (QWebDatabase).
      
                  In addition QWebSettings gains configuration functions for
                  enabling/disabling offline storage, web application cache
                  and DOM local storage.
      
                  This commits lands the core feature(s), the unit tests and the
                  documentation are going to follow in the comming days/weeks.
      
                  Note: The API is not frozen yet.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      430f7fe5
    • hausmann@webkit.org's avatar
      2008-11-14 Yael Aharon <yael.aharon@nokia.com> · 62424c97
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Make it possible to get the cache directory set in the application
              cache storage.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62424c97
    • hausmann@webkit.org's avatar
      2008-11-14 Yael Aharon <yael.aharon@nokia.com> · f0f936a4
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Make it possible to get the cache directory set in the application
              cache storage.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0f936a4
    • justin.garcia@apple.com's avatar
      WebCore: · 5b803002
      justin.garcia@apple.com authored
      2008-11-14  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Beth Dakin.
      
              <rdar://problem/4230923> "Make Plain Text" doesn't reset text alignment in single paragraph messages
              
              When applying block styles, we would add block properties to the body element, and Mail's
              Make Plain Text feature isn't equipped to remove those.  This could have been fixed on our side,
              but this change has the advantage that it fixes the bug on Tiger, where Mail does not plan future updates.
              
              We have code that puts the paragraphs that we're operating on into blocks of their own before
              adding or removing block properties from the blocks that enclose them.  We need to run this code 
              when the enclosing block is the body element.
              
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Added, moved code from moveParagraphContents
              to here.
              (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Renamed some variables for clarity.
              Added a few comments.  Fixed bug by not bailing out when the block about to be used is the body element.
              * editing/CompositeEditCommand.h:
      
      LayoutTests:
      
      2008-11-14  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Beth Dakin.
      
              <rdar://problem/4230923> "Make Plain Text" doesn't reset text alignment in single paragraph messages
      
              * editing/style/4230923-expected.txt: Added.
              * editing/style/4230923.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b803002
    • hausmann@webkit.org's avatar
      2008-11-14 Kristian Amlie <kristian.amlie@trolltech.com> · 2b7abc24
      hausmann@webkit.org authored
              Reviewed by Darin Adler.
      
              Compile fix for RVCT.
      
              In reality, it is two fixes:
      
              1. Remove typename. I believe typename can only be used when the named
              type depends on the template parameters, which it doesn't in this
              case, so I think this is more correct.
              2. Replace ::iterator scope with specialized typedef. This is to work
              around a bug in RVCT.
      
              https://bugs.webkit.org/show_bug.cgi?id=22260
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b7abc24
    • hausmann@webkit.org's avatar
      2008-11-14 Kristian Amlie <kristian.amlie@trolltech.com> · 9476dca4
      hausmann@webkit.org authored
              Reviewed by Darin Adler.
      
              Compile fix for WINSCW.
      
              This fix doesn't protect against implicit conversions from bool to
              integers, but most likely that will be caught on another platform.
      
              https://bugs.webkit.org/show_bug.cgi?id=22260
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9476dca4
    • cwzwarich@webkit.org's avatar
      2008-11-14 Cameron Zwarich <zwarich@apple.com> · 770a8a80
      cwzwarich@webkit.org authored
              Reviewed by Darin Adler.
      
              Bug 22245: Move wtf/dtoa.h into the WTF namespace
              <https://bugs.webkit.org/show_bug.cgi?id=22245>
      
              Move wtf/dtoa.h into the WTF namespace from the JSC namespace. This
              introduces some ambiguities in name lookups, so I changed all uses of
              the functions in wtf/dtoa.h to explicitly state the namespace.
      
              JavaScriptCore:
      
              * JavaScriptCore.exp:
              * parser/Lexer.cpp:
              (JSC::Lexer::lex):
              * runtime/InitializeThreading.cpp:
              * runtime/JSGlobalObjectFunctions.cpp:
              (JSC::parseInt):
              * runtime/NumberPrototype.cpp:
              (JSC::integerPartNoExp):
              (JSC::numberProtoFuncToExponential):
              * runtime/UString.cpp:
              (JSC::concatenate):
              (JSC::UString::from):
              (JSC::UString::toDouble):
              * wtf/dtoa.cpp:
              * wtf/dtoa.h:
      
              WebCore:
      
              * platform/text/String.cpp:
              (WebCore::charactersToDouble):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      770a8a80
    • vestbo@webkit.org's avatar
      2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com> · 66a87f27
      vestbo@webkit.org authored
              Rubber-stamped by Simon Hausmann.
      
              Make sure Qt scrollbars follow the style with regard to context menus
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66a87f27
    • vestbo@webkit.org's avatar
      2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com> · 6d15427a
      vestbo@webkit.org authored
              Rubber-stamped by Simon Hausmann.
      
              Make scrollbar look active when the window is active on Qt/Mac
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d15427a
    • cwzwarich@webkit.org's avatar
      2008-11-14 Cameron Zwarich <zwarich@apple.com> · 22f3900d
      cwzwarich@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Bug 22257: Enable redundant read optimizations for results generated by compileBinaryArithOp()
              <https://bugs.webkit.org/show_bug.cgi?id=22257>
      
              This shows no change in performance on either SunSpider or the V8
              benchmark suite, but it removes an ugly special case and allows for
              future optimizations to be implemented in a cleaner fashion.
      
              This patch was essentially given to me by Gavin Barraclough upon my
              request, but I did regression and performance testing so that he could
              work on something else.
      
              * VM/CTI.cpp:
              (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate): Move the final
              result to eax if it is not already there.
              (JSC::CTI::compileBinaryArithOp): Remove the killing of the final result
              register that disables the optimization.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22f3900d
  2. 13 Nov, 2008 8 commits