1. 30 Sep, 2006 4 commits
    • mjs's avatar
      Reviewed by Adele. · 97b567ff
      mjs authored
              - fix build
      
              * platform/FloatRect.h:
              (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
              but more appropriate for path-type stuff.
              * platform/cg/PathCG.cpp:
              (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97b567ff
    • ap's avatar
      Reviewed by Darin. · e08cbe85
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=11011
              External CSS is parsed as iso-8859-1 even though the main document is utf-8
      
              Test: fast/encoding/css-charset-default.xhtml
      
              * loader/CachedResourceClient.h:
              (WebCore::CachedResourceClient::setCSSStyleSheet):
              (WebCore::CachedResourceClient::setXSLStyleSheet):
              Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
              takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
      
              * css/CSSImportRule.cpp:
              (WebCore::CSSImportRule::setCSSStyleSheet):
              (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
              * css/CSSImportRule.h:
      
              * css/CSSStyleSheet.cpp:
              (WebCore::CSSStyleSheet::CSSStyleSheet):
              * css/CSSStyleSheet.h:
              Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
              member. Changed some String parameters to const String&.
      
              * css/StyleSheet.cpp:
              (WebCore::StyleSheet::StyleSheet):
              * css/StyleSheet.h:
              Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
      
              * css/StyleSheetList.cpp:
              (WebCore::StyleSheetList::length):
              (WebCore::StyleSheetList::item):
              * css/StyleSheetList.h:
              Special-casing implicit stylesheets seemed to be dead code, removed.
      
              * dom/Document.cpp:
              (WebCore::Document::setCSSStyleSheet):
              (WebCore::Document::recalcStyleSelector):
              * dom/Document.h:
              Renamed setStyleSheet() to setCSSStyleSheet().
      
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
              (WebCore::ProcessingInstruction::setCSSStyleSheet):
              (WebCore::ProcessingInstruction::setXSLStyleSheet):
              (WebCore::ProcessingInstruction::parseStyleSheet):
              * dom/ProcessingInstruction.h:
      
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute 
              is not specified.
              (WebCore::HTMLLinkElement::setCSSStyleSheet):
              * html/HTMLLinkElement.h:
      
              * html/HTMLStyleElement.cpp:
              (WebCore::HTMLStyleElement::childrenChanged):
              * ksvg2/svg/SVGStyleElement.cpp:
              (WebCore::SVGStyleElement::childrenChanged):
              Inherit URL and charset from the document.
      
              * loader/Cache.cpp:
              (WebCore::Cache::requestCSSStyleSheet):
              * loader/Cache.h:
              Adjust for setStyleSheet() renaming.
      
              * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::ref):
              (WebCore::CachedCSSStyleSheet::deref):
              (WebCore::CachedCSSStyleSheet::checkNotify):
              Pass the encoding to setCSSStyleSheet().
      
              * loader/CachedXSLStyleSheet.cpp:
              (WebCore::CachedXSLStyleSheet::ref):
              (WebCore::CachedXSLStyleSheet::checkNotify):
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::requestCSSStyleSheet):
              * loader/DocLoader.h:
              * page/Frame.cpp:
              (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
              (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
              * xml/XSLImportRule.cpp:
              (WebCore::XSLImportRule::setXSLStyleSheet):
              (WebCore::XSLImportRule::loadSheet):
              * xml/XSLImportRule.h:
              Adjust for setStyleSheet() renaming.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e08cbe85
    • rwlbuis's avatar
      Reviewed by eseidel. · 1f4fa6e6
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=11096
              Hit testing for polylines fails
      
              Fix Path::contains so it handles filled, non-closed paths too.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f4fa6e6
    • hyatt's avatar
      Event refactoring. · 3ee17e4a
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ee17e4a
  2. 29 Sep, 2006 16 commits
    • adele's avatar
      Reviewed by Adele. · 9f2e4b67
      adele authored
              Fixes windows bustage:
              http://bugs.webkit.org/show_bug.cgi?id=11093
      
              * platform/win/PlatformScrollBar.h:
              * platform/win/TemporaryLinkStubs.cpp:
              (PlatformScrollBar::PlatformScrollBar):
              (ScrollBar::ScrollBar):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f2e4b67
    • hyatt's avatar
      Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit · 6ba8ab79
      hyatt authored
              in RenderObject::NodeInfo (and then propagating that Widget to
              MouseEventWithHitTestResults).
      
              This allows RenderListBox and RenderBlock to do the same thing when the
              mouse is over the scrollbar.
      
              Also land fix to support font-size: 0.
      
              Reviewed by mjs (scrollbar), eric (font-size)
      
              * dom/Document.cpp:
              (WebCore::Document::prepareMouseEvent):
              * page/Frame.cpp:
              (WebCore::Frame::passWidgetMouseDownEventToWidget):
              * page/FrameView.cpp:
              (WebCore::selectCursor):
              (WebCore::FrameView::handleMouseMoveEvent):
              (WebCore::FrameView::dispatchMouseEvent):
              * page/MouseEventWithHitTestResults.cpp:
              (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
              * page/MouseEventWithHitTestResults.h:
              (WebCore::MouseEventWithHitTestResults::scrollbar):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::isPointInScrollbar):
              (WebCore::RenderBlock::nodeAtPoint):
              * rendering/RenderBlock.h:
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::hitTest):
              * rendering/RenderLayer.h:
              (WebCore::RenderLayer::getHiddenBehavior):
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::RenderListBox):
              (WebCore::RenderListBox::~RenderListBox):
              (WebCore::RenderListBox::isPointInScrollbar):
              * rendering/RenderListBox.h:
              * rendering/RenderObject.h:
              (WebCore::RenderObject::NodeInfo::NodeInfo):
              (WebCore::RenderObject::NodeInfo::scrollbar):
              (WebCore::RenderObject::NodeInfo::setScrollbar):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ba8ab79
    • adele's avatar
      Reviewed by Adele. · 12628dc4
      adele authored
              Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
      
              * platform/win/ScrollViewWin.cpp:
              (WebCore::ScrollView::convertToContainingWindow):
              (WebCore::ScrollView::convertFromContainingWindow):
              * platform/win/WidgetWin.cpp:
              (WebCore::Widget::convertToContainingWindow):
              (WebCore::Widget::convertFromContainingWindow):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12628dc4
    • adele's avatar
      Updated with new argument for PlatformScrollBar. · 110cc417
      adele authored
              * platform/win/TemporaryLinkStubs.cpp:
              (PlatformScrollBar::PlatformScrollBar):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      110cc417
    • adele's avatar
      Reviewed by Hyatt. · 7a4fb4c3
      adele authored
              Fixing build bustage with cast to int.
      
              * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a4fb4c3
    • adele's avatar
      Fixing accidental include. · 897ffad4
      adele authored
              * rendering/RenderListBox.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      897ffad4
    • adele's avatar
      Adding RenderListBox files. · f520b80e
      adele authored
       
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f520b80e
    • bdakin's avatar
      Fixing typo. No problem in the ned. Just the end. · 4f09628e
      bdakin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f09628e
    • adele's avatar
      Reviewed by Adam. · f989049f
      adele authored
              Initial implementation of engine-based list box control.
      
              * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
      
              * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
              * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
              (WebCore::FrameMac::FrameMac):
              (WebCore::FrameMac::handleMousePressEvent):
              (WebCore::FrameMac::handleMouseMoveEvent):
              (WebCore::FrameMac::mouseDown):
      
              * page/Frame.cpp:
              (WebCore::Frame::handleMouseMoveEvent):
              (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
              (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
              (WebCore::Frame::autoscrollTimerFired): ditto.
              (WebCore::Frame::stopAutoscrollTimer): ditto.
              (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
              * page/Frame.h:
              * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
      
              * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
              (WebCore::FrameViewPrivate::reset):
              (WebCore::FrameView::currentMousePosition):
              (WebCore::FrameView::handleMousePressEvent):
              (WebCore::FrameView::handleMouseDoubleClickEvent):
              (WebCore::selectCursor):
              (WebCore::FrameView::handleMouseMoveEvent):
              (WebCore::FrameView::handleMouseReleaseEvent):
              * page/FrameView.h:
      
              * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
              * platform/ScrollBar.h:
              (WebCore::):
              (WebCore::ScrollBar::controlSize):
              * platform/mac/PlatformScrollBar.h:
              * platform/mac/PlatformScrollBarMac.mm:
              (NSControlSizeForScrollBarControlSize):
              (-[WebCoreScrollBar initWithPlatformScrollBar:]):
              (WebCore::PlatformScrollBar::PlatformScrollBar):
      
              * rendering/RenderBlock.h:
              * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
              * rendering/RenderLayer.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::shouldAutoscroll):
              (WebCore::RenderObject::autoscroll):
              * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
      
              * css/html4.css: Added properties for new list boxes.
      
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
              (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
              * html/HTMLOptionElement.h: Added disabled method.
      
              * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
              (WebCore::HTMLSelectElement::recalcStyle):
              (WebCore::HTMLSelectElement::lastSelectedListIndex):
              (WebCore::HTMLSelectElement::deselectItems):
              (WebCore::HTMLSelectElement::setSelectedIndex):
              (WebCore::HTMLSelectElement::isKeyboardFocusable):
              (WebCore::HTMLSelectElement::isMouseFocusable):
              (WebCore::HTMLSelectElement::createRenderer):
              (WebCore::HTMLSelectElement::recalcListItems):
              (WebCore::HTMLSelectElement::setRecalcListItems):
              (WebCore::HTMLSelectElement::reset):
              (WebCore::HTMLSelectElement::notifyOptionSelected):
              (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
              (WebCore::HTMLSelectElement::nextSelectableListIndex):
              (WebCore::HTMLSelectElement::previousSelectableListIndex):
              * html/HTMLSelectElement.h:
      
              * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
              (WebCore::RenderTheme::paint):
              (WebCore::RenderTheme::paintBorderOnly):
              (WebCore::RenderTheme::paintDecorations):
              (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
              (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
              (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
              (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
              (WebCore::RenderTheme::isControlStyled):
              (WebCore::RenderTheme::supportsFocusRing):
              * rendering/RenderTheme.h:
              * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
      
              * rendering/RenderListBox.cpp: Added.
              (WebCore::RenderListBox::RenderListBox):
              (WebCore::RenderListBox::~RenderListBox):
              (WebCore::RenderListBox::setStyle):
              (WebCore::RenderListBox::updateFromElement):
              (WebCore::RenderListBox::calcMinMaxWidth):
              (WebCore::RenderListBox::size):
              (WebCore::RenderListBox::numItems):
              (WebCore::RenderListBox::calcHeight):
              (WebCore::RenderListBox::baselinePosition):
              (WebCore::RenderListBox::itemBoundingBoxRect):
              (WebCore::RenderListBox::paintObject):
              (WebCore::RenderListBox::paintScrollbar):
              (WebCore::RenderListBox::paintItemForeground):
              (WebCore::RenderListBox::paintItemBackground):
              (WebCore::RenderListBox::scrollBarTarget):
              (WebCore::RenderListBox::isPointInScrollbar):
              (WebCore::RenderListBox::optionAtPoint):
              (WebCore::RenderListBox::autoscroll):
              (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
              (WebCore::RenderListBox::scroll):
              (WebCore::RenderListBox::valueChanged):
              * rendering/RenderListBox.h: Added.
              (WebCore::RenderListBox::isListBox):
              (WebCore::RenderListBox::selectionChanged):
              (WebCore::RenderListBox::setSelectionChanged):
              (WebCore::RenderListBox::canHaveChildren):
              (WebCore::RenderListBox::renderName):
              (WebCore::RenderListBox::setOptionsChanged):
              (WebCore::RenderListBox::shouldAutoscroll):
              (WebCore::RenderListBox::listIndexIsVisible):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f989049f
    • bdakin's avatar
      Reviewed by Darin. · 9d05e15f
      bdakin authored
              We had a bug where html4.css was ignoring Media Queries. In the ned 
              the problem was that we were trying to send a char* to the 
              MediaQueryEvaluator constructor that expects a String, but the 
              char* got interpreted as a bool, the wrong constructor was called, 
              and the media type was never set.
      
              No test case possible since this only affects html4.css
      
              * css/MediaQueryEvaluator.cpp: New constructor that expects takes a 
              char*
              (WebCore::MediaQueryEvaluator):
              * css/MediaQueryEvaluator.h: Same.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d05e15f
    • ggaren's avatar
      LayoutTests: · eb140e63
      ggaren authored
              Reviewed by John, Maciej.
              
              Added test for whether a frame element reports its src attribute as a
              complete, rather than relative, URL.
      
              * fast/frames/frame-src-attribute-expected.txt: Added.
              * fast/frames/frame-src-attribute.html: Added.
              * fast/frames/resources/frame-src-attribute-subframe.html: Added.
      
      WebCore:
      
              Reviewed by John, Maciej.
              
              Integrated some frame and iframe code. I'm trying to fix up frame ownership
              and loading. Reducing the number of different code paths involved
              seemed like a good first step.
              
              As a side effect, I fixed a bug where FRAME elements would report their
              src attributes as relative, rather than compelete, URLs. (IFRAME elements
              had the correct complete URL behavior.)
      
              * html/HTMLFrameElement.cpp:
              (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
              (WebCore::HTMLFrameElement::openURL):
                  (1) Removed checks that requestFrame does for us
                  (2) Added isURLAllowed check, to have one clear bottleneck for it
                  (3) Added viewsource check, to have one clear bottleneck for it
              (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
              method, instead of finding our content frame in our own unique way.
              (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
              since openURL does this for us now.
              (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
              This is what FF does, and it made no sense to have different behaviors
              for FRAME and IFRAME elements.
              * html/HTMLIFrameElement.cpp:
              (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
              code.
              * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
              HTMLFrameElement now does everything we need.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb140e63
    • rwlbuis's avatar
      Reviewed by Hyatt. · 3fbe04f4
      rwlbuis authored
              Fix Qt/Linux build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fbe04f4
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · 5c038c28
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c038c28
    • weinig's avatar
      Reviewed by Tim H. · ac93628e
      weinig authored
              Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11082
              Simplify Internal methods for the auto-generated Objective-C DOM code
      
              - Auto-generate the internal methods for more Objective-C classes.
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOM.mm:
              * bindings/objc/DOMCSS.mm:
              (-[DOMStyleSheet WebCore::]):
              (+[DOMStyleSheet _styleSheetWith:WebCore::]):
              (-[DOMCSSRule WebCore::]):
              (-[DOMCSSRule _initWithCSSRule:WebCore::]):
              (+[DOMCSSRule _CSSRuleWith:WebCore::]):
              (-[DOMCSSValue WebCore::]):
              (-[DOMCSSValue _initWithCSSValue:WebCore::]):
              (+[DOMCSSValue _CSSValueWith:WebCore::]):
              * bindings/objc/DOMHTMLAppletElement.mm:
              (-[DOMHTMLAppletElement WebCore::]):
              (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
              * bindings/objc/DOMHTMLEmbedElement.mm:
              (-[DOMHTMLEmbedElement WebCore::]):
              (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMInternal.mm:
              * bindings/scripts/CodeGeneratorObjC.pm:
              * css/CSSCharsetRule.idl:
              * css/CSSFontFaceRule.idl:
              * css/CSSImportRule.idl:
              * css/CSSMediaRule.idl:
              * css/CSSPageRule.idl:
              * css/CSSPrimitiveValue.idl:
              * css/CSSStyleRule.idl:
              * css/CSSStyleSheet.idl:
              * css/CSSUnknownRule.idl:
              * css/CSSValueList.idl:
              * dom/KeyboardEvent.idl:
              * dom/MouseEvent.idl:
              * dom/MutationEvent.idl:
              * dom/NodeIterator.idl:
              * dom/OverflowEvent.idl:
              * dom/UIEvent.idl:
              * dom/WheelEvent.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac93628e
    • harrison's avatar
      LayoutTests: · 43f6c9d0
      harrison authored
              Reviewed by John Sullivan.
      
              <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
              <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
      
              * fast/text/attributed-substring-from-range-001-expected.txt: Added.
              * fast/text/attributed-substring-from-range-001.html: Added.
              
              Check attributed string results when starting or ending at a br element.
      
      WebCore:
      
              Reviewed by John Sullivan.
      
              <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
              <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
      
              Test added
              * fast/text/attributed-substring-from-range-001.html
      
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::attributedString):
              Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
              Also, add validation of the range.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43f6c9d0
    • rwlbuis's avatar
      Reviewed by Maciej. · eb9f6717
      rwlbuis authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
              InsertRule can not handle @import statements
      
              Allow @import as part of a css rule.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb9f6717
  3. 28 Sep, 2006 11 commits
    • hyatt's avatar
      Switch over the Mac-specific uses of viewportToContents/contentsToViewport. · 80a6a30d
      hyatt authored
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::eventMayStartDrag):
              (WebCore::FrameMac::dragHysteresisExceeded):
              (WebCore::FrameMac::mouseDown):
              (WebCore::FrameMac::shouldDragAutoNode):
              (WebCore::FrameMac::sendContextMenuEvent):
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge _visiblePositionForPoint:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80a6a30d
    • hyatt's avatar
      Eliminate viewportToContents and contentsToViewport · 97c694f0
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97c694f0
    • aliceli1's avatar
      Build fix by adding missing files for CommandByName · 82b0749c
      aliceli1 authored
              * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82b0749c
    • aliceli1's avatar
      Adding CommandByName files to the vcproj · 42f98123
      aliceli1 authored
              * WebCore.vcproj/WebCore/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42f98123
    • aliceli1's avatar
      · 0da5e09a
      aliceli1 authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0da5e09a
    • aroben's avatar
      Reviewed by Adele. · 5b965904
      aroben authored
              Remove no-longer-used PopUpButton.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
              * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
      	PopUpButtonMac.mm
              * platform/PopUpButton.h: Removed.
              * platform/mac/PopUpButtonMac.mm: Removed.
              * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
              * rendering/DeprecatedRenderSelect.cpp: Change #include of
      	PopUpButton.h to ListBox.h
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b965904
    • darin's avatar
      JavaScriptCore: · 6138a1eb
      darin authored
              Reviewed by Alice.
      
              - support for change that should fix <rdar://problem/4733044>
                REGRESSION: XML iBench shows 10% perf. regression (copying
                strings while decoding)
      
              * wtf/Vector.h: Changed VectorBuffer so that the general case
              contains an instance of the 0 case, since deriving from it
              was violating the Liskov Substitution Principle.
              (WTF::VectorBuffer::releaseBuffer): Added. Releases the buffer so it can
              be adopted by another data structure that uses the FastMalloc.h allocator.
              Returns 0 if the internal buffer was being used.
              (WTF::Vector::releaseBuffer): Added. Releases the buffer as above or creates
              a new one in the case where the internal buffer was being used.
      
      WebCore:
      
              Reviewed by Alice.
      
              - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
                10% perf. regression (copying strings while decoding)
      
              Use Vector<UChar> instead of String when building up the decoded string in
              the ICU and Mac decoders. Using String leads to O(n^2) behavior because
              String grows the buffer every single time that append is called. Using
              Vector::append instead of String::append also avoids constructing a string
              each time just to append and a questionable copy that is done inside the
              String::append function which also contributed to the slowness.
      
              * platform/PlatformString.h:
              * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
              Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
              allocation.
              * platform/StringImpl.h:
              * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
      
              * platform/StreamingTextDecoder.h:
              * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
              Change to use a Vector<UChar> instead of a String, since vectors have better
              resizing performance (they store a separate capacity).
      
              * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
              * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
              Change to use Vector<UChar> instead of String and then create a string at
              the end of the process using the new adopt function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6138a1eb
    • weinig's avatar
      Reviewed by Tim H. · f64d1354
      weinig authored
              Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11057
              Auto-generate more SVG Objective-C bindings
      
              - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean, 
                DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
                DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
                DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
                DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
                DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests, 
                and DOMSVGTransformable.
      
              - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
                parent interfaces and the SVG animated classes.
      
              - Corrects CodeGenerator.pm to only skip the first parent for the main 
                interface.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMSVG.h:
              * bindings/scripts/CodeGenerator.pm:
              * bindings/scripts/CodeGeneratorObjC.pm:
              * ksvg2/svg/SVGAnimatedAngle.idl:
              * ksvg2/svg/SVGAnimatedBoolean.idl:
              * ksvg2/svg/SVGAnimatedEnumeration.idl:
              * ksvg2/svg/SVGAnimatedInteger.idl:
              * ksvg2/svg/SVGAnimatedLength.idl:
              * ksvg2/svg/SVGAnimatedLengthList.idl:
              * ksvg2/svg/SVGAnimatedNumber.idl:
              * ksvg2/svg/SVGAnimatedPathData.idl:
              * ksvg2/svg/SVGAnimatedString.idl:
              * ksvg2/svg/SVGAnimatedTransformList.idl:
              * ksvg2/svg/SVGExternalResourcesRequired.idl:
              * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
              * ksvg2/svg/SVGFitToViewBox.idl:
              * ksvg2/svg/SVGLangSpace.idl:
              * ksvg2/svg/SVGLocatable.idl:
              * ksvg2/svg/SVGMetadataElement.idl:
              * ksvg2/svg/SVGStringList.idl:
              * ksvg2/svg/SVGStylable.idl:
              * ksvg2/svg/SVGStyleElement.idl:
              * ksvg2/svg/SVGTests.idl:
              * ksvg2/svg/SVGTransformable.idl:
              * ksvg2/svg/SVGURIReference.idl:
              * ksvg2/svg/SVGUnitTypes.idl:
              * ksvg2/svg/SVGZoomAndPan.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f64d1354
    • beidson's avatar
      Reviewed by Mitz Pettel!!! · a31d0ecf
      beidson authored
              Change the error code check for common functions from SQLResultOk to SQLResultDone 
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::forgetPageURLQuery):
              (WebCore::IconDatabase::setIconIDForPageURLQuery):
              (WebCore::IconDatabase::addIconForIconURLQuery):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a31d0ecf
    • hyatt's avatar
      Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be... · 18d2f317
      hyatt authored
      Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be the viewport point of reference for events and such.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18d2f317
    • hyatt's avatar
      Fix for bug 9222, cursor is wrong when mousing over overflow... · d6df5850
      hyatt authored
              Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
              selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
              scrollbars to provide hover feedback if needed.
      
              Reviewed by Eric
      
              * page/FrameView.cpp:
              (WebCore::selectCursor):
              (WebCore::FrameView::handleMouseMoveEvent):
              * platform/ScrollBar.h:
              (WebCore::ScrollBar::mouseMoved):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6df5850
  4. 27 Sep, 2006 6 commits
    • aroben's avatar
      2006-09-27 MorganL <morganl.webkit@yahoo.com> · c46cb262
      aroben authored
              Reviewed by Maciej and Adam, landed by Adam
      
              Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=11072
              Windows build is busted
      
              * platform/win/TemporaryLinkStubs.cpp:
              (ScrollView::paint):
              (ScrollView::themeChanged):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c46cb262
    • eseidel's avatar
      2006-09-27 Eric Seidel <eric@eseidel.com> · 4eb9f842
      eseidel authored
              Reviewed by mitz.
      
              paths with no fill specified default to black but do not recieve paint-related mouse events
              http://bugzilla.opendarwin.org/show_bug.cgi?id=11069
              The default fill was being applied at the wrong place in the rendering chain, causing this problem.
      
              Test: svg/custom/hover-default-fill.svg
      
              * kcanvas/RenderPath.cpp:
              (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
              * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
              * ksvg2/misc/KCanvasRenderingStyle.cpp:
              (WebCore::KSVGPainterFactory::isFilled): remove null check
              (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
              (WebCore::KSVGPainterFactory::isStroked): remove null check
              (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
              * ksvg2/svg/SVGPaint.cpp:
              (WebCore::SVGPaint::defaultFill): added.
              (WebCore::SVGPaint::defaultStroke): added.
              * ksvg2/svg/SVGPaint.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4eb9f842
    • rwlbuis's avatar
      Reviewed by eseidel. · 54820aa2
      rwlbuis authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=11015
              SVG handles em units incorrectly
      
              Calculate viewport coordinates at layout time, since
              at this point the font size is known and lengths depending
              on font sizes can be calculated correctly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54820aa2
    • eseidel's avatar
      2006-09-27 Eric Seidel <eric@eseidel.com> · 9c1a0334
      eseidel authored
              Reviewed by darin.
      
              Change our invalid-fill error behavior to match Opera (and soon Firefox)
              http://bugzilla.opendarwin.org/show_bug.cgi?id=11017
      
              * ksvg2/misc/KCanvasRenderingStyle.cpp:
              (WebCore::KSVGPainterFactory::isFilled):
              (WebCore::KSVGPainterFactory::fillPaintServer):
              (WebCore::KSVGPainterFactory::isStroked):
              (WebCore::KSVGPainterFactory::strokePaintServer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c1a0334
    • beidson's avatar
      Build fix · 52c4fbcc
      beidson authored
              * loader/icon/IconDatabase.cpp:
              (WebCore::readySQLStatement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52c4fbcc
    • beidson's avatar
      WebCore: · b8a16d03
      beidson authored
              Reviewed by Adam
      
              In very specific circumstances, prepared SQLStatements can become invalid without
              any warning.  This checks for that state and re-prepares the statement and also
              adds more aggressive error-checking everywhere these statements are used.
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
              (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
              (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
              (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
              (WebCore::IconDatabase::forgetPageURLQuery): Ditto
              (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
              (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
              (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
              (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
              * loader/icon/SQLStatement.cpp:
              (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
              * loader/icon/SQLStatement.h:
              
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8a16d03
  5. 26 Sep, 2006 3 commits
    • darin's avatar
      Reviewed by Steve. · f2b7ba53
      darin authored
              - clean up options for font code path
      
              * platform/Font.h:
              * platform/Font.cpp:
              (WebCore::Font::setCodePath): Added. Replaces boolean version.
              (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
      
              * platform/mac/WebCoreTextRenderer.mm:
              (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2b7ba53
    • sullivan's avatar
      WebCore: · caf3550b
      sullivan authored
              Reviewed by Darin
      
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
              Added limit parameter, passed down to Frame
              
              * page/Frame.h:
              * page/Frame.cpp:
              (WebCore::Frame::markAllMatchesForText):
              Added limit parameter. Stop the search if it hits limit.
      
      WebKit:
      
              Reviewed by Darin
      
              * WebView/WebHTMLViewPrivate.h:
              * WebView/WebHTMLView.m:
              (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
              Added limit parameter, passed over the bridge. Stop the search if it hits limit.
      
              * WebView/WebViewPrivate.h:
              * WebView/WebView.m:
              (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
              Added limit parameter, passed to WebHTMLView.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      caf3550b
    • seangies's avatar
      Removed #if's. · baf40fdf
      seangies authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baf40fdf