1. 18 Jan, 2011 1 commit
  2. 17 Jan, 2011 9 commits
    • tonyg@chromium.org's avatar
      2011-01-17 Tony Gentilcore <tonyg@chromium.org> · 938b60ed
      tonyg@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              Fix some headers with missing or misspelled #ifndef guards
              https://bugs.webkit.org/show_bug.cgi?id=52545
      
              * wtf/RefPtrHashMap.h:
      2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Fix some headers with missing or misspelled #ifndef guards
              https://bugs.webkit.org/show_bug.cgi?id=52545
      
              No new tests because no new functionality.
      
              * ForwardingHeaders/runtime/InitializeThreading.h:
              * editing/SmartReplace.h:
              * loader/CrossOriginAccessControl.h:
              * loader/NetscapePlugInStreamLoader.h:
              * platform/chromium/ClipboardUtilitiesChromium.h:
              * platform/graphics/cairo/DrawErrorUnderline.h:
              * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
              * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
              * platform/graphics/cg/PDFDocumentImage.h:
              * platform/win/WebCoreTextRenderer.h:
      2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Fix some headers with missing or misspelled #ifndef guards
              https://bugs.webkit.org/show_bug.cgi?id=52545
      
              * WebKitStatistics.h:
      2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Fix some headers with missing or misspelled #ifndef guards
              https://bugs.webkit.org/show_bug.cgi?id=52545
      
              * Shared/UserMessageCoders.h:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
              * WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
              * WebProcess/WebProcessMain.h:
      2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Fix some headers with missing or misspelled #ifndef guards
              https://bugs.webkit.org/show_bug.cgi?id=52545
      
              * DumpRenderTree/chromium/TestEventPrinter.h:
              * DumpRenderTree/chromium/WebPreferences.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      938b60ed
    • jberlin@webkit.org's avatar
      REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when · d617a3b2
      jberlin@webkit.org authored
      navigating back to an unreachable URL
      https://bugs.webkit.org/show_bug.cgi?id=52388
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Test: http/tests/navigation/go-back-to-error-page.html
      
      * history/PageCache.cpp:
      (WebCore::PageCache::canCachePageContainingThisFrame):
      Do not cache any error pages (which we can recognize as having substitute data and/or an
      unreachableURL).
      
      Tools: 
      
      Add a third parameter (unreachableURL) to queueLoadHTMLString.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (queueLoadHTMLStringCallback):
      (LayoutTestController::queueLoadHTMLString):
      (LayoutTestController::queueLoadAlternateHTMLString):
      * DumpRenderTree/LayoutTestController.h:
      
      * DumpRenderTree/WorkQueueItem.h:
      (LoadHTMLStringItem::LoadHTMLStringItem):
      
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
      (WorkItemLoadHTMLString::run):
      (LayoutTestController::queueLoadHTMLString):
      
      * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
      (LoadHTMLStringItem::invoke):
      * DumpRenderTree/mac/WorkQueueItemMac.mm:
      (LoadHTMLStringItem::invoke):
      * DumpRenderTree/win/WorkQueueItemWin.cpp:
      (LoadHTMLStringItem::invoke):
      
      LayoutTests: 
      
      Add a test that loads an alternate HTML String for an "unreachable" URL, loads another
      page, and then goes back to the "unreachable" URL, which is now reachable.
      
      This tests two things:
      1) No assertion failure when going back to an unreachable URL.
      2) There is no page cached for the unreachable URL.
      
      * http/tests/navigation/go-back-to-error-page-expected.txt: Added.
      * http/tests/navigation/go-back-to-error-page.html: Added.
      * http/tests/navigation/resources/page-to-go-back-from.html: Added.
      * http/tests/navigation/resources/page-treated-as-unreachable.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d617a3b2
    • mitz@apple.com's avatar
      Update xcodeproj svn:ignore to include xcuserdata. · 2db326be
      mitz@apple.com authored
      Rubber-stamped by Mark Rowe.
      
      Examples: 
      
      * NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
      * NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
      * NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
      * NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.
      
      Source/JavaScriptCore: 
      
      * JavaScriptCore.xcodeproj: Modified property svn:ignore.
      
      Source/JavaScriptGlue: 
      
      * JavaScriptGlue.xcodeproj: Modified property svn:ignore.
      
      Source/ThirdParty/ANGLE: 
      
      * ANGLE.xcodeproj: Modified property svn:ignore.
      * src/build_angle.xcodeproj: Modified property svn:ignore.
      
      Source/WebCore: 
      
      * WebCore.xcodeproj: Modified property svn:ignore.
      * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.
      
      Source/WebKit: 
      
      * WebKit.xcodeproj: Modified property svn:ignore.
      
      Source/WebKit2: 
      
      * ...
      2db326be
    • ossy@webkit.org's avatar
      Unreviewed fix after r75908. · 2fb61453
      ossy@webkit.org authored
      Move WebKit into Source
      https://bugs.webkit.org/show_bug.cgi?id=52530
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fb61453
    • ossy@webkit.org's avatar
      Unreviewed. · edc79f3f
      ossy@webkit.org authored
      Remove accidentally committed debug printing after r75908.
      
      * Scripts/webkitdirs.pm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edc79f3f
    • jknotten@chromium.org's avatar
      2011-01-17 John Knottenbelt <jknotten@chromium.org> · 865c6af3
      jknotten@chromium.org authored
              Unreviewed.
      
              Add myself to committers list
              https://bugs.webkit.org/show_bug.cgi?id=52566
      
              * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      865c6af3
    • jknotten@chromium.org's avatar
      2011-01-17 John Knottenbelt <jknotten@chromium.org> · 390c2e34
      jknotten@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              GeolocationController should call stopUpdating on destruction
              https://bugs.webkit.org/show_bug.cgi?id=52216
      
              fast/dom/window-close-crash.html tests that we do not fail the
              assertion in the mock GeolocationClient that the GeolocationClient
              is not updating when the GeolocationController is destroyed.
      
              * fast/dom/Geolocation/resources/window-close-popup.html: Added.
              * fast/dom/Geolocation/script-tests/window-close-crash.js: Added.
              (gotPosition):
              (waitForWindowToClose):
              (failedToCreateWatch):
              * fast/dom/Geolocation/window-close-crash-expected.txt: Added.
              * fast/dom/Geolocation/window-close-crash.html: Added.
              * platform/gtk/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
      2011-01-17  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              GeolocationController should call stopUpdating on destruction
              https://bugs.webkit.org/show_bug.cgi?id=52216
      
              Test: fast/dom/Geolocation/window-close-crash.html
      
              * page/GeolocationController.cpp:
              (WebCore::GeolocationController::~GeolocationController):
      2011-01-17  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              GeolocationController should call stopUpdating on destruction
              https://bugs.webkit.org/show_bug.cgi?id=52216
      
              fast/dom/Geolocation/window-close-crash.html requires that a
              Geolocation watch be started in a secondary window. Consequently,
              we need to allow geolocation permission and provide a mock
              geolocation position for the secondary window's
              GeolocationClientMock.
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::setGeolocationPermission):
              (LayoutTestController::setMockGeolocationPosition):
              (LayoutTestController::setMockGeolocationError):
              * DumpRenderTree/chromium/TestShell.h:
              (TestShell::windowList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      390c2e34
    • abarth@webkit.org's avatar
      2011-01-16 Adam Barth <abarth@webkit.org> · 93df65cb
      abarth@webkit.org authored
              Update more include paths to reflect WebKit move.
      
              * DumpRenderTree/chromium/EventSender.cpp:
              (EventSender::keyDown):
              (EventSender::needsShiftModifier):
              * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
              * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93df65cb
    • tkent@chromium.org's avatar
      2011-01-16 Kent Tamura <tkent@chromium.org> · 83b8975e
      tkent@chromium.org authored
              Unreviewed, Chromium build fix.
      
              * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83b8975e
  3. 16 Jan, 2011 3 commits
  4. 15 Jan, 2011 3 commits
  5. 14 Jan, 2011 11 commits
    • bweinstein@apple.com's avatar
      ShouldLoadResourceForFrame should use strings, not URLs. · 2f3ef409
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52476
      
      Reviewed by Geoff Garen.
      
      Tools: 
      
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
      
      WebKit2: 
      
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
      (WebKit::InjectedBundlePageLoaderClient::shouldLoadResourceForFrame): Pass resourceURL as a string instead of
          a URL, and rename from subresourceURL to resourceURL.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f3ef409
    • tonyg@chromium.org's avatar
      2011-01-14 Tony Gentilcore <tonyg@chromium.org> · 0aeb9e9f
      tonyg@chromium.org authored
              Reviewed by David Levin.
      
              Add Tony Gentilcore as a reviewer
              https://bugs.webkit.org/show_bug.cgi?id=52480
      
              * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0aeb9e9f
    • levin@chromium.org's avatar
      2011-01-14 David Levin <levin@chromium.org> · 5fe2bcb0
      levin@chromium.org authored
              Reviewed by Eric Seidel.
      
              check-webkit-style: _FunctionState should keep track of where the function name starts.
              https://bugs.webkit.org/show_bug.cgi?id=52454
      
              * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
              _FunctionState and logic for setting it correctly.
              * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fe2bcb0
    • commit-queue@webkit.org's avatar
      2011-01-14 Vincent Scheib <scheib@chromium.org> · ea5fb8d1
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Add support to DumpRenderTree to use the GPU rather than software renderer
              https://bugs.webkit.org/show_bug.cgi?id=52333
      
              * DumpRenderTree/chromium/DumpRenderTree.cpp:
              (main):
              * Scripts/webkitpy/layout_tests/port/chromium.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      2011-01-14  Vincent Scheib  <scheib@chromium.org>
      
              Reviewed by David Levin.
      
              Add support to DumpRenderTree to use the GPU rather than software renderer
              https://bugs.webkit.org/show_bug.cgi?id=52333
      
              * DEPS: Moved forward to take required support from webkit_support.h
              * WebKit.gyp: DumpRenderTree depends on Angle on windows
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea5fb8d1
    • tony@chromium.org's avatar
      2011-01-14 Tony Chang <tony@chromium.org> · 482e80c7
      tony@chromium.org authored
              Reviewed by Kent Tamura.
      
              [chromium] update fonts.conf to fix 6 linux tests in drt
              https://bugs.webkit.org/show_bug.cgi?id=52411
      
              * platform/chromium/test_expectations.txt:
      2011-01-14  Tony Chang  <tony@chromium.org>
      
              Reviewed by Kent Tamura.
      
              [chromium] update fonts.conf to fix 6 linux tests in drt
              https://bugs.webkit.org/show_bug.cgi?id=52411
      
              * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
                  chromium's src/webkit/tools/test_shell/resources/fonts.conf
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      482e80c7
    • eric@webkit.org's avatar
      2011-01-14 Eric Seidel <eric@webkit.org> · dffe34a7
      eric@webkit.org authored
              Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
      
              Reviewed by Adam Barth.
      
              Fix when running Tools/Scripts/check-webkit-style without arguments.
              https://bugs.webkit.org/show_bug.cgi?id=52261#c16
      
              * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
              * Scripts/webkitpy/common/checkout/scm_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dffe34a7
    • jochen@chromium.org's avatar
      2011-01-04 Jochen Eisinger <jochen@chromium.org> · 3555d084
      jochen@chromium.org authored
              Reviewed by David Levin.
      
              Store the tempdir object in a variable so it doesn't get deleted too early.
              https://bugs.webkit.org/show_bug.cgi?id=51875
      
              * Scripts/update-webkit-auxiliary-libs:
              * Scripts/update-webkit-support-libs:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3555d084
    • eric@webkit.org's avatar
      2011-01-14 Eric Seidel <eric@webkit.org> · 7dcc87ad
      eric@webkit.org authored
              Unreviewed.  Make it work in python 2.5.
      
              webkit-patch suggest-reviewers dies when ChangeLogs are missing
              https://bugs.webkit.org/show_bug.cgi?id=49158
      
              * Scripts/webkitpy/common/checkout/api_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dcc87ad
    • loislo@chromium.org's avatar
      2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com> · f2e57dc1
      loislo@chromium.org authored
              Unreviewed, rolling out r75774.
              http://trac.webkit.org/changeset/75774
              https://bugs.webkit.org/show_bug.cgi?id=52431
      
              gtk builds were broken (Requested by loislo2 on #webkit).
      
              * CMakeLists.txt:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/Inspector.idl:
              * inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
              * inspector/InspectorBrowserDebuggerAgent.h: Removed.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::inspectedPageDestroyed):
              (WebCore::InspectorController::didCommitLoad):
              (WebCore::InspectorController::enableDebuggerFromFrontend):
              (WebCore::InspectorController::disableDebugger):
              (WebCore::InspectorController::restoreStickyBreakpoints):
              (WebCore::InspectorController::restoreStickyBreakpoint):
              (WebCore::InspectorController::setEventListenerBreakpoint):
              (WebCore::InspectorController::removeEventListenerBreakpoint):
              (WebCore::InspectorController::hasEventListenerBreakpoint):
              (WebCore::InspectorController::setXHRBreakpoint):
              (WebCore::InspectorController::removeXHRBreakpoint):
              (WebCore::InspectorController::hasXHRBreakpoint):
              * inspector/InspectorController.h:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::discardBindings):
              (WebCore::InspectorDOMAgent::setDOMBreakpoint):
              (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
              (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
              (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
              (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
              (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
              (WebCore::InspectorDOMAgent::didInsertDOMNode):
              (WebCore::InspectorDOMAgent::didRemoveDOMNode):
              (WebCore::InspectorDOMAgent::hasBreakpoint):
              (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
              (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
      
      2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r75774.
              http://trac.webkit.org/changeset/75774
              https://bugs.webkit.org/show_bug.cgi?id=52431
      
              gtk builds were broken (Requested by loislo2 on #webkit).
      
              * Scripts/webkitpy/common/checkout/scm.py:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2e57dc1
    • levin@chromium.org's avatar
      check-webkit-style: _FunctionState should detect pure functions. · 2966763f
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52428
      
      Reviewed by Shinichiro Hamaji.
      
      * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
      is a pure virtual function.
      * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
      virtual functions are correctly detected.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2966763f
    • loislo@chromium.org's avatar
      2011-01-12 Ilya Tikhonovsky <loislo@chromium.org> · 741bf235
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
              We have some methods of Debugger which are related to DOM.
              Lets extract these methods to BrowserDebugger agent.
      
              http://bugs.webkit.org/show_bug.cgi?id=52294
      
              * CMakeLists.txt:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/Inspector.idl:
              * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
              (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
              (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
              (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
              (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
              (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
              (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
              (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
              (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
              (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
              * inspector/InspectorBrowserDebuggerAgent.h: Added.
              (WebCore::InspectorBrowserDebuggerAgent::create):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::inspectedPageDestroyed):
              (WebCore::InspectorController::didCommitLoad):
              (WebCore::InspectorController::enableDebuggerFromFrontend):
              (WebCore::InspectorController::disableDebugger):
              (WebCore::InspectorController::restoreStickyBreakpoints):
              (WebCore::InspectorController::restoreStickyBreakpoint):
              * inspector/InspectorController.h:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::discardBindings):
              (WebCore::InspectorDOMAgent::didInsertDOMNode):
              (WebCore::InspectorDOMAgent::didRemoveDOMNode):
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
              (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
      
      2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Just small fix for problem with check-webkit-style.
              It just didn't work for this patch.
              Old code can't concatenate a list of strings with None.
      
              * Scripts/webkitpy/common/checkout/scm.py:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      741bf235
  6. 13 Jan, 2011 12 commits
    • levin@chromium.org's avatar
      2011-01-13 David Levin <levin@chromium.org> · 2021db24
      levin@chromium.org authored
              Reviewed by Shinichiro Hamaji.
      
              check-webkit-style: _FunctionState should use Position to know where items are.
              https://bugs.webkit.org/show_bug.cgi?id=52424
      
              * Scripts/webkitpy/style/checkers/cpp.py:
              (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
              (detect_functions): Changed to pass Position's to _FunctionState.begin and
              did some minor clean-up.
              (*): Other changes are simply about converting to use the Position's in_FunctionState
              instead of line numbers.
              * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
              to verify the positions stored in _FunctionState.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2021db24
    • eric@webkit.org's avatar
      2011-01-13 Eric Seidel <eric@webkit.org> · 7500b00d
      eric@webkit.org authored
              Reviewed by David Levin.
      
              webkit-patch suggest-reviewers dies when ChangeLogs are missing
              https://bugs.webkit.org/show_bug.cgi?id=49158
      
              This is not the most elegant, but it is a very safe fix to this bug.
              One advantage of catching ScriptError like this instead of adding a
              new added_or_modified_files or fixing all changed_files callers
              to use a more specific change_files variant, is that we catch
              all kinds of ScriptErrors which might cause our (non-essential)
              suggest-reviewers code to fail out.  This should make passing
              --suggest-reviewers to webkit-patch upload much more robust
              and may even make it possible for us to make it default.
      
              The root of the problem here is that SCM.changed_files includes
              deleted ChangeLog paths (from moves, etc) which then when we ask
              SVN/Git for the contents of the file at that revision, the command
              errors out and Executive.run_command raises a ScriptError.
      
              In the future we might fix this differently by making all current
              callers of chagned_files use a more specific method for requesting
              what types of changes they're interested in (adds, modifies, deletes, etc.)
      
              * Scripts/webkitpy/common/checkout/api.py:
              * Scripts/webkitpy/common/checkout/api_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7500b00d
    • mitz@apple.com's avatar
      <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if... · 1c3ad0ea
      mitz@apple.com authored
      <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
      https://bugs.webkit.org/show_bug.cgi?id=52419
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore: 
      
      Test: http/tests/loading/cross-origin-XHR-willLoadRequest.html
      
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::init): Complete r74453 by ensuring that m_request is only set after
      willSendRequest(). Otherwise, willSendRequest() ends up calling into
      ThreadableDocumentRequest::willSendRequest(), which cancels the request.
      
      Tools: 
      
      Allow to further control the behavior of the willSendRequest delegate callback by making it
      set a different URL in the new request.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (addURLToRedirectCallback): Added.
      (LayoutTestController::staticFunctions): Added addURLToRedirect.
      (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
      (LayoutTestController::redirectionDestinationForURL): Added this getter.
      * DumpRenderTree/LayoutTestController.h:
      * DumpRenderTree/mac/ResourceLoadDelegate.mm:
      (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
      if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
      change the URL in the new request to the redirect destination.
      
      LayoutTests: 
      
      * http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt: Added.
      * http/tests/loading/cross-origin-XHR-willLoadRequest.html: Added.
      * platform/gtk/Skipped: Skip the new test.
      * platform/qt/Skipped: Ditto.
      * platform/win/Skipped: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c3ad0ea
    • eric@webkit.org's avatar
      2011-01-13 Eric Seidel <eric@webkit.org> · dfc446d1
      eric@webkit.org authored
              Reviewed by Mihai Parparita.
      
              webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
              https://bugs.webkit.org/show_bug.cgi?id=52416
      
              Example: webkit-patch suggest-reviewers -g ca3890fe
              UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
      
              I also added FIXMEs about the changed_files returning deleted files problem
              which is causing the other most common exception for suggest-reviewers
              (and is probably breaking sheriff-bots blame detection).
      
              * Scripts/webkitpy/common/checkout/api.py:
              * Scripts/webkitpy/common/checkout/api_unittest.py:
              * Scripts/webkitpy/common/checkout/scm.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfc446d1
    • eric@webkit.org's avatar
      2011-01-13 Eric Seidel <eric@webkit.org> · f9a94b03
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              results archives from commit-queue are too large to upload
              https://bugs.webkit.org/show_bug.cgi?id=52405
      
              * Scripts/webkitpy/common/system/filesystem.py:
              * Scripts/webkitpy/common/system/filesystem_mock.py:
              * Scripts/webkitpy/tool/commands/queues.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9a94b03
    • alex@webkit.org's avatar
      2011-01-13 Alejandro G. Castro <alex@igalia.com> · 4b7a1f76
      alex@webkit.org authored
              Reviewed by Martin Robinson.
      
              [gtk] Zero-sized font does not yet work
              https://bugs.webkit.org/show_bug.cgi?id=49793
      
              Unskip font-size-zero.html.
      
              * platform/gtk/Skipped:
      
      2011-01-13  Alejandro G. Castro  <alex@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [gtk] Zero-sized font does not yet work
              https://bugs.webkit.org/show_bug.cgi?id=49793
      
              Set minimum-font-size to 0 for the DRT.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
      
      2011-01-13  Alejandro G. Castro  <alex@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [gtk] Zero-sized font does not yet work
              https://bugs.webkit.org/show_bug.cgi?id=49793
      
              Allow 0 as a minimum-font-size value for the settings.
      
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b7a1f76
    • ossy@webkit.org's avatar
      2011-01-13 Csaba Osztrogonác <ossy@webkit.org> · a331c0a2
      ossy@webkit.org authored
              Reviewed by Darin Adler.
      
              Make old-run-webkit-tests more robust on buildbots
              https://bugs.webkit.org/show_bug.cgi?id=52364
      
              * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a331c0a2
    • ossy@webkit.org's avatar
      2011-01-13 Csaba Osztrogonác <ossy@webkit.org> · d84c9287
      ossy@webkit.org authored
              Reviewed by Darin Adler.
      
              Make old-run-webkit-tests more robust on buildbots
              https://bugs.webkit.org/show_bug.cgi?id=52364
      
              * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d84c9287
    • tony@chromium.org's avatar
      2011-01-13 Tony Chang <tony@chromium.org> · c87743cb
      tony@chromium.org authored
              Reviewed by Kent Tamura.
      
              [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
              https://bugs.webkit.org/show_bug.cgi?id=52332
      
              Fix Linux baseline. Mac should now match Safari Mac.
      
              * platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
              * platform/chromium/test_expectations.txt:
      2011-01-13  Tony Chang  <tony@chromium.org>
      
              Reviewed by Kent Tamura.
      
              [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
              https://bugs.webkit.org/show_bug.cgi?id=52332
      
              Forked Info.plist is not longer needed.
      
              * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
      2011-01-13  Tony Chang  <tony@chromium.org>
      
              Reviewed by Kent Tamura.
      
              [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
              https://bugs.webkit.org/show_bug.cgi?id=52332
      
              * WebKit.gyp: Remove WebKitTestNetscapePlugIn
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c87743cb
    • mnaganov@chromium.org's avatar
      2011-01-13 Mikhail Naganov <mnaganov@chromium.org> · 57207cd5
      mnaganov@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Cleanup after r75613 -- make all UI-facing strings
              to be passed directly to WebInspector.UIString
      
              https://bugs.webkit.org/show_bug.cgi?id=52365
      
              * English.lproj/localizedStrings.js:
              * inspector/front-end/ApplicationCacheItemsView.js:
              (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
              (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
              * inspector/front-end/AuditRules.js:
              (WebInspector.AuditRules.GzipRule.prototype.doRun):
              (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
              (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.EventListenerBreakpointsSidebarPane):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
              * inspector/front-end/CookieItemsView.js:
              (WebInspector.CookieItemsView.prototype._updateWithCookies):
              * inspector/front-end/ImageView.js:
              (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
              (WebInspector.ImageView.prototype._createContentIfNeeded):
              * inspector/front-end/NetworkPanel.js:
              (WebInspector.NetworkTimeCalculator.prototype.formatValue):
              (WebInspector.NetworkTransferTimeCalculator.prototype.formatValue):
              (WebInspector.NetworkTransferDurationCalculator.prototype.formatValue):
              * inspector/front-end/ProfileDataGridTree.js:
              (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
              (WebInspector.ProfileDataGridNode.prototype.get data):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.Type.toUIString):
              (WebInspector.Resource.Type.toString):
              * inspector/front-end/TimelineOverviewPane.js:
              (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
              * inspector/front-end/TimelinePanel.js:
              (WebInspector.TimelinePanel):
              (WebInspector.TimelineCalculator.prototype.formatValue):
              (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
              (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
              (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
              * inspector/front-end/utilities.js:
              ():
              * Scripts/check-inspector-strings:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57207cd5
    • commit-queue@webkit.org's avatar
      2011-01-13 Sheriff Bot <webkit.review.bot@gmail.com> · fc237bdd
      commit-queue@webkit.org authored
              Unreviewed, rolling out r74881.
              http://trac.webkit.org/changeset/74881
              https://bugs.webkit.org/show_bug.cgi?id=52357
      
              The EFL builder has been red for days (Requested by abarth on
              #webkit).
      
              * Scripts/webkitpy/common/net/buildbot/buildbot.py:
              * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc237bdd
    • mjs@apple.com's avatar
      2011-01-12 Maciej Stachowiak <mjs@apple.com> · 74f62170
      mjs@apple.com authored
              Reviewed by David Levin.
      
              Add beforeunload support to WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=52353
      
              * platform/mac-wk2/Skipped: Unskip a test that was failing solely due to missing
              beforeunload support.
      2011-01-12  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by David Levin.
      
              Add beforeunload support to WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=52353
              
              This makes a number of currently failing tests pass.
      
              * WebKitTestRunner/TestController.cpp:
              (WTR::runBeforeUnloadConfirmPanel):
              (WTR::createOtherPage):
              (WTR::TestController::initialize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74f62170
  7. 12 Jan, 2011 1 commit