- 17 Nov, 2006 5 commits
-
-
thatcher authored
<rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves * WebKit.xcodeproj/project.pbxproj: * WebView/WebView.mm: (+[WebView initialize]): (-[WebView setPreferences:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17830 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rwlbuis authored
http://bugs.webkit.org/show_bug.cgi?id=11635 Bug 11635: Fix potential issue with non-xslt build Fix the issue and do style guideline corrections. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17829 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
thatcher authored
<rdar://problem/4843131> text entry is slow inside element that has the deletion rectangle around it Only disable/enable the delete button inside applyCommand() to prevent slowing down typing. This reintroduces <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside * editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply): (WebCore::applyCommand): * editing/EditCommand.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17828 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zimmermann authored
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11617 Adapt to latest API changes, fixing Qt/Linux build. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
harrison authored
<rdar://problem/4799899> Frame::revealSelection() only scrolls the startContainer's layer Replace an assert with a fixme that refers to this bug. * page/Frame.cpp: (WebCore::Frame::revealSelection): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 16 Nov, 2006 14 commits
-
-
beidson authored
Reviewed and landed by Brady Testcase for: http://bugs.webkit.org/show_bug.cgi?id=11590 Bug 11590: REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render * fast/css/import-rule-regression-11590-expected.txt: Added. * fast/css/import-rule-regression-11590.html: Added. * fast/css/resources/imports.css: Added. * fast/css/resources/style.css: Added. WebCore: Reviewed and landed by Brady Fixes http://bugs.webkit.org/show_bug.cgi?id=11590 - REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render Fix the regression by setting m_loadCompleted correctly. * css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded): * dom/Node.h: (WebCore::Node::sheetLoaded): * dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded): * dom/ProcessingInstruction.h: * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::sheetLoaded): * html/HTMLLinkElement.h: * html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::sheetLoaded): * html/HTMLStyleElement.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17825 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
harrison authored
<rdar://problem/4056100> REGRESSION (Tiger): Deleting top part of reply email leaves fails to clear text at end of message The problem was triggered by the fact that the parent div was changing both in position and in height. The renderer normally bifurcates its logic for x-position changes vs height changes. Call repaintDuringLayoutIfMoved() with old rect (incl. width and height) instead of just the old position. Test added: * manual-tests/delete-into-nested-block.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::positionNewFloats): * rendering/RenderBox.cpp: (WebCore::RenderBox::repaintDuringLayoutIfMoved): * rendering/RenderBox.h: * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::placeChild): * rendering/RenderObject.cpp: (WebCore::RenderObject::repaintDuringLayoutIfMoved): * rendering/RenderObject.h: * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17824 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Slider cleanup. Let the theme set the size of the slider thumb. * rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): Moving the thumb's appearance adjustment to createThumbStyle. (WebCore::RenderSlider::createThumbStyle): (WebCore::RenderSlider::layout): Let the theme set the size of the thumb. * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbSize): Added. * rendering/RenderTheme.h: ditto. * rendering/RenderThemeMac.h: ditto. * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17823 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andersca authored
Use Vector instead of DeprecatedValueList in a few places. * bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::getOwnPropertySlot): * bindings/js/kjs_dom.h: * bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLCollection::getNamedItems): * bindings/objc/DOM.mm: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::dashboardRegionsDictionary): * css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::diff): * html/HTMLCollection.cpp: (WebCore::HTMLCollection::namedItems): * html/HTMLCollection.h: * kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation): * kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEColorMatrix::values): (WebCore::KCanvasFEColorMatrix::setValues): (WebCore::KCanvasFEConvolveMatrix::kernel): (WebCore::KCanvasFEConvolveMatrix::setKernel): * kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack): (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter): * ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::filterEffect): * platform/graphics/svg/SVGResourceClipper.h: * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: (WebCore::SVGResourceClipper::applyClip): * platform/network/FormData.h: * rendering/RenderPath.h: * rendering/SVGRenderTreeAsText.h: (WebCore::operator<<): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17818 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andersca authored
* editing/markup.cpp: (WebCore::createMarkup): Add null-checks for the frame, it might not exist for all documents. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17817 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ap authored
Reviewed and landed by ap. http://bugs.webkit.org/show_bug.cgi?id=11509: Windows build bustage. Also reorganizes WebCore.vcproj to add files whose absence wasn't causing compile errors, but which should have been there, and to make the include directory ordering (and contents) sane. Also reorganizes TemporaryLinkStubs.cpp to put headers and function groups in alphabetical order, and ensure that all functions in the file call notImplemented(). WebCore: * WebCore.vcproj/WebCore/WebCore.vcproj: * bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref): * bridge/win/ContextMenuClientWin.h: Added. (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref): * bridge/win/EditorClientWin.h: * bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin): (WebCore::FrameWin::keyPress): * bridge/win/FrameWin.h: * bridge/win/PageWin.cpp: Removed. * editing/EditCommand.h: * loader/FormState.h: * loader/FrameLoader.h: * page/EventHandler.cpp: * platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes): * platform/graphics/win/ImageWin.cpp: * platform/network/ResourceError.cpp: * platform/network/ResourceHandleInternal.h: * platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): * platform/win/ScreenWin.cpp: (WebCore::monitorInfo): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth): * platform/win/SoundWin.cpp: Added. (WebCore::systemBeep): * platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::CheckCacheObjectStatus): (WebCore::CheckIfReloading): (WebCore::defaultLanguage): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::findNextSentenceFromIndex): (WebCore::findNextWordFromIndex): (WebCore::findSentenceBoundary): (WebCore::findWordBoundary): (WebCore::focusRingColor): (WebCore::historyContains): (WebCore::inputElementAltText): (WebCore::IsResponseURLEqualToURL): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::refreshPlugins): (WebCore::resetButtonDefaultLabel): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::ResponseURL): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::searchableIndexIntroduction): (WebCore::ServeSynchronousRequest): (WebCore::setFocusRingColorChangeFunction): (WebCore::submitButtonDefaultLabel): (WebCore::CachedResource::setPlatformResponse): (WebCore::CachedResource::setAllData): (WebCore::ChromeClientWin::setWindowRect): (WebCore::ChromeClientWin::windowRect): (WebCore::ChromeClientWin::pageRect): (WebCore::ChromeClientWin::scaleFactor): (WebCore::ChromeClientWin::focus): (WebCore::ChromeClientWin::unfocus): (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::ChromeClientWin::show): (WebCore::ChromeClientWin::canRunModal): (WebCore::ChromeClientWin::runModal): (WebCore::ChromeClientWin::setToolbarsVisible): (WebCore::ChromeClientWin::toolbarsVisible): (WebCore::ChromeClientWin::setStatusbarVisible): (WebCore::ChromeClientWin::statusbarVisible): (WebCore::ChromeClientWin::setScrollbarsVisible): (WebCore::ChromeClientWin::scrollbarsVisible): (WebCore::ChromeClientWin::setMenubarVisible): (WebCore::ChromeClientWin::menubarVisible): (WebCore::ChromeClientWin::setResizable): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenuClientWin::addCustomContextMenuItems): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::EditorClientWin::shouldDeleteRange): (WebCore::EditorClientWin::shouldShowDeleteInterface): (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled): (WebCore::EditorClientWin::isGrammarCheckingEnabled): (WebCore::EditorClientWin::spellCheckerDocumentTag): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::lastEventIsMouseUp): (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::tabsToLinks): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameView::updateBorder): (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::canPaste): (WebCore::FrameWin::issuePasteAndMatchStyleCommand): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::passSubframeEventToSubframe): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::addMessageToConsole): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::markMisspellingsInAdjacentWords): (WebCore::FrameWin::respondToChangedContents): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineWidth): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint): (WebCore::IconDatabase::isIconExpiredForIconURL): (WebCore::IconDatabase::hasEntryForIconURL): (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::Image::drawTiled): (WebCore::Image::getHBITMAP): (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::transform): (WebCore::PlatformMouseEvent::PlatformMouseEvent): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::setRect): (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::clearRequest): (WebCore::PolicyCheck::call): (WebCore::RenderThemeWin::systemFont): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::adjustMenuListStyle): (WebCore::ResourceLoader::cancel): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollPointRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::paint): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::themeChanged): (WebCore::ScrollView::convertChildToSelf): (WebCore::ScrollView::convertSelfToChild): (WebCore::ScrollView::geometryChanged): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::TextField::selectAll): (WebCore::TextField::addSearchResult): (WebCore::TextField::selectionStart): (WebCore::TextField::hasSelectedText): (WebCore::TextField::selectedText): (WebCore::TextField::setAutoSaveName): (WebCore::TextField::checksDescendantsForFocus): (WebCore::TextField::setSelection): (WebCore::TextField::setMaxResults): (WebCore::TextField::edited): (WebCore::TextField::focusPolicy): (WebCore::TextField::TextField): (WebCore::TextField::~TextField): (WebCore::TextField::setFont): (WebCore::TextField::setAlignment): (WebCore::TextField::setWritingDirection): (WebCore::TextField::maxLength): (WebCore::TextField::setMaxLength): (WebCore::TextField::text): (WebCore::TextField::setText): (WebCore::TextField::cursorPosition): (WebCore::TextField::setCursorPosition): (WebCore::TextField::setEdited): (WebCore::TextField::setReadOnly): (WebCore::TextField::setPlaceholderString): (WebCore::TextField::setColors): (WebCore::TextField::sizeForCharacterWidth): (WebCore::TextField::baselinePosition): (WebCore::TextField::setLiveSearch): (WebCore::Widget::enableFlushDrawing): (WebCore::Widget::isEnabled): (WebCore::Widget::focusPolicy): (WebCore::Widget::disableFlushDrawing): (WebCore::Widget::removeFromParent): (WebCore::Widget::lockDrawingFocus): (WebCore::Widget::unlockDrawingFocus): (WebCore::Widget::capturingMouse): (WebCore::Widget::setCapturingMouse): (WebCore::Widget::capturingTarget): (WebCore::Widget::capturingChild): (WebCore::Widget::setCapturingChild): (WebCore::Widget::convertChildToSelf): (WebCore::Widget::convertSelfToChild): (WebCore::Widget::setParent): (WebCore::Widget::parent): (WebCore::Widget::setEnabled): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect): * platform/win/WidgetWin.cpp: (WebCore::Widget::clearFocus): WebKit: * COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::loadHTMLString): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::loadDataSource): (WebFrame::didReceiveData): (WebFrame::receivedResponse): (WebFrame::receivedAllData): * COM/WebFrame.h: * COM/WebView.cpp: (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick): * WebKit.vcproj/WebKit.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17816 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
thatcher authored
<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made * editing/markup.cpp: (WebCore::createMarkup): disable the delete button so it's elements are not serialized into the markup git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17815 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
staikos authored
Making the code valgrind clean. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17814 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andersca authored
<rdar://problem/4841123> REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message * Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]): If the range passed in is null, return null. When this function was in the bridge, it would never get called with a null range when nothing was selected. Instead, the range would just have invalid boundary points. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17813 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
thatcher authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
harrison authored
<rdar://problem/4799949> REGRESSION: Crash in FrameMac::eventMayStartDrag() by clicking on a page * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventMayStartDrag): Add nil check of hitTest's result.innerNode(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17811 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
thatcher authored
<rdar://problem/4836897> Deletion rectangle disappears when multiple list items are selected Consider the container of the selection range for deletion before asking enclosingNodeOfType(). * editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17810 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rwlbuis authored
Removal of unused m_styleElement. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17808 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aroben authored
Rename the items in the ContextMenuAction enum so that they don't conflict with WebKit names. * WebCore.xcodeproj/project.pbxproj: * platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): * platform/ContextMenu.h: (WebCore::): (WebCore::ContextMenuItem::ContextMenuItem): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 15 Nov, 2006 21 commits
-
-
aroben authored
Change m_contextMenu to an OwnPtr. * WebCore.xcodeproj/project.pbxproj: * page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): * page/ContextMenuController.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17806 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aroben authored
Reviewed by Anders. Add new ContextMenuController and ContextMenuClient classes, and move context menu responsibilities from Chrome and ChromeClient to them. * WebCore.exp: * WebCore.xcodeproj/project.pbxproj: Add new files to project, and alphabetize some others. * page/Chrome.cpp: Remove context menu-related code. * page/Chrome.h: Ditto. * page/ChromeClient.h: * page/ContextMenuClient.h: Added. * page/ContextMenuController.cpp: Added. (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::~ContextMenuController): (WebCore::ContextMenuController::handleContextMenuEvent): (WebCore::ContextMenuController::contextMenuActionSelected): * page/ContextMenuController.h: Added. (WebCore::ContextMenuController::client): * page/Page.cpp: Every Page now has a ContextMenuController. (WebCore::Page::Page): * page/Page.h: Made m_dragCaretController and m_chrome objects instead of pointers to objects. (WebCore::Page::contextMenuController): * platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Removed the call to Chrome to ask the delegate to add its menu items, and moved the code from the static addDefaultItems function into this method. * platform/ContextMenu.h: (WebCore::ContextMenu::show): Added an empty method body since this method is now called from ContextMenuController (although no one calls into ContextMenuController yet, so it's OK for this to be empty). (WebCore::ContextMenu::hide): Ditto. WebKit: Reviewed by Anders. Added new WebContextMenuClient class to act as WebCore's ChromeClient, and moved context menu-related code there from WebChromeClient. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: * WebCoreSupport/WebContextMenuClient.h: Added. (WebContextMenuClient::webView): * WebCoreSupport/WebContextMenuClient.mm: Added. (WebContextMenuClient::create): (WebContextMenuClient::WebContextMenuClient): (WebContextMenuClient::ref): (WebContextMenuClient::deref): (WebContextMenuClient::addCustomContextMenuItems): * WebKit.xcodeproj/project.pbxproj: Added new files. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17805 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
thatcher authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca authored
Add null checks on the node filter, they can be null if no filter was passed to the respective create functions. * bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::mark): * bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::mark): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17803 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
oliver authored
Reviewed by Anders. Allow <embed> and <object> tags to include non-plugin content when plugins are disabled Fixes <rdar://problems/4839488> * html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded): * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded): * loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17802 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
* rendering/RenderSlider.cpp: (WebCore::RenderSlider::setPositionFromValue): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17801 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Adding MathExtras header. * rendering/RenderSlider.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17800 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
thatcher authored
<rdar://problem/4832894> Crash deleting an element inside a list while deletion rectangle is visible (compareBoundaryPoints) * Disable and hide the deletion UI for each editing command. This prevents editing commands from being affected by the deletion UI elements we insert. The deletion UI is then shown after the editing commands are completely done. * Multiple calls to DeleteButtonController's disable() needed to be paired with the same number of enable() calls before the deletion UI is enabled again. This allows for nested editing commands to be called without thrashing the deletion UI. * Make sure the the renderers are currently reflecting the latest style changes, so call updateLayoutIgnorePendingStylesheets(). * editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::DeleteButtonController): (WebCore::isDeletableElement): (WebCore::DeleteButtonController::respondToChangedSelection): check the enabled state (WebCore::DeleteButtonController::respondToChangedContents): check the enabled state (WebCore::DeleteButtonController::show): call isDeletableElement() to make sure the element is allowed (WebCore::DeleteButtonController::deleteTarget): check the enabled state * editing/DeleteButtonController.h: (WebCore::DeleteButtonController::disable): (WebCore::DeleteButtonController::enable): (WebCore::DeleteButtonController::enabled): * editing/EditCommand.cpp: (WebCore::EditCommand::apply): hide and disable the deletion UI, then show at the end (WebCore::EditCommand::unapply): ditto (WebCore::EditCommand::reapply): ditto git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17799 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Reviewed by Adam. Updating results for new slider implementation. * fast/forms/input-appearance-height-expected.checksum: * fast/forms/input-appearance-height-expected.png: * fast/forms/input-appearance-height-expected.txt: WebCore: Reviewed by Adam. New implementation of slider control. * WebCore.xcodeproj/project.pbxproj: Removed DeprecatedSlider and Slider classes, added RenderSlider class. * rendering/DeprecatedSlider.cpp: Removed. * rendering/DeprecatedSlider.h: Removed. * platform/Slider.h: Removed. * platform/mac/SliderMac.mm: Removed. * platform/win/TemporaryLinkStubs.cpp: * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoElement for thumb, PseudoSliderThumb. * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added code for "-webkit-slider-thumb". * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): * rendering/RenderStyle.cpp: (WebCore::): (WebCore::pseudoBit): * rendering/RenderStyle.h: (WebCore::RenderStyle::): * css/html4.css: Added style for input[type="range"] and input[type="range"]::-webkit-slider-thumb * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer): Create RenderSlider for input type="range" elements. (WebCore::HTMLInputElement::defaultEventHandler): Allow the renderer to forward events, and set thumb position when click occurs on the track. * page/EventHandler.cpp: Added concept of a node that will capture all mouse events. This will be used by the slider thumb, so it can continue to capture mouse move events during the drag, even though those events aren't directly over the slider. (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::setCapturingMouseEventsNode): (WebCore::EventHandler::dispatchMouseEvent): If the capturingMouseEventsNode is set, then dispatch all mouse events to that node. * page/EventHandler.h: * rendering/RenderSlider.cpp: Added. (WebCore::HTMLSliderThumbElement::isShadowNode): (WebCore::HTMLSliderThumbElement::shadowParentNode): (WebCore::HTMLSliderThumbElement::inDragMode): Keeps track of whether or not the thumb is in drag mode. (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement): (WebCore::HTMLSliderThumbElement::defaultEventHandler): Handles positioning of slider thumb during drag. (WebCore::RenderSlider::RenderSlider): (WebCore::RenderSlider::~RenderSlider): (WebCore::RenderSlider::baselinePosition): (WebCore::RenderSlider::calcMinMaxWidth): (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle): (WebCore::RenderSlider::layout): Positions the thumb to be centered on the track. (WebCore::RenderSlider::updateFromElement): (WebCore::RenderSlider::mouseEventIsInThumb): (WebCore::RenderSlider::setValueForPosition): (WebCore::RenderSlider::setPositionFromValue): (WebCore::RenderSlider::positionForOffset): (WebCore::RenderSlider::valueChanged): (WebCore::RenderSlider::currentPosition): (WebCore::RenderSlider::setCurrentPosition): (WebCore::RenderSlider::trackSize): (WebCore::RenderSlider::forwardEvent): (WebCore::RenderSlider::inDragMode): * rendering/RenderSlider.h: Added. (WebCore::RenderSlider::renderName): * rendering/RenderTheme.cpp: Added drawing code for slider track and thumb. (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::adjustSliderTrackStyle): (WebCore::RenderTheme::adjustSliderThumbStyle): * rendering/RenderTheme.h: (WebCore::RenderTheme::paintSliderTrack): (WebCore::RenderTheme::paintSliderThumb): * rendering/RenderThemeMac.h: * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::TrackGradientInterpolate): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::adjustSliderTrackStyle): (WebCore::RenderThemeMac::adjustSliderThumbStyle): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17798 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
bdakin authored
Oops! Forgot to add this! * platform/mac/ContextMenuMac.mm: Added. (-[MenuTarget forwardContextMenuAction:initWithContextMenu:WebCore::]): (-[MenuTarget WebCore::]): (-[MenuTarget setMenu:WebCore::]): (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): (ContextMenu::appendItem): (ContextMenu::itemCount): (ContextMenu::insertItem): (ContextMenu::setPlatformMenuDescription): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17797 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
bdakin authored
Reviewed by Adam and Beth. Initial cut at pushing Context Menus into WebCore. Nobody actually calls this code just yet. * WebCore.exp: * WebCore.xcodeproj/project.pbxproj: * page/Chrome.cpp: (WebCore::Chrome::addCustomContextMenuItems): Use the chrome to call into addContextMenuItems on the UIDelegate. * page/Chrome.h: * page/ChromeClient.h: * platform/ContextMenu.cpp: Added. (WebCore::addDefaultItems): (WebCore::ContextMenu::populate): * platform/ContextMenu.h: Added. (WebCore::): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::hitTestResult): (WebCore::ContextMenu::platformMenuDescription): WebKit: Reviewed by Adam & Beth. WebKit side of first cut at engine context menus. Use the client to call into the UIDelegate. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addCustomContextMenuItems): * WebKit.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17796 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
beidson authored
Quick change of files to ObjC++ for BF cache re-write * History/WebBackForwardList.m: Removed. * History/WebBackForwardList.mm: Added. * History/WebHistoryItem.m: Removed. * History/WebHistoryItem.mm: Added. * WebKit.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17795 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
- Fix for <rdar://problem/4780306> REGRESSION: clicking in textarea does not set selection at PunBB.org * css/html4.css: Removed "-webkit-user-select: ignore" for labels. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17794 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
beidson authored
SPI addition * WebView/WebFrame.mm: (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): * WebView/WebFrameInternal.h: * WebView/WebFramePrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17792 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
beidson authored
<rdar://problem/4838729> - Replace mistakenly removed SPI * WebView/WebHTMLView.m: (-[WebHTMLView _handleAutoscrollForMouseDragged:]): * WebView/WebHTMLViewPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17788 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
thatcher authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
harrison authored
<rdar://problem/4836034> REGRESSION: Hang while spell-checking (advanceToNextMisspelling) Test: * manual-tests/keep_spelling_markers.html: Updated to include checking for this bug. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): it.advance() even when current string is a single space. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17786 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
beidson authored
Backing out macro expansion * WebCore.xcodeproj/project.pbxproj: * html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName): * ksvg2/scripts/make_names.pl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17785 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
harrison authored
<rdar://problem/4770453> VO not honoring secure edit fields in web pages The remaining problem was the password fields would return their contents even though they did not advertise that they could. Apparently, VoiceOver does not read the ads. * bridge/mac/WebCoreAXObject.mm: (isPasswordFieldElement): (-[WebCoreAXObject isPasswordField]): (-[WebCoreAXObject textMarkerForVisiblePosition:]): (-[WebCoreAXObject accessibilityAttributeValue:]): (-[WebCoreAXObject doAXStringForRange:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17784 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
lamadio authored
Reviewed by Darin Adler, Maciej Stachowiak Cleanup: Expanded macros in generated files * html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName): * ksvg2/scripts/make_names.pl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17783 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andersca authored
Use Vector instead of DeprecatedPtrList. * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): * editing/BreakBlockquoteCommand.cpp: * rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutline): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
