1. 19 Jul, 2011 20 commits
    • steveblock@google.com's avatar
      REGRESSION (r82194): jvalueToJavaValue() does not correctly set length of String property · 96013927
      steveblock@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64730
      
      Reviewed by Alexey Proskuryakov.
      
      Covered by existing tests.
      
      * bridge/jni/v8/JNIUtilityPrivate.cpp:
      (JSC::Bindings::jvalueToJavaValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96013927
    • rniwa@webkit.org's avatar
      [chromium] rebaseline Chromium results after r91249 . · 34866095
      rniwa@webkit.org authored
      Unreviewed.
      
      Patch by Jeremy Moskovich <jeremy@chromium.org> on 2011-07-19
      
      * platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png: Added.
      * platform/chromium-win/fast/speech/input-text-speechbutton-expected.txt: Added.
      * platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png: Added.
      * platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34866095
    • yurys@chromium.org's avatar
      [Chromium] Web Inspector: add sanity test for shared worker inspector · d64d46dd
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64799
      
      Reviewed by Pavel Feldman.
      
      * src/js/Tests.js:
      (.TestSuite.prototype.testSharedWorker):
      (.TestSuite.prototype.evaluateInConsole_):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d64d46dd
    • weinig@apple.com's avatar
      Check in Leopard specific results for Selectors 3 tests. · b1cd1c56
      weinig@apple.com authored
      * platform/mac-leopard/css3/selectors3: Added.
      * platform/mac-leopard/css3/selectors3/html: Added.
      * platform/mac-leopard/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt.
      * platform/mac-leopard/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt.
      * platform/mac-leopard/css3/selectors3/xhtml: Added.
      * platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-174a-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-174a-expected.txt.
      * platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-174b-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-174b-expected.txt.
      * platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
      * platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
      * platform/mac-leopard/css3/selectors3/xml: Added.
      * platform/mac-leopard/css3/selectors3/xml/css3-modsel-174a-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-174a-expected.txt.
      * platform/mac-leopard/css3/selectors3/xml/css3-modsel-174b-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-174b-expected.txt.
      * platform/mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
      * platform/mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1cd1c56
    • vitalyr@chromium.org's avatar
      2011-07-19 Vitaly Repeshko <vitalyr@chromium.org> · 3391456e
      vitalyr@chromium.org authored
              [V8] Don't put CSSRuleLists in object groups.
              https://bugs.webkit.org/show_bug.cgi?id=64798
      
              Reviewed by Pavel Feldman.
      
              Retention of CSSRuleLists should be implemented using hidden
              references from holder objects. By putting lists in groups we
              artificially extend their lifetimes much more than necessary.
      
              * bindings/v8/V8GCController.cpp:
              (WebCore::GrouperVisitor::visitDOMWrapper):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3391456e
    • gyuyoung.kim@samsung.com's avatar
      [EFL] Add ewk_network.cpp|h files. · 235d0a8a
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=63315
      
      Source/WebCore:
      
      Enable setOnLine(bool) on EFL port as well as Android and Chromium.
      
      Reviewed by Antonio Gomes.
      
      * platform/network/NetworkStateNotifier.cpp:
      * platform/network/NetworkStateNotifier.h:
      
      Source/WebKit/efl:
      
      ewk_network.cpp|h files are added to ewk in order to support APIs related to networking.
      In addition, ewk_network_state_notifier_online_set() is added to ewk_network.cpp in order
      to notify NetworkStateNotifier of network status.
      
      Reviewed by Antonio Gomes.
      
      * CMakeListsEfl.txt:
      * ewk/EWebKit.h:
      * ewk/ewk_network.cpp: Added.
      (ewk_network_proxy_uri_set):
      (ewk_network_proxy_uri_get):
      (ewk_network_state_notifier_online_set):
      * ewk/ewk_network.h:
      * ewk/ewk_settings.cpp:
      * ewk/ewk_settings.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      235d0a8a
    • kov@webkit.org's avatar
      [GTK] Google Calendar thinks we're mobile · adab7955
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63994
      
      Patch by Gustavo Noronha Silva  <gns@gnome.org> on 2011-07-11
      Reviewed by Xan Lopez.
      
      Further special-case Google Calendar, for it thinks WebKit+Linux
      means mobile, so we also have to spoof the OS.
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::userAgent): use the new WebKitGTK+
      private API that centralizes the logic now.
      * tests/testwebsettings.c: Add tests to make sure the Google
      special-cases only apply for the expected domains and when quirks
      special-casing is enabled.
      (test_non_quirky_user_agents):
      (test_webkit_web_settings_user_agent):
      * webkit/webkitwebsettings.cpp:
      (webkitUserAgent): make it static.
      (safariUserAgent): returns a fake Safari in Mac OS X User-Agent.
      (initializeDomainsList): moved from FrameLoaderClientGtk.
      (isGoogleDomain):ditto.
      (isGoogleCalendar): ditto.
      (userAgentForURL): ditto.
      (webkitWebSettingsUserAgentForUri): centralize the whole
      user agent spoofing logic in this new private API that can be used
      by the browser to know what's going to happen for a specific URI
      and also allows our API testing.
      * webkit/webkitwebsettingsprivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adab7955
    • loislo@chromium.org's avatar
      Web Inspector: implement import/export for timeline data. · 273992bc
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64601
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Test: inspector/timeline/timeline-load.html
      
      * English.lproj/localizedStrings.js:
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::FrontendMenuProvider::contextMenuItemSelected):
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel):
      (WebInspector.TimelinePanel.prototype._createFileSelector):
      (WebInspector.TimelinePanel.prototype._contextMenu):
      (WebInspector.TimelinePanel.prototype._exportToFile):
      (WebInspector.TimelinePanel.prototype._importFromFile):
      (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
      (WebInspector.TimelinePanel.prototype._clearPanel):
      (WebInspector.TimelineModel):
      (WebInspector.TimelineModel.prototype._addRecord):
      (WebInspector.TimelineModel.prototype._importNextChunk):
      (WebInspector.TimelineModel.prototype._importFromFile):
      (WebInspector.TimelineModel.prototype._importFromFile.onError):
      (WebInspector.TimelineModel.prototype._exportToFile):
      (WebInspector.TimelineModel.prototype._reset):
      * inspector/front-end/utilities.js:
      ():
      
      LayoutTests:
      
      * inspector/timeline/timeline-load-expected.txt: Added.
      * inspector/timeline/timeline-load.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      273992bc
    • loki@webkit.org's avatar
      Add missing expected file after r91191 · 981a7b7f
      loki@webkit.org authored
      * platform/qt/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      981a7b7f
    • vsevik@chromium.org's avatar
      Web Inspector: Rename agentIdentifierPrefix to processId, move out from page agent and make static. · 3788fea0
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64729
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * inspector/IdentifiersFactory.cpp: Added.
      (WebCore::IdentifiersFactory::createIdentifier):
      * inspector/IdentifiersFactory.h: Added.
      (WebCore::IdentifiersFactory::setProcessId):
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::setProcessId):
      * inspector/InspectorController.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::frameId):
      (WebCore::InspectorPageAgent::loaderId):
      * inspector/InspectorPageAgent.h:
      
      Source/WebKit/chromium:
      
      * public/WebDevToolsAgent.h:
      * src/WebDevToolsAgentImpl.cpp:
      (WebKit::WebDevToolsAgentImpl::setAgentIdentifierPrefix):
      (WebKit::WebDevToolsAgentImpl::setProcessId):
      * src/WebDevToolsAgentImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3788fea0
    • jeremy@chromium.org's avatar
      Fix microphone icon placement in speech input control for dir=rtl. · 37eec66b
      jeremy@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64668
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      Modify default stylesheet to propagate dir=rtl from the outer input
      control to the shadow DOM container.  This makes the microphone
      icon appear on the left for dir=rtl, which is the desired behavior.
      
      Test: fast/speech/speech-bidi-rendering.html
      
      * css/html.css:
      (input[x-webkit-speech][dir=rtl]::-webkit-textfield-decoration-container):
      
      LayoutTests:
      
      Added test that verifies placement of microphone icon for dir=rtl.
      
      * fast/speech/speech-bidi-rendering.html: Added.
      * platform/mac/fast/speech/speech-bidi-rendering-expected.png: Added.
      * platform/mac/fast/speech/speech-bidi-rendering-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37eec66b
    • alexis.menard@openbossa.org's avatar
      [Qt][WK2] Make QDesktopWebView::navigationAction method usable in QML. · cc2dc4e1
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64690
      
      Make the API usable with QML by declaring what's needed
      with the macros.
      
      Reviewed by Benjamin Poulain.
      
      * UIProcess/API/qt/qdesktopwebview.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc2dc4e1
    • commit-queue@webkit.org's avatar
      [EFL] Account for the invalid pointer case in WebCore::screenRect() · 2d18fb44
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64543
      
      Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-19
      Reviewed by Antonio Gomes.
      
      Fix a regression introduced in r88245: it assumes the pointer passed
      to screenRect() is always valid.
      fast/frames/crash-removed-iframe.html proves this is not always true,
      so we need to do some sanity check on the pointer before using it.
      No new tests as this has been caught by the current test suite.
      
      * platform/efl/PlatformScreenEfl.cpp:
      (WebCore::screenRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d18fb44
    • yutak@chromium.org's avatar
      Unreviewed. Edit Chromium test expectation for... · d18ff195
      yutak@chromium.org authored
      Unreviewed. Edit Chromium test expectation for http/tests/websocket/tests/hybi/reserved-opcodes.html.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d18ff195
    • eric@webkit.org's avatar
      new-run-webkit-tests should support --leaks · 8bf898e1
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63832
      
      Reviewed by Dirk Pranke.
      
      This may not be sufficient to actually transition over the leaks bot,
      but this is a huge step in the right direction.
      
      I had to make parse-malloc-history understand being passed more than
      one file (to avoid the silly cat | nonsense in old-run-webkit-tests).
      
      I removed some dead code relating to previous iterations of our crash detection.
      
      I created a new class "LeakDetector" to encapsulate all this logic.
      Eventually we should consider pulling that class out of mac.py and
      sharing with other ports.  However given that ORWT has had
      --leaks support on Mac for almost 7 years and no other port has added
      it, leaves me to believe we're in no rush to move LeakDetector.
      
      I've tested --leaks locally.  I suspect there are more bugs to shake out
      but it seems to work well enough to start.
      
      I also added support for --guard-malloc, but have not tested it much.  It
      should be viewed as experimental at this time.
      
      I also fixed various os.path uses to self._filesystem as I was reading
      through the various files to understand how best to fix this bug.
      
      * Scripts/old-run-webkit-tests:
      (parseLeaksandPrintUniqueLeaks):
      * Scripts/parse-malloc-history:
      (main):
      * Scripts/webkitpy/common/system/crashlogs.py:
      * Scripts/webkitpy/layout_tests/controllers/manager.py:
      * Scripts/webkitpy/layout_tests/controllers/worker.py:
      * Scripts/webkitpy/layout_tests/port/base.py:
      * Scripts/webkitpy/layout_tests/port/chromium_win.py:
      * Scripts/webkitpy/layout_tests/port/gtk.py:
      * Scripts/webkitpy/layout_tests/port/mac.py:
      * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
      * Scripts/webkitpy/layout_tests/port/server_process.py:
      * Scripts/webkitpy/layout_tests/port/webkit.py:
      * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bf898e1
    • commit-queue@webkit.org's avatar
      Patch by Robin Qiu <robin.qiu@torchmobile.com.cn> on 2011-07-19 · b4abfc88
      commit-queue@webkit.org authored
      Reviewed by Antonio Gomes.
      
      ScrollBar should initialize current position in constructor.
      https://bugs.webkit.org/show_bug.cgi?id=39284
      
      When ScrollBar is created, m_currentPos should be initialized to
      m_scrollableArea's current scrollPosition. Because scrollbars may
      be created after the content of m_scrollableArea has been scrolled.
      
      Source/WebCore:
      
      Test: scrollbars/scrollbar-initial-position.html
      
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::Scrollbar):
      
      LayoutTests:
      
      * scrollbars/scrollbar-initial-position-expected.png: Added.
      * scrollbars/scrollbar-initial-position-expected.txt: Added.
      * scrollbars/scrollbar-initial-position.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4abfc88
    • yutak@chromium.org's avatar
      WebSocket: Implement hybi framing · 6a2ece20
      yutak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64522
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Implement WebSocket framing protocol which is mainly described in
      <http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-4> and
      <http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-6>.
      
      Hybi protocol introduces a new frame format which is drastically different from
      the old one. Notable differences are:
      - Binary data support.
      - Fragmentation support: a single message can be fragmented to multiple frames.
      - Ping-pong support.
      - Masking: frame content of a client must be masked to prevent cross-protocol attacks.
      
      This patch covers the following features:
      - Send a pong frame when a ping frame is received.
      - Receive fragmented frames.
      - Receive masked frames. (Servers do not have to mask frames, but they may if they wish.)
      
      The following features are NOT implemented yet:
      - Send or receive binary messages.
      - Send a ping message.
      - Send fragmented frames. (It is unclear whether this is necessary.)
      - Rewrite the frame content by WebSocket protocol extensions (like frame compression).
      
      New tests: http/tests/websocket/tests/hybi/broken-utf8.html
                 http/tests/websocket/tests/hybi/fragmented-control-frame.html
                 http/tests/websocket/tests/hybi/fragmented-frames.html
                 http/tests/websocket/tests/hybi/interleaved-fragments.html
                 http/tests/websocket/tests/hybi/long-control-frame.html
                 http/tests/websocket/tests/hybi/masked-frames.html
                 http/tests/websocket/tests/hybi/pong.html
                 http/tests/websocket/tests/hybi/reserved-bits.html
                 http/tests/websocket/tests/hybi/reserved-opcodes.html
                 http/tests/websocket/tests/hybi/too-long-payload.html
      
      * websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::WebSocketChannel):
      (WebCore::WebSocketChannel::send):
      The original content of send() was moved to a private method sendFrameHixie76().
      (WebCore::WebSocketChannel::fail):
      Stop handling incoming data after the WebSocket connection is failed.
      It was unclear to me whether we should do the same thing for hixie-76 connection;
      for now, I kept the original behavior.
      (WebCore::WebSocketChannel::processBuffer):
      (WebCore::WebSocketChannel::resumeTimerFired):
      (WebCore::WebSocketChannel::startClosingHandshake):
      (WebCore::WebSocketChannel::closingTimerFired):
      (WebCore::WebSocketChannel::parseFrame):
      (WebCore::WebSocketChannel::processFrame):
      (WebCore::WebSocketChannel::processFrameHixie76):
      (WebCore::WebSocketChannel::sendFrame):
      (WebCore::WebSocketChannel::sendFrameHixie76):
      * websockets/WebSocketChannel.h:
      (WebCore::WebSocketChannel::isNonControlOpCode):
      (WebCore::WebSocketChannel::isControlOpCode):
      (WebCore::WebSocketChannel::isReservedOpCode):
      
      LayoutTests:
      
      Fix existing tests so they match the new frame format, and add tests for the new frame types
      and error conditions related to the new frame format.
      
      Unskip hybi tests on mac, win and chromium. Other ports (wk2, qt and gtk) still skip these tests
      because they do not support changing the value of "WebKitHixie76WebSocketProtocolEnabled"
      preference key via layoutTestController.overridePreferences() yet.
      
      * http/tests/websocket/tests/hybi/broken-utf8-expected.txt: Added.
      * http/tests/websocket/tests/hybi/broken-utf8.html: Added.
      * http/tests/websocket/tests/hybi/broken-utf8_wsh.py: Added.
      * http/tests/websocket/tests/hybi/client-close-expected.txt:
      * http/tests/websocket/tests/hybi/client-close.html:
      The format of a close frame has been changed. Currently, we do not include any payload
      in a close frame, thus it must start with "\x88\x80" (see section 4.1 of hybi-10
      specification for more details).
      * http/tests/websocket/tests/hybi/client-close_wsh.py:
      * http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt: Added.
      * http/tests/websocket/tests/hybi/fragmented-control-frame.html: Added.
      * http/tests/websocket/tests/hybi/fragmented-control-frame_wsh.py: Added.
      * http/tests/websocket/tests/hybi/fragmented-frames-expected.txt: Added.
      * http/tests/websocket/tests/hybi/fragmented-frames.html: Added.
      * http/tests/websocket/tests/hybi/fragmented-frames_wsh.py: Added.
      * http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt: Added.
      * http/tests/websocket/tests/hybi/interleaved-fragments.html: Added.
      * http/tests/websocket/tests/hybi/interleaved-fragments_wsh.py: Added.
      * http/tests/websocket/tests/hybi/long-control-frame-expected.txt: Added.
      * http/tests/websocket/tests/hybi/long-control-frame.html: Added.
      * http/tests/websocket/tests/hybi/long-control-frame_wsh.py: Added.
      * http/tests/websocket/tests/hybi/masked-frames-expected.txt: Added.
      * http/tests/websocket/tests/hybi/masked-frames.html: Added.
      * http/tests/websocket/tests/hybi/masked-frames_wsh.py: Added.
      * http/tests/websocket/tests/hybi/pong-expected.txt: Added.
      * http/tests/websocket/tests/hybi/pong.html: Added.
      * http/tests/websocket/tests/hybi/pong_wsh.py: Added.
      * http/tests/websocket/tests/hybi/reserved-bits-expected.txt: Added.
      * http/tests/websocket/tests/hybi/reserved-bits.html: Added.
      * http/tests/websocket/tests/hybi/reserved-bits_wsh.py: Added.
      * http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt: Added.
      * http/tests/websocket/tests/hybi/reserved-opcodes.html: Added.
      * http/tests/websocket/tests/hybi/reserved-opcodes_wsh.py: Added.
      * http/tests/websocket/tests/hybi/send2_wsh.py:
      Send two text frames at once.
      * http/tests/websocket/tests/hybi/too-long-payload-expected.txt: Added.
      * http/tests/websocket/tests/hybi/too-long-payload.html: Added.
      * http/tests/websocket/tests/hybi/too-long-payload_wsh.py: Added.
      * platform/chromium/test_expectations.txt:
      Derive test expectations of hixie76 tests, because these tests are likely to behave
      the same way as hixie76 tests. Will be checked later whether they really do.
      * platform/mac/Skipped:
      * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a2ece20
    • zimmermann@webkit.org's avatar
      2011-07-19 Nikolas Zimmermann <nzimmermann@rim.com> · 877dc99f
      zimmermann@webkit.org authored
              REGRESSION (r88913): Preview in Safari's snippet editor has a fixed height instead of filling the entire pane
              https://bugs.webkit.org/show_bug.cgi?id=64059
      
              REGRESSION (r88913): <object> has wrong computed height
              https://bugs.webkit.org/show_bug.cgi?id=62769
      
              Reviewed by Rob Buis.
      
              Add new layout test in fast/css covering both bugs.
              Update svg/zoom/page results (this is a progression, but the test itself remains broken, see comment inline).
      
              * fast/css/replaced-element-implicit-size.html: Added.
              * platform/mac/fast/css/replaced-element-implicit-size-expected.png: Added.
              * platform/mac/fast/css/replaced-element-implicit-size-expected.txt: Added.
              * platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png:
              * platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt:
      
      2011-07-19  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              REGRESSION (r88913): Preview in Safari's snippet editor has a fixed height instead of filling the entire pane
              https://bugs.webkit.org/show_bug.cgi?id=64059
      
              REGRESSION (r88913): <object> has wrong computed height
              https://bugs.webkit.org/show_bug.cgi?id=62769
      
              Reviewed by Rob Buis.
      
              Fix misinterpretation of CSS 2.1 - "10.5 Content height: the 'height' property".
              It says "If the height of the containing block is not specified explicitelz (i.e. it depends on the
              content height), and this element is not absolutely positioned, the value computes to 'auto'".
      
              Checking whether the containing block height depends on the content height is not equal to checking
              whether the height property is set on the containing block, there are other ways to implicitly specify
              the height by setting top & bottom. Fix that by checking whether the containing block has a height
              property or top & bottom set.
      
              While I was at it, make computeReplacedLogicalWidth/Height a bit more explicit to make it easier to compare
              the code with the spec quoatations - this doesn't change the functionality only the readability.
              
              Test: fast/css/replaced-element-implicit-size.html
      
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::computeReplacedLogicalWidth): Cleanup comment, make code more explicit.
              (WebCore::RenderReplaced::logicalHeightIsAuto): Add helper method used by computeReplacedLogicalHeight.
              (WebCore::RenderReplaced::computeReplacedLogicalHeight): Fix height=auto detection.
              * rendering/RenderReplaced.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      877dc99f
    • abarth@webkit.org's avatar
      garden-o-matic should have a "Triage Failures" button for iterating over failures · e3b1ada7
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64769
      
      Reviewed by Eric Seidel.
      
      This patch adds some global static state and refactors things a bit so
      that we can iterate over all the failures in the details pane.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
          - Add a generic callback iterator to iterate through a series of
            callbacks. We use this to iterate through the failures we want to
            display the details of.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
          - Add a toolbar for the results summary and change the buttons to
            be real buttons.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
          - Make the detail pane 75% of the window.
          - Make the buttons pretty.
          - Allow the failure type badges to apply to the details pane as well.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
          - Restructure how we bring up the details pane so we can iterate
            through a bunch of failures.
          - Remove the transition between results details because it's
            annoying when you want to click through a bunch of failures.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
          - Add some more structure to the title bar for the results details
            so it's clearer which results we're currently displaying.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3b1ada7
    • abarth@webkit.org's avatar
      garden-o-matic should live update as conditions change on the buildbot · 65ecad21
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64646
      
      Reviewed by Eric Seidel.
      
      This patch causes the garden-o-matic display to update every 10 minutes
      to show the latest failures.  This patch required a moderately large
      refactoring of main.js to make the display incremental instead of
      all-at-once.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65ecad21
  2. 18 Jul, 2011 20 commits
    • aestes@apple.com's avatar
      Solar Walk app-specific hack accidentally strips stylesheets from the document. · 27797ba6
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64777
      
      Reviewed by Adam Barth.
      
      Solar Walk uses a self-closed title tag in its documents ("<title />").
      The HTML5 parser does not recognize this as a valid self-closing tag,
      so it treats the remainder of the document as title text.
      
      We work around this in WebKit by injecting a script that calls
      document.write() on the contents of document.title, thereby restoring
      the contents of the document. Unfortunately this overwrote several
      <style> tags that existed before the <title>, thereby causing the
      document to not have the intended styling.
      
      Fix this by having the injected script concatenate document.title to
      the document instead of overwriting it during document.write(). We can
      also take the opportunity to remove document.title since it does not
      contain useful information.
      
      * Misc/SolarWalkQuirksUserScript.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27797ba6
    • rniwa@webkit.org's avatar
      Fix Chromium test expectations. · 6aebd5e3
      rniwa@webkit.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6aebd5e3
    • rniwa@webkit.org's avatar
      REGRESSION(91209?): fast/css/custom-font-xheight.html is failing on Leopard · 724bf274
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64767
      
      Add a runtime check for font cascading optimization.
      
      It's a constant value in Mac port so hopefully gcc will constant-propagate the value
      and eliminate the function altogether.
      
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore::canSetCascadeListForCustomFont): Added.
      (WebCore::FontPlatformData::ctFont):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      724bf274
    • rniwa@webkit.org's avatar
      Chromium test expectation update after r91229. · 63018767
      rniwa@webkit.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63018767
    • morrita@google.com's avatar
      .: [ShadowContentElement] forwarded node should be able to access its hosting content element. · d534c6d8
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      Added GTK symbols for new window.internals methods.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      - Introduced ShadowInclusionSet to manage included nodes to its includer content element.
        ShadowInclusionSet instance is owned by ShadowRoot.
      - Updated the set on inclusion list changes.
      - Used the set to retrieve the content element of NodeRenderingContext.
      
      There are also related refactoring and cleanup:
      - Renamed NodeRenderingContext::m_contentElement to m_includer
      - ShadowContentSelector::m_activeElement is no longer used, thus removed.
      
      Test: fast/dom/shadow/content-element-includer.html
      
      * WebCore.exp.in:
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      (WebCore::NodeRenderingContext::nextRenderer):
      (WebCore::NodeRenderingContext::previousRenderer):
      * dom/NodeRenderingContext.h:
      (WebCore::NodeRenderingContext::includer):
      * dom/ShadowContentElement.cpp:
      (WebCore::removeFromSet):
      (WebCore::addToSet):
      (WebCore::ShadowContentElement::attach):
      (WebCore::ShadowContentElement::detach):
      * dom/ShadowContentElement.h:
      (WebCore::ShadowInclusionSet::add):
      (WebCore::ShadowInclusionSet::remove):
      (WebCore::ShadowInclusionSet::isEmpty):
      (WebCore::ShadowInclusionSet::Translator::hash):
      (WebCore::ShadowInclusionSet::Translator::equal):
      (WebCore::ShadowInclusionSet::Hash::hash):
      (WebCore::ShadowInclusionSet::Hash::equal):
      (WebCore::ShadowInclusionSet::find):
      * dom/ShadowContentSelector.cpp:
      (WebCore::ShadowContentSelector::ShadowContentSelector):
      (WebCore::ShadowContentSelector::selectInclusion):
      * dom/ShadowContentSelector.h:
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::~ShadowRoot):
      (WebCore::ShadowRoot::includerFor):
      (WebCore::ShadowRoot::inclusions):
      (WebCore::ShadowRoot::ensureInclusions):
      * dom/ShadowRoot.h:
      (WebCore::toShadowRoot):
      * testing/Internals.cpp:
      (WebCore::Internals::includerFor):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      Exported additional symbols for window.internals object.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      - Added a new test.
      - Updated expectations. This change make ShadowContentElement availability on NodeRenderingContext
        more strict. that makes some redundant node disappeared.
      
      * fast/dom/shadow/content-element-includer-expected.txt: Added.
      * fast/dom/shadow/content-element-includer.html: Added.
      * platform/chromium-win/fast/html/details-nested-2-expected.txt:
      * platform/gtk/fast/html/details-nested-2-expected.txt:
      * platform/mac/fast/html/details-nested-2-expected.txt:
      * platform/qt/fast/html/details-nested-2-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d534c6d8
    • barraclough@apple.com's avatar
      Add a failing test expectation for object-prototype-properties.html after r91225. · 6ec662b6
      barraclough@apple.com authored
      Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-07-18
      
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ec662b6
    • commit-queue@webkit.org's avatar
      Tab Atkins is not in committers.py (as a non-committer) · 8146dd49
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64770
      
      Patch by Tab Atkins <jackalmage@gmail.com> on 2011-07-18
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8146dd49
    • dino@apple.com's avatar
      2011-07-18 Dean Jackson <dino@apple.com> · ef970381
      dino@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=64742
              Expose WebPreferences for media playback requiring user gestures and inline playback
      
              Reviewed by Simon Fraser.
      
              Media playback already tested if it should require user gestures, but
              no setting was ever exposed to clients. Also, some ports only allow media
              playback to be fullscreen, so exposing a new setting for them.
      
              Two new WebPreferences: MediaPlaybackRequiresUserGesture and
              MediaPlaybackAllowsInline.
      
          WebCore:
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::HTMLMediaElement): Examine the new Setting
              for user gestures.
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h: Two new settings.
              (WebCore::Settings::setMediaPlaybackRequiresUserGesture):
              (WebCore::Settings::mediaPlaybackRequiresUserGesture):
              (WebCore::Settings::setMediaPlaybackAllowsInline):
              (WebCore::Settings::mediaPlaybackAllowsInline):
      
          WebKit/mac:
      
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              (-[WebPreferences mediaPlaybackRequiresUserGesture]):
              (-[WebPreferences setMediaPlaybackRequiresUserGesture:]):
              (-[WebPreferences mediaPlaybackAllowsInline]):
              (-[WebPreferences setMediaPlaybackAllowsInline:]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChanged:]):
      
          WebKit/win:
      
              * Interfaces/IWebPreferencesPrivate.idl:
              * WebPreferenceKeysPrivate.h:
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings):
              (WebPreferences::setMediaPlaybackRequiresUserGesture):
              (WebPreferences::mediaPlaybackRequiresUserGesture):
              (WebPreferences::setMediaPlaybackAllowsInline):
              (WebPreferences::mediaPlaybackAllowsInline):
              * WebPreferences.h:
              * WebView.cpp:
              (WebView::notifyPreferencesChanged):
      
          WebKit2:
      
              * Shared/WebPreferencesStore.h:
              * UIProcess/API/C/WKPreferences.cpp:
              (WKPreferencesSetMediaPlaybackRequiresUserGesture):
              (WKPreferencesGetMediaPlaybackRequiresUserGesture):
              (WKPreferencesSetMediaPlaybackAllowsInline):
              (WKPreferencesGetMediaPlaybackAllowsInline):
              * UIProcess/API/C/WKPreferencesPrivate.h:
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::updatePreferences):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef970381
    • rniwa@webkit.org's avatar
      Leopard build fix after r91229. · d9b04cf4
      rniwa@webkit.org authored
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore::FontPlatformData::ctFont):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9b04cf4
    • rniwa@webkit.org's avatar
      Add a failing test expectation for object-prototype-properties.html after r91225. · 460e4252
      rniwa@webkit.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      460e4252
    • mitz@apple.com's avatar
      REGRESSION(91209?): fast/css/custom-font-xheight.html is failing on Leopard · ad4bbbaa
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64767
      
      Reviewed by Sam Weinig.
      
      * platform/graphics/Font.h:
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore::FontPlatformData::ctFont): Undo the cascade list optimization on Leopard for custom
      fonts, because adding a cascade list apparently breaks the font.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad4bbbaa
    • mdelaney@apple.com's avatar
      Remove drawsUsingCopy now that all ports handle the copying · 570f3fcd
      mdelaney@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64768
              
      Introduced in https://bugs.webkit.org/show_bug.cgi?id=43507, ImageBuffer::drawsUsingCopy
      was used to know whether or not an ImageBuffer should be explicitly copied before being
      painted into a context (as was used in HTMLCanvasElement::paint). All platforms now
      handle the logic of copying or not in their ImageBuffer::draw() implementations, so
      drawsUsingCopy() is no longer needed. This patch removes it.
      
      Reviewed by Dan Bernstein.
      
      No new tests; does not affect behavior.
      
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::paint):
      * platform/graphics/ImageBuffer.h:
      (WebCore::ImageBuffer::isAccelerated):
      * platform/graphics/cairo/ImageBufferCairo.cpp:
      * platform/graphics/cg/ImageBufferCG.cpp:
      * platform/graphics/qt/ImageBufferQt.cpp:
      * platform/graphics/skia/ImageBufferSkia.cpp:
      * platform/graphics/wince/ImageBufferWinCE.cpp:
      * platform/graphics/wx/ImageBufferWx.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      570f3fcd
    • vsevik@chromium.org's avatar
      Web Inspector: [REGRESSION] Resource preserving fails when frameNavigated... · 668ddbfa
      vsevik@chromium.org authored
      Web Inspector: [REGRESSION] Resource preserving fails when frameNavigated event is dispatched on NetworkPanel.
      https://bugs.webkit.org/show_bug.cgi?id=64748
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkLogView.prototype._frameNavigated):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      668ddbfa
    • commit-queue@webkit.org's avatar
      DFG JIT does not optimize strict equality as effectively as the old JIT does. · 6efa2caf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64759
      
      Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
      Reviewed by Gavin Barraclough.
      
      This adds a more complete set of strict equality optimizations.  If either
      operand is known numeric, then the code reverts to the old style of optimizing
      (first try integer comparison).  Otherwise it uses the old JIT's trick of
      first simultaneously checking if both operands are either numbers or cells;
      if not then a fast path is taken.
      
      * dfg/DFGJITCodeGenerator.cpp:
      (JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
      (JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
      (JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):
      * dfg/DFGJITCodeGenerator.h:
      * dfg/DFGNonSpeculativeJIT.cpp:
      (JSC::DFG::NonSpeculativeJIT::compile):
      * dfg/DFGOperations.cpp:
      * dfg/DFGOperations.h:
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6efa2caf
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=64760 · 1fbf1db9
      barraclough@apple.com authored
      DFG JIT - Should be able to compile program code.
      
      Reviewed by Geoff Garen.
      
      Add support for op_end, hooks to compile program code in Executable.cpp.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
          - Add support for op_end
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::compileEntry):
      (JSC::DFG::JITCompiler::compileBody):
      (JSC::DFG::JITCompiler::link):
          - Added, separate out steps of compileFunction.
      (JSC::DFG::JITCompiler::compile):
          - Added, compile program code.
      (JSC::DFG::JITCompiler::compileFunction):
          - Sections separated out to helper functions.
      * dfg/DFGJITCompiler.h:
      (JSC::DFG::JITCompiler::JITCompiler):
          - Added m_exceptionCheckCount.
      * runtime/Executable.cpp:
      (JSC::tryDFGCompile):
      (JSC::tryDFGCompileFunction):
      (JSC::ProgramExecutable::compileInternal):
      (JSC::FunctionExecutable::compileForCallInternal):
          - Renamed tryDFGCompile to tryDFGCompileFunction, added tryDFGCompile to compile program code.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fbf1db9
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=64678 · 921ec019
      barraclough@apple.com authored
      Fix bugs in Object.prototype this handling.
      
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore: 
      
      undefined/null this values should throw TypeErrors, not convert to the global object,
      also, to toLocaleString should be calling the ToObject & invoking the object's toString
      function, even for values that are already strings.
      
      * runtime/ObjectPrototype.cpp:
      (JSC::objectProtoFuncValueOf):
      (JSC::objectProtoFuncHasOwnProperty):
      (JSC::objectProtoFuncIsPrototypeOf):
      (JSC::objectProtoFuncPropertyIsEnumerable):
      (JSC::objectProtoFuncToLocaleString):
      (JSC::objectProtoFuncToString):
      
      LayoutTests: 
      
      * fast/js/resources/js-test-pre.js:
          - Updated harness to not call Object.prototype.toString on undefined.
      * fast/js/eval-var-decl-expected.txt:
      * fast/js/object-prototype-properties-expected.txt: Added.
      * fast/js/object-prototype-properties.html: Added.
      * fast/js/object-prototype-toLocaleString-expected.txt
      * fast/js/script-tests/eval-var-decl.js:
          - Fix test case, calling hasProperty with undefined as the this value should throw.
      * fast/js/script-tests/object-prototype-properties.js: Added.
          - Place for test cases for Object.prototype properties; to being with, check that calling these methods on undefined throws!
      * fast/js/script-tests/object-prototype-toLocaleString.js:
          - Added test cases for correct behaviour when this is a string primitive.
      * sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.1_The_this_Keyword/S11.1.1_A2-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.4_String.prototype.charAt/S15.5.4.4_A1_T3-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.5_String.prototype.charCodeAt/S15.5.4.5_A1_T3-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
          - These test cases are all incorrect. (See https://bugs.ecmascript.org/show_bug.cgi?id=117).
            We were incorrectly passing 15.5.4.11_String.prototype.replace, this should fail, as the others do.
            All the other 15.5.4 tests were failing & are still failing, but now have a better error message.
            S11.1.1_A2 is also invalid, calling toString() passing undefined as this should throw.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      921ec019
    • rniwa@webkit.org's avatar
      Fix a typo. · 760f400b
      rniwa@webkit.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      760f400b
    • bweinstein@apple.com's avatar
      Prep work for: Crash under WebPage::platformDragEnded when dragging on Mac · dc5fa7a6
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64766
      <rdar://problem/9548174>
              
      Reviewed by Darin Adler.
      
      Add a DragClient function that is called when a drag is ended, and call it from DragController::dragEnded.
      This isn't used yet, but will be used by WebKit2 on Mac.
              
      This patch also cleans up style in DragClient.h.
      
      No change in behavior, no tests needed.
      
      * page/DragClient.h:
      (WebCore::DragClient::dragEnded): Stub virtual implementation for now, this will be used by
          WebKit2 on Mac.
      * page/DragController.cpp:
      (WebCore::DragController::dragEnded): Call DragClient::dragEnded.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc5fa7a6
    • rniwa@webkit.org's avatar
      Add Chromium failing expectations for some font tests; failures are tracked by the bug 64767. · f63be00a
      rniwa@webkit.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f63be00a
    • ojan@chromium.org's avatar
      Load ToT chromium bots by default in the flakiness dashboard · 89a78439
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64756
      
      Reviewed by Adam Barth.
      
      For now, these are the most useful bots to look at. Eventually,
      we may want to load the build.webkit.org bots by default once
      most of the bots there upload results.
      
      * TestResultServer/static-dashboards/dashboard_base.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89a78439