1. 17 Jan, 2011 40 commits
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, test expectations update. · 95d4bfae
      dimich@chromium.org authored
      Added TIMEOUT to  fast/canvas/canvas-fillPath-pattern-shadow.html
      
      * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95d4bfae
    • commit-queue@webkit.org's avatar
      2011-01-17 Jarred Nicholls <jarred@sencha.com> · f9194859
      commit-queue@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              REGRESSION(r75709): Return value of fscanf() shouldn't be ignored.
              https://bugs.webkit.org/show_bug.cgi?id=52585
      
              gcc 4.4.4+ has warn_unused_value attribute on fscanf, so we should check
              the return value to get around the gcc warning
      
              * jit/ExecutableAllocatorFixedVMPool.cpp:
              (JSC::maybeModifyVMPoolSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9194859
    • msaboff@apple.com's avatar
      2011-01-17 Michael Saboff <msaboff@apple.com> · b1155bd1
      msaboff@apple.com authored
              Reviewed by Oliver Hunt.
      
              [regexfuzz] Crash running regex with lookahead
              https://bugs.webkit.org/show_bug.cgi?id=52548
      
              Eliminated agressive chaining of backtracks.  This code was overwriting
              already valid backtrack information.
      
              * yarr/YarrJIT.cpp:
              (JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):
      2011-01-17  Michael Saboff  <msaboff@apple.com>
      
              Reviewed by Oliver Hunt.
      
              [regexfuzz] Crash running regex with lookahead
              https://bugs.webkit.org/show_bug.cgi?id=52548
      
              New tests from regex fuzzer.
      
              * fast/regex/parentheses-expected.txt:
              * fast/regex/script-tests/parentheses.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1155bd1
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, test expectations update. · 212b8fc1
      dimich@chromium.org authored
      Same as previous patch, now for -gpu file.
      
      * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      212b8fc1
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, test expectations update. · 5951b3da
      dimich@chromium.org authored
      fast/canvas/canvas-fillPath-pattern-shadow.html fails on Win and Linux.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5951b3da
    • aroben@apple.com's avatar
      Simplify WKCACFLayerRenderer's API · 07b671ba
      aroben@apple.com authored
      createRenderer/destroyRenderer are now hidden behind setHostWindow.
      WKCACFLayerRendererClient::animationsStarted has been removed, as it
      was never called. (The work it was supposed to do was already being
      accomplished by WKCACFLayerRenderer::render telling each layer that
      animations are starting.)
      
      Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use
      
      Reviewed by Chris Marrin.
      
      Source/WebCore:
      
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
      (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Moved the
      call to setHostWindow here from the WM_CREATE handler. The WM_CREATE
      handler was causing the Direct3D device to be created, but MSDN says
      you shouldn't create a device while handling WM_CREATE. Removed
      no-longer-needed call to createRenderer (setHostWindow does this now)
      and the never-needed call to setNeedsDisplay (we never draw into the
      root layer; this was just creating an unnecessary backing store the
      size of the screen!).
      (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Moved WM_CREATE
      code, as described above. Removed call to destroyRenderer when handling
      WM_DESTROY; setHostWindow does this now. Fixed up our WM_PAINT handler
      to do a synchronous paint and to clear our dirty region, while I was in
      here.
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Changed to call
      setHostWindow instead of destroyRenderer; the former calls the latter
      if needed.
      (WebCore::WKCACFLayerRenderer::setHostWindow): Moved here from the
      header file. Destroys our old renderer (i.e., IDirect3DDevice9) if
      we're losing our window, or creates a renderer if we're gaining a
      window.
      (WebCore::WKCACFLayerRenderer::createRenderer): Updated for WKSI function rename.
      (WebCore::WKCACFLayerRenderer::destroyRenderer): Changed to clear the
      D3D device from our context before releasing the device.
      
      * platform/graphics/win/WKCACFLayerRenderer.h: Removed
      WKCACFLayerRendererClient::animationsStarted. Removed setNeedsDisplay.
      Make createRenderer, destroyRenderer, and renderSoon private.
      
      WebKit/win:
      
      Update for WKCACFLayerRenderer changes
      
      * WebView.cpp:
      (WebView::WebViewWndProc): Removed call to layerRendererBecameVisible
      when handling WM_SHOWWINDOW. All this did was try to create the
      renderer, but it had already been created in setAcceleratedCompositing,
      so wasn't needed.
      (WebView::setAcceleratedCompositing): Removed call to createRenderer;
      setHostWindow does this for us now.
      
      * WebView.h: Removed animationsStarted and layerRendererBecameVisible.
      
      WebKitLibraries:
      
      Make it possible to both set and clear a wkCACFContext's D3D device
      
      * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
      * win/lib/WebKitSystemInterface.lib:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07b671ba
    • aroben@apple.com's avatar
      Paint directly into a GraphicsLayer when using accelerated compositing · e8d0708b
      aroben@apple.com authored
      Before this patch, we were painting into our normal backing store
      HBITMAP, wrapping it in a CGImage, and handing it off to Core
      Animation. This had at least two disadvantages:
         1) The bitmap could be modified while Core Animation was using it.
         2) It introduced extra complexity.
      
      When entering accelerated compositing mode, WebView now creates a
      GraphicsLayer to draw into. This GraphicsLayer sits between the root
      layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When
      WebView invalidates, it just calls setNeedsDisplayInRect on its
      GraphicsLayer. When WebView paints, it just tells its
      WKCACFLayerRenderer to paint, which will call back to WebView to draw
      into the GraphicsLayer if it has a dirty region. This is very similar
      to the current implementation of LayerBackedDrawingArea in WebKit2.
      
      Fixes <http://webkit.org/b/52582> WebView should paint directly into a
      GraphicsLayer when in accelerated compositing mode
      
      Reviewed by Simon Fraser and Chris Marrin.
      
      WebCore:
      
      Remove special-cased support for providing content for the root layer
      
      Clients will just have to provide content through the normal
      GraphicsLayer channels now!
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Removed
      initialization of m_backingStoreDirty, which has itself been removed.
      (WebCore::WKCACFLayerRenderer::setNeedsDisplay): Moved code to schedule
      a sync from here to syncCompositingStateSoon. We only need to call
      renderSoon if we don't call syncCompositingStateSoon; the latter
      function calls the former.
      (WebCore::WKCACFLayerRenderer::paint): Removed code to handle
      m_backingStoreDirty. We don't want to know anything about clients'
      backing stores.
      (WebCore::WKCACFLayerRenderer::syncCompositingStateSoon): Added. Code
      came from setNeedsDisplay.
      
      * platform/graphics/win/WKCACFLayerRenderer.h:
      Removed setRootContents[AndDisplay], setBackingStoreDirty, and
      m_backingStoreDirty. Made paint() public so that clients can force a
      synchronous render (e.g., when handling WM_PAINT).
      
      WebKit/win:
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::attachRootGraphicsLayer):
      (WebChromeClient::scheduleCompositingLayerSync):
      Updated for WebView changes.
      
      * WebView.cpp:
      (WebView::repaint): When using accelerated compositing, just invalidate
      our backing layer. This matches the behavior of LayerBackedDrawingArea.
      (WebView::deleteBackingStore): Removed accelerated compositing code.
      The WKCACFLayerRenderer doesn't need to know about our backing store
      anymore; we don't use it at all when in accelerated compositing mode.
      (WebView::addToDirtyRegion): When using accelerated compositing, just
      invalidate our backing layer.
      (WebView::scrollBackingStore): Added an assertion that this isn't
      called in accelerated compositing mode.
      (WebView::sizeChanged): Update our backing layer's size, too, and
      invalidate it.
      (WebView::updateBackingStore): Added an assertion that this isn't
      called in accelerated compositing mode.
      (WebView::paint): If we're in accelerated compositing mode, sync our
      compositing state. If we're *still* in accelerated compositing mode,
      just tell our WKCACFLayerRenderer to paint and clear our dirty region.
      (The later changes in this function are just un-indenting code that
      used to be inside an if.)
      
      (WebView::paintIntoBackingStore):
      (WebView::paintIntoWindow):
      Added assertions that these aren't called in accelerated compositing
      mode.
      
      (WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for
      removal of setRootLayerNeedsDisplay.
      (WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now
      set the layer as a child of our own backing layer.
      (WebView::scheduleCompositingLayerSync): Just call through to
      WKCACFLayerRenderer.
      (WebView::setAcceleratedCompositing): Create our backing layer and set
      it as the child of WKCACFLayerRenderer's root layer.
      (WebView::notifyAnimationStarted): Added. We never expect this
      GraphicsLayerClient override to be called, as we don't use animations
      on our backing layer.
      (WebView::notifySyncRequired): Added. Just schedule a sync.
      (WebView::paintContents): Added. Just clip and paint!
      
      (WebView::showDebugBorders):
      (WebView::showRepaintCounter):
      Added. These just call through to Settings.
      
      (WebView::syncCompositingState): Changed to first update layout, then
      sync state for our backing layer, then sync WebCore's state. This
      matches LayerBackedDrawingArea.
      
      * WebView.h: WebView now implements the GraphicsLayerClient interface.
      Removed setRootLayerNeedsDisplay; it's been replaced by calling
      setNeedsDisplay on our backing layer and calling
      syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed
      updateRootLayerContents; that function was used to pass our backing
      store to Core Animation, which we no longer do. Added m_backingLayer.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8d0708b
    • aroben@apple.com's avatar
      Remove contexts from WKCACFContextFlusher before destroying them · ff62db97
      aroben@apple.com authored
      We aren't really using WKCACFContextFlusher for anything useful at the
      moment, but that will probably change in the near future.
      
      I couldn't come up with a way to test this because it isn't possible to
      resize a window in DumpRenderTree.
      
      Fixes <http://webkit.org/b/52573> REGRESSION (r75262): Crash beneath
      WKCACFContextFlusher::flushAllContexts when resizing window on page
      that uses accelerated compositing
      
      Reviewed by Simon Fraser.
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Remove our
      context from WKCACFContextFlusher. (This code was erroneously removed
      from WKCACFLayerRenderer::destroyRenderer in r75262. This is a more
      sensible place for it.)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff62db97
    • aroben@apple.com's avatar
      Don't access the CACFLayerRef's sublayers directly from PlatformCALayer · 7317c459
      aroben@apple.com authored
      There might be a secret extra sublayer (the tile parent layer) that
      PlatformCALayer doesn't know about. When PlatformCALayer would
      encounter this, it would try to use the tile parent layer's
      PlatformCALayer wrapper, which was null, and then would crash. We now
      ask PlatformCALayerWinInternal for the sublayer list, since that class
      knows about the tile parent layer and can exclude it from the sublayer
      list.
      
      Covered by compositing/tiling/huge-layer-resize.html.
      
      Fixes <http://webkit.org/b/52597> Crash beneath
      PlatformCALayer::adoptSublayers when switching out of tiling mode
      (null-dereference of a PlatformCALayer)
      
      Reviewed by Darin Adler and Chris Marrin.
      
      LayoutTests:
      
      Make compositing/tiling/huge-layer-resize.html faster, more reliable,
      and more crashy (when there's a WebKit bug)
      
      This test was trying to cause a layout/paint to happen by returning to
      the event loop for a certain amount of time via setTimeout. But this
      didn't always result in a layout/paint (at least on Windows). We now
      force the layout/paint explicitly, which also lets us speed up the test
      by removing the setTimeouts.
      
      * compositing/tiling/huge-layer-resize.html:
      (testOnLoad): Changed to use recordLayerTree, which forces a
      layout/paint, instead of hoping that setTimeout will do the trick.
      (recordLayerTree): Forces a layout/paint, then dumps the layer tree.
      
      Source/WebCore:
      
      * platform/graphics/ca/win/PlatformCALayerWin.cpp:
      (PlatformCALayer::adoptSublayers):
      (printLayer):
      Changed to use PlatformCALayerWinInternal::getSublayers.
      
      * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
      (PlatformCALayerWinInternal::getSublayers): Added. Retrieves the list
      of PlatformCALayers that represent our sublayers. Significantly, this
      code knows about the tile parent layer and can thus exclude it.
      
      * platform/graphics/ca/win/PlatformCALayerWinInternal.h: Added
      getSublayers.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7317c459
    • wsiegrist@apple.com's avatar
      2011-01-17 William Siegrist <wsiegrist@apple.com> · dbac7d92
      wsiegrist@apple.com authored
      Explicitly set mode during file upload to ensure web server can read the files.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbac7d92
    • thakis@chromium.org's avatar
      2011-01-17 Nico Weber <thakis@chromium.org> · 5cc8cac1
      thakis@chromium.org authored
              Unreviewed.
      
              Roll chromium DEPS forward to pick up the skia roll to skia r692.
              https://bugs.webkit.org/show_bug.cgi?id=52600
      
              * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cc8cac1
    • commit-queue@webkit.org's avatar
      2011-01-17 Naoki Takano <takano.naoki@gmail.com> · d23f2759
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              [Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
              https://bugs.webkit.org/show_bug.cgi?id=51382
              http://crbug.com/60427
      
              Calculate correct location of popup window whenever the items in the window change.
      
              No new tests, because this fix is for Chromium project and hard to test only in WebKit project
      
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupContainer::layoutAndCalculateWidgetRect): New Function to layout and calculate popup widget rect.
              (WebCore::PopupContainer::showPopup): Move widgetRect calculation logic to calculateWidgetRect().
              (WebCore::PopupContainer::refresh): Add parameter focusRect to take the location and the size of focus text input field to calculate correct popup window location.
              * platform/chromium/PopupMenuChromium.h: Append new input parameter for refresh().
      2011-01-17  Naoki Takano  <takano.naoki@gmail.com>
      
              Reviewed by Kent Tamura.
      
              [Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
              https://bugs.webkit.org/show_bug.cgi?id=51382
              http://crbug.com/60427
      
              Calculate correct location of popup window whenever the items in the window change.
      
              No new tests, because this fix is for Chromium project and hard to test only in WebKit project
      
             * WebKit/chromium/src/WebViewImpl.cpp:
             (WebKit::WebViewImpl::refreshAutoFillPopup): Change the logic in refreshAutoFilPopup() to check both the location and the size of popup window.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d23f2759
    • jhoneycutt@apple.com's avatar
      Windows build fix. Unreviewed. · ff92a4b6
      jhoneycutt@apple.com authored
      * Shared/PrintInfo.cpp:
      Use #include, not #import.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff92a4b6
    • ap@apple.com's avatar
      Actually wrote a FIXME promised for a review comment. · 09a2f3fc
      ap@apple.com authored
              * UIProcess/API/mac/WKView.mm:
              (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09a2f3fc
    • ap@apple.com's avatar
      Reviewed by Anders Carlsson and Darin Adler. · 0909d924
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=52595
              Make basic printing work in WebKit2
      
              * Shared/WebPreferencesStore.h:
              * UIProcess/API/C/WKPreferences.cpp:
              (WKPreferencesSetShouldPrintBackgrounds):
              (WKPreferencesGetShouldPrintBackgrounds):
              * UIProcess/API/C/WKPreferences.h:
              Implement a preference for printing backgrounds.
      
              * Shared/PrintInfo.cpp: Added.
              (WebKit::PrintInfo::encode):
              (WebKit::PrintInfo::decode):
              * Shared/PrintInfo.h: Added.
              * Shared/mac/PrintInfoMac.mm: Added.
              (WebKit::PrintInfo::PrintInfo):
              A new class for passing page setup information down to the web process.
      
              * WebKit2.xcodeproj/project.pbxproj:
              * GNUmakefile.am:
              * WebKit2.pro:
              * win/WebKit2.vcproj:
              Added PrintInfo.
      
              * Scripts/webkit2/messages.py: Added PrintInfo.h to a list of structs.
      
              * UIProcess/API/mac/WKView.mm:
              (WKViewData): Cache page count and geometry.
              (WebFrameWrapper): Added a wrapper class for adding a WebFrameProxy to an NSDictionary.
              (-[WKView drawRect:]): Added logging.
              (setFrameBeingPrinted): Store a frame into NSPrintOperation's NSPrintInfo, so that all 
              methods invoked for this operation would know what's being printed.
              (frameBeingPrinted): Retrieve this data.
              (-[WKView printOperationWithPrintInfo:forFrame:]): Create a print operation that's appropriate
              for the frame.
              (-[WKView knowsPageRange:]): Ask the web process.
              (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
              Take over printing, because I couldn't make drawRect: work correctly with WebKit custom fit
              to page implementation.
              (-[WKView _provideTotalScaleFactorForPrintOperation:]): Help AppKit clip correctly.
              (-[WKView rectForPage:]): Return a pre-calculated rect.
      
              * UIProcess/WebPageProxy.h: Added m_isInPrintingMode to track whether the web page is in
              printing mode. The UI process controls that.
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::WebPageProxy): Initialize m_isInPrintingMode.
              (WebKit::WebPageProxy::beginPrinting): Change printing mode in web process if the value changes.
              (WebKit::WebPageProxy::endPrinting): Ditto.
              (WebKit::WebPageProxy::computePagesForPrinting): Ask the web process about output page geometry.
              (WebKit::WebPageProxy::drawRectToPDF): Ask the web process about printed page data.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::close): Delete m_printContext while there is still a Frame pointer.
              (WebKit::WebPage::updatePreferences): Pass through ShouldPrintBackgrounds.
              (WebKit::WebPage::beginPrinting): Switch into printing mode (or update parameters if we're
              already in printing mode).
              (WebKit::WebPage::endPrinting): Delete m_printContext, implicitly calling end().
              (WebKit::WebPage::computePagesForPrinting): Make sure that we're in printing mode, and
              copmute page rects.
              (WebKit::WebPage::drawRectToPDF): Added a CG specific function to create a PDF document out
              of a page rect. It should really work for onscreen content, but we only need it for printing.
      
              * WebProcess/WebPage/WebPage.h:
      
              * WebProcess/WebPage/WebPage.messages.in: Added BeginPrinting, EndPrinting,
              ComputePagesForPrinting and DrawRectToPDF.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0909d924
    • mrowe@apple.com's avatar
      Fix the 32-bit build. · d482bb41
      mrowe@apple.com authored
      * WebCore.exp.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d482bb41
    • mitz@apple.com's avatar
      Use of invalid hash map key in CSSFontFaceSource::getFontData() with 0-sized remote font · 78de1d02
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52598
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Test: fast/css/font-face-zero-hash-key.html
      
      * css/CSSFontFaceSource.cpp:
      (WebCore::CSSFontFaceSource::getFontData): Add 1 to the font size to avoid a 0 hash key.
      * css/CSSSegmentedFontFace.cpp:
      (WebCore::CSSSegmentedFontFace::getFontData): Ditto.
      
      LayoutTests: 
      
      * fast/css/font-face-zero-hash-key-expected.txt: Added.
      * fast/css/font-face-zero-hash-key.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78de1d02
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project · 4f1e3a43
      ddkilzer@apple.com authored
      Reviewed by Dan Bernstein.
      
      WebCore:
      
      This fixes two issues:
      
      Add missing DOMDocumentFragmentPrivate.h and
      DOMDocumentPrivate.h files to the project.  These files were
      never added to the the project although their *Internal.h
      counterparts were added in r16548 and r17390.
      
      Add missing DOMDocumentFragmentInternal.h to the Headers
      section.  It was moved from Headers to "Copy Generated Headers"
      in r31045, but it should have an entry in both sections.
      
      * WebCore.xcodeproj/project.pbxproj:
      
      WebKit/mac:
      
      * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
      DOMDocumentPrivate.h to the PrivateHeaders directory.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f1e3a43
    • commit-queue@webkit.org's avatar
      2011-01-17 Helder Correia <helder@sencha.com> · 51fd6f02
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Incorrect shadow alpha with pattern fillStyle
              https://bugs.webkit.org/show_bug.cgi?id=52559
      
              The shadow color opacity needs to be set on the shadow painter.
              This is related to bug 52556.
      
              * fast/canvas/canvas-fillPath-pattern-shadow-expected.txt: Added.
              * fast/canvas/canvas-fillPath-pattern-shadow.html: Added.
              * fast/canvas/script-tests/canvas-fillPath-pattern-shadow.js: Added.
      2011-01-17  Helder Correia  <helder@sencha.com>
      
              Reviewed by Andreas Kling.
      
              [Qt] Incorrect shadow alpha with pattern fillStyle
              https://bugs.webkit.org/show_bug.cgi?id=52559
      
              The shadow color opacity needs to be set on the shadow painter.
              This is related to bug 52556.
      
              Test: fast/canvas/canvas-fillPath-pattern-shadow.html
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::fillPath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51fd6f02
    • mrobinson@webkit.org's avatar
      2011-01-17 Martin Robinson <mrobinson@igalia.com> · f763db6c
      mrobinson@webkit.org authored
              Reviewed by Andreas Kling.
      
              [GTK] Port a crash fix from libsoup upstream to the libsoup cache code
              https://bugs.webkit.org/show_bug.cgi?id=52586
      
              No new tests. This is just a merge from upstream.
      
              * platform/network/soup/cache/soup-http-input-stream.c:
              (webkit_soup_http_input_stream_got_chunk): Properly handle unsigned numbers.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f763db6c
    • tonyg@chromium.org's avatar
      2011-01-17 Tony Gentilcore <tonyg@chromium.org> · 938b60ed
      tonyg@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              Fix some headers with missing or misspelled #ifndef guards
              https://bugs.webkit.org/show_bug.cgi?id=52545
      
              * wtf/RefPtrHashMap.h:
      2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Fix some headers with missing or misspelled #ifndef guards
              https://bugs.webkit.org/show_bug.cgi?id=52545
      
              No new tests because no new functionality.
      
              * ForwardingHeaders/runtime/InitializeThreading.h:
              * editing/SmartReplace.h:
              * loader/CrossOriginAccessControl.h:
              * loader/NetscapePlugInStreamLoader.h:
              * platform/chromium/ClipboardUtilitiesChromium.h:
              * platform/graphics/cairo/DrawErrorUnderline.h:
              * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
              * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
              * platform/graphics/cg/PDFDocumentImage.h:
              * platform/win/WebCoreTextRenderer.h:
      2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Fix some headers with missing or misspelled #ifndef guards
              https://bugs.webkit.org/show_bug.cgi?id=52545
      
              * WebKitStatistics.h:
      2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Fix some headers with missing or misspelled #ifndef guards
              https://bugs.webkit.org/show_bug.cgi?id=52545
      
              * Shared/UserMessageCoders.h:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
              * WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
              * WebProcess/WebProcessMain.h:
      2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Fix some headers with missing or misspelled #ifndef guards
              https://bugs.webkit.org/show_bug.cgi?id=52545
      
              * DumpRenderTree/chromium/TestEventPrinter.h:
              * DumpRenderTree/chromium/WebPreferences.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      938b60ed
    • ddkilzer@apple.com's avatar
      2011-01-17 David Kilzer <ddkilzer@apple.com> · 5827990f
      ddkilzer@apple.com authored
              <http://webkit.org/b/52524> fast/dom/Range/range-clone-contents.html fails only on Windows
      
              Reviewed by Alexey Proskuryakov.
      
              * platform/win/Skipped: Removed
              fast/dom/Range/range-clone-contents.html.  It appears the
              Windows buildbots need a clean build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5827990f
    • pfeldman@chromium.org's avatar
      2011-01-17 Pavel Feldman <pfeldman@chromium.org> · 03305a55
      pfeldman@chromium.org authored
              Not reviewed: follow-up fix for r52574: do not reuse clear() for navigation.
      
              * inspector/front-end/NetworkPanel.js:
              (WebInspector.NetworkPanel.prototype.clear):
              (WebInspector.NetworkPanel.prototype.mainResourceChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03305a55
    • ap@apple.com's avatar
      Build fix. · 97daddd8
      ap@apple.com authored
              * Platform/Logging.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97daddd8
    • sergio@webkit.org's avatar
      2011-01-17 Sergio Villar Senin <svillar@igalia.com> · 55c7f491
      sergio@webkit.org authored
              Reviewed by Martin Robinson.
      
              [Gtk] No need to content sniff 304 Not Modified responses
              https://bugs.webkit.org/show_bug.cgi?id=52570
      
              Makes no sense to wait for the outcome of content sniffing when WebCore
              is validating resources. If we get a 304 Not Modified it means that we can
              safely use the cached version of the resource we're asking for.
      
              No new tests because it does not change functionality, it just
              calls didReceiveResponse sooner for 304 Not Modified responses.
      
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::gotHeadersCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55c7f491
    • jberlin@webkit.org's avatar
      REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when · d617a3b2
      jberlin@webkit.org authored
      navigating back to an unreachable URL
      https://bugs.webkit.org/show_bug.cgi?id=52388
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Test: http/tests/navigation/go-back-to-error-page.html
      
      * history/PageCache.cpp:
      (WebCore::PageCache::canCachePageContainingThisFrame):
      Do not cache any error pages (which we can recognize as having substitute data and/or an
      unreachableURL).
      
      Tools: 
      
      Add a third parameter (unreachableURL) to queueLoadHTMLString.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (queueLoadHTMLStringCallback):
      (LayoutTestController::queueLoadHTMLString):
      (LayoutTestController::queueLoadAlternateHTMLString):
      * DumpRenderTree/LayoutTestController.h:
      
      * DumpRenderTree/WorkQueueItem.h:
      (LoadHTMLStringItem::LoadHTMLStringItem):
      
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
      (WorkItemLoadHTMLString::run):
      (LayoutTestController::queueLoadHTMLString):
      
      * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
      (LoadHTMLStringItem::invoke):
      * DumpRenderTree/mac/WorkQueueItemMac.mm:
      (LoadHTMLStringItem::invoke):
      * DumpRenderTree/win/WorkQueueItemWin.cpp:
      (LoadHTMLStringItem::invoke):
      
      LayoutTests: 
      
      Add a test that loads an alternate HTML String for an "unreachable" URL, loads another
      page, and then goes back to the "unreachable" URL, which is now reachable.
      
      This tests two things:
      1) No assertion failure when going back to an unreachable URL.
      2) There is no page cached for the unreachable URL.
      
      * http/tests/navigation/go-back-to-error-page-expected.txt: Added.
      * http/tests/navigation/go-back-to-error-page.html: Added.
      * http/tests/navigation/resources/page-to-go-back-from.html: Added.
      * http/tests/navigation/resources/page-treated-as-unreachable.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d617a3b2
    • ap@apple.com's avatar
      Reviewed by Dan Bernstein. · d423cf51
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=52592
              Add a logging channel for WKView
      
              * Platform/Logging.cpp:
              * Platform/Logging.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d423cf51
    • pfeldman@chromium.org's avatar
      2011-01-17 Pavel Feldman <pfeldman@chromium.org> · 75ad60e5
      pfeldman@chromium.org authored
              Not reviewed: fixing typo in r75952.
      
              * inspector/front-end/NetworkPanel.js:
              (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75ad60e5
    • enrica@apple.com's avatar
      Drag and drop support: refactoring of image from link and image from selection · c08c834b
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52496
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore: 
      
      This work cleans up the Mac code and makes it more similar to the Windows implementation,
      avoiding the use of an NSView when the FrameView can be used.
      The refactoring is a necessary step towards the complete support of drag and drop
      in WebKit2.
              
      * page/mac/FrameMac.mm:
      (WebCore::Frame::imageFromRect): Modified to use FrameView instead of NSView
      to generate the image for drag.
      
      Source/WebKit/mac: 
      
      This work cleans up the Mac code and makes it more similar to the Windows implementation,
      avoiding the use of an NSView when the FrameView can be used.
      The refactoring is a necessary step towards the complete support of drag and drop
      in WebKit2.
      
      * WebCoreSupport/WebDragClient.mm:
      (WebDragClient::createDragImageForLink): Added.
      * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
      * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c08c834b
    • andersca@apple.com's avatar
      2011-01-17 Anders Carlsson <andersca@apple.com> · 59b33d65
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Factor bitmap context drawing code out into a shared function
              https://bugs.webkit.org/show_bug.cgi?id=52589
      
              * Platform/cg/CGUtilities.h: Added.
              * Platform/cg/CGUtilities.cpp: Added.
              (WebKit::paintBitmapContext):
              New function that will paint a bitmap context into a CGContext.
      
              * Shared/cg/ShareableBitmapCG.cpp:
              (WebKit::ShareableBitmap::paint):
              Use paintBitmapContext.
      
              * UIProcess/mac/BackingStoreMac.mm:
              (WebKit::BackingStore::paint):
              (WebKit::BackingStore::scroll):
              Use paintBitmapContext.
      
              * WebKit2.xcodeproj/project.pbxproj:
              * win/WebKit2.vcproj:
              * win/WebKit2Common.vsprops:
              Add CGUtilities.{cpp|h}.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59b33d65
    • mitz@apple.com's avatar
      Update xcodeproj svn:ignore to include xcuserdata. · 2db326be
      mitz@apple.com authored
      Rubber-stamped by Mark Rowe.
      
      Examples: 
      
      * NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
      * NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
      * NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
      * NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.
      
      Source/JavaScriptCore: 
      
      * JavaScriptCore.xcodeproj: Modified property svn:ignore.
      
      Source/JavaScriptGlue: 
      
      * JavaScriptGlue.xcodeproj: Modified property svn:ignore.
      
      Source/ThirdParty/ANGLE: 
      
      * ANGLE.xcodeproj: Modified property svn:ignore.
      * src/build_angle.xcodeproj: Modified property svn:ignore.
      
      Source/WebCore: 
      
      * WebCore.xcodeproj: Modified property svn:ignore.
      * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.
      
      Source/WebKit: 
      
      * WebKit.xcodeproj: Modified property svn:ignore.
      
      Source/WebKit2: 
      
      * ...
      2db326be
    • ap@apple.com's avatar
      Fixing a typo from a bad merge. · de0cd6f0
      ap@apple.com authored
              * UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de0cd6f0
    • ap@apple.com's avatar
      Reviewed by John Sullivan. · 1487c1e0
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=52590
              Should pass a frame into -[WKView canPrintHeadersAndFooters]
      
              * UIProcess/API/mac/WKView.h:
              * UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]): Also, renamed the method
              to canChangeFrameLayout.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1487c1e0
    • ap@apple.com's avatar
      Leopard build fix. · 53737167
      ap@apple.com authored
              * page/PrintContext.cpp: GCC complained about shortening a double value to float.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53737167
    • mrowe@apple.com's avatar
      Remove a few more empty directories that I missed. · 40c8ded4
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40c8ded4
    • mrowe@apple.com's avatar
      Remove a large number of empty directories. · c88d3e39
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c88d3e39
    • ap@apple.com's avatar
      Reviewed by Dan Bernstein. · 2320483d
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=52495
      
              No change in behavior, so no tests.
      
              * WebCore.exp.in: Export additional methods, as I'm going to use more code from PrintContext.
      
              * page/PrintContext.cpp:
              (WebCore::PrintContext::~PrintContext): No need to clear m_pageRects, the object is being
              destroyed already.
              (WebCore::PrintContext::pageCount): Changed page count from int to size_t.
              (WebCore::PrintContext::pageRect): Ditto.
              (WebCore::PrintContext::computePageRects): Pass allowHorizontalTiling as an argument.
              PrintContext already has code to calculate scale factor, so it makes sense to make methods
              that contain it universal (allowHorizontalTiling is always true for Safari).
              Round page height to an integer, because Mac code does that, and because page height is
              treated as integer almost everywhere else in code.
              (WebCore::PrintContext::begin): Allow calling this function multiple times. There is no need
              to return to screen mode if e.g. "print backgounds" option changes.
              (WebCore::PrintContext::computeAutomaticScaleFactor): Expose scale factor computation, so
              that clients don't have to copy it.
              (WebCore::PrintContext::spoolRect): Add a way to spool a precomputed rect - handy if a request
              comes from code that doesn't have page number.
              (WebCore::PrintContext::pageNumberForElement): Page number int -> size_t.
      
              * page/PrintContext.h: Added comments and FIXMEs. PrintContext needs cleanup, but that
              depends on deciding how it really needs to work (e.g. whether computePageRects() should
              cause relayout).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2320483d
    • pfeldman@chromium.org's avatar
      2011-01-17 Pavel Feldman <pfeldman@chromium.org> · d55413b4
      pfeldman@chromium.org authored
              Not reviewed: skip flaky inspector test (will look at it tomorrow).
      
              * platform/mac-leopard/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d55413b4
    • andersca@apple.com's avatar
      2011-01-17 Anders Carlsson <andersca@apple.com> · 5b5fbf8c
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Implement scrolling support
              https://bugs.webkit.org/show_bug.cgi?id=52502
      
              * Shared/UpdateInfo.cpp:
              (WebKit::UpdateInfo::encode):
              (WebKit::UpdateInfo::decode):
              * Shared/UpdateInfo.h:
              Add scrollRect and scrollDelta member variables.
      
              * UIProcess/BackingStore.h:
              Add scroll member function.
      
              * UIProcess/DrawingAreaProxyImpl.cpp:
              (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
              Repaint the scroll rect. Force a display of the view when the update info contains a scroll rect.
      
              * UIProcess/mac/BackingStoreMac.mm:
              (WebKit::BackingStore::incorporateUpdate):
              Call scroll.
      
              (WebKit::BackingStore::scroll):
              Paint the backing store into itself.
      
              * WebProcess/WebPage/DrawingAreaImpl.cpp:
              (WebKit::DrawingAreaImpl::display):
              Pass the scroll information in the update info.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b5fbf8c
    • pfeldman@chromium.org's avatar
      2011-01-17 Pavel Feldman <pfeldman@chromium.org> · b34c2dc0
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: unify image data source assignment, add image url
              to the image view properties list.
              https://bugs.webkit.org/show_bug.cgi?id=52584
      
              * English.lproj/localizedStrings.js:
              * inspector/front-end/ImageView.js:
              (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
              (WebInspector.ImageView.prototype._createContentIfNeeded):
              * inspector/front-end/NetworkPanel.js:
              (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype.populateImageSource):
              (WebInspector.Resource.prototype._contentURL):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.FrameResourceTreeElement.prototype.onattach):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b34c2dc0