1. 26 Feb, 2008 9 commits
    • hyatt@apple.com's avatar
      · 95aa614a
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95aa614a
    • hyatt@apple.com's avatar
      Reviewed by Dan · 21cc37a9
      hyatt@apple.com authored
              http://bugs.webkit.org/show_bug.cgi?id=17485
      
              Refine our behavior for empty inlines so that they work more correctly with margins/borders/padding.
              Fixes a regression on huffingtonpost.com.
      
              New tests added to fast/inline
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::computeLogicalBoxHeights):
              (WebCore::InlineFlowBox::placeBoxesVertically):
              (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::calcMargins):
              * rendering/RenderFlow.h:
              * rendering/RenderObject.h:
              (WebCore::RenderObject::hasHorizontalBordersPaddingOrMargin):
              (WebCore::RenderObject::hasHorizontalBordersOrPadding):
              * rendering/bidi.cpp:
              (WebCore::getBorderPaddingMargin):
              (WebCore::RenderBlock::layoutInlineChildren):
              (WebCore::inlineFlowRequiresLineBox):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21cc37a9
    • timothy@apple.com's avatar
      .: · 7e518c5b
      timothy@apple.com authored
              Reviewed by Darin Adler.
      
              Add "64" and "64u" make rules to allow easy building of 64-bit versions.
      
              make 64: will build Intel-only 64-bit.
              make 64u: will build 4-way universal for PPC and Intel.
      
              * Makefile:
              * Makefile.shared:
      
      WebKitTools:
      
              Reviewed by Darin Adler.
      
              * Scripts/build-webkit: Add --universal and --64-bit flags to make building
              64-bit architectures easy. Combine the two flags to build 4-way universal.
              * Makefile: Add "64" and "64u" make rules. Fix the universal rule to return
              non-zero when the build failes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e518c5b
    • weinig@apple.com's avatar
      Fix Windows build. · 10ac6851
      weinig@apple.com authored
              * platform/text/PlatformString.h:
              (WebCore::reverseFind):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10ac6851
    • mitz@apple.com's avatar
      WebCore: · 8e3f8bda
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17555
                <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page
      
              Test: fast/dynamic/subtree-table-cell-height.html
      
              * rendering/RenderObject.cpp:
              (WebCore::objectIsRelayoutBoundary): Exclude table cells, since their
              height depends on their contents even if the CSS height property is
              fixed.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=17555
                <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page
      
              * fast/dynamic/subtree-table-cell-height.html: Added.
              * platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
              * platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
              * platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e3f8bda
    • jess@apple.com's avatar
      Reviewed by Darin. · 6997a5d3
      jess@apple.com authored
              * Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment,
              so that Safari inherits it when launched. Preexisting code in WebKit checks this
              environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications
              launched by Safari continue to use the standard system WebKit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6997a5d3
    • weinig@apple.com's avatar
      JavaScriptCore: · f8479433
      weinig@apple.com authored
              Reviewed by Dan Bernstein.
      
              - Add a variant of remove that takes a position and a length.
      
              * wtf/Vector.h:
              (WTF::Vector::remove):
      
      WebCore:
      
              Reviewed by Dan Bernstein.
      
              Make the cleanPath function in CSSStyleSelector more efficient by using
              a Vector<UChar>.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::cleanPath): Make this function work on a Vector<UChar> instead
              of a String.  Also remove unnecessary reverseFind call that could be acomplished
              with two compares.
              (WebCore::checkPseudoState): Remove reserveCapacity calls now that we are using
              a stack buffer.
              * platform/text/PlatformString.h:
              (WebCore::find): Make this find generic enough that it can be used for
              String::find.
              (WebCore::reverseFind): Implement reverseFind so that it can be used
              for with a UChar* and length.
              * platform/text/StringImpl.cpp:
              (WebCore::StringImpl::find): Use implementation in PlatformString.cpp
              (WebCore::StringImpl::reverseFind): Ditto,
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8479433
    • ap@webkit.org's avatar
      Reviewed by Darin. Tweaked and landed by Alexey. · a4d42b5d
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=17411
              Ideographic comma and full stop should be treated as line-breakable characters
      
              Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop.html
      
              * platform/text/CharacterNames.h: Added ideographicComma and ideographicFullStop.
              * rendering/break_lines.cpp: (WebCore::shouldBreakAfter): Added a workaround for an issue in
              Unicode 5.0 that is causing this.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4d42b5d
    • eric@webkit.org's avatar
      Reviewed by eseidel. Landed by eseidel · a481d02f
      eric@webkit.org authored
              Fix improperly initialized m_isUpToDate member variable.
              Fixs 50+ layout tests when run on Tiger.
              http://bugs.webkit.org/show_bug.cgi?id=17549
      
              * platform/network/cf/ResourceResponse.h:
              (WebCore::ResourceResponse::ResourceResponse):
              * platform/network/mac/ResourceResponse.h:
              (WebCore::ResourceResponse::ResourceResponse):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a481d02f
  2. 25 Feb, 2008 31 commits
    • mitz@apple.com's avatar
      WebCore: · 51017321
      mitz@apple.com authored
              Reviewed by Sam Weinig.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17152
                Paragraphs indented with :first-letter and text-align CSS render incorrectly
      
              Test: fast/text/apply-start-width-after-skipped-text.html
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::findNextLineBreak): Improved the logic for when
              to figure in the padding, border and margin before a text node when the
              line begins inside a text node.
      
      LayoutTests:
      
              Reviewed by Sam Weinig.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=17152
                Paragraphs indented with :first-letter and text-align CSS render incorrectly
      
              * fast/text/apply-start-width-after-skipped-text.html: Added.
              * platform/mac/fast/text/apply-start-width-after-skipped-text-expected.checksum: Added.
              * platform/mac/fast/text/apply-start-width-after-skipped-text-expected.png: Added.
              * platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51017321
    • kevino@webkit.org's avatar
      Windows build fix for wx port. · 06b9bcbd
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06b9bcbd
    • mrowe@apple.com's avatar
      2008-02-25 Mark Rowe <mrowe@apple.com> · 178d531e
      mrowe@apple.com authored
              Windows build fix.
      
              * platform/network/cf/ResourceResponseCFNet.cpp:
              (WebCore::ResourceResponse::platformCompare):  Implement platformCompare for ResourceResponseCFNet.cpp.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      178d531e
    • bdakin@apple.com's avatar
      WebCore: · b056bbd9
      bdakin@apple.com authored
              Reviewed by Geoff.
      
              Fixed for <rdar://problem/5760530> REGRESSION: Assertion failure in 
              Document::removePendingSheet() from r30438
      
              r30438 added a call to CachedResource::error() from inside 
              Loader::didReceiveData() if a CSS file 4xxs. There was an 
              assumption in the loader, though, that either error() would be 
              called, or didFinishLoading() would be called, so some work is 
              duplicated in each. Now that we are calling an error() on files 
              that will also make it to didFinishLoading() (since they succeeded 
              in the network layer), we need to make sure we do not duplicate the 
              work. CachedCSSStyleSheet::error() calls checkNotify, which ends up 
              decrementing the document's pending style sheet counter. 
              checkNotify() was still getting called, though, through the normal  
              didFinishLoading code path, and the counter was being decremented 
              twice. Bad!
      
              * loader/loader.cpp:
              (WebCore::Loader::didFinishLoading):
              (WebCore::Loader::didReceiveData):
      
      LayoutTests:
      
              Reviewed by Geoff.
      
              Test for <rdar://problem/5760530> REGRESSION: Assertion failure in 
              Document::removePendingSheet() from r30438
      
              * http/tests/misc/missing-style-sheet-expected.txt: Added.
              * http/tests/misc/missing-style-sheet.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b056bbd9
    • mrowe@apple.com's avatar
      Fix the Gtk, wx and Qt builds. · 0064a3bb
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0064a3bb
    • mrowe@apple.com's avatar
      Fix bug number in ChangeLog. · f18f2910
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f18f2910
    • mrowe@apple.com's avatar
      2008-02-25 MorganL <morganl.webkit@yahoo.com> · fd3abd67
      mrowe@apple.com authored
              Reviewed by Darin Adler.
      
              Eliminate some #ifdefs from headers in platform/network.
              http://bugs.webkit.org/show_bug.cgi?id=11786
      
              * WebCore.base.exp:
              * WebCore.order:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/XMLTokenizer.cpp:
              * loader/ResourceLoader.h:
              * platform/network/AuthenticationChallenge.cpp: Removed.
              * platform/network/AuthenticationChallenge.h: Removed.
              * platform/network/AuthenticationChallengeBase.cpp: Copied from platform/network/AuthenticationChallenge.cpp.
              (WebCore::AuthenticationChallengeBase::AuthenticationChallengeBase):
              (WebCore::AuthenticationChallengeBase::previousFailureCount):
              (WebCore::AuthenticationChallengeBase::proposedCredential):
              (WebCore::AuthenticationChallengeBase::protectionSpace):
              (WebCore::AuthenticationChallengeBase::failureResponse):
              (WebCore::AuthenticationChallengeBase::error):
              (WebCore::AuthenticationChallengeBase::isNull):
              (WebCore::AuthenticationChallengeBase::nullify):
              (WebCore::AuthenticationChallengeBase::compare):
              * platform/network/AuthenticationChallengeBase.h: Copied from platform/network/AuthenticationChallenge.h.
              (WebCore::AuthenticationChallengeBase::platformCompare):
              (WebCore::operator==):
              (WebCore::operator!=):
              * platform/network/ResourceError.cpp: Removed.
              * platform/network/ResourceError.h: Removed.
              * platform/network/ResourceErrorBase.cpp: Copied from platform/network/ResourceError.cpp.
              (WebCore::ResourceErrorBase::lazyInit):
              (WebCore::ResourceErrorBase::compare):
              * platform/network/ResourceErrorBase.h: Copied from platform/network/ResourceError.h.
              (WebCore::ResourceErrorBase::isNull):
              (WebCore::ResourceErrorBase::domain):
              (WebCore::ResourceErrorBase::errorCode):
              (WebCore::ResourceErrorBase::failingURL):
              (WebCore::ResourceErrorBase::localizedDescription):
              (WebCore::ResourceErrorBase::ResourceErrorBase):
              (WebCore::ResourceErrorBase::platformLazyInit):
              (WebCore::ResourceErrorBase::platformCompare):
              (WebCore::operator==):
              * platform/network/ResourceResponseBase.cpp:
              (WebCore::ResourceResponseBase::isHTTP):
              (WebCore::ResourceResponseBase::url):
              (WebCore::ResourceResponseBase::setUrl):
              (WebCore::ResourceResponseBase::mimeType):
              (WebCore::ResourceResponseBase::setMimeType):
              (WebCore::ResourceResponseBase::expectedContentLength):
              (WebCore::ResourceResponseBase::setExpectedContentLength):
              (WebCore::ResourceResponseBase::textEncodingName):
              (WebCore::ResourceResponseBase::setTextEncodingName):
              (WebCore::ResourceResponseBase::suggestedFilename):
              (WebCore::ResourceResponseBase::setSuggestedFilename):
              (WebCore::ResourceResponseBase::httpStatusCode):
              (WebCore::ResourceResponseBase::setHTTPStatusCode):
              (WebCore::ResourceResponseBase::httpStatusText):
              (WebCore::ResourceResponseBase::setHTTPStatusText):
              (WebCore::ResourceResponseBase::httpHeaderField):
              (WebCore::ResourceResponseBase::setHTTPHeaderField):
              (WebCore::ResourceResponseBase::httpHeaderFields):
              (WebCore::ResourceResponseBase::isAttachment):
              (WebCore::ResourceResponseBase::setExpirationDate):
              (WebCore::ResourceResponseBase::expirationDate):
              (WebCore::ResourceResponseBase::setLastModifiedDate):
              (WebCore::ResourceResponseBase::lastModifiedDate):
              (WebCore::ResourceResponseBase::lazyInit):
              (WebCore::ResourceResponseBase::compare):
              * platform/network/ResourceResponseBase.h:
              (WebCore::ResourceResponseBase::ResourceResponseBase):
              (WebCore::ResourceResponseBase::platformLazyInit):
              (WebCore::ResourceResponseBase::platformCompare):
              (WebCore::operator==):
              * platform/network/cf/AuthenticationCF.cpp:
              (WebCore::AuthenticationChallenge::AuthenticationChallenge):
              (WebCore::AuthenticationChallenge::platformCompare):
              * platform/network/cf/AuthenticationChallenge.h: Added.
              (WebCore::AuthenticationChallenge::AuthenticationChallenge):
              (WebCore::AuthenticationChallenge::sourceHandle):
              (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
              * platform/network/cf/ResourceError.h: Added.
              (WebCore::ResourceError::ResourceError):
              * platform/network/cf/ResourceErrorCF.cpp:
              (WebCore::ResourceError::ResourceError):
              (WebCore::ResourceError::platformLazyInit):
              (WebCore::ResourceError::platformCompare):
              (WebCore::ResourceError::operator CFStreamError):
              * platform/network/cf/ResourceResponse.h:
              (WebCore::ResourceResponse::ResourceResponse):
              * platform/network/cf/ResourceResponseCFNet.cpp:
              (WebCore::ResourceResponse::platformLazyInit):
              * platform/network/curl/AuthenticationChallenge.h: Added.
              (WebCore::AuthenticationChallenge::AuthenticationChallenge):
              * platform/network/curl/ResourceError.h: Added.
              (WebCore::ResourceError::ResourceError):
              * platform/network/curl/ResourceResponse.h:
              (WebCore::ResourceResponse::ResourceResponse):
              * platform/network/mac/AuthenticationChallenge.h: Added.
              (WebCore::AuthenticationChallenge::AuthenticationChallenge):
              (WebCore::AuthenticationChallenge::sender):
              (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
              * platform/network/mac/AuthenticationMac.mm:
              (WebCore::AuthenticationChallenge::AuthenticationChallenge):
              (WebCore::AuthenticationChallenge::platformCompare):
              * platform/network/mac/ResourceError.h: Added.
              (WebCore::ResourceError::ResourceError):
              * platform/network/mac/ResourceErrorMac.mm:
              (WebCore::ResourceError::platformLazyInit):
              (WebCore::ResourceError::platformCompare):
              * platform/network/mac/ResourceResponse.h:
              (WebCore::ResourceResponse::ResourceResponse):
              * platform/network/mac/ResourceResponseMac.mm:
              (WebCore::ResourceResponse::platformLazyInit):
              (WebCore::ResourceResponse::platformCompare):
              * platform/network/qt/AuthenticationChallenge.h: Added.
              (WebCore::AuthenticationChallenge::AuthenticationChallenge):
              * platform/network/qt/ResourceError.h: Added.
              (WebCore::ResourceError::ResourceError):
              * platform/network/qt/ResourceResponse.h:
              (WebCore::ResourceResponse::ResourceResponse):
              * xml/XSLTProcessor.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd3abd67
    • aroben@apple.com's avatar
      Fix run-webkit-tests after r30394 · 95b975d3
      aroben@apple.com authored
              * Scripts/webkitdirs.pm: Never append _debug to FindSafari's
              executable name.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95b975d3
    • aroben@apple.com's avatar
      Move plugin-related methods to WebFrameLoaderClient · 35720993
      aroben@apple.com authored
               Reviewed by Anders.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (WebFrameLoaderClient::WebFrameLoaderClient):
               (WebFrameLoaderClient::setMainDocumentError):
               (WebFrameLoaderClient::committedLoad): Added some early returns.
               (WebFrameLoaderClient::receivedData):
               (WebFrameLoaderClient::finishedLoading): Ditto.
               (getWebDataSource):
               (WebFrameLoaderClient::createPlugin):
               * WebCoreSupport/WebFrameLoaderClient.h:
               * WebFrame.cpp:
               (WebFrame::WebFramePrivate::WebFramePrivate):
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35720993
    • aroben@apple.com's avatar
      Move createFrame to WebFrameLoaderClient · db07d227
      aroben@apple.com authored
               Reviewed by Anders.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (WebFrameLoaderClient::createFrame):
               (WebFrameLoaderClient::loadURLIntoChild):
               * WebCoreSupport/WebFrameLoaderClient.h:
               * WebFrame.cpp:
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db07d227
    • aroben@apple.com's avatar
      Move progress-related methods to WebFrameLoaderClient · 4567e4f4
      aroben@apple.com authored
               Reviewed by Anders.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (WebFrameLoaderClient::postProgressStartedNotification):
               (WebFrameLoaderClient::postProgressEstimateChangedNotification):
               (WebFrameLoaderClient::postProgressFinishedNotification):
               * WebCoreSupport/WebFrameLoaderClient.h:
               * WebFrame.cpp:
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4567e4f4
    • aroben@apple.com's avatar
      Remove WebFrame::detachedFromParent1 · a8f4a38f
      aroben@apple.com authored
               This method was removed from FrameLoaderClient in r19042, but was
               never removed from WebFrame.
      
               Reviewed by Anders.
      
               * WebFrame.cpp:
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8f4a38f
    • beidson@apple.com's avatar
      Reviewed by T3h Mitz Pettel (Dan Bernstein) · 557d4895
      beidson@apple.com authored
              Layout test for already fixed bug <rdar://problem/5729445>
      
              * storage/multiple-transactions-expected.txt: Added.
              * storage/multiple-transactions.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      557d4895
    • andersca@apple.com's avatar
      Reviewed by Darin. · 6ac9e50e
      andersca@apple.com authored
              Move remaining render style objects over to start with a refcount of 1 and get
              rid of DeprecatedDataRef.
              
              * rendering/DataRef.h:
              (WebCore::DataRef::operator*):
              (WebCore::DataRef::operator->):
              * rendering/RenderStyle.h:
              * rendering/SVGRenderStyle.cpp:
              (WebCore::SVGRenderStyle::SVGRenderStyle):
              * rendering/SVGRenderStyle.h:
              (WebCore::SVGRenderStyle::create):
              (WebCore::SVGRenderStyle::copy):
              * rendering/SVGRenderStyleDefs.cpp:
              (StyleFillData::StyleFillData):
              (StyleStrokeData::StyleStrokeData):
              (StyleStopData::StyleStopData):
              (StyleTextData::StyleTextData):
              (StyleClipData::StyleClipData):
              (StyleMaskData::StyleMaskData):
              (StyleMarkerData::StyleMarkerData):
              (StyleMiscData::StyleMiscData):
              * rendering/SVGRenderStyleDefs.h:
              (WebCore::StyleFillData::create):
              (WebCore::StyleFillData::copy):
              (WebCore::StyleStrokeData::create):
              (WebCore::StyleStrokeData::copy):
              (WebCore::StyleStopData::create):
              (WebCore::StyleStopData::copy):
              (WebCore::StyleTextData::create):
              (WebCore::StyleTextData::copy):
              (WebCore::StyleClipData::create):
              (WebCore::StyleClipData::copy):
              (WebCore::StyleMaskData::create):
              (WebCore::StyleMaskData::copy):
              (WebCore::StyleMarkerData::create):
              (WebCore::StyleMarkerData::copy):
              (WebCore::StyleMiscData::create):
              (WebCore::StyleMiscData::copy):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ac9e50e
    • mrowe@apple.com's avatar
      2008-02-25 Mark Mentovai <mark@moxienet.com> · 3b6e3b06
      mrowe@apple.com authored
              Reviewed by Mark Rowe.
      
              Enable CollectorHeapIntrospector to build by itself, as well as in an AllInOneFile build.
              http://bugs.webkit.org/show_bug.cgi?id=17538
      
              * kjs/CollectorHeapIntrospector.cpp: Provide "using" declaration for
                WTF::RemoteMemoryReader.
              * kjs/collector.h: Move CollectorHeap declaration here...
              * kjs/collector.cpp: ... from here.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b6e3b06
    • mitz@apple.com's avatar
      Reviewed by Dave Hyatt. · 887f359e
      mitz@apple.com authored
              - remove file-static BidiRun variables from bidi.cpp
      
              * platform/text/BidiResolver.h:
              (WebCore::BidiResolver::): Initialize m_logicallyLastRun.
              (WebCore::BidiResolver::logicallyLastRun): Added.
              (WebCore::BidiResolver::runCount): Made unsigned.
              (WebCore::::reverseRuns): Changed ints to unsigned.
              (WebCore::::createBidiRunsForLine): Made this function set
              m_logicallyLastRun.
              * rendering/RenderBlock.h:
              * rendering/bidi.cpp:
              (WebCore::BidiState::addRun): Removed setting of sLogicallyLastBidiRun.
              (WebCore::RenderBlock::constructLine): Removed unused start parameter
              and added run count and first and last run parameters. Replaced end
              parameter with lastLine boolean and endObject pointer.
              (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added first
              and logically last run parameters.
              (WebCore::RenderBlock::computeVerticalPositionsForLine): Added firstRun
              parameter.
              (WebCore::RenderBlock::bidiReorderLine): Removed setting of static
              variables.
              (WebCore::RenderBlock::layoutInlineChildren): Changed to use BidiState
              accessors instead of file statics.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      887f359e
    • mrowe@apple.com's avatar
      2008-02-25 Rodney Dawes <dobey@wayofthemonkey.com> · 81bf662c
      mrowe@apple.com authored
              Reviewed by Jon Honeycutt.
      
              http://bugs.webkit.org/show_bug.cgi?id=16924
              Bug 16924: Shared PluginDatabase, PluginPackage, and PlugInInfoStore implementations
      
              Add PluginInfoStore.cpp and new PluginDatabase.cpp to GTK+ and Qt ports.
              Remove old PlugInInfoStoreQt.cpp as it is obsoleted by shared code.
              Add PluginInfoStore, PluginDatabase, and PluginStream files to Wx build.
              Add new PluginDatabase.cpp to Windows build.
              Add temporary stubs for new PluginDatabase and PluginPackage.
              shared classes to GTK+, Qt, and Wx ports.
              Copy PluginDatabaseWin.cpp to PluginDatabase.cpp to preserve history.
              Remove shared code from PluginDatabaseWin.cpp.
              Remove Windows-specific code from PluginDatabase.cpp.
              Use PlatformModule and PlatformFileTime instead of HMODULE and FILETIME.
              Remove extraneous PluginPackage:: from hash() class method prototype.
              Subsume storeFileVersion into PluginPackage::fetchInfo.
              Add cross-platform PlatformModuleVersion type definition.
              Use PlatformModuleVersion to store the module version.
              Rename m_fileVersion[ML]S to m_moduleVersion.
              Change compareFileVersion to use PlatformModuleVersion as the argument.
              Move PluginView::determineQuirks and m_quirks to PluginPackage.
              Updated determineQuirks for the PlatformModuleVersion.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCoreSources.bkl:
              * webcore-base.bkl:
              * WebCore.vcproj/WebCore.vcproj:
              * Platform/FileSystem.h:
              * platform/qt/PlugInInfoStoreQt.cpp:
              * platform/gtk/TemporaryLinkStubs.cpp:
              * platform/qt/TemporaryLinkStubs.cpp:
              * platform/wx/TemporaryLinkStubs.cpp:
              * plugins/PluginDatabase.cpp:
              * plugins/PluginDatabase.h:
              * plugins/win/PluginDatabaseWin.cpp:
              * plugins/PluginPackage.h:
              * plugins/win/PluginPackageWin.cpp:
              * plugins/PluginView.h:
              * plugins/win/PluginViewWin.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81bf662c
    • andersca@apple.com's avatar
      Reviewed by Darin. · 63d5b8ed
      andersca@apple.com authored
              Make more style objects start out with a refcount of 1.
              
              * rendering/RenderStyle.cpp:
              (WebCore::StyleSurroundData::StyleSurroundData):
              (WebCore::StyleBoxData::StyleBoxData):
              (WebCore::StyleVisualData::StyleVisualData):
              (WebCore::StyleBackgroundData::StyleBackgroundData):
              (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
              (WebCore::StyleRareInheritedData::StyleRareInheritedData):
              (WebCore::StyleInheritedData::StyleInheritedData):
              * rendering/RenderStyle.h:
              (WebCore::StyleSurroundData::create):
              (WebCore::StyleSurroundData::copy):
              (WebCore::StyleBoxData::create):
              (WebCore::StyleBoxData::copy):
              (WebCore::StyleVisualData::create):
              (WebCore::StyleVisualData::copy):
              (WebCore::StyleBackgroundData::create):
              (WebCore::StyleBackgroundData::copy):
              (WebCore::StyleBackgroundData::~StyleBackgroundData):
              (WebCore::StyleRareNonInheritedData::create):
              (WebCore::StyleRareNonInheritedData::copy):
              (WebCore::StyleRareInheritedData::create):
              (WebCore::StyleRareInheritedData::copy):
              (WebCore::StyleInheritedData::create):
              (WebCore::StyleInheritedData::copy):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63d5b8ed
    • andersca@apple.com's avatar
      Reviewed by Darin. · 5c3a52de
      andersca@apple.com authored
              Make some of the refcounted style objects start out with a refcount of 1.
      
              * rendering/DataRef.h:
              Make a DeprecatedDataRef class which is just a copy of the old DataRef class.
              Change DataRef to use ::create() and ::copy() instead of the constructors.
              Change DataRef's pointer to be a RefPtr instead.
      
              * rendering/RenderStyle.cpp:
              (WebCore::StyleMarqueeData::StyleMarqueeData):
              (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
              (WebCore::StyleMultiColData::StyleMultiColData):
              (WebCore::StyleTransformData::StyleTransformData):
              Start with a RefCount of 1.
              
              * rendering/RenderStyle.h:
              * rendering/SVGRenderStyle.h:
              Add ::create() and ::copy() methods. Make not yet converted classes use DeprecatedDataRef.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c3a52de
    • darin@apple.com's avatar
      WebCore: · 129cdd7b
      darin@apple.com authored
              Reviewed by Anders.
              Based on a patch by Tim Steele <timsteele41@gmail.com>.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17186
                Fragment navigation within a page permanently cancels meta refresh
      
              Test: fast/loader/meta-refresh-anchor-click.html
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::load): When load type is FrameLoadTypeRedirectWithLockedHistory,
              always do a real load. This makes sure that meta refresh loads are treated as real loads
              rather than anchor scrolls. Also tweaked formatting a bit.
              (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): This function is
              an alternate way to complete a load, so it needs to start the redirection timer if
              redirection has already been scheduled.
      
      LayoutTests:
      
              Reviewed by Anders.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=17186
                Fragment navigation within a page permanently cancels meta refresh
      
              * fast/loader/meta-refresh-anchor-click-expected.txt: Added.
              * fast/loader/meta-refresh-anchor-click.html: Added.
              * fast/loader/resources/meta-refresh-subframe.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      129cdd7b
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · 815ef2f2
      mitz@apple.com authored
              - avoid counting spaces in non-justified text
      
              * rendering/bidi.cpp:
              Removed file-static numSpaces.
              (WebCore::BidiState::addRun): Removed space counting.
              (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added space
              counting, conditional on the block having the text-align: justify
              property value.
              (WebCore::RenderBlock::bidiReorderLine): Removed initialization of
              numSpaces.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      815ef2f2
    • darin@apple.com's avatar
      Requested by Steve. · 190e4057
      darin@apple.com authored
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::ImageSource::createFrameAtIndex): Put the string into a global
              variable (because CFSTR is inefficient on Windows).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      190e4057
    • darin@apple.com's avatar
      JavaScriptCore: · c06878b4
      darin@apple.com authored
              Reviewed by Adam.
      
              * JavaScriptCore.exp: Sort the contents of this file.
      
      WebCore:
      
              Reviewed by Adam.
      
              * WebCore.base.exp: Export blankURL, and sort the file.
      
      WebKit/mac:
      
              Reviewed by Adam.
      
              * WebView/WebArchiver.mm:
              (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
              * WebView/WebFrame.mm:
              (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the
              variable name URL to avoid clashing with the renamed KURL in the future. Also use
              blankURL.
              (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto.
              (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto.
              (-[WebFrame loadHTMLString:baseURL:]): Ditto.
              (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c06878b4
    • aroben@apple.com's avatar
      MSVC build fix · f3172872
      aroben@apple.com authored
              * kjs/testkjs.cpp:
              (functionQuit): Don't add a return statement after exit(0) for MSVC.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3172872
    • aroben@apple.com's avatar
      Move many dispatch methods to WebFrameLoaderClient · b6b1ea20
      aroben@apple.com authored
               Reviewed by Sam.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
               (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
               (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
               (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
               (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
               (WebFrameLoaderClient::dispatchWillClose):
               (WebFrameLoaderClient::dispatchDidReceiveIcon):
               (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
               (WebFrameLoaderClient::dispatchDidReceiveTitle):
               (WebFrameLoaderClient::dispatchDidCommitLoad):
               (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
               (WebFrameLoaderClient::dispatchDidFinishLoad):
               (WebFrameLoaderClient::dispatchDidFirstLayout):
               (WebFrameLoaderClient::dispatchShow):
               * WebCoreSupport/WebFrameLoaderClient.h:
               * WebFrame.cpp:
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6b1ea20
    • aroben@apple.com's avatar
      Move two more methods to WebFrameLoaderClient · 2497509c
      aroben@apple.com authored
               Reviewed by Sam.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (WebFrameLoaderClient::hasFrameView):
               (WebFrame::forceLayout):
               * WebCoreSupport/WebFrameLoaderClient.h:
               * WebFrame.cpp:
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2497509c
    • hausmann@webkit.org's avatar
      3de6b94a
    • mrowe@apple.com's avatar
      2008-02-25 Johnny Ding <johnnyding.webkit@gmail.com> · 8dbab3a4
      mrowe@apple.com authored
              Reviewed by Darin Adler.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17444
      
              In HTMLTokenizer::write, the code checks 'pendingScripts.isEmpty()' to decide
              whether to save prependingSrc or not. However, in HTMLTokenizer::scriptHandler
              and HTMLTokenizer::scriptExecution, the code checks testBit:LoadingExtScript
              to decide whether to save prependingSrc or not. The later behavior is not right
              because, in scriptHandler and scriptExecution, even the pendingScripts queue is
              empty, the testBit:LoadingExtScript might be TRUE.
      
              Test: fast/tokenizer/nested-multiple-scripts.html
      
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::scriptHandler): check pendingScripts.isEmpty() instead of
              checking state.loadingExtScript().
              (WebCore::HTMLTokenizer::scriptExecution): check pendingScripts.isEmpty() instead of
              checking state.loadingExtScript().
      
      2008-02-25  Johnny Ding  <johnnyding.webkit@gmail.com>
      
              Reviewed by Darin Adler.
      
              - bug http://bugs.webkit.org/show_bug.cgi?id=17444
              Test for multiple nested scripts which are in a external script.
      
              * fast/tokenizer/nested-multiple-scripts-expected.txt: Added.
              * fast/tokenizer/nested-multiple-scripts.html: Added.
              * fast/tokenizer/resources/external-script-1.js: Added.
              * fast/tokenizer/resources/external-script-2.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dbab3a4
    • darin@apple.com's avatar
      * Scripts/do-webcore-rename: Make some updates based on a trial run of · be2b2787
      darin@apple.com authored
              the renaming script.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be2b2787
    • darin@apple.com's avatar
      * Scripts/do-webcore-rename: More renaming plans. · 77a29c5a
      darin@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77a29c5a
    • weinig@apple.com's avatar
      Reviewed by Mark Rowe. · 0e854124
      weinig@apple.com authored
              http://bugs.webkit.org/show_bug.cgi?id=17529
              Add support for reading from stdin from testkjs
      
              * kjs/testkjs.cpp:
              (GlobalObject::GlobalObject): Add readline function to global object.
              (functionReadline): Added. Reads characters from stdin until a '\n' or
              EOF is encountered. The input is returned as a String to the caller.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e854124