1. 08 Sep, 2009 38 commits
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=28987, make the Document cache the... · 959a3c5a
      hyatt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=28987, make the Document cache the page's user stylesheet in
      parsed form.  Allows the sheet to survive across destruction/re-creation of the CSSStyleSelector.
      
      Reviewed by Eric Seidel.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::CSSStyleSelector):
      * css/CSSStyleSelector.h:
      * dom/Document.cpp:
      (WebCore::Document::attach):
      (WebCore::Document::pageUserSheet):
      (WebCore::Document::clearPageUserSheet):
      (WebCore::Document::recalcStyleSelector):
      * dom/Document.h:
      * loader/PlaceholderDocument.cpp:
      (WebCore::PlaceholderDocument::attach):
      * page/Page.cpp:
      (WebCore::Page::userStyleSheetLocationChanged):
      * page/Settings.cpp:
      (WebCore::Settings::setUserStyleSheetLocation):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      959a3c5a
    • kenneth@webkit.org's avatar
      Unreviewed buildfix. · eb68b32f
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
      Fix Qt build after 48167, by adding the new cpp/h files
      added to WebCore.gypi to WebCore.pro as well.
      
      * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb68b32f
    • kenneth@webkit.org's avatar
      Unreviewed build fix. · d397bade
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
      Potential build fix for Qt 4.5
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::mousePressEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d397bade
    • xan@webkit.org's avatar
      2009-09-08 Xan Lopez <xlopez@igalia.com> · 6c28bbb6
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              should not pass URI fragments to libsoup
              https://bugs.webkit.org/show_bug.cgi?id=28687
      
              Strip the fragment from the URI before passing it to soup, since
              it forwards it to servers in some cases (like when using a proxy)
              which confuses them and makes them return 403/404.
      
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::startHttp):
              (WebCore::):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c28bbb6
    • kenneth@webkit.org's avatar
      WebCore: Add QGraphicsScene events support to the Qt platform events. · f4218548
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
      Reviewed by Simon Hausmann.
      
      * platform/PlatformMouseEvent.h:
      * platform/PlatformWheelEvent.h:
      * platform/qt/PlatformMouseEventQt.cpp:
      (WebCore::PlatformMouseEvent::PlatformMouseEvent):
      * platform/qt/WheelEventQt.cpp:
      (WebCore::PlatformWheelEvent::applyDelta):
      (WebCore::PlatformWheelEvent::PlatformWheelEvent):
      
      WebKit/qt: Add support for handling QGraphicsScene events.
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
      Reviewed by Simon Hausmann.
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::mouseMoveEvent):
      (QWebPagePrivate::mousePressEvent):
      (QWebPagePrivate::mouseDoubleClickEvent):
      (QWebPagePrivate::mouseTripleClickEvent):
      (QWebPagePrivate::handleClipboard):
      (QWebPagePrivate::mouseReleaseEvent):
      (QWebPagePrivate::wheelEvent):
      (QWebPagePrivate::dragEnterEvent):
      (QWebPagePrivate::dragLeaveEvent):
      (QWebPagePrivate::dragMoveEvent):
      (QWebPagePrivate::dropEvent):
      (QWebPage::event):
      * Api/qwebpage_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4218548
    • weinig@apple.com's avatar
      Update Security Group Members list. · 78268e3b
      weinig@apple.com authored
      Reviewed by Adele Peterson.
      
      * security/security-group-members.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78268e3b
    • eric@webkit.org's avatar
      2009-09-08 Michael Nordman <michaeln@google.com> · abae25d0
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Chromium] Cleanup: remove a few deprecated methods.
              https://bugs.webkit.org/show_bug.cgi?id=28960
      
              No new tests, just syntactic sugar.
      
              * platform/network/chromium/ResourceRequest.h:
              * platform/network/chromium/ResourceResponse.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abae25d0
    • eric@webkit.org's avatar
      2009-09-08 Yongjun Zhang <yongjun.zhang@nokia.com> · b0a0204d
      eric@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              https://bugs.webkit.org/show_bug.cgi?id=28981
      
              [Qt] make npapi.h compile in winscw compiler.
      
              Add XP_SYMBIAN macro to identify Symbian OS; this macro should be used for Symbian
              specific changes in npapi.h.
              Undefine XP_WIN when building for Symbian to avoid including Windows specific code.
      
              * bridge/npapi.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0a0204d
    • kov@webkit.org's avatar
      2009-09-08 Priit Laes <plaes@plaes.org> · 284d2c03
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Fix up erroneus 'Since: @version@' tags in documentation.
      
              * webkit/webkitwebdatasource.cpp:
              * webkit/webkitwebresource.cpp:
              (webkit_web_resource_class_init):
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
              * webkit/webkitwebview.cpp:
              (webkit_web_view_class_init):
              * webkit/webkitwebwindowfeatures.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      284d2c03
    • oliver@apple.com's avatar
      Web Inspector assertion failure related to marking · 0347b6a7
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=28997
      
      Reviewed by Geoff Garen.
      
      When wrapping the callback the JSInspectorCallbackWrapper creator was using
      inheritorID for the prototype structure which is unsafe for anything other
      than a pure JS object.  Instead we now create a new structure, which while
      inefficient is not problematic as this code is not hit frequently.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0347b6a7
    • dglazkov@chromium.org's avatar
      2009-09-08 Kelly Norton <knorton@google.com> · 4fa9a569
      dglazkov@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Add missing extension to the file entry in WebCore.vcproj.
      
              * WebCore.vcproj/WebCore.vcproj: Added "cpp".
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fa9a569
    • eric@webkit.org's avatar
      2009-09-08 Cameron McCormack <cam@mcc.id.au> · 9a027078
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Fix DumpRenderTree build from clean tree on Tiger
              https://bugs.webkit.org/show_bug.cgi?id=28927
      
              * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
              DerivedSources/DumpRenderTree directory exists when
              building on Tiger.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a027078
    • jianli@chromium.org's avatar
      WebCore: dataTransfer.types() should not return Files if file list is empty in the clipboard. · 53f88072
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28891
      
      Reviewed by David Levin.
      
      We change the behavior to handle the empty file list in order to match the spec.
      
      Tested by clipboard-file-access.html.
      
      * platform/mac/ClipboardMac.mm:
      (WebCore::addHTMLClipboardTypesForCocoaType):
      (WebCore::ClipboardMac::types):
      
      LayoutTests: dataTransfer.types() should not return Files if file list is empty in the clipboard.
      https://bugs.webkit.org/show_bug.cgi?id=28891
      
      Reviewed by David Levin.
      
      Update the test script and expected result to reflect the behavior change.
      
      * http/tests/security/clipboard/clipboard-file-access-expected.txt:
      * http/tests/security/clipboard/resources/clipboard-file-access.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53f88072
    • japhet@chromium.org's avatar
      2009-09-08 Steve VanDeBogart <vandebo@chromium.org> · e0c155f1
      japhet@chromium.org authored
              Reviewed by Eric Seidel.
      
              Handle middle click in Chromium like QT
              https://bugs.webkit.org/show_bug.cgi?id=28696
      
              Tested by middle-click-onpaste.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0c155f1
    • eric@webkit.org's avatar
      2009-09-08 Kelly Norton <knorton@google.com> · 80bd7d6d
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              WebInspector: Adds a timeline agent to InspectorController that collects
              high-level timing data about event dispatch, layout, painting and HTML
              parsing and makes it available to Inspector.
              https://bugs.webkit.org/show_bug.cgi?id=25503
      
              * WebCore.gypi:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/Document.cpp:
              (WebCore::Document::recalcStyle):
              * dom/Document.h:
              (WebCore::Document::inspectorTimelineAgent):
              * dom/Node.cpp:
              (WebCore::Node::dispatchGenericEvent):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::write):
              * inspector/DOMDispatchTimelineItem.cpp: Added.
              (WebCore::DOMDispatchTimelineItem::DOMDispatchTimelineItem):
              (WebCore::DOMDispatchTimelineItem::convertToScriptObject):
              * inspector/DOMDispatchTimelineItem.h: Added.
              (WebCore::DOMDispatchTimelineItem::~DOMDispatchTimelineItem):
              * inspector/InspectorBackend.cpp:
              (WebCore::InspectorBackend::enableTimeline):
              (WebCore::InspectorBackend::disableTimeline):
              (WebCore::InspectorBackend::timelineEnabled):
              * inspector/InspectorBackend.h:
              * inspector/InspectorBackend.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setFrontendProxyObject):
              (WebCore::InspectorController::close):
              (WebCore::InspectorController::resetScriptObjects):
              (WebCore::InspectorController::enableTimeline):
              (WebCore::InspectorController::disableTimeline):
              (WebCore::InspectorController::timelineEnabled):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::timelineAgent):
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::timelineWasEnabled):
              (WebCore::InspectorFrontend::timelineWasDisabled):
              (WebCore::InspectorFrontend::addItemToTimeline):
              * inspector/InspectorFrontend.h:
              * inspector/InspectorTimelineAgent.cpp: Added.
              (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
              (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
              (WebCore::InspectorTimelineAgent::willDispatchDOMEvent):
              (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
              (WebCore::InspectorTimelineAgent::willLayout):
              (WebCore::InspectorTimelineAgent::didLayout):
              (WebCore::InspectorTimelineAgent::willRecalculateStyle):
              (WebCore::InspectorTimelineAgent::didRecalculateStyle):
              (WebCore::InspectorTimelineAgent::willPaint):
              (WebCore::InspectorTimelineAgent::didPaint):
              (WebCore::InspectorTimelineAgent::willWriteHTML):
              (WebCore::InspectorTimelineAgent::didWriteHTML):
              (WebCore::InspectorTimelineAgent::reset):
              (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
              (WebCore::InspectorTimelineAgent::currentTimeInMilliseconds):
              (WebCore::InspectorTimelineAgent::sessionTimeInMilliseconds):
              * inspector/InspectorTimelineAgent.h: Added.
              * inspector/TimelineItem.cpp: Added.
              (WebCore::TimelineItem::TimelineItem):
              (WebCore::TimelineItem::addToTimeline):
              (WebCore::TimelineItem::convertToScriptObject):
              (WebCore::TimelineItem::convertChildrenToScriptArray):
              (WebCore::TimelineItem::addChildItem):
              * inspector/TimelineItem.h: Added.
              (WebCore::):
              (WebCore::TimelineItem::~TimelineItem):
              (WebCore::TimelineItem::previous):
              (WebCore::TimelineItem::releasePrevious):
              (WebCore::TimelineItem::setEndTime):
              (WebCore::TimelineItem::type):
              * inspector/front-end/TimelineAgent.js: Added.
              (WebInspector.TimelineAgent):
              (WebInspector.addItemToTimeline):
              (WebInspector.timelineWasEnabled):
              (WebInspector.timelineWasDisabled):
              * inspector/front-end/inspector.html:
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
              (WebCore::FrameView::paintContents):
              * page/FrameView.h:
              (WebCore::FrameView::inspectorTimelineAgent):
              * page/Page.cpp:
              (WebCore::Page::inspectorTimelineAgent):
              * page/Page.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80bd7d6d
    • eric@webkit.org's avatar
      2009-09-08 Benjamin Poulain <benjamin.poulain@nokia.com> · 18a00fea
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              https://bugs.webkit.org/show_bug.cgi?id=29007
              Add a test for the signal QWebFrame::javaScriptWindowObjectCleared()
      
              * tests/qwebframe/tst_qwebframe.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18a00fea
    • eric@webkit.org's avatar
      2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 56657906
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Fix unused variable warnings
              https://bugs.webkit.org/show_bug.cgi?id=29018
      
              No functional change, no tests.
      
              * history/qt/HistoryItemQt.cpp:
              (WebCore::HistoryItem::restoreState):
              * platform/graphics/qt/ImageBufferQt.cpp:
              (WebCore::putImageData):
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::paintMenuList):
      2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Fix unused variable warnings
              https://bugs.webkit.org/show_bug.cgi?id=29018
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::keyPressEvent):
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::startDownload):
              (WebCore::FrameLoaderClientQt::createFrame):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56657906
    • eric@webkit.org's avatar
      2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 4a2c2a01
      eric@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              [Qt] Use the declaration order in initializer lists
              https://bugs.webkit.org/show_bug.cgi?id=29017
      
              No functional change, no new tests.
      
              * platform/graphics/qt/FontCacheQt.cpp:
              (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
              * platform/network/qt/QNetworkReplyHandler.cpp:
              (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
      2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Ariya Hidayat.
      
              [Qt] Use the declaration order in initializer lists
              https://bugs.webkit.org/show_bug.cgi?id=29017
      
              * Api/qwebframe_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a2c2a01
    • eric@webkit.org's avatar
      2009-09-08 Kent Tamura <tkent@chromium.org> · 42558348
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Tests for ValidityState::typeMismatch() for <input type=number>.
              https://bugs.webkit.org/show_bug.cgi?id=28934
      
              * fast/forms/ValidityState-typeMismatch-number-expected.txt: Added.
              * fast/forms/ValidityState-typeMismatch-number.html: Added.
              * fast/forms/resources/ValidityState-typeMismatch-number.js: Added.
      2009-09-08  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Implement ValidityState::typeMismatch() for <input type=number>.
              https://bugs.webkit.org/show_bug.cgi?id=28934
      
              Test: fast/forms/ValidityState-typeMismatch-number.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::formStringToDouble):
              * html/HTMLInputElement.h:
              * html/ValidityState.cpp:
              (WebCore::ValidityState::typeMismatch):
              * html/ValidityState.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42558348
    • kevino@webkit.org's avatar
      wx build fix after introduction of platform/mock directory. · ec97d605
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec97d605
    • eric@webkit.org's avatar
      2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 943227cf
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Build fix when USE(LOCKFREE_THREADSAFESHARED) is not defined
              https://bugs.webkit.org/show_bug.cgi?id=29011
      
              * wtf/Threading.h: Use LOCKFREE_THREADSAFESHARED guard for
              atomicIncrement and atomicDecrement
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      943227cf
    • yael.aharon@nokia.com's avatar
      Unreviewed. · 15d095e3
      yael.aharon@nokia.com authored
      Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-08
      Add myself to list of committers.
      
      * Scripts/modules/committers.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15d095e3
    • laszlo.1.gombos@nokia.com's avatar
      2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com> · e34f3a0a
      laszlo.1.gombos@nokia.com authored
              Unreviewed.
      
              Add myself to list of committers.
      
              * Scripts/modules/committers.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e34f3a0a
    • eric@webkit.org's avatar
      2009-09-08 Cameron McCormack <cam@mcc.id.au> · f6e89491
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              prepare-ChangeLog too chatty on file additions
              https://bugs.webkit.org/show_bug.cgi?id=29019
      
              * Scripts/prepare-ChangeLog: Omit description of added properties
              on newly added files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6e89491
    • kov@webkit.org's avatar
      2009-09-08 Andras Becsi <becsi.andras@stud.u-szeged.hu> · 815a1b7d
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [Gtk] Another attempt of a buildfix.
      
              * GNUmakefile.am: Modified. Remove some extra IDL files added in r48153.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      815a1b7d
    • eric@webkit.org's avatar
      2009-09-08 Steve Block <steveblock@google.com> · ef745148
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Adds a LayoutTestController method to set the permission state for Geolocation.
              This is required to use the mock Geolocation service for testing.
              https://bugs.webkit.org/show_bug.cgi?id=29027
      
              * fast/dom/Geolocation/resources/permission-denied.js: Added. Tests that the error callback is invoked with a permission error code when Geolocation permission is denied and the Geolocation service provides a good position fix.
              * fast/dom/Geolocation/permission-denied-expected.txt: Added.  Expected result for above test.
              * fast/dom/Geolocation/permission-denied.html: Added. Wrapper for above test.
              * fast/dom/Geolocation/resources/success.js: Added. Tests that the success callback is invoked when the Geolocation service provides a good position fix.
              * fast/dom/Geolocation/success-expected.txt: Added. Expected result for above test.
              * fast/dom/Geolocation/success.html: Added. Wrapper for above test.
              * platform/gtk/Skipped:
      2009-09-08  Steve Block  <steveblock@google.com>
      
              Reviewed by Adam Barth.
      
              Adds a LayoutTestController method to set the permission state for Geolocation.
              This is required to use the mock Geolocation service for testing.
              https://bugs.webkit.org/show_bug.cgi?id=29027
      
              * DumpRenderTree/LayoutTestController.cpp: Modified.
              (setDatabaseQuotaCallback): Modified. Style fix.
              (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
              (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
              * DumpRenderTree/LayoutTestController.h: Modified.
              (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
              (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
              (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
              * DumpRenderTree/mac/UIDelegate.mm: Modified.
              (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef745148
    • zoltan@webkit.org's avatar
      2009-09-07 Zoltan Horvath <zoltan@webkit.org> · fa418157
      zoltan@webkit.org authored
              Reviewed by Darin Adler.
      
              Allow custom memory allocation control in Yarr's RegexInterpreter
              https://bugs.webkit.org/show_bug.cgi?id=29025
      
              Inherits RegexInterpreter classes from FastAllocBase (bug #20422), which has
              been instantiated by 'new':
      
              class ByteDisjunction
              -> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1462
      
              struct BytecodePattern
              -> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1279
      
              * yarr/RegexInterpreter.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa418157
    • hausmann@webkit.org's avatar
      WebCore: [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack. · d7adca36
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28865
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
      Reviewed by Simon Hausmann.
      
      Save the QCursor as a property in WidgetQt::setCursor
      and actually change the cursor in QWebView::event() by making use
      of the QEvent::DynamicPropertyChange event type.
      When unsetCursor() is called on the QWidget we can fallback to
      the cursor set by WebCore.
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> and
               Antonio Gomes <antonio.gomes@openbossa.org> on 2009-09-07
      
      * platform/qt/WidgetQt.cpp:
      (WebCore::Widget::setCursor):
      
      WebKit/qt: [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.
      https://bugs.webkit.org/show_bug.cgi?id=28865
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
      Reviewed by Simon Hausmann.
      
      Clean up the unserCursor hack to use the QCursor set
      as a property of the QWidget by WebCore::WidgetQt.
      
      Remove all code that are no longer necessary for getting
      cursor change events.
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> and
               Antonio Gomes <antonio.gomes@openbossa.org> on 2009-09-07
      
      * Api/qwebpage.cpp:
      * Api/qwebpage_p.h:
      * Api/qwebview.cpp:
      (QWebViewPrivate::QWebViewPrivate):
      (QWebView::event):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7adca36
    • kov@webkit.org's avatar
      2009-09-08 Andras Becsi <becsi.andras@stud.u-szeged.hu> · 84a00b64
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [Gtk] Buildfix for build error introduced in r48150.
      
              * GNUmakefile.am: Modified. Added missing IDL files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84a00b64
    • vestbo@webkit.org's avatar
      [Qt] Buildfix. Build error caused by r48150. · fea4486b
      vestbo@webkit.org authored
      Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-08
      Reviewed by Tor Arne Vestbø.
      
      * WebCore.pro: missing IDL files added
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fea4486b
    • laszlo.1.gombos@nokia.com's avatar
      2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com> · abcb139c
      laszlo.1.gombos@nokia.com authored
              Reviewed by Simon Hausmann.
      
              [Qt] QtWebKit single API to enable persistency
              https://bugs.webkit.org/show_bug.cgi?id=28682
      
              Disable LocalStorage, ApplicationCache, HTML5 offline storage by
              default.
      
              If persistency is enabled the default directory for LocalStorage and
              ApplicationCache is now based on QDesktopServices::DataLocation and not
              QDesktopServices::CacheLocation (as it is expected to keep this data
              around after a reboot).
      
              If persistency is enabled initialize HTML5 offline storage as well - this
              fixed offline Storage for QtLauncher.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abcb139c
    • cmarrin@apple.com's avatar
      Update Canvas 3D implementation to match spec · 24616126
      cmarrin@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=29010
      
              This adds several new CanvasXXXArray classes each of which has a custom constructor
              and custom getters and setters. Also changed CanvasRenderingContext3D and GraphicsContext3D
              to match the new and changed API.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24616126
    • vestbo@webkit.org's avatar
      [Qt] Add expected files for new tests since we pass them. · 0baa0f1e
      vestbo@webkit.org authored
      Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-08
      Reviewed by Tor Arne Vestbø.
      
      * platform/qt/fast/reflections/abs-position-in-reflection-expected.txt: Added.
      * platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0baa0f1e
    • vestbo@webkit.org's avatar
      Refactor --strict switch to --ignore-metrics and correct the · 58bbbee4
      vestbo@webkit.org authored
      implementation to make the feature usable on all platforms.
      https://bugs.webkit.org/show_bug.cgi?id=28907
      
      Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-07
      Reviewed by Tor Arne Vestbø.
      
      run-webkit-tests --ignore-metrics strips the font related metrics from
      the actual and expected data before comparing them.
      In this way the render trees can be checked for obvious differences but
      a successful test implies by no means that the layout is actually correct.
      
      * Scripts/run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58bbbee4
    • hamaji@chromium.org's avatar
      Unreviewed. · 36b56008
      hamaji@chromium.org authored
      Change my mail address on the list of committers.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36b56008
    • hausmann@webkit.org's avatar
      Make m_windowVisible more consistent with the actual visibility of the inspector. · f737480a
      hausmann@webkit.org authored
      Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-08
      Reviewed by Timothy Hatcher.
      
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::setWindowVisible):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f737480a
    • abarth@webkit.org's avatar
      2009-09-07 Adam Barth <abarth@webkit.org> · bbdd36d5
      abarth@webkit.org authored
              Unreviewed speculative build fix for Snow Leopard.
      
              * platform/GeolocationService.cpp:
              (WebCore::createGeolocationServiceNull):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbdd36d5
    • abarth@webkit.org's avatar
      2009-09-07 Steve Block <steveblock@google.com> · 3ba9b43d
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              Adds a mock Geolocation service. This will be used to provide predictable behavior of the
              Geolocation API for use in LayoutTests. Later changes will integrate the the mock
              Geolocation service with DumpRenderTree.
              https://bugs.webkit.org/show_bug.cgi?id=28264
      
              * fast/dom/Geolocation/resources/error.js: Added. Tests that the error callback is called when the service reports an error.
              * fast/dom/Geolocation/error-expected.txt: Added. Expected result for above test.
              * fast/dom/Geolocation/error.html: Added. Wrapper for above test.
      2009-09-07  Steve Block  <steveblock@google.com>
      
              Reviewed by Adam Barth.
      
              Adds a mock Geolocation service. This will be used to provide predictable behavior of the
              Geolocation API for use in LayoutTests. Later changes will integrate the the mock
              Geolocation service with DumpRenderTree.
              https://bugs.webkit.org/show_bug.cgi?id=28264
      
              The mock Geolocation service returns a fixed position or error. This position or error can be
              set through static methods on the GeolocationService class. The position or error is shared
              between all instances of the mock Geolocation service.
      
              Implementation details.
              The GeolocationService object maintains a pointer to a factory function which it uses to create
              Geolocation service instances. Each platform implementing Geolocation sets this pointer
              to the factory function for their platform's implementation. When the mock Geolocation service
              is activated, the factory function pointer is reset to the factory function for the mock service.
      
              Test: fast/dom/Geolocation/error.html
      
              * WebCore.base.exp: Modified. Exports GeolocationServiceMock methods.
              * GNUMakefile.am: Modified. Added GeolocationServiceMock files.
              * WebCore.gypi: Modified. Added GeolocationServiceMock files.
              * WebCore.pro: Modified. Added GeolocationServiceMock files.
              * WebCore.vcproj/WebCore.vcproj: Modified. Added GeolocationServiceMock files.
              * WebCore.vcproj/WebCoreCommon.vsprops: Modified. Added mock directory to includes.
              * WebCore.xcodeproj/project.pbxproj: Modified. Added GeolocationServiceMock files and exports some headers.
              * WebCoreSources.bkl: Modified. Added GeolocationServiceMock files.
              * page/ChromeClient.h: Modified. Fixed comment.
              * page/Geolocation.cpp: Modified.
              (WebCore::Geolocation::setIsAllowed): Modified. Fixed error string.
              * platform/GeolocationService.cpp: Modified.
              (WebCore::createGeolocationServiceNull): Added. Returns null in place of a Geolocation service. Used to avoid link errors on platforms where Geolocation is not implemented.
              (WebCore::GeolocationService::create): Added. Uses the factory function pointer to create a Geolocation service implementation.
              (WebCore::GeolocationService::useMock): Added. Configures the GeolocationServie to use the mock implementation.
              * platform/GeolocationService.h: Modified.
              * platform/mock: Added.
              * platform/mock/GeolocationServiceMock.cpp: Added.
              (WebCore::GeolocationServiceMock::create): Added. Creates a GeolocationServiceMock object.
              (WebCore::GeolocationServiceMock::GeolocationServiceMock): Added. Constructor.
              (WebCore::GeolocationServiceMock::~GeolocationServiceMock): Added. Destructor.
              (WebCore::GeolocationServiceMock::setPosition): Added. Sets the position that will be returned by the object.
              (WebCore::GeolocationServiceMock::setError): Added. Sets the error that will be returned by the object.
              (WebCore::GeolocationServiceMock::startUpdating): Added. GeolocationService implementation. Starts the service.
              (WebCore::GeolocationServiceMock::stopUpdating): Added. GeolocationService implementation. Stops the service.
              (WebCore::GeolocationServiceMock::timerFired): Added. Used to provide an asynchronous callback when the service is started.
              (WebCore::GeolocationServiceMock::makeGeolocationCallbackFromAllInstances): Added. Used to call back when the position or error is updated.
              (WebCore::GeolocationServiceMock::makeGeolocationCallback): Added. Used to call back when the service starts.
              (WebCore::GeolocationServiceMock::initStatics): Added. Initializes statics members with constructors.
              (WebCore::GeolocationServiceMock::cleanUpStatics): Added. Cleans up static members with constructors.
              * platform/mock/GeolocationServiceMock.h: Added.
              (WebCore::GeolocationServiceMock::lastPosition): Added. Returns the fixed position.
              (WebCore::GeolocationServiceMock::lastError): Added. Returns the fixed error.
              * platform/gtk/GeolocationServiceGtk.cpp: Modified.
              (WebCore::GeolocationServiceGtk::create): Added. Creates an instance of GeolocationServiceGtk.
              * platform/gtk/GeolocationServiceGtk.h: Modified.
              * platform/mac/GeolocationServiceMac.h: Modified.
              * platform/mac/GeolocationServiceMac.mm: Modified.
              (WebCore::GeolocationServiceMac::create): Added. Creates an instance of GeolocationServiceMac.
      2009-09-07  Steve Block  <steveblock@google.com>
      
              Reviewed by Adam Barth.
      
              Adds a mock Geolocation service. This will be used to provide predictable behavior of the
              Geolocation API for use in LayoutTests. Later changes will integrate the the mock
              Geolocation service with DumpRenderTree.
              https://bugs.webkit.org/show_bug.cgi?id=28264
      
              * WebKit.xcodeproj/project.pbxproj: Modified. Adds WebGeolocationMock.
      2009-09-07  Steve Block  <steveblock@google.com>
      
              Reviewed by Adam Barth.
      
              Adds a mock Geolocation service. This will be used to provide predictable behavior of the
              Geolocation API for use in LayoutTests. Later changes will integrate the the mock
              Geolocation service with DumpRenderTree.
              https://bugs.webkit.org/show_bug.cgi?id=28264
      
              * WebCoreSupport/WebGeolocationMockPrivate.h: Added.
              * WebCoreSupport/WebGeolocationMock.mm: Added.
              (+[WebGeolocationMock setError:code:]): Added. Used by DumpRender tree to configure the mock Geolocation service.
              (+[WebGeolocationMock setPosition:latitude:longitude:accuracy:]): Added. Used by DumpRender tree to configure the mock Geolocation service.
              * WebKit.exp: Modified. Exports WebGeolocationMock.
      2009-09-07  Steve Block  <steveblock@google.com>
      
              Reviewed by Adam Barth.
      
              Adds a mock Geolocation service. This will be used to provide predictable behavior of the
              Geolocation API for use in LayoutTests. Later changes will integrate the the mock
              Geolocation service with DumpRenderTree.
              https://bugs.webkit.org/show_bug.cgi?id=28264
      
              * DumpRenderTree/LayoutTestController.cpp: Modified.
              (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
              (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
              (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
              * DumpRenderTree/LayoutTestController.h: Modified.
              * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
              (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
              (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ba9b43d
  2. 07 Sep, 2009 2 commits
    • jorlow@chromium.org's avatar
      2009-09-07 Jeremy Orlow <jorlow@chromium.org> · cf79a867
      jorlow@chromium.org authored
              Reviewed by Eric Seidel.
      
              Clean up localStorage.clear() layout test.
              https://bugs.webkit.org/show_bug.cgi?id=28939
      
              This is the first step of https://bugs.webkit.org/show_bug.cgi?id=27897 which
              is a pretty major cleanup of all the dom storage layout tests.  I'm just
              changing this one to begin with to get buy-in on the approach.
      
              This also adds a new method to the fast/js/js-test-pre.js that runs a command
              and prints it to the screen.  This should really help with making the output of
              the tests readable without looking at the source code.
      
              * fast/js/resources/js-test-pre.js:
              (tryAndLog): Runs a command and logs it to the screen.
              * storage/domstorage/localstorage/clear-expected.txt:
              * storage/domstorage/localstorage/clear.html:
              * storage/domstorage/resources: Added.
              * storage/domstorage/resources/clear.js: Added.
                  The meat of the test is now in this file.
              * storage/domstorage/sessionstorage/clear-expected.txt:
              * storage/domstorage/sessionstorage/clear.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf79a867
    • abarth@webkit.org's avatar
      2009-09-07 Adam Barth <abarth@webkit.org> · 6c50c495
      abarth@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              https://bugs.webkit.org/show_bug.cgi?id=28985
      
              We need to be slightly more careful about how we pick up a script
              execution context.  In particular, we were getting the wrong document
              for frames that had been navigated somewhere else.
      
              In the long term, we should think about a better algorithm for
              computing the script context.
      
              Fixes LayoutTests/http/tests/xmlhttprequest/detaching-frame-2.html
      
              * bindings/v8/V8Proxy.cpp:
              (WebCore::V8Proxy::retrieveFrame):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c50c495