GitLab

Unreviewed. Fix test after r146938. Since CSS Exclusions is still an experimental feature, shape-inside-on-nested-container-with-unresolved-height.html
test should enable CSS Exclusions for the testrunners first.  

* fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Set CSSExclisions enabled for DRT/WTR.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Marked compositing/rtl/rtl-iframe-* tests as ImageOnlyFailure instead of Failure.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=39889

Reviewed by Anders Carlsson.

This must be tested manually. See the issue for details.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext):
Revise the Windows implementation of the PluginView class
paintWindowedPluginIntoContext to use the containing window
position when computing the plugin's position for printing.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113238

Reviewed by James Robinson.

Source/WebCore:

Added NotCompositedForNoVisibleContent in ViewportConstrainedNotCompositedReason and set it in RLC.

Test: compositing/layer-creation/fixed-position-no-content-scroll-reason.html

* rendering/RenderLayer.h: Add NotCompositedForNoVisibleContent.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Set NotCompositedForNoVisibleContent reason when the fixed position layer has no visible content.

LayoutTests:

* compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt: Added.
* compositing/layer-creation/fixed-position-no-content-scroll-reason.html: Copied from LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html. Test case for the bug.
* compositing/layer-creation/fixed-position-in-view-dynamic.html: Set background of fixed layer to distinguish out-of-view case from no-content case.
* compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Ditto.
* compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html: Ditto.
* platform/chromium/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
* platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Marked compositing/iframes/scrolling-iframe.html flaky on all platforms.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113255

Reviewed by Julien Chaffraix.

When we decide what should be the radius of a circle, we should choose the smallest available space. For instance when the
width or height is not resolvable for the circle we should not have a radius for it. This change modifies the behavior to
use the smaller available space, so we won't render unnecessary circle shapes.

Source/WebCore: 

Test: fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html

* rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape):

LayoutTests: 

* fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://webkit.org/b/65829
rdar://problem/11271238

Reviewed by Joseph Pecoraro.

* inspector/InjectedScriptSource.js:
(InjectedScript.prototype._evaluateOn): Don't use 'eval' parameter (it isn't
allowed in strict mode). Swap window.eval with our known eval instead.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113337

Reviewed by Abhishek Arya and Alexey Proskuryakov.

Source/WebCore: 

Use RefPtr instead of raw pointer in m_associatedFormControls.

* dom/Document.cpp:
(WebCore::Document::didAssociateFormControlsTimerFired):
* dom/Document.h:
(Document):
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::didAssociateFormControls):
* page/ChromeClient.h:
(WebCore::ChromeClient::didAssociateFormControls):

Source/WebKit/chromium: 

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::didAssociateFormControls):
* src/ChromeClientImpl.h:
(ChromeClientImpl):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113335

Patch by Mike Lattanzio <mlattanzio@blackberry.com> on 2013-03-26
Reviewed by Rob Buis.

PR# 280374
Include accelerated compositing layers in screen captures.
Reviewed Internally By: Jakob Petsovits

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::drawContents):
* Api/BackingStore_p.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113144

Reviewed by Geoffrey Garen.
        
Forgot to include Geoff's requested change in the original commit.

* profiler/ProfilerDatabase.cpp:
(Profiler):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113144

Source/JavaScriptCore: 

Reviewed by Geoffrey Garen.
        
Added the ability to save profiler output with JSC_enableProfiler=true. It will save it
to the current directory, or JSC_PROFILER_PATH if the latter was specified.
        
This works by saving the Profiler::Database either when it is destroyed or atexit(),
whichever happens first.
        
This allows use of the profiler from any WebKit client.

* jsc.cpp:
(jscmain):
* profiler/ProfilerDatabase.cpp:
(Profiler):
(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::~Database):
(JSC::Profiler::Database::registerToSaveAtExit):
(JSC::Profiler::Database::addDatabaseToAtExit):
(JSC::Profiler::Database::removeDatabaseFromAtExit):
(JSC::Profiler::Database::performAtExitSave):
(JSC::Profiler::Database::removeFirstAtExitDatabase):
(JSC::Profiler::Database::atExitCallback):
* profiler/ProfilerDatabase.h:
(JSC::Profiler::Database::databaseID):
(Database):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):

Source/WTF: 

Reviewed by Geoffrey Garen.
        
I got tired of the fact that getpid(2) is not a syscall on Windows (unless you do
_getpid() I believe), so I wrote a header that abstracts it. I also changed existing
code that uses getpid() to use WTF::getCurrentProcessID().

* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::dumpProfile):
* wtf/ProcessID.h: Added.
(WTF):
(WTF::getCurrentProcessID):
* wtf/text/StringImpl.cpp:
(WTF::StringStats::printStats):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        <rdar://problem/13194263> Crashes in NetworkProcess due to threading issues
        https://bugs.webkit.org/show_bug.cgi?id=113256

        Reviewed by Mark Rowe.

        * NetworkProcess/NetworkResourceLoader.h: Added some forgotten OVERRIDEs.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=109094

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-26
Reviewed by Rob Buis.

Internally Reviewed by Jakob Petsovits.

Mouse content position should be in document coordinate.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateCursor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        https://bugs.webkit.org/show_bug.cgi?id=113256

        Reviewed by Brady Eidson.

        Added a new code path in ResourceHandle/ResourceHandleClient that doesn't need
        blocking calls. Implemented it for NSURLConnection by changing NSOperationQueue
        version to forward calls to main thread.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113258
<rdar://problem/13492038>

Reviewed by Simon Fraser.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
Only start the zero-delay timer if it's not already active.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubber stamped by James Robinson.

* fast/dom/34176.html: Convert from little endian UTF-16 to UTF-8
to make git diff happy.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113250

Reviewed by Ojan Vafai.

The different filters for showing results are only used for layout
tests, otherwise, we show everything.

Change the defaults to false (what layout tests used), and only
look at the values when viewing layout tests.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(htmlForTestsWithExpectationsButNoFailures):
(shouldHideTest):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=109507

Unreviewed rebaseline.

* platform/chromium-linux-x86/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Removed.
* platform/chromium-linux/compositing/overflow/composited-scrolling-paint-phases-expected.txt:
* platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
* platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
* platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
* platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/chromium-mac/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/chromium-win/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
* platform/chromium/TestExpectations:
* platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
* platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
* platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
* platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
* platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
* platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
* platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
* platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
* platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
* platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113253

Reviewed by James Robinson.

Source/WebCore:

Convert scrollAnimatorEnabled into an autogenerated setting. This involves renaming
the setter from setEnableScrollAnimator(bool) to setScrollAnimatorEnabled(bool) and
updating the callers. I didn't change any WebKit API methods.

Also remove the code in InternalSettings since it's never used and will now be
autogenerated with proper resetting code.

No new tests, this is a refactor and should compile.

* page/Settings.cpp:
(WebCore::Settings::Settings): Remove code that is now autogenerated.
* page/Settings.h:
(Settings): Remove code that is now autogenerated.
* page/Settings.in: Add entry for scrollAnimatorEnabled.
* testing/InternalSettings.cpp: Remove unused code.
* testing/InternalSettings.h: Remove unused code.
* testing/InternalSettings.idl: Remove unused code.

Source/WebKit/chromium:

* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setEnableScrollAnimator): Update call to WebCore to use setScrollAnimatorEnabled(bool).

Source/WebKit/gtk:

* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings): Update call to WebCore to use setScrollAnimatorEnabled(bool).
(webkit_web_view_settings_notify): Update call to WebCore to use setScrollAnimatorEnabled(bool).

Source/WebKit/qt:

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply): Update call to WebCore to use setScrollAnimatorEnabled(bool).

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout): Update call to WebCore to use setScrollAnimatorEnabled(bool).
(WebKit::WebPage::updatePreferences): Update call to WebCore to use setScrollAnimatorEnabled(bool).


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

and we share this file with them via html5lib.

* html5lib/resources/template.dat:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113334

Patch by Joe Mason <jmason@blackberry.com> on 2013-03-26
Reviewed by Rob Buis.

RIM PR 316345

When receiving an HTTP response that has a Content-Type header such as text/xml, but no
body, RSSFilterStream::notifyHeadersReceived reads the Content-Type as "potential RSS", and
calls saveHeaders. It expects to sniff the body in notifyDataReceived to see if it's RSS,
and then call sendSavedHeaders to pass on the headers. But since there is no body,
notifyDataReceived is never called. So call sendSavedHeaders in notifyClose too (it will not
send them again if they were already sent.)

* platform/network/blackberry/rss/RSSFilterStream.cpp:
(WebCore::RSSFilterStream::notifyClose):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113333

Patch by Isaac Levy <ilevy@google.com> on 2013-03-26
Reviewed by Ojan Vafai.

* TestResultServer/static-dashboards/builders.jsonp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113330

250ms -> 100ms

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-26
Reviewed by Pavel Feldman.

* inspector/front-end/inspector.css:
(.animate #main):
(.animate #floating-status-bar-container):
(.animate #drawer):
(.animate #bottom-status-bar-container > *):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113316

Reviewed by Dimitri Glazkov.

Enabling this setting allows plain text clipboard content to include alt
text like on Firefox and IE10.

* public/WebSettings.h:
(WebSettings):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setSelectionIncludesAltImageText):
* src/WebSettingsImpl.h:
(WebSettingsImpl):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Also update the test expectations for the bug 113227 flaky since they're passing most of the time.

* platform/mac/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113328

Reviewed by Jocelyn Turcotte.

Downstream bugreport: https://bugreports.qt-project.org/browse/QTBUG-30249

We use QProcess::start() with a commandline string to start the web process
and the string is treated by QProcess as a whitespace delimeted list of the
command and the arguments, thus we have to escape the path to the process
binaries so that if the path contains spaces we still run the appropriate
command.

* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113329

Reviewed by Jocelyn Turcotte.

Downstream bugreport: https://bugreports.qt-project.org/browse/QTBUG-30288

Remove an erroneous assert which is no longer valid if
mouse gestures are enabled.

* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleInputEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113258
<rdar://problem/13492038>

Reviewed by Anders Carlsson.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
Add a zero-delay timer for intrinsic content size updates.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Add a zero-delay timer for intrinsic content size updates.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
Start our new one-shot zero-delay timer.
(WebKit::TiledCoreAnimationDrawingArea::updateIntrinsicContentSizeTimerFired):
Inform the WebPage that the intrinsic content size has changed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/graphics/win/FontCustomPlatformDataCairo.h:
(FontCustomPlatformData): Correct signature in header to match
required implementation.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113269

Reviewed by Rob Buis.

PR 296106

Source/WebCore:

The LayerRenderer should never clear before drawing the layers, from
now on that's the responsibility of the caller.

Only manually testable.

* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::setViewport):
* platform/graphics/blackberry/LayerRendererClient.h:
(LayerRendererClient):

Source/WebKit/blackberry:

Various flaws in the code could conspire to make the screen cleared to
black before rendering the web page. This only happened when the
BackingStore was inactive, and the LayerTiler takes on the job of
drawing the root layer. When tiles are missing, this made the
"checkerboard" effect especially noticeable since black color was seen
where the tile should have been. It would be better to clear to the web
page background color.

This was actually the intent of the code, but when the document
background color was invalid, we would still use it instead of the
background color from settings. Also, the LayerRenderer would clear to
black when WebPageCompositorPrivate::drawsRootLayer() was true.

Fixed by falling back to the settings background color when the
document background color is invalid, and removing the clearing code
from the LayerRenderer entirely. The appropriate clear already happens
near the beginning of BackingStorePrivate::blitVisibleContents().

Also slightly cleaned up the code for managing the background color.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
(BlackBerry::WebKit::WebPagePrivate::updateBackgroundColor):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::documentBackgroundColor):
* Api/WebPageCompositor.cpp:
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
* Api/WebPage_p.h:
(WebPagePrivate):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=113126

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Make it possible to read from a writable Clipboard.

Test: editing/pasteboard/can-read-in-copy-and-cut-events.html

* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):
(WebCore::ClipboardQt::readClipboardData):
(WebCore::ClipboardQt::hasData):
(WebCore::ClipboardQt::items):
* platform/qt/ClipboardQt.h:
(ClipboardQt):

LayoutTests:

Unskip now working editing/pasteboard/can-read-in-copy-and-cut-events.html.
The other test still needs better drag-and-drop support in DRT.

* platform/qt/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Update
method signature to match CG variant.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113283

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Merged isValidHTTPToken() from HTTPValidation.h and isRFC2616Token() from
HTTPParsers.h. They were doing exactly the same thing and their
implementation was almost the same.

Removed HTTPValidation.* and moved remaining code to HTTPParsers.* as this
seems like the proper place and it seems odd to keep HTTPValidation for
just one function.

No new tests, no behavior change for layout tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* platform/network/HTTPParsers.cpp:
(WebCore::isValidHTTPHeaderValue):
(WebCore):
(WebCore::isValidHTTPToken): Implementation is slightly simplified based on
isValidHTTPToken() from HTTPValidation.cpp. (c >= 0x80 || c == 0x7F) is
replaced by (c >= 0x7F). (c <= 0x1F ||  c == ' ' || c == '\t') is replaced
by (c <= 0x20). Those expressions are shorter but equivalent.
(WebCore::contentDispositionType):
* platform/network/HTTPParsers.h:
* platform/network/HTTPValidation.cpp: Removed.
* platform/network/HTTPValidation.h: Removed.
* xml/XMLHttpRequest.cpp: Stop including HTTPValidation.h.

Source/WebKit/chromium:

* src/AssociatedURLLoader.cpp: Include HTTPParsers.h instead
of HTTPValidation.h to use isValidHTTPToken().


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=112126

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: editing/execCommand/overtype-support.html
       editing/execCommand/overtype.html

Add a new Overwrite command to the editor. This command will
perform overtype operations when enabled instead of "normal" text
insertions. As IE does, we maintain a single toggle state in the
editor (enabled/disabled) for all the editable content in the
page.

This new command will be only available for richly editable
content via keybindings or the context menu. For testing purposes
it is also accessible via internals.

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::replaceTextInNode): Use RefPtr for
local variables.
* editing/Editor.cpp:
(WebCore::Editor::Editor):
* editing/Editor.h:
(WebCore::Editor::isOverwriteModeEnabled):
(WebCore::Editor::toggleOverwriteModeEnabled):
(Editor): Added two new functions and a new attribute.
* editing/EditorCommand.cpp:
(WebCore::executeToggleOverwrite): Enables/disables overwrite mode.
(WebCore):
(WebCore::createCommandMap): New OverWrite command.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::setEndingSelectionWithoutValidation):
Refactored from performTrivialReplace(), shared by
performOverwrite().
(WebCore):
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::performOverwrite):
(WebCore::InsertTextCommand::doApply): Perform overwrite if enabled.
* editing/InsertTextCommand.h:
(InsertTextCommand):
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Reset OverWrite mode
to false.
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore):
(WebCore::Internals::toggleOverwriteModeEnabled): Provide access
to overwrite functionality in Editor for testing purposes.
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/mac:

Added the OverWrite editing command to the WebCore editing
commands lists.

* WebView/WebHTMLView.mm:
* WebView/WebView.h:
* WebView/WebView.mm:

LayoutTests:

Two new layout tests for the new overtype mode. We use
overtype-support.html to check that the Overwrite command is not
exported to JavaScript but accessible through Internals. The
overtype.html one is used to test the actual behaviour of the
command.

The new command was also added to enabling-and-selection-2.js to
check that it is only available for richly editable content.

* editing/execCommand/enabling-and-selection-2-expected.txt:
Updated expectations for OverWrite command.
* editing/execCommand/overtype-expected.txt: Added.
* editing/execCommand/overtype-support-expected.txt: Added.
* editing/execCommand/overtype-support.html: Added.
* editing/execCommand/overtype.html: Added.
* editing/execCommand/script-tests/enabling-and-selection-2.js:
Added a check for OverWrite command.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113263

Reviewed by Rob Buis.

PR 312404

Source/WebCore:

Fix WebOverlay::pixelViewportRect() to return the pixel viewport rect
instead of the window rect. These are different if the web page is
rendered starting at a window coordinate other than 0,0. The clip rect
encodes the position we're rendered at, and can be used to translate
the rect expressed in window coordinates to the pixel viewport
coordinate system.

Also perform some cleanup of related code.

Only manually testable.

* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::getTransformedHolePunchRect):
(WebCore::LayerCompositingThread::drawTextures):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::toPixelCoordinates):
(WebCore):
(WebCore::LayerRenderer::toWindowCoordinates):
(WebCore::LayerRenderer::toPixelViewportCoordinates):
(WebCore::LayerRenderer::toDocumentViewportCoordinates):
(WebCore::LayerRenderer::updateLayersRecursive):
* platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderer):

Source/WebKit/blackberry:

Fixed by returning pixel viewport coordinates instead of window
coordinates.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/146901
https://bugs.webkit.org/show_bug.cgi?id=113321

Was landed to soon (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-26

Source/WebCore:

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.):
(WebInspector.ConsoleView.prototype.filter):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleView.prototype._promptKeyDown):
(WebInspector.ConsoleView.prototype._printResult):
(WebInspector.ConsoleCommand.prototype.highlightSearchResults):
* inspector/front-end/inspector.css:
(.console-warning-level, .console-error-level, .console-log-level, .console-debug-level):
(.filter-all .console-debug-level, .filter-debug .console-debug-level):
(.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message):

LayoutTests:

* inspector/console/console-preserve-log.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113016

Reviewed by Eric Seidel.

Source/WebCore:

New test added to html5lib suite.

* html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::isSpecialNode):

LayoutTests:

* html5lib/resources/template.dat:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113311

Reviewed by Pavel Feldman.

Source/WebCore:

Made independent handling of breakpoints and breakpoint location in breakpoint manager consistent.
JavaScriptSourceFrame now removes breakpoints originally set in it based on primary UI location.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpoints):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpointLocations):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.onUISourceCodeContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._removeAllBreakpoints):

LayoutTests:

* inspector/debugger/live-edit-breakpoints-expected.txt:
* inspector/debugger/live-edit-breakpoints.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113030
<rdar://problem/13300254>

Patch by Simon Cooper <scooper@apple.com> on 2013-03-26
Reviewed by Alexey Proskuryakov.

When choosing / looking for a specialized Sandbox for a Plugin the
bundle-id needs to be sanitized before using it to construct a
filesystem name to look up. The “/“ character should not be allowed
and transformed into something else, in this case a “:”

* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::loadSandboxProfile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146902 268f45cc-cd09-0410-ab3c-d52691b4dbfc