1. 03 Oct, 2011 40 commits
    • darin@apple.com's avatar
      Change cursor to hand over missing plug-in message · 95130fcc
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69312
      
      Reviewed by Sam Weinig.
      
      No tests because we currently don't have any test machinery for cursors.
      
      * page/EventHandler.cpp:
      (WebCore::OptionalCursor::OptionalCursor): Added. Construct an object
      to represent either a cursor, or no cursor change.
      (WebCore::OptionalCursor::isCursorChange): Added.
      (WebCore::OptionalCursor::cursor): Added.
      (WebCore::EventHandler::selectCursor): Changed return type to OptionalCursor,
      moved some special cases from handleMouseMoveEvent in here. Moved the logic
      for plug-ins and framesets into the specific renderer classes for those.
      Added a call to the new getCursor virtual function.
      (WebCore::EventHandler::handleMouseMoveEvent): Changed cursor setting code to
      just be a call to selectCursor and then setCursor. Plug-in-specific code is now
      in RenderWidget.
      
      * page/EventHandler.h: Changed return type of selectCursor.
      
      * page/MouseEventWithHitTestResults.cpp: Made some functions be inline.
      * page/MouseEventWithHitTestResults.h:
      (WebCore::MouseEventWithHitTestResults::localPoint): Made this inline.
      (WebCore::MouseEventWithHitTestResults::scrollbar): Made this inline.
      Yes, this has nothing to do with the rest of the patch, but it's good.
      
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::getReplacementTextGeometry): Made const.
      (WebCore::RenderEmbeddedObject::isInMissingPluginIndicator): Made const.
      Overloaded so it can be called with a point rather than an event.
      (WebCore::shouldMissingPluginMessageBeButton): Added. Helps streamline
      the logic below.
      (WebCore::RenderEmbeddedObject::handleMissingPluginIndicatorEvent):
      Changed to use shouldMissingPluginMessageBeButton.
      (WebCore::RenderEmbeddedObject::getCursor): Added. Sets the cursor to
      a hand when over the missing plug-in message.
      * rendering/RenderEmbeddedObject.h: Added getCursor override. Also updated
      for other changes above.
      
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::getCursor): Added. Contains the logic that used
      to be hardcoded in EventHandler::selectCursor about cursors when over
      resizable frame borders.
      * rendering/RenderFrameSet.h: Added getCursor.
      
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::getCursor): Added. Returns SetCursorBasedOnStyle.
      * rendering/RenderObject.h: Added getCursor.
      
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::getCursor): Added. Contains the logic that used
      to be hardcoded in EventHandler::handleMouseMoveEvent to prevent setting
      the cursor when the pointer is over a plug-in. This new code is much better,
      because it only kicks in when there is actually a plug-in present. The old
      was based on the HTML tag!
      * rendering/RenderWidget.h: Added getCursor.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95130fcc
    • abarth@webkit.org's avatar
      garden-o-matic should remove builders from the failure grid once they start to pass · 414abf8c
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69309
      
      Unreviewed.  dglazkov is on vacation.  I need to interest someone else
      in reviewing these patches.
      
      This patch follows the update/purge model from UpdateTracker.  This
      patch is less awesome than it could be because it causes the UI to
      flash slightly.  In a future patch, we'll want to use these
      update/purge notifications to update the UI without flashing.  However,
      that's not such a big deal because this UI is hidden in the default
      view.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      414abf8c
    • fpizlo@apple.com's avatar
      JSC ASSERT Opening the Web Inspector · 94551a41
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69293
      
      Reviewed by Oliver Hunt.
      
      If a polymorphic access structure list has a duplicated structure, then
      don't crash.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94551a41
    • barraclough@apple.com's avatar
      On X86, switch bucketCount into a register, timeoutCheck into memory · 70558a37
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69299
      
      Reviewed by Geoff Garen.
      
      We don't have sufficient registers to keep both in registers, and DFG JIT will trample esi;
      it doesn't matter if the bucketCount gets stomped on (in fact it may add to randomness!),
      but it if the timeoutCheck gets trashed we may make calls out to the timout_check stub
      function too frequently (regressing performance). This patch has no perf impact on sunspider.
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * assembler/MacroAssemblerX86.h:
      (JSC::MacroAssemblerX86::branchAdd32):
      (JSC::MacroAssemblerX86::branchSub32):
          - Added branchSub32 with AbsoluteAddress.
      * jit/JIT.cpp:
      (JSC::JIT::emitTimeoutCheck):
          - Keep timeout count in memory on X86.
      * jit/JITInlineMethods.h:
      (JSC::JIT::emitValueProfilingSite):
          - remove X86 specific code, switch bucket count back into a register.
      * jit/JITStubs.cpp:
          - Stop initializing esi (it is no longer the timeoutCheck!)
      * jit/JSInterfaceJIT.h:
          - change definition of esi to be the bucketCountRegister.
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalData.h:
          - Add timeoutCount as a property to global data (the counter should be per-thread).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70558a37
    • fpizlo@apple.com's avatar
      DFG backends don't have access to per-node predictions from the propagator · d30b1206
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69291
      
      Reviewed by Oliver Hunt.
              
      Nodes now have two notion of predictions: the heap prediction, which is
      what came directly from value profiling, and the propagator's predictions,
      which arise out of abstract interpretation. Every node has a propagator
      prediction, but not every node has a heap prediction; and there is no
      guarantee that a node that has both will keep them consistent as the
      propagator may have additional information available to it.
              
      This is performance neutral.
      
      * dfg/DFGGraph.cpp:
      (JSC::DFG::Graph::dump):
      * dfg/DFGGraph.h:
      * dfg/DFGJITCompiler.h:
      (JSC::DFG::JITCompiler::getPrediction):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::Node):
      (JSC::DFG::Node::hasHeapPrediction):
      (JSC::DFG::Node::getHeapPrediction):
      (JSC::DFG::Node::predictHeap):
      (JSC::DFG::Node::prediction):
      (JSC::DFG::Node::predict):
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::Propagator):
      (JSC::DFG::Propagator::setPrediction):
      (JSC::DFG::Propagator::mergePrediction):
      (JSC::DFG::Propagator::propagateNodePredictions):
      (JSC::DFG::Propagator::fixupNode):
      (JSC::DFG::Propagator::isPredictedNumerical):
      (JSC::DFG::Propagator::logicalNotIsPure):
      (JSC::DFG::Propagator::setReplacement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d30b1206
    • andersca@apple.com's avatar
      Work towards making PlatformWheelEvent immutable · fae40064
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69306
      
      Reviewed by Sam Weinig.
      
      Currently, PlatformWheelEvent has an m_isAccepted flag that tracks whether
      the event has been handled or not. For all other event types, that state is instead
      tracked by the return value of the various event handlers.
      
      As a first step, add return values to the various handleWheelEvent functions and
      add an assertion in EventHandler::wheelEvent that the return value is the same as
      the state of PlatformWheelEvent::isAccepted.
      
      * Configurations/Base.xcconfig:
      Don't warn when using C++11 extensions.
      
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::wheelEvent):
      Assert that isAccepted matches the return value.
      
      * platform/ScrollAnimator.cpp:
      (WebCore::ScrollAnimator::handleWheelEvent):
      Return isAccepted.
      
      * platform/ScrollAnimator.h:
      HandleWheelEvent now returns a boolean.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::wheelEvent):
      Return whether the event was handled or not.
      
      * platform/ScrollView.h:
      ScrollView::wheelEvent now returns a bool.
      
      * platform/ScrollableArea.cpp:
      (WebCore::ScrollableArea::handleWheelEvent):
      * platform/ScrollableArea.h:
      ScrollableArea::handleWheelEvent now returns a bool.
      
      * platform/chromium/ScrollAnimatorChromiumMac.h:
      * platform/chromium/ScrollAnimatorChromiumMac.mm:
      (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
      Add return values, based on either the base class calls or the state of
      PlatformWheelEvent::isAccepted().
      
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::handleWheelEvent):
      Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fae40064
    • levin@chromium.org's avatar
      webkitpy: Expose cc_emails and comments from bug.py · 779eb51a
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69308
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
      * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
      * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
      to comments being exposed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      779eb51a
    • eric@webkit.org's avatar
      Add a microbenchmark for a full-page render of the HTML5 spec · d327870d
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69285
      
      Reviewed by Adam Barth.
      
      This was designed to be a test for https://bugs.webkit.org/show_bug.cgi?id=68944
      But it seems that by far our dominating cost for the HTML5 benchmark is
      time spent laying out lines (which isn't actually that surprising).
      
      I'm adding the performance test for posterity.
      
      * Parser/html-parser.html:
       - Removed use of "about:blank" which abarth says is a no-op.  Made comment more accurate.
      * Parser/html5-full-render.html: Copied from PerformanceTests/Parser/html-parser.html.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d327870d
    • mitz@apple.com's avatar
      <rdar://problem/9973489> REGRESSION (r66599): -[DOMNode boundingBox] returns... · 1ff1aa7c
      mitz@apple.com authored
      <rdar://problem/9973489> REGRESSION (r66599): -[DOMNode boundingBox] returns the zero rect for SVG elements
      https://bugs.webkit.org/show_bug.cgi?id=69305
      
      Reviewed by Simon Fraser.
      
      Source/WebCore: 
      
      Test: svg/custom/boundingBox.html
      
      Rather than asserting and returning the zero rect, take the transform-aware code path for computing SVG
      bounding rects.
      
      * rendering/svg/RenderSVGForeignObject.cpp:
      (WebCore::RenderSVGForeignObject::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().
      * rendering/svg/RenderSVGInline.cpp:
      (WebCore::RenderSVGInline::mapLocalToContainer): Ditto.
      * rendering/svg/RenderSVGModelObject.cpp:
      (WebCore::RenderSVGModelObject::mapLocalToContainer): Ditto.
      (WebCore::RenderSVGModelObject::absoluteRects): Replaced an incorrect assertion with code to approximate the bounding
      box.
      * rendering/svg/RenderSVGText.cpp:
      (WebCore::RenderSVGText::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().
      * rendering/svg/SVGRenderSupport.cpp:
      (WebCore::SVGRenderSupport::mapLocalToContainer): Removed the fixed and useTransform boolean parameters.
      * rendering/svg/SVGRenderSupport.h:
      
      LayoutTests: 
      
      * svg/custom/boundingBox-expected.txt: Added.
      * svg/custom/boundingBox.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ff1aa7c
    • jamesr@google.com's avatar
      [chromium] Tweak WebCompositor API for input event handling to express three possible states · 8b742be1
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69304
      
      Reviewed by Darin Fisher.
      
      * public/WebCompositorClient.h:
      * src/WebCompositorImpl.cpp:
      (WebKit::WebCompositorImpl::~WebCompositorImpl):
      (WebKit::WebCompositorImpl::handleInputEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b742be1
    • commit-queue@webkit.org's avatar
      Add myself to the watchlist for platform/graphics/chromium · 4e20ab9d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69297
      
      Patch by James Robinson <jamesr@chromium.org> on 2011-10-03
      Reviewed by David Levin.
      
      * Scripts/webkitpy/common/config/watchlist:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e20ab9d
    • andersca@apple.com's avatar
      Content area does not return to the correct position after rubberbanding · 5e75d84d
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69302
      <rdar://problem/10102886>
      
      Reviewed by Sam Weinig.
      
      Make sure to schedule a display after adding to the dirty region.
      
      * WebProcess/WebPage/DrawingAreaImpl.cpp:
      (WebKit::DrawingAreaImpl::scroll):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e75d84d
    • michaeln@google.com's avatar
      A little more WebSQLDatabase thread safety. · 99c9c1c9
      michaeln@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69277
      
      - switch to using AtomicallyInitializedStatic where appropiate
      - avoid using some Strings across threads
      
      Reviewed by David Levin.
      
      Existing tests apply.
      
      * storage/AbstractDatabase.cpp:
      (WebCore::guidMutex):
      (WebCore::guidToVersionMap):
      (WebCore::guidToDatabaseMap):
      (WebCore::guidForOriginAndName):
      (WebCore::AbstractDatabase::databaseInfoTableName):
      (WebCore::AbstractDatabase::AbstractDatabase):
      (WebCore::AbstractDatabase::performOpenAndVerify):
      (WebCore::AbstractDatabase::getVersionFromDatabase):
      (WebCore::AbstractDatabase::setVersionInDatabase):
      * storage/AbstractDatabase.h:
      * storage/chromium/DatabaseTrackerChromium.cpp:
      (WebCore::DatabaseTracker::tracker):
      * storage/chromium/QuotaTracker.cpp:
      (WebCore::QuotaTracker::instance):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99c9c1c9
    • rniwa@webkit.org's avatar
      Replace m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand by positions · bd6682da
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68874
      
      Reviewed by Enrica Casucci.
      
      Replaced m_firstNodeInserted and m_lastLeafInserted by m_startOfInsertedContent and m_endOfInsertedContent
      respectively. Also removed removeNodePreservingChildren and removeNodeAndPruneAncestors in ReplaceSelectionCommand
      because they were not virtual in CompositeEditCommand and implicitly overriding the functions was confusing.
      Since each of these two functions is used at exactly one place, just update positions and insertedNodes explicitly.
      
      * editing/CompositeEditCommand.cpp:
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
      (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
      (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent):
      (WebCore::ReplaceSelectionCommand::handleStyleSpans):
      (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Update m_endOfInsertedContent by endingSelection().visibleEnd()
      instead of m_lastLeafInserted with destination.previous() because moveParagraph could have removed leading whitespace in
      the text node referenced by destination. This is tested by an existing layout test.
      (WebCore::ReplaceSelectionCommand::doApply):
      (WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace): Update positions as needed. All changes are tested
      by the existing layout tests in editing/pasteboard.
      (WebCore::ReplaceSelectionCommand::updateNodesInserted):
      * editing/ReplaceSelectionCommand.h:
      * editing/htmlediting.cpp:
      (WebCore::hasARenderedDescendant): Moved from CompositeEditCommand.cpp.
      (WebCore::highestNodeToRemoveInPruning): Ditto.
      * editing/htmlediting.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd6682da
    • rniwa@webkit.org's avatar
      REGRESSION(r94274): cloned text input loses value · f6200406
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69095
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      The bug was caused by copyNonAttributeProperties not updating inner element text after copying
      m_valueIfDirty. Fixed the bug by calling updateInnerTextValue.
      
      Test: fast/forms/clone-input-with-dirty-value.html
      
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::copyNonAttributeProperties):
      
      LayoutTests: 
      
      Added a regression test that clones an input element with a dirty value.
      The cloned input element should have the edited value.
      
      * fast/forms/clone-input-with-dirty-value-expected.txt: Added.
      * fast/forms/clone-input-with-dirty-value.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6200406
    • rniwa@webkit.org's avatar
      Leopard build fix after r96530. · a7b4c3c7
      rniwa@webkit.org authored
      * rendering/svg/RenderSVGResourcePattern.cpp:
      (WebCore::RenderSVGResourcePattern::applyResource):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7b4c3c7
    • weinig@apple.com's avatar
      Move ContentSecurityPolicy to the ScriptExecutionContext to prepare it for... · 068444c5
      weinig@apple.com authored
      Move ContentSecurityPolicy to the ScriptExecutionContext to prepare it for working with XHR and workers
      https://bugs.webkit.org/show_bug.cgi?id=69294
      
      Reviewed by Darin Adler.
      
      * dom/Document.cpp:
      (WebCore::Document::initSecurityContext):
      Initialize the ContentSecurityPolicy by calling down to the ScriptExecutionContext.
      
      * dom/Document.h:
      Move the ContentSecurityPolicy member and getter from here to ScriptExecutionContext.h.
      
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::setContentSecurityPolicy):
      * dom/ScriptExecutionContext.h:
      (WebCore::ScriptExecutionContext::contentSecurityPolicy):
      Add ContentSecurityPolicy member and getter/setter.
      
      * page/ContentSecurityPolicy.cpp:
      (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
      (WebCore::ContentSecurityPolicy::didReceiveHeader):
      (WebCore::ContentSecurityPolicy::reportViolation):
      (WebCore::ContentSecurityPolicy::parseReportURI):
      (WebCore::ContentSecurityPolicy::createCSPDirective):
      * page/ContentSecurityPolicy.h:
      (WebCore::ContentSecurityPolicy::create):
      Replace Document with ScriptExecutionContext. Add temporary checked casts to document
      where necessary.
      
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::WorkerContext):
      Add initialization of the ContentSecurityPolicy.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      068444c5
    • andersca@apple.com's avatar
      Remove custom scrollbar painting hooks · aabadfa9
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69163
      
      Source/WebCore: 
      
      Reviewed by Alexey Proskuryakov.
      
      The custom scrollbar and scroll corner painting hooks aren't used by anyone
      so go ahead and remove them. This removes the setter/getter and ChromeClient functions.
      
      * page/Chrome.cpp:
      * page/ChromeClient.h:
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      * page/Settings.h:
      * platform/ScrollbarThemeComposite.cpp:
      (WebCore::ScrollbarThemeComposite::paint):
      (WebCore::ScrollbarThemeComposite::paintScrollCorner):
      
      Source/WebKit/chromium: 
      
      Reviewed by Alexey Proskuryakov.
      
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::setShouldPaintCustomScrollbars):
      
      Source/WebKit/win: 
      
      Reviewed by Alexey Proskuryakov.
      
      Remove now unused WebPreferences and ChromeClient overrides.
      
      * Interfaces/IWebPreferences.idl:
      * WebCoreSupport/WebChromeClient.cpp:
      * WebCoreSupport/WebChromeClient.h:
      * WebPreferenceKeysPrivate.h:
      * WebPreferences.cpp:
      (WebPreferences::unused3):
      (WebPreferences::unused4):
      * WebPreferences.h:
      * WebView.cpp:
      (WebView::notifyPreferencesChanged):
      
      Source/WebKit2: 
      
      Remove overridden ChromeClient member functions.
      
      Reviewed by Alexey Proskuryakov.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      Tools: 
      
      Reviewed by Alexey Proskuryakov.
      
      * DumpRenderTree/chromium/WebPreferences.cpp:
      (WebPreferences::applyTo):
      No need to enable custom scrollbar painting.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aabadfa9
    • abarth@webkit.org's avatar
      Update results again now that Leopard has finally cycled. · 789c2ef2
      abarth@webkit.org authored
      * platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
      * platform/chromium-cg-mac-leopard/svg/custom/non-scaling-stroke-expected.png:
      * platform/chromium-cg-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Added.
      * platform/chromium-cg-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
      * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
      * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
      * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
      * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
      * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
      * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
      * platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
      * platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
      * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      789c2ef2
    • darin@apple.com's avatar
      Rename many obviously-correct call sites in WebCore using releaseRef to use it... · 9564cb79
      darin@apple.com authored
      Rename many obviously-correct call sites in WebCore using releaseRef to use it by its new name leakRef
      https://bugs.webkit.org/show_bug.cgi?id=68672
      
      Reviewed by Daniel Bates.
      
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::commonJSGlobalData):
      * css/CSSInitialValue.h:
      (WebCore::CSSInitialValue::createExplicit):
      (WebCore::CSSInitialValue::createImplicit):
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::init):
      * css/CSSStyleSelector.cpp:
      (WebCore::parseUASheet):
      (WebCore::CSSStyleSelector::styleForElement):
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::wheelEvent):
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderTheme::themeForPage):
      * platform/gtk/RenderThemeGtk.cpp:
      (WebCore::RenderTheme::themeForPage):
      * platform/haiku/RenderThemeHaiku.cpp:
      (WebCore::RenderTheme::themeForPage):
      * platform/network/cf/DNSCFNet.cpp:
      (WebCore::DNSResolveQueue::resolve):
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::ResourceHandle::releaseConnectionForDownload):
      * platform/qt/RenderThemeQt.cpp:
      (WebCore::RenderTheme::themeForPage):
      (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
      * platform/text/BidiContext.cpp:
      (WebCore::BidiContext::create):
      * platform/wx/RenderThemeWx.cpp:
      (WebCore::RenderTheme::themeForPage):
      * rendering/RenderThemeChromiumLinux.cpp:
      (WebCore::RenderTheme::themeForPage):
      * rendering/RenderThemeChromiumMac.mm:
      (WebCore::RenderTheme::themeForPage):
      * rendering/RenderThemeChromiumSkia.cpp:
      (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
      (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
      (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
      * rendering/RenderThemeChromiumWin.cpp:
      (WebCore::RenderTheme::themeForPage):
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderTheme::themeForPage):
      * rendering/RenderThemeSafari.cpp:
      (WebCore::RenderTheme::themeForPage):
      * rendering/RenderThemeWin.cpp:
      (WebCore::RenderTheme::themeForPage):
      (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
      (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
      (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
      * rendering/RenderThemeWinCE.cpp:
      (WebCore::RenderTheme::themeForPage):
      * rendering/style/RenderStyle.cpp:
      (WebCore::defaultStyle):
      Call leakRef instead of releaseRef. I did this only in the cases where
      it was obvious to me this was the right way to do it. I'll keep revisiting
      sites still calling it releaseRef until they are all gone.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9564cb79
    • ojan@chromium.org's avatar
      remove dead code in flipForWritingMode · 035c88ca
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68948
      
      Reviewed by Hajime Morita.
      
      ChildToParentFlippingAdjustment is never used, so the third argument
      to flipForWritingMode always has the same value.
      
      In addition, renamed to flipForWritingModeForChild to be more clear
      that it's operating on the child and renamed flipFloatForWritingMode to match.
      
      No new tests. This is just a code cleanup. No functional changes.
      
      * rendering/InlineBox.cpp:
      (WebCore::InlineBox::paint):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::paintChildren):
      (WebCore::RenderBlock::flipFloatForWritingModeForChild):
      (WebCore::RenderBlock::paintFloats):
      (WebCore::RenderBlock::hitTestFloats):
      (WebCore::RenderBlock::hitTestContents):
      * rendering/RenderBlock.h:
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::flipForWritingModeForChild):
      (WebCore::RenderBox::topLeftLocation):
      * rendering/RenderBox.h:
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::paintObject):
      (WebCore::RenderTable::nodeAtPoint):
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::nodeAtPoint):
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::paintCell):
      (WebCore::RenderTableSection::nodeAtPoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      035c88ca
    • jer.noble@apple.com's avatar
      Unreviewed, rolling out r96526. · ad9dc384
      jer.noble@apple.com authored
      http://trac.webkit.org/changeset/96526
      https://bugs.webkit.org/show_bug.cgi?id=68587
      
      WEB_AUDIO has numerous 64->32 bit casting warnings, causing
      build breakages where -Wall is enabled.
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      * wtf/Platform.h:
      
      Source/WebCore:
      
      * Configurations/FeatureDefines.xcconfig:
      * WebCore.xcodeproj/project.pbxproj:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad9dc384
    • abarth@webkit.org's avatar
      Update results to account for Windows Vista. · de0ec607
      abarth@webkit.org authored
      * platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
      * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
      * platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de0ec607
    • joepeck@webkit.org's avatar
      <http://webkit.org/b/69152> Web Inspector: rgb() with percentages shows wrong hex/hsl values · c6490747
      joepeck@webkit.org authored
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Previously we assumed rgb values were always in byte form,
      but they could include percentage values. Ex. rgb(100%,0,0).
      This patch fixes this, and in the process includes clamping
      for invalid percentages, byte values, and alpha values.
      
      Test: inspector/styles/styles-invalid-color-values.html
      
      * inspector/front-end/Color.js:
      (WebInspector.Color.prototype._clamp):
      (WebInspector.Color.prototype._individualRGBValueToFloatValue):
      (WebInspector.Color.prototype._individualRGBValueToHexValue):
      (WebInspector.Color.prototype._rgbToHex):
      (WebInspector.Color.prototype._rgbToHSL):
      An individual rgb value can be either a decimal/float or a
      percentage. Rewrite the conversion functions to handle either
      input. Regardless of the type of input, always return a clamped
      decimal/float value between 0 and 255.
      
      (WebInspector.Color.prototype._rgbaToHSLA):
      (WebInspector.Color.prototype._hslaToRGBA):
      (WebInspector.Color.prototype._parse):
      Clamp the alpha value between 0 and 1.
      
      LayoutTests:
      
      This test outputs all of the supported color format representations
      for supplied CSS color values. We expect some of the CSS values
      to be clamped, e.g. rgb(300,0,0) to rgb(255,0,0). This also tests
      that rgb percentages, such as rgb(100%,0,0), work correctly.
      
      * inspector/styles/styles-invalid-color-values-expected.txt: Added.
      * inspector/styles/styles-invalid-color-values.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6490747
    • abarth@webkit.org's avatar
      Update chromium-cg-mac results after http://trac.webkit.org/changeset/96530. · 643fa1b0
      abarth@webkit.org authored
      * platform/chromium-cg-mac/svg/custom/pattern-skew-transformed-expected.png:
      * platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
      * platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
      * platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
      * platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
      * platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
      * platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      643fa1b0
    • levin@chromium.org's avatar
      watchlist: Make watchlist run on a bot. · 624b7acc
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68974
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      Change to log what is run so that we can see the style command
      and the watchlist command being run.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      624b7acc
    • levin@chromium.org's avatar
      watchlist: Allow specified a bug to attach the watchlist info to. · 988f9337
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69288
      
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
      * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
      Add tests and fix an existing test because the unit tests do not go through the
      normal command line processing (so the -g argument remained when we determined bug ids).
      * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
      get the assert raises regex method.
      * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      988f9337
    • abarth@webkit.org's avatar
      Update results now that the race condition is fixed. It seems like the · 5c6b3f9e
      abarth@webkit.org authored
      cross-platform results would need to be updated as well, but no bot has
      told me that yet.
      
      * platform/chromium-mac-leopard/svg/as-object: Added.
      * platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c6b3f9e
    • abarth@webkit.org's avatar
      Update baselines after http://trac.webkit.org/changeset/96530. · e969e715
      abarth@webkit.org authored
      * platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
      * platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
      * platform/chromium-cg-mac/svg/custom/non-scaling-stroke-expected.png:
      * platform/chromium-cg-mac/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
      * platform/chromium-cg-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
      * platform/chromium-cg-mac/svg/custom/pattern-with-transformation-expected.png:
      * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
      * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
      * platform/chromium-linux/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
      * platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
      * platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
      * platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png:
      * platform/chromium-mac/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
      * platform/chromium-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png:
      * platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
      * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
      * platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
      * platform/chromium-win/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
      * platform/chromium-win/svg/custom/pattern-size-bigger-than-target-size-expected.png:
      * platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
      * platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
      * platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
      * platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
      * svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e969e715
    • commit-queue@webkit.org's avatar
      [EFL] DRT: Add JSStringUtils.{cpp,h} · 3fac0249
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66397
      
      Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-10-03
      Reviewed by Ryosuke Niwa.
      
      Adds helper functions to compare the equality of C-style strings and
      JSStringRef objects.
      
      * DumpRenderTree/efl/JSStringUtils.cpp: Added.
      (equals):
      * DumpRenderTree/efl/JSStringUtils.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fac0249
    • abarth@webkit.org's avatar
      garden-o-matic should work in Safari 5.1 · 1ad21aab
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69290
      
      Reviewed by Sam Weinig.
      
      My old implementation of bind was too clever by half.  This one seems
      to work better, at least according to this test.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ad21aab
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r96532. · e3d1a25b
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/96532
      https://bugs.webkit.org/show_bug.cgi?id=69289
      
      Accidentally marked failures as expected instead of creating
      new baseline. (Requested by krit on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3d1a25b
    • barraclough@apple.com's avatar
      Unreviewed build fix for DFG JIT 32_64. · 5c4f4337
      barraclough@apple.com authored
      * dfg/DFGJITCompiler32_64.cpp:
      (JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c4f4337
    • abarth@webkit.org's avatar
      webkit->chromium DEPS roll 103471->103694 · b3cdf9fe
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69271
      
      This brings in a new tools/win/supalink directory from
      http://src.chromium.org/viewvc/chrome?view=rev&revision=103474
      
      Patch by Elliot Poger <epoger@google.com> on 2011-10-03
      Reviewed by Adam Barth.
      
      * DEPS:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3cdf9fe
    • krit@webkit.org's avatar
      Uneviewed by rebaseline after SVG Pattern patch with bug 69261. · a8806a1f
      krit@webkit.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8806a1f
    • eric@webkit.org's avatar
      PerformanceTests/Parser/html-parser is only testing parsing of the head element · 35f5f9b9
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69283
      
      Reviewed by Adam Barth.
      
      While investigating https://bugs.webkit.org/show_bug.cgi?id=68944
      I found that the html-parser benchmark was only parsing up to the
      first script tag per loop!  We've fixed this by adding the sandbox
      tag which will deny all external loads and allow the parser to
      synchronously continue parsing the entire document to completion
      (as we had expected it was doing).
      
      This changes the profile somewhat.  Line number counting is much
      hotter, since we're actually accounting for the parse of the entire
      document in our sample.
      
      Total sample time only about doubles, from 1800ms to 3800ms on my machine
      which is less than I would have expected.
      
      * Parser/html-parser.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35f5f9b9
    • krit@webkit.org's avatar
      SVG Pattern tile pixelated on patternTransform · 530eb308
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69261
      
      Source/WebCore: 
      
      Reviewed by Rob Buis.
      
      Scale the SVG pattern tile by the scale level of patternTransform to avoid pixelation.
      
      Test: svg/custom/pattern-scaled-pattern-space.svg
      
      * rendering/svg/RenderSVGResourcePattern.cpp:
      (WebCore::RenderSVGResourcePattern::applyResource):
      
      LayoutTests: 
      
      Reviewed by Rob Buis.
              
      Add a new test to check that SVG pattern tiles are not pixelated on
      scaling with patternTransform.
      Updated two more pixel tests. Both changes are progressions.
      
      * platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
      * platform/mac/svg/custom/non-scaling-stroke-expected.png:
      * svg/custom/pattern-scaled-pattern-space-expected.png: Added.
      * svg/custom/pattern-scaled-pattern-space-expected.txt: Added.
      * svg/custom/pattern-scaled-pattern-space.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      530eb308
    • jamesr@google.com's avatar
      [chromium] Add WebWidget API for accessing the current WebCompositor · 1684c769
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69181
      
      Reviewed by Darin Fisher.
      
      Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
      didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.
      
      Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
      thread to get access to a WebCompositor pointer.
      
      * public/WebWidget.h:
      (WebKit::WebWidget::compositor):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::compositor):
      (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      * src/WebViewImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1684c769
    • abarth@webkit.org's avatar
      Another round of updates after http://trac.webkit.org/changeset/96509. · a08db2a7
      abarth@webkit.org authored
      * platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
      * platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Added.
      * platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png: Added.
      * platform/chromium-cg-mac/tables/mozilla/bugs/bug113235-2-expected.png:
      * platform/chromium-cg-mac/tables/mozilla/bugs/bug23994-expected.png:
      * platform/chromium-cg-mac/tables/mozilla/bugs/bug56405-expected.png:
      * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.png:
      * platform/chromium-win/fast/invalid/017-expected.png:
      * platform/chromium-win/fast/invalid/018-expected.png:
      * platform/chromium-win/fast/invalid/020-expected.png:
      * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a08db2a7
    • fpizlo@apple.com's avatar
      DFG should speculate more aggressively on obvious cases on · 752f7d98
      fpizlo@apple.com authored
      polymorphic get_by_id
      https://bugs.webkit.org/show_bug.cgi?id=69235
      
      Reviewed by Oliver Hunt.
              
      This implements trivial polymorphic get_by_id. It also fixes
      problems in the CSE for CheckStructure in the put_by_id
      transition case.
              
      Doing this required knowing whether a polymorphic get_by_id stub
      was doing a direct access rather than a call of some kind.
              
      Slight speed-up on Kraken and SunSpider. 0.5% speed-up in the
      scaled mean of all benchmarks.
      
      * GNUmakefile.list.am:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * bytecode/Instruction.h:
      (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
      (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::cellConstant):
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGGraph.cpp:
      (JSC::DFG::Graph::dump):
      * dfg/DFGGraph.h:
      (JSC::DFG::Graph::addStructureSet):
      (JSC::DFG::Graph::addStructureTransitionData):
      * dfg/DFGNode.h:
      (JSC::DFG::StructureTransitionData::StructureTransitionData):
      (JSC::DFG::Node::hasStructureTransitionData):
      (JSC::DFG::Node::structureTransitionData):
      (JSC::DFG::Node::hasStructureSet):
      (JSC::DFG::Node::structureSet):
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::checkStructureLoadElimination):
      (JSC::DFG::Propagator::performNodeCSE):
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::tryBuildGetByIDList):
      (JSC::DFG::tryBuildGetByIDProtoList):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGStructureSet.h: Added.
      (JSC::DFG::StructureSet::StructureSet):
      (JSC::DFG::StructureSet::add):
      (JSC::DFG::StructureSet::addAll):
      (JSC::DFG::StructureSet::remove):
      (JSC::DFG::StructureSet::contains):
      (JSC::DFG::StructureSet::isSubsetOf):
      (JSC::DFG::StructureSet::isSupersetOf):
      (JSC::DFG::StructureSet::size):
      (JSC::DFG::StructureSet::at):
      (JSC::DFG::StructureSet::operator[]):
      (JSC::DFG::StructureSet::last):
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::privateCompileGetByIdSelfList):
      (JSC::JIT::privateCompileGetByIdProtoList):
      (JSC::JIT::privateCompileGetByIdChainList):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::privateCompileGetByIdSelfList):
      (JSC::JIT::privateCompileGetByIdProtoList):
      (JSC::JIT::privateCompileGetByIdChainList):
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      (JSC::getPolymorphicAccessStructureListSlot):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      752f7d98