1. 08 Apr, 2011 40 commits
    • antti@apple.com's avatar
      Not reviewed. · 94f17cbe
      antti@apple.com authored
      Skip for DRT differences.
      
      * platform/mac-wk2/Skipped:
      * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94f17cbe
    • mjs@apple.com's avatar
      2011-04-08 Maciej Stachowiak <mjs@apple.com> · 60484939
      mjs@apple.com authored
              Reviewed by Darin Adler.
      
              -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
              https://bugs.webkit.org/show_bug.cgi?id=58128
              <rdar://problem/9244553>
              
              The root of the problem here was an O(N^2) issue - each WebView,
              upon having its preferences initialized, would broadcast a
              notification that was listened to by all other WebViews sharing
              its preferences.
              
              To maintain the API contract, I split the notification into two,
              one that is for public API consumption, and the other which is for
              internal use only. Changes that don't need to be picked up by
              other WebViews broadcast the public notification only. And we
              avoid WebView broadcasting a notification just to get itself to
              update.
      
              * Misc/WebIconDatabase.mm:
              (-[WebIconDatabase _startUpIconDatabase]):
              (-[WebIconDatabase _shutDownIconDatabase]):
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
              (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
              (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
              (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
              * WebView/WebPreferences.mm:
              (-[WebPreferences initWithIdentifier:]):
              (-[WebPreferences _setStringValue:forKey:]):
              (-[WebPreferences _setIntegerValue:forKey:]):
              (-[WebPreferences _setFloatValue:forKey:]):
              (-[WebPreferences _setBoolValue:forKey:]):
              (-[WebPreferences _setLongLongValue:forKey:]):
              (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
              (-[WebPreferences _postPreferencesChangedNotification]):
              (-[WebPreferences _postPreferencesChangedAPINotification]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
              (-[WebView _preferencesChangedNotification:]):
              (-[WebView _preferencesChanged:]):
              (-[WebView setUsesPageCache:]):
              (+[WebView initialize]):
              (-[WebView setPreferences:]):
              (-[WebView _keyboardUIMode]):
              * WebView/WebViewInternal.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60484939
    • commit-queue@webkit.org's avatar
      2011-04-08 Siddharth Mathur <siddharth.mathur@nokia.com> · 13b2b056
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [Qt][WK2][Symbian] Remove use of stack arrays with variable size
              https://bugs.webkit.org/show_bug.cgi?id=57877
      
              For better compiler portability, use new/delete for arrays when size
              isn't known at compile time. Also fix one compiler warning about bitshift
              operations on signed integer
              * Platform/CoreIPC/unix/ConnectionUnix.cpp:
              (CoreIPC::Connection::readyReadHandler):
              (CoreIPC::Connection::sendOutgoingMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13b2b056
    • rniwa@webkit.org's avatar
      2011-04-08 Ryosuke Niwa <rniwa@webkit.org> · 8073bff2
      rniwa@webkit.org authored
              Reviewed by Tony Chang, Darin Adler, and Enrica Casucci.
      
              REGRESSION(r81887): Crash in SplitElement
              https://bugs.webkit.org/show_bug.cgi?id=57743
      
              The crash was caused by ReplaceSelectionCommand::doApply's calling splitElement with computeNodeAfterPosition
              even when the position was after the last node in it container. Since all we are doing here is to splitting tree
              up until the highest ancestor with isInlineNodeWithStyle, replaced the while loop by calls to splitTreeToNode
              and highestEnclosingNodeOfType.
      
              Also fixed a bug in splitTreeToNode not to check the difference in visible position when splitting the ancestor,
              which would have introduced unnecessary nodes when splitting tree and a bug in highestEnclosingNodeOfType that
              it incorrectly called deprecatedNode instead of containerNode.
      
              Test: editing/inserting/insert-images-in-pre-x-crash.html
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::splitTreeToNode):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/htmlediting.cpp:
              (WebCore::highestEnclosingNodeOfType):
      2011-04-08  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Tony Chang, Darin Adler, and Enrica Casucci.
      
              REGRESSION(r81887): Crash in SplitElement
              https://bugs.webkit.org/show_bug.cgi?id=57743
      
              Added a regression test for a crash in ReplaceSelectionCommand.
      
              * editing/inserting/insert-images-in-pre-x-crash-expected.txt: Added.
              * editing/inserting/insert-images-in-pre-x-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8073bff2
    • antti@apple.com's avatar
      Incoming source should be preload scanned when the parser is blocked · 559a988d
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=58117
      
      Reviewed by Tony Gentilcore.
      
      Source/WebCore: 
      
      Scan the appended source if parser is blocked.
      
      Test: http/tests/loading/preload-append-scan.php
      
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::append):
      
      LayoutTests: 
      
      * http/tests/loading/preload-append-scan-expected.txt: Added.
      * http/tests/loading/preload-append-scan.php: Added.
      * http/tests/resources/slow-script.pl: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      559a988d
    • commit-queue@webkit.org's avatar
      2011-04-08 Varun Jain <varunjain@chromium.org> · b3e35558
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              Need to extend WebKit chromium API to access text selection
              https://bugs.webkit.org/show_bug.cgi?id=57888
      
              *  Source/WebKit/chromium/public/WebFrame.h:
              *  Source/WebKit/chromium/public/WebWidget.h:
              *  Source/WebKit/chromium/src/WebFrameImpl.cpp:
              *  Source/WebKit/chromium/src/WebFrameImpl.h:
              *  Source/WebKit/chromium/src/WebPopupMenuImpl.h:
              *  Source/WebKit/chromium/src/WebViewImpl.cpp:
              *  Source/WebKit/chromium/src/WebViewImpl.h:
              *  Source/WebKit/chromium/tests/PopupMenuTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3e35558
    • mrobinson@webkit.org's avatar
      2011-04-08 Martin Robinson <mrobinson@igalia.com> · 55cb70aa
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Fix the WebKit2 build for older versions of GTK+
              https://bugs.webkit.org/show_bug.cgi?id=58095
      
              No new tests. This is just a build fix.
      
              * platform/gtk/GtkVersioning.c:
              (gdk_window_create_similar_surface): Reimplement this method for older versions of GDK.
              * platform/gtk/GtkVersioning.h: Add the new method to the header.
      2011-04-08  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] Fix the WebKit2 build for older versions of GTK+
              https://bugs.webkit.org/show_bug.cgi?id=58095
      
              * UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Include the GtkVersioning.h header.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55cb70aa
    • jianli@chromium.org's avatar
      Unreviewed, fixed a typo in chromium test expectation list. · 694cc9c4
      jianli@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      694cc9c4
    • jianli@chromium.org's avatar
      Unreviewed, added one more failed test to test expectation list in chromium. · 013e8745
      jianli@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      013e8745
    • commit-queue@webkit.org's avatar
      2011-04-08 Misha Tyutyunik <michael.tyutyunik@nokia.com> · 66bb9ee3
      commit-queue@webkit.org authored
              Reviewed by Laszlo Gombos.
      
              [Qt] Plugin is not scrolled together with page content or jumping
              when content is rendered using cache (backing store).
              https://bugs.webkit.org/show_bug.cgi?id=56130
      
              This is a Symbian portion of the fix. For Linux it looks like
              it's enough to call set geometry which should be addressed in
              https://bugs.webkit.org/show_bug.cgi?id=57179
      
              No new tests required. This can be tested with manual tests from
              WebCore/manual-tests/qt and WebCore/manual-tests/plugins
      
              * plugins/symbian/PluginViewSymbian.cpp:
              (WebCore::PluginView::updatePluginWidget):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66bb9ee3
    • jianli@chromium.org's avatar
      Unreviewed, added failed tests to test expectation list in chromium. · 85f4421b
      jianli@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85f4421b
    • inferno@chromium.org's avatar
      2011-04-08 Abhishek Arya <inferno@chromium.org> · 058216db
      inferno@chromium.org authored
              Unreviewed. Remove accidental printf added in r83306.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::sendContextMenuEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      058216db
    • commit-queue@webkit.org's avatar
      2011-04-08 Pere Martir <pere.martir4@gmail.com> · d8e1e491
      commit-queue@webkit.org authored
              Reviewed by Adam Roben.
      
              Locate NSTD.EXE in 64-bit Windows
              https://bugs.webkit.org/show_bug.cgi?id=57847
      
              * Scripts/old-run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8e1e491
    • enrica@apple.com's avatar
      Dragging text in a WebKit2 window results in a copy instead of a move. · 18fff928
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56772
      <rdar://problem/9165140>
      
      Reviewed by Darin Adler.
      
      cleanupAfterSystemDrag cannot call dragEnd in WebKit2, since
      the call to startDrag is asynchronous.
              
      * page/mac/DragControllerMac.mm:
      (WebCore::DragController::cleanupAfterSystemDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18fff928
    • kbalazs@webkit.org's avatar
      2011-04-07 Balazs Kelemen <kbalazs@webkit.org> · 07455fa6
      kbalazs@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [WK2][Qt][GTK] Introduce common use flag for the shared UNIX domain socket IPC implementation
              https://bugs.webkit.org/show_bug.cgi?id=58030
      
              * wtf/Platform.h: Introduce USE(UNIX_DOMAIN_SOCKETS) for WebKit2.
      2011-04-07  Balazs Kelemen  <kbalazs@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [WK2][Qt][GTK] Introduce common use flag for the shared UNIX domain socket IPC implementation
              https://bugs.webkit.org/show_bug.cgi?id=58030
      
              Replace "PLATFORM(QT) || PLATFORM(GTK)" conditions in IPC code with
              USE(UNIX_DOMAIN_SOCKETS).
      
              * Platform/CoreIPC/Attachment.h:
              * Platform/CoreIPC/Connection.h:
              * Platform/SharedMemory.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07455fa6
    • andersca@apple.com's avatar
      2011-04-07 Anders Carlsson <andersca@apple.com> · 1b582bcf
      andersca@apple.com authored
              Reviewed by Simon Fraser.
      
              Clicks not recognized on http://www.nibblestutorials.net/ which uses Silverlight
              https://bugs.webkit.org/show_bug.cgi?id=58108
              <rdar://problem/9167611>
      
              Change platformHandleMouseEvent to return true, which means that the plug-in has handled the
              event. Some plug-ins (like Silverlight) will return false from NPP_HandleEvent even though the
              event has been handled. In this case it lead to a very subtle bug where the plug-in element would
              lose focus right after a mouse down even had been sent.
      
              * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
              (WebKit::NetscapePlugin::platformHandleMouseEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b582bcf
    • commit-queue@webkit.org's avatar
      2011-04-08 Sheriff Bot <webkit.review.bot@gmail.com> · d0941063
      commit-queue@webkit.org authored
              Unreviewed, rolling out r83295.
              http://trac.webkit.org/changeset/83295
              https://bugs.webkit.org/show_bug.cgi?id=58144
      
              Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
      
              * platform/qt/Skipped:
      2011-04-08  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r83295.
              http://trac.webkit.org/changeset/83295
              https://bugs.webkit.org/show_bug.cgi?id=58144
      
              Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::handleInputMethodKeydown):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0941063
    • sergio@webkit.org's avatar
      2011-04-08 Sergio Villar Senin <svillar@igalia.com> · 239c6ef3
      sergio@webkit.org authored
              Unreviewed, looks like the test is working fine now.
      
              [GTK] websocket/tests/bad-sub-protocol-control-chars.html fails on 32-bit Debug bot
              https://bugs.webkit.org/show_bug.cgi?id=46942
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      239c6ef3
    • aroben@apple.com's avatar
      Qt build fix · 3912059c
      aroben@apple.com authored
      * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3912059c
    • commit-queue@webkit.org's avatar
      2011-04-08 Jon Lee <jonlee@apple.com> · 7a4a2735
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              adding *.vcproj.*.user to .gitignore for Visual Studio development
              https://bugs.webkit.org/show_bug.cgi?id=58097
      
              * .gitignore:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a4a2735
    • aroben@apple.com's avatar
      Pass NPP_SetWindow a null window handle during plugin destruction on non-Mac platforms · ae094af7
      aroben@apple.com authored
      This matches WebKit1.
      
      Fixes <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
      plugin
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit2:
      
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::destroy): Null out our NPWindow's window handle and pass it to
      NPP_SetWindow (unless we're on Mac).
      
      Tools:
      
      Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
      
      * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
      (pluginLogWithArguments): Moved code to format and log the message here...
      (pluginLog): ...from here.
      
      * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
      
      * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
      (PluginTest::log): Added. Calls through to pluginLogWithArguments.
      
      * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
      
      * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
      (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
      to begin.
      (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
      constructor.
      (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
      can be used to invoke our setWillBeDestroyed function.
      (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
      anything unexpected happens).
      (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
      NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
      NPP_SetWindow was *not* called during destruction.
      (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
      method, setWillBeDestroyed.
      (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
      object.
      
      * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
      * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
      * GNUmakefile.am:
      Added new test.
      
      * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
      WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
      
      LayoutTests:
      
      Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
      
      * platform/win-wk2/Skipped: Removed a test that no longer crashes thanks to this fix.
      
      * plugins/npp-set-window-called-during-destruction-expected.txt: Added.
      * plugins/npp-set-window-called-during-destruction.html: Added.
      
      * platform/mac/plugins/npp-set-window-called-during-destruction-expected.txt: Added. This is
      different from the cross-platform results because we don't expect NPP_SetWindow to be called
      during destruction.
      
      * platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Added. This is
      a copy of the cross-platform results, needed to override the Mac-specific results.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae094af7
    • aroben@apple.com's avatar
      Clean build fix · 89007679
      aroben@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Don't try to delete directories that
      don't exist. Also switched from del /s to rmdir /s, which has the benefit of deleting the
      directory itself in addition to the files it contains.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89007679
    • dglazkov@chromium.org's avatar
      2011-04-05 Dimitri Glazkov <dglazkov@chromium.org> · 72e43ec9
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Move WheelEvent-dispatching logic into WheelEventDispatchMediator.
              https://bugs.webkit.org/show_bug.cgi?id=57642
      
              Covered by existing tests, no functional change.
      
              * dom/Event.cpp:
              * dom/Event.h:
              (WebCore::EventDispatchMediator::EventDispatchMediator): Added default
                  constructor.
              (WebCore::EventDispatchMediator::event): Inlined.
              (WebCore::EventDispatchMediator::setEvent): Added.
              * dom/EventDispatcher.cpp: Removed dispatchWheelEvent.
              * dom/EventDispatcher.h: Updated decls.
              * dom/Node.cpp:
              (WebCore::Node::dispatchWheelEvent): Changed to use the mediator and
                  return a bool, like other dispatch event functions.
              * dom/Node.h: Changed decl.
              * dom/WheelEvent.cpp:
              (WebCore::granularity): Moved from EventDispatcher.
              (WebCore::WheelEventDispatchMediator::WheelEventDisatchMediator): Added.
              (WebCore::WheelEventDispatchMediator::event): Added.
              (WebCore::WheelEventDispatchMediator::dispatchEvent): Added.
              * dom/WheelEvent.h: Updated decls.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleWheelEvent): Changed to receive and react
                  to the return value.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72e43ec9
    • commit-queue@webkit.org's avatar
      2011-04-08 Jamie Cooley <james.cooley@nokia.com> · 7bd03880
      commit-queue@webkit.org authored
              Reviewed by Benjamin Poulain.
      
              [Qt][WK2] Make sure qwkhistory.h is copied into includes/WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=57945
      
              * UIProcess/API/qt/WKView.h:
              * UIProcess/API/qt/qwkhistory.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bd03880
    • jberlin@webkit.org's avatar
      Windows build warning fix. · e831e6af
      jberlin@webkit.org authored
      * WebCore.vcproj/WebCore.vcproj:
      Since ShadowRoot.cpp is included in the DOMAllInOne.cpp file, it should be excluded from
      the build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e831e6af
    • yi.4.shen@nokia.com's avatar
      2011-04-08 Yi Shen <yi.4.shen@nokia.com> · e80e3dbe
      yi.4.shen@nokia.com authored
              Reviewed by Antonio Gomes.
      
              [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
              https://bugs.webkit.org/show_bug.cgi?id=57472
      
              Unskips the fast/events/onsearch-enter.html test.
      
              * platform/qt/Skipped:
      2011-04-08  Yi Shen  <yi.4.shen@nokia.com>
      
              Reviewed by Antonio Gomes.
      
              [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
              https://bugs.webkit.org/show_bug.cgi?id=57472
      
              Avoid to insert new line for both keydown event & keypress event.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::handleInputMethodKeydown):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e80e3dbe
    • podivilov@chromium.org's avatar
      2011-04-07 Pavel Podivilov <podivilov@chromium.org> · 13b82ef5
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: update breakpoints according to source frame decorations after live edit.
              https://bugs.webkit.org/show_bug.cgi?id=58029
      
              * inspector/debugger/live-edit-expected.txt:
              * inspector/debugger/live-edit.html:
      2011-04-07  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: update breakpoints according to source frame decorations after live edit.
              https://bugs.webkit.org/show_bug.cgi?id=58029
      
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent.didEditScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent):
              * inspector/front-end/SourceFile.js:
              (WebInspector.SourceFile.prototype.set content):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
              (WebInspector.SourceFrame.prototype._handleSave):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13b82ef5
    • podivilov@chromium.org's avatar
      2011-04-08 Pavel Podivilov <podivilov@chromium.org> · bb843073
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: fix scripts concatenation in scripts panel.
              https://bugs.webkit.org/show_bug.cgi?id=58138
      
              When there is just one script starting at 0:0 it should not be surrounded by <script> framing.
      
              * inspector/front-end/SourceFile.js:
              (WebInspector.SourceFile.prototype._loadResourceContent):
              (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb843073
    • steveblock@google.com's avatar
      2011-04-08 Steve Block <steveblock@google.com> · 63d1254e
      steveblock@google.com authored
              Unreviewed build fix.
      
              Media Stream API: add the getUserMedia method and the Javascript bindings
              https://bugs.webkit.org/show_bug.cgi?id=56586
      
              Add new tests to skipped lists for platforms where the feature is not
              enabled.
      
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63d1254e
    • yurys@chromium.org's avatar
      2011-04-08 Yury Semikhatsky <yurys@chromium.org> · 76b4e593
      yurys@chromium.org authored
              Unreviewed. Update Chromium test expectations to match results after rolling
              v8 revision that reports stack overflow exception to the console.
      
              * platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
              * platform/chromium-win/fast/js/recursion-limit-equal-expected.txt: Removed.
              * platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt.
              * platform/chromium/fast/js/recursion-limit-equal-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/js/recursion-limit-equal-expected.txt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76b4e593
    • pfeldman@chromium.org's avatar
      2011-04-08 Pavel Feldman <pfeldman@chromium.org> · 99d6041b
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements.
              https://bugs.webkit.org/show_bug.cgi?id=58118
      
              This change reuses location for call frames in the protocol + structures script
              location <-> source lines interaction better. When we need UI columns, we will add
              them, but we should distinguish between script and UI terms on the type level, not naming.
      
              * English.lproj/localizedStrings.js:
              * bindings/v8/DebuggerScript.js:
              * inspector/InjectedScriptSource.js:
              * inspector/Inspector.json:
              * inspector/front-end/CallStackSidebarPane.js:
              (WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLine):
              (WebInspector.CallStackSidebarPane.prototype.update):
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestSourceMapping):
              (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage):
              (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
              (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
              (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
              (WebInspector.PresenationCallFrame):
              (WebInspector.PresenationCallFrame.prototype.sourceLine.didRequestSourceMapping):
              (WebInspector.PresenationCallFrame.prototype.sourceLine):
              * inspector/front-end/ScriptFormatter.js:
              (WebInspector.ScriptFormatter.locationToPosition):
              (WebInspector.ScriptFormatter.lineToPosition):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
              (WebInspector.ScriptsPanel.prototype._debuggerPaused):
              (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
              (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
              (WebInspector.ScriptsPanel.prototype._callFrameSelected):
              * inspector/front-end/SourceFile.js:
              (WebInspector.SourceMapping.prototype.scriptLocationToSourceLine):
              (WebInspector.SourceMapping.prototype.sourceLineToScriptLocation):
              (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
              (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99d6041b
    • podivilov@chromium.org's avatar
      2011-04-08 Pavel Podivilov <podivilov@chromium.org> · 6782b967
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: distinguish breakpoints set on de-obfuscated sources from breakponts set on original sources.
              https://bugs.webkit.org/show_bug.cgi?id=58133
      
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
              (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
              (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
              (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
              (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
              (WebInspector.DebuggerPresentationModel.prototype._reset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6782b967
    • podivilov@chromium.org's avatar
      2011-04-07 Pavel Podivilov <podivilov@chromium.org> · 9a8b7d06
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: make SourceFrame TextViewer's delegate for editing operations.
              https://bugs.webkit.org/show_bug.cgi?id=58026
      
              This is the first step of decoupling TextViewer from SourceFrame.
      
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              (WebInspector.SourceFrame.prototype.show):
              (WebInspector.SourceFrame.prototype.hide):
              (WebInspector.SourceFrame.prototype._ensureContentLoaded):
              (WebInspector.SourceFrame.prototype.contentEditable):
              (WebInspector.SourceFrame.prototype.startEditing):
              (WebInspector.SourceFrame.prototype.endEditing):
              (WebInspector.SourceFrame.prototype._createTextViewer):
              (WebInspector.SourceFrame.prototype._handleSave):
              (WebInspector.SourceFrame.prototype._handleRevertEditing):
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
              (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
              (WebInspector.TextViewer.prototype._syncDecorationsForLine):
              (WebInspector.TextViewer.prototype._doubleClick):
              (WebInspector.TextViewerDelegate):
              (WebInspector.TextViewerDelegate.prototype.contentEditable):
              (WebInspector.TextViewerDelegate.prototype.startEditing):
              (WebInspector.TextViewerDelegate.prototype.endEditing):
              (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
              (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
              * inspector/front-end/inspector.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a8b7d06
    • steveblock@google.com's avatar
      2011-04-08 Leandro Gracia Gil <leandrogracia@chromium.org> · fab8862c
      steveblock@google.com authored
              Reviewed by Steve Block.
      
              Media Stream API: add the getUserMedia method and the Javascript bindings.
              https://bugs.webkit.org/show_bug.cgi?id=56586
      
              Test the Javascript behaviour of the getUserMedia method with different types of arguments.
              Current specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication
      
              * fast/dom/MediaStream/argument-types-expected.txt: Added.
              * fast/dom/MediaStream/argument-types.html: Added.
              * fast/dom/MediaStream/enabled-expected.txt: Added.
              * fast/dom/MediaStream/enabled.html: Added.
              * fast/dom/MediaStream/no-interface-object-expected.txt: Added.
              * fast/dom/MediaStream/no-interface-object.html: Added.
              * fast/dom/MediaStream/script-tests/argument-types.js: Added.
              (shouldNotThrow):
              (test):
              (emptyFunction):
              ():
              (ObjectThrowingException.prototype.valueOf):
              (ObjectThrowingException.prototype.toString):
              * fast/dom/MediaStream/script-tests/enabled.js: Added.
              (hasGetUserMediaProperty):
              * fast/dom/MediaStream/script-tests/no-interface-object.js: Added.
              (test):
      2011-04-08  Leandro Gracia Gil  <leandrogracia@chromium.org>
      
              Reviewed by Steve Block.
      
              Media Stream API: add the getUserMedia method and the Javascript bindings.
              https://bugs.webkit.org/show_bug.cgi?id=56586
      
              Add the getUserMedia method to the navigator and its new Javascript types.
              Current specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication
      
              Tests: fast/dom/MediaStream/argument-types.html
                     fast/dom/MediaStream/enabled.html
                     fast/dom/MediaStream/no-interface-object.html
      
              * Android.derived.jscbindings.mk:
              * Android.derived.v8bindings.mk:
              * Android.v8bindings.mk:
              * CMakeLists.txt:
              * CodeGenerators.pri:
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.list.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSNavigatorCustom.cpp:
              (WebCore::JSNavigator::webkitGetUserMedia):
              * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
              (WebCore::V8Navigator::webkitGetUserMediaCallback):
              * page/Navigator.cpp:
              (WebCore::Navigator::webkitGetUserMedia):
              * page/Navigator.h:
              * page/Navigator.idl:
              * page/NavigatorUserMediaError.h: Added.
              (WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
              (WebCore::NavigatorUserMediaError::~NavigatorUserMediaError):
              (WebCore::NavigatorUserMediaError::code):
              * page/NavigatorUserMediaError.idl: Added.
              * page/NavigatorUserMediaErrorCallback.h: Added.
              (WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):
              * page/NavigatorUserMediaErrorCallback.idl: Added.
              * page/NavigatorUserMediaSuccessCallback.h: Added.
              (WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):
              * page/NavigatorUserMediaSuccessCallback.idl: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fab8862c
    • mnaganov@chromium.org's avatar
      2011-04-08 Mikhail Naganov <mnaganov@chromium.org> · 25c17aa9
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
              https://bugs.webkit.org/show_bug.cgi?id=58010
              https://bugs.webkit.org/show_bug.cgi?id=58011
      
              Added tests for "Containment" view. Minor refactorings, bugs fixed.
              Split one large tests into smaller ones to avoid timing out in debug mode.
      
              Tests: inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html
                     inspector/profiler/detailed-heapshots-containment-show-all.html
                     inspector/profiler/detailed-heapshots-containment-show-next.html
                     inspector/profiler/detailed-heapshots-containment-sorting.html
                     inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html
                     inspector/profiler/detailed-heapshots-summary-show-all.html
                     inspector/profiler/detailed-heapshots-summary-show-next.html
                     inspector/profiler/detailed-heapshots-summary-sorting.html
      
              * inspector/front-end/DetailedHeapshotGridNodes.js:
              (WebInspector.HeapSnapshotGridNode):
              (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
              (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
              (WebInspector.HeapSnapshotGridNode.prototype.sort):
              (WebInspector.HeapSnapshotGenericObjectNode):
              (WebInspector.HeapSnapshotObjectNode):
              (WebInspector.HeapSnapshotInstanceNode):
              (WebInspector.HeapSnapshotConstructorNode):
              (WebInspector.HeapSnapshotDiffNode):
              (WebInspector.HeapSnapshotDominatorObjectNode):
              * inspector/front-end/DetailedHeapshotView.js:
              (WebInspector.HeapSnapshotContainmentDataGrid):
              (WebInspector.HeapSnapshotDominatorsDataGrid):
      
      2011-04-08  Mikhail Naganov  <mnaganov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
              https://bugs.webkit.org/show_bug.cgi?id=58010
              https://bugs.webkit.org/show_bug.cgi?id=58011
      
              Added tests for "Containment" view. Minor refactorings, bugs fixed.
              Split one large tests into smaller ones to avoid timing out in debug mode.
      
              * inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html: Added.
              * inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-containment-show-all.html: Added.
              * inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-containment-show-next.html: Added.
              * inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-containment-sorting.html: Added.
              * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html: Added.
              * inspector/profiler/detailed-heapshots-summary-expected.txt: Removed.
              * inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-summary-show-all.html: Added.
              * inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-summary-show-next.html: Added.
              * inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-summary-sorting.html: Added.
              * inspector/profiler/detailed-heapshots-summary.html: Removed.
              * inspector/profiler/detailed-heapshots-test.js:
              (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):
              (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest):
              (initialize_DetailedHeapshotTest.):
              (initialize_DetailedHeapshotTest):
              * platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Copied from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
              * platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
              * platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
              * platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
              * platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
              * platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
              * platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
              * platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25c17aa9
    • podivilov@chromium.org's avatar
      2011-04-08 Andrey Adaikin <aandrey@google.com> · 9fdebe06
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Bugs in some corner cases in the text editor
              https://bugs.webkit.org/show_bug.cgi?id=58025
      
              This solves the following bugs:
              1) The very last _empty_ line would not be deleted if you hit a Backspace on it, or the selection text to be deleted is extended to the very bottom of the editor.
              2) An odd corner case: delete all source code from the editor, hit backspace on the only empty line, then add a character. In this case the browser will insert a TEXT node instead of a DIV node for a lineRow.
      
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
              (WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf):
              (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
              (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
              (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fdebe06
    • podivilov@chromium.org's avatar
      2011-04-07 Pavel Podivilov <podivilov@chromium.org> · 68c7ef15
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: add test for script formatter worker.
              https://bugs.webkit.org/show_bug.cgi?id=57447
      
              * inspector/debugger/script-formatter-expected.txt: Added.
              * inspector/debugger/script-formatter.html: Added.
              * platform/chromium/test_expectations.txt:
      2011-04-07  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: add test for script formatter worker.
              https://bugs.webkit.org/show_bug.cgi?id=57447
      
              Test: inspector/debugger/script-formatter.html
      
              * GNUmakefile.am:
              * WebCore.xcodeproj/project.pbxproj:
              * gyp/streamline-inspector-source.sh:
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel.prototype._addScript):
              (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
              (WebInspector.DebuggerPresentationModel.prototype._formatter):
              * inspector/front-end/ScriptFormatterWorker.js:
      2011-04-07  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: add test for script formatter worker.
              https://bugs.webkit.org/show_bug.cgi?id=57447
      
              * WebKit.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68c7ef15
    • tkent@chromium.org's avatar
      2011-04-08 Kent Tamura <tkent@chromium.org> · 051d41fb
      tkent@chromium.org authored
              [Chromium] Note some flaky tests.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      051d41fb
    • tkent@chromium.org's avatar
      2011-04-08 Kent Tamura <tkent@chromium.org> · 2f7f1e85
      tkent@chromium.org authored
              [Chromium] The second attempt of fixing for Windows (dbg)(shared) build.
      
              * WebKit.gyp: webkit should not depend on webkit_support.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f7f1e85
    • carlosgc@webkit.org's avatar
      2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com> · f8c95ba9
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Do not destroy WorkQueue event sources unless they have been cancelled
              https://bugs.webkit.org/show_bug.cgi?id=57611
      
              * Platform/WorkQueue.h:
              * Platform/gtk/WorkQueueGtk.cpp:
              (WorkQueue::EventSource::EventSource): Remove unused member
              m_dispatchSource.
              (WorkQueue::EventSource::executeEventSource): Make it return void
              instead of boolean since we are always ignoring the return value.
              (WorkQueue::EventSource::performWork): Return FALSE from the
              callback only when the source has been cancelled (condition = 0)
              to make sure it's destroyed when the even source handler is
              unregistered.
              (WorkQueue::registerEventSourceHandler): Use GRefPtr for the
              source, to avoid leaking it.
              (WorkQueue::scheduleWorkOnSource): Receive the source callback as
              parameter so that it can be used by scheduleWorkOnTermination() too.
              (WorkQueue::scheduleWork):
              (WorkQueue::scheduleWorkAfterDelay):
              (WorkQueue::scheduleWorkOnTermination): Use
              scheduleWorkOnSource().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8c95ba9