1. 23 Feb, 2006 12 commits
    • darin's avatar
      Reviewed by John Sullivan. · 947a31b6
      darin authored
              - moved QMouseEvent, QKeyEvent, QWheelEvent, and "Foundation extras"
                from kwq to platform directory
              - moved history function from kwq to bridge directory
              - eliminated QEvent, MousePressEvent, MouseDoubleClickEvent, MouseMoveEvent,
                MoveReleaseEvent, and DrawContents classes
              - merged NodeImpl::MouseEvent and the MouseEvent from khtml_events.h into
                a single class in the page directory
              - broke khtmllayout.h out into a file for the Length structure in the css
                directory and a file for the GapRects structure in the rendering directory
              - redid the Length structure to work more portably by not relying on bitfield
                layout and improve the names to no longer explicitly mention "width"
              - reduced use of QGuardedPtr and other uses of the QObject "destroyed" signal
      
              * ForwardingHeaders/kparts: Removed.
              * ForwardingHeaders/qevent.h: Removed.
              * khtml/khtml_events.cpp: Removed.
              * khtml/khtml_events.h: Removed.
              * khtml/misc/khtmllayout.h: Removed.
              * kwq/KWQEvent.h: Removed.
              * kwq/KWQEvent.mm: Removed.
              * kwq/KWQFoundationExtras.h: Removed.
              * kwq/KWQKHistoryProvider.mm: Removed.
              * kwq/KWQKPartsHistoryProvider.h: Removed.
      
              * bridge/History.h: Added.
              * bridge/mac/HistoryMac.mm: Added.
              * css/Length.h: Added.
              * page/MouseEventWithHitTestResults.h: Added.
              * platform/KeyEvent.h: Added.
              * platform/MouseEvent.h: Added.
              * platform/WheelEvent.h: Added.
              * platform/mac/FoundationExtras.h: Added.
              * platform/mac/KeyEventMac.mm: Added.
              * platform/mac/MouseEventMac.mm: Added.
              * platform/mac/WheelEventMac.mm: Added.
              * rendering/GapRects.h: Added.
      
              * WebCore.xcodeproj/project.pbxproj: Updated for above changes.
              * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.
      
              * bridge/mac/MacFrame.h: Removed unused parameters from urlSelected functions.
              Replaced MouseEvent, MousePressEvent, MouseMoveEvent, and MouseReleaseEvent
              with MouseEventWithHitTestResults.
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::urlSelected): Removed unused parameters.
              (WebCore::MacFrame::wheelEvent): Changed to use WheelEvent.
              (WebCore::MacFrame::keyEvent): Changed to use KeyEvent.
              (WebCore::MacFrame::khtmlMousePressEvent): Changed parameter type.
              (WebCore::MacFrame::khtmlMouseMoveEvent): Ditto.
              (WebCore::MacFrame::khtmlMouseReleaseEvent): Ditto.
              (WebCore::MacFrame::passSubframeEventToSubframe): Ditto.
              (WebCore::MacFrame::mouseDown): Changed to use MouseEvent.
              (WebCore::MacFrame::mouseDragged): Ditto.
              (WebCore::MacFrame::mouseUp): Ditto.
              (WebCore::MacFrame::mouseMoved): Ditto.
              (WebCore::MacFrame::sendContextMenuEvent): Ditto.
      
              * css/csshelper.h: Removed a bunch of unused declarations.
      
              * dom/DocumentImpl.h:
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::prepareMouseEvent): Changed to take a MouseEvent
              and return a MouseEventWithHitTestResults.
              (WebCore::DocumentImpl::defaultEventHandler): Changed to use KeyEvent.
      
              * dom/NodeImpl.h: Removed NodeImpl::MouseEvent and NodeImpl::MouseEventType.
              * dom/NodeImpl.cpp:
              (WebCore::NodeImpl::dispatchMouseEvent): Changed to always get the type and
              detail values from the caller, never from the event. Changed to use MouseEvent.
              (WebCore::NodeImpl::dispatchKeyEvent): Changed to use KeyEvent.
              (WebCore::NodeImpl::dispatchWheelEvent): Changed to use WheelEvent.
      
              * dom/dom2_eventsimpl.h:
              * dom/dom2_eventsimpl.cpp:
              (WebCore::KeyboardEventImpl::KeyboardEventImpl): Changed to use KeyEvent.
              (WebCore::KeyboardEventImpl::charCode): Ditto.
      
              * dom/dom_elementimpl.h: Removed unused mouseEventHandler function.
      
              * khtml/ecma/domparser.h: Use RefPtr instead of QGuardedPtr to hold the reference
              to the document.
      
              * khtml/ecma/kjs_proxy.h: (WebCore::KJSProxyImpl::haveInterpreter): Added. For
              use in the Frame destructor so we can get an existing KJS::Window object without
              creating a new interpreter and window object.
      
              * khtml/ecma/kjs_window.h: Merged WindowQObject into Window. Changed all the
              guarded pointers to Frame to use plain old pointers that are cleared by the
              Frame explicitly (by the function disconnectFrame). Made the pointers to all
              the sub-objects of KJS::Window be mutable so we don't have to const_cast in
              the functions to get (and lazily create) them.
              * khtml/ecma/kjs_window.cpp:
              (KJS::DOMWindowTimer::DOMWindowTimer): Use Window* instead of WindowQObject*.
              (KJS::History::disconnectFrame): Added. Clears m_frame.
              (KJS::FrameArray::disconnectFrame): Added. Clears m_frame.
              (KJS::Window::Window): Removed code to create a WindowQObject.
              (KJS::Window::~Window): Removed code to delete a WindowQObject.
              (KJS::Window::location): Remove now-unneeded const_cast.
              (KJS::Window::selection): Ditto.
              (KJS::Window::locationbar): Ditto.
              (KJS::Window::menubar): Ditto.
              (KJS::Window::personalbar): Ditto.
              (KJS::Window::statusbar): Ditto.
              (KJS::Window::toolbar): Ditto.
              (KJS::Window::scrollbars): Ditto.
              (KJS::Window::getValueProperty): Update since m_frame is now a raw pointer.
              (KJS::Window::getOwnPropertySlot): Ditto.
              (KJS::Window::toBoolean): Ditto.
              (KJS::Window::scheduleClose): Remove assert that WindowQObject* is not null.
              (KJS::Window::isSafeScript): Update since m_frame is now a raw pointer.
              (KJS::Window::clear): Remove code to delete a WindowQObject. Added a call
              to clearAllTimeouts instead.
              (KJS::Window::clearAllTimeouts): Added. Does equivalent of the WindowQObject
              destructor.
              (KJS::Window::installTimeout): Moved to Window from WindowQObject.
              (KJS::Window::pauseTimeouts): Ditto.
              (KJS::Window::resumeTimeouts): Ditto.
              (KJS::Window::clearTimeout): Ditto.
              (KJS::Window::timerFired): Ditto.
              (KJS::Window::disconnectFrame): Added. Sets all the frame pointers to 0.
              (KJS::FrameArray::getOwnPropertySlot): Update since m_frame is now a raw pointer.
              (KJS::Location::getOwnPropertySlot): Ditto.
              (KJS::Location::put): Ditto.
              (KJS::Selection::getOwnPropertySlot): Ditto.
              (KJS::BarInfo::getOwnPropertySlot): Ditto.
      
              * khtml/html/html_baseimpl.h: Forward-declare Length instead of including khtmllayout.h.
              * khtml/html/html_imageimpl.h: Ditto.
      
              * khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler):
              Changed to use KeyEvent and removed the code to extract the button and state from the
              DOM even to pass to urlSelected.
              * ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler): Ditto.
      
              * khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::timerFired): Change to use
              a RefPtr instead of a QGuardedPtr.
      
              * khtml/misc/helper.h:
              * khtml/misc/helper.cpp: Removed printpainter and setPrintPainter.
      
              * ksvg2/svg/SVGDocumentImpl.h:
              * ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::dispatchKeyEvent):
              Change to use KeyEvent.
      
              * kwq/KWQComboBox.mm:
              (-[KWQPopUpButton becomeFirstResponder]):
              (-[KWQPopUpButton resignFirstResponder]):
              * kwq/KWQFileButton.mm:
              (KWQFileButton::focusChanged):
              * kwq/KWQListBox.mm:
              (-[KWQTableView becomeFirstResponder]):
              (-[KWQTableView resignFirstResponder]):
              * kwq/KWQSlider.mm:
              (-[KWQSlider becomeFirstResponder]):
              (-[KWQSlider resignFirstResponder]):
              * kwq/KWQTextArea.mm:
              (-[KWQTextAreaTextView becomeFirstResponder]):
              (-[KWQTextAreaTextView resignFirstResponder]):
              * kwq/KWQTextField.mm:
              (-[KWQTextFieldController setHasFocus:]):
              Updated to use new eventFilterFocusIn/Out instead of the general purpose
              eventFilter function. This allows us to remove QEvent and the focus events.
      
              * kwq/KWQNamespace.h: Removed ButtonState.
      
              * kwq/KWQObject.h:
              * kwq/KWQObject.cpp: Replaced eventFilter function with eventFilterFocusIn and
              eventFilterFocusOut, allowing us to remove QEvent. Removed event function.
      
              * kwq/KWQSlot.cpp:
              (KWQSlot::KWQSlot): Removed the parentDestroyed slot.
              (KWQSlot::call): Ditto.
      
              * page/Frame.h:
              * page/Frame.cpp:
              (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): Renamed from
              PartStyleSheetLoader. Removed a lot of unneeded null checks. Use a
              raw Frame pointer instead of a QGuardedPtr, and count on the Frame
              to delete us when it's being deleted.
              (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): No longer
              a virtual function. This is not a polymorphic class.
              (WebCore::UserStyleSheetLoader::setStyleSheet): Remove code to delete
              ourselves -- that's now the frame's responsibility.
              (WebCore::Frame::~Frame): Call disconnectFrame on the KJS::Window and
              delete m_userStyleSheetLoader.
              (WebCore::Frame::changeLocation): Update since urlSelected no longer takes
              button and state parameters.
              (WebCore::Frame::setUserStyleSheet): Delete existing loader to stop a load
              in progress before starting a new load. Store reference to loader.
              (WebCore::Frame::urlSelected): Remove button and state parameters and unused
              local variable hasTarget.
              (WebCore::Frame::selectClosestWordFromMouseEvent): Change from QMouseEvent
              to MouseEvent.
              (WebCore::Frame::handleMousePressEventDoubleClick): Change from MousePressEvent
              to MouseEventWithHitTestResults.
              (WebCore::Frame::handleMousePressEventTripleClick): Ditto.
              (WebCore::Frame::handleMousePressEventSingleClick): Ditto.
              (WebCore::Frame::khtmlMousePressEvent): Ditto.
              (WebCore::Frame::handleMouseMoveEventSelection): Change from MouseMoveEvent
              to MouseEventWithHitTestResults.
              (WebCore::Frame::khtmlMouseMoveEvent): Ditto.
              (WebCore::Frame::khtmlMouseReleaseEvent): Change from MouseReleaseEvent
              to MouseEventWithHitTestResults.
              (WebCore::Frame::khtmlMouseDoubleClickEvent): Change from
              MouseReleaseDoubleClickEvent to MouseEventWithHitTestResults.
              (WebCore::Frame::passWidgetMouseDownEventToWidget): Change from
              NodeImpl::MouseEvent to MouseEventWithHitTestResults.
      
              * page/FramePrivate.h: Added m_userStyleSheetLoader.
      
              * page/FrameView.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::viewportMousePressEvent): Change from QMouseEvent to
              MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults.
              (WebCore::FrameView::viewportMouseDoubleClickEvent): Ditto.
              (WebCore::selectCursor): Ditto.
              (WebCore::FrameView::viewportMouseMoveEvent): Ditto.
              (WebCore::FrameView::viewportMouseReleaseEvent): Ditto.
              (WebCore::FrameView::keyPressEvent): Change from QKeyEvent to KeyEvent.
              (WebCore::FrameView::dispatchMouseEvent): Change from QMouseEvent to
              MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults.
              (WebCore::FrameView::viewportWheelEvent): Change from QWheelEvent to
              WheelEvent.
              (WebCore::FrameView::hoverTimerFired): Update for change to prepareMouseEvent
              parameters.
      
              * platform/Widget.h:
              * platform/Widget.cpp: Removed event function.
      
              * rendering/render_form.h: Removed LineEditWidget, ComboBoxWidget, TextAreaWidget.
              * rendering/render_form.cpp:
              (WebCore::RenderFormElement::slotClicked): Changed from QMouseEvent to MouseEvent.
              (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed): Updated for changes
              to the Length class.
              (WebCore::RenderSelect::setWidgetWritingDirection): Updated for removal of
              ComboBoxWidget.
              (WebCore::RenderSelect::slotSelected): Ditto.
              (WebCore::RenderSelect::createComboBox): Ditto.
      
              * rendering/render_replaced.h:
              * rendering/render_replaced.cpp:
              (WebCore::RenderWidget::destroy): Updated since removeEventFilter no longer takes
              a parameter.
              (WebCore::RenderWidget::setQWidget): Ditto.
              (WebCore::RenderWidget::eventFilterFocusIn): Added. Replaces eventFilter.
              (WebCore::RenderWidget::eventFilterFocusOut): Ditto.
      
              * css/css_computedstyle.cpp:
              (WebCore::valueForLength):
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              * css/cssstyleselector.cpp:
              (WebCore::checkPseudoState):
              (WebCore::CSSStyleSelector::applyProperty):
              (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
              * khtml/html/html_imageimpl.cpp:
              (WebCore::HTMLAreaElementImpl::getRegion):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::MarginInfo::MarginInfo):
              (WebCore::RenderBlock::isSelfCollapsingBlock):
              (WebCore::RenderBlock::layoutBlock):
              (WebCore::RenderBlock::determineHorizontalPosition):
              (WebCore::RenderBlock::leftRelOffset):
              (WebCore::RenderBlock::rightRelOffset):
              (WebCore::RenderBlock::calcMinMaxWidth):
              (WebCore::getBPMWidth):
              (WebCore::RenderBlock::calcInlineMinMaxWidth):
              (WebCore::RenderBlock::calcBlockMinMaxWidth):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::calcWidth):
              (WebCore::RenderTable::layout):
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::calcMinMaxWidth):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::addChild):
              (WebCore::RenderTableSection::addCell):
              (WebCore::RenderTableSection::calcRowHeight):
              (WebCore::RenderTableSection::layoutRows):
              * rendering/RenderText.h:
              (khtml::RenderText::marginLeft):
              (khtml::RenderText::marginRight):
              * rendering/bidi.cpp:
              (khtml::getBPMWidth):
              * rendering/render_applet.cpp:
              (WebCore::RenderApplet::createWidgetIfNecessary):
              * rendering/render_box.cpp:
              (WebCore::RenderBox::paintBackgroundExtended):
              (WebCore::RenderBox::getClipRect):
              (WebCore::RenderBox::relativePositionOffset):
              (WebCore::RenderBox::calcWidth):
              (WebCore::RenderBox::calcWidthUsing):
              (WebCore::RenderBox::sizesToIntrinsicWidth):
              (WebCore::RenderBox::calcHorizontalMargins):
              (WebCore::RenderBox::calcHeight):
              (WebCore::RenderBox::calcHeightUsing):
              (WebCore::RenderBox::calcPercentageHeight):
              (WebCore::RenderBox::calcReplacedWidth):
              (WebCore::RenderBox::calcReplacedWidthUsing):
              (WebCore::RenderBox::calcReplacedHeight):
              (WebCore::RenderBox::calcReplacedHeightUsing):
              (WebCore::RenderBox::availableHeightUsing):
              (WebCore::RenderBox::calcVerticalMargins):
              (WebCore::RenderBox::calcAbsoluteHorizontal):
              (WebCore::RenderBox::calcAbsoluteHorizontalValues):
              (WebCore::RenderBox::calcAbsoluteVertical):
              (WebCore::RenderBox::calcAbsoluteVerticalValues):
              * rendering/render_br.cpp:
              (WebCore::RenderBR::lineHeight):
              * rendering/render_flexbox.cpp:
              (khtml::RenderFlexibleBox::calcHorizontalMinMaxWidth):
              (khtml::RenderFlexibleBox::calcVerticalMinMaxWidth):
              (khtml::RenderFlexibleBox::calcMinMaxWidth):
              (khtml::RenderFlexibleBox::allowedChildFlex):
              * rendering/render_flow.cpp:
              (WebCore::RenderFlow::lineHeight):
              * rendering/render_frames.cpp:
              (WebCore::RenderFrameSet::layout):
              * rendering/render_image.cpp:
              (WebCore::RenderImage::isWidthSpecified):
              (WebCore::RenderImage::isHeightSpecified):
              * rendering/render_layer.cpp:
              (WebCore::Marquee::direction):
              (WebCore::Marquee::start):
              (WebCore::Marquee::updateMarqueeStyle):
              (WebCore::Marquee::timerFired):
              * rendering/render_line.cpp:
              (WebCore::InlineFlowBox::marginLeft):
              (WebCore::InlineFlowBox::marginRight):
              * rendering/render_object.cpp:
              (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
              (WebCore::RenderObject::paintBorderImage):
              (WebCore::RenderObject::paddingTop):
              (WebCore::RenderObject::paddingBottom):
              (WebCore::RenderObject::paddingLeft):
              (WebCore::RenderObject::paddingRight):
              (WebCore::RenderObject::getVerticalPosition):
              (WebCore::RenderObject::lineHeight):
              (WebCore::RenderObject::addDashboardRegions):
              * rendering/render_style.h:
              * rendering/render_theme_mac.mm:
              (WebCore::RenderThemeMac::addIntrinsicMargins):
              * rendering/table_layout.cpp:
              (WebCore::FixedTableLayout::calcWidthArray):
              (WebCore::FixedTableLayout::calcMinMaxWidth):
              (WebCore::FixedTableLayout::layout):
              (WebCore::AutoTableLayout::recalcColumn):
              (WebCore::AutoTableLayout::fullRecalc):
              (WebCore::AutoTableLayout::calcMinMaxWidth):
              (WebCore::AutoTableLayout::calcEffectiveWidth):
              (WebCore::AutoTableLayout::layout):
              (WebCore::AutoTableLayout::calcPercentages):
              Updated for changes to the Length class.
              Also removed a check of the printpainter global, never used in WebCore.
      
              * bindings/objc/DOM.mm:
              * bindings/objc/DOMCSS.mm:
              * bindings/objc/DOMHTML.mm:
              * bridge/mac/WebCoreFrameBridge.mm:
              * css/csshelper.cpp:
              * editing/SelectionController.cpp:
              * khtml/ecma/kjs_html.h:
              * kwq/KWQAccObject.mm:
              * kwq/KWQAccObjectCache.mm:
              * kwq/KWQClipboard.mm:
              * kwq/KWQFont.mm:
              * kwq/KWQFontMetrics.mm:
              * kwq/KWQKJobClasses.mm:
              * kwq/KWQKURL.mm:
              * kwq/KWQLoader.mm:
              * kwq/KWQPageState.mm:
              * kwq/KWQPainter.mm:
              * kwq/WebCoreSettings.mm:
              * platform/StringImpl.cpp:
              * platform/mac/CursorMac.mm:
              * platform/mac/WidgetMac.mm:
              * rendering/RenderBlock.h:
              * rendering/render_canvas.cpp:
              * rendering/render_line.h:
              * rendering/render_style.cpp:
              * rendering/table_layout.h:
              Updated includes.
      
              * bindings/js/JSDOMCore.cpp: Touched, because I got strange failures if this
              didn't rebuild.
              * bindings/js/JSDOMEvents.cpp: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      947a31b6
    • thatcher's avatar
      New build to fix the i386 arch. (The _cuEnc64 symbol was missing.) · 05690148
      thatcher authored
              * libWebKitSystemInterface.a:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05690148
    • eseidel's avatar
      2006-02-23 Eric Seidel <eseidel@apple.com> · 864b4dde
      eseidel authored
              Reviewed by darin.
      
              Fix linking of static constructed globals on win32.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * config.h:
              * dom/EventNames.cpp:
              (WebCore::EventNames::init):
              * dom/EventNames.h:
              * dom/dom_qname.cpp:
              (WebCore::QualifiedName::init):
              * dom/dom_qname.h:
              * khtml/html/htmlnames.cpp:
              (WebCore::HTMLNames::init):
              * khtml/html/htmlnames.h:
              * platform/AtomicString.cpp:
              (WebCore::AtomicString::init):
              * platform/StaticConstructors.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      864b4dde
    • vicki's avatar
      Reviewed by Tim Omernick. · aebb78f0
      vicki authored
       
              - fix <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event
      
              Check shouldClose() before actually scheduling a close.
      
              shouldClose() checks for the onbeforeunload handler, displays the onbeforeunload dialog, and returns a 
              result based on whether the user clicks "OK" or "Cancel".  In cases where the window is closed with cmd-w 
              or by clicking the red globe, shouldClose() is checked in the windowShouldClose delegate method.  Since 
              windowShouldClose isn't invoked when a window is closed with Javascript, it makes sense to add a check 
              for shouldClose() in scheduleClose(), returning early when appropriate before the chain of events that 
              closes a window even gets started.  
      
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::scheduleClose): add a check for shouldClose()
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aebb78f0
    • ggaren's avatar
      Reviewed by Darin, Maciej. · d62a712a
      ggaren authored
              - Inline some functions suggested by Shark. 2.9% speedup on super
              accurate JS iBench.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7411
              <rdar://problem/4448116>
      
              * kjs/nodes.h:
              (KJS::ArgumentsNode::evaluateList):
              * kjs/object.cpp:
              * kjs/object.h:
              (KJS::ScopeChain::release):
              (KJS::JSObject::toPrimitive):
              * kjs/scope_chain.cpp:
              * kjs/ustring.cpp:
              * kjs/ustring.h:
              (KJS::UString::toArrayIndex):
              * kjs/value.cpp:
              * kjs/value.h:
              (KJS::JSValue::toObject):
              * kxmlcore/FastMalloc.cpp:
              (KXMLCore::TCMalloc_ThreadCache_FreeList::Push):
              (KXMLCore::TCMalloc_ThreadCache_FreeList::Pop):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d62a712a
    • vicki's avatar
      Reviewed by Hyatt. · 8bb20cbc
      vicki authored
       
              - fix <rdar://problem/4456004> onbeforeunload should cancel, and 
              <rdar://problem/4453579> REGRESSION (TOT): onbeforeunload is broken (7421)
      
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::shouldClose): Onbeforeunload is a non-bubbling window
              event, so we should be using handleWindowEvent rather than dispatching a 
              generic event on the body. It seems this only worked before because of incorrect
              code in other parts of the tree. 
              * dom/dom2_eventsimpl.cpp:
              (WebCore::BeforeUnloadEventImpl::BeforeUnloadEventImpl): for this constructor,
              pass true for the cancel parameter
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bb20cbc
    • ap's avatar
      Reviewed by Darin. · 01538bb8
      ap authored
              - Turn http tests back on by default.
              - Wait for Apache to actually start serving requests.
              - Get user id from a built-in variable rather than an external command; 
              don't pass the group. 
      
              * Scripts/run-webkit-tests: 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01538bb8
    • ap's avatar
      Suggested by Mitz Pettel, reviewed by Darin. · 2cf64115
      ap authored
              * Scripts/run-webkit-tests: Pass User and Group directives, so that Apache
              can run CGIs even if the permissions are 700 or 600.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cf64115
    • darin's avatar
      Collaborating with Alexey. · de24439f
      darin authored
              - turn off http tests by default until we figure out how to get them
                to run even when permissions on CGI files are 700 instead of 755
      
              * Scripts/run-webkit-tests: Set $testHTTP to 0 instead of 1 for now.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de24439f
    • eseidel's avatar
      2006-02-23 Eric Seidel <eseidel@apple.com> · ea6e03b8
      eseidel authored
              Add *.user to ignore list.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea6e03b8
    • eseidel's avatar
      2006-02-23 Eric Seidel <eseidel@apple.com> · 05be17e9
      eseidel authored
              Remove binary file which shouldn't have been commited (and add to ignore list).
      
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Removed.
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05be17e9
    • darin's avatar
      Reviewed by Eric. · 3c46729b
      darin authored
              * Scripts/run-webkit-tests: Put Apache log files in the right directory.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c46729b
  2. 22 Feb, 2006 9 commits
    • eseidel's avatar
      2006-02-22 Eric Seidel <eseidel@apple.com> · 7a8468df
      eseidel authored
              Reviewed by Tim Hatcher.
      
              Fix install-win-extras to not try to re-install setx if installed.
      
              * Scripts/install-win-extras:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a8468df
    • eseidel's avatar
      2006-02-22 Eric Seidel <eseidel@apple.com> · 63b57d5b
      eseidel authored
              One more file possibly missing from previous commit?
      
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb:
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63b57d5b
    • eseidel's avatar
      2006-02-22 Eric Seidel <eseidel@apple.com> · 5fcb65b5
      eseidel authored
              Reviewed by justing.
      
              Files missing from previous commit.
      
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fcb65b5
    • eseidel's avatar
      2006-02-22 Eric Seidel <eseidel@apple.com> · ee17ad11
      eseidel authored
              Rubber-stamped by justing.
      
              Corrected path for DumpRenderTree.intermediate files
      
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee17ad11
    • eseidel's avatar
      2006-02-22 Eric Seidel <eseidel@apple.com> · 1cff66fe
      eseidel authored
              Reviewed by justing.
      
              Fixed build-dumprendertree to exit with correct error codes.
      
              * Scripts/build-dumprendertree:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cff66fe
    • eseidel's avatar
      2006-02-22 Eric Seidel <eseidel@apple.com> · b7131a34
      eseidel authored
              Reviewed by justing.
      
              Update build scripts to generalize building on Win32, and allow
              building of DumpRenderTree on Win32 from build-dumprendertree.
      
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
              (main):
              * Scripts/build-dumprendertree:
              * Scripts/build-webkit:
              * Scripts/webkitdirs.pm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7131a34
    • eseidel's avatar
      2006-02-22 Eric Seidel <eseidel@apple.com> · 613935f9
      eseidel authored
              Reviewed by hyatt.
      
              * DumpRenderTree/DumpRenderTree.vcproj: Added.
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Added.
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Added.
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added.
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Added.
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Added.
              (_tmain):
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added.
              * Scripts/build-webkit: make build-webkit cleanup after itself
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      613935f9
    • eseidel's avatar
      2006-02-22 Eric Seidel <eseidel@apple.com> · aa0e0241
      eseidel authored
              Reviewed by darin.
      
              Adding stub FrameWin class to expose link errors.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * bridge/win/FrameWin.cpp: Added.
              * bridge/win/FrameWin.h: Added.
              (WebCore::Win):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa0e0241
    • mjs's avatar
      Reviewed by Geoff. · 5be25ad7
      mjs authored
              - move QStringList to platform, make it portable
      
              * ForwardingHeaders/qstringlist.h: Removed.
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/DocumentImpl.h:
              * kcanvas/KCanvasFilters.h:
              * khtml/xbl/xbl_protohandler.cpp:
              * ksvg2/svg/SVGColorImpl.cpp:
              * ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
              * ksvg2/svg/SVGDOMImplementationImpl.h:
              * ksvg2/svg/SVGFEBlendElementImpl.cpp:
              * ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
              * ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
              * ksvg2/svg/SVGFECompositeElementImpl.cpp:
              * ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
              * ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp:
              * ksvg2/svg/SVGFEFloodElementImpl.cpp:
              * ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
              * ksvg2/svg/SVGFELightElementImpl.cpp:
              * ksvg2/svg/SVGFEMergeElementImpl.cpp:
              * ksvg2/svg/SVGFEOffsetElementImpl.cpp:
              * ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
              * ksvg2/svg/SVGFETileElementImpl.cpp:
              * ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
              * ksvg2/svg/SVGFitToViewBoxImpl.cpp:
              * ksvg2/svg/SVGLengthListImpl.cpp:
              * ksvg2/svg/SVGNumberListImpl.cpp:
              * ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
              * ksvg2/svg/SVGStringListImpl.cpp:
              * ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
              * ksvg2/svg/SVGTransformableImpl.cpp:
              * kwq/KWQClipboard.mm:
              * kwq/KWQKConfigBase.mm:
              * kwq/KWQKHTMLSettings.h:
              * kwq/KWQKLocale.h:
              * kwq/KWQKSSLKeyGen.h:
              * kwq/KWQStringList.h: Removed.
              * kwq/KWQStringList.mm: Removed.
              * loader/DocLoader.h:
              * page/Frame.h:
              * platform/QStringList.cpp: Added.
              (QStringList::split):
              (QStringList::pop_front):
              * platform/QStringList.h: Added.
              * platform/mac/QStringListMac.mm: Added.
              (QStringList::getNSArray):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5be25ad7
  3. 21 Feb, 2006 19 commits
    • ap's avatar
      Reviewed by Darin. · 0f59636c
      ap authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7409
                Some minor fixes to http tests.
      
      LayoutTests:
      
              * http/conf/httpd.conf: don't define CustomLog and ErrorLog - these are now 
              passed from run-webkit-tests.
              * http/tests/favicon.ico: Added.
              * http/tests/incremental/slow-utf8-text.text: Remove an unused variable,
              * http/tests/incremental/split-hex-entities.html: Ditto.
              * http/tests/xmlhttprequest/interactive-state.cgi: Ditto.
      
      WebKitTools:
      
              * Scripts/run-webkit-tests: Pass CustomLog and ErrorLog directives to httpd.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f59636c
    • kdecker's avatar
      Reviewed by Darin. · e398dcd6
      kdecker authored
              Backed out my previous check in. Since these methods are internal to WebKit (and not private)
              it's perfectly OK for them to remain as categories. 
              * ChangeLog:
              * WebView/WebPreferences.m:
              (-[WebPreferences _integerValueForKey:]):
              (-[WebPreferences _setIntegerValue:forKey:]):
              (-[WebPreferences _floatValueForKey:]):
              (-[WebPreferences _setFloatValue:forKey:]):
              (-[WebPreferences _boolValueForKey:]):
              (-[WebPreferences _setBoolValue:forKey:]):
              * WebView/WebPreferencesPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e398dcd6
    • adele's avatar
      Reviewed by Hyatt. · 590ce138
      adele authored
              - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7330
              baselinePosition is wrong for new text field when empty
      
              * fast/forms/input-baseline-expected.checksum: Added.
              * fast/forms/input-baseline-expected.png: Added.
              * fast/forms/input-baseline-expected.txt: Added.
              * fast/forms/input-baseline.html: Added.
              * fast/inline-block/contenteditable-baseline-expected.checksum: Added.
              * fast/inline-block/contenteditable-baseline-expected.png: Added.
              * fast/inline-block/contenteditable-baseline-expected.txt: Added.
              * fast/inline-block/contenteditable-baseline.html: Added.
      
              Reviewed by Hyatt.
      
              Tests:
              * fast/forms/input-baseline.html
              * fast/inline-block/contenteditable-baseline.html
      
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7330
              baselinePosition is wrong for new text field when empty
      
              * rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox):  
               If we're dealing with an empty contenteditable block, then we've added height to the block to make room for the caret, 
               and there are no children to give us the baseline.  Instead, compute the baseline for the block itself, and factor in the border and the padding.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      590ce138
    • vicki's avatar
      Reviewed by Adele. · 916502e0
      vicki authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7363
              REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail
      
              Add a nil check for the renderer, and refetch the renderer for the old focus node
              after dispatching the event. 
      
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::setFocusNode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      916502e0
    • eseidel's avatar
      2006-02-21 Eric Seidel <eseidel@apple.com> · 29b54346
      eseidel authored
              Reviewed by ggaren.
      
              Add grammarWrapper.cpp to work around visual studio bug plaguing buildbot.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29b54346
    • kdecker's avatar
      Reviewed by Timo O. · 4e818c44
      kdecker authored
              Moved these (already private) methods into the private WebPreferences header.
              Slightly better style than sprinkling the code with categories. 
              
              * WebView/WebPreferences.m:
              (-[WebPreferences _integerValueForKey:]): Moved to WebPreferences (WebPrivate).
              (-[WebPreferences _floatValueForKey:]): Ditto.
              (-[WebPreferences _boolValueForKey:]): Ditto.
              (-[WebPreferences _setBoolValue:forKey:]): Ditto.
              (-[WebPreferences _setFloatValue:forKey:]): Ditto.
              (-[WebPreferences _setIntegerValue:forKey:]): Ditto.
              * WebView/WebPreferencesPrivate.h: Added the above methods.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e818c44
    • ggaren's avatar
      Accidentally wrote "Release" instead of "Debug" in my last patch. · e9b278f4
      ggaren authored
              * quality/leakhunting.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9b278f4
    • eseidel's avatar
      2006-02-21 Eric Seidel <eseidel@apple.com> · 3831c7fa
      eseidel authored
              Reviewed by ggaren.
      
              * kjs/testkjs.cpp: #if out timeval code on win32
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3831c7fa
    • ap's avatar
      Reviewed by Darin. · 3c1c8bcf
      ap authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=6197
                Would like to use locally installed Apache for testing.
      
              Added two run-webkit-tests options:
                --http (--nohttp)  - whether to launch Apache (defaults to yes);
                --port - which port to listen on (defaults to 8000).
      
              Tests in LayoutTests/http are not run directly, and Apache is used instead.
              For example, http/tests/xmlhttprequest/post-content-type.html is loaded as
              http://127.0.0.1:8000/xmlhttprequest/post-content-type.html.
      
              Also added support for .shtml and .text files. Text files give an empty 
              *-expected.txt, but a correct image.
      
              Apache only listens on the loopback interface. It writes logs to /tmp/WebKit.
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c1c8bcf
    • darin's avatar
      Reviewed by Darin. · 8a633fbd
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7397
                TCPageMap.h would not compile for me because string.h was missing
      
              * kxmlcore/TCPageMap.h: Added <string.h> include.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a633fbd
    • darin's avatar
      Reviewed by John Sullivan. · 45d8ba10
      darin authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7404
                remove a bunch of extra implementsCall overrides
      
              * JavaScriptCore.xcodeproj/project.pbxproj: Sorted files.
      
              * kjs/internal.h: Made InternalFunctionImp::callAsFunction pure virtual so that
              we'll get a compile error if some derived class neglects to implement it.
      
              * kjs/function.cpp: (KJS::FunctionImp::FunctionImp): Remove unneeded initialization
              of param, which is an OwnPtr so it gets initialized by default.
      
              * bindings/runtime_method.cpp:
              * bindings/runtime_method.h:
              * kjs/array_object.cpp:
              * kjs/array_object.h:
              * kjs/bool_object.cpp:
              * kjs/bool_object.h:
              * kjs/date_object.cpp:
              * kjs/date_object.h:
              * kjs/error_object.cpp:
              * kjs/error_object.h:
              * kjs/function.cpp:
              * kjs/function.h:
              * kjs/function_object.cpp:
              * kjs/function_object.h:
              * kjs/math_object.cpp:
              * kjs/math_object.h:
              * kjs/number_object.cpp:
              * kjs/number_object.h:
              * kjs/object_object.cpp:
              * kjs/object_object.h:
              * kjs/regexp_object.cpp:
              * kjs/regexp_object.h:
              * kjs/string_object.cpp:
              * kjs/string_object.h:
              Removed many rendundant implementations of implementsCall from subclasses of
              InternalFunctionImp.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45d8ba10
    • darin's avatar
      Suggested by Mark Rowe. · a3380497
      darin authored
              * Scripts/run-webkit-tests: Don't include the number of excluded leaks when
              reporting leak counts.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3380497
    • darin's avatar
      - fixed build · deb9c8c7
      darin authored
              * kjs/internal.cpp: (KJS::InternalFunctionImp::implementsCall):
              Oops, fixed name.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      deb9c8c7
    • darin's avatar
      Change suggested by Mitz. · 45120a16
      darin authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7402
                REGRESSION: Methods do not execute
      
              * kjs/internal.h: Add implementsHasCall to InternalFunctionImp.
              * kjs/internal.cpp: (KJS::InternalFunctionImp::implementsHasCall):
              Return true. All the classes derived from InternalFunctionImp need
              to return true from this -- later we can remove all the extra
              implementations too.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45120a16
    • mjs's avatar
      Rubber Stamped by Hyatt. · ed59c7ee
      mjs authored
              - renamed STATIC, FIXED, RELATIVE, ABSOLUTE to StaticPosition, FixedPosition, etc
              
              This avoids conflicting with win32 headers.
      
              * css/css_computedstyle.cpp:
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle):
              (WebCore::CSSStyleSelector::applyProperty):
              * editing/htmlediting.cpp:
              (WebCore::isSpecialElement):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::updateFirstLetter):
              * rendering/render_box.cpp:
              (WebCore::RenderBox::setStyle):
              (WebCore::RenderBox::absolutePosition):
              (WebCore::RenderBox::computeAbsoluteRepaintRect):
              * rendering/render_flow.cpp:
              (WebCore::RenderFlow::getAbsoluteRepaintRect):
              * rendering/render_layer.cpp:
              (WebCore::RenderLayer::convertToLayerCoords):
              (WebCore::RenderLayer::calculateClipRects):
              (WebCore::RenderLayer::calculateRects):
              * rendering/render_object.cpp:
              (WebCore::RenderObject::markContainingBlocksForLayout):
              (WebCore::RenderObject::containingBlock):
              (WebCore::RenderObject::setStyle):
              (WebCore::RenderObject::container):
              * rendering/render_style.cpp:
              (WebCore::RenderStyle::diff):
              * rendering/render_style.h:
              (khtml::):
              (khtml::RenderStyle::initialPosition):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed59c7ee
    • mjs's avatar
      Rubber Stamped by Hyatt. · 975fa95a
      mjs authored
              - remove KWQSignalStubs.cpp from project.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      975fa95a
    • mjs's avatar
      Platform build fix, not reviewed. · 28af6b39
      mjs authored
              - undef min and max, and include <algorithm> so std::min works
      
              * rendering/font.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28af6b39
    • mjs's avatar
      - fix build breakage caused by last-minute change to my patch · fb1763f8
      mjs authored
              * kjs/lookup.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb1763f8
    • mjs's avatar
      LayoutTests: · 268b51a5
      mjs authored
              Reviewed by Geoff and Darin.
              
              Patch from Maks Orlovich, based on work by David Faure, hand-applied and 
              significantly reworked by me.
              
              - Patch: give internal function names (KJS merge)
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6279
              
              Updated test results, now showing correct function string.
      
              * fast/dom/xmlhttprequest-get-expected.txt:
              * fast/js/kde/function-expected.txt:
              * fast/js/kde/inbuilt_function_tostring-expected.txt:
      
      WebCore:
      
              Reviewed by Geoff and Darin.
              
              Patch from Maks Orlovich, based on work by David Faure, hand-applied and 
              significantly reworked by me.
              
              - Patch: give internal function names (KJS merge)
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6279
      
              * khtml/ecma/kjs_binding.h:
              * khtml/ecma/kjs_html.cpp:
              (KJS::HTMLElementFunction::HTMLElementFunction):
              * kwq/WebCoreScriptDebugger.mm:
              (-[WebCoreScriptCallFrame functionName]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      268b51a5