1. 13 Jun, 2012 40 commits
    • scheib@chromium.org's avatar
      Remove duplicate webkitpointerlockchange events when unlocking. · 94681642
      scheib@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88917
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      Subsequent patches adding the new API for entering and exiting
      pointer lock would be burdened by handling multiple change events
      when the lock target is changed. This change introduces
      temporary code to suppress duplicate change events.
      
      Existing tests simplified by removing the duplicate change events.
      
      * page/PointerLockController.cpp:
      (WebCore::PointerLockController::requestPointerLock):
      (WebCore::PointerLockController::didLosePointerLock):
      * page/PointerLockController.h:
      (PointerLockController):
      
      LayoutTests:
      
      Part of a series of refactoring changes to update pointer lock API to
      the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
      
      Tests simplified by removing the duplicate change events.
      
      * pointer-lock/lock-already-locked-expected.txt:
      * pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
      * pointer-lock/pointerlockchange-pointerlockerror-events.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94681642
    • dpranke@chromium.org's avatar
      nrwt: remove port.test_expectations() and port.test_expectations_overrides() · 90fde9f6
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88948
      
      Reviewed by Ojan Vafai.
      
      In the final patch of this run, we remove the
      test_expectations() and test_expectation_overrides() methods
      from the Port class - callers must now use just
      expectations_dict().
      
      Note that support for the cascade in new-run-webkit-tests is
      complete but only Chromium uses it; webkit-patch
      rebaseline-expectations still does not support updating entries
      in any file other than the first expectations file, however.
      
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port.path_to_test_expectations_file):
      (Port.uses_test_expectations_file):
      (Port.expectations_files):
      * Scripts/webkitpy/layout_tests/port/base_unittest.py:
      (PortTest.test_additional_expectations):
      * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
      (ChromiumPortTest.test_expectations_files):
      * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
      (TestGoogleChromePort.test_get_google_chrome_port):
      * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
      (test_test_expectations):
      (test_legacy_test_expectations):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90fde9f6
    • commit-queue@webkit.org's avatar
      Update range sliders rendering for volume and playback position of new Chrome video controls. · bc23d296
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88623
      
      Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-13
      Reviewed by Eric Carlson.
      
      No new tests, final patch will contain the rebaselined tests.
      
      The Chrome video controls are receiving a visual update. This patch contains updates to the
      rendering of the range sliders for the playback position and the volume. This includes the
      creation of a shadowPseudoId to be able to style the range sliders via CSS, the rendering
      of the slider background and the highlighted ranges.
      
      * css/mediaControlsChromium.css:
      (input[type="range"]::-webkit-media-slider-container):
      Adjust the styling of the slider container backgrounds.
      (input[type="range"]::-webkit-media-slider-thumb):
      Adjust the styling of the slider thumbs.
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::sliderThumbShadowPseudoId):
      Add an accessor function for the slider thumb shadowPseudoId.
      (WebCore::mediaSliderThumbShadowPseudoId):
      Add an accessor function for the media slider thumb shadowPseudoId.
      (WebCore::SliderThumbElement::shadowPseudoId):
      Add a different CSS pseudo-class name to the media slider thumbs.
      (WebCore::TrackLimiterElement::shadowPseudoId):
      Add a different CSS pseudo-class name to the media slider thumbs.
      (WebCore::SliderContainerElement::shadowPseudoId):
      Add a different CSS pseudo-class name to the media slider background container.
      * rendering/RenderMediaControlsChromium.cpp:
      (WebCore::paintRoundedSliderBackground):
      Add function to draw rounded background of sliders in a dark color.
      (WebCore::paintSliderRangeHighlight):
      Add function to draw a highlighted grey region on the sliders, which is rounded only at
      its ends.
      (WebCore::paintMediaSlider):
      Update the background and buffered range renderings on the playback position slider by making
      use of the new helper functions.
      (WebCore::paintMediaVolumeSlider):
      Update the background and buffered range renderings on the volume slider by making
      use of the new helper functions.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc23d296
    • commit-queue@webkit.org's avatar
      [BlackBerry] Update Select Popup's styling · b0943606
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89005
      
      Patch by Christopher Hutten-Czapski <chutten@rim.com> on 2012-06-13
      Reviewed by Rob Buis.
      
      Add in some nicely-styled CSS and JS for the BlackBerry port's <select>
      
      * Resources/blackberry/popupControlBlackBerry.css:
      (body):
      (.popup-area):
      (.popup-area>:first-child):
      (.popup-buttons):
      (.popup-button-divider):
      (.popup-button):
      (.popup-button:active):
      (.popup-button:first-child:active):
      (.popup-button:last-child:active):
      (.popup-button:only-child:active):
      * Resources/blackberry/selectControlBlackBerry.css: Added.
      (.select-area):
      (.select-area:last-child):
      (.option):
      (.optgroup:last-child):
      (.selected):
      (.optgroup):
      (.optgroup .option):
      * Resources/blackberry/selectControlBlackBerry.js: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0943606
    • fpizlo@apple.com's avatar
      DFG should be able to set watchpoints on global variables · b75911b2
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88692
      
      Source/JavaScriptCore: 
      
      Reviewed by Geoffrey Garen.
              
      Rolling back in after fixing Windows build issues, and implementing
      branchTest8 for the Qt port's strange assemblers.
              
      This implements global variable constant folding by allowing the optimizing
      compiler to set a "watchpoint" on globals that it wishes to constant fold.
      If the watchpoint fires, then an OSR exit is forced by overwriting the
      machine code that the optimizing compiler generated with a jump.
              
      As such, this patch is adding quite a bit of stuff:
              
      - Jump replacement on those hardware targets supported by the optimizing
        JIT. It is now possible to patch in a jump instruction over any recorded
        watchpoint label. The jump must be "local" in the sense that it must be
        within the range of the largest jump distance supported by a one
        instruction jump.
                
      - WatchpointSets and Watchpoints. A Watchpoint is a doubly-linked list node
        that records the location where a jump must be inserted and the
        destination to which it should jump. Watchpoints can be added to a
        WatchpointSet. The WatchpointSet can be fired all at once, which plants
        all jumps. WatchpointSet also remembers if it had ever been invalidated,
        which allows for monotonicity: we typically don't want to optimize using
        watchpoints on something for which watchpoints had previously fired. The
        act of notifying a WatchpointSet has a trivial fast path in case no
        Watchpoints are registered (one-byte load+branch).
              
      - SpeculativeJIT::speculationWatchpoint(). It's like speculationCheck(),
        except that you don't have to emit branches. But, you need to know what
        WatchpointSet to add the resulting Watchpoint to. Not everything that
        you could write a speculationCheck() for will have a WatchpointSet that
        would get notified if the condition you were speculating against became
        invalid.
                
      - SymbolTableEntry now has the ability to refer to a WatchpointSet. It can
        do so without incurring any space overhead for those entries that don't
        have WatchpointSets.
                
      - The bytecode generator infers all global function variables to be
        watchable, and makes all stores perform the WatchpointSet's write check,
        and marks all loads as being potentially watchable (i.e. you can compile
        them to a watchpoint and a constant).
              
      Put together, this allows for fully sleazy inlining of calls to globally
      declared functions. The inline prologue will no longer contain the load of
      the function, or any checks of the function you're calling. I.e. it's
      pretty much like the kind of inlining you would see in Java or C++.
      Furthermore, the watchpointing functionality is built to be fairly general,
      and should allow setting watchpoints on all sorts of interesting things
      in the future.
              
      The sleazy inlining means that we will now sometimes inline in code paths
      that have never executed. Previously, to inline we would have either had
      to have executed the call (to read the call's inline cache) or have
      executed the method check (to read the method check's inline cache). Now,
      we might inline when the callee is a watched global variable. This
      revealed some humorous bugs. First, constant folding disagreed with CFA
      over what kinds of operations can clobber (example: code path A is dead
      but stores a String into variable X, all other code paths store 0 into
      X, and then you do CompareEq(X, 0) - CFA will say that this is a non-
      clobbering constant, but constant folding thought it was clobbering
      because it saw the String prediction). Second, inlining would crash if
      the inline callee had not been compiled. This patch fixes both bugs,
      since otherwise run-javascriptcore-tests would report regressions.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * assembler/ARMv7Assembler.h:
      (ARMv7Assembler):
      (JSC::ARMv7Assembler::ARMv7Assembler):
      (JSC::ARMv7Assembler::labelForWatchpoint):
      (JSC::ARMv7Assembler::label):
      (JSC::ARMv7Assembler::replaceWithJump):
      (JSC::ARMv7Assembler::maxJumpReplacementSize):
      * assembler/AbstractMacroAssembler.h:
      (JSC):
      (AbstractMacroAssembler):
      (Label):
      (JSC::AbstractMacroAssembler::watchpointLabel):
      (JSC::AbstractMacroAssembler::readPointer):
      * assembler/AssemblerBuffer.h:
      * assembler/MacroAssemblerARM.h:
      (JSC::MacroAssemblerARM::branchTest8):
      (MacroAssemblerARM):
      (JSC::MacroAssemblerARM::replaceWithJump):
      (JSC::MacroAssemblerARM::maxJumpReplacementSize):
      * assembler/MacroAssemblerARMv7.h:
      (JSC::MacroAssemblerARMv7::load8Signed):
      (JSC::MacroAssemblerARMv7::load16Signed):
      (MacroAssemblerARMv7):
      (JSC::MacroAssemblerARMv7::replaceWithJump):
      (JSC::MacroAssemblerARMv7::maxJumpReplacementSize):
      (JSC::MacroAssemblerARMv7::branchTest8):
      (JSC::MacroAssemblerARMv7::jump):
      (JSC::MacroAssemblerARMv7::makeBranch):
      * assembler/MacroAssemblerMIPS.h:
      (JSC::MacroAssemblerMIPS::branchTest8):
      (MacroAssemblerMIPS):
      (JSC::MacroAssemblerMIPS::replaceWithJump):
      (JSC::MacroAssemblerMIPS::maxJumpReplacementSize):
      * assembler/MacroAssemblerSH4.h:
      (JSC::MacroAssemblerSH4::branchTest8):
      (MacroAssemblerSH4):
      (JSC::MacroAssemblerSH4::replaceWithJump):
      (JSC::MacroAssemblerSH4::maxJumpReplacementSize):
      * assembler/MacroAssemblerX86.h:
      (MacroAssemblerX86):
      (JSC::MacroAssemblerX86::branchTest8):
      * assembler/MacroAssemblerX86Common.h:
      (JSC::MacroAssemblerX86Common::replaceWithJump):
      (MacroAssemblerX86Common):
      (JSC::MacroAssemblerX86Common::maxJumpReplacementSize):
      * assembler/MacroAssemblerX86_64.h:
      (MacroAssemblerX86_64):
      (JSC::MacroAssemblerX86_64::branchTest8):
      * assembler/X86Assembler.h:
      (JSC::X86Assembler::X86Assembler):
      (X86Assembler):
      (JSC::X86Assembler::cmpb_im):
      (JSC::X86Assembler::testb_im):
      (JSC::X86Assembler::labelForWatchpoint):
      (JSC::X86Assembler::label):
      (JSC::X86Assembler::replaceWithJump):
      (JSC::X86Assembler::maxJumpReplacementSize):
      (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
      * bytecode/CodeBlock.cpp:
      (JSC):
      (JSC::CodeBlock::printGetByIdCacheStatus):
      (JSC::CodeBlock::dump):
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::appendOSRExit):
      (JSC::CodeBlock::appendSpeculationRecovery):
      (CodeBlock):
      (JSC::CodeBlock::appendWatchpoint):
      (JSC::CodeBlock::numberOfWatchpoints):
      (JSC::CodeBlock::watchpoint):
      (DFGData):
      * bytecode/DFGExitProfile.h:
      (JSC::DFG::exitKindToString):
      (JSC::DFG::exitKindIsCountable):
      * bytecode/GetByIdStatus.cpp:
      (JSC::GetByIdStatus::computeForChain):
      * bytecode/Instruction.h:
      (Instruction):
      (JSC::Instruction::Instruction):
      * bytecode/Opcode.h:
      (JSC):
      (JSC::padOpcodeName):
      * bytecode/Watchpoint.cpp: Added.
      (JSC):
      (JSC::Watchpoint::~Watchpoint):
      (JSC::Watchpoint::correctLabels):
      (JSC::Watchpoint::fire):
      (JSC::WatchpointSet::WatchpointSet):
      (JSC::WatchpointSet::~WatchpointSet):
      (JSC::WatchpointSet::add):
      (JSC::WatchpointSet::notifyWriteSlow):
      (JSC::WatchpointSet::fireAllWatchpoints):
      * bytecode/Watchpoint.h: Added.
      (JSC):
      (Watchpoint):
      (JSC::Watchpoint::Watchpoint):
      (JSC::Watchpoint::setDestination):
      (WatchpointSet):
      (JSC::WatchpointSet::isStillValid):
      (JSC::WatchpointSet::hasBeenInvalidated):
      (JSC::WatchpointSet::startWatching):
      (JSC::WatchpointSet::notifyWrite):
      (JSC::WatchpointSet::addressOfIsWatched):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::ResolveResult::checkValidity):
      (JSC::BytecodeGenerator::addGlobalVar):
      (JSC::BytecodeGenerator::BytecodeGenerator):
      (JSC::BytecodeGenerator::resolve):
      (JSC::BytecodeGenerator::emitResolve):
      (JSC::BytecodeGenerator::emitResolveWithBase):
      (JSC::BytecodeGenerator::emitResolveWithThis):
      (JSC::BytecodeGenerator::emitGetStaticVar):
      (JSC::BytecodeGenerator::emitPutStaticVar):
      * bytecompiler/BytecodeGenerator.h:
      (BytecodeGenerator):
      * bytecompiler/NodesCodegen.cpp:
      (JSC::FunctionCallResolveNode::emitBytecode):
      (JSC::PostfixResolveNode::emitBytecode):
      (JSC::PrefixResolveNode::emitBytecode):
      (JSC::ReadModifyResolveNode::emitBytecode):
      (JSC::AssignResolveNode::emitBytecode):
      (JSC::ConstDeclNode::emitCodeSingle):
      * dfg/DFGAbstractState.cpp:
      (JSC::DFG::AbstractState::execute):
      (JSC::DFG::AbstractState::clobberStructures):
      * dfg/DFGAbstractState.h:
      (AbstractState):
      (JSC::DFG::AbstractState::didClobber):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::handleInlining):
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGCCallHelpers.h:
      (CCallHelpers):
      (JSC::DFG::CCallHelpers::setupArguments):
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::CSEPhase::globalVarWatchpointElimination):
      (CSEPhase):
      (JSC::DFG::CSEPhase::globalVarStoreElimination):
      (JSC::DFG::CSEPhase::performNodeCSE):
      * dfg/DFGCapabilities.h:
      (JSC::DFG::canCompileOpcode):
      * dfg/DFGConstantFoldingPhase.cpp:
      (JSC::DFG::ConstantFoldingPhase::run):
      * dfg/DFGCorrectableJumpPoint.h:
      (JSC::DFG::CorrectableJumpPoint::isSet):
      (CorrectableJumpPoint):
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::linkOSRExits):
      (JSC::DFG::JITCompiler::link):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasIdentifierNumberForCheck):
      (Node):
      (JSC::DFG::Node::identifierNumberForCheck):
      (JSC::DFG::Node::hasRegisterPointer):
      * dfg/DFGNodeType.h:
      (DFG):
      * dfg/DFGOSRExit.cpp:
      (JSC::DFG::OSRExit::OSRExit):
      * dfg/DFGOSRExit.h:
      (OSRExit):
      * dfg/DFGOperations.cpp:
      * dfg/DFGOperations.h:
      * dfg/DFGPredictionPropagationPhase.cpp:
      (JSC::DFG::PredictionPropagationPhase::propagate):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::callOperation):
      (JSC::DFG::SpeculativeJIT::appendCall):
      (SpeculativeJIT):
      (JSC::DFG::SpeculativeJIT::speculationWatchpoint):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::privateExecute):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompileMainPass):
      (JSC::JIT::privateCompileSlowCases):
      * jit/JIT.h:
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::emit_op_put_global_var_check):
      (JSC):
      (JSC::JIT::emitSlow_op_put_global_var_check):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::emit_op_put_global_var_check):
      (JSC):
      (JSC::JIT::emitSlow_op_put_global_var_check):
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      (JSC):
      * jit/JITStubs.h:
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::LLINT_SLOW_PATH_DECL):
      (LLInt):
      * llint/LLIntSlowPaths.h:
      (LLInt):
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      * runtime/JSObject.cpp:
      (JSC::JSObject::removeDirect):
      * runtime/JSObject.h:
      (JSObject):
      * runtime/JSSymbolTableObject.h:
      (JSC::symbolTableGet):
      (JSC::symbolTablePut):
      (JSC::symbolTablePutWithAttributes):
      * runtime/SymbolTable.cpp: Added.
      (JSC):
      (JSC::SymbolTableEntry::copySlow):
      (JSC::SymbolTableEntry::freeFatEntrySlow):
      (JSC::SymbolTableEntry::couldBeWatched):
      (JSC::SymbolTableEntry::attemptToWatch):
      (JSC::SymbolTableEntry::addressOfIsWatched):
      (JSC::SymbolTableEntry::addWatchpoint):
      (JSC::SymbolTableEntry::notifyWriteSlow):
      (JSC::SymbolTableEntry::inflateSlow):
      * runtime/SymbolTable.h:
      (JSC):
      (SymbolTableEntry):
      (Fast):
      (JSC::SymbolTableEntry::Fast::Fast):
      (JSC::SymbolTableEntry::Fast::isNull):
      (JSC::SymbolTableEntry::Fast::getIndex):
      (JSC::SymbolTableEntry::Fast::isReadOnly):
      (JSC::SymbolTableEntry::Fast::getAttributes):
      (JSC::SymbolTableEntry::Fast::isFat):
      (JSC::SymbolTableEntry::SymbolTableEntry):
      (JSC::SymbolTableEntry::~SymbolTableEntry):
      (JSC::SymbolTableEntry::operator=):
      (JSC::SymbolTableEntry::isNull):
      (JSC::SymbolTableEntry::getIndex):
      (JSC::SymbolTableEntry::getFast):
      (JSC::SymbolTableEntry::getAttributes):
      (JSC::SymbolTableEntry::isReadOnly):
      (JSC::SymbolTableEntry::watchpointSet):
      (JSC::SymbolTableEntry::notifyWrite):
      (FatEntry):
      (JSC::SymbolTableEntry::FatEntry::FatEntry):
      (JSC::SymbolTableEntry::isFat):
      (JSC::SymbolTableEntry::fatEntry):
      (JSC::SymbolTableEntry::inflate):
      (JSC::SymbolTableEntry::bits):
      (JSC::SymbolTableEntry::freeFatEntry):
      (JSC::SymbolTableEntry::pack):
      (JSC::SymbolTableEntry::isValidIndex):
      
      Source/WTF: 
      
      Reviewed by Geoffrey Garen.
              
      Added ability to set the inline capacity of segmented vectors.
              
      Also added the ability ot ASSERT_NOT_REACHED() without having to
      propagate NO_RETURN macros, which would be a show-stopper for code
      that is conditionally unreachable.
      
      * wtf/Assertions.h:
      (UNREACHABLE_FOR_PLATFORM):
      * wtf/SegmentedVector.h:
      (WTF):
      (SegmentedVectorIterator):
      (WTF::SegmentedVectorIterator::operator=):
      (WTF::SegmentedVectorIterator::SegmentedVectorIterator):
      (SegmentedVector):
      
      LayoutTests: 
      
      Rubber stamped by Geoffrey Garen.
              
      Added a test for watchpoints. Also updated the jsc-test-list to include the latest
      tests.
      
      * fast/js/dfg-call-function-hit-watchpoint-expected.txt: Added.
      * fast/js/dfg-call-function-hit-watchpoint.html: Added.
      * fast/js/jsc-test-list:
      * fast/js/script-tests/dfg-call-function-hit-watchpoint.js: Added.
      (foo):
      (bar):
      (.foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b75911b2
    • dpranke@chromium.org's avatar
      nrwt: implement the actual cascade of TestExpectations · 328c586a
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88947
      
      Reviewed by Ojan Vafai.
      
      This change implements the actual cascade by removing the
      concept of 'overrides' from the TestExpectations object and
      parsing each file separately.
      
      There is an actual semantic change in this patch, in that
      setting an expectation on a directory in one file will override
      the expectations on any individual tests set in prior files. The
      test_overrides__directory() unit test verifies this.
      
      Otherwise, this patch mostly consists of deleting code :).
      
      * Scripts/webkitpy/layout_tests/models/test_expectations.py:
      (TestExpectationsModel.__init__):
      (TestExpectationsModel.add_expectation_line):
      (TestExpectationsModel._add_test):
      (TestExpectationsModel._already_seen_better_match):
      (TestExpectations.__init__):
      (TestExpectations._add_expectations):
      * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
      (test_overrides__directory):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      328c586a
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening after r120228, fix an incorrect test expectation. · d736098b
      zandobersek@gmail.com authored
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d736098b
    • commit-queue@webkit.org's avatar
      [V8] IndexedDB: Cursor value modifications should be preserved until cursor iterates · 17d70497
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83526
      
      Patch by Alec Flett <alecflett@chromium.org> on 2012-06-13
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      Cache the 'value' attribute of IDBCursorWithValue with policy
      determined by IDBCursor.cpp, to follow spec behavior of keeping a
      consistent script object until the cursor advances. See
      http://www.w3.org/TR/IndexedDB/#widl-IDBCursorWithValueSync-value
      for details.
      
      Test: storage/indexeddb/cursor-value.html
      
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::IDBCursor):
      (WebCore::IDBCursor::value):
      (WebCore::IDBCursor::setValueReady):
      * Modules/indexeddb/IDBCursor.h:
      (IDBCursor):
      (WebCore::IDBCursor::valueIsDirty):
      * Modules/indexeddb/IDBCursorWithValue.idl:
      * WebCore.gypi:
      * bindings/v8/IDBCustomBindings.cpp: Added.
      (WebCore):
      (WebCore::V8IDBCursorWithValue::valueAccessorGetter):
      
      LayoutTests:
      
      * storage/indexeddb/cursor-value-expected.txt: Added.
      * storage/indexeddb/cursor-value.html: Added.
      * storage/indexeddb/resources/cursor-value.js: Added.
      (openDatabase.request.onsuccess.request.onsuccess):
      (openDatabase.request.onsuccess):
      (openDatabase):
      (testCursor.request.onsuccess):
      (testCursor):
      (ensureModificationsNotPersisted.request.onsuccess):
      (ensureModificationsNotPersisted):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17d70497
    • dpranke@chromium.org's avatar
      webkitpy: update callers to use port.expectation_dict() instead of... · 378c494e
      dpranke@chromium.org authored
      webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
      https://bugs.webkit.org/show_bug.cgi?id=88946
      
      Reviewed by Ojan Vafai.
      
      In preparation for fully supporting cascading expectations files
      and removing the 'overrides' concept.
      
      There should be no functional changes in this patch.
      
      * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
      (ManagerTest.test_update_summary_with_result):
      (ResultSummaryTest.get_result_summary):
      * Scripts/webkitpy/layout_tests/models/test_expectations.py:
      (TestExpectations.__init__):
      * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
      (parse_exp):
      (SkippedTests.check):
      (RemoveConfigurationsTest.test_remove):
      (test_remove_line):
      * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
      (LintTest.test_all_configurations.FakePort.__init__):
      (LintTest.test_all_configurations.FakePort.expectations_dict):
      (LintTest.test_lint_test_files__errors):
      * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
      (test_overrides_are_included_correctly):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      378c494e
    • commit-queue@webkit.org's avatar
      Code cleanup from bug 88881 to share the SliderVerticalPart code. · e8908ffc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88930
      
      Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-13
      Reviewed by Eric Carlson.
      
      No new tests - this is just code cleanup.
      
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::hasVerticalAppearance):
      Avoid having two ifdef-ed returns in the code depending on ENABLE(VIDEO).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8908ffc
    • dpranke@chromium.org's avatar
      webkitpy: rework the TestExpectations style checker in preparation for the cascade · 242248be
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88945
      
      Reviewed by Ojan Vafai.
      
      This patch changes the style checker to call the
      TestExpectations parser directly and be oblivious as to what the
      port's actual expectations are.
      
      * Scripts/webkitpy/style/checkers/test_expectations.py:
      (TestExpectationsChecker.__init__):
      (TestExpectationsChecker.check_test_expectations):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      242248be
    • ossy@webkit.org's avatar
      REGRESSION(r120108): It made http/tests/loading/gmail-assert-on-load.html fail · 1800a814
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88923
      
      Patch by Shrey Banga <banga@chromium.org> on 2012-06-13
      Reviewed by Csaba Osztrogonác.
      
      * http/tests/loading/gmail-assert-on-load-expected.txt: Removed.
      * http/tests/misc/gmail-assert-on-load-expected.txt: Added.
      * http/tests/misc/gmail-assert-on-load.html: Renamed from LayoutTests/http/tests/loading/gmail-assert-on-load.html.
      All tests in http/tests/loading dump frame load events, which are not
      consistent or relevant for this test. So it had to be moved out of
      http/tests/loading.
      * platform/qt/Skipped: This test can be unskipped now
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1800a814
    • dpranke@chromium.org's avatar
      nrwt: restructure the port classes to handle multiple expectations files · bdeed04d
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88944
      
      Reviewed by Ojan Vafai.
      
      This patch restructures the Port classes so that each port
      returns a list of TestExpectations files to be used (in a new, public,
      expectations_files() method), and the base implementation rolls them
      up into the ordered expectations_dict(), which becomes a public
      method.
      
      port.path_to_test_expectations_file(), port.test_expectations(),
      and port.test_expectations_overrides() are then reimplemented as
      wrappers around port.expectations_dict().
      port.test_expectations() and port.test_expectations_overrides()
      will eventually be removed when the cascade is fully completed,
      and port.path_to_test_expectations_file() will be removed when
      the rebaselining tool supports the cascade
      (expectations_files() may also become private at that point).
      
      There should be no functional changes in this patch, but a bunch
      of custom logic gets deleted!
      
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port.expectations_dict):
      (Port):
      (Port.expectations_files):
      (Port.test_expectations):
      (Port.test_expectations_overrides):
      * Scripts/webkitpy/layout_tests/port/base_unittest.py:
      (PortTest.test_additional_expectations):
      (PortTest.test_uses_test_expectations_file):
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      (ChromiumPort.all_baseline_variants):
      (ChromiumPort.expectations_files):
      * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
      (ChromiumPortTest.test_overrides_and_builder_names):
      * Scripts/webkitpy/layout_tests/port/google_chrome.py:
      (_expectations_files):
      (GoogleChromeLinux32Port.expectations_files):
      (GoogleChromeLinux64Port.expectations_files):
      (GoogleChromeMacPort.expectations_files):
      (GoogleChromeWinPort.expectations_files):
      * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
      (TestGoogleChromePort._verify_expectations_overrides):
      * Scripts/webkitpy/layout_tests/port/port_testcase.py:
      (PortTestCase.test_expectations_ordering):
      * Scripts/webkitpy/layout_tests/port/webkit.py:
      (WebKitPort._skipped_file_search_paths):
      * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
      (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
      (test_rebaseline_updates_expectations_file):
      (test_rebaseline_does_not_include_overrides):
      (test_rebaseline_expectations):
      (test_overrides_are_included_correctly):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdeed04d
    • bfulgham@webkit.org's avatar
      [WinCairo] Update URL of WinCairoRequirements.zip download. · 29a0e7e3
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89009
      
      Reviewed by Martin Robinson.
      
      * Tools/Scripts/update-webkit-dependency: Put fallback code
      to download a "last update" time from servers that don't properly
      report Last-Modified in their HTTP header.
      * Tools/Scripts/update-webkit-wincairo-libs: Change download link
      for the WinCairo build requirements bundle.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29a0e7e3
    • commit-queue@webkit.org's avatar
      [chromium mac] Don't include things in subframeworks of · 2b116ed1
      commit-queue@webkit.org authored
      ApplicationServices.framework.
      
      A CoreText #include (with quotes instead of brackets, even) sprung up
      in r120506, bug 69826.
      
      https://bugs.webkit.org/show_bug.cgi?id=88569
      
      Patch by Mark Mentovai <mark@chromium.org> on 2012-06-13
      Reviewed by Stephen White.
      
      No new tests.
      
      * platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b116ed1
    • abecsi@webkit.org's avatar
      [Qt][WK2] ASSERT(m_rawAttributes.initialScale > 0) in QtViewportHandler::initialRect() · 669c3b6c
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89026
      
      Reviewed by Csaba Osztrogonác.
      
      Only act on viewport attribute changes if the layout size is valid.
      
      * UIProcess/qt/QtViewportHandler.cpp:
      (WebKit::QtViewportHandler::setInitialScaleIfNeeded):
      (WebKit::QtViewportHandler::viewportAttributesChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      669c3b6c
    • ossy@webkit.org's avatar
      REGRESSION (r120204-r120206): 37 fast/profiler tests failing on GTK Linux 64-bit Release · 14617ec4
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89006
      
      Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-06-13
      Reviewed by Enrica Casucci.
      
      * fast/profiler/nested-start-and-stop-profiler-expected.txt:
      * fast/profiler/resources/profiler-test-JS-resources.js:
      (printProfileNodeWithoutTime): change childern to children()
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14617ec4
    • bfulgham@webkit.org's avatar
      [WinCairo] Build fix after Windows export definition file change. · f89559fb
      bfulgham@webkit.org authored
      * win/WebKit2CFLite.def: Add missing symbol exports.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f89559fb
    • dpranke@chromium.org's avatar
      nrwt: preliminary cleanup before supporting cascading expectations files · 2be6fc57
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88942
      
      Reviewed by Ojan Vafai.
      
      This change just prepares the TestExpectations parser to get filenames
      along with the expectations, and improves the warning messages so that
      they contain the filenames along with the line numbers.
      
      There should be no functional changes in this patch.
      
      * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
      (TestExpectationEditorTests.make_parsed_expectation_lines):
      * Scripts/webkitpy/layout_tests/models/test_expectations.py:
      (TestExpectationParser.parse):
      (TestExpectationParser.expectation_for_skipped_test):
      (TestExpectationParser._tokenize):
      (TestExpectationParser._tokenize_list):
      (TestExpectationLine):
      (TestExpectationsModel.__init__):
      (TestExpectationsModel._already_seen_better_match):
      (TestExpectations.__init__):
      (TestExpectations._shorten_filename):
      (TestExpectations._report_warnings):
      (TestExpectations._add_skipped_tests):
      * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
      (TestExpectationParserTests._tokenize):
      (TestExpectationParserTests.test_tokenize_blank):
      (TestExpectationParserTests.test_tokenize_missing_colon):
      (TestExpectationParserTests.test_tokenize_extra_colon):
      (TestExpectationParserTests.test_tokenize_empty_comment):
      (TestExpectationParserTests.test_tokenize_comment):
      (TestExpectationParserTests.test_tokenize_missing_equal):
      (TestExpectationParserTests.test_tokenize_extra_equal):
      (TestExpectationParserTests.test_tokenize_valid):
      (TestExpectationParserTests.test_tokenize_valid_with_comment):
      (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
      (TestExpectationParserTests.test_parse_empty_string):
      (TestExpectationSerializerTests._tokenize):
      (TestExpectationSerializerTests.assert_round_trip):
      (TestExpectationSerializerTests.assert_list_round_trip):
      * Scripts/webkitpy/tool/servers/gardeningserver.py:
      (GardeningExpectationsUpdater.update_expectations):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2be6fc57
    • commit-queue@webkit.org's avatar
      Removing an extra HandleScope in V8Proxy::evaluateInIsolatedWorld · 98ce4cef
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88451
      
      Patch by Eriq Augustine <eaugusti@chromium.org> on 2012-06-13
      Reviewed by Adam Barth.
      
      Any values retuned by the evaluation will get destroyed with the extra
      HandleScope.
      
      I was unable to cause a test failure, however this feature is tested by:
      platform/chromium/http/tests/misc/execute-and-return-value.html
      
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::evaluateInIsolatedWorld):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98ce4cef
    • zandobersek@gmail.com's avatar
      [Gtk] Enable link prefetch support in the developer builds · 44a6ce7f
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=89011
      
      Reviewed by Martin Robinson.
      
      .: 
      
      Rather export an automake conditional than define a preprocessor
      macro for enabling link prefetch support.
      
      * configure.ac:
      
      Source/WebCore: 
      
      Handle the ENABLE_LINK_PREFETCH conditional in standard way.
      
      No new tests - covered by existing link prefetch tests.
      
      * GNUmakefile.am:
      
      Tools: 
      
      Enable the link prefetch support for Gtk by default in developer
      builds.
      
      * Scripts/webkitperl/FeatureList.pm:
      
      LayoutTests: 
      
      Remove expectations for link prefetch tests that now pass and
      recategorise a few failures that now fail due to missing
      dumpResourceResponseMIMETypes implementation in DumpRenderTree.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44a6ce7f
    • wangxianzhu@chromium.org's avatar
      Unreviewed, rolling out r120220. · 45e26b67
      wangxianzhu@chromium.org authored
      http://trac.webkit.org/changeset/120220
      https://bugs.webkit.org/show_bug.cgi?id=89021
      
      The patch broke build Chromium Win Release (Requested by
      wangxianzhu on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-13
      
      * WebKit.gyp:
      * public/linux/WebFontRendering.h:
      (WebKit):
      (WebFontRendering):
      * public/linuxish/WebFontRendering.h: Removed.
      * src/linux/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp.
      (WebKit):
      (WebKit::WebFontRendering::setHinting):
      (WebKit::WebFontRendering::setAntiAlias):
      (WebKit::WebFontRendering::setSubpixelGlyphs):
      (WebKit::WebFontRendering::setSubpixelRendering):
      (WebKit::WebFontRendering::setSubpixelPositioning):
      (WebKit::WebFontRendering::setLCDOrder):
      (WebKit::WebFontRendering::setLCDOrientation):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45e26b67
    • jchaffraix@webkit.org's avatar
      Unreviewed flakiness removal. · 2abe7266
      jchaffraix@webkit.org authored
      * platform/chromium/TestExpectations:
      The test was improved as bug 52064 (which was fixed some time ago). The test isn't showing
      up as flaky anymore so removing it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2abe7266
    • commit-queue@webkit.org's avatar
      Rename currentDeviceMotion to lastMotion in DeviceMotionClient · 8ff5193e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88854
      
      Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-13
      Reviewed by Adam Barth.
      
      Rename the function currentDeviceMotion to lastMotion in DeviceMotionClient.
      This makes it consistent with the similar function lastOrientation in DeviceOrientationClient.
      
      Source/WebCore:
      
      Just a rename, so does not require any new tests.
      
      * dom/DeviceMotionClient.h:
      (DeviceMotionClient):
      * dom/DeviceMotionController.cpp:
      (WebCore::DeviceMotionController::timerFired):
      (WebCore::DeviceMotionController::addListener):
      * loader/EmptyClients.h:
      (WebCore::EmptyDeviceMotionClient::lastMotion):
      * platform/qt/DeviceMotionClientQt.cpp:
      (WebCore::DeviceMotionClientQt::lastMotion):
      * platform/qt/DeviceMotionClientQt.h:
      (DeviceMotionClientQt):
      * platform/qt/DeviceMotionProviderQt.h:
      (WebCore::DeviceMotionProviderQt::lastMotion):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/DeviceMotionClientBlackBerry.cpp:
      (DeviceMotionClientBlackBerry::lastMotion):
      (DeviceMotionClientBlackBerry::onMotion):
      * WebCoreSupport/DeviceMotionClientBlackBerry.h:
      (DeviceMotionClientBlackBerry):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DeviceMotionClientEfl.cpp:
      (WebCore::DeviceMotionClientEfl::lastMotion):
      * WebCoreSupport/DeviceMotionClientEfl.h:
      (DeviceMotionClientEfl):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/DeviceMotionClientGtk.cpp:
      (WebKit::DeviceMotionClientGtk::lastMotion):
      * WebCoreSupport/DeviceMotionClientGtk.h:
      (DeviceMotionClientGtk):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ff5193e
    • vsevik@chromium.org's avatar
      Web Inspector: Breakpoint's _uiLocationRemoved() method is never called. · 75bda203
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89003
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/BreakpointManager.js:
      (WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
      (WebInspector.BreakpointManager.Breakpoint):
      (WebInspector.BreakpointManager.Breakpoint.prototype._locationUpdated):
      (WebInspector.BreakpointManager.Breakpoint.prototype._resetLocations):
      (WebInspector.BreakpointManager.Breakpoint.prototype._fakeBreakpointAtPrimaryLocation):
      * inspector/front-end/FileSystemModel.js: Drive by compilation fix.
      (WebInspector.FileSystemModel):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75bda203
    • dgrogan@chromium.org's avatar
      IndexedDB: Add tests, an assert, and some comments around open/close/setVersion call sequencing · d4fcfbe6
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88829
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Test: storage/indexeddb/three-setversion-calls.html
      
      * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
      (WebCore::IDBDatabaseBackendImpl::processPendingCalls):
      
      LayoutTests:
      
      * storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
      * storage/indexeddb/resources/factory-deletedatabase-interactions.js:
      (Connection.this.open.req.onsuccess.that.handle.onversionchange):
      (Connection.this.open.req.onsuccess):
      (Connection.this.open):
      (test3):
      (test4.runSteps.):
      (test4):
      (test4.):
      * storage/indexeddb/resources/three-setversion-calls.js: Added.
      (test):
      (openDBConnection):
      (successHandler.return.trans.oncomplete):
      (openSuccess1.deleteRequest.onsuccess):
      (openSuccess1):
      * storage/indexeddb/three-setversion-calls-expected.txt: Added.
      * storage/indexeddb/three-setversion-calls.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4fcfbe6
    • leviw@chromium.org's avatar
      Unreviewed Chromium test expectation update after r119893. · 10770e3c
      leviw@chromium.org authored
      * fast/multicol/nested-columns-expected.txt: Added.
      * fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
      * platform/chromium-linux-x86/fast/borders: Removed.
      * platform/chromium-linux-x86/fast/multicol/vertical-rl: Added.
      * platform/chromium-linux-x86/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
      * platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
      * platform/chromium-linux/fast/multicol/nested-columns-expected.png:
      * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
      * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
      * platform/chromium-linux/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
      * platform/chromium-linux/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Added.
      * platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png:
      * platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.png:
      * platform/chromium-mac-leopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.
      * platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
      * platform/chromium-mac/fast/multicol/nested-columns-expected.png:
      * platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:
      * platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
      * platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
      * platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Added.
      * platform/chromium-win-vista/fast/borders: Removed.
      * platform/chromium-win-vista/fast/multicol: Added.
      * platform/chromium-win-vista/fast/multicol/vertical-rl: Added.
      * platform/chromium-win-vista/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
      * platform/chromium-win-xp/fast/borders: Removed.
      * platform/chromium-win/fast/borders/border-antialiasing-expected.png:
      * platform/chromium-win/fast/multicol/nested-columns-expected.png:
      * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
      * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
      * platform/chromium-win/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
      * platform/chromium-win/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Added.
      * platform/chromium/TestExpectations:
      * platform/efl/fast/multicol/nested-columns-expected.txt: Removed.
      * platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt: Removed.
      * platform/gtk/fast/multicol/nested-columns-expected.txt: Removed.
      * platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10770e3c
    • wangxianzhu@chromium.org's avatar
      [Chromium] Let Android and Linux share WebFontRendering decl/impl. · fc39f010
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88802
      
      Reviewed by Adam Barth.
      
      * WebKit.gyp:
      * public/linux/WebFontRendering.h: Temporarily forwards to the new file under linuxish.
      * public/linuxish: Added.
      * public/linuxish/WebFontRendering.h: Copied from chromium/public/linux/WebFontRendering.h.
      * src/linux/WebFontRendering.cpp: Removed.
      * src/linuxish: Added.
      * src/linuxish/WebFontRendering.cpp: Copied from chromium/src/linux/WebFontRendering.cpp.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc39f010
    • commit-queue@webkit.org's avatar
      [Chromium] WebFrameImpl::find doesn't work for searching from a selection. · b855c223
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88885
      
      Patch by Martin Kosiba <mkosiba@google.com> on 2012-06-13
      Reviewed by Adam Barth.
      
      Remember the active match not just until the seatchText changes but for the entire find session.
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::find):
      (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b855c223
    • commit-queue@webkit.org's avatar
      [Qt] Fixed visible content rect lost during page-load · b087e03e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88991
      
      Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-13
      Reviewed by Kenneth Rohde Christiansen.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b087e03e
    • ossy@webkit.org's avatar
      Update buildbot master in autoinstaller to match build.webkit.org · 2cd9cf2e
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88992
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/thirdparty/__init__.py:
      (AutoinstallImportHook._install_buildbot):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cd9cf2e
    • zandobersek@gmail.com's avatar
      Skip the isolated world tests for Gtk - the infrastructure is missing · c275c184
      zandobersek@gmail.com authored
      and they take too long to fail by timing out, lengthening the bot cycles.
      
      Rubber-stamped by Philippe Normand.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c275c184
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r120209. · b5b77372
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/120209
      https://bugs.webkit.org/show_bug.cgi?id=89007
      
      Broke the WebKit2 mac build. (Requested by andersca on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-13
      
      Source/WebKit2:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Shared/API/c/WKBase.h:
      * Shared/APIClientTraits.h:
      * Shared/APIObject.h:
      * Shared/IntentData.cpp: Removed.
      * Shared/IntentData.h: Removed.
      * Target.pri:
      * UIProcess/API/C/WKAPICast.h:
      (WebKit):
      * UIProcess/API/C/WKPage.h:
      * UIProcess/API/gtk/WebKitLoaderClient.cpp:
      (attachLoaderClientToView):
      * UIProcess/WebIntentData.cpp: Removed.
      * UIProcess/WebIntentData.h: Removed.
      * UIProcess/WebLoaderClient.cpp:
      * UIProcess/WebLoaderClient.h:
      (WebKit):
      (WebLoaderClient):
      * UIProcess/WebPageProxy.cpp:
      * UIProcess/WebPageProxy.h:
      (WebKit):
      (WebPageProxy):
      * UIProcess/WebPageProxy.messages.in:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchIntent):
      
      Tools:
      
      * MiniBrowser/mac/BrowserWindowController.m:
      (-[BrowserWindowController awakeFromNib]):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::initialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5b77372
    • vsevik@chromium.org's avatar
      Web Inspector: Errors when pending console messages are attached to JavaScriptSourceFrame. · 28796de2
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88712
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/PresentationConsoleMessageHelper.js:
      (WebInspector.PresentationConsoleMessageHelper):
      (WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
      (WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28796de2
    • peter@chromium.org's avatar
      [Chromium] Fix Clang build with USE(NATIVE_FULLSCREEN_VIDEO)=1 · b7c15bc6
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88987
      
      Reviewed by Simon Hausmann.
      
      The enterFullscreen method is declared as const by MediaPlayerPrivateInterface,
      so this one should be declared as such as well.
      
      
      * src/WebMediaPlayerClientImpl.cpp:
      (WebKit::WebMediaPlayerClientImpl::enterFullscreen):
      * src/WebMediaPlayerClientImpl.h:
      (WebMediaPlayerClientImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7c15bc6
    • zoltan@webkit.org's avatar
      check-webkit-style needs to respect Qt API coding style · 9ec8826f
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88995
      
      Reviewed by Csaba Osztrogonác.
      
      Add -whitespace/declaration exception to Qt API files.
      
      * Scripts/webkitpy/style/checker.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ec8826f
    • alexis.menard@openbossa.org's avatar
      Web Inspector: add a way to get the remote inspector url for a given page. · 36b4770d
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88902
      
      Reviewed by Jocelyn Turcotte.
      
      Expose the remote inspector url for a given page in the API. If you want
      to create a web view and load directly the inspector for the page you want to inspect,
      it helps to get the url as it is impossible to figure it out from the API layer.
      
      * UIProcess/API/qt/qquickwebview.cpp:
      (QQuickWebViewExperimental::remoteInspectorUrl):
      * UIProcess/API/qt/qquickwebview_p.h:
      * UIProcess/InspectorServer/WebInspectorServer.cpp:
      (WebKit):
      (WebKit::WebInspectorServer::inspectorUrlForPageID):
      * UIProcess/InspectorServer/WebInspectorServer.h:
      (WebInspectorServer):
      * UIProcess/InspectorServer/WebSocketServer.cpp:
      (WebKit::WebSocketServer::WebSocketServer):
      (WebKit::WebSocketServer::listen):
      (WebKit::WebSocketServer::close):
      * UIProcess/InspectorServer/WebSocketServer.h:
      (WebKit::WebSocketServer::bindAddress):
      (WebKit::WebSocketServer::port):
      (WebKit::WebSocketServer::serverState):
      (WebSocketServer):
      * UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:
      (WebKit::remoteInspectorPagePath):
      (WebKit):
      (WebKit::WebInspectorServer::inspectorUrlForPageID):
      (WebKit::WebInspectorServer::buildPageList):
      * UIProcess/WebInspectorProxy.h:
      (WebKit::WebInspectorProxy::remoteInspectionPageID):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36b4770d
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening after r120100, r120167, r120173 and r120181. · f110442e
      zandobersek@gmail.com authored
      * fast/events/constructors/speech-recognition-error-constructor-expected.txt:
      * platform/gtk/editing/pasteboard/4641033-expected.txt:
      * platform/gtk/editing/selection/mixed-editability-1-expected.txt:
      * platform/gtk/editing/selection/paragraph-granularity-expected.txt:
      * platform/gtk/editing/selection/triple-click-in-pre-expected.txt:
      * platform/gtk/editing/selection/word-granularity-expected.txt:
      * platform/gtk/fast/multicol/span/clone-flexbox-expected.txt:
      * platform/gtk/http/tests/misc/location-replace-crossdomain-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f110442e
    • commit-queue@webkit.org's avatar
      [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient · 27516ac5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88340
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-13
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Add implementation for dispatchIntent() in WebFrameLoaderClient.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Shared/API/c/WKBase.h:
      * Shared/APIClientTraits.h:
      * Shared/APIObject.h:
      * Shared/IntentData.cpp: Added.
      (WebKit):
      (WebKit::IntentData::encode):
      (WebKit::IntentData::decode):
      * Shared/IntentData.h: Added.
      (CoreIPC):
      (WebKit):
      (IntentData):
      * Target.pri:
      * UIProcess/API/C/WKAPICast.h:
      (WebKit):
      * UIProcess/API/C/WKPage.h:
      * UIProcess/API/gtk/WebKitLoaderClient.cpp:
      (attachLoaderClientToView):
      * UIProcess/WebIntentData.cpp: Added.
      (WebKit):
      (WebKit::WebIntentData::WebIntentData):
      (WebKit::WebIntentData::data):
      * UIProcess/WebIntentData.h: Added.
      (WebKit):
      (WebIntentData):
      (WebKit::WebIntentData::create):
      (WebKit::WebIntentData::~WebIntentData):
      (WebKit::WebIntentData::action):
      (WebKit::WebIntentData::payloadType):
      (WebKit::WebIntentData::extras):
      (WebKit::WebIntentData::suggestions):
      (WebKit::WebIntentData::type):
      * UIProcess/WebLoaderClient.cpp:
      (WebKit):
      (WebKit::WebLoaderClient::didReceiveIntentForFrame):
      * UIProcess/WebLoaderClient.h:
      (WebKit):
      (WebLoaderClient):
      * UIProcess/WebPageProxy.cpp:
      (WebKit):
      (WebKit::WebPageProxy::didReceiveIntentForFrame):
      * UIProcess/WebPageProxy.h:
      (WebKit):
      (WebPageProxy):
      * UIProcess/WebPageProxy.messages.in:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchIntent):
      
      Tools:
      
      Update initialization of WKPageLoaderClient.
      
      * MiniBrowser/mac/BrowserWindowController.m:
      (-[BrowserWindowController awakeFromNib]):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::initialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27516ac5
    • apavlov@chromium.org's avatar
      Web Inspector: Support user attributes in DOMNode · 2373f334
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88706
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      This change allows clients to store arbitrary properties on DOMNodes and know if there are descendants
      (and how many of them) having a certain property set.
      
      Test: inspector/elements/user-attributes.html
      
      * inspector/front-end/DOMAgent.js:
      (WebInspector.DOMNode.prototype._removeChild):
      (WebInspector.DOMNode.prototype._updateChildUserPropertyCountsOnRemoval):
      (WebInspector.DOMNode.prototype._updateDescendantUserPropertyCount):
      (WebInspector.DOMNode.prototype.setUserProperty):
      (WebInspector.DOMNode.prototype.removeUserProperty):
      (WebInspector.DOMNode.prototype.getUserProperty):
      (WebInspector.DOMNode.prototype.descendantUserPropertyCount):
      
      LayoutTests:
      
      * http/tests/inspector/elements-test.js:
      (initialize_ElementTest.InspectorTest.dumpElementsTree.dumpMap):
      (initialize_ElementTest.InspectorTest.dumpElementsTree.userPropertyDataDump):
      (initialize_ElementTest.InspectorTest.dumpElementsTree.print):
      (initialize_ElementTest.InspectorTest.dumpElementsTree):
      * inspector/elements/resources/user-properties.js: Added.
      (test.step0):
      (test.step1):
      (test.step2):
      (test):
      * inspector/elements/user-properties-expected.txt: Added.
      * inspector/elements/user-properties.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2373f334