Commits · 94141258d346c6295e77e1b2c8d475f5695569e6 · App_Technologies / webkit

25 Jun, 2012 2 commits

Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag). · 73eb1e5f

macpherson@chromium.org authored Jun 26, 2012

https://bugs.webkit.org/show_bug.cgi?id=89542

Reviewed by Dimitri Glazkov.

Source/WebCore:

Added fast/css/variables/build-supports-variables.html to test runtime flag in test environment.
Updated all other css variables tests to enable the runtime flag from JS.

* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::CSSParser::cssVariablesEnabled):
(WebCore):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::lex):
* css/CSSParser.h:
(CSSParser):
* css/CSSParserMode.h:
(CSSParserContext):
* page/Settings.h:
(Settings):
(WebCore::Settings::setCSSVariablesEnabled):
(WebCore::Settings::cssVariablesEnabled):

Source/WebKit/chromium:

* features.gypi:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setExperimentalCSSVariablesEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

73eb1e5f

Unreviewed, rolling out r121129. · 320d95e4

hclam@chromium.org authored Jun 25, 2012

http://trac.webkit.org/changeset/121129
https://bugs.webkit.org/show_bug.cgi?id=89542

Chromium ASan failure: crbug.com/134402

Source/WebCore:

* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::lex):
* css/CSSParser.h:
(CSSParser):
* css/CSSParserMode.h:
(CSSParserContext):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* page/Settings.h:
(Settings):
* testing/InternalSettings.cpp:
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit/chromium:

* features.gypi:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:
(WebSettingsImpl):

LayoutTests:

* fast/css/variables/border-width.html:
* fast/css/variables/build-supports-variables-expected.txt: Removed.
* fast/css/variables/build-supports-variables.html: Removed.
* fast/css/variables/colors-test.html:
* fast/css/variables/complex-cycle.html:
* fast/css/variables/computed-style.html:
* fast/css/variables/inherited-values.html:
* fast/css/variables/inline-styles.html:
* fast/css/variables/invalid-shorthand.html:
* fast/css/variables/invalid-variable-value.html:
* fast/css/variables/multi-level-cycle.html:
* fast/css/variables/redefinition.html:
* fast/css/variables/shorthand.html:
* fast/css/variables/simple-cycle.html:
* fast/css/variables/transform-test.html:
* fast/css/variables/undefined.html:
* fast/css/variables/use-before-defined.html:
* fast/css/variables/var-inside-shorthand.html:
* fast/css/variables/variable-chain.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

320d95e4

24 Jun, 2012 1 commit

Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag). · d7f98d4e

macpherson@chromium.org authored Jun 25, 2012

https://bugs.webkit.org/show_bug.cgi?id=89542

Reviewed by Dimitri Glazkov.

Source/WebCore:

Added fast/css/variables/build-supports-variables.html to test runtime flag in test environment.
Updated all other css variables tests to enable the runtime flag from JS.

* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::CSSParser::cssVariablesEnabled):
(WebCore):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::lex):
* css/CSSParser.h:
(CSSParser):
* css/CSSParserMode.h:
(CSSParserContext):
* page/Settings.h:
(Settings):
(WebCore::Settings::setCSSVariablesEnabled):
(WebCore::Settings::cssVariablesEnabled):

Source/WebKit/chromium:

* features.gypi:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setExperimentalCSSVariablesEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d7f98d4e

16 May, 2012 1 commit

Add tests for CSS Variables. · 6177786a

macpherson@chromium.org authored May 17, 2012

https://bugs.webkit.org/show_bug.cgi?id=86575

Reviewed by Dimitri Glazkov.

* fast/css/variables/colors-test-expected.html: Added.
* fast/css/variables/colors-test.html: Added.
* fast/css/variables/complex-cycle-expected.html: Added.
* fast/css/variables/complex-cycle.html: Added.
* fast/css/variables/computed-style-expected.html: Added.
* fast/css/variables/computed-style.html: Added.
* fast/css/variables/inherited-values-expected.html: Added.
* fast/css/variables/inherited-values.html: Added.
* fast/css/variables/inline-styles-expected.html: Added.
* fast/css/variables/inline-styles.html: Added.
* fast/css/variables/invalid-shorthand-expected.html: Added.
* fast/css/variables/invalid-shorthand.html: Added.
* fast/css/variables/invalid-variable-value-expected.html: Added.
* fast/css/variables/invalid-variable-value.html: Added.
* fast/css/variables/multi-level-cycle-expected.html: Added.
* fast/css/variables/multi-level-cycle.html: Added.
* fast/css/variables/redefinition-expected.html: Added.
* fast/css/variables/redefinition.html: Added.
* fast/css/variables/shorthand-expected.html: Added.
* fast/css/variables/shorthand.html: Added.
* fast/css/variables/simple-cycle-expected.html: Added.
* fast/css/variables/simple-cycle.html: Added.
* fast/css/variables/undefined-expected.html: Added.
* fast/css/variables/undefined.html: Added.
* fast/css/variables/use-before-defined-expected.html: Added.
* fast/css/variables/use-before-defined.html: Added.
* fast/css/variables/var-inside-shorthand-expected.html: Added.
* fast/css/variables/var-inside-shorthand.html: Added.
* fast/css/variables/variable-chain-expected.html: Added.
* fast/css/variables/variable-chain.html: Added.
* platform/chromium/test_expectations.txt: Skip tests until variables implementation lands.
* platform/efl/test_expectations.txt: Skip tests until variables implementation lands.
* platform/gtk/test_expectations.txt: Skip tests until variables implementation lands.
* platform/mac/test_expectations.txt: Skip tests until variables implementation lands.
* platform/qt/test_expectations.txt: Skip tests until variables implementation lands.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6177786a