1. 06 Dec, 2012 40 commits
    • abecsi@webkit.org's avatar
      [Qt][WK2] Fix QWebKitTest's notification of device pixel ratio change · 92c6f0c5
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104269
      
      Unreviewed, trivialy fixing last minute change.
      
      Move signal emission to the correct place.
      
      * UIProcess/API/qt/qquickwebview.cpp:
      (QQuickWebViewFlickablePrivate::onComponentComplete):
      * UIProcess/qt/PageViewportControllerClientQt.cpp:
      (WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92c6f0c5
    • commit-queue@webkit.org's avatar
      [Chromium] Add GL_CHROMIUM_async_pixel_transfers extension support. · 847381cb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103995
      
      Patch by David Reveman <reveman@chromium.org> on 2012-12-06
      Reviewed by Kenneth Russell.
      
      Add asyncTexImage2DCHROMIUM and asyncTexSubImage2DCHROMIUM to
      WebGraphicsContext3D.h.
      
      * chromium/public/WebGraphicsContext3D.h:
      (WebGraphicsContext3D):
      (WebKit::WebGraphicsContext3D::asyncTexImage2DCHROMIUM):
      (WebKit::WebGraphicsContext3D::asyncTexSubImage2DCHROMIUM):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      847381cb
    • commit-queue@webkit.org's avatar
      [CSS Exclusions] Add support for computing the first included interval position. · 4055b2e0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103327
      
      Source/WebCore:
      
      Patch by Hans Muller <hmuller@adobe.com> on 2012-12-06
      Reviewed by Levi Weintraub.
      
      If the first "word" in a line doesn't fit within the shape-inside when lineTop
      is the top of the shape's logical bounding box, adjust lineTop downwards to where
      the word fits.  Currently only rounded rectangle shapes are supported.
      
      Added ExclusionShape::firstIncludedIntervalLogicalTop(). The new virtual method
      computes the topmost/leftmost location where a line segment with the specified
      minLogicalIntervalSize will fit within the exclusion shape and returns the
      corresponding logical Y coordinate.  The result is additionally constrained to
      be at or below minLogicalIntervalTop. If the segment will not fit anywhere within
      the shape, then false is returned.
      
      During layout, minLogicalIntervalTop is the nominal top of the line being laid
      out within the exclusion shape.
      
      RenderBlock::layoutRunsAndFloatsInRange() now calls a new ExclusionShapeInsideInfo
      method, adjustLogicalLineTop(), which uses firstIncludedIntervalLogicalTop() to
      decide if the logical top of the line has to be moved downwards, for the first
      word to fit within the exclusion shape.
      
      Tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001.html
             fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002.html
      
      * rendering/ExclusionPolygon.cpp:
      (WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): This is a stub implementation.
      * rendering/ExclusionPolygon.h:
      * rendering/ExclusionRectangle.cpp:
      (WebCore::ellipseXIntercept): Added spaces to conform to webkit style and to be consistent with ellipseYIntercept()
      (WebCore::ellipseYIntercept): Compute an ellipse's Y intercept for an X coordinate.
      (WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop): See the description above.
      * rendering/ExclusionRectangle.h:
      * rendering/ExclusionShape.h:
      (ExclusionShape):
      (WebCore::ExclusionShape::logicalTopForMinY): Internal to logical coordinate conversion.
      * rendering/ExclusionShapeInsideInfo.cpp:
      (WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): A new method that updates m_lineTop with firstIncludedIntervalPosition().
      * rendering/ExclusionShapeInsideInfo.h:
      (ExclusionShapeInsideInfo):
      (WebCore::ExclusionShapeInsideInfo::logicalLineTop): This is just a cover for the private m_lineTop field.
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::layoutRunsAndFloatsInRange): Added code that restarts the layout loop if it's necessary to adjust the line's logicalTop.
      (WebCore::RenderBlock::restartLayoutRunsAndFloatsInRange): Factored newly common code into this helper function.
      
      LayoutTests:
      
      Test the rounded rectangle support for adjusting the top of a line downwards
      when the first word doesn't fit within the shape.
      
      Patch by Hans Muller <hmuller@adobe.com> on 2012-12-06
      Reviewed by Levi Weintraub.
      
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4055b2e0
    • mvujovic@adobe.com's avatar
      Unreviewed. Add myself to committers.py. · 89e4321f
      mvujovic@adobe.com authored
      * Scripts/webkitpy/common/config/committers.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89e4321f
    • schenney@chromium.org's avatar
      Rebaseline some expectations · 67069859
      schenney@chromium.org authored
      Unreviewed expectations update
      
      These test have expectations but apparently just need rebaselines.
      Some may still be flakey.
      
      * platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
      * platform/chromium-linux/svg/css/group-with-shadow-expected.png:
      * platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
      * platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
      * platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png:
      * platform/chromium-mac-lion/svg/custom/mask-invalidation-expected.png: Added.
      * platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
      * platform/chromium-mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
      * platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
      * platform/chromium-mac/svg/css/group-with-shadow-expected.png:
      * platform/chromium-mac/svg/custom/radialGradient-focal-radius-expected.png: Added.
      * platform/chromium-mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
      * platform/chromium-win-xp/svg/css/group-with-shadow-expected.png:
      * platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
      * platform/chromium-win/svg/css/group-with-shadow-expected.png:
      * platform/chromium-win/svg/custom/mask-invalidation-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
      * platform/chromium-win/svg/custom/radialGradient-focal-radius-expected.png: Added.
      * platform/chromium-win/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
      * platform/chromium/svg/custom/radialGradient-focal-radius-expected.png: Removed.
      * platform/chromium/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
      * platform/efl-wk1/svg/custom: Added.
      * platform/efl-wk1/svg/custom/radialGradient-focal-radius-expected.png: Added.
      * platform/efl/svg/custom/radialGradient-focal-radius-expected.png: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67069859
    • commit-queue@webkit.org's avatar
      [EFL] Optimize binary size by removing dead sections on unix/gcc · a51a222f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102827
      
      Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-06
      Reviewed by Kenneth Rohde Christiansen.
      
      Turn on -ffunction-sections -fdata-sections --gc-section flags
      on unix for the gcc toolchain for release builds to optimize binary
      size for the Efl port.
      
      * Source/cmake/OptionsEfl.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a51a222f
    • schenney@chromium.org's avatar
      Test expectations update · 31477764
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104007
      
      Unreviewed expectations update.
      
      * platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31477764
    • wjmaclean@chromium.org's avatar
      [chromium] Should apply link highlight to largest enclosing node with a handCursor. · f02843f2
      wjmaclean@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104264
      
      Reviewed by Adrienne Walker.
      
      Source/WebKit/chromium:
      
      Link highlights sometimes only apply to part of a link, if we select an enclosed
      node (e.g. font changes in link text). The highlight should be applied to the
      largest enclosing node that still has handCursor set.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::bestTouchLinkNode):
      
      LayoutTests:
      
      Add layout test to cover new functionality.
      
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested.html: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f02843f2
    • abecsi@webkit.org's avatar
      [Qt][WK2] Fix QWebKitTest's notification of device pixel ratio change · 61bcf6d7
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104269
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Since the ViewportInfoItem of MiniBrowser is created before the
      WebView finishes construction, thus before the viewport controller
      has been instantiated, the shown device pixel ratio was incorrect.
      Additionally QWebKitTest's notification signal was also not emitted
      when the value changed.
      
      * UIProcess/API/qt/qquickwebview.cpp:
      (QQuickWebViewPrivate::QQuickWebViewPrivate):
      * UIProcess/qt/PageViewportControllerClientQt.cpp:
      (WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61bcf6d7
    • rniwa@webkit.org's avatar
      Use ownerNode() instead of base() in HTMLCollection · 0a919eec
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104244
      
      Reviewed by Adam Barth.
      
      Use ownerNode() instead of base() in HTMLCollection to match LiveNodeList.
      Notice that the definition of base(), which this patch removes, is "return ownerNode()".
      
      * bindings/js/JSHTMLFormControlsCollectionCustom.cpp:
      (WebCore::getNamedItems):
      * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
      (WebCore::JSHTMLOptionsCollection::indexSetter):
      (WebCore::JSHTMLOptionsCollection::remove):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateImplementation):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateOpaqueRootForGC):
      * bindings/scripts/IDLAttributes.txt:
      * bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:
      (WebCore::getNamedItems):
      * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
      (WebCore::V8HTMLOptionsCollection::removeCallback):
      (WebCore::V8HTMLOptionsCollection::indexedPropertySetter):
      * dom/WebKitNamedFlow.cpp:
      (WebCore::WebKitNamedFlow::ownerNode):
      * dom/WebKitNamedFlow.h:
      (WebKitNamedFlow):
      * dom/WebKitNamedFlow.idl:
      * html/HTMLAllCollection.idl:
      * html/HTMLCollection.h:
      (HTMLCollection):
      * html/HTMLCollection.idl:
      * html/HTMLFormControlsCollection.cpp:
      (WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
      (WebCore::HTMLFormControlsCollection::create):
      (WebCore::HTMLFormControlsCollection::formControlElements):
      (WebCore::HTMLFormControlsCollection::formImageElements):
      (WebCore::HTMLFormControlsCollection::namedItem):
      (WebCore::HTMLFormControlsCollection::updateNameCache):
      * html/HTMLFormControlsCollection.idl:
      * html/HTMLNameCollection.cpp:
      (WebCore::HTMLNameCollection::~HTMLNameCollection):
      (WebCore::HTMLNameCollection::virtualItemAfter):
      * html/HTMLOptionsCollection.cpp:
      (WebCore::HTMLOptionsCollection::add):
      (WebCore::HTMLOptionsCollection::remove):
      (WebCore::HTMLOptionsCollection::selectedIndex):
      (WebCore::HTMLOptionsCollection::setSelectedIndex):
      (WebCore::HTMLOptionsCollection::setLength):
      * html/HTMLOptionsCollection.idl:
      * html/HTMLPropertiesCollection.cpp:
      (WebCore::HTMLPropertiesCollection::updateRefElements):
      (WebCore::HTMLPropertiesCollection::namedItem):
      * html/HTMLTableRowsCollection.cpp:
      (WebCore::HTMLTableRowsCollection::virtualItemAfter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a919eec
    • zandobersek@gmail.com's avatar
      UndoManager layout tests should be removed · 5a0cc107
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104246
      
      Reviewed by Adam Barth.
      
      The UndoManager feature support was removed from the source tree
      in r133326. The layout tests should be removed as well. As with
      the feature implementation, these too can be restored back when needed.
      
      * editing/undomanager: Removed.
      * editing/undomanager/automatic-transaction-attribute-expected.txt: Removed.
      * editing/undomanager/automatic-transaction-attribute.html: Removed.
      * editing/undomanager/automatic-transaction-data-expected.txt: Removed.
      * editing/undomanager/automatic-transaction-data.html: Removed.
      * editing/undomanager/automatic-transaction-node-expected.txt: Removed.
      * editing/undomanager/automatic-transaction-node.html: Removed.
      * editing/undomanager/document-has-undomanager-expected.txt: Removed.
      * editing/undomanager/document-has-undomanager.html: Removed.
      * editing/undomanager/domtransaction-survives-gc-expected.txt: Removed.
      * editing/undomanager/domtransaction-survives-gc.html: Removed.
      * editing/undomanager/undomanager-isolated-world-expected.txt: Removed.
      * editing/undomanager/undomanager-isolated-world.html: Removed.
      * editing/undomanager/undomanager-item-expected.txt: Removed.
      * editing/undomanager/undomanager-item.html: Removed.
      * editing/undomanager/undomanager-reenter-expected.txt: Removed.
      * editing/undomanager/undomanager-reenter.html: Removed.
      * editing/undomanager/undomanager-transact-expected.txt: Removed.
      * editing/undomanager/undomanager-transact.html: Removed.
      * editing/undomanager/undomanager-undo-redo-expected.txt: Removed.
      * editing/undomanager/undomanager-undo-redo.html: Removed.
      * editing/undomanager/undoscopehost-use-after-free-expected.txt: Removed.
      * editing/undomanager/undoscopehost-use-after-free.html: Removed.
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt-4.8/TestExpectations:
      * platform/qt-mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a0cc107
    • commit-queue@webkit.org's avatar
      [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky · a02708f9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104139
      
      Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
      Reviewed by Kenneth Rohde Christiansen.
      
      Resize the window back to 800x600 between tests.
      This should be a no-op if the test did not resize the window.
      
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::resetStateToConsistentValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a02708f9
    • alexis@webkit.org's avatar
      [Mac] Unreviewed gardening after r136415. · 8cedd0a8
      alexis@webkit.org authored
      r136415 enables the CSS3 background position offsets therefore this
      expected png needs to be updated with the new result (the correct one
      actually). It was not failing on the bot as the Apple Mac bot does not
      seem to run pixel tests.
      
      * platform/mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cedd0a8
    • tommyw@google.com's avatar
      Speech Recognition API: Change the error code to a string on SpeechRecognitionError · 05c3c5b1
      tommyw@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104254
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      SpeechRecognitionError::code (numeric value) has been changed to SpeechRecognitionError::error (string)
      in the latest specification.
      
      http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html#speechreco-error
      
      Existing tests modified to cover this patch.
      
      * Modules/speech/SpeechRecognitionError.cpp:
      (WebCore::ErrorCodeToString):
      (WebCore):
      (WebCore::SpeechRecognitionError::create):
      (WebCore::SpeechRecognitionError::SpeechRecognitionError):
      * Modules/speech/SpeechRecognitionError.h:
      (SpeechRecognitionErrorInit):
      (WebCore::SpeechRecognitionError::error):
      (SpeechRecognitionError):
      * Modules/speech/SpeechRecognitionError.idl:
      
      Source/WebKit/chromium:
      
      Minor WebCore type changes.
      
      * src/AssertMatchingEnums.cpp:
      * src/SpeechRecognitionClientProxy.cpp:
      (WebKit::SpeechRecognitionClientProxy::didReceiveError):
      
      Tools:
      
      Changes the mock error function to take a string instead of an int.
      
      * DumpRenderTree/chromium/DRTTestRunner.cpp:
      (DRTTestRunner::setMockSpeechRecognitionError):
      * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
      (WebTestRunner::ErrorTask::ErrorTask):
      (MockWebSpeechRecognizer::setError):
      * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
      (MockWebSpeechRecognizer):
      
      LayoutTests:
      
      Adjusting tests.
      
      * fast/events/constructors/speech-recognition-error-constructor-expected.txt:
      * fast/events/constructors/speech-recognition-error-constructor.html:
      * fast/speech/scripted/speechrecognition-errors-expected.txt:
      * fast/speech/scripted/speechrecognition-errors.html:
      * fast/speech/scripted/speechrecognitionerror-basics-expected.txt:
      * fast/speech/scripted/speechrecognitionerror-basics.html:
      * platform/chromium/fast/events/constructors/speech-recognition-error-constructor-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05c3c5b1
    • schenney@chromium.org's avatar
      SVG <use> element inside an svg-as-image fails · 68674b2b
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104007
      
      Reviewed by Eric Seidel.
      
      Upon redraw, SVGImage calls layout on the document it is drawing into
      the image if the image, provided it believes the redraw does not need
      to be delayed. Unfortunately, when an SVG <use> element is modified
      (by animation, say) and regenerates its shadow tree, the destructors
      invoke redraw, causing the SVGImage to call layout on something that
      is in the process of being deleted. That's bad.
      
      This change causes SVGImage to always delay the redraw. It is the most robust
      way to protect against this problem, as there may be any number of
      ways to cause this issue (a node being deleted in an svg-as-image
      target) and this protects against them all.
      
      The test case crashes in Asan Chromium.
      
      Source/WebCore: 
      
      Test: svg/as-image/animated-use-as-image-crash.html
      
      * svg/graphics/SVGImageCache.cpp:
      (WebCore::SVGImageCache::imageContentChanged): Always redraw on the timer.
      
      LayoutTests: 
      
      * platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Changed as a result of this change.
      * svg/as-image/animated-use-as-image-crash-expected.txt: Added.
      * svg/as-image/animated-use-as-image-crash.html: Added.
      * svg/as-image/resources/animated-href-on-use.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68674b2b
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, update an expected file. · d1a45694
      ossy@webkit.org authored
      * platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1a45694
    • commit-queue@webkit.org's avatar
      TextTrack's .cues not ordered correctly when two cues have the same .startTime · 4a0b22f1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103266
      
      Patch by Antoine Quint <graouts@apple.com> on 2012-12-06
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      Adding a new method TextTrackCueList::updateCueIndex() to update the list of
      cues after changing the .startTime or .endTime of a TextTrackCue. I elected to
      add a new method to TextTrackCueList rather than calling remove() and then add()
      on the list from TextTrack::cueDidChange() so that the nature of the operation
      is abstracted and we can easily change the way we keep the cue list sorted at
      a later time should we choose to.
      
      * html/track/TextTrack.cpp:
      (WebCore::TextTrack::cueDidChange):
      * html/track/TextTrackCueList.cpp:
      (WebCore::TextTrackCueList::updateCueIndex):
      (WebCore):
      * html/track/TextTrackCueList.h:
      (TextTrackCueList):
      
      LayoutTests:
      
      Unskip an Opera test that we now pass. Note that the original test has two issues that prompted
      changes in this patch. The first issue is https://www.w3.org/Bugs/Public/show_bug.cgi?id=20066
      and I've elected to comment the sub-test that fails and tracking turning it back on when the test
      is corrected with https://bugs.webkit.org/show_bug.cgi?id=104255. The second issue was in the sub-test
      that revealed the failure covered by this bug and had an issue acknowledged by the author
      (see https://www.w3.org/Bugs/Public/show_bug.cgi?id=20066) so I fixed it in our repository.
      
      * media/track/opera/interfaces/TextTrack/cues-expected.txt: Added.
      * media/track/opera/interfaces/TextTrack/cues.html:
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a0b22f1
    • pierre.rossi@gmail.com's avatar
      [Qt] QWebView uses the mobile style and doesn't follow Qt's style · faa2e7af
      pierre.rossi@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104134
      
      Reviewed by Simon Hausmann.
      
      Another issue introduced by r136235.
      Fix the order of initialization of the styleFactory and creation of the
      WebCore Page. Since the latter has a RenderTheme member and the creation
      of the appropriate RenderTheme type (QStyle-backed) is dependant on having
      first initialized the theme factory function, we need to postpone this just
      a little bit.
      
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::QWebPageAdapter):
      (QWebPageAdapter::initializeWebCorePage): Added.
      * WebCoreSupport/QWebPageAdapter.h:
      * WidgetApi/qwebpage.cpp:
      (QWebPagePrivate::QWebPagePrivate): call initializeWebCorePage only after
      having initialized WebKitWidgets related logic (QStyle hooks in this case).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faa2e7af
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r136788. · 17930810
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/136788
      https://bugs.webkit.org/show_bug.cgi?id=104260
      
      Asserts on EFL WebKit2 Debug bot (Requested by yael on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06
      
      * UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
      (WebKit::LayerTreeRenderer::setLayerState):
      (WebKit::LayerTreeRenderer::setRootLayerID):
      * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
      (WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
      (WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
      * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
      (LayerTreeCoordinator):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17930810
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r136795. · 121049c4
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/136795
      https://bugs.webkit.org/show_bug.cgi?id=104257
      
      Asserts on EFL WebKit2 Debug bot (Requested by yael on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06
      
      * UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
      (WebKit::LayerTreeRenderer::setRootLayerID):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      121049c4
    • commit-queue@webkit.org's avatar
      [EFL] Fix destination path in Source/PlatformEfl.cmake · f3f290ac
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104237
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2012-12-06
      Reviewed by Laszlo Gombos.
      
      Remove InspectorBackendCommands.js when copying it for the consistency in Source/PlatformEfl.cmake.
      
      * Source/PlatformEfl.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3f290ac
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 0f3317d6
      zandobersek@gmail.com authored
      Adding missing platform-specific baselines.
      
      * platform/gtk/fast/text/decorations-with-text-combine-expected.png: Added.
      * platform/gtk/fast/text/decorations-with-text-combine-expected.txt: Added.
      * platform/gtk/fast/text/orientation-sideways-expected.png: Added.
      * platform/gtk/fast/text/orientation-sideways-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f3317d6
    • abecsi@webkit.org's avatar
      [Qt][Mac] Fix libxslt and libxml2 config tests · 8da4e100
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104164
      
      Reviewed by Simon Hausmann.
      
      Source/WebCore:
      
      Since libxml2 is a dependency for libxslt and is not used
      standalone the configurations for it should also depend on
      whether XSLT is enabled.
      Also avoid using pkg-config on Mac, instead use direct
      include paths and add needed libraries to the linker.
      
      No new tests needed.
      
      * WebCore.pri:
      
      Tools:
      
      We should not use pkg-config on Mac instead use direct include
      paths and add needed libraries to the linker options to detect
      libxslt and libxml2 provided by the system.
      Previously we would always fall back to qtxmlpatterns.
      
      * qmake/config.tests/libxml2/libxml2.pro:
      * qmake/config.tests/libxslt/libxslt.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8da4e100
    • ossy@webkit.org's avatar
      [Qt] Fix the build if the path contains "+" character · ae4df2ab
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104120
      
      Reviewed by Tor Arne Vestbø.
      
      The second parameter of qmake's replace() is regular expression, so
      we have to escape special characters in paths passed to replace().
      
      * qmake/mkspecs/features/default_post.prf:
      * qmake/mkspecs/features/default_pre.prf:
      * qmake/mkspecs/features/functions.prf:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae4df2ab
    • commit-queue@webkit.org's avatar
      [EFL][Qt] fast/regions/autowidth-normalflow-maxwidth.html is failing · 724c297e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104160
      
      Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
      Reviewed by Kenneth Rohde Christiansen.
      
      The test fast/regions/autowidth-normalflow-maxwidth.html is failing for EFL and Qt
      because the test expects that the text of the test would fit in 400 pixels,
      but both for Qt and for EFL, the text requires more than that.
      Changed the test and the expectation ref-test to allow 450 pixels.
      
      * fast/regions/autowidth-normalflow-maxwidth-expected.html:
      * fast/regions/autowidth-normalflow-maxwidth.html:
      * platform/efl-wk2/TestExpectations:
      * platform/qt-5.0-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      724c297e
    • shinyak@chromium.org's avatar
      Internals.getElementByIdInShadowRoot is nonsense now. · b98e8f8d
      shinyak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104241
      
      Reviewed by Kent Tamura.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Since we have ShadowRoot.getElementById() now, we don't need Internals.getElementByIdInShadowRoot, which is
      the same functionality of ShadowRoot.getElementById().
      
      Test: fast/dom/shadow/get-element-by-id-in-shadow-root.html
      
      * WebCore.exp.in:
      * testing/Internals.cpp:
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def.in:
      
      LayoutTests:
      
      * fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt:
      * fast/dom/shadow/get-element-by-id-in-shadow-root.html:
      * fast/dom/shadow/resources/shadow-dom.js: Uses ShadowRoot.getElementById() instead.
      (getNodeInShadowTreeStack):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b98e8f8d
    • christophe.dumez@intel.com's avatar
      [EFL][WK2] Context clients should unregister themselves when destroyed · 5b12c7a1
      christophe.dumez@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104113
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Make sure the context clients (History and Download clients)
      unregister themselves when destroyed to make sure their
      callback functions are never called after the client objects
      have been destroyed (i.e. when the parent Ewk_Context has
      been destroyed).
      
      This addresses crashing issues after a Ewk_Context object
      gets unref'd and destroyed.
      
      * UIProcess/efl/ContextHistoryClientEfl.cpp:
      (WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
      (WebKit):
      (WebKit::ContextHistoryClientEfl::~ContextHistoryClientEfl):
      * UIProcess/efl/ContextHistoryClientEfl.h:
      (ContextHistoryClientEfl):
      * UIProcess/efl/DownloadManagerEfl.cpp:
      (WebKit::DownloadManagerEfl::~DownloadManagerEfl):
      (WebKit):
      * UIProcess/efl/DownloadManagerEfl.h:
      (DownloadManagerEfl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b12c7a1
    • commit-queue@webkit.org's avatar
      [EFL] Active texture state gets corrupted after updating graphics surface contents. · 4e27e6ae
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104248.
      
      Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-06
      Reviewed by Kenneth Rohde Christiansen.
      
      GraphicsContext3DPrivate::copyToGraphicsSurface() doesn't restore the previously bound texture
      after copying texture contents. This corrupts the texture state.
      
      Existing Tests should cover this.
      
      * platform/graphics/efl/GraphicsContext3DPrivate.cpp:
      (GraphicsContext3DPrivate::copyToGraphicsSurface):
      * platform/graphics/opengl/GLPlatformSurface.cpp:
      (WebCore::GLPlatformSurface::updateContents):
      * platform/graphics/opengl/GLPlatformSurface.h:
      (GLPlatformSurface):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e27e6ae
    • apavlov@chromium.org's avatar
      Web Inspector: Goto panel shortcuts and description are reversed · 1ae24eb7
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103988
      
      Reviewed by Pavel Feldman.
      
      Swap the square brackets in the shortcuts.
      
      * inspector/front-end/inspector.js:
      (WebInspector._registerShortcuts):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ae24eb7
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r136825. · 90b81888
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/136825
      https://bugs.webkit.org/show_bug.cgi?id=104251
      
      It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
      flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06
      
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::resetStateToConsistentValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90b81888
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r136818. · b778377c
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/136818
      https://bugs.webkit.org/show_bug.cgi?id=104249
      
      simulatedClick does not work as per #chrmium irc. (Requested
      by hayato on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06
      
      Source/WebCore:
      
      * dom/EventDispatcher.cpp:
      (WebCore::EventRelatedTargetAdjuster::adjust):
      * dom/MouseEvent.cpp:
      (WebCore::MouseEventDispatchMediator::create):
      (WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator):
      (WebCore::MouseEventDispatchMediator::dispatchEvent):
      * dom/MouseEvent.h:
      (MouseEventDispatchMediator):
      * dom/Node.cpp:
      (WebCore::Node::dispatchEvent):
      
      LayoutTests:
      
      * fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
      * fast/dom/shadow/shadow-dom-event-dispatching.html:
      * fast/events/dispatch-synthetic-mouseevent-expected.txt: Removed.
      * fast/events/dispatch-synthetic-mouseevent.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b778377c
    • podivilov@chromium.org's avatar
      [chromium] Unreviewed, fix baselines for... · 01cc1b1d
      podivilov@chromium.org authored
      [chromium] Unreviewed, fix baselines for plugins/npp-set-window-called-during-destruction.html on win7.
      
      * platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
      * platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
      * platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt:
      * platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01cc1b1d
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update · 6362e0a3
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104210
      https://bugs.webkit.org/show_bug.cgi?id=103869
      
      * platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
      * platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png:
      * platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
      * platform/chromium-linux/fast/forms/datetime/datetime-appearance-l10n-expected.png:
      * platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
      * platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
      * platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
      * platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
      * platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
      * platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
      * platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
      * platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
      * platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-lion/fast/forms/datetime/datetime-appearance-l10n-expected.png:
      * platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
      * platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
      * platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
      * platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
      * platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/datetime/datetime-appearance-l10n-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
      * platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
      * platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
      * platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
      * platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
      * platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
      * platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png:
      * platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
      * platform/chromium-win/fast/forms/datetime/datetime-appearance-l10n-expected.png:
      * platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
      * platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
      * platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
      * platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
      * platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
      * platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
      * platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6362e0a3
    • tkent@chromium.org's avatar
      [Chromium] Update test expectations · 6f5c9746
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103853
      https://bugs.webkit.org/show_bug.cgi?id=103869
      
      * platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
      * platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f5c9746
    • commit-queue@webkit.org's avatar
      [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky · 955b9250
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104139
      
      Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
      Reviewed by Kenneth Rohde Christiansen.
      
      Resize the window back to 800x600 between tests.
      This should be a no-op if the test did not resize the window.
      
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::resetStateToConsistentValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      955b9250
    • commit-queue@webkit.org's avatar
      [v8] Fix hidden property name of V8ArrayBufferView flag. · e1441ac4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104099
      
      Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-12-06
      Reviewed by Kentaro Hara.
      
      Fix hidden property name of V8ArrayBufferView hidden copy method.
      
      * bindings/v8/V8HiddenPropertyName.h:
      (WebCore):
      * bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
      (WebCore::getHiddenCopyMethod):
      (WebCore::installHiddenCopyMethod):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1441ac4
    • haraken@chromium.org's avatar
      Unreviewed. Fixed a wrong comment landed in r136822. · 384cc7fb
      haraken@chromium.org authored
      * bindings/v8/V8Binding.h:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      384cc7fb
    • haraken@chromium.org's avatar
      [V8] Implement deprecatedV8String() · 22585752
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104230
      
      Reviewed by Adam Barth.
      
      To make an Isolate mandatory in v8String(), we implement
      deprecatedV8String() for call sites that don't have
      an Isolate. Eventually we want to kill the method though.
      
      No tests. No change in behavior.
      
      * bindings/scripts/test/V8/V8TestCallback.cpp:
      (WebCore::V8TestCallback::callbackWithClass2Param):
      * bindings/v8/Dictionary.cpp:
      (WebCore::Dictionary::getKey):
      * bindings/v8/IDBBindingUtilities.cpp:
      (WebCore::get):
      (WebCore::set):
      * bindings/v8/JavaScriptCallFrame.cpp:
      (WebCore::JavaScriptCallFrame::evaluate):
      * bindings/v8/ScriptController.cpp:
      (WebCore::ScriptController::compileAndRunScript):
      (WebCore::ScriptController::bindToWindowObject):
      (WebCore::ScriptController::disableEval):
      * bindings/v8/ScriptDebugServer.cpp:
      (WebCore::ScriptDebugServer::setBreakpoint):
      (WebCore::ScriptDebugServer::removeBreakpoint):
      (WebCore::ScriptDebugServer::setScriptSource):
      (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
      (WebCore::ScriptDebugServer::compileScript):
      * bindings/v8/ScriptFunctionCall.cpp:
      (WebCore::ScriptCallArgumentHandler::appendArgument):
      (WebCore::ScriptFunctionCall::call):
      (WebCore::ScriptFunctionCall::construct):
      * bindings/v8/ScriptProfiler.cpp:
      (WebCore::ScriptProfiler::start):
      (WebCore::ScriptProfiler::stop):
      (WebCore::ScriptProfiler::takeHeapSnapshot):
      * bindings/v8/ScriptSourceCode.cpp:
      (WebCore::ScriptSourceCode::compileScript):
      * bindings/v8/V8Binding.h:
      (WebCore):
      (WebCore::deprecatedV8String):
      * bindings/v8/V8DOMWindowShell.cpp:
      (WebCore::V8DOMWindowShell::initializeIfNeeded):
      (WebCore::V8DOMWindowShell::namedItemAdded):
      (WebCore::V8DOMWindowShell::namedItemRemoved):
      * bindings/v8/V8LazyEventListener.cpp:
      (WebCore::V8LazyEventListener::prepareListenerObject):
      * bindings/v8/V8WindowErrorHandler.cpp:
      (WebCore::V8WindowErrorHandler::callListenerFunction):
      * bindings/v8/V8WorkerContextErrorHandler.cpp:
      (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
      * bindings/v8/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::evaluate):
      * bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
      (WebCore::installHiddenCopyMethod):
      (WebCore::copyElements):
      * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
      (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
      * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
      (WebCore::V8InjectedScriptHost::getEventListenersCallback):
      * bindings/v8/custom/V8InjectedScriptManager.cpp:
      (WebCore::InjectedScriptManager::createInjectedScript):
      * bindings/v8/custom/V8MessageEventCustom.cpp:
      (WebCore::V8MessageEvent::dataAccessorGetter):
      * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
      (WebCore::toV8Object):
      (WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22585752
    • keishi@webkit.org's avatar
      Page popup should align to the right when the anchor element is rtl · 26c757cf
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104219
      
      Reviewed by Kent Tamura.
      
      Page popup should align to the right edge of the anchor element when the anchor element is rtl.
      
      No new tests. Mock page popup can't test popup window position.
      
      * Resources/pagepopups/pickerCommon.js:
      (_adjustWindowRectHorizontally): Align to the right edge when anchor element is rtl. Removed some redundant lines.
      (setWindowRect): If the window is hidden we want to move first then resize so the popup doesn't flicker.
      (isWindowHidden): Returns true if the window is hidden using hideWindow().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26c757cf
    • haraken@chromium.org's avatar
      [V8] Make an Isolate mandatory for v8StringOrNull() and v8StringOrUndefined() · 75e36779
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104213
      
      Reviewed by Adam Barth.
      
      All call sites of v8StringOrNull() and v8StringOrUndefined() have an Isolate.
      
      No tests. No change in behavior.
      
      * bindings/v8/V8Binding.h:
      (WebCore::v8StringOrNull):
      (WebCore::v8StringOrUndefined):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75e36779