1. 27 Mar, 2013 1 commit
    • eric.carlson@apple.com's avatar
      [Mac] webkitClosedCaptionsVisible doesn't work · 92907e15
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113417
      
      Reviewed by Jer Noble.
      
      Source/WebCore: 
      
      Test: media/track/track-in-band-legacy-api.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement): Delete m_disableCaptions, it is no longer used.
      (WebCore::HTMLMediaElement::configureTextTrackGroup): Pass this to textTrackSelectionScore.
      (WebCore::HTMLMediaElement::setClosedCaptionsVisible):  Delete m_disableCaptions, it is no longer used.
      * html/HTMLMediaElement.h: Ditto.
      
      * page/CaptionUserPreferences.cpp:
      (WebCore::CaptionUserPreferences::textTrackSelectionScore): Add an HTMLMediaElement parameter.
      * page/CaptionUserPreferences.h:
      
      * page/CaptionUserPreferencesMac.h:
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Return a score if the media element
          is showing captions, even if the preference says captions are disabled.
      
      LayoutTests: 
      
      * media/track/track-in-band-legacy-api-expected.txt: Added.
      * media/track/track-in-band-legacy-api.html: Added.
      
      * platform/chromium/TestExpectations: Skip new test.
      * platform/efl/TestExpectations: Ditto.
      * platform/gtk/TestExpectations: Ditto.
      * platform/mac/TestExpectations: Ditto.
      * platform/qt/TestExpectations: Ditto.
      * platform/win/TestExpectations: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92907e15
  2. 25 Mar, 2013 4 commits
  3. 22 Mar, 2013 4 commits
  4. 21 Mar, 2013 1 commit
  5. 20 Mar, 2013 2 commits
    • rniwa@webkit.org's avatar
      Add flaky test expectations to compositing/geometry/limit-layer-bounds-fixed.html · d442557d
      rniwa@webkit.org authored
      and fast/dom/MutationObserver/database-callback-delivery.html on Windows per bugs
      112867 and 112868.
      
      * platform/win/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d442557d
    • commit-queue@webkit.org's avatar
      Source/WebCore: [css3-text] Parsing -webkit-each-line value for text-indent from css3-text · 30809ee8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109021
      
      Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-20
      Reviewed by Julien Chaffraix.
      
      "each-line" is added for text-indent in CSS3.
      http://dev.w3.org/csswg/css3-text/#each-line
      
      This patch is the parsing part to support each-line value for text-indent.
      
      "each-line" means "Indentation affects the first line of the block
      container as well as each line after a forced line break, but does
      not affect lines after a soft wrap break."
      
      It's prefixed and guarded by CSS3_TEXT flag.
      
      Tests: fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html
             fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
          style.getPropertyCSSValue(text-indent) returns CSSPrimitiveValue when text-indent has only <length>
          or <percentage> value, but returns CSSValueList when text-indent also has -webkit-each-line.
      
      * css/CSSParser.cpp:
      (WebCore::isSimpleLengthPropertyID): Removed CSSPropertyTextIndent case.
      (WebCore::CSSParser::parseValue):
      (WebCore::CSSParser::parseTextIndent): Added.
      * css/CSSParser.h:
          Parsed <length> or <percentage> with -webkit-each-line for text-indent.
      
      * css/CSSValueKeywords.in: Added new -webkit-each-line keyword.
      * css/StyleBuilder.cpp:
      (ApplyPropertyTextIndent): Added.
      (WebCore::ApplyPropertyTextIndent::applyInheritValue):
      (WebCore::ApplyPropertyTextIndent::applyInitialValue):
      (WebCore::ApplyPropertyTextIndent::applyValue):
      (WebCore::ApplyPropertyTextIndent::createHandler):
      (WebCore::StyleBuilder::StyleBuilder):
          Added codes to handle applying text-indent offset and -webkit-each-line option to our style.
      
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::diff):
      * rendering/style/RenderStyle.h:
      * rendering/style/RenderStyleConstants.h: Added enum TextIndentLine.
      * rendering/style/StyleRareInheritedData.cpp:
      (WebCore::StyleRareInheritedData::StyleRareInheritedData):
      (WebCore::StyleRareInheritedData::operator==):
      * rendering/style/StyleRareInheritedData.h: Added m_textIndentLine.
      (StyleRareInheritedData):
          Added the usual getter / setter / initial methods for m_textIndentLine.
      
      LayoutTests: [css3-text] Parsing -webkit-each-line value for text-indent from css3-text
      https://bugs.webkit.org/show_bug.cgi?id=109021
      
      "each-line" is added for text-indent in CSS3.
      http://dev.w3.org/csswg/css3-text/#each-line
      
      Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-20
      Reviewed by Julien Chaffraix.
      
      * fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt: Added.
      * fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt: Added.
      * fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html: Added.
      * fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html: Added.
      * fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent-inherited.js: Added.
      (testComputedStyle):
      (ownValueTest):
      (inheritanceTest):
      * fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js: Added.
      (testElementStyle):
      (testComputedStyle):
      (valueSettingTest):
      (invalidValueSettingTest):
      * platform/chromium/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt-mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30809ee8
  6. 19 Mar, 2013 2 commits
    • rniwa@webkit.org's avatar
      Add failing test expectations on Windows per bugs 112764 and 112766. · 1d0ae5db
      rniwa@webkit.org authored
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d0ae5db
    • dino@apple.com's avatar
      Source/WebCore: Allow PlugIn Snapshotting to be tested · 0743e1e4
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98696
      
      Reviewed by Tim Horton.
      
      Expose a new setting maximumPlugInSnapshotAttempts that can
      be set by testing scripts.
      
      Tests: plugins/snapshotting/restart.html
             plugins/snapshotting/simple.html
      
      * page/Settings.in:
      
      Source/WebKit2: Allow PlugIn Snapshotting to be tested
      https://bugs.webkit.org/show_bug.cgi?id=98696
      
      Reviewed by Tim Horton.
      
      Use the new maximumPlugInSnapshotAttempts setting rather than a hardcoded
      value. At the same time, if this value is 0, then snapshot immediately
      (don't wait to get a snapshot and test it).
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::didInitializePlugin): Snapshot immediately if maximum attempts are 0.
      (WebKit::PluginView::pluginSnapshotTimerFired): Use setting rather than file local variable.
      
      LayoutTests: Allow PlugIn Snapshotting to be tested
      https://bugs.webkit.org/show_bug.cgi?id=98696
      <rdar://problem/12456731>
      
      Reviewed by Tim Horton.
      
      Two new simple tests for plugin snapshotting. One that makes
      sure the plugin was snapshotted (looks for the RenderSnapshottedPlugin)
      and one that restarts a snapshotted plugin by clicking.
      
      Since this feature is currently only enabled in WebKit2, the tests
      are skipped everywhere else.
      
      * platform/chromium/TestExpectations: Skip plugins/snapshotting.
      * platform/efl/TestExpectations: Ditto.
      * platform/gtk/TestExpectations: Ditto.
      * platform/mac-wk2/TestExpectations: Ditto.
      * platform/mac-wk2/plugins/snapshotting/restart-expected.txt: Added.
      * platform/mac-wk2/plugins/snapshotting/simple-expected.txt: Added.
      * platform/mac/TestExpectations: Skip plugins/snapshotting.
      * platform/qt/TestExpectations: Ditto.
      * platform/win/TestExpectations: Ditto.
      * plugins/snapshotting/restart.html: Added.
      * plugins/snapshotting/simple.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0743e1e4
  7. 18 Mar, 2013 1 commit
  8. 13 Mar, 2013 3 commits
    • kinuko@chromium.org's avatar
      Quota API: Update IDL to make it match the latest WD · 5c3424aa
      kinuko@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88396
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Add a new interface object (navigator.StorageQuota) and deprecate the old one (window.StorageInfo)
      to make the code match with the latest Quota API WD:
      http://www.w3.org/TR/quota-api/
      
      Tests: storage/storagequota-query-usage.html
             storage/storagequota-request-quota.html
      
      * CMakeLists.txt:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * Modules/quota/DOMWindowQuota.cpp:
      (WebCore::DOMWindowQuota::webkitStorageInfo): Added a deprecate warning message for the old interface.
      * Modules/quota/NavigatorStorageQuota.cpp: Added for the new interface.
      * Modules/quota/NavigatorStorageQuota.h: Added for the new interface.
      * Modules/quota/NavigatorStorageQuota.idl: Added for the new interface.
      * Modules/quota/StorageErrorCallback.cpp:
      (WebCore::StorageErrorCallback::CallbackTask::CallbackTask):
      (WebCore::StorageErrorCallback::CallbackTask::performTask):
      * Modules/quota/StorageErrorCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoErrorCallback.h.
      (WebCore):
      (StorageErrorCallback):
      (WebCore::StorageErrorCallback::~StorageErrorCallback):
      (WebCore::StorageErrorCallback::CallbackTask::create):
      * Modules/quota/StorageErrorCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoErrorCallback.idl.
      * Modules/quota/StorageInfo.cpp: Added code to relay requests to the new StorageQuota implementation.
      * Modules/quota/StorageInfo.h:
      * Modules/quota/StorageInfo.idl:
      * Modules/quota/StorageQuota.cpp: Added for the new interface.
      * Modules/quota/StorageQuota.h:
      (WebCore::StorageQuota::create):
      * Modules/quota/StorageQuota.idl: Copied from Source/WebCore/Modules/quota/StorageInfo.idl.
      * Modules/quota/StorageQuotaCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoQuotaCallback.h.
      * Modules/quota/StorageQuotaCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoQuotaCallback.idl.
      * Modules/quota/StorageUsageCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoUsageCallback.h.
      * Modules/quota/StorageUsageCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoUsageCallback.idl.
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * page/FeatureObserver.h:
      
      Source/WebKit/chromium:
      
      Add a new interface object (navigator.StorageQuota) and deprecate the old one (window.StorageInfo)
      to make the code match with the latest Quota API WD:
      http://www.w3.org/TR/quota-api/
      
      * WebKit.gyp:
      * src/AssertMatchingEnums.cpp:
      * src/StorageQuotaChromium.cpp: Renamed from Source/WebKit/chromium/src/StorageInfoChromium.cpp.
      (WebCore):
      (WebCore::StorageQuota::queryUsageAndQuota):
      (WebCore::StorageQuota::requestQuota):
      * src/WebStorageQuotaCallbacksImpl.cpp:
      (WebKit::WebStorageQuotaCallbacksImpl::WebStorageQuotaCallbacksImpl):
      * src/WebStorageQuotaCallbacksImpl.h:
      (WebCore):
      (WebStorageQuotaCallbacksImpl):
      
      LayoutTests:
      
      * platform/chromium/TestExpectations:
      * storage/storagequota-query-usage-expected.txt: Added.
      * storage/storagequota-query-usage.html: Added.
      * storage/storagequota-request-quota-expected.txt: Added.
      * storage/storagequota-request-quota.html: Added.
      
      Rebaselines:
      * platform/chromium/fast/dom/everything-to-string-expected.txt: Added.
      * platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
      * platform/chromium/fast/js/global-constructors-expected.txt:
      * platform/chromium/http/tests/security/isolatedWorld/all-window-properties-expected.txt: Added.
      * platform/chromium/http/tests/security/isolatedWorld/all-window-prototypes-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c3424aa
    • timothy_horton@apple.com's avatar
      Make lint-test-expectations happy with the Apple-Windows TestExpectations files · 0349df13
      timothy_horton@apple.com authored
      Unreviewed.
      
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0349df13
    • timothy_horton@apple.com's avatar
      Make lint-test-expectations happy with the Apple-Windows TestExpectations files · 6e9ee81e
      timothy_horton@apple.com authored
      Unreviewed.
      
      accessibility/radio-button-checkbox-size.html was moved to platform/mac in http://trac.webkit.org/changeset/138124
      fast/css/ignore-text-zoom.html was removed in http://trac.webkit.org/changeset/145168
      inspector-protocol/layer-tree.html was removed in http://trac.webkit.org/changeset/144624
      Remove a bunch of duplicate entries.
      
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e9ee81e
  9. 08 Mar, 2013 1 commit
  10. 07 Mar, 2013 2 commits
  11. 06 Mar, 2013 3 commits
  12. 05 Mar, 2013 4 commits
  13. 02 Mar, 2013 1 commit
    • benjamin@webkit.org's avatar
      Move computedStyleIncludingVisitedInfo from TestRunner to Internals · 599049a9
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109772
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-02
      Reviewed by Andreas Kling.
      
      Source/WebCore: 
      
      The function computedStyleIncludingVisitedInfo() is purely internal to WebCore,
      it is better defined on Internals than on TestRunner.
      
      * testing/Internals.cpp:
      (WebCore::Internals::computedStyleIncludingVisitedInfo):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/blackberry: 
      
      * WebKitSupport/DumpRenderTreeSupport.cpp:
      * WebKitSupport/DumpRenderTreeSupport.h:
      (DumpRenderTreeSupport):
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      (DumpRenderTreeSupportGtk):
      
      Source/WebKit/mac: 
      
      * WebView/WebView.mm:
      * WebView/WebViewPrivate.h:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      Source/WebKit2: 
      
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
      * WebProcess/WebPage/WebFrame.cpp:
      * WebProcess/WebPage/WebFrame.h:
      (WebFrame):
      
      Tools: 
      
      * DumpRenderTree/TestRunner.cpp:
      (TestRunner::staticFunctions):
      * DumpRenderTree/TestRunner.h:
      (TestRunner):
      * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
      * DumpRenderTree/efl/TestRunnerEfl.cpp:
      * DumpRenderTree/gtk/TestRunnerGtk.cpp:
      * DumpRenderTree/mac/TestRunnerMac.mm:
      * DumpRenderTree/qt/TestRunnerQt.cpp:
      * DumpRenderTree/qt/TestRunnerQt.h:
      (TestRunner):
      * DumpRenderTree/win/TestRunnerWin.cpp:
      * DumpRenderTree/wx/TestRunnerWx.cpp:
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      LayoutTests: 
      
      Update the tests.
      
      * fast/history/multiple-classes-visited.html:
      * fast/history/nested-visited-test.html:
      * fast/history/self-is-visited.html:
      * fast/history/sibling-visited-test.html:
      * fast/loader/stateobjects/state-url-sets-links-visited.html:
      * platform/win/TestExpectations: unskip the tests.
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      599049a9
  14. 01 Mar, 2013 3 commits
  15. 28 Feb, 2013 1 commit
  16. 27 Feb, 2013 2 commits
    • simonjam@chromium.org's avatar
      [chromium] Lower priority of preloaded images · 46617ac1
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110527
      
      Source/WebCore:
      
      Reviewed by Nate Chapin.
      
      This improves Speed Index by ~5%, because it encourages us to load images that are needed for
      painting over speculative preloads. Ideally, all embedders would use this, but it relies on
      ResourceHandle::didChangePriority being implemented. Currently, only Chrome does that.
      
      Test: http/tests/loading/promote-img-preload-priority.html
      
      * loader/FrameLoaderClient.h:
      (FrameLoaderClient):
      (WebCore::FrameLoaderClient::dispatchDidChangeResourcePriority): Added callback to enable testing.
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::setLoadPriority): Signal callback.
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::preload): Actual behavior change.
      
      Source/WebKit/chromium:
      
      Plumb the didChangePriority signal into DRT so it can be tested.
      
      Reviewed by Nate Chapin.
      
      * public/WebFrameClient.h:
      (WebKit):
      (WebKit::WebFrameClient::didChangeResourcePriority):
      (WebFrameClient):
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDidChangeResourcePriority):
      (WebKit):
      * src/FrameLoaderClientImpl.h:
      (FrameLoaderClientImpl):
      
      Tools:
      
      Plumb the didChangePriority signal into DRT so it can be tested.
      
      Reviewed by Nate Chapin.
      
      * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
      (WebKit):
      (WebTestRunner::WebTestProxy::didChangeResourcePriority):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
      (WebTestRunner::TestRunner::TestRunner):
      (WebTestRunner::TestRunner::reset):
      (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
      (WebTestRunner):
      (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
      (TestRunner):
      * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
      (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
      (WebTestRunner::WebTestProxyBase::willSendRequest):
      (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
      (WebTestRunner):
      
      LayoutTests:
      
      Reviewed by Nate Chapin.
      
      * http/tests/loading/promote-img-preload-priority-expected.txt: Added.
      * http/tests/loading/promote-img-preload-priority.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46617ac1
    • ossy@webkit.org's avatar
      One more unreviewed fix after r144032 and r144051. · 6ae42915
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110734
      
      Patch by Csaba Osztrogonác <ossy@webkit.org> on 2013-02-26
      
      * TestExpectations: Unskip tests.
      * html5lib/generated/run-template-write.html: Revert an accidental change by r144051.
      * platform/gtk/TestExpectations: Skip run-template-data.html and run-template-write.html instead of run-template.html
      * platform/mac/TestExpectations: Ditto.
      * platform/qt/TestExpectations: Ditto.
      * platform/win/TestExpectations: Ditto.
      * platform/wincairo/TestExpectations: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ae42915
  17. 26 Feb, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Empty <button>s should collapse; empty <input type="button"> should not collapse · e293e4a4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110654
      
      Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-26
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      This patch also fixes other height computation issues with flex boxes
      related to scroll bars and hasLineIfEmpty()=true. See below for
      details.
      
      Tests: css3/flexbox/button.html
             css3/flexbox/position-absolute-child-with-contenteditable.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::layoutBlock): Add a FIXME to make
      border/padding/scrollbar inclusion more consistent with other
      renderers.
      * rendering/RenderButton.h:
      (WebCore::RenderButton::hasLineIfEmpty): We only want a line for
      <input type=button|submit|reset>, for consistency with Firefox.
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::layoutBlock): Start out layoutBlock by
      setting the logical height to border + padding + scrollbar height to
      ensure that we have space for the scrollbar even without children. The
      layoutFlexItems change below is not enough because we also need this
      when hasLineIfEmpty() is false.
      (WebCore::RenderFlexibleBox::layoutFlexItems): Ensure we have a line
      when hasLineIfEmpty() is true by calling setLogicalHeight(border+
      padding+scrollbar+lineHeight()) if we don't have a flex line.
      
      LayoutTests:
      
      * css3/flexbox/button-expected.png: Added.
      * css3/flexbox/button-expected.txt: Added.
      * css3/flexbox/button.html: Added.
      Test empty buttons, <input type=button>, and buttons with
      overflow:scroll;
      
      * css3/flexbox/position-absolute-child-with-contenteditable-expected.html: Added.
      * css3/flexbox/position-absolute-child-with-contenteditable.html: Added.
      Test flex boxes with hasLineIfEmpty()=true and absolute positioned
      children. Uses contenteditable=true to get that effect.
      
      * platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.png:
      * platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.txt:
      * platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
      * platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt:
      * platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
      * platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.txt:
      Regenerate test cases that use <input type=button>.
      
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      Mark tests for rebaselining.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e293e4a4
  18. 25 Feb, 2013 1 commit
    • eric@webkit.org's avatar
      Move html5lib/run-test* into html5lib/generated in preparation for generating these harnesses · 6a10d373
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110795
      
      Reviewed by Ojan Vafai.
      
      * html5lib/generated/run-template-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-template.html: Added.
      * html5lib/generated/run-tests1-expected.txt: Renamed from LayoutTests/html5lib/run-test7-expected.txt.
      * html5lib/generated/run-tests1.html: Added.
      * html5lib/generated/run-tests10-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests10.html: Added.
      * html5lib/generated/run-tests11-expected.txt: Renamed from LayoutTests/html5lib/run-test11-expected.txt.
      * html5lib/generated/run-tests11.html: Added.
      * html5lib/generated/run-tests12-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests12.html: Added.
      * html5lib/generated/run-tests14-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests14.html: Added.
      * html5lib/generated/run-tests15-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests15.html: Added.
      * html5lib/generated/run-tests16-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests16.html: Added.
      * html5lib/generated/run-tests17-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests17.html: Added.
      * html5lib/generated/run-tests18-expected.txt: Renamed from LayoutTests/html5lib/run-test18-expected.txt.
      * html5lib/generated/run-tests18.html: Added.
      * html5lib/generated/run-tests19-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests19.html: Added.
      * html5lib/generated/run-tests2-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests2.html: Added.
      * html5lib/generated/run-tests20-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests20.html: Added.
      * html5lib/generated/run-tests21-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests21.html: Added.
      * html5lib/generated/run-tests22-expected.txt: Renamed from LayoutTests/html5lib/run-test10-expected.txt.
      * html5lib/generated/run-tests22.html: Added.
      * html5lib/generated/run-tests23-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests23.html: Added.
      * html5lib/generated/run-tests24-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests24.html: Added.
      * html5lib/generated/run-tests25-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests25.html: Added.
      * html5lib/generated/run-tests26-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests26.html: Added.
      * html5lib/generated/run-tests3-expected.txt: Renamed from LayoutTests/html5lib/run-test14-expected.txt.
      * html5lib/generated/run-tests3.html: Added.
      * html5lib/generated/run-tests4-expected.txt: Renamed from LayoutTests/html5lib/run-test12-expected.txt.
      * html5lib/generated/run-tests4.html: Added.
      * html5lib/generated/run-tests5-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests5.html: Added.
      * html5lib/generated/run-tests6-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests6.html: Added.
      * html5lib/generated/run-tests7-expected.txt: Renamed from LayoutTests/html5lib/run-test1-expected.txt.
      * html5lib/generated/run-tests7.html: Added.
      * html5lib/generated/run-tests8-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests8.html: Added.
      * html5lib/generated/run-tests9-expected.txt: Renamed from LayoutTests/html5lib/run-template-expected.txt.
      * html5lib/generated/run-tests9.html: Added.
      * html5lib/run-template.html: Removed.
      * html5lib/run-test1.html: Removed.
      * html5lib/run-test10.html: Removed.
      * html5lib/run-test11.html: Removed.
      * html5lib/run-test12.html: Removed.
      * html5lib/run-test14.html: Removed.
      * html5lib/run-test15-expected.txt: Removed.
      * html5lib/run-test15.html: Removed.
      * html5lib/run-test16-expected.txt: Removed.
      * html5lib/run-test16.html: Removed.
      * html5lib/run-test17-expected.txt: Removed.
      * html5lib/run-test17.html: Removed.
      * html5lib/run-test18.html: Removed.
      * html5lib/run-test19-expected.txt: Removed.
      * html5lib/run-test19.html: Removed.
      * html5lib/run-test2-expected.txt: Removed.
      * html5lib/run-test2.html: Removed.
      * html5lib/run-test20-expected.txt: Removed.
      * html5lib/run-test20.html: Removed.
      * html5lib/run-test21-expected.txt: Removed.
      * html5lib/run-test21.html: Removed.
      * html5lib/run-test22-expected.txt: Removed.
      * html5lib/run-test22.html: Removed.
      * html5lib/run-test23-expected.txt: Removed.
      * html5lib/run-test23.html: Removed.
      * html5lib/run-test24-expected.txt: Removed.
      * html5lib/run-test24.html: Removed.
      * html5lib/run-test25-expected.txt: Removed.
      * html5lib/run-test25.html: Removed.
      * html5lib/run-test26-expected.txt: Removed.
      * html5lib/run-test26.html: Removed.
      * html5lib/run-test3-expected.txt: Removed.
      * html5lib/run-test3.html: Removed.
      * html5lib/run-test4-expected.txt: Removed.
      * html5lib/run-test4.html: Removed.
      * html5lib/run-test5-expected.txt: Removed.
      * html5lib/run-test5.html: Removed.
      * html5lib/run-test6-expected.txt: Removed.
      * html5lib/run-test6.html: Removed.
      * html5lib/run-test7.html: Removed.
      * html5lib/run-test8-expected.txt: Removed.
      * html5lib/run-test8.html: Removed.
      * html5lib/run-test9-expected.txt: Removed.
      * html5lib/run-test9.html: Removed.
      * platform/chromium/TestExpectations:
      * platform/chromium/html5lib/generated/run-tests1-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test7-expected.txt.
      * platform/chromium/html5lib/generated/run-tests18-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test18-expected.txt.
      * platform/chromium/html5lib/generated/run-tests7-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test1-expected.txt.
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a10d373
  19. 21 Feb, 2013 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r143419. · 9a1dc733
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/143419
      https://bugs.webkit.org/show_bug.cgi?id=110507
      
      Broke border-image on Mac (Requested by jpfau on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21
      
      Source/WebCore:
      
      * platform/graphics/GraphicsContext.cpp:
      (WebCore::GraphicsContext::drawTiledImage):
      * platform/graphics/GraphicsContext.h:
      (GraphicsContext):
      * platform/graphics/Image.cpp:
      (WebCore::Image::drawTiled):
      * platform/graphics/Image.h:
      (Image):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintNinePieceImage):
      
      LayoutTests:
      
      * fast/borders/border-image-02.html: Removed.
      * platform/chromium-linux/fast/borders/border-image-02-expected.png: Removed.
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/borders/border-image-02-expected.txt: Removed.
      * platform/efl/TestExpectations:
      * platform/gtk/fast/borders/border-image-02-expected.png: Removed.
      * platform/gtk/fast/borders/border-image-02-expected.txt: Removed.
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a1dc733
    • commit-queue@webkit.org's avatar
      Convert buttons from DeprecatedFlexBox to nondeprecated FlexibleBox · e7c35fc5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109994
      
      Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-21
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Covered by existing tests for <button> and <input
      type="button|submit|reset">
      
      * css/html.css:
      (input[type="button"], input[type="submit"], input[type="reset"], input[type="file"]::-webkit-file-upload-button, button):
      Convert from box-align to align-items. We are using flex-start here in
      conjunction with an auto margin for correct centering. See
      RenderButton.cpp below for the margin & more explanation.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
      Add a case for creating a non-deprecated flex box.
      
      * rendering/RenderButton.cpp:
      (WebCore::RenderButton::RenderButton):
      (WebCore::RenderButton::addChild):
      (WebCore::RenderButton::removeChild):
      Forward to new base class
      (WebCore::RenderButton::styleWillChange):
      (WebCore::RenderButton::setupInnerStyle):
      We are now using flexbox properties.
      - min-width is needed for correct shrinking of the contents
      - margin-top and margin-bottom are used for correct centering. We
      can't use align-items: center because results are incorrect when the
      content overflows. See LayoutTests/fast/forms/control-clip.html
      
      * rendering/RenderButton.h:
      Inherit from RenderFlexibleBox
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::createAnonymous):
      (WebCore):
      * rendering/RenderFlexibleBox.h:
      (RenderFlexibleBox):
      Add a createAnonymous function to RenderFlexibleBox.
      
      LayoutTests:
      
      * fast/flexbox/box-orient-button.html: Change -webkit-box to
      -webkit-flex, and related changes.
      * fast/flexbox/resources/box-orient-button.js:
      (setFlexDirection): webkitBoxOrient -> webkitFlexDirection
      
      * fast/replaced/table-percent-height.html: Give a value to the
      <input type="button"> so that the layout doesn't change. No need to
      change expectations because this test uses dumpAsText() and just
      compares one button's height to another.
      
      * http/tests/security/isolatedWorld/userGestureEvents.html: Add text
      to the button so that sending the click event doesn't miss the
      now-smaller button.
      * http/tests/security/isolatedWorld/userGestureEvents-expected.txt:
      Add that text to the expectation too.
      
      * fast/forms/button-generated-content-expected.txt:
      * platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.png:
      * platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.txt:
      * platform/chromium-linux/fast/forms/button-generated-content-expected.png:
      * platform/chromium-linux/fast/forms/button-generated-content-expected.txt:
      * platform/chromium-linux/fast/forms/select-baseline-expected.png:
      * platform/chromium-linux/fast/forms/select-baseline-expected.txt:
      * platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
      * platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt:
      * platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
      * platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.txt:
      * platform/mac/css2.1/20110323/replaced-elements-001-expected.txt:
      * platform/mac/fast/forms/select-baseline-expected.txt:
      * platform/mac/svg/custom/foreign-object-skew-expected.txt:
      Rebaseline. Most changes come from the fact that an empty button now
      consistently has a small height, when previously it would sometimes
      have the height of the line. See this testcase:
      https://bugs.webkit.org/attachment.cgi?id=188679
      The new behavior is consistent with Firefox.
      
      The only other difference is fast/forms/button-generated-content.html:
      The empty buttons are now aligned on the baseline instead of being
      vertically centered in the line. This is consistent with Firefox.
      
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      Mark tests for rebaselining.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7c35fc5
  20. 19 Feb, 2013 1 commit
    • commit-queue@webkit.org's avatar
      'round' not implemented in border-image · 3a1d402a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=14185
      
      Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-19
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Add rendering support for 'round' keyword of border-image-repeat CSS property
      http://dev.w3.org/csswg/css3-background/#border-image-repeat
      Rebased original patch by Benjamin Otte <otte@gnome.org> and made few fixes.
      
      Test: fast/borders/border-image-02.html
      
      * platform/graphics/GraphicsContext.cpp:
      (WebCore::GraphicsContext::drawTiledImage):
      * platform/graphics/GraphicsContext.h:
      (GraphicsContext):
      * platform/graphics/Image.cpp:
      (WebCore::Image::drawTiled):
      * platform/graphics/Image.h:
      (Image):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintNinePieceImage): For 'round' keyword,
      the image is tiled (repeated) to fill the area. If it does not fill the area
      with a whole number of tiles, the image is rescaled so that it does.
      
      LayoutTests:
      
      Added test for 'round' keyword of border-image-repeat CSS property
      http://dev.w3.org/csswg/css3-background/#border-image-repeat
      
      * fast/borders/border-image-02.html: Added.
      * platform/chromium-linux/fast/borders/border-image-02-expected.png: Added.
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/borders/border-image-02-expected.txt: Added.
      * platform/efl/TestExpectations:
      * platform/gtk/fast/borders/border-image-02-expected.png: Added.
      * platform/gtk/fast/borders/border-image-02-expected.txt: Added.
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a1d402a