1. 27 Mar, 2013 2 commits
    • eric.carlson@apple.com's avatar
      [Mac] webkitClosedCaptionsVisible doesn't work · 92907e15
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113417
      
      Reviewed by Jer Noble.
      
      Source/WebCore: 
      
      Test: media/track/track-in-band-legacy-api.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement): Delete m_disableCaptions, it is no longer used.
      (WebCore::HTMLMediaElement::configureTextTrackGroup): Pass this to textTrackSelectionScore.
      (WebCore::HTMLMediaElement::setClosedCaptionsVisible):  Delete m_disableCaptions, it is no longer used.
      * html/HTMLMediaElement.h: Ditto.
      
      * page/CaptionUserPreferences.cpp:
      (WebCore::CaptionUserPreferences::textTrackSelectionScore): Add an HTMLMediaElement parameter.
      * page/CaptionUserPreferences.h:
      
      * page/CaptionUserPreferencesMac.h:
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Return a score if the media element
          is showing captions, even if the preference says captions are disabled.
      
      LayoutTests: 
      
      * media/track/track-in-band-legacy-api-expected.txt: Added.
      * media/track/track-in-band-legacy-api.html: Added.
      
      * platform/chromium/TestExpectations: Skip new test.
      * platform/efl/TestExpectations: Ditto.
      * platform/gtk/TestExpectations: Ditto.
      * platform/mac/TestExpectations: Ditto.
      * platform/qt/TestExpectations: Ditto.
      * platform/win/TestExpectations: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92907e15
    • cfleizach@apple.com's avatar
      Regression in tests due to https://bugs.webkit.org/show_bug.cgi?id=113339 · ae539ad0
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113361
      
      Source/WebCore: 
      
      Fix the red bots. No review.
      
      Ensure only pop-up buttons get the AXRequired attribute instead of all buttons.        
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
      
      LayoutTests: 
      
      Remove skipped tests.
      
      * platform/mac/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae539ad0
  2. 26 Mar, 2013 2 commits
  3. 25 Mar, 2013 3 commits
    • eric.carlson@apple.com's avatar
      REGRESSION(r146380): media/track/track-user-preferences.html · 7bbf6ab9
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113083
      
      Reviewed by Jer Noble.
      
      Source/WebCore: 
      
      Ignore track change notifications triggered by automatic track selection so the 
      configuration is not changed.
      
      No new tests, this fixes an existing test.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::configureTextTrackGroup): Clear m_processingPreferenceChange after all
          track configuration is finished.
      (WebCore::HTMLMediaElement::configureTextTrackDisplay): Do nothing if m_processingPreferenceChange
          is true.
      
      LayoutTests: 
      
      * platform/mac/TestExpectations: Remove test from expectations.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bbf6ab9
    • rniwa@webkit.org's avatar
      Mac rebaselines after r146779. Also add failing expectations for 4 transition tests per bug 113223. · 20d54a7b
      rniwa@webkit.org authored
      * platform/mac/TestExpectations:
      * platform/mac/css3/filters/effect-reference-expected.png:
      * platform/mac/css3/filters/effect-reference-expected.txt:
      * platform/mac/css3/filters/effect-reference-hw-expected.png:
      * platform/mac/css3/filters/effect-reference-hw-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20d54a7b
    • alecflett@chromium.org's avatar
      Support Quota API in Workers · b72a039b
      alecflett@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112972
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Tests: fast/workers/shared-worker-storagequota-query-usage.html
             fast/workers/worker-storagequota-query-usage.html
      
      * Modules/quota/WorkerNavigatorStorageQuota.cpp: Added.
      * Modules/quota/WorkerNavigatorStorageQuota.h: Added.
      * Modules/quota/WorkerNavigatorStorageQuota.idl: Added.
      * WebCore.gypi: Add entries for WorkerNavigatorStorageQuota.
      * page/WorkerNavigator.h: Add a Navigator supplement that extends the worker navigator.
      
      LayoutTests:
      
      * fast/workers/resources/shared-worker-common.js:
      (handleMessage): Allow port to be dynamically discovered from self.
      * fast/workers/resources/storagequota-query-usage.js: Added.
      (worker.onmessage):
      * fast/workers/resources/worker-storagequota-query-usage.js: Added.
      (requestUsage.errorCallback):
      (requestUsage.usageCallback):
      (requestUsage):
      * fast/workers/shared-worker-storagequota-query-usage-expected.txt: Added.
      * fast/workers/shared-worker-storagequota-query-usage.html: Added.
      * fast/workers/worker-storagequota-query-usage-expected.txt: Added.
      * fast/workers/worker-storagequota-query-usage.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b72a039b
  4. 22 Mar, 2013 3 commits
  5. 21 Mar, 2013 1 commit
    • rniwa@webkit.org's avatar
      [Mac] Add baselines for css3/filters/effect-reference*.html · 6e016da1
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112962
      
      Reviewed by Dean Jackson.
      
      Add Mac rebaselines for the following tests and removed the corresponding entries in TestExpectations.
      
      * platform/mac/TestExpectations:
      * platform/mac/css3/filters/effect-reference-expected.png: Added.
      * platform/mac/css3/filters/effect-reference-expected.txt:
      * platform/mac/css3/filters/effect-reference-external-expected.png: Added.
      * platform/mac/css3/filters/effect-reference-hw-expected.png: Added.
      * platform/mac/css3/filters/effect-reference-hw-expected.txt:
      * platform/mac/css3/filters/effect-reference-ordering-expected.png: Added.
      * platform/mac/css3/filters/effect-reference-ordering-hw-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e016da1
  6. 20 Mar, 2013 14 commits
  7. 19 Mar, 2013 6 commits
    • ojan@chromium.org's avatar
      Rebaselines after r146272. · 5dba918f
      ojan@chromium.org authored
      * platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png:
      * platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
      * platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
      * platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
      * platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dba918f
    • ojan@chromium.org's avatar
      Make intrinsic size keywords on flexboxes work · 2087f498
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112652
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Tests: fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items.html
             fast/css-intrinsic-dimensions/intrinsic-sized-flex-items.html
      
      * platform/Length.h:
      (WebCore::Length::isSpecifiedOrIntrinsic):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax):
      (WebCore::RenderBox::computeLogicalWidthInRegion):
      (WebCore::RenderBox::computeLogicalWidthInRegionUsing):
      Pass in the Length so that RenderFlexibleBox can call this method and avoid
      doing a bunch of code duplication.
      
      * rendering/RenderBox.h:
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
      Instead of just calling valueForLength, call computeLogicalWidthInRegionUsing so that
      we properly resolve intrinsic Length types. Incidentally, this should also make viewport
      percentage units work.
      
      (WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
      Resolve intrinsic min/max Lengths. Also, instead of calling minPreferredLogicalWidth for the
      min-width: auto case, call computeMainAxisExtentForChild to correctly compute the min intrinsic size.
      
      LayoutTests:
      
      * fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items-expected.txt: Added.
      * fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items.html: Added.
      * fast/css-intrinsic-dimensions/intrinsic-sized-flex-items-expected.txt: Added.
      * fast/css-intrinsic-dimensions/intrinsic-sized-flex-items.html: Added.
      * platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
      * platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt:
      This looks like a rounding difference. The new result matches the non-column result
      in this same test, so it looks more correct to me.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2087f498
    • dino@apple.com's avatar
      Source/WebCore: Allow PlugIn Snapshotting to be tested · 0743e1e4
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98696
      
      Reviewed by Tim Horton.
      
      Expose a new setting maximumPlugInSnapshotAttempts that can
      be set by testing scripts.
      
      Tests: plugins/snapshotting/restart.html
             plugins/snapshotting/simple.html
      
      * page/Settings.in:
      
      Source/WebKit2: Allow PlugIn Snapshotting to be tested
      https://bugs.webkit.org/show_bug.cgi?id=98696
      
      Reviewed by Tim Horton.
      
      Use the new maximumPlugInSnapshotAttempts setting rather than a hardcoded
      value. At the same time, if this value is 0, then snapshot immediately
      (don't wait to get a snapshot and test it).
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::didInitializePlugin): Snapshot immediately if maximum attempts are 0.
      (WebKit::PluginView::pluginSnapshotTimerFired): Use setting rather than file local variable.
      
      LayoutTests: Allow PlugIn Snapshotting to be tested
      https://bugs.webkit.org/show_bug.cgi?id=98696
      <rdar://problem/12456731>
      
      Reviewed by Tim Horton.
      
      Two new simple tests for plugin snapshotting. One that makes
      sure the plugin was snapshotted (looks for the RenderSnapshottedPlugin)
      and one that restarts a snapshotted plugin by clicking.
      
      Since this feature is currently only enabled in WebKit2, the tests
      are skipped everywhere else.
      
      * platform/chromium/TestExpectations: Skip plugins/snapshotting.
      * platform/efl/TestExpectations: Ditto.
      * platform/gtk/TestExpectations: Ditto.
      * platform/mac-wk2/TestExpectations: Ditto.
      * platform/mac-wk2/plugins/snapshotting/restart-expected.txt: Added.
      * platform/mac-wk2/plugins/snapshotting/simple-expected.txt: Added.
      * platform/mac/TestExpectations: Skip plugins/snapshotting.
      * platform/qt/TestExpectations: Ditto.
      * platform/win/TestExpectations: Ditto.
      * plugins/snapshotting/restart.html: Added.
      * plugins/snapshotting/simple.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0743e1e4
    • simon.fraser@apple.com's avatar
      Assertion in LegacyWebArchive::create() in editing tests · 2e8c7d5f
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112642
      
      editing/pasteboard/5780697-1.html is also a flakey assertion.
      
      Move to mac-wk2 beacuse these only seem to happen in WK2.
      
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e8c7d5f
    • simon.fraser@apple.com's avatar
      [Mac] Flaky crash in SliderThumbElement::defaultEventHandler on... · 845ca10e
      simon.fraser@apple.com authored
      [Mac] Flaky crash in SliderThumbElement::defaultEventHandler on fast/forms/range/slider-delete-while-dragging-thumb.html
      https://bugs.webkit.org/show_bug.cgi?id=108223
      
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      845ca10e
    • levin@chromium.org's avatar
      Change icon-url-property test for platforms which don't support dumpIconChanges. · efaed87d
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112660
      
      Reviewed by Simon Fraser.
      
      Add the baseline for mac and remove the test failure.
      
      * fast/dom/icon-url-property.html:
      * platform/mac/TestExpectations:
      * platform/mac/fast/dom/icon-url-property-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efaed87d
  8. 18 Mar, 2013 9 commits