- 11 May, 2011 40 commits
-
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. Handle case when GrContext creation fails https://bugs.webkit.org/show_bug.cgi?id=60410 Exercised by all canvas tests when DRT is run with skia-gpu * platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::grContext): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
psolanki@apple.com authored
Reviewed by Andreas Kling. Remove empty class CallbackGuard https://bugs.webkit.org/show_bug.cgi?id=60610 CallbackGuard was only ever used on Tiger and it is now an empty class. Remove all uses of it. * platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. Implement CSSPropertyMargin and CSSPropertyPadding in CSSStyleApplyProperty. https://bugs.webkit.org/show_bug.cgi?id=60609 No new tests - refactoring only. * css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Initialise CSSPropertyMargin and CSSPropertyPadding handlers. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove unused implementations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Kent Tamura. Some elements in meter-styles.html are hiding its content part with non-content-area. https://bugs.webkit.org/show_bug.cgi?id=58149 - Resized the border and padding values - Gave "-webkit-appearance: none" to test that is intended to be painted using shadows. * fast/dom/HTMLMeterElement/meter-styles.html: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kevino@webkit.org authored
[wx] Implement more clipping functions for wxWebKit. https://bugs.webkit.org/show_bug.cgi?id=60662 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Brady Eidson. Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history https://bugs.webkit.org/show_bug.cgi?id=60674 * WebCore.exp.in: Export restoreScrollPositionAndViewState() 2011-05-11 Damian Kaleta <dkaleta@apple.com> Reviewed by Brady Eidson. Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history https://bugs.webkit.org/show_bug.cgi?id=60674 * UIProcess/API/C/WKPage.cpp: (WKPageTryRestoreScrollPosition): * UIProcess/API/C/WKPage.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::tryRestoreScrollPosition): * UIProcess/WebPageProxy.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryRestoreScrollPosition): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. WebKit does not build with GCCE https://bugs.webkit.org/show_bug.cgi?id=60667 Allow compile WebKit with GCCE * wtf/Alignment.h: * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leviw@chromium.org authored
Reviewed by Eric Seidel. Switch paintFillLayer and its progeny to use IntRect instead of four ints https://bugs.webkit.org/show_bug.cgi?id=60596 Changing integers passed into paintFillLayer and other derivatives to IntRects and IntSizes that reflect their function. No new tests since this is just refactoring. * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask): * rendering/InlineFlowBox.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxFillLayers): (WebCore::RenderBox::paintBoxDecorationsWithSize): (WebCore::RenderBox::paintMaskImages): (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer): * rendering/RenderBox.h: * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): * rendering/RenderBoxModelObject.h: * rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): * rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Eric Seidel. Enable strict PassOwnPtr on Mac https://bugs.webkit.org/show_bug.cgi?id=60684 This should build cleanly now. * wtf/PassOwnPtr.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by James Robinson. [chromium] Use mapTexSubImage2D for tile uploads if available https://bugs.webkit.org/show_bug.cgi?id=60008 * platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels): * platform/graphics/chromium/LayerTilerChromium.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Darin Adler. Protect JSC from WebCore executing JS during JS wrapper finalization https://bugs.webkit.org/show_bug.cgi?id=60672 <rdar://problem/9350997> Detect when we're trying to execute JS during GC and prevent the execution from happening. We also assert that this isn't happening as it implies incorrect behaviour of an object's destructor. * JavaScriptCore.exp: * heap/Heap.cpp: * heap/Heap.h: (JSC::Heap::isBusy): * interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): * runtime/JSGlobalData.h: (JSC::JSGlobalData::isCollectorBusy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alexis.menard@openbossa.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Implements a disable appearance for Media Elements of Qt port. https://bugs.webkit.org/show_bug.cgi?id=60561 Implements a disable appearance for the media controls of the Qt port when the media is not yet available. * platform/qt/RenderThemeQt.cpp: (WebCore::mediaElementCanPlay): (WebCore::RenderThemeQt::getMediaControlForegroundColor): (WebCore::RenderThemeQt::paintMediaSliderThumb): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Reviewed by Dimitri Glazkov. input type=email is too strict https://bugs.webkit.org/show_bug.cgi?id=55988 * fast/forms/resources/ValidityState-typeMismatch-email.js: * fast/forms/ValidityState-typeMismatch-email-expected.txt: 2011-05-11 Kent Tamura <tkent@chromium.org> Reviewed by Dimitri Glazkov. input type=email is too strict https://bugs.webkit.org/show_bug.cgi?id=55988 Follow the updated specification. * html/EmailInputType.cpp: Update the pattern to allow a domain part without periods. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cdn@chromium.org authored
Reviewed by David Levin. Adding Cris Neckar to the Webkit Security Group site. https://bugs.webkit.org/show_bug.cgi?id=60668 * security/security-group-members.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Reviewed by Gavin Barraclough. WebKit2 doesn't build on Mac with strict PassOwnPtr https://bugs.webkit.org/show_bug.cgi?id=60655 * Platform/CoreIPC/HandleMessage.h: (CoreIPC::handleMessageDelayed): Add explicit adoptPtr to indicate that the constructor is taking ownership. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jpu@apple.com authored
Reviewed by Darin Adler. Autocorrection persists after deleting and retyping the same word at same location. https://bugs.webkit.org/show_bug.cgi?id=60555 <rdar://problem/9373915> See WebCore/ChangeLog for detail. * platform/mac-leopard/Skipped: * platform/mac-snowleopard/Skipped: * platform/mac/editing/spelling/delete-autocorrected-word-2-expected.png: Added. * platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt: Added. * platform/mac/editing/spelling/delete-autocorrected-word-2.html: Added. 2011-05-11 Jia Pu <jpu@apple.com> Reviewed by Darin Adler. Autocorrection persists after deleting and retyping the same word at same location. https://bugs.webkit.org/show_bug.cgi?id=60555 <rdar://problem/9373915> This patch intends to alleviate the issue of repetitively applying the same autocorrection when user delete and retype the same word at the same location. This scenario is especially common when autocorrection modifies the first letter of the word. This patch consists following major changes: 1. Added a new marker type, DeletedAutocorrection. This marker is added to the whitespace that precedes a deleted autocorrection. If the user later types the same original word at after this whitespace, the autocorrection will not be applied again. 2. In DeleteSelectionCommand, added code to notify SpellingCorrectionController about the autocorrection that has just been deleted. 3. In Editor and SpellingCorrectionController, added code to apply the marker and to suppress autocorrection when necessary. 4. The change in CompositeEditCommand::replaceTextInNode is necessary for preserving markers. Otherwise, we will loose the DeletedAutocorrection on the whitespace, when inserting text after the whitespace. Test: platform/mac/editing/spelling/delete-autocorrected-word-2.html * dom/DocumentMarker.h: Added new marker type DeletedAutocorrection. (WebCore::DocumentMarker::AllMarkers::AllMarkers): * dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::markersInRange): Support querying multiple marker types. * dom/DocumentMarkerController.h: * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodeAndPreserveMarkers): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): * editing/CompositeEditCommand.h: * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): (WebCore::DeleteSelectionCommand::fixupWhitespace): (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection): Extracting the original string if we are deleting an autocorrection. (WebCore::DeleteSelectionCommand::doApply): Notify editor about the deleted autocorrection and its position. * editing/DeleteSelectionCommand.h: * editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Moved all logic of determining when to suppress an autocorrection into SpellingCorrectionController. (WebCore::Editor::deletedAutocorrectionAtPosition): * editing/Editor.h: * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): * editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToAppliedEditing): (WebCore::SpellingCorrectionController::deletedAutocorrectionAtPosition): (WebCore::SpellingCorrectionController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult): * editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::UNLESS_ENABLED): * editing/visible_units.cpp: (WebCore::isStartOfWord): * editing/visible_units.h: * manual-tests/autocorrection/spell-checking-after-reversion.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Gavin Barraclough. Enable gc mark validation in temporarily in release builds https://bugs.webkit.org/show_bug.cgi?id=60678 Make it easier to turn the gc mark validation on and off, and temporarily turn it on for all builds. * heap/MarkStack.cpp: * heap/MarkStack.h: (JSC::MarkStack::append): (JSC::MarkStack::internalAppend): * runtime/WriteBarrier.h: (JSC::MarkStack::appendValues): * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/9414874mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=60677 Reviewed by Darin Adler. * platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars): Only perform an immediate scroll, aborting any running animation, if the new scroll offset computed here is different from the current scroll offset. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Reviewed by Dimitri Glazkov. <input pattern="1|10" value="10"> doesn't work correctly. https://bugs.webkit.org/show_bug.cgi?id=60619 Add test cases and update the result. * fast/forms/ValidityState-patternMismatch-expected.txt: * fast/forms/ValidityState-patternMismatch.html: 2011-05-11 Kent Tamura <tkent@chromium.org> Reviewed by Dimitri Glazkov. <input pattern="1|10" value="10"> doesn't work correctly. https://bugs.webkit.org/show_bug.cgi?id=60619 Fixes a bug that patternMismatch returns a wrong result if - a whole value matches to a pattern, - a sub-string of the value also matches to the pattern, and - the sub-string matching has priority. * html/BaseTextInputType.cpp: (WebCore::BaseTextInputType::patternMismatch): Enclose the specified pattern with ^( and )$. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by David Levin. Prevented DOMFileSystemBase from imposing file naming restrictions on external file systems. https://bugs.webkit.org/show_bug.cgi?id=60583 There are no new tests for this change since it requires the presence of external file system provider which is specific to the platform host process. Chromium implementation will test this within its extension API test suite. * fileapi/DOMFileSystemBase.cpp: (WebCore::pathToAbsolutePath): (WebCore::DOMFileSystemBase::getFile): (WebCore::DOMFileSystemBase::getDirectory): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by David Levin. Expose shouldBufferData to ThreadableLoaderOptions to be able to disable buffering of the loaded resource. https://bugs.webkit.org/show_bug.cgi?id=60656 * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest): Pass the shouldBufferData to the resource load scheduler, forcing it to true for the preflight request. * loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Pass through shouldBufferData to SubresourceLoader::create * loader/ResourceLoadScheduler.h: * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Set shouldBufferData on the newly created loader * loader/SubresourceLoader.h: * loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Add shouldBufferData to the options, defaulting to true. 2011-05-11 Antoine Labour <piman@chromium.org> Reviewed by David Levin. Don't buffer data for resources loaded by AssociatedURLLoader. https://bugs.webkit.org/show_bug.cgi?id=60656 * src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::loadAsynchronously): set shouldBufferData to false in ThreadableLoaderOptions git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jcivelli@chromium.org authored
Reviewed by Adam Barth. Adding a Content-Type parser. This is needed for MHTML support. https://bugs.webkit.org/show_bug.cgi?id=60637 (WebCore::ScriptController::disableEval): * platform/network/ContentTypeParser.cpp: Added. * platform/network/ContentTypeParser.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by David Levin. Teach validate-committer-lists how to validate committers bugzilla_email() https://bugs.webkit.org/show_bug.cgi?id=60651 It turns out we currently have 9 committers with invalid values for their bugzilla_email field (meaning we don't know what email is their bugzilla account). "Alexander Kellett" <lypanov@mac.com> "Andre Boule" <aboule@apple.com> "Cameron McCormack" <cam@webkit.org> "Chris Petersen" <cpetersen@apple.com> "Eli Fidler" <eli@staikos.net> "Matt Lilek" <webkit@mattlilek.com> "Pierre d'Herbemont" <pdherbemont@free.fr> "Scott Violet" <sky@chromium.org> "Adam Treat" <treat@kde.org> Most of those haven't committed in a very long time, so it's not suprising that we haven't noticed that their bugzilla emails are bogus. * Scripts/validate-committer-lists: * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
Switch TestWebKitAPI to GTest Patch by Dmitry Lomov <dslomov@google.com> on 2011-05-11 Reviewed by David Levin. Fixes Makefiles and WinCairo build as well .: * Source/ThirdParty/gtest/README.WebKit: * Source/ThirdParty/gtest/msvc/gtest-md.vcproj: * Source/ThirdParty/gtest/xcode/Config/General.xcconfig: * Source/ThirdParty/gtest/xcode/Makefile: Added. Source/WebKit/win: * WebKit.vcproj/WebKit.sln: Tools: * Makefile: * Scripts/build-api-tests: * Scripts/run-api-tests: * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: * TestWebKitAPI/Test.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::dumpTestNames): (TestWebKitAPI::TestsController::runTestNamed): (TestWebKitAPI::TestsController::runAllTests): * TestWebKitAPI/TestsController.h: * TestWebKitAPI/mac/main.mm: (main): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ademar.reis@openbossa.org authored
Reviewed by Mark Rowe. Update Qt/Nokia Security contacts https://bugs.webkit.org/show_bug.cgi?id=60650 Ademar (me) replaced Simon as the release manager and primary security contact for QtWebKit. See: http://lists.webkit.org/mailman/private.cgi/webkit-security/2011-February/000584.html * security/security-group-members.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=60274 Reviewed by Steve Falkenburg. Source/WebCore: Share the default storage session between the UI and Web Processes. * platform/network/cf/CookieStorageCFNet.cpp: (WebCore::defaultSessionCookieStorage): Keep track of the default storage session cookie storage. (WebCore::currentCookieStorage): Call defaultCookieStorage to get the default cookie storage. (WebCore::defaultCookieStorage): If there is a default storage session cookie storage, prefer that over getting the default cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly without specifying a storage session will not get the cookie storage being shared by the UI and Web Processes. * platform/network/ResourceHandle.h: * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Make sure to set the current storage session on any requests used by the Web Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid doing anything with the Web Process's default storage session (which is not the one shared with the UI Process). (WebCore::makeFinalRequest): Ditto. (WebCore::ResourceHandle::willSendRequest): Ditto. (WebCore::ResourceHandle::currentStorageSession): If there is a Private Browsing storage session, return that. If not, on Windows return the default storage session that is being shared with the UI Process and on Mac return 0. (WebCore::defaultCFURLStorageSession): (WebCore::ResourceHandle::setDefaultStorageSession): (WebCore::ResourceHandle::defaultStorageSession): * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Make sure to set the current storage session on any requests used by the Web Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid doing anything with the Web Process's default storage session (which is not the one shared with the UI Process). Source/WebKit/win: * WebView.cpp: (WebView::setCacheModel): Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session. Source/WebKit2: Share the default storage session between the UI and Web Processes. * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): Only encode the session parameter if it is valid. (WebKit::WebProcessCreationParameters::decode): Don't try to decode a null session data. * Shared/WebProcessCreationParameters.h: Add a parameter for a serialized default storage session, used only on Windows. * Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::decodeResourceRequest): Make sure to set the current storage session on any requests used by the Web Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid doing anything with the Web Process's default storage session. * UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess): Serialize the default storage session in the UI Process and add it to the WebProcessCreationParameters. * WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL): Use the cache associated with the current storage session and make sure the request has the current storage session set on it before doing anything with it. * WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel): Use the default storage session. (WebKit::WebProcess::platformClearResourceCaches): Ditto. (WebKit::WebProcess::platformInitializeWebProcess): Deserialize the default storage session passed in by the UI Process and hand it to the ResourceHandle. WebKitLibraries: Take 3 after rolling out KB2465367 from my system. * win/include/WebKitSystemInterface/WebKitSystemInterface.h: * win/lib/WebKitSystemInterface.lib: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by David Kilzer. Remove wml directory from include lists https://bugs.webkit.org/show_bug.cgi?id=60646 Remove wml dir from CMake, Autotools and qmake build systems since WML was removed in r85256. No new tests since no change in functionality. * CMakeLists.txt: * GNUmakefile.am: * WebCore.pri: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Antonio Gomes. [CMAKE] Move EFL-specific file to CMakeListsEfl.txt https://bugs.webkit.org/show_bug.cgi?id=60642 Move file EFL-specific file to the CMakeListsEfl.txt file. This implies having to include CMakeLists${PORT}.txt before the ADD_CUSTOM_COMMAND calls, since they depend on lists that now may change inside a port like WebCore_USER_AGENT_STYLE_SHEETS. No new tests since no change in functionality. * CMakeLists.txt: remove css file specific to EFL port. * CMakeListsEfl.txt: move file here. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Alexey Proskuryakov. Add Luke Macpherson to committers.py as a Contributor https://bugs.webkit.org/show_bug.cgi?id=60639 * Scripts/webkitpy/common/config/committers.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jpu@apple.com authored
Reviewed by Darin Adler. CorrectionPanel sometimes hangs in dismissSoon(). https://bugs.webkit.org/show_bug.cgi?id=60599 <rdar://problem/9313628> Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal, for condition checking. * WebCoreSupport/CorrectionPanel.h: * WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::CorrectionPanel): (CorrectionPanel::show): (CorrectionPanel::dismissSoon): (CorrectionPanel::dismissInternal): (CorrectionPanel::handleAcceptedReplacement): 2011-05-11 Jia Pu <jpu@apple.com> Reviewed by Darin Adler. CorrectionPanel sometimes hangs in dismissSoon(). https://bugs.webkit.org/show_bug.cgi?id=60599 <rdar://problem/9313628> Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal, for condition checking. * UIProcess/mac/CorrectionPanel.h: * UIProcess/mac/CorrectionPanel.mm: (WebKit::CorrectionPanel::CorrectionPanel): (WebKit::CorrectionPanel::show): (WebKit::CorrectionPanel::dismissSoon): (WebKit::CorrectionPanel::dismissInternal): (WebKit::CorrectionPanel::handleAcceptedReplacement): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
inferno@chromium.org authored
Unreviewed. More rebaselines after r86261. * platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added. * platform/chromium-mac-leopard/fast/forms/slider-padding-expected.png: Added. * platform/chromium-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png: * platform/chromium-mac-leopard/fast/repaint/slider-thumb-drag-release-expected.png: * platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: * platform/chromium-mac/fast/forms/slider-padding-expected.png: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by David Kilzer. Return empty Favicon URL instead of default one when the frame isn't top level one https://bugs.webkit.org/show_bug.cgi?id=60527 This issue was discovered by chromium browser test. * dom/Document.cpp: (WebCore::Document::setIconURL): Restored original logic which was inadvertently flipped by http://trac.webkit.org/changeset/85785. * loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURLs): (WebCore::FrameLoader::fillIconURL): Restored original logic, the empty URL should be returned instead of default one. The client (at least chromium) may rely on the returned value to decided whether the favicon should be changed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Russell. [chromium] Make throttling of WebGL based on webgl frames, not compositor frames https://bugs.webkit.org/show_bug.cgi?id=60508 When a WebGL layer is dirtied outside of a requestAnimFrame callback, we need to prevent WebGL from running too far ahead of the GPU process. The current throttling mechanism relies on prepareTexture being called for every WebGL frame. However, in a non-requestAnimFrame application, multiple frames might get created before the compositor runs and calls prepareTexture on the surface. To address this, we post a task that calls a special rate limiting GL extension on the WebGL context after every WebGL "frame." When the compositor runs, it calls prepareTexture as usual. * platform/graphics/chromium/Extensions3DChromium.h: * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): * platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::setIsAnimating): (WebCore::LayerRendererChromium::isAnimating): * platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromiumRateLimitTask::WebGLLayerChromiumRateLimitTask): (WebCore::WebGLLayerChromiumRateLimitTask::run): (WebCore::WebGLLayerChromiumRateLimitTask::cancel): (WebCore::WebGLLayerChromium::WebGLLayerChromium): (WebCore::WebGLLayerChromium::~WebGLLayerChromium): (WebCore::WebGLLayerChromium::setTextureUpdated): (WebCore::WebGLLayerChromium::setContext): * platform/graphics/chromium/WebGLLayerChromium.h: (WebCore::WebGLLayerChromium::context): 2011-05-11 Nat Duca <nduca@chromium.org> Reviewed by Kenneth Russell. [chromium] Make throttling of WebGL based on webgl frames, not compositor frames https://bugs.webkit.org/show_bug.cgi?id=60508 Tell LayerRendererChromium when the requestAnimFrame-callbacks are running. * public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::rateLimitOffscreenContextCHROMIUM): * src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM): * src/GraphicsContext3DChromium.cpp: * src/GraphicsContext3DInternal.h: * src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
inferno@chromium.org authored
Unreviewed. Rebaselines after r86261. * platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png: * platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
noam.rosenthal@nokia.com authored
Reviewed by Kenneth Rohde Christiansen. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch https://bugs.webkit.org/show_bug.cgi?id=60439 Patch 10/12: Glue the TextureMapper refactoring into Webkit(1). 1. Pass a GraphicsLayer* instead of a PlatformLayer* to the QWebPageClient. 2. Set parameters in TextureMapper/TextureMapperNode instead of passing them in an options argument. 3. Rename PlatformLayerProxyQt to TextureMapperNodeClient * Api/qwebframe.cpp: (QWebFramePrivate::renderCompositedLayers): * Api/qwebframe.h: * Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate): * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::attachRootGraphicsLayer): * WebCoreSupport/PageClientQt.cpp: (WebCore::TextureMapperNodeClientQt::TextureMapperNodeClientQt): (WebCore::TextureMapperNodeClientQt::scroll): (WebCore::TextureMapperNodeClientQt::setTextureMapper): (WebCore::TextureMapperNodeClientQt::~TextureMapperNodeClientQt): (WebCore::TextureMapperNodeClientQt::computeLastModifiedRect): (WebCore::TextureMapperNodeClientQt::syncRootLayer): (WebCore::TextureMapperNodeClientQt::rootNode): (WebCore::PageClientQWidget::setRootGraphicsLayer): (WebCore::PageClientQWidget::syncLayers): (WebCore::PageClientQWidget::~PageClientQWidget): (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::syncLayers): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer): (WebCore::PageClientQGraphicsWidget::markForSync): * WebCoreSupport/PageClientQt.h: (WebCore::PageClientQWidget::PageClientQWidget): (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::syncLayersTimeout): 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com> Reviewed by Kenneth Rohde Christiansen. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch https://bugs.webkit.org/show_bug.cgi?id=60439 Patch 12/12: Enable accelerated animations in texture-mapper. The entire interpolation mechanism happens inside TextureMapper, and we interpolate right before we paint. No new tests. Tests in LayoutTests/compositing cover this. * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper): (WebCore::GraphicsLayerTextureMapper::syncCompositingState): (WebCore::GraphicsLayerTextureMapper::addAnimation): (WebCore::GraphicsLayerTextureMapper::pauseAnimation): (WebCore::GraphicsLayerTextureMapper::removeAnimation): (WebCore::GraphicsLayerTextureMapper::animationStartedTimerFired): * platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations): (WebCore::normalizedAnimationValue): (WebCore::TextureMapperNode::applyOpacityAnimation): (WebCore::solveEpsilon): (WebCore::solveCubicBezierFunction): (WebCore::solveStepsFunction): (WebCore::applyTimingFunction): (WebCore::TextureMapperNode::applyTransformAnimation): (WebCore::TextureMapperNode::applyAnimationFrame): (WebCore::TextureMapperNode::applyAnimation): (WebCore::TextureMapperNode::hasRunningOpacityAnimation): (WebCore::TextureMapperNode::hasRunningTransformAnimation): (WebCore::TextureMapperNode::syncAnimations): (WebCore::copyTimingFunction): (WebCore::copyAnimationValue): (WebCore::TextureMapperAnimation::TextureMapperAnimation): * platform/graphics/texmap/TextureMapperNode.h: (WebCore::TextureMapperAnimation::create): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Russell. Don't send zeros in TexImage if GL implementation handles that https://bugs.webkit.org/show_bug.cgi?id=60581 Chromium already handles zeroing textures upon creation, so don't bother zeroing them in WebKit, as that causes some unnecessary memcpys of zeros. No new tests as functionality is the same. * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2DBase): * platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe): * platform/graphics/GraphicsContext3D.h: * platform/graphics/gtk/GraphicsContext3DGtk.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): * platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::GraphicsContext3D): * platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): 2011-05-11 John Bauman <jbauman@chromium.org> Reviewed by Kenneth Russell. Don't send zeros in TexImage if GL implementation handles that https://bugs.webkit.org/show_bug.cgi?id=60581 Chromium already handles zeroing textures upon creation, so don't bother zeroing them in WebKit, as that causes some unnecessary memcpys of zeros. * src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::create): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Attempt to fix Chromium Mac build. * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dbates@webkit.org authored
Reviewed by Antonio Gomes. [Qt] Extract code to set mouse event modifiers into common function https://bugs.webkit.org/show_bug.cgi?id=60649 Consolidate code to set the keyboard modifiers for a mouse event into a common function that can be used by both PlatformMouseEvent(QGraphicsSceneMouseEvent*, int clickCount) and PlatformMouseEvent(QInputEvent*, int clickCount) so as to remove duplicate code. No functionality was changed. So, no new tests. * platform/qt/PlatformMouseEventQt.cpp: (WebCore::mouseEventModifiersFromQtKeyboardModifiers): Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent): Modified to call mouseEventModifiersFromQtKeyboardModifiers(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leviw@chromium.org authored
Reviewed by Eric Seidel. Switch RenderBoxModelObject::paintBorder to use IntRect instead of four ints https://bugs.webkit.org/show_bug.cgi?id=60591 Switching RenderBoxModelObject::paintBorder to use IntRect instead of four ints representing a rect. No new tests since there is no functionality change. * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxDecorations): * rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorationsWithSize): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder): * rendering/RenderBoxModelObject.h: * rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): * rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Unreviewed, rolling out r86255. http://trac.webkit.org/changeset/86255 https://bugs.webkit.org/show_bug.cgi?id=60660 REGRESSION (r86255): Lots of tests crashing in CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release (WebKit2 Tests) (Requested by aroben on #webkit). * platform/network/ResourceHandle.h: * platform/network/cf/CookieStorageCFNet.cpp: (WebCore::currentCookieStorage): (WebCore::defaultCookieStorage): * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::makeFinalRequest): (WebCore::ResourceHandle::willSendRequest): * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): 2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r86255. http://trac.webkit.org/changeset/86255 https://bugs.webkit.org/show_bug.cgi?id=60660 REGRESSION (r86255): Lots of tests crashing in CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release (WebKit2 Tests) (Requested by aroben on #webkit). * WebView.cpp: (WebView::setCacheModel): 2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r86255. http://trac.webkit.org/changeset/86255 https://bugs.webkit.org/show_bug.cgi?id=60660 REGRESSION (r86255): Lots of tests crashing in CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release (WebKit2 Tests) (Requested by aroben on #webkit). * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: * Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::decodeResourceRequest): * UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess): * WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL): * WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess): 2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r86255. http://trac.webkit.org/changeset/86255 https://bugs.webkit.org/show_bug.cgi?id=60660 REGRESSION (r86255): Lots of tests crashing in CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release (WebKit2 Tests) (Requested by aroben on #webkit). * win/include/WebKitSystemInterface/WebKitSystemInterface.h: * win/lib/WebKitSystemInterface.lib: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-