- 15 Nov, 2002 8 commits
-
-
darin authored
* WebView.subproj/WebTextView.m: (-[WebTextView initWithFrame:]): Remove unneeded setWidthTracksTextView:, because that's the default. (-[WebTextView dataSourceUpdated:]): Replace the thing each time in the RTF case. (-[WebTextView viewDidMoveToSuperview]): Here's where we resize, but only the width. Resizing the height was causing the bug. (-[WebTextView layout]): Do nothing. (-[WebTextView setAcceptsDrags:]): Update to new name. Since we weren't importing WebDocument.h, we never noticed that this file got out of sync. (-[WebTextView acceptsDrags]): Ditto. (-[WebTextView setAcceptsDrops:]): Ditto. (-[WebTextView acceptsDrops]): Ditto. * WebView.subproj/WebDocument.h: Fix typo. It said setAcceptsDrags: twice. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
* WebView.subproj/WebDataSourcePrivate.h: * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setJustOpenedForTargetedLink:]): (-[WebDataSource _justOpenedForTargetedLink]): * WebView.subproj/WebFrame.m: (-[WebFrame findOrCreateFramedNamed:]): * WebView.subproj/WebFramePrivate.h: * WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): (-[WebFrame _loadDataSource:withLoadType:]): (-[WebFrame _downloadRequest:toPath:]): (-[WebFrame _setJustOpenedForTargetedLink:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
(-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]): Give the listener a slightly longer lifetime, to make this API a bit more foolproof. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
* WebView.subproj/WebFramePrivate.m: (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
Make navigation policy asynchronous for real. * WebKit.pbproj/project.pbxproj: * WebView.subproj/WebControllerPolicyDelegate.h: * WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyDecisionListenerPrivate initWithTarget:action:]): (-[WebPolicyDecisionListenerPrivate dealloc]): (-[WebPolicyDecisionListener usePolicy:]): (-[WebPolicyDecisionListener _initWithTarget:action:]): (-[WebPolicyDecisionListener dealloc]): (-[WebPolicyDecisionListener _invalidate]): * WebView.subproj/WebControllerPolicyDelegatePrivate.h: Added. * WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): * WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]): * WebView.subproj/WebFramePrivate.h: * WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]): (-[WebFrame _continueAfterNavigationPolicy:]): (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): (-[WebFrame _loadDataSource:withLoadType:]): WebBrowser: Make navigation policy asynchronous. * BrowserWebController.m: (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
* WebView.subproj/WebBaseResourceHandleDelegate.h: * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]): (-[WebMainResourceClient handle:didReceiveResponse:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
to be asynchronous. However, the actually delegate method is not async yet. * WebView.subproj/WebFramePrivate.h: * WebView.subproj/WebFramePrivate.m: (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]): (-[WebFrame _loadDataSource:withLoadType:]): * WebView.subproj/WebMainResourceClient.h: * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient stopLoadingForPolicyChange]): (-[WebMainResourceClient continueAfterNavigationPolicy:request:]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 14 Nov, 2002 10 commits
-
-
mjs authored
method (_loadDataSource:withLoadType:). * WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame reload]): * WebView.subproj/WebFramePrivate.h: * WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _loadRequest:triggeringAction:loadType:]): (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]): (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrame _loadDataSource:withLoadType:]): (-[WebFrame _downloadRequest:toPath:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
Change things so the public interface to loading is loadRequest: and everything else is private. * Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): * Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): * WebView.subproj/WebController.h: * WebView.subproj/WebController.m: (-[WebController init]): * WebView.subproj/WebControllerPrivate.m: (-[WebController _createFrameNamed:inParent:allowsScrolling:]): (-[WebController _downloadURL:toPath:]): * WebView.subproj/WebFrame.h: * WebView.subproj/WebFrame.m: (-[WebFrame init]): (-[WebFrame initWithName:webView:controller:]): (-[WebFrame loadRequest:]): (-[WebFrame reload]): * WebView.subproj/WebFramePrivate.h: * WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]): (-[WebFrame _clearProvisionalDataSource]): (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _loadRequest:triggeringAction:]): (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _setProvisionalDataSource:]): (-[WebFrame _startLoading]): (-[WebFrame _downloadRequest:toPath:]): * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient stopLoadingAfterContentPolicy]): (-[WebMainResourceClient handle:didReceiveResponse:]): * WebView.subproj/WebView.m: (-[WebView concludeDragOperation:]): WebBrowser: Change things so the public interface to loading is loadRequest: and everything else is private. * BrowserDocument.m: (-[BrowserDocument goToRequest:]): * BrowserWebController.m: (-[BrowserWebController initWithBrowserDocument:]): * Debug/SnippetController.h: * Debug/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController load]): (-[SnippetController loadComplete]): (-[SnippetController mainDataSource]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
shoudl speed up i-bench substantially and morrison's PLT test slightly. Note that the adjustFrames layout stuff has been removed from isLoadComplete. * WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]): (-[WebFrame _isLoadComplete]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
* English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes. WebKit: * English.lproj/Localizable.strings: Updated to include the new error messages that Maciej just added. I wonder what effect this will have if we see those errors in Alex-32? git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sheridan authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gramps authored
Added missing semi-colon in definition of WebPolicyDecisionListener to fix build error. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
Combined file URL policy with content policy. We don't actually bother to ask earlier for file URLs yet, since that will make things more complicated. * Misc.subproj/WebKitErrors.h: * WebView.subproj/WebControllerPolicyDelegate.h: * WebView.subproj/WebDefaultPolicyDelegate.m: * WebView.subproj/WebFramePrivate.h: * WebView.subproj/WebFramePrivate.m: (-[WebFrame _handleUnimplementablePolicy:errorCode:forURL:]): (-[WebFrame _continueAfterNavigationPolicyForRequest:dataSource:]): * WebView.subproj/WebMainResourceClient.h: * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient stopLoadingAfterContentPolicy]): (-[WebMainResourceClient handle:didReceiveResponse:]): * WebView.subproj/WebView.m: (+[WebView initialize]): WebBrowser: Combined file URL policy with content policy. Also adjusted error handling to continue to handle file errors well. * BrowserWebController.m: ...
-
darin authored
- fixed 3099240 -- REGRESSION: repro assert d->m_doc->parsing Don't force all redirects to be reloads, because the ones from JavaScript must not be. Maybe a better solution post-Alex-32 will be to pass a flag that distinguishes redirects from other location changes. * khtml/khtml_part.cpp: (KHTMLPart::slotRedirect): Don't ignore the anchor when comparing URLs to see if they should be a reload. We'll still do a reload if the URLs are actually equal, but if they differ in anchor we will just go to the anchor. This is the bug fix. * kwq/WebCoreBridge.h: Add reload parameter. * kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:headers:]): Stuff the reload parameter into the URLArgs. WebKit: - fixed 3099240 -- REGRESSION: repro assert d->m_doc->parsing Make the reload flag pass across the bridge. * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): Pass a reload flag, based on the load type, to the bridge. * WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Pass a reload flag of NO in the anchor case. Preserve reload load types even when doing client redirects (have to talk with Trey about this tomorrow). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com * kwq/WebCoreBridge.h: Add needsLayout. * kwq/WebCoreBridge.mm: (-[WebCoreBridge needsLayout]): Return true if the render tree root says "layouted" is false. It would be more elegant to use more of this WebCore layout logic and have less of our own on the WebKit side. * WebCore.pbproj/project.pbxproj: Oh, that Project Builder. WebKit: - fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com * WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): If the WebCore side needs layout, then do layout before trying to draw. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
trey authored
generate two items in the back-forward list. iBench still works. * WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Call straight to the frame for all impl. (-[WebBridge reportClientRedirectCancelled]): Call straight to the frame for all impl. (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]): clientRedirect param removed when sending _loadURL: to frame. * WebView.subproj/WebFramePrivate.h: * WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): clientRedirect param removed. Check our own ivar to know if we are in client redirect case. (-[WebFrame _loadURL:intoChild:]): clientRedirect param removed when sending _loadURL: . (-[WebFrame _clientRedirectedTo:delay:fireDate:]): Note that we are doing a redirect if time=0 and we're not completed. Also includes ...
-
- 13 Nov, 2002 6 commits
-
-
mjs authored
Pass mime type instead of full response to content policy delegate method, in preparation for merging it with the file URL policy. * WebView.subproj/WebControllerPolicyDelegate.h: * WebView.subproj/WebDefaultPolicyDelegate.m: * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): WebBrowser: Pass mime type instead of full response to content policy delegate method, in preparation for merging it with the file URL policy. * BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fixed 3083982 -- Logging into AOL gives null view Turns out AOL was using a refresh header, which we were not supporting. * khtml/khtml_part.h: Declare receivedFirstData, a private member function. * khtml/khtml_part.cpp: (KHTMLPart::receivedFirstData): Separate out the part of slotData we want to share, which really seems kinda separate anyway. (KHTMLPart::slotData): More of the same. * kwq/KWQKHTMLPart.h: Declare addMetaData. * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::slotData): Call receivedFirstData instead of doing the same thing ourselves. (KWQKHTMLPart::addMetaData): Added. Puts metadata into the job. * kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Fix bug where this was calling openURL: but meant to call loadURL:. * kwq/WebCoreBridge.h: Add headers to openURL method. Remove setContentType. * kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:withHeaders:]): Handle Content-Type and Refresh. This method is big enough that I should probably move the guts to KWQKHTMLPart. - other things * kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): I overlooked something while doing my "bug fix" in here a while back. Change an assignment statement to an assert. WebKit: - fixed 3083982 -- Logging into AOL gives null view Turns out AOL was using a refresh header, which we were not supporting. * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): Call openURL: and pass headers in. * WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]): Pass nil for headers in this case, since we know it's just an anchor change. - other things * WebCoreSupport.subproj/WebBridge.h: Remove dataSourceChanged and dataSource methods. We try to keep the bridge methods down to actual bridging. * WebCoreSupport.subproj/WebBridge.m: Remove dataSourceChanged altogether, and move dataSource up in the file. * WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation setDataSource:]): Keep the data source around, so we don't need to ask the bridge for it. (-[WebHTMLRepresentation documentSource]): Use it here. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
trey authored
* WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): Make the rep before _transitionToCommitted. This is the way it used to be. (-[WebDataSource _makeRepresentation]): Don't make the docView here. * WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Make the docView here, after we save the scroll state but before notifying the delegate. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
* WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]): Don't set the state to WebFrameStateComplete if it has already been set to WebFrameStateProvisional. If it has, that means we already began a new load; that one is not yet complete. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sullivan authored
- fixed 3099922 -- REGRESSION: Back button always pops up menu * Misc.subproj/WebNSViewExtras.h: * Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]: Fixed a copy/paste error I made yesterday -- this method was never noticing the mouse-up events because it was checking the event type against the wrong number. Also changed the hysteresis values from unsigneds to floats (unsigned was just wrong). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
- fixed 3050447 - Policy handlers have no way of telling client that the proposed navigation is a form post * khtml/khtml_part.cpp: (KHTMLPart::submitForm): Call kwq->submitForm * kwq/KWQKHTMLPart.h: * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Adjusted for bridge API change. (KWQKHTMLPart::openURLRequest): Removed POST handling. (KWQKHTMLPart::submitForm): Added this back, because we need to know what URL navigations are caused by form submission, even if they are not POSTs. (KWQKHTMLPart::urlSelected): Adjusted for bridge API change. * kwq/WebCoreBridge.h: Add triggeringEvent: parameter to postURL: and isFormSubmission: parameter to loadURL:. WebKit: - fixed 3050447 - Policy handlers have no way of telling client that the proposed navigation is a form post Now we pass form submissions through all the normal policy steps. * WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]): (-[WebBridge postWithURL:data:contentType:triggeringEvent:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): * WebView.subproj/WebDataSourcePrivate.h: * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setTriggeringAction:]): (-[WebDataSource _triggeringAction]): (-[WebDataSource _lastCheckedRequest]): (-[WebDataSource _setLastCheckedRequest:]): * WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): * WebView.subproj/WebFramePrivate.h: * WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowRequest:]): (-[WebFrame _loadRequest:triggeringAction:]): (-[WebFrame _actionInformationForNavigationType:event:]): (-[WebFrame _continueAfterNavigationPolicyForRequest:dataSource:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]): (-[WebFrame _loadURL:intoChild:]): (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 12 Nov, 2002 10 commits
-
-
mjs authored
Combine click policy and URL policy into navigation policy. * WebView.subproj/WebControllerPolicyDelegate.h: * WebView.subproj/WebDefaultPolicyDelegate.h: * WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate navigationPolicyForAction:andRequest:inFrame:]): * WebView.subproj/WebFramePrivate.h: * WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowRequest:]): (-[WebFrame _actionInformationForNavigationType:event:]): (-[WebFrame _continueAfterFileURLPolicyForRequest:]): (-[WebFrame _continueAfterNavigationPolicyForRequest:event:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]): WebBrowser: Combined click policy and URL policy into navigation policy. * BrowserDocument.m: (-[BrowserDocument goToRequest:]): * BrowserWebController.m: (-[BrowserWebController navigationPolicyForAction:andRequest:inFrame:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
trey authored
fixed 3096030 - Crash in -[WebBackForwardList goToEntry:] when playing with SnapBack and dictionary.com * WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]): Set state=completed only after we tell the bridge to end the load. This allows client redirects to be processed before we think we're complete. (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]): Only process client redirects as such if we are not already complete. This makes JS driven navigations after load-time work like the user would expect, as normal navigations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
the download directory * WebView.subproj/WebControllerPrivate.h: * WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:]): Call _downloadURL:toPath: with nil path. (-[WebController _downloadURL:toPath:]): New method that predetermines the path to download to (needed for DnD). * WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use _downloadURL:toPath: * WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): Use _downloadURL:toPath: * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask delegate for download path if we already have one. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rjw authored
some situations. * WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sullivan authored
* Misc.subproj/WebNSViewExtras.h: * Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]): new method (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:]): now calls the new method, passing the default hysteresis values WebBrowser: - fixed 3096528 -- don't let initially-horizontal drags of toolbar bookmarks escape from toolbar Unfortunately I left behind a drawing glitch, recorded as bug 3099488. Ideas to fix this are hereby solicited. * FavoritesBar.m: (-[FavoritesBar slideButtonsIntoPlace]): renamed from repositionButtons for clarity (-[FavoritesBar maxButtonX]): new method, extracted from _layOutButtons (-[FavoritesBar _layOutButtons]): now calls maxButtonX (-[FavoritesBar setDropIndex:]): updated for name change (-[FavoritesBar specialBookmarkSourcesCount]): new method, extracted from duplicated code (-[FavoritesBar lastNonFavoriteIndex]): new method, extracted from dropIndexFromDraggingInfo: (-[FavoritesBar dropIndexFromLocalPoint:]): new method, extracted from dropIndexFromDraggingInfo: (-[FavoritesBar dropIndexFromDraggingInfo:]): now calls dropIndexFromLocalPoint: (-[FavoritesBar addDroppedBookmarks:atIndex:]): new method, extracted from performDragOperation: (-[FavoritesBar performDragOperation:]): now calls addDroppedBookmarks:atIndex: (-[FavoritesBar _lastDraggedEventFollowing:]), (-[FavoritesBar _lastDraggedOrUpEventFollowing:]): new methods, cribbed from AppKit (-[FavoritesBar constrainProposedButtonFrame:]): new method (-[FavoritesBar reorderFavoriteButton:fromMouseDownEvent:]): new method, drags (but not using CoreDragging stuff) button horizontally within bar only * FavoritesBarView.h: added definition of FavoritesBarReorderingDelegate informal protocol * FavoritesBarView.m: (-[FavoritesBarView reorderFavoriteButton:fromMouseDownEvent:]): pass call through to delegate (FavoritesBar) * FavoriteButton.m: (-[FavoriteButton currentEventOffsetFromEvent:]): new method, extracted from performDragFromEvent: (-[FavoriteButton performDragFromEvent:]): now calls extracted method (-[FavoriteButton canDrag]): renamed from canDragButton; now checks whether superview is a FavoritesBarView (-[FavoriteButton mouseDown:]): checks whether initial dragging movement was primarily vertical or horizontal; if horizontal, calls new reordering code; if vertical, uses larger hysteresis to minimize accidental poofing git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rjw authored
* khtml/rendering/font.cpp: (Font::drawText): (Font::floatWidth): (Font::floatCharacterWidths): * kwq/KWQFontMetrics.h: * kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths): * kwq/KWQPainter.h: * kwq/KWQPainter.mm: (QPainter::drawText): * kwq/WebCoreTextRenderer.h: Implemented letter-spacing and word-spacing CSS properties. * Misc.subproj/WebStringTruncator.m: (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): * WebCoreSupport.subproj/WebTextRenderer.h: * WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]): Changed to reflect method name change. * EtchedStringView.m: (-[EtchedStringView drawRect:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
Removed policy classes and instead use the policy enums directly, since we no longer hold the path in the enum. * Downloads.subproj/WebDownloadHandler.m: * WebKit.exp: * WebKit.pbproj/project.pbxproj: * WebView.subproj/WebControllerPolicyDelegate.h: * WebView.subproj/WebControllerPolicyDelegate.m: * WebView.subproj/WebControllerPolicyDelegatePrivate.h: Removed. * WebView.subproj/WebControllerPrivate.m: * WebView.subproj/WebDefaultPolicyDelegate.h: * WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate defaultURLPolicyForRequest:]): (-[WebDefaultPolicyDelegate URLPolicyForRequest:inFrame:]): (-[WebDefaultPolicyDelegate fileURLPolicyForMIMEType:andRequest:inFrame:]): (-[WebDefaultPolicyDelegate unableToImplementPolicy:error:forURL:inFrame:]): (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]): * WebView.subproj/WebFramePrivate.m: (-...
-
mjs authored
used with redirects. * WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadRequest:triggeringEvent:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]): (-[WebFrame _postWithURL:data:contentType:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fixed 3083043 -- Alex doesn't decode % sequences in javascript: URLs Some places here did KURL::decode_string, but others didn't. * khtml/khtml_part.cpp: (KHTMLPart::slotShowDocument): Added call to KURL::decode_string. (KHTMLPart::overURL): Ditto. (KHTMLPart::urlSelected): Ditto. (KHTMLPart::requestFrame): Ditto. (KHTMLPart::slotChildURLRequest): Ditto. WebKit: - improved the code that manages observing the window and superview * WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSuperviewObservers]): Added. (-[WebHTMLView removeSuperviewObservers]): Added. (-[WebHTMLView addWindowObservers]): Added. (-[WebHTMLView removeWindowObservers]): Added. (-[WebHTMLView viewWillMoveToSuperview:]): Call removeSuperviewObservers. (-[WebHTMLView viewDidMoveToSuperview]): Call addSuperviewObservers. (-[WebHTMLView viewWillMoveToWindow:]): Call removeWindowObservers and removeSuperviewObservers. (-[WebHTMLView viewDidMoveToWindow]): Call addWindowObservers and addSuperviewObservers. WebBrowser: - fixed 3083043 -- Alex doesn't decode % sequences in javascript: URLs * BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): Call CFURLCreateStringByReplacingPercentEscapes on the URL fragment before passing it to stringByEvaluatingJavaScriptFromString:. * BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]): Ditto. - fixed world leaks seen when playing with the snippet window * Debug/SnippetController.m: (-[SnippetController dealloc]): Release the location change delegate to avoid a leak. Also release the data source now that we retain it. (-[SnippetController windowWillClose:]): Release everything here. If we don't we get a world leak. Also remove the WebView from the superview. If we don't, it leaks. At some point we should look into this because it may indicate a WebKit problem, so I marked it with a FIXME. (-[SnippetController load]): Retain the data source. (-[SnippetController loadComplete]): Release the old text storage. * Debug/SnippetController.h: Tweaks. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
Remove contentPolicy parameter from _downloadURL, and remove remaining traces of path from policy object. * WebView.subproj/WebControllerPolicyDelegate.h: * WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyPrivate dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:]): (+[WebClickPolicy webPolicyWithClickAction:]): * WebView.subproj/WebControllerPolicyDelegatePrivate.h: * WebView.subproj/WebControllerPrivate.h: * WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:]): * WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate downloadURL:]): * WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]): * WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]): * WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): * WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): WebBrowser: Don't pass path when making policy objects. * BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:]): (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 11 Nov, 2002 6 commits
-
-
darin authored
* English.lproj/StringsNotToBeLocalized.txt: Update. WebCore: * kwq/KWQWidget.mm: (QWidget::setCursor): Remove printf I left in by accident. WebKit: * Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): Use fileSystemRepresentationWithPath, not cString, to turn a path into something to pass to FSPathMakeRef. * English.lproj/StringsNotToBeLocalized.txt: Update. WebBrowser: * BrowserNSStringExtras.m: (-[NSString compareVersionString:]): Use lossyCString so we don't get an exception if a string is bad. * English.lproj/StringsNotToBeLocalized.txt: Update. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- tighten up cursor handling a bit more * kwq/KWQWidget.mm: (QWidget::setCursor): Use setDocumentCursor: instead of our own protocol. (QWidget::cursor): Use documentCursor instead of storing our own cursor. * kwq/WebCoreFrameView.h: Remove setCursor: method. WebKit: - tighten up cursor handling a bit more * WebView.subproj/WebDynamicScrollBarsView.m: * WebView.subproj/WebHTMLView.m: (-[WebHTMLView addMouseMovedObserver]): Call _frameOrBoundsChanged so we emit a mouse moved event right away. (-[WebHTMLView viewWillMoveToSuperview:]): Remove the colon since I removed the parameter from _frameOrBoundsChanged. * WebView.subproj/WebHTMLViewPrivate.h: Declare _frameOrBoundsChanged. * WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frameOrBoundsChanged]): Remove parameter. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
trey authored
* WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Save scroll position on reload (-[WebFrame _isLoadComplete]): Restore position on reload git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
trey authored
First checkin of making frames work with the back forward list, restoring scroll position and form state. Fixing: 3014555 Lose frameset context going back/forward 3078151 History inconsistency after loading frame content 3089551 REGRESSION: www.bmwusa.com frames don't load in alex-30 3095878 refresh doesn't preserve frame state WebCore: * khtml/khtml_part.cpp: (KHTMLPart::requestFrameName): Call through bridge to get generated frame name. * kwq/KWQKHTMLPart.h: * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::generateFrameName): New call that just forwards through the bridge. * kwq/WebCoreBridge.h: WebKit: * History.subproj/WebBackForwardList.m: (-[WebBackForwardList addEntry:]): Yank code to avoid adding a duplicate entry, to catch the refresh case. That's dealt with in WebFramePrivate now. (-[WebBackForwardList description]): Enhanced to print more info. * History.subproj/WebHistoryItem.h: History items now hold an array of...
-
mjs authored
Store path and the fact that we're downloading in the data source, instead of storing the content policy. * Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler cleanUpAfterFailure]): (-[WebDownloadHandler createFileIfNecessary]): (-[WebDownloadHandler finishedLoading]): * WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:withContentPolicy:]): * WebView.subproj/WebDataSource.h: * WebView.subproj/WebDataSource.m: (+[WebDataSource registerRepresentationClass:forMIMEType:]): (-[WebDataSource isDownloading]): (-[WebDataSource downloadPath]): * WebView.subproj/WebDataSourcePrivate.h: * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _setIsDownloading:]): (-[WebDataSource _setDownloadPath:]): * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handleDidFinishLoading:]): WebBrowser: Adjusted for WebKit API changes. * DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDataSource:]): (-[DownloadProgressEntry path]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
Don't ask for the content policy any more if the previous policies said to save - in effect this means to ask only if the previous policies said to use the content policy. Also, remove now-useless previous content policy parameter from content policy delegate. * WebView.subproj/WebControllerPolicyDelegate.h: * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setContentPolicy:]): Retain new policy before releasing the old one. * WebView.subproj/WebDefaultPolicyDelegate.m: * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask for content policy if the delegate already decided to save. WebBrowser: Adjusted for WebKit API change. * BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-