1. 27 Oct, 2008 16 commits
  2. 25 Oct, 2008 15 commits
    • ggaren@apple.com's avatar
      2008-10-25 Geoffrey Garen <ggaren@apple.com> · 93eccf94
      ggaren@apple.com authored
              Not reviewed.
              
              Try to fix Windows build.
      
              * VM/Machine.cpp:
              (JSC::Machine::privateExecute): Provide a dummy value to the
              HostCallRecord in CTI non-sampling builds, to silence compiler warning.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93eccf94
    • ggaren@apple.com's avatar
      2008-10-25 Geoffrey Garen <ggaren@apple.com> · d2fd0655
      ggaren@apple.com authored
              Not reviewed.
              
              Try to fix Windows build.
      
              * VM/SamplingTool.h:
              (JSC::SamplingTool::encodeSample): Explicitly cast bool to int, to
              silence compiler warning.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2fd0655
    • ggaren@apple.com's avatar
      2008-10-25 Geoffrey Garen <ggaren@apple.com> · bdfb2b5d
      ggaren@apple.com authored
              Not reviewed.
              
              Try to fix Mac debug build on the buildbot.
      
              * platform/FileChooser.cpp:
              (WebCore::FileChooserClient::~FileChooserClient):
              * platform/FileChooser.h: Moved destructor to .cpp file, to avoid a
              weak exported symbol.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdfb2b5d
    • ggaren@apple.com's avatar
      2008-10-25 Geoffrey Garen <ggaren@apple.com> · be95ccfc
      ggaren@apple.com authored
              Reviewed by Sam Weinig, with Gavin Barraclough's help.
              
              Fixed Sampling Tool:
                  - Made CodeBlock sampling work with CTI
                  - Improved accuracy by unifying most sampling data into a single
                    32bit word, which can be written / read atomically.
                  - Split out three different #ifdefs for modularity: OPCODE_SAMPLING;
                    CODEBLOCK_SAMPLING; OPCODE_STATS.
                  - Improved reporting clarity
                  - Refactored for code clarity
      
              * JavaScriptCore.exp: Exported another symbol.
      
              * VM/CTI.cpp:
              (JSC::CTI::emitCTICall):
              (JSC::CTI::compileOpCall):
              (JSC::CTI::emitSlowScriptCheck):
              (JSC::CTI::compileBinaryArithOpSlowCase):
              (JSC::CTI::privateCompileMainPass):
              (JSC::CTI::privateCompileSlowCases):
              (JSC::CTI::privateCompile):
              * VM/CTI.h: Updated CTI codegen to use the unified SamplingTool interface
              for encoding samples. (This required passing the current vPC to a lot
              more functions, since the unified interface samples the current vPC.)
              Added hooks for writing the current CodeBlock* on function entry and
              after a function call, for the sake of the CodeBlock sampler. Removed
              obsolete hook for clearing the current sample inside op_end. Also removed
              the custom enum used to differentiate flavors of op_call, since the
              OpcodeID enum works just as well. (This was important in an earlier
              version of the patch, but now it's just cleanup.)
      
              * VM/CodeBlock.cpp:
              (JSC::CodeBlock::lineNumberForVPC):
              * VM/CodeBlock.h: Upated for refactored #ifdefs. Changed lineNumberForVPC
              to be robust against vPCs not recorded for exception handling, since
              the Sampler may ask for an arbitrary vPC.
      
              * VM/Machine.cpp:
              (JSC::Machine::execute):
              (JSC::Machine::privateExecute):
              (JSC::Machine::cti_op_call_NotJSFunction):
              (JSC::Machine::cti_op_construct_NotJSConstruct):
              * VM/Machine.h:
              (JSC::Machine::setSampler):
              (JSC::Machine::sampler):
              (JSC::Machine::jitCodeBuffer): Upated for refactored #ifdefs. Changed
              Machine to use SamplingTool helper objects to record movement in and
              out of host code. This makes samples a bit more precise.
              
              * VM/Opcode.cpp:
              (JSC::OpcodeStats::~OpcodeStats):
              * VM/Opcode.h: Upated for refactored #ifdefs. Added a little more padding,
              to accomodate our more verbose opcode names.
      
              * VM/SamplingTool.cpp:
              (JSC::ScopeSampleRecord::sample): Only count a sample toward our total
              if we actually record it. This solves cases where a CodeBlock will
              claim to have been sampled many times, with reported samples that don't
              match.
      
              (JSC::SamplingTool::run): Read the current sample into a Sample helper
              object, to ensure that the data doesn't change while we're analyzing it,
              and to help decode the data. Only access the CodeBlock sampling hash
              table if CodeBlock sampling has been enabled, so non-CodeBlock sampling
              runs can operate with even less overhead.
      
              (JSC::SamplingTool::dump): I reorganized this code a lot to print the
              most important info at the top, print as a table, annotate and document
              the stuff I didn't understand when I started, etc.
      
              * VM/SamplingTool.h: New helper classes, described above.
      
              * kjs/Parser.h:
              * kjs/Shell.cpp:
              (runWithScripts):
              * kjs/nodes.cpp:
              (JSC::ScopeNode::ScopeNode): Updated for new sampling APIs.
      
              * wtf/Platform.h: Moved sampling #defines here, since our custom is to
              put ENABLE #defines into Platform.h. Made explicit the fact that
              CODEBLOCK_SAMPLING depends on OPCODE_SAMPLING.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be95ccfc
    • kevino@webkit.org's avatar
      wx build fix. · 79ee22d1
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79ee22d1
    • vestbo@webkit.org's avatar
      2008-10-25 Jade Han <jade.han@nokia.com> · 4e51694b
      vestbo@webkit.org authored
              Reviewed by Anders.
      
              Enable custom properties for Qt runtime objects in QtWebKit
      
              https://bugs.webkit.org/show_bug.cgi?id=21813
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e51694b
    • jmalonzo@webkit.org's avatar
      2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org> · c91a653f
      jmalonzo@webkit.org authored
              JSC Build fix, not reviewed.
      
              * VM/CTI.cpp: add missing include stdio.h for debug builds
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c91a653f
    • jmalonzo@webkit.org's avatar
      2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org> · e39356e5
      jmalonzo@webkit.org authored
              Gtk build fix: add '-' to Wl which was missed in r36845
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e39356e5
    • weinig@apple.com's avatar
      2008-10-24 Sam Weinig <sam@webkit.org> · 10a0b73b
      weinig@apple.com authored
              Yet another windows build fix.
      
              * WebCoreSupport/WebChromeClient.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10a0b73b
    • weinig@apple.com's avatar
      2008-10-24 Sam Weinig <sam@webkit.org> · 656b4ed8
      weinig@apple.com authored
              Another Qt build fix.
      
              * WebCoreSupport/ChromeClientQt.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      656b4ed8
    • weinig@apple.com's avatar
      2008-10-24 Sam Weinig <sam@webkit.org> · 57fab778
      weinig@apple.com authored
              Another windows build fix.
      
              * WebCoreSupport/WebChromeClient.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57fab778
    • weinig@apple.com's avatar
      2008-10-24 Sam Weinig <sam@webkit.org> · 6c48aa1d
      weinig@apple.com authored
              Fix windows build.
      
              * page/Chrome.cpp:
              * page/Chrome.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c48aa1d
    • weinig@apple.com's avatar
      2008-10-24 Sam Weinig <sam@webkit.org> · 9f15ec5b
      weinig@apple.com authored
              Fix the Gtk build.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f15ec5b
    • weinig@apple.com's avatar
      2008-10-24 Sam Weinig <sam@webkit.org> · 32ded9f2
      weinig@apple.com authored
              Fix Qt build.
      
              * platform/qt/FileChooserQt.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32ded9f2
    • weinig@apple.com's avatar
      WebCore: · d75fed72
      weinig@apple.com authored
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              Move file choosing into WebKit ChromeClient.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::runOpenPanel):
              * page/Chrome.cpp:
              (WebCore::Chrome::runOpenPanel):
              * page/Chrome.h:
              * page/ChromeClient.h:
              * page/mac/ChromeMac.mm:
              * platform/FileChooser.h:
              * platform/mac/FileChooserMac.mm:
              * platform/qt/FileChooserQt.cpp:
              * platform/win/FileChooserWin.cpp:
              * platform/wx/TemporaryLinkStubs.cpp:
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::click):
      
      WebKit/gtk:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::runOpenPanel):
              * WebCoreSupport/ChromeClientGtk.h:
      
      WebKit/mac:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::runOpenPanel):
      
      WebKit/qt:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::runOpenPanel):
              * WebCoreSupport/ChromeClientQt.h:
      
      WebKit/win:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::runOpenPanel):
              * WebCoreSupport/WebChromeClient.h:
      
      WebKit/wx:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::runOpenPanel):
              * WebKitSupport/ChromeClientWx.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d75fed72
  3. 24 Oct, 2008 9 commits