1. 05 Jan, 2012 40 commits
    • commit-queue@webkit.org's avatar
      [Chromium] Expectations for svg/carto.net/button.svg can be updated · 921d05fb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75621
      
      Unreviewed Chromium test expectations update.
      
      Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-05
      
      * platform/chromium-linux-x86/svg/carto.net: Removed.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      921d05fb
    • alexis.menard@openbossa.org's avatar
      getComputedStyle for background is not implemented. · 148d8b35
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75539
      
      Reviewed by Tony Chang.
      
      Source/WebCore: 
      
      Implement getComputedStyle for background.
      
      Test: fast/css/getComputedStyle/getComputedStyle-background-shorthand.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      LayoutTests: 
      
      Add new tests to make sure we return the correct values.
      
      * fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt: Added.
      * fast/css/getComputedStyle/getComputedStyle-background-shorthand.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      148d8b35
    • commit-queue@webkit.org's avatar
      Pass WebFrame instead of WebCore::Frame to the WebKit2 specific FrameNetworkingContext · 0c566f47
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75550
      
      Make the WebKit2 FrameNetworkingContext implementation store the
      WebFrame instead of the WebCore::Frame as this is needed for the Qt
      port to implement a.o. HTTP autentication and SSL support.
      
      As the WebFrameNetworkingContext is partly shared across all WebKit2 ports,
      all port specific files have been modified.
      
      For the Qt implementation of FrameNetworkingContext, we also set a
      property to the originatingObject for the page ID. We also switch to
      using an OwnPtr instead of a raw C++ pointer for the
      m_originatingObject member.
      
      Based on original patch by Peter Hartmann.
      
      Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-05
      Reviewed by Kenneth Rohde Christiansen.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::createNetworkingContext):
      * WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h:
      (WebFrameNetworkingContext::create):
      (WebFrameNetworkingContext::WebFrameNetworkingContext):
      * WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h:
      (WebFrameNetworkingContext::create):
      (WebFrameNetworkingContext::WebFrameNetworkingContext):
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
      (WebKit::WebFrameNetworkingContext::create):
      (WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
      * WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
      (WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
      (WebCore::WebFrameNetworkingContext::~WebFrameNetworkingContext):
      (WebCore::WebFrameNetworkingContext::create):
      * WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
      * WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:
      (WebFrameNetworkingContext::create):
      (WebFrameNetworkingContext::WebFrameNetworkingContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c566f47
    • commit-queue@webkit.org's avatar
      [Qt] Never enable FontConfig on Mac OS X · 3e8d7302
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75616
      
      Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-05
      Reviewed by Tor Arne Vestbø.
      
      * qmake/mkspecs/features/features.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e8d7302
    • hclam@chromium.org's avatar
      Unreviewed, rolling out r104159. · 1985d1aa
      hclam@chromium.org authored
      http://trac.webkit.org/changeset/104159
      https://bugs.webkit.org/show_bug.cgi?id=75590
      
      Chromium port GPU tests cannot be executed.
      
      * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
      (get):
      (_default_tests_paths):
      * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
      (ChromiumGpuTest.assert_port_works):
      * Scripts/webkitpy/layout_tests/port/factory.py:
      (PortFactory._port_name_from_arguments_and_options):
      (PortFactory):
      (PortFactory._get_kwargs):
      (PortFactory.get):
      * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
      (FactoryTest.test_google_chrome.names):
      (FactoryTest.test_google_chrome):
      * Scripts/webkitpy/layout_tests/port/google_chrome.py:
      (GetGoogleChromePort):
      (GetGoogleChromePort.GoogleChromeLinux32Port):
      (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
      (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
      (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
      (GetGoogleChromePort.GoogleChromeLinux64Port):
      (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
      (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
      (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
      (GetGoogleChromePort.GoogleChromeMacPort):
      (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
      (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
      (GetGoogleChromePort.GoogleChromeWinPort):
      (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
      (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
      * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
      (GetGoogleChromePortTest._verify_baseline_path):
      (GetGoogleChromePortTest._verify_expectations_overrides):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1985d1aa
    • rniwa@webkit.org's avatar
      DOM Attribute tests on Dromaeo spends 2.7% of time in hasSelectorForAttribute · a79e58a7
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75569
      
      Reviewed by Andreas Kling.
      
      Check needsStyleRecalc() first to avoid unnecessary hash lookups.
      
      * dom/Element.cpp:
      (WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a79e58a7
    • philn@webkit.org's avatar
      Unreviewed, GTK test_expectations update. · caf14632
      philn@webkit.org authored
      * platform/gtk/test_expectations.txt: Give
      media/media-blocked-by-beforeload.html another chance on the bot
      after its update in r103509.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      caf14632
    • commit-queue@webkit.org's avatar
      [EFL] Replace alloca to C++ new placement. · 1f1b1735
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72017
      
      Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-01-05
      Reviewed by Andreas Kling.
      
      Replaces alloca to C++ new placement as it is not very portable.
      It allows to skip checking of memory allocation as new never returns NULL.
      According to Edje's documentation type of val (member of Edje_Message_Float_Set)
      is double so I changed it to avoid undefined behaviour.
      
      * platform/efl/ScrollbarEfl.cpp:
      (ScrollbarEfl::updateThumbPositionAndProportion):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f1b1735
    • ossy@webkit.org's avatar
      [Qt][WK2]REGRESSION(r104068):... · 5c3af0b5
      ossy@webkit.org authored
      [Qt][WK2]REGRESSION(r104068): editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html made the next test fail
      
      Unreviewed gardening. One more attempt to paint the Qt-WK2 bot green.
      
      * platform/qt-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c3af0b5
    • hclam@chromium.org's avatar
      Not reviewed. Update Chromium port test expectations. · 465c87a8
      hclam@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      465c87a8
    • commit-queue@webkit.org's avatar
      [EFL] Invalidation request for ewk_view can be discarded without rendering. · c7d8e90e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71564
      
      Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-05
      Reviewed by Hajime Morita.
      
      As ewk_view discards a queue for invalidation requests
      as soon as it proceeds the repaint step, the newly produced invalidation requests
      from ewk_view_layout_if_needed_recursive API can be discarded
      and unpainted dirty area can occur.
      As this issue is just caused by use of flush API in repaint step,
      (internal API) ewk_view_repaints_get is replaced with ewk_view_repaints_pop
      in order to make sure that old invalidation requests are removed from queue.
      And in addition to that, ewk_view_repaint_add is modified
      in order to let queue of invalidation requests keep a proper size.
      As a result flush API won't be used for the repaint step.
      
      * ewk/ewk_private.h:
      * ewk/ewk_view.cpp:
      (_ewk_view_repaint_add):
      (_ewk_view_smart_calculate):
      (ewk_view_repaints_pop):
      * ewk/ewk_view_single.cpp:
      (_ewk_view_single_smart_repaints_process):
      * ewk/ewk_view_tiled.cpp:
      (_ewk_view_tiled_smart_repaints_process):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7d8e90e
    • dpranke@chromium.org's avatar
      webkitpy: clean up port factory methods · df41f55a
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75590
      
      Reviewed by Eric Seidel.
      
      This change consolidates much of the "factory method" logic
      of determining which port objects to create for a given set
      of configurations by merging the separate factory methods in
      chromium_gpu and google_chrome into PortFactory so that at least
      all of the logic is in one place.
      
      * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
      * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
      * Scripts/webkitpy/layout_tests/port/factory.py:
      (_port_name_from_arguments_and_options):
      (get):
      * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
      (test_google_chrome):
      * Scripts/webkitpy/layout_tests/port/google_chrome.py:
      (GoogleChromeLinux32Port):
      (GoogleChromeLinux32Port.baseline_search_path):
      (test_expectations_overrides):
      (architecture):
      (GoogleChromeLinux64Port):
      (GoogleChromeLinux64Port.baseline_search_path):
      (GoogleChromeMacPort):
      (GoogleChromeMacPort.baseline_search_path):
      (GoogleChromeWinPort):
      (GoogleChromeWinPort.baseline_search_path):
      * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
      (_verify_baseline_path):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df41f55a
    • commit-queue@webkit.org's avatar
      Remove duplicate file references from WebCore.xcodeproj · 893f02f7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75581
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-05
      Reviewed by Andreas Kling.
      
      Many generated DOMSVG files had two references.
      
      In platform/graphics, there was two arm directory
      with the same files related to ARM Neon.
      
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      893f02f7
    • aroben@apple.com's avatar
      Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code · 5faff20f
      aroben@apple.com authored
      This allows us to add the Apple Application Support directory to PATH before trying to load
      WebKit so that CoreGraphics.dll and friends can be found.
      
      Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
      
      Reviewed by Anders Carlsson.
      
      Tools:
      
      * DumpRenderTree/win/ImageDiff.vcproj:
      * DumpRenderTree/win/ImageDiffCommon.vsprops:
      Changed to build ImageDiff.dll instead of ImageDiff.exe.
      
      * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
      Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
      
      * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
      * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
      * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
      * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
      * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
      * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
      * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
      
      * DumpRenderTree/win/ImageDiffWin.cpp: Added.
      (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
      to main.
      
      * win/DLLLauncher/DLLLauncherMain.cpp:
      (main):
      (wWinMain):
      Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
      stub launcher acts as a console program and calls a console version of
      dllLauncherEntryPoint.
      
      Source/WebKit/win:
      
      Add ImageDiffLauncher to WebKit.sln
      
      It builds just after ImageDiff.
      
      * WebKit.vcproj/WebKit.sln:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5faff20f
    • kenneth@webkit.org's avatar
      [Qt] Implement QQuickWebView::inputMethodQuery · 586d4bf9
      kenneth@webkit.org authored
      Reviewed by Simon Hausmann.
      
      Implement the current Qt5 queries of inputMethodQuery.
      
      * UIProcess/API/qt/qquickwebview.cpp:
      (QQuickWebView::inputMethodQuery):
      * UIProcess/API/qt/qquickwebview_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      586d4bf9
    • aroben@apple.com's avatar
      Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code · 7f7f3cf1
      aroben@apple.com authored
      This allows us to add the Apple Application Support directory to PATH before trying to load
      WebKit so that CoreGraphics.dll and friends can be found.
      
      Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
      double-clicked
      
      Reviewed by Anders Carlsson.
      
      Tools:
      
      * MiniBrowser/MiniBrowser.vcproj:
      * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
      Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
      
      * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
      * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
      * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
      * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
      * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
      * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
      * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
      
      * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
      but changed to build the stub launcher.
      
      * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
      it needs to be compiled into the .exe instead of the .dll.
      (DllMain): Added. We use this to store the DLL's HINSTANCE.
      (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
      DLLLauncherMain code.
      
      * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
      to here.
      
      Source/WebKit/win:
      
      Add MiniBrowserLauncher to WebKit.sln
      
      It builds just after MiniBrowser.
      
      * WebKit.vcproj/WebKit.sln: Added MiniBrowserLauncher.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f7f3cf1
    • aroben@apple.com's avatar
      Make WinLauncher's window frame respond to clicks/drags again · 8fec4ff1
      aroben@apple.com authored
      Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
      bar when Aero is disabled
      
      Reviewed by Brent Fulgham.
      
      * WinLauncher/WinLauncher.cpp:
      (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
      Also removed an unnecessary "break" keyword.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fec4ff1
    • aroben@apple.com's avatar
      Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code · 1c6ff807
      aroben@apple.com authored
      This allows us to add the Apple Application Support directory to PATH before trying to load
      WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
      should use this mechanism.
      
      Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
      double-clicked
      
      Reviewed by Anders Carlsson.
      
      Tools:
      
      * WinLauncher/WinLauncher.cpp: Removed InitInstance.
      (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
      done by the now-removed InitInstance function.
      (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
      calls. Merged code from InitInstance into this function, and change to use the global hInst
      variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
      function, which corresponds to WinLauncher.exe.
      
      * WinLauncher/WinLauncher.vcproj:
      * WinLauncher/WinLauncherCommon.vsprops:
      Changed to build WinLauncher.dll instead of WinLauncher.exe.
      
      * WinLauncher/WinLauncherLauncher.rc: Added.
      * WinLauncher/WinLauncherLauncherResource.h: Added.
      This just references the WinLauncher.ico file to set the application icon (though it looks
      like that's a default icon).
      
      * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
      but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
      
      * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
      * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
      * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
      * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
      * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
      * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
      * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
      
      * win/DLLLauncher/DLLLauncherMain.cpp: Added.
      (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
      program if it detects heap corruption.
      (getStringValue): Helper function to read a string value from the registry.
      (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
      application from the registry.
      (appleApplicationSupportDirectory): Helper function to return the path to the Apple
      Application Support directory.
      (copyEnvironmentVariable): Helper function to copy an environment variable's value.
      (prependPath): Helper function to prepend a directory to the PATH.
      (fatalError): Helper function to display an error to the user.
      (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
      dllLauncherEntryPoint function.
      
      Source/WebKit/win:
      
      Add WinLauncherLauncher to WebKit.sln
      
      It builds just after WinLauncher.
      
      * WebKit.vcproj/WebKit.sln: Added WinLauncherLauncher.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c6ff807
    • antti@apple.com's avatar
      Improve SelectorChecker::determineSelectorScopes · f84ff12c
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75619
      
      Reviewed by Andreas Kling.
      
      SelectorChecker::determineSelectorScopes currently searches to the end of the selector chain and
      then sees if the last one is suitable to be a scope. A better algorithm will find a scope from
      anywhere in the chain.
              
      With this patch we search the whole chain for potential scopes. We now prefer id scopes
      over class scopes. Scopes can be found for rules using sibling selectors too.
              
      On both engadget.com and nytimes.com, we can now skip one more full style recalc due to 
      the improved stylesheet analysis. 
      
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::determineSelectorScopes):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f84ff12c
    • carlosgc@webkit.org's avatar
      [GTK] Use the default screen in PlatformScreenGtk methods when they are called with a NULL widget · 777f998f
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75620
      
      Reviewed by Philippe Normand.
      
      We are currently retuning an empty rectangle for
      screenRect/screenAvailableRect and 0 for getVisual.
      
      * platform/gtk/PlatformScreenGtk.cpp:
      (WebCore::getVisual):
      (WebCore::screenRect):
      (WebCore::screenAvailableRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      777f998f
    • hclam@chromium.org's avatar
      Not reviewed. Update Chromium port test expectations. · 6e08867a
      hclam@chromium.org authored
      * platform/chromium-win-xp/fast/backgrounds/animated-svg-as-mask-expected.png: Removed.
      * platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Removed.
      * platform/chromium-win-xp/svg/as-background-image/animated-svg-as-background-expected.png: Removed.
      * platform/chromium-win-xp/svg/custom/glyph-selection-lang-attribute-expected.png: Removed.
      * platform/chromium-win-xp/svg/text/text-align-01-b-expected.png: Removed.
      * platform/chromium-win-xp/svg/text/text-path-01-b-expected.png: Removed.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e08867a
    • commit-queue@webkit.org's avatar
      [Chromium] Remove WebSettings::setAcceleratedDrawingEnabled from public API. · c9116ca0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74125
      
      Patch by David Reveman <reveman@chromium.org> on 2012-01-05
      Reviewed by James Robinson.
      
      Remove setAcceleratedDrawingEnabled method from WebSettings class.
      
      * public/WebSettings.h:
      * src/WebSettingsImpl.cpp:
      * src/WebSettingsImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9116ca0
    • commit-queue@webkit.org's avatar
      [Chromium] Expected test failures after Skia is rolled to 2918 · d6fabf9e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75019
      
      Fixed now that Skia has rolled past r2936.
      
      Unreviewed Chromium port test expectations update.
      
      Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-05
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6fabf9e
    • hclam@chromium.org's avatar
      Unreviewed. Build fix. · 38ea0a89
      hclam@chromium.org authored
      Adding missing const_cast<> to fix compilation failures due to r104143.
      
      * platform/audio/VectorMath.cpp:
      (WebCore::VectorMath::zvmul):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38ea0a89
    • abarth@webkit.org's avatar
      Move Gamepad declarations from Navigator.idl into Modules/gamepad · 75d123ee
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75559
      
      Reviewed by Eric Seidel.
      
      This patch moves the gamepad-related declarations in Navigator.idl into
      Modules/gamepad.  The next step is to move the state into
      Modules/gamepad as well.
      
      * Modules/gamepad/NavigatorGamepad.cpp: Added.
      (WebCore::NavigatorGamepad::NavigatorGamepad):
      (WebCore::NavigatorGamepad::~NavigatorGamepad):
      (WebCore::NavigatorGamepad::webkitGamepads):
      * Modules/gamepad/NavigatorGamepad.h: Added.
      * Modules/gamepad/NavigatorGamepad.idl: Added.
      * WebCore.gypi:
      * page/Navigator.cpp:
      (WebCore::Navigator::gamepads):
      * page/Navigator.h:
      * page/Navigator.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75d123ee
    • carlosgc@webkit.org's avatar
      [GTK] Add methods to get/set the WebView zoom level to WebKit2 GTK+ API · 7f35c72f
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75248
      
      Reviewed by Gustavo Noronha Silva.
      
      It uses the page zoom factor unconditionally for now.
      
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkitWebViewSetProperty):
      (webkitWebViewGetProperty):
      (webkit_web_view_class_init): Add WebKitWebView:zoom-level
      property.
      (webkit_web_view_set_zoom_level): Set current zoom level.
      (webkit_web_view_get_zoom_level): Get current zoom level.
      * UIProcess/API/gtk/WebKitWebView.h:
      * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
      * UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
      (testWebViewZoomLevel):
      (beforeAll):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f35c72f
    • alexis.menard@openbossa.org's avatar
      getComputedStyle for border-image is not implemented. · 11fa146e
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75347
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Implement getComputedStyle for border-color.
      
      fast/css/getComputedStyle/computed-style-border-image.html was extended to cover the
      new feature.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      LayoutTests:
      
      Extend existing test to cover that we return correct values for border-image.
      
      * fast/css/getComputedStyle/computed-style-border-image-expected.txt:
      * fast/css/getComputedStyle/computed-style-border-image.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11fa146e
    • commit-queue@webkit.org's avatar
      Add a SSE2 optimized function zvmul in VectorMatch · f5f5b9c8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74842
      
      Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-01-05
      Reviewed by Kenneth Russell.
      
      Use zvmul in FFTFrameFFMPEG.cpp::multiply() and FFTFrameMac.cpp::multiply().
      
      * platform/audio/VectorMath.cpp:
      (WebCore::VectorMath::zvmul):
      * platform/audio/VectorMath.h:
      * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:
      (WebCore::FFTFrame::multiply):
      * platform/audio/mac/FFTFrameMac.cpp:
      (WebCore::FFTFrame::multiply):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5f5b9c8
    • hclam@chromium.org's avatar
      Unreviewed. Build fix for Chromium Mac Clang build. · 23daad6f
      hclam@chromium.org authored
      Push using namespace WTF to .cpp file from .h file.
      
      * platform/text/TextCodecASCIIFastPath.h:
      * platform/text/TextCodecLatin1.cpp:
      * platform/text/TextCodecUTF8.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23daad6f
    • ossy@webkit.org's avatar
      [Qt][WK2]REGRESSION(r104068): It made editing/pasteboard/copy-in-password-field.html fail · 936a5815
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75615
      
      Unreviewed gardening.
      
      * platform/qt-wk2/Skipped: Skip editing/pasteboard/copy-in-password-field.html to paint the bot green.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      936a5815
    • commit-queue@webkit.org's avatar
      WebKit adds vertical paddings and borders to the fixed width of CSS tables · 6e1c5625
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74955
      
      Patch by Max Vujovic <mvujovic@adobe.com> on 2012-01-05
      Reviewed by Julien Chaffraix.
      
      Source/WebCore:
      
      Test: fast/table/css-table-width.html
      
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::computeLogicalWidth):
      
          Changed the width calculation for CSS tables to take into account horizontal
          paddings and borders instead of vertical paddings and borders.
      
      LayoutTests:
      
      Added tests to check that the fixed width style is applied correctly to
      CSS tables with respect to table paddings and borders.
      
      * fast/table/css-table-width-expected.txt: Added.
      * fast/table/css-table-width.html: Added.
      * fast/table/script-tests/css-table-width.js: Added.
      (computeCSSTableOffsetWidth):
      (computeCSSTableOffsetHeight):
      (computeCSSTableProperty):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e1c5625
    • peter@chromium.org's avatar
      [Chromium] Upstream the RenderTheme and ScrollbarTheme for Android · e5a68bb9
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74614
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Upstream the RenderTheme and ScrollbarTheme for Android. These are
      mostly derived from their Linux variants.
      
      RenderThemeChromiumAndroid inherits from RenderThemeChromiumLinux and
      only overrides the three methods which have different behavior.
      Scrollbars will be drawn in the threaded compositor for Android (which
      will be upstreamed later), but for increased layout test parity we'll
      match Chromium-Linux.
      
      No new tests. This code will be exercised by existing layout tests, and
      by manually verifying that theme parts render as expected.
      
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      * platform/chromium/ScrollbarThemeChromiumAndroid.cpp: Added.
      (WebCore::ScrollbarTheme::nativeTheme):
      (WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
      (WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
      (WebCore::ScrollbarThemeChromiumAndroid::shouldCenterOnThumb):
      (WebCore::ScrollbarThemeChromiumAndroid::buttonSize):
      (WebCore::ScrollbarThemeChromiumAndroid::minimumThumbLength):
      * platform/chromium/ScrollbarThemeChromiumAndroid.h: Added.
      * rendering/RenderThemeChromiumAndroid.cpp: Added.
      (WebCore::RenderThemeChromiumAndroid::create):
      (WebCore::RenderTheme::themeForPage):
      (WebCore::RenderThemeChromiumAndroid::~RenderThemeChromiumAndroid):
      (WebCore::RenderThemeChromiumAndroid::systemColor):
      (WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
      * rendering/RenderThemeChromiumAndroid.h: Added.
      * rendering/RenderThemeChromiumLinux.cpp:
      * rendering/RenderThemeChromiumLinux.h:
      
      Source/WebKit/chromium:
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setScrollbarColors):
      (WebKit::WebViewImpl::setSelectionColors):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5a68bb9
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening. Skip a new failing test. · 1e8451b5
      ossy@webkit.org authored
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e8451b5
    • fsamuel@chromium.org's avatar
      [Chromium] Expose Fixed Position Layout to WebViewImpl · a9db01ae
      fsamuel@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75556
      
      Reviewed by Darin Fisher.
      
      * public/WebView.h:
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::shouldLayoutFixedElementsRelativeToFrame):
      (WebKit::WebViewImpl::setShouldLayoutFixedElementsRelativeToFrame):
      * src/WebViewImpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9db01ae
    • ossy@webkit.org's avatar
      unshift/pop fifo may consume excessive memory · 5ff458cf
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75588
      
      Reviewed by Zoltan Herczeg.
      
      Buildfix after r104120.
      
      * runtime/JSArray.cpp: Remove useless asserts, baecause unsigned expression >= 0 is always true
      (JSC::JSArray::unshiftCount):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ff458cf
    • zherczeg@webkit.org's avatar
      Unreviewed gardening after r104134. · 2b791cc0
      zherczeg@webkit.org authored
      * wtf/Assertions.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b791cc0
    • zherczeg@webkit.org's avatar
      Unreviewed gardening after r75605. · 06a8acdd
      zherczeg@webkit.org authored
      Rubber stamped by NOBODY Csaba Osztrogonác.
      
      * wtf/Assertions.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06a8acdd
    • commit-queue@webkit.org's avatar
      Source/WebCore: Fix potential superlinear runtime of multiple indirect adjenceny combinators. · 74dc5b69
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75083
      
      Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-01-05
      Reviewed by Antti Koivisto.
      
      A sequence of indirect adjencency combinator such as "li ~ li ~ la" could with the
      former algorithm potentially do an quadratic number of element matches.
      The recursive matching algorithm now detects cases where all siblings have
      failed one indirect sibling match and fails the entire selector.
      
      Test: perf/nested-combined-selectors.html
      
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkSelector): Return SelectorFailsAllSiblings when
      all siblings have failed a selector component.
      * css/SelectorChecker.h: Add SelectorFailsAllSiblings enum value
      
      LayoutTests:        Test of styling performance of selectors with multiple indirect combinators
             https://bugs.webkit.org/show_bug.cgi?id=75083
      
             Reviewed by Antti Koivisto.
      
             * perf/nested-combined-selectors.html: Added.
      
      Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-01-05
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74dc5b69
    • haraken@chromium.org's avatar
      prepare-ChangeLog cannot parse python code that nests classes and defs · 74d3a16e
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75524
      
      Reviewed by Ryosuke Niwa.
      
      This patch fixes the python parser of prepare-ChangeLog so that it can parse
      python code that nests classes and defs, like this:
      
      class C:
          pass
          def f():
              pass
          pass
      
      Also, this patch fixes the python parser so that it inserts a dummy line
      at the end of the file to pop out all popped scopes.
      
      * Scripts/prepare-ChangeLog:
      (get_function_line_ranges_for_python):
      
      * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
      Added test cases that nest classes and defs.
      (func7):
      (func7.func8):
      (func7.func8.func9):
      (Class2):
      (Class2.Class3):
      (Class2.Class3.Class4):
      (Class5):
      (Class5.func10):
      (Class5.func11):
      * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74d3a16e
    • kling@webkit.org's avatar
      InspectorStyleSheet: Avoid cloning CSSRuleLists. · 335d34ed
      kling@webkit.org authored
      <http://webkit.org/b/75603>
      
      Reviewed by Ryosuke Niwa.
      
      Don't filter out @charset rules from CSSRuleLists. This was forcing us to clone
      the stylesheet rule list, and is unnecessary since InspectorStyleSheet disregards
      any rule that isn't either a style rule or a rule with an internal rule list.
      
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::asCSSRuleList):
      (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
      
          Don't pass omitCharsetRules=true to the CSSRuleList constructor.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      335d34ed