1. 07 Feb, 2006 23 commits
    • mjs's avatar
      Rubber stamped by Hyatt. · 9156f8e5
      mjs authored
              - move kwq/KWQString.mm to platform/QString.cpp, split out nonportable parts, speculative
              port of one remaining nonportable bit to windows.
      
              * ForwardingHeaders/qstring.h:
              * WebCore+SVG/KDOMSettings.h:
              * WebCore+SVG/kdom.h:
              * WebCore.xcodeproj/project.pbxproj:
              * css/cssparser.h:
              * css/cssstyleselector.cpp:
              * kcanvas/KCanvasResources.h:
              * kcanvas/KCanvasTreeDebug.h:
              * khtml/ecma/kjs_window.h:
              * khtml/editing/html_interchange.cpp:
              * khtml/editing/visible_position.h:
              * khtml/editing/visible_text.h:
              * khtml/editing/visible_units.cpp:
              * khtml/html/FormDataList.h:
              * khtml/html/html_objectimpl.cpp:
              * khtml/html/htmltokenizer.h:
              * khtml/misc/decoder.h:
              * khtml/misc/formdata.h:
              * khtml/xbl/xbl_protohandler.cpp:
              * khtml/xml/dom_position.cpp:
              * khtml/xsl/xslt_processorimpl.h:
              * ksvg2/svg/SVGHelper.h:
              * ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
              * ksvg2/svg/SVGStyleElementImpl.cpp:
              * ksvg2/svg/SVGURIReferenceImpl.h:
              * ksvg2/svg/svgpathparser.cpp:
              * kwq/KWQAccObjectCache.mm:
              * kwq/KWQBuffer.h:
              * kwq/KWQEvent.h:
              * kwq/KWQFont.mm:
              * kwq/KWQFontFamily.h:
              * kwq/KWQFontMetrics.h:
              * kwq/KWQKConfigBase.h:
              * kwq/KWQKDebug.h:
              * kwq/KWQKHTMLSettings.h:
              * kwq/KWQKJobClasses.h:
              * kwq/KWQKJobClasses.mm:
              * kwq/KWQKLocale.mm:
              * kwq/KWQKSSLKeyGen.mm:
              * kwq/KWQKURL.h:
              * kwq/KWQLineEdit.h:
              * kwq/KWQRegExp.h:
              * kwq/KWQRenderTreeDebug.h:
              * kwq/KWQString.h: Removed.
              * kwq/KWQString.mm: Removed.
              * kwq/KWQStringList.h:
              * kwq/KWQTextCodec.h:
              * kwq/KWQTextStream.h:
              * kwq/KWQTextUtilities.mm:
              * kwq/WebCoreScriptDebugger.mm:
              * loader/Cache.h:
              * platform/Color.cpp:
              * platform/Color.h:
              * platform/QString.cpp: Added.
              (allocateHandle):
              (KWQStringData::KWQStringData):
              (QString::QString):
              (QString::insert):
              (QString::detach):
              (QString::remove):
              (QString::setLength):
              (QString::fill):
              (initializeHandleNodeBlock):
              (allocateNode):
              (freeHandle):
              * platform/QString.h: Added.
              * platform/SegmentedString.h:
              * platform/StringImpl.h:
              * platform/mac/Image.mm:
              * platform/mac/QString.mm: Added.
              (QString::setBufferFromCFString):
              (QString::fromCFString):
              (QString::fromNSString):
              (QString::getNSString):
              (QString::utf8):
              (QString::fromUtf8):
              * rendering/bidi.h:
              * rendering/break_lines.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9156f8e5
    • hyatt's avatar
      Update page directory in Win32 project to match what's there now. · 36aefb65
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36aefb65
    • mjs's avatar
      Reviewed by Adele. · 69b3b5f0
      mjs authored
              - remove all remains of old-style frame tree, ChildFrame, ObjectContents and FrameList are all gone
      
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:
              (WebCore::BrowserExtensionMac::createNewWindow):
              * khtml/ecma/kjs_window.cpp:
              (KJS::createNewWindow):
              (KJS::Window::indexGetter):
              (KJS::Window::getOwnPropertySlot):
              (KJS::WindowFunc::callAsFunction):
              (KJS::FrameArray::getValueProperty):
              (KJS::FrameArray::indexGetter):
              (KJS::FrameArray::nameGetter):
              (KJS::FrameArray::getOwnPropertySlot):
              * kwq/KWQFrame.mm:
              (QFrame::setFrameStyle):
              * page/Frame.cpp:
              (WebCore::Frame::Frame):
              (WebCore::Frame::stopLoading):
              (WebCore::Frame::clear):
              (WebCore::Frame::stopAnimations):
              (WebCore::Frame::checkCompleted):
              (WebCore::Frame::checkEmitLoadEvent):
              (WebCore::Frame::requestFrame):
              (WebCore::Frame::requestObject):
              (WebCore::Frame::loadSubframe):
              (WebCore::Frame::findFrame):
              (WebCore::Frame::frameExists):
              (WebCore::Frame::setZoomFactor):
              (WebCore::Frame::frameNames):
              (WebCore::Frame::frames):
              (WebCore::Frame::childFrameNamed):
              (WebCore::Frame::slotPartRemoved):
              (WebCore::Frame::connectChild):
              (WebCore::Frame::disconnectChild):
              (WebCore::Frame::canCachePage):
              (WebCore::Frame::setPolicyBaseURL):
              (WebCore::Frame::treeNode):
              (WebCore::Frame::frameDetached):
              * page/Frame.h:
              * page/FramePrivate.h:
              * page/FrameTreeNode.h:
              (WebCore::FrameTreeNode::name):
              (WebCore::FrameTreeNode::parent):
              (WebCore::FrameTreeNode::nextSibling):
              (WebCore::FrameTreeNode::previousSibling):
              (WebCore::FrameTreeNode::firstChild):
              (WebCore::FrameTreeNode::lastChild):
              (WebCore::FrameTreeNode::childCount):
              * page/ObjectContents.h: Removed.
              * page/Plugin.h:
              (WebCore::Plugin::view):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69b3b5f0
    • adele's avatar
      LayoutTests: · 5ac0b02e
      adele authored
             - test for 
              <rdar://problem/3727939> Safari strips \0 characters from HTML tags making them valid
      
              * fast/encoding/decoder-allow-null-chars.html
              * fast/encoding/decoder-allow-null-chars-expected.txt
      
      WebCore:
      
              Reviewed by Maciej.
      
              - Fixed <rdar://problem/3727939> Safari strips \0 characters from HTML tags making them valid 
      
              Test: fast/encoding/decoder-allow-null-chars.html
      
              * kwq/KWQTextCodec.cpp:
              (KWQTextDecoder::convertLatin1): Removed stripping of null characters
              (unwanted): ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ac0b02e
    • hyatt's avatar
      Land the skeleton of a PNG decoder for Win32. · 688bf91a
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      688bf91a
    • hyatt's avatar
      Add bindings/js/JSEvents.cpp to the win32 build. · d803c463
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d803c463
    • eseidel's avatar
      2006-02-07 Eric Seidel <eseidel@apple.com> · 28783024
      eseidel authored
              Reviewed by hyatt.
      
              Removed ImageSubset, making ImageViewer link directly to WebCore.
      
              * Viewer.vcproj:
              * WebCore.vcproj/ImageSubset: Removed.
              * WebCore.vcproj/ImageSubset/ImageSubset.vcproj: Removed.
              * WebCore.vcproj/WebCore.sln:
              * WebCore.vcproj/WebCore/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28783024
    • hyatt's avatar
      Add Image Subset of WebCore as a project to the win32 build for the Image... · 4d0b96a0
      hyatt authored
      Add Image Subset of WebCore as a project to the win32 build for the Image Viewer app to link against.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d0b96a0
    • ggaren's avatar
      Reviewed by darin. · 933626da
      ggaren authored
              - Fixed <rdar://problem/4425269> REGRESSION: wrong size pop-up when 
              downloading attachment at webmail.mac.com (6882)
      
              The bug was that the feature string parser didn't always initialize the
              *Set variables, so WebCore assumed a height was set when it wasn't,
              and used a garbage height variable.
      
              While there, I fixed two other bugs: (1) The parser wasn't chewing up 
              as many characters as I thought it was. (Chewing up extra characters 
              is necessary to match Win IE.) (2) We considered \t and \f to be 
              whitespace, but Win IE doesn't.
      
              * manual-tests/window-open-features-parsing.html: Added these cases,
              fixed up comments.
      
              * bridge/BrowserExtension.h: Cleaned up declaration order a bit.
              * khtml/ecma/kjs_window.cpp:
              (KJS::isSeparator): New function, tells you if a character is a
              separator
              (KJS::parseWindowFeatures): Always initialize *Set to false. Drive
              parsing based on invalid characters ('separators') rather than valid 
              ones, to match Win IE.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      933626da
    • darin's avatar
      Set more MIME types. · ddec2334
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddec2334
    • darin's avatar
      Set a bunch of MIME types. · 0fbb69b2
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fbb69b2
    • ap's avatar
      2006-02-07 Alexey Proskuryakov <ap@nypop.com> · 620e5b45
      ap authored
              Reviewed by Timothy.
      
              Convert JavaScript objects to appropriate AppleScript types, instead of only strings
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7012
      
      WebKit:
              * WebView/WebView.m:
              (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Added.
              * WebView/WebViewPrivate.h:
      
      WebCore:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (aeDescFromJSValue): Added.
              (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): Added.
      
      WebKitTools:
              * DumpRenderTree/AppleScriptController.h: Added.
              * DumpRenderTree/AppleScriptController.m: Added.
              * DumpRenderTree/DumpRenderTree.m:
              (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      
      LayoutTests:
              * fast/AppleScript: Added.
              * fast/AppleScript/001-expected.txt: Added.
              * fast/AppleScript/001.html: Added.
              * fast/AppleScript/array-expected.txt: Added.
              * fast/AppleScript/array.html: Added.
              * fast/AppleScript/date-expected.txt: Added.
              * fast/AppleScript/date.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      620e5b45
    • hyatt's avatar
      31af4586
    • hyatt's avatar
      FInal image renaming for Win32 gif stuff. · 2d1e7f16
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d1e7f16
    • hyatt's avatar
      Rename ImageDecoder to ImageSource. · 5ee85f7f
      hyatt authored
              Reviewed by mjs
      
              * WebCore.xcodeproj/project.pbxproj:
              * platform/Image.cpp:
              (WebCore::Image::cacheFrame):
              (WebCore::Image::size):
              (WebCore::Image::setNativeData):
              (WebCore::Image::frameCount):
              (WebCore::Image::isSizeAvailable):
              * platform/Image.h:
              * platform/ImageDecoder.h: Removed.
              * platform/ImageSource.h: Added.
              * platform/cairo/ImageCairo.cpp:
              (WebCore::Image::drawInRect):
              * platform/cairo/ImageDecoderCairo.cpp: Removed.
              * platform/cairo/ImageSourceCairo.cpp: Added.
              (WebCore::createDecoderPlugin):
              (WebCore::ImageSource::ImageSource):
              (WebCore::ImageSource::~ImageSource):
              (WebCore::ImageSource::initialized):
              (WebCore::ImageSource::setData):
              (WebCore::ImageSource::isSizeAvailable):
              (WebCore::ImageSource::size):
              (WebCore::ImageSource::repetitionCount):
              (WebCore::ImageSource::frameCount):
              (WebCore::ImageSource::createFrameAtIndex):
              (WebCore::ImageSource::frameDurationAtIndex):
              * platform/mac/Image.mm:
              (WebCore::Image::drawInRect):
              * platform/mac/ImageData.mm: Removed.
              * platform/mac/ImageDecoder.cpp: Removed.
              * platform/mac/ImageSource.cpp: Added.
              (WebCore::ImageSource::ImageSource):
              (WebCore::ImageSource::~ImageSource):
              (WebCore::ImageSource::initialized):
              (WebCore::ImageSource::setData):
              (WebCore::ImageSource::isSizeAvailable):
              (WebCore::ImageSource::size):
              (WebCore::ImageSource::repetitionCount):
              (WebCore::ImageSource::frameCount):
              (WebCore::ImageSource::createFrameAtIndex):
              (WebCore::ImageSource::frameDurationAtIndex):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ee85f7f
    • hyatt's avatar
      Combine ImageData and Image (the result ends up in Image). · 058251ef
      hyatt authored
              Reviewed by mjs
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOM.mm:
              (-[DOMElement _image]):
              (-[DOMElement _imageTIFFRepresentation]):
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::fileWrapperForElement):
              * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
              (KCanvasFEImageQuartz::getCIFilter):
              * khtml/ecma/kjs_html.cpp:
              (KJS::KJS::Context2DFunction::callAsFunction):
              (KJS::drawPattern):
              (KJS::_rh):
              (KJS::ImagePattern::createPattern):
              * kwq/KWQClipboard.mm:
              (WebCore::KWQClipboard::dragNSImage):
              * kwq/KWQCursor.h:
              * kwq/KWQCursor.mm:
              (WebCore::createCustomCursor):
              (WebCore::QCursor::QCursor):
              * kwq/KWQPainter.h:
              * kwq/KWQPainter.mm:
              (WebCore::QPainter::drawImageAtPoint):
              (WebCore::QPainter::drawImageInRect):
              (WebCore::QPainter::drawImage):
              (WebCore::QPainter::drawFloatImage):
              (WebCore::QPainter::drawTiledImage):
              (WebCore::QPainter::drawScaledAndTiledImage):
              * loader/CachedImage.cpp:
              (WebCore::CachedImage::image):
              * loader/CachedImage.h:
              * page/FrameView.cpp:
              (WebCore::selectCursor):
              * platform/Image.cpp:
              (WebCore::Image::Image):
              (WebCore::Image::~Image):
              (WebCore::Image::invalidateData):
              (WebCore::Image::cacheFrame):
              (WebCore::Image::isNull):
              (WebCore::Image::size):
              (WebCore::Image::setData):
              (WebCore::Image::setNativeData):
              (WebCore::Image::frameCount):
              (WebCore::Image::isSizeAvailable):
              (WebCore::Image::frameAtIndex):
              (WebCore::Image::frameDurationAtIndex):
              (WebCore::Image::shouldAnimate):
              (WebCore::Image::startAnimation):
              (WebCore::Image::stopAnimation):
              (WebCore::Image::resetAnimation):
              (WebCore::Image::advanceAnimation):
              (WebCore::Image::rect):
              * platform/Image.h:
              (KXMLCore::):
              (WebCore::FrameData::m_duration):
              (WebCore::FrameData::~FrameData):
              (WebCore::Image::currentFrame):
              (WebCore::Image::animationObserver):
              (WebCore::Image::setIsPDF):
              * platform/ImageData.cpp: Removed.
              * platform/ImageData.h: Removed.
              * platform/cairo/ImageCairo.cpp:
              (WebCore::FrameData::clear):
              (WebCore::Image::initNativeData):
              (WebCore::Image::destroyNativeData):
              (WebCore::Image::invalidateNativeData):
              (WebCore::Image::drawInRect):
              (WebCore::Image::tileInRect):
              (WebCore::Image::scaleAndTileInRect):
              * platform/mac/Image.mm:
              (WebCore::FrameData::clear):
              (WebCore::Image::initNativeData):
              (WebCore::Image::destroyNativeData):
              (WebCore::Image::invalidateNativeData):
              (WebCore::Image::loadResource):
              (WebCore::Image::supportsType):
              (WebCore::Image::checkForSolidColor):
              (WebCore::Image::getTIFFRepresentation):
              (WebCore::Image::getNSImage):
              (WebCore::Image::getCGImageRef):
              (WebCore::Image::drawInRect):
              (WebCore::drawPattern):
              (WebCore::Image::tileInRect):
              (WebCore::Image::scaleAndTileInRect):
              * rendering/render_image.cpp:
              (WebCore::RenderImage::imageChanged):
              (WebCore::RenderImage::resetAnimation):
              (WebCore::RenderImage::paint):
              (WebCore::RenderImage::nullImage):
              * rendering/render_image.h:
              (WebCore::RenderImage::image):
              * rendering/render_list.cpp:
              (RenderListItem::getAbsoluteRepaintRect):
              (RenderListMarker::paint):
              (RenderListMarker::calcMinMaxWidth):
              * rendering/render_object.cpp:
              (WebCore::RenderObject::paintBorderImage):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      058251ef
    • mjs's avatar
      Reviewed by Darin. Landed by Maciej. · 59d61a92
      mjs authored
              
              - Several fixes to the site
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7105
      
              * blog/wp-content/themes/webkit/style.css:
              * index.html:
              * quality/bugwriting.html:
              * quality/reduction.html:
              * webkitdev.css:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59d61a92
    • mjs's avatar
      LayoutTests: · 3348998b
      mjs authored
              Reviewed by Eric.
              
              - test case that verifies that <object> containing html is treated
                like <iframe> in various respects
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7125
      
              * fast/dom/HTMLObjectElement/object-as-frame-expected.txt: Added.
              * fast/dom/HTMLObjectElement/object-as-frame.html: Added.
              
              - updated this test to reflect that the onload event now fires for iframes,
                including ones with empty src
              http://bugzilla.opendarwin.org/show_bug.cgi?id=3609
      
              * fast/events/event-targets-expected.checksum: Removed.
              * fast/events/event-targets-expected.png: Removed.
              * fast/events/event-targets-expected.txt:
              * fast/events/event-targets.html:
      
      WebCore:
      
              Reviewed by Eric.
      
              - fixed "remove frame, renderer and completed flag from ChildFrame, make Frame track these"
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7125
              
              - fixed "onload event never called for iframe element with emtpy or about:blank src"
              http://bugzilla.opendarwin.org/show_bug.cgi?id=3609
              
              * bridge/mac/MacFrame.h:
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::MacFrame): pass along renderer
              (WebCore::MacFrame::nextKeyViewInFrameHierarchy): get owner element in newfangled way
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge removeChild:]): don't mess with renderer
              (-[WebCoreFrameBridge init]): call new designated initializer
              (-[WebCoreFrameBridge initWithRenderer:]): new designated initializer
              (-[WebCoreFrameBridge dealloc]): don't mess with renderer
              (-[WebCoreFrameBridge finalize]): ditto
              (-[WebCoreFrameBridge installInFrame:]): ditto
              * page/Frame.cpp:
              (WebCore::FrameList::find): get name from frame not ChildFrame
              (WebCore::Frame::init): take renderer parameter
              (WebCore::Frame::clear): clear m_plugins, not m_objects
              (WebCore::Frame::childBegin): updated comment
              (WebCore::Frame::stop): add check-completed for documentless case here
              (WebCore::Frame::checkCompleted): don't track separate completed flag
              in ChildFrame, use the sub Frame object's own
              (WebCore::Frame::checkEmitLoadEvent): ditto
              (WebCore::Frame::requestFrame): don't store renderer and name in ChildFrame,
              instead pass them along
              (WebCore::Frame::requestObject): ditto above
              (WebCore::Frame::loadPlugin): expect renderer parameter
              (WebCore::Frame::loadSubframe): expect renderer and name parameters
              (WebCore::Frame::slotChildStarted): don't mess with ChildFrame
              (WebCore::Frame::slotChildCompleted): ditto
              (WebCore::Frame::childFrame): don't check m_objects
              (WebCore::Frame::frameExists): fix spacing, remove obsolete check and comment
              (WebCore::Frame::frameNames): get name from frame
              (WebCore::Frame::ownerElement): simplify a lot since the Frame knows its owner
              renderer now
              (WebCore::Frame::ownerRenderer): added
              (WebCore::Frame::canCachePage): check m_plugins not m_objects
              * page/Frame.h:
              * page/FramePrivate.h:
              (WebCore::ChildFrame): Remove constructor, most fields.
              (WebCore::FramePrivate::FramePrivate): Pass ownerRenderer
              * rendering/render_frames.cpp:
              (WebCore::RenderPartObject::updateWidget): Make sure to pass name attr
              to requestObject.
      
      WebKit:
      
              Reviewed by Eric.
      
              - fixed "remove frame, renderer and completed flag from ChildFrame, make Frame track these"
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7125
              
              - fixed "onload event never called for iframe element with emtpy or about:blank src"
              http://bugzilla.opendarwin.org/show_bug.cgi?id=3609
      
              * WebCoreSupport/WebFrameBridge.h:
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge initWithPage:webView:renderer:frameName:view:]): Pass along renderer.
              (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Pass along renderer.
              * WebCoreSupport/WebPageBridge.m:
              (-[WebPageBridge initWithMainFrameName:webView:frameView:]): Pass null for renderer.
              * WebView/WebView.m:
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3348998b
    • adele's avatar
      LayoutTests: · b2f91888
      adele authored
              Reviewed by Maciej.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6944
                REGRESSION: crash when loading page w/ <link> that has a DOMSubtreeModified event listener
      
              * fast/events/event-listener-on-link.html: Added.
              * fast/events/event-listener-on-link-expected.txt: Added.
              * fast/events/event-listener-on-link-expected.png: Added.
              * fast/events/event-listener-on-link-expected.checksum: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6944
                REGRESSION: crash when loading page w/ <link> that has a DOMSubtreeModified event listener
      
              Test: fast/events/event-listener-on-link.html
      
              * khtml/xml/dom_elementimpl.h: Added createAttrImplIfNeeded, removed allocateImpl, 
               changed AttrImpl contructor to remove createTextChild bool, added createTextChild method, 
               changed getAttributeNode, getAttributeNodeNS, getNamedItem, getNamedItemNS, and item to return PassRefPtrs.
              (DOM::ElementImpl::getAttributeNode):
              * khtml/xml/dom_elementimpl.cpp:
              (WebCore::AttributeImpl::createAttrImplIfNeeded): New method to replace allocateImpl.  
               This will use a RefPtr for the AttrImpl, check for an existing AttrImpl, create one if there isn't one,
               and will call the new createTextChild.
              (WebCore::AttrImpl::AttrImpl):  Moved creation of text child to new createTextChild method.  
               If done in the constructor, the ref count is still 0, and the act of appending the text node 
               could cause the AttrImpl to be destroyed.
              (WebCore::AttrImpl::createTextChild): Moved code from AttrImpl contructor.  
               Also, I've added an assert to make sure that any callers of this have ref'd the AttrImpl.
              (WebCore::AttrImpl::cloneNode): Used RefPtr instead of PassRefPtr, and then called release() on it before returning.
              (WebCore::ElementImpl::cloneNode): ditto.
              (WebCore::ElementImpl::getAttributeNodeNS): Changed return type to PassRefPtr.
              (WebCore::NamedAttrMapImpl::getNamedItemNS): ditto.
              (WebCore::NamedAttrMapImpl::getNamedItem): ditto. Changed use of allocateImpl to createAttrImplIfNeeded
              (WebCore::NamedAttrMapImpl::setNamedItem): ditto.
              (WebCore::NamedAttrMapImpl::removeNamedItem): ditto.
              (WebCore::NamedAttrMapImpl::item): ditto.
              * khtml/xml/DocumentImpl.cpp:
              (WebCore::DocumentImpl::createAttributeNS): Changed return type to PassRefPtr and removed bool from AttrImpl contructor call.
              * khtml/xml/DocumentImpl.h: Now returns a PassRefPtr for createAttribute and createAttributeNS. 
              (WebCore::DocumentImpl::createAttribute):
              * khtml/xml/NamedNodeMapImpl.h: Now returns a PassRefPtr for getNamedItem, getNamedItemNS, and item.
              (WebCore::NamedNodeMapImpl::getNamedItem):
              * bindings/objc/DOM.mm:
              (-[DOMNamedNodeMap getNamedItem:]): Call get() since the methods discussed above now return PassRefPtrs.
              (-[DOMNamedNodeMap item:]): ditto.
              (-[DOMNamedNodeMap getNamedItemNS::]): ditto.
              (-[DOMDocument createAttribute:]): ditto.
              (-[DOMDocument createAttributeNS::]): ditto.
              (-[DOMElement getAttributeNode:]): ditto.
              (-[DOMElement getAttributeNodeNS::]): ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2f91888
    • mjs's avatar
      Reviewed by Darin. · b38b8459
      mjs authored
              
              - fixed 7094: onfocus/onblur on non-form-controls bubble
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7094
      
              * khtml/html/HTMLElementImpl.cpp:
              (WebCore::HTMLElementImpl::parseMappedAttribute): connect onfocus/onblur to
              focus/blur, not DOMFocusIn/DOMFocusOut
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b38b8459
    • mjs's avatar
      Reviewed by Darin. · be34e8e6
      mjs authored
              - test for 7094: onfocus/onblur on non-form-controls bubble
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7094
      
              * fast/events/div-focus-expected.txt: Added.
              * fast/events/div-focus.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be34e8e6
    • hyatt's avatar
      Fix build bustage on Mac. · 6347bec6
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6347bec6
    • hyatt's avatar
      Fix build bustage on Mac. · 371d63a3
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      371d63a3
  2. 06 Feb, 2006 17 commits