1. 16 Mar, 2011 40 commits
    • oliver@apple.com's avatar
      2011-03-15 Oliver Hunt <oliver@apple.com> · 90cf7d51
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Make Structure creation require a JSGlobalData
              https://bugs.webkit.org/show_bug.cgi?id=56438
      
              Mechanical change to make Structure::create require JSGlobalData&, and
              require all users to provide the globalData.
      
              * API/JSCallbackConstructor.h:
              (JSC::JSCallbackConstructor::createStructure):
              * API/JSCallbackFunction.h:
              (JSC::JSCallbackFunction::createStructure):
              * API/JSCallbackObject.h:
              (JSC::JSCallbackObject::createStructure):
              * API/JSContextRef.cpp:
              * JavaScriptCore.exp:
              * debugger/DebuggerActivation.cpp:
              (JSC::DebuggerActivation::DebuggerActivation):
              * debugger/DebuggerActivation.h:
              (JSC::DebuggerActivation::createStructure):
              * jit/JITStubs.cpp:
              (JSC::DEFINE_STUB_FUNCTION):
              * jsc.cpp:
              (GlobalObject::GlobalObject):
              (functionRun):
              (jscmain):
              * runtime/Arguments.h:
              (JSC::Arguments::createStructure):
              * runtime/ArrayPrototype.h:
              (JSC::ArrayPrototype::createStructure):
              * runtime/BooleanObject.h:
              (JSC::BooleanObject::createStructure):
              * runtime/DateInstance.h:
              (JSC::DateInstance::createStructure):
              * runtime/DatePrototype.h:
              (JSC::DatePrototype::createStructure):
              * runtime/ErrorInstance.h:
              (JSC::ErrorInstance::createStructure):
              * runtime/Executable.h:
              (JSC::ExecutableBase::createStructure):
              (JSC::EvalExecutable::createStructure):
              (JSC::ProgramExecutable::createStructure):
              (JSC::FunctionExecutable::createStructure):
              * runtime/FunctionPrototype.h:
              (JSC::FunctionPrototype::createStructure):
              * runtime/GetterSetter.h:
              (JSC::GetterSetter::createStructure):
              * runtime/InternalFunction.h:
              (JSC::InternalFunction::createStructure):
              * runtime/JSAPIValueWrapper.h:
              (JSC::JSAPIValueWrapper::createStructure):
              * runtime/JSActivation.h:
              (JSC::JSActivation::createStructure):
              * runtime/JSArray.cpp:
              (JSC::JSArray::JSArray):
              * runtime/JSArray.h:
              (JSC::JSArray::createStructure):
              * runtime/JSByteArray.cpp:
              (JSC::JSByteArray::createStructure):
              * runtime/JSByteArray.h:
              (JSC::JSByteArray::JSByteArray):
              * runtime/JSCell.h:
              (JSC::JSCell::JSCell::createDummyStructure):
              * runtime/JSFunction.h:
              (JSC::JSFunction::createStructure):
              * runtime/JSGlobalData.cpp:
              (JSC::JSGlobalData::storeVPtrs):
              (JSC::JSGlobalData::JSGlobalData):
              * runtime/JSGlobalObject.cpp:
              (JSC::JSGlobalObject::reset):
              * runtime/JSGlobalObject.h:
              (JSC::JSGlobalObject::JSGlobalObject):
              (JSC::JSGlobalObject::createStructure):
              * runtime/JSNotAnObject.h:
              (JSC::JSNotAnObject::createStructure):
              * runtime/JSONObject.h:
              (JSC::JSONObject::createStructure):
              * runtime/JSObject.cpp:
              (JSC::JSObject::createInheritorID):
              * runtime/JSObject.h:
              (JSC::JSObject::createStructure):
              (JSC::JSNonFinalObject::createStructure):
              (JSC::JSFinalObject::createStructure):
              (JSC::createEmptyObjectStructure):
              (JSC::JSObject::inheritorID):
              * runtime/JSObjectWithGlobalObject.h:
              (JSC::JSObjectWithGlobalObject::createStructure):
              * runtime/JSPropertyNameIterator.h:
              (JSC::JSPropertyNameIterator::createStructure):
              * runtime/JSStaticScopeObject.h:
              (JSC::JSStaticScopeObject::createStructure):
              * runtime/JSString.h:
              (JSC::RopeBuilder::createStructure):
              * runtime/JSVariableObject.h:
              (JSC::JSVariableObject::createStructure):
              * runtime/JSWrapperObject.h:
              (JSC::JSWrapperObject::createStructure):
              * runtime/JSZombie.h:
              (JSC::JSZombie::createStructure):
              * runtime/MathObject.h:
              (JSC::MathObject::createStructure):
              * runtime/NativeErrorConstructor.cpp:
              (JSC::NativeErrorConstructor::NativeErrorConstructor):
              * runtime/NativeErrorConstructor.h:
              (JSC::NativeErrorConstructor::createStructure):
              * runtime/NumberConstructor.h:
              (JSC::NumberConstructor::createStructure):
              * runtime/NumberObject.h:
              (JSC::NumberObject::createStructure):
              * runtime/ObjectConstructor.h:
              (JSC::ObjectConstructor::createStructure):
              * runtime/RegExpConstructor.h:
              (JSC::RegExpConstructor::createStructure):
              * runtime/RegExpObject.h:
              (JSC::RegExpObject::createStructure):
              * runtime/ScopeChain.h:
              (JSC::ScopeChainNode::createStructure):
              * runtime/StringObject.h:
              (JSC::StringObject::createStructure):
              * runtime/StringObjectThatMasqueradesAsUndefined.h:
              (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
              * runtime/StringPrototype.h:
              (JSC::StringPrototype::createStructure):
              * runtime/Structure.h:
              (JSC::Structure::create):
      2011-03-15  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Make Structure creation require a JSGlobalData
              https://bugs.webkit.org/show_bug.cgi?id=56438
      
              Mechanical change to make all structure creation pass a JSGlobalData&.
      
              * JSRun.cpp:
              (JSGlueGlobalObject::JSGlueGlobalObject):
              (JSRun::JSRun):
              * JSRun.h:
              * JSUtils.cpp:
              (getThreadGlobalObject):
              * UserObjectImp.h:
              (UserObjectImp::createStructure):
      2011-03-15  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Make Structure creation require a JSGlobalData
              https://bugs.webkit.org/show_bug.cgi?id=56438
      
              Mechanical change to make all structure creation use GlobalData
      
              * bindings/js/JSAudioConstructor.cpp:
              (WebCore::JSAudioConstructor::JSAudioConstructor):
              * bindings/js/JSAudioConstructor.h:
              (WebCore::JSAudioConstructor::createStructure):
              * bindings/js/JSDOMBinding.h:
              (WebCore::DOMObjectWithGlobalPointer::createStructure):
              (WebCore::DOMConstructorObject::createStructure):
              (WebCore::getDOMStructure):
              * bindings/js/JSDOMGlobalObject.h:
              (WebCore::JSDOMGlobalObject::createStructure):
              * bindings/js/JSDOMWindowBase.h:
              (WebCore::JSDOMWindowBase::createStructure):
              * bindings/js/JSDOMWindowShell.cpp:
              (WebCore::JSDOMWindowShell::JSDOMWindowShell):
              (WebCore::JSDOMWindowShell::setWindow):
              * bindings/js/JSDOMWindowShell.h:
              (WebCore::JSDOMWindowShell::createStructure):
              * bindings/js/JSImageConstructor.cpp:
              (WebCore::JSImageConstructor::JSImageConstructor):
              * bindings/js/JSImageConstructor.h:
              (WebCore::JSImageConstructor::createStructure):
              * bindings/js/JSImageDataCustom.cpp:
              (WebCore::toJS):
              * bindings/js/JSOptionConstructor.cpp:
              (WebCore::JSOptionConstructor::JSOptionConstructor):
              * bindings/js/JSOptionConstructor.h:
              (WebCore::JSOptionConstructor::createStructure):
              * bindings/js/JSWorkerContextBase.h:
              (WebCore::JSWorkerContextBase::createStructure):
              * bindings/js/WorkerScriptController.cpp:
              (WebCore::WorkerScriptController::initScript):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bridge/c/CRuntimeObject.h:
              (JSC::Bindings::CRuntimeObject::createStructure):
              * bridge/c/c_instance.cpp:
              (JSC::Bindings::CRuntimeMethod::createStructure):
              * bridge/jni/jsc/JavaInstanceJSC.cpp:
              (JavaRuntimeMethod::createStructure):
              * bridge/jni/jsc/JavaRuntimeObject.h:
              (JSC::Bindings::JavaRuntimeObject::createStructure):
              * bridge/objc/ObjCRuntimeObject.h:
              (JSC::Bindings::ObjCRuntimeObject::createStructure):
              * bridge/objc/objc_instance.mm:
              (ObjCRuntimeMethod::createStructure):
              * bridge/objc/objc_runtime.h:
              (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
              * bridge/runtime_array.h:
              (JSC::RuntimeArray::createStructure):
              * bridge/runtime_method.h:
              (JSC::RuntimeMethod::createStructure):
              * bridge/runtime_object.h:
              (JSC::Bindings::RuntimeObject::createStructure):
      2011-03-15  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Make Structure creation require a JSGlobalData
              https://bugs.webkit.org/show_bug.cgi?id=56438
      
              Mechanical change to make all Structure creation use a JSGlobalData&
      
              * Plugins/Hosted/ProxyInstance.mm:
              (WebKit::ProxyRuntimeMethod::createStructure):
              * Plugins/Hosted/ProxyRuntimeObject.h:
              (WebKit::ProxyRuntimeObject::createStructure):
      2011-03-15  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Make Structure creation require a JSGlobalData
              https://bugs.webkit.org/show_bug.cgi?id=56438
      
              Mechanical change to make all Structure creation use a JSGlobalData&.
      
              * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
              (WebKit::JSNPMethod::JSNPMethod):
              * WebProcess/Plugins/Netscape/JSNPMethod.h:
              (WebKit::JSNPMethod::createStructure):
              * WebProcess/Plugins/Netscape/JSNPObject.cpp:
              (WebKit::JSNPObject::JSNPObject):
              * WebProcess/Plugins/Netscape/JSNPObject.h:
              (WebKit::JSNPObject::createStructure):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90cf7d51
    • bweinstein@apple.com's avatar
      Skip plugins/refcount-leaks.html on Windows, because it is failing in release builds, · ef891620
      bweinstein@apple.com authored
      and passing in debug. This is being tracked by https://bugs.webkit.org/show_bug.cgi?id=56478.
      
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef891620
    • rniwa@webkit.org's avatar
      2011-03-16 Ryosuke Niwa <rniwa@webkit.org> · 8773632d
      rniwa@webkit.org authored
              Build fix for r81266. "expected" should appear after "mac", "unix", and "win" not before them.
      
              * editing/style/iframe-onload-crash-expected-mac.txt: Removed.
              * editing/style/iframe-onload-crash-expected-unix.txt: Removed.
              * editing/style/iframe-onload-crash-expected-win.txt: Removed.
              * editing/style/iframe-onload-crash-mac-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-mac.txt.
              * editing/style/iframe-onload-crash-unix-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-unix.txt.
              * editing/style/iframe-onload-crash-win-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-win.txt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8773632d
    • ap@apple.com's avatar
      Reviewed by Dan Bernstein. · 219a2b32
      ap@apple.com authored
              WebKit2: Sometimes Command-[ opens a new tab and loads the back page in it
              https://bugs.webkit.org/show_bug.cgi?id=56477
              <rdar://problem/8806664>
      
              * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent):
              Set NSApplication current event when re-dispatching a key event that returned from the web
              process unhandled. That way, code that looks at current event modifiers won't be confused.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      219a2b32
    • psolanki@apple.com's avatar
      Fix typo in path name. The test was just checking for onProgress was called for the content · ef426e69
      psolanki@apple.com authored
      and the error page served by Apache in this case sufficed for it to pass.
      
      Reviewed by Alexey Proskuryakov.
      
      * http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef426e69
    • psolanki@apple.com's avatar
      2011-03-16 Pratik Solanki <psolanki@apple.com> · 2102e04e
      psolanki@apple.com authored
              Reviewed by Alexey Proskuryakov.
      
              REGRESSION: Crash in adjustMIMETypeIfNecessary since r81001
              https://bugs.webkit.org/show_bug.cgi?id=56345
      
              Add test that verifies the we don't crash when an XHR response headers don't contain
              Content-Type.
      
              * http/tests/xmlhttprequest/resources/.htaccess:
              * http/tests/xmlhttprequest/resources/noContentType.asis: Added.
              * http/tests/xmlhttprequest/xmlhttprequest-no-content-type-expected.txt: Added.
              * http/tests/xmlhttprequest/xmlhttprequest-no-content-type.html: Added.
      2011-03-16  Pratik Solanki  <psolanki@apple.com>
      
              Reviewed by Alexey Proskuryakov.
      
              REGRESSION: Crash in adjustMIMETypeIfNecessary since r81001
              https://bugs.webkit.org/show_bug.cgi?id=56345
      
              Add NULL check for Content-Type header field.
      
              Test: http/tests/xmlhttprequest/xmlhttprequest-no-content-type.html
      
              * platform/network/mac/WebCoreURLResponse.mm:
              (WebCore::adjustMIMETypeIfNecessary):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2102e04e
    • leviw@chromium.org's avatar
      2011-03-16 Levi Weintraub <leviw@chromium.org> · 14f546d2
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
              https://bugs.webkit.org/show_bug.cgi?id=56407
      
              Creating three versions of the iframe-onload-crash test to cover all editing behaviors.
      
              * editing/style/iframe-onload-crash-expected-mac.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
              * editing/style/iframe-onload-crash-expected-unix.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
              * editing/style/iframe-onload-crash-expected-win.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
              * editing/style/iframe-onload-crash-expected.txt: Removed.
              * editing/style/iframe-onload-crash-mac.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
              * editing/style/iframe-onload-crash-unix.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
              * editing/style/iframe-onload-crash-win.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
              * editing/style/iframe-onload-crash.html: Removed.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/win/Skipped:
      2011-03-15  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
              https://bugs.webkit.org/show_bug.cgi?id=56407
      
              Fixing the creation of incorrect ranges from TextIterator due to passing node/offset pairs that
              weren't parent-anchored. Also changing canHaveChildrenForEditing to properly handle nodes that
              have had children appended to them that editing wouldn't normally allow.
      
              Tests: editing/style/iframe-onload-crash-mac.html
                     editing/style/iframe-onload-crash-unix.html
                     editing/style/iframe-onload-crash-win.html
      
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::rangeFromLocationAndLength): Passing parent-anchored values to range.
              * editing/htmlediting.cpp:
              (WebCore::canHaveChildrenForEditing): Adding a condition that the nodes don't already have children
              for hr and datagrid, as you can append any node to another using javascript.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14f546d2
    • mnaganov@chromium.org's avatar
      2011-03-16 Mikhail Naganov <mnaganov@chromium.org> · 82aef340
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              [Chromium] Report object groups and single DOM-related objects
              to the new heap profiler.
              https://bugs.webkit.org/show_bug.cgi?id=53659
      
              * Android.v8bindings.mk:
              * WebCore.gypi:
              * WebCore.pro:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/RetainedDOMInfo.cpp: Added.
              (WebCore::RetainedDOMInfo::RetainedDOMInfo):
              * bindings/v8/RetainedDOMInfo.h: Added.
              * bindings/v8/RetainedObjectInfo.h: Added.
              * bindings/v8/ScriptProfiler.cpp:
              (WebCore::retainedDOMInfo):
              (WebCore::ScriptProfiler::initialize):
              * bindings/v8/ScriptProfiler.h:
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::V8DOMWindowShell::initContextIfNeeded):
              * bindings/v8/V8GCController.cpp:
              (WebCore::GroupId::GrouperItem::GrouperItem):
              (WebCore::GroupId::GrouperItem::groupId):
              (WebCore::GroupId::GrouperItem::createRetainedObjectInfo):
              (WebCore::calculateGroupId):
              (WebCore::GrouperVisitor::visitDOMWrapper):
              (WebCore::GrouperVisitor::applyGrouping):
              * bindings/v8/WrapperTypeInfo.h:
              * inspector/front-end/DetailedHeapshotGridNodes.js:
              (WebInspector.HeapSnapshotConstructorNode):
              (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
              (WebInspector.HeapSnapshotDiffNode):
              (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
              (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
              * inspector/front-end/DetailedHeapshotView.js:
              (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
              (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
              (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching):
              (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
              (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
              (WebInspector.DetailedHeapshotView.prototype._changeRetainingPathsRoot):
              (WebInspector.DetailedHeapshotView.prototype.get isTracingToWindowObjects):
              * inspector/front-end/HeapSnapshot.js:
              (WebInspector.HeapSnapshotNode.prototype.get className):
              (WebInspector.HeapSnapshot.prototype._buildAggregates):
              (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots):
              (WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
              * inspector/front-end/heapProfiler.css:
              (.detailed-heapshot-view .retaining-paths-view .title > span):
              (.detailed-heapshot-view .retaining-paths-to-windows):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82aef340
    • weinig@apple.com's avatar
      Skip test fast/forms/input-autofilled.html in mac-wk2 since · b811f41d
      weinig@apple.com authored
      layoutTestController.setAutofilled is not yet supported.
      
      * platform/mac-wk2/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b811f41d
    • weinig@apple.com's avatar
      Add WebKit2 API to figure out if an input or textarea was edited · b7c22c4e
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56474
      
      Reviewed by Adam Roben.
      
      Source/WebCore: 
      
      Add HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
      and use them to implement -[DOMHTMLInputElement _isEdited] and -[DOMHTMLTextAreaElement _isEdited]
      as well as API in WebKit2.
      
      * WebCore.exp.in:
      * bindings/objc/DOMHTML.mm:
      (-[DOMHTMLInputElement _isEdited]):
      (-[DOMHTMLTextAreaElement _isEdited]):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::lastChangeWasUserEdit):
      * html/HTMLInputElement.h:
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::lastChangeWasUserEdit):
      * html/HTMLTextAreaElement.h:
      
      Source/WebKit2: 
      
      Expose WKBundleNodeHandleGetHTMLInputElementLastChangeWasUserEdit and
      WKBundleNodeHandleGetHTMLTextAreaElementLastChangeWasUserEdit. Next time,
      I will work on giving these functions longer names.
      
      * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
      (WKBundleNodeHandleGetHTMLInputElementLastChangeWasUserEdit):
      (WKBundleNodeHandleGetHTMLTextAreaElementLastChangeWasUserEdit):
      * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
      (WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7c22c4e
    • ggaren@apple.com's avatar
      2011-03-16 Geoffrey Garen <ggaren@apple.com> · 02bf0404
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              Some conservative root gathering cleanup
              https://bugs.webkit.org/show_bug.cgi?id=56447
              
              SunSpider says 0.5% - 1.8% faster.
      
              * interpreter/RegisterFile.cpp:
              (JSC::RegisterFile::gatherConservativeRoots):
              * interpreter/RegisterFile.h: New helper function for doing the
              conservative gathering of the register file. It's still conservative,
              since the register file may contain uninitialized values, but it's
              moving-safe, because it only visits values tagged as pointers, so there's
              no risk of mistaking an integer for a pointer and accidentally changing it.
      
              * runtime/ConservativeSet.cpp:
              (JSC::ConservativeRoots::add):
              * runtime/ConservativeSet.h: Added a single-value add function, used above.
      
              * runtime/Heap.cpp:
              (JSC::Heap::markRoots): Separated machine stack conservative roots from
              register file conservative roots because machine stack roots must be
              pinned, but register file roots need not be pinned.
              
              Adopted new interface for passing the current stack extent to the machine
              stack root gathering routine. This allows us to exclude marking-related
              data structures on the stack, and thus avoid double-marking the set of
              machine roots.
      
              * runtime/MachineStackMarker.cpp:
              (JSC::MachineThreads::gatherFromCurrentThread):
              (JSC::MachineThreads::gatherConservativeRoots):
              * runtime/MachineStackMarker.h: Added new interface, described above.
      
              * runtime/MarkedBlock.h:
              (JSC::MarkedBlock::firstAtom):
              * wtf/StdLibExtras.h:
              (WTF::roundUpToMultipleOf): Moved roundUpToMultipleOf so it could be used
              by MachineStacks.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02bf0404
    • ggaren@apple.com's avatar
      2011-03-16 Geoffrey Garen <ggaren@apple.com> · b7d71072
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              A little bit of MarkStack cleanup
              https://bugs.webkit.org/show_bug.cgi?id=56443
              
              Moved MarkStack functions into MarkStack.h/.cpp.
              
              SunSpider reports no change.
      
              * runtime/JSArray.h:
              * runtime/JSCell.h: Moved from here...
              * runtime/MarkStack.cpp:
              (JSC::MarkStack::markChildren):
              (JSC::MarkStack::drain): ...to here. Also, no need to inline drain. It's
              a huge function, and not called many times.
      
              * runtime/MarkStack.h:
              (JSC::MarkStack::~MarkStack): Moved near constructor, per style guide.
              (JSC::MarkStack::append):
              (JSC::MarkStack::deprecatedAppend):
              (JSC::MarkStack::internalAppend): Moved to here.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7d71072
    • bweinstein@apple.com's avatar
      More cleanup of expected results files for text combine tests from r81255. · 4d7218ae
      bweinstein@apple.com authored
      * platform/win/fast/dynamic/text-combine-expected.checksum: Added.
      * platform/win/fast/dynamic/text-combine-expected.png: Added.
      * platform/win/fast/text/international/text-combine-image-test-expected.txt:
              
      * platform/win/fast/international: Removed. This was the wrong directory.
      * platform/win/fast/international/text-combine-image-test-expected.txt: Removed. This was the wrong directory.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d7218ae
    • pfeldman@chromium.org's avatar
      2011-03-15 Pavel Feldman <pfeldman@chromium.org> · 381ebd8a
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
              https://bugs.webkit.org/show_bug.cgi?id=56376
      
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMAgent.prototype._setDocument):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      381ebd8a
    • podivilov@chromium.org's avatar
      2011-03-16 Pavel Podivilov <podivilov@chromium.org> · 84a9c1e0
      podivilov@chromium.org authored
              Unreviewed, fix live-edit test broken by r81238.
      
              * inspector/debugger/live-edit.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84a9c1e0
    • bweinstein@apple.com's avatar
      Make the files added -expected.txt instead of -actual.txt so run-webkit-tests · 9e9a0c82
      bweinstein@apple.com authored
      will actually find them.
      
      * platform/win/fast/dynamic/text-combine-actual.txt: Removed.
      * platform/win/fast/dynamic/text-combine-expected.txt: Copied from platform/win/fast/dynamic/text-combine-actual.txt.
      * platform/win/fast/international/text-combine-image-test-actual.txt: Removed.
      * platform/win/fast/international/text-combine-image-test-expected.txt: Copied from platform/win/fast/international/text-combine-image-test-actual.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e9a0c82
    • bweinstein@apple.com's avatar
      Add Windows-specific results for text combine tests. · b2a6ae3c
      bweinstein@apple.com authored
      * platform/win/fast/dynamic/text-combine-actual.txt: Added.
      * platform/win/fast/international: Added.
      * platform/win/fast/international/text-combine-image-test-actual.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2a6ae3c
    • ossy@webkit.org's avatar
      [Qt] Add failing tests to the Skipped list because of missing test fonts. · 752f648c
      ossy@webkit.org authored
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      752f648c
    • ossy@webkit.org's avatar
      REGRESSION (r68976): Incorrect bidi rendering in SVG text · 91b5de15
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=53980
      
      Add Qt specific expected files after r81168.
      
      * platform/qt/Skipped: Add new tests because of missing test fonts.
      * platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.checksum: Added.
      * platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
      * platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
      * platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added.
      * platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
      * platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
      * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
      * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
      * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
      * platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91b5de15
    • beidson@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=56467 · 774f2538
      beidson@apple.com authored
      IconDatabase-related crash seen in WK2 tests
      
      Reviewed by Adam Roben.
      
      * WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
      (WebKit::WebIconDatabaseProxy::setIconDataForIconURL): The IconLoader might set a null data for an icon, so handle that case.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      774f2538
    • mitz@apple.com's avatar
      text-combine text retains compressed font after adding characters to it · 80c25d50
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56448
      
      Reviewed by Simon Fraser.
      
      Source/WebCore: 
      
      Test: fast/dynamic/text-combine.html
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty): Allow styles with text-combine to be shared, since
      only the clones on the RenderCombineText will be mutated.
      * rendering/RenderCombineText.cpp:
      (WebCore::RenderCombineText::styleDidChange): Clone the style, to avoid mutating the parent’s
      style.
      (WebCore::RenderCombineText::combineText): Start off with the original font; restore it if
      the text cannot be combined.
      * rendering/RenderCombineText.h:
      (WebCore::RenderCombineText::originalFont): Added. Returns the parent’s font.
      
      LayoutTests: 
      
      * fast/dynamic/text-combine.html: Added.
      * platform/mac/fast/dynamic/text-combine-expected.checksum: Added.
      * platform/mac/fast/dynamic/text-combine-expected.png: Added.
      * platform/mac/fast/dynamic/text-combine-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80c25d50
    • aroben@apple.com's avatar
      Disable jquery/effects.html · ceb8786a
      aroben@apple.com authored
      It often times out due to its sheer size. The failure is tracked by
      <http://webkit.org/b/56080>.
      
      * jquery/effects.html-disabled: Renamed from LayoutTests/jquery/effects.html.
      
      * platform/gtk/Skipped:
      * platform/win-xp/Skipped:
      Unskipped the test since we're now disabling it via other means.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ceb8786a
    • philn@webkit.org's avatar
      2011-03-16 Philippe Normand <pnormand@igalia.com> · 5e01189d
      philn@webkit.org authored
              Unreviewed, skipping one more svg test failing on 32-bits release,
              likely due to bug 39022.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e01189d
    • ossy@webkit.org's avatar
      [Qt] fast/text/soft-hyphen-4.html introduced in r80984 · ccf3f745
      ossy@webkit.org authored
      and fails because hyphenation isn't implemented yet.
      
      * platform/qt/Skipped: Add fast/text/soft-hyphen-4.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccf3f745
    • philn@webkit.org's avatar
      2011-03-16 Philippe Normand <pnormand@igalia.com> · b2464a84
      philn@webkit.org authored
              Unreviewed, skip svg/W3C-I18N tests failing on 32-bits Debug only.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2464a84
    • philn@webkit.org's avatar
      2011-03-16 Philippe Normand <pnormand@igalia.com> · 79c11f9b
      philn@webkit.org authored
              Unreviewed, skip editing/style/iframe-onload-crash.html on GTK.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79c11f9b
    • ossy@webkit.org's avatar
      Update Qt specific expected file after r81049. · 37412b32
      ossy@webkit.org authored
      * platform/qt/fast/table/overflowHidden-expected.txt: Updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37412b32
    • podivilov@chromium.org's avatar
      2011-03-16 Pavel Podivilov <podivilov@chromium.org> · a3255e70
      podivilov@chromium.org authored
              Unreviewed, fix test broken by r81238.
      
              * inspector/debugger/live-edit.html:
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3255e70
    • podivilov@chromium.org's avatar
      2011-03-14 Pavel Podivilov <podivilov@chromium.org> · 079a2c83
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: refactor event listener breakpoints.
              https://bugs.webkit.org/show_bug.cgi?id=56305
      
              * inspector/debugger/event-listener-breakpoints-expected.txt: Added.
              * inspector/debugger/event-listener-breakpoints.html: Added.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2011-03-14  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: refactor event listener breakpoints.
              https://bugs.webkit.org/show_bug.cgi?id=56305
      
              - restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
              - store event listener breakpoints in a separate separate setting
              - move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane
      
              Test: inspector/debugger/event-listener-breakpoints.html
      
              * inspector/Inspector.idl:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::setFrontend):
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
              (WebCore::InspectorBrowserDebuggerAgent::clear):
              * inspector/InspectorBrowserDebuggerAgent.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didCommitLoadImpl):
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint):
              (WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint):
              (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
              (WebInspector.BreakpointManager.prototype._projectChanged):
              (WebInspector.BreakpointManager.prototype._saveBreakpoints):
              (WebInspector.BreakpointManager.prototype._validateBreakpoints):
              (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.EventListenerBreakpointsSidebarPane):
              (WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
              * inspector/front-end/CallStackSidebarPane.js:
              (WebInspector.CallStackSidebarPane.prototype.update):
              (WebInspector.CallStackSidebarPane.prototype.setStatus):
              (WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._debuggerPaused):
              (WebInspector.ScriptsPanel.prototype._clearInterface):
              * inspector/front-end/Settings.js:
              (WebInspector.Settings):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      079a2c83
    • ddkilzer@apple.com's avatar
      Minor clean-up after r81156, r81172 · 991f93fe
      ddkilzer@apple.com authored
      Follow-up for:
      <http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++
      
      * platform/graphics/GraphicsLayer.h: Removed unused @class
      WebLayer declaration.
      * platform/graphics/ca/PlatformCAAnimation.h: Changed typedef
      struct CAPropertyAnimation to class declaration.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      991f93fe
    • apavlov@chromium.org's avatar
      2011-03-16 Alexander Pavlov <apavlov@chromium.org> · f0f11122
      apavlov@chromium.org authored
              [Chromium] Unreviewed, update expectations.
              Fix Linux Debug expectation clash for transitions/interrupted-accelerated-transition.html.
              Let svg/text/font-size-below-point-five.svg fail on Mac Release.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0f11122
    • apavlov@chromium.org's avatar
      2011-03-16 Alexander Pavlov <apavlov@chromium.org> · 2bc422ce
      apavlov@chromium.org authored
              [Chromium] Unreviewed, remove duplicate expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bc422ce
    • ossy@webkit.org's avatar
      [Qt]Web Inspector: inspector/elements/mutate-unknown-node.html fails · 41283c45
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=56457
      
      * platform/qt/Skipped: Add inspector/elements/mutate-unknown-node.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41283c45
    • podivilov@chromium.org's avatar
      2011-03-16 Andrey Adaikin <aandrey@google.com> · ce84983f
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Remove live-edit code
              https://bugs.webkit.org/show_bug.cgi?id=56177
      
              * inspector/front-end/Settings.js:
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              (WebInspector.SourceFrame.prototype._doubleClick):
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextEditorMainPanel):
              (WebInspector.TextEditorMainPanel.prototype.set readOnly):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce84983f
    • benjamin.poulain@nokia.com's avatar
      2011-03-16 Benjamin Poulain <benjamin.poulain@nokia.com> · dd3f6173
      benjamin.poulain@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt][WK2] Loading an empty URL crashes
              https://bugs.webkit.org/show_bug.cgi?id=55501
      
              A null WKURLRef is created in the API of WebKit 2 when converting a null string. The code
              of WKPageLoadURL assume the WKPageRef is not null which causes crashes if it is.
      
              This patch uses the converter toWTFString() to pass from WKPageRef to WTFString. This converter
              ensure the returned string is a valid null string.
      
              Tested through the Qt API tests.
      
              * UIProcess/API/C/WKPage.cpp:
              (WKPageLoadURL):
              * UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp:
              (tst_QGraphicsWKView::loadEmptyUrl):
              * UIProcess/API/qt/tests/qwkpage/qwkpage.pro: Added.
              * UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp: Added.
              (tst_QWKPage::init):
              (tst_QWKPage::cleanup):
              (tst_QWKPage::loadEmptyUrl):
              * UIProcess/API/qt/tests/tests.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd3f6173
    • ossy@webkit.org's avatar
      [Qt] Typo fix after r81226. · 953aba43
      ossy@webkit.org authored
      * platform/qt/Skipped: Remove unnecessary "#".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      953aba43
    • apavlov@chromium.org's avatar
      2011-03-16 Alexander Pavlov <apavlov@chromium.org> · adb80964
      apavlov@chromium.org authored
              [Chromium] Unreviewed, suppress Win builder failures from r81222.
              Also, one tentatively stale suppression is removed.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adb80964
    • commit-queue@webkit.org's avatar
      2011-03-16 Alexis Menard <alexis.menard@openbossa.org> · e1a7e8f3
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it.
              https://bugs.webkit.org/show_bug.cgi?id=56403
      
              In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING);
              As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched
              i.e the pause() made when beginScrubbing is done is just internal.
      
              No new tests: Verified manually.
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivateGStreamer::updateStates):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1a7e8f3
    • dino@apple.com's avatar
      2011-03-16 Dean Jackson <dino@apple.com> · 3fddd784
      dino@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=56242
              Flaky Test: transitions/interrupted-accelerated-transition.html
      
              Skip this while https://bugs.webkit.org/show_bug.cgi?id=54151
              (Animation API) is in progress.
      
              * platform/chromium/test_expectations.txt:
              * platform/mac/Skipped:
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fddd784
    • commit-queue@webkit.org's avatar
      2011-03-16 Luiz Agostini <luiz.agostini@openbossa.org> · b9217121
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              fast/loader/stateobjects/replacestate-in-iframe.html caused infinite loop.
              https://bugs.webkit.org/show_bug.cgi?id=36467
      
              Removing the test from skipped list since the problem seems to be solved.
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9217121