1. 25 Jun, 2008 5 commits
    • mitz@apple.com's avatar
      WebCore: · 909b8eb8
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/5873639> REGRESSION (r31620): css2.1/t1506-c525-font-wt-00-b fails on Windows
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=18863
                <rdar://problem/5908890> weight mappings with @font-face aren't consistent
      
              Tests: fast/css/font-face-locally-installed.html
                     fast/css/font-face-multiple-faces.html
      
              * WebCore.vcproj/WebCore.vcproj: Added FontTraitsMask.h.
      
              * WebCore.xcodeproj/project.pbxproj: Ditto.
      
              * css/CSSFontFace.h:
              Made CSSFontFace store descriptors from the @font-face rule, as follows:
              (WebCore::CSSFontFace::create): Added a FontTraitsMask argument.
              (WebCore::CSSFontFace::traitsMask): Added this accessor.
              (WebCore::CSSFontFace::addRange): Added.
              (WebCore::CSSFontFace::ranges): Added.
              (WebCore::CSSFontFace::UnicodeRange::UnicodeRange):
              (WebCore::CSSFontFace::UnicodeRange::from):
              (WebCore::CSSFontFace::UnicodeRange::to):
              (WebCore::CSSFontFace::CSSFontFace): Added a FontTraitsMask and a vector
              of UnicodeRanges as member variables.
      
              * css/CSSFontFaceSource.cpp:
              Changed the hash key from the font size alone to the font size and
              the synthetic style bits, needed if the same source supplies different
              synthesized versions.
              (WebCore::CSSFontFaceSource::pruneTable):
              (WebCore::CSSFontFaceSource::getFontData):
      
              * css/CSSFontFaceSource.h:
      
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::~CSSFontSelector): Added code to delete
              the contents of the font face, locally-installed font face and segmented
              font tables.
              (WebCore::CSSFontSelector::addFontFaceRule): Changed this function to
              not create segmented font faces, but instead just collect font faces
              and annotate them with descriptors (traits and unicode ranges).
              (WebCore::compareFontFaces): Added. Used in getFontData() to sort the
              font faces by proximity to the desired traits.
              (WebCore::CSSFontSelector::getFontData): Changed to create the segmented
              font face here and cache it.
      
              * css/CSSFontSelector.h:
      
              * css/CSSSegmentedFontFace.cpp:
              Changed to keep a vector of font faces instead of font face ranges, as
              font faces now know their Unicode ranges.
              (WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace):
              (WebCore::CSSSegmentedFontFace::isLoaded):
              (WebCore::CSSSegmentedFontFace::isValid):
              (WebCore::CSSSegmentedFontFace::appendFontFace):
              (WebCore::CSSSegmentedFontFace::getFontData): Removed the synthetic
              traits parameters, and instead changed to set them on each FontData
              separately based on the difference between the desired traits and
              the font face's traits.
      
              * css/CSSSegmentedFontFace.h:
      
              * platform/graphics/FontCache.h:
              Removed fontExists() and added getTraitsInFamily().
      
              * platform/graphics/FontDescription.cpp:
              (WebCore::FontDescription::traitsMask): Added.
      
              * platform/graphics/FontDescription.h:
      
              * platform/graphics/FontTraitsMask.h: Added.
      
              * platform/graphics/GlyphPageTreeNode.cpp:
              (WebCore::GlyphPageTreeNode::initializePage): Changed to fill in with
              glyphs from all fonts in the segmented font, using each font in turn to
              fill in characters not covered by earlier fonts.
      
              * platform/graphics/gtk/FontCacheGtk.cpp:
              (WebCore::FontCache::getTraitsInFamily): Added a stub.
      
              * platform/graphics/mac/FontCacheMac.mm:
              (WebCore::FontCache::getTraitsInFamily): Added.
      
              * platform/graphics/qt/FontCacheQt.cpp:
              (WebCore::FontCache::getTraitsInFamily): Added a stub.
      
              * platform/graphics/win/FontCacheWin.cpp:
              (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): Added.
              (WebCore::traitsInFamilyEnumProc): Added.
              (WebCore::FontCache::getTraitsInFamily): Added.
      
              * platform/graphics/wx/FontCacheWx.cpp:
              (WebCore::FontCache::getTraitsInFamily): Added a stub.
      
              * platform/mac/WebFontCache.h:
              * platform/mac/WebFontCache.mm:
              (toTraitsMask): Added.
              (+[WebFontCache getTraits:inFamily:]): Added.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - tests for https://bugs.webkit.org/show_bug.cgi?id=18863
                <rdar://problem/5908890> weight mappings with @font-face aren't consistent
      
              * fast/css/font-face-locally-installed.html: Added.
              * fast/css/font-face-multiple-faces.html: Added.
              * platform/mac/fast/css/font-face-locally-installed-expected.checksum: Added.
              * platform/mac/fast/css/font-face-locally-installed-expected.png: Added.
              * platform/mac/fast/css/font-face-locally-installed-expected.txt: Added.
              * platform/mac/fast/css/font-face-multiple-faces-expected.checksum: Added.
              * platform/mac/fast/css/font-face-multiple-faces-expected.png: Added.
              * platform/mac/fast/css/font-face-multiple-faces-expected.txt: Added.
              * platform/win/Skipped: Removed css2.1/t1506-c525-font-wt-00-b.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      909b8eb8
    • cwzwarich@webkit.org's avatar
      2008-06-25 Cameron Zwarich <cwzwarich@uwaterloo.ca> · 7576c03d
      cwzwarich@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Attempt to fix Windows debug build. The compiler gives a warning when
              Structured Exception Handling and destructors are used in the same
              function. Using manual locking and unlocking instead of constructors
              and destructors should fix the warning.
      
              * kjs/Shell.cpp:
              (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7576c03d
    • ap@webkit.org's avatar
      Forgot to address a review comment about better names for tracked objects, doing it now. · a9535cf0
      ap@webkit.org authored
              * kjs/JSGlobalData.cpp:
              (KJS::JSGlobalData::JSGlobalData):
              * kjs/JSGlobalData.h:
              * kjs/nodes.cpp:
              (KJS::ParserRefCounted::ParserRefCounted):
              (KJS::ParserRefCounted::ref):
              (KJS::ParserRefCounted::deref):
              (KJS::ParserRefCounted::hasOneRef):
              (KJS::ParserRefCounted::deleteNewObjects):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9535cf0
    • ap@webkit.org's avatar
      Reviewed by Geoff. · 9e7ecd38
      ap@webkit.org authored
              Remove more threadInstance() calls.
      
              * kjs/JSFunction.cpp:
              (KJS::JSFunction::getParameterName):
              (KJS::IndexToNameMap::unMap):
              (KJS::Arguments::deleteProperty):
              * kjs/JSFunction.h:
              Access nullIdentifier without going to thread specific storage.
      
              * JavaScriptCore.exp:
              * kjs/JSGlobalData.cpp:
              (KJS::JSGlobalData::JSGlobalData):
              * kjs/JSGlobalData.h:
              * kjs/Parser.cpp:
              (KJS::Parser::parse):
              * kjs/Parser.h:
              (KJS::ParserRefCountedData::ParserRefCountedData):
              (KJS::Parser::parse):
              * kjs/grammar.y:
              * kjs/nodes.cpp:
              (KJS::ParserRefCounted::ParserRefCounted):
              (KJS::ParserRefCounted::ref):
              (KJS::ParserRefCounted::deref):
              (KJS::ParserRefCounted::hasOneRef):
              (KJS::ParserRefCounted::deleteNewObjects):
              (KJS::Node::Node):
              (KJS::StatementNode::StatementNode):
              (KJS::BreakpointCheckStatement::BreakpointCheckStatement):
              (KJS::ConstDeclNode::ConstDeclNode):
              (KJS::BlockNode::BlockNode):
              (KJS::ForInNode::ForInNode):
              (KJS::ScopeNode::ScopeNode):
              (KJS::ProgramNode::ProgramNode):
              (KJS::ProgramNode::create):
              (KJS::EvalNode::EvalNode):
              (KJS::EvalNode::create):
              (KJS::FunctionBodyNode::FunctionBodyNode):
              (KJS::FunctionBodyNode::create):
              * kjs/nodes.h:
              (KJS::ExpressionNode::):
              (KJS::NullNode::):
              (KJS::BooleanNode::):
              (KJS::NumberNode::):
              (KJS::ImmediateNumberNode::):
              (KJS::StringNode::):
              (KJS::RegExpNode::):
              (KJS::ThisNode::):
              (KJS::ResolveNode::):
              (KJS::ElementNode::):
              (KJS::ArrayNode::):
              (KJS::PropertyNode::):
              (KJS::PropertyListNode::):
              (KJS::ObjectLiteralNode::):
              (KJS::BracketAccessorNode::):
              (KJS::DotAccessorNode::):
              (KJS::ArgumentListNode::):
              (KJS::ArgumentsNode::):
              (KJS::NewExprNode::):
              (KJS::EvalFunctionCallNode::):
              (KJS::FunctionCallValueNode::):
              (KJS::FunctionCallResolveNode::):
              (KJS::FunctionCallBracketNode::):
              (KJS::FunctionCallDotNode::):
              (KJS::PrePostResolveNode::):
              (KJS::PostIncResolveNode::):
              (KJS::PostDecResolveNode::):
              (KJS::PostfixBracketNode::):
              (KJS::PostIncBracketNode::):
              (KJS::PostDecBracketNode::):
              (KJS::PostfixDotNode::):
              (KJS::PostIncDotNode::):
              (KJS::PostDecDotNode::):
              (KJS::PostfixErrorNode::):
              (KJS::DeleteResolveNode::):
              (KJS::DeleteBracketNode::):
              (KJS::DeleteDotNode::):
              (KJS::DeleteValueNode::):
              (KJS::VoidNode::):
              (KJS::TypeOfResolveNode::):
              (KJS::TypeOfValueNode::):
              (KJS::PreIncResolveNode::):
              (KJS::PreDecResolveNode::):
              (KJS::PrefixBracketNode::):
              (KJS::PreIncBracketNode::):
              (KJS::PreDecBracketNode::):
              (KJS::PrefixDotNode::):
              (KJS::PreIncDotNode::):
              (KJS::PreDecDotNode::):
              (KJS::PrefixErrorNode::):
              (KJS::UnaryOpNode::UnaryOpNode):
              (KJS::UnaryPlusNode::):
              (KJS::NegateNode::):
              (KJS::BitwiseNotNode::):
              (KJS::LogicalNotNode::):
              (KJS::BinaryOpNode::BinaryOpNode):
              (KJS::ReverseBinaryOpNode::ReverseBinaryOpNode):
              (KJS::MultNode::):
              (KJS::DivNode::):
              (KJS::ModNode::):
              (KJS::AddNode::):
              (KJS::SubNode::):
              (KJS::LeftShiftNode::):
              (KJS::RightShiftNode::):
              (KJS::UnsignedRightShiftNode::):
              (KJS::LessNode::):
              (KJS::GreaterNode::):
              (KJS::LessEqNode::):
              (KJS::GreaterEqNode::):
              (KJS::InstanceOfNode::):
              (KJS::InNode::):
              (KJS::EqualNode::):
              (KJS::NotEqualNode::):
              (KJS::StrictEqualNode::):
              (KJS::NotStrictEqualNode::):
              (KJS::BitAndNode::):
              (KJS::BitOrNode::):
              (KJS::BitXOrNode::):
              (KJS::LogicalAndNode::):
              (KJS::LogicalOrNode::):
              (KJS::ConditionalNode::):
              (KJS::ReadModifyResolveNode::):
              (KJS::AssignResolveNode::):
              (KJS::ReadModifyBracketNode::):
              (KJS::AssignBracketNode::):
              (KJS::AssignDotNode::):
              (KJS::ReadModifyDotNode::):
              (KJS::AssignErrorNode::):
              (KJS::CommaNode::):
              (KJS::VarDeclCommaNode::):
              (KJS::ConstStatementNode::):
              (KJS::SourceElements::SourceElements):
              (KJS::EmptyStatementNode::):
              (KJS::DebuggerStatementNode::):
              (KJS::ExprStatementNode::):
              (KJS::VarStatementNode::):
              (KJS::IfNode::):
              (KJS::IfElseNode::):
              (KJS::DoWhileNode::):
              (KJS::WhileNode::):
              (KJS::ForNode::):
              (KJS::ContinueNode::):
              (KJS::BreakNode::):
              (KJS::ReturnNode::):
              (KJS::WithNode::):
              (KJS::LabelNode::):
              (KJS::ThrowNode::):
              (KJS::TryNode::):
              (KJS::ParameterNode::):
              (KJS::FuncExprNode::):
              (KJS::FuncDeclNode::):
              (KJS::CaseClauseNode::):
              (KJS::ClauseListNode::):
              (KJS::CaseBlockNode::):
              (KJS::SwitchNode::):
              Changed ParserRefCounted to hold a JSGlobalData pointer, and used it to replace
              threadInstance calls.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e7ecd38
    • cwzwarich@webkit.org's avatar
      2008-06-24 Cameron Zwarich <cwzwarich@uwaterloo.ca> · d81ad203
      cwzwarich@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Make the JavaScript shell collect the heap from main() instead of
              jscmain() to suppress leak messages in debug builds.
      
              * kjs/Shell.cpp:
              (main):
              (jscmain):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d81ad203
  2. 24 Jun, 2008 33 commits
    • abarth@webkit.org's avatar
      WebCore: · d6517365
      abarth@webkit.org authored
      2008-06-24  Anonymous
      
              Reviewed by Darin Adler.  Committed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=19470
      
              Check for a null documentElement() to fix four crashes.
      
              * WebCore/dom/Document.cpp:
              * WebCore/dom/Node.cpp:
      
      LayoutTests:
      
      2008-06-24  Anonymous
      
              Reviewed by Darin Adler.  Committed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=19470
      
              Check for a null documentElement() to fix four crashes.
      
              * LayoutTests/fast/dom/documentElement-null-expected.txt: Added.
              * LayoutTests/fast/dom/documentElement-null.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6517365
    • abarth@webkit.org's avatar
      Fix png mime-type · aea2f4fc
      abarth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aea2f4fc
    • abarth@webkit.org's avatar
      WebCore: · 5f8c1e85
      abarth@webkit.org authored
      2008-06-24  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              Fix <https://bugs.webkit.org/show_bug.cgi?id=19597>
      
              Correctly parse <!-- </textarea> --> inside a <textarea>, matching
              Internet Explorer, Firefox, Opera, and HTML 5.
      
              Tests: fast/parser/comment-in-script-tricky.html
                     fast/parser/comment-in-style.html
                     fast/parser/comment-in-textarea.html
                     fast/parser/comment-in-title.html
      
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseSpecial):
      
      LayoutTests:
      
      2008-06-24  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=19597
      
              Test that we correctly parse comments containing end tags in CDATA and
              RCDATA contexts.
      
              * fast/parser/comment-in-script-tricky-expected.txt: Added.
              * fast/parser/comment-in-script-tricky.html: Added.
              * fast/parser/comment-in-style.html: Added.
              * fast/parser/comment-in-textarea.html: Added.
              * fast/parser/comment-in-title-expected.txt: Added.
              * fast/parser/comment-in-title.html: Added.
              * platform/mac/fast/parser/comment-in-style-expected.checksum: Added.
              * platform/mac/fast/parser/comment-in-style-expected.png: Added.
              * platform/mac/fast/parser/comment-in-style-expected.txt: Added.
              * platform/mac/fast/parser/comment-in-textarea-expected.checksum: Added.
              * platform/mac/fast/parser/comment-in-textarea-expected.png: Added.
              * platform/mac/fast/parser/comment-in-textarea-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f8c1e85
    • mitz@apple.com's avatar
      Reviewed by Mark Rowe. · 5d91738e
      mitz@apple.com authored
              - add another test using remote fonts to the Tiger skipped list
      
              * platform/mac-tiger/Skipped: Added fast/css/font-weight-1.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d91738e
    • mrowe@apple.com's avatar
      2008-06-24 Mark Rowe <mrowe@apple.com> · aca8ca22
      mrowe@apple.com authored
              Exclude the newly-added accessibilityController from the dumped window properties.
      
              * fast/dom/Window/window-properties.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aca8ca22
    • cwzwarich@webkit.org's avatar
      2008-06-24 Cameron Zwarich <cwzwarich@uwaterloo.ca> · db79713c
      cwzwarich@webkit.org authored
              Reviewed by Maciej.
      
              Make the conversion of the pair (less, jtrue) to jless use register
              reference counting information for safety instead of requiring callers
              to decide whether it is safe.
      
              No changes on SunSpider codegen.
      
              * VM/CodeGenerator.cpp:
              (KJS::CodeGenerator::emitJumpIfTrue):
              * VM/CodeGenerator.h:
              * kjs/nodes.cpp:
              (KJS::DoWhileNode::emitCode):
              (KJS::WhileNode::emitCode):
              (KJS::ForNode::emitCode):
              (KJS::CaseBlockNode::emitCodeForBlock):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db79713c
    • mitz@apple.com's avatar
      Reviewed by Stephanie Lewis. · 8183796d
      mitz@apple.com authored
              - move the linker flags from the debug configuration in the project
                to the shared configuration
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
              * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8183796d
    • mitz@apple.com's avatar
      - try to fix the Tiger build · 36668baa
      mitz@apple.com authored
              * DumpRenderTree/mac/AccessibilityControllerMac.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36668baa
    • cwzwarich@webkit.org's avatar
      2008-06-24 Cameron Zwarich <cwzwarich@uwaterloo.ca> · bf9388e6
      cwzwarich@webkit.org authored
              Rubber stamped by Oliver.
      
              Roll out r34777 due to multiple assertion failures on tests.
      
              * ChangeLog:
              * VM/CodeGenerator.cpp:
              (KJS::CodeGenerator::emitJump):
              (KJS::CodeGenerator::emitJumpIfTrueMayCombine):
              (KJS::CodeGenerator::emitJumpIfTrue):
              (KJS::CodeGenerator::emitJumpIfFalse):
              (KJS::CodeGenerator::emitJumpScopes):
              * VM/LabelID.h:
              * VM/Machine.cpp:
              (KJS::Machine::privateExecute):
              * VM/Machine.h:
              * VM/Opcode.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf9388e6
    • justin.garcia@apple.com's avatar
      WebCore: · 87099ef1
      justin.garcia@apple.com authored
      2008-06-24  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by John.
      
              <rdar://problem/6026335> REGRESSION: Caret disappears after deleting a particular selection involving a ToDo
              
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs): If asked to preserveStyle, we
              apply styles from the moved paragraph to the destination with applyStyle, which
              does selection preservation when it needs to apply block styles.  Selection preservation 
              uses relatively untested code in TextIterator to count VisiblePositions which fails in 
              this particular test case because it doesn't handle changes in editability properly.  
              We can avoid this bug by not applying block styles from moved paragraphs.  This is 
              something that should be done anyway, since the moved paragraph should assume the 
              block styles of the destination.
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::styleAtPosition): Added a FIXME about how it is misleading for
              this function to also include the typing style.
              * editing/TextIterator.h: Added a FIXME about how the code path used for selection preservation
              is buggy and should be phased out when we rewrite moveParagraphs.
      
      LayoutTests:
      
      2008-06-24  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by John.
      
              <rdar://problem/6026335> REGRESSION: Caret disappears after deleting a particular selection involving a ToDo
      
              * editing/deleting/6026335-expected.txt: Added.
              * editing/deleting/6026335.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87099ef1
    • kmccullough@apple.com's avatar
      2008-06-24 Kevin McCullough <kmccullough@apple.com> · cafdc2b8
      kmccullough@apple.com authored
              -Added a manual test for the profiler.
      
              * manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cafdc2b8
    • kmccullough@apple.com's avatar
      2008-06-24 Kevin McCullough <kmccullough@apple.com> · 9c50c73f
      kmccullough@apple.com authored
              Reviewed by Tim.
      
              <rdar://problem/6031594> JSProfiler: Profiler goes into an infinite
              loop sometimes.
              <rdar://problem/6031603> JSProfiler: Profiler asserts in debug and
              give the wrong times in release
      
              Fixed two issues found by Tim in the same test.
      
              * profiler/Profile.cpp:
              (KJS::Profile::removeProfileStart): No longer take profile's time from
              all ancestors, but instead attribute it to its parent.  Also add an
              Assert to ensure we only delete the child we mean to.
              (KJS::Profile::removeProfileEnd): Ditto for profileEnd.
              (KJS::Profile::didExecute): Cleaned up the execution order and correctly
              attribute all of the parent's time to the new node.
              * profiler/ProfileNode.cpp: If this node does not have a startTime it
              should not get a giant total time, but instead be 0.
              (KJS::ProfileNode::endAndRecordCall):
              * profiler/ProfileNode.h:
              (KJS::ProfileNode::removeChild): Should reset the sibling pointers since
              one of them has been removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c50c73f
    • oliver@apple.com's avatar
      Groundwork for reimplementing the slow script dialog · 3301ed8d
      oliver@apple.com authored
      Reviewed by Cameron.
      
      Add special loop opcodes as groundwork for slow script
      termination.  Also added a few assertions to prevent us
      from accidentally coalescing conditional jump operands
      in a way that might bypass the slow script opcodes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3301ed8d
    • bdakin@apple.com's avatar
      WebKitTools: · e1d57dbb
      bdakin@apple.com authored
      2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>
      
              Reviewed by Darin.
      
              Fix for <rdar://problem/5884881> Make DumpRenderTree support 
              accessibility tests
      
              This patch adds some basic support for accessibility layout tests 
              on the Mac.
      
              * DumpRenderTree/AccessibilityController.cpp: Added.
              (AccessibilityController::AccessibilityController):
              (AccessibilityController::~AccessibilityController):
              (dumpCurrentAttributesCallback):
              (AccessibilityController::makeWindowObject):
              (AccessibilityController::getJSClass):
              (AccessibilityController::staticFunctions):
              * DumpRenderTree/AccessibilityController.h: Added.
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
              * DumpRenderTree/mac/AccessibilityControllerMac.mm: Added.
              (descriptionOfValue):
              (AccessibilityController::dumpCurrentAttributes):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              * DumpRenderTree/mac/FrameLoadDelegate.h:
              * DumpRenderTree/mac/FrameLoadDelegate.mm:
              (-[FrameLoadDelegate init]):
              (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
      
      LayoutTests:
      
      2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>
      
              Reviewed by Darin.
              
              First test for <rdar://problem/5884881> Make DumpRenderTree support 
              accessibility tests
      
              * accessibility: Added.
              * accessibility/document-attributes-expected.txt: Added.
              * accessibility/document-attributes.html: Added.
              * platform/gtk/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1d57dbb
    • weinig@apple.com's avatar
      WebCore: · c0dac789
      weinig@apple.com authored
      2008-06-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Add support for loadstart, abort and error events for XMLHttpRequests.
      
              Tests: http/tests/xmlhttprequest/onabort-event.html
                     http/tests/xmlhttprequest/onerror-event.html
                     http/tests/xmlhttprequest/onloadstart-event.html
      
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::mark):
              (WebCore::JSXMLHttpRequest::onreadystatechange):
              (WebCore::JSXMLHttpRequest::onabort):
              (WebCore::JSXMLHttpRequest::setOnabort):
              (WebCore::JSXMLHttpRequest::onerror):
              (WebCore::JSXMLHttpRequest::setOnerror):
              (WebCore::JSXMLHttpRequest::onload):
              (WebCore::JSXMLHttpRequest::onloadstart):
              (WebCore::JSXMLHttpRequest::setOnloadstart):
              (WebCore::JSXMLHttpRequest::onprogress):
              * dom/EventNames.h:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::callReadyStateChangeListener):
              (WebCore::XMLHttpRequest::createRequest):
              (WebCore::XMLHttpRequest::abort):
              (WebCore::XMLHttpRequest::networkError):
              (WebCore::XMLHttpRequest::abortError):
              (WebCore::XMLHttpRequest::didFail):
              (WebCore::XMLHttpRequest::updateAndDispatchOnProgress):
              (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent):
              (WebCore::XMLHttpRequest::dispatchXMLHttpRequestProgressEvent):
              (WebCore::XMLHttpRequest::dispatchAbortEvent):
              (WebCore::XMLHttpRequest::dispatchErrorEvent):
              (WebCore::XMLHttpRequest::dispatchLoadEvent):
              (WebCore::XMLHttpRequest::dispatchLoadStartEvent):
              (WebCore::XMLHttpRequest::dispatchProgressEvent):
              * xml/XMLHttpRequest.h:
              (WebCore::XMLHttpRequest::setOnAbortListener):
              (WebCore::XMLHttpRequest::onAbortListener):
              (WebCore::XMLHttpRequest::setOnErrorListener):
              (WebCore::XMLHttpRequest::onErrorListener):
              (WebCore::XMLHttpRequest::setOnLoadStartListener):
              (WebCore::XMLHttpRequest::onLoadStartListener):
              * xml/XMLHttpRequest.idl:
      
      LayoutTests:
      
      2008-06-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Add tests for loadstart, abort and error events for XMLHttpRequests
      
              * http/tests/xmlhttprequest/onabort-event-expected.txt: Added.
              * http/tests/xmlhttprequest/onabort-event.html: Added.
              * http/tests/xmlhttprequest/onerror-event-expected.txt: Added.
              * http/tests/xmlhttprequest/onerror-event.html: Added.
              * http/tests/xmlhttprequest/onloadstart-event-expected.txt: Added.
              * http/tests/xmlhttprequest/onloadstart-event.html: Added.
              * http/tests/xmlhttprequest/resources/get.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0dac789
    • sullivan@apple.com's avatar
      2008-06-24 John Sullivan <sullivan@apple.com> · 756b97fd
      sullivan@apple.com authored
              Reviewed by Dan Bernstein
      
              * Scripts/extract-localizable-strings:
              add UI_STRING_LOCALIZE_LATER, LPCTSTR_UI_STRING_LOCALIZE_LATER, and LOG_WARNING to the 
              list of debugging macros, to avoid noise when keeping the list of localized string 
              exceptions up to date
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      756b97fd
    • darin@apple.com's avatar
      2008-06-24 Darin Adler <darin@apple.com> · abfe4880
      darin@apple.com authored
              Reviewed by Cameron.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=19739
                REGRESSION: fast/js/property-getters-and-setters.html fails
      
              * kjs/JSObject.cpp:
              (KJS::JSObject::put): Remove an untested optimization I checked in by accident.
              The two loops up the prototype chain both need to start from this; instead the
              second loop was starting where the first loop left off.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abfe4880
    • andersca@apple.com's avatar
      2008-06-24 Anders Carlsson <andersca@apple.com> · dcd1fa72
      andersca@apple.com authored
              Reviewed by Mitz.
      
              <rdar://problem/5957606>
              CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::DocumentLoader::cancelPendingSubstituteLoad + 23
      
              Remove the loader from the document loader after calling didFail, so that the loader will be deferred corectly
              in case the call do didFail starts a new run loop.
              
              * loader/NetscapePlugInStreamLoader.cpp:
              (WebCore::NetscapePlugInStreamLoader::didCancel):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcd1fa72
    • mitz@apple.com's avatar
      WebKitTools: · 4a84907d
      mitz@apple.com authored
              Rubber-stamped by Darin Adler.
      
              - add a font family for testing font-weight
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker
              flags to create data sections for the WeightWatcher fonts.
              * DumpRenderTree/fonts: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher100.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher200.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher300.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher400.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher500.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher600.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher700.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher800.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher900.ttf: Added.
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (activateFonts): Renamed activateAhemFont to this and made it activate
              the WeightWatcher fonts in addition to Ahem.
              (prepareConsistentTestingEnvironment): Adjusted for the name change.
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (initialize): Added the WeightWatcher fonts.
      
      LayoutTests:
      
              Rubber-stamped by Darin Adler.
      
              - add font-weight test for a family that has 9 weights
      
              * fast/css/font-weight-1.html: Added.
              * platform/mac/fast/css/font-weight-1-expected.checksum: Added.
              * platform/mac/fast/css/font-weight-1-expected.png: Added.
              * platform/mac/fast/css/font-weight-1-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a84907d
    • sfalken@apple.com's avatar
      Build fix. · 861f9388
      sfalken@apple.com authored
              * kjs/nodes.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      861f9388
    • sullivan@apple.com's avatar
      2008-06-24 John Sullivan <sullivan@apple.com> · 8d424516
      sullivan@apple.com authored
              Rubber-stamped by Sam Weinig
      
              * StringsNotToBeLocalized.txt:
              brought this file up to date
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d424516
    • ap@webkit.org's avatar
      Release build fix. · 986eafbb
      ap@webkit.org authored
              * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
              (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
              * bindings/js/JSCustomSQLTransactionCallback.cpp:
              (WebCore::JSCustomSQLTransactionCallback::handleEvent):
              Initialize callbackCallType, as the compiler is not smart enough to figure out data flow.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      986eafbb
    • hausmann@webkit.org's avatar
      2008-06-24 Joerg Bornemann <joerg.bornemann@trolltech.com> · e01e2d23
      hausmann@webkit.org authored
              Reviewed by Simon.
      
              For the Qt build on Windows don't depend on the presence of GNU CPP
              but use MSVC's preprocessor instead.
              dftables accepts a --preprocessor option which is set in pcre.pri for MSVC platforms.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e01e2d23
    • ap@webkit.org's avatar
      Reviewed by Darin. · 4874ebbb
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=19723
              REGRESSION(r34648): Some SVG tests crash when running under --threaded
      
              * rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::destroy): Do not attempt
              to paint during document destruction, because rendering structures are not kept in a
              consistent state then.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4874ebbb
    • hausmann@webkit.org's avatar
      2008-06-24 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> · 58630be5
      hausmann@webkit.org authored
              Reviewed by Darin.
      
              https://bugs.webkit.org/show_bug.cgi?id=19727
      
              Return bool from GraphicsContext::getShadow() so the tests aren't duplicated so
              many times in Cairo and Qt ports.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58630be5
    • hausmann@webkit.org's avatar
      2008-06-24 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> · 6b27f0e8
      hausmann@webkit.org authored
              Reviewed by Simon.
      
              https://bugs.webkit.org/show_bug.cgi?id=18459
      
              Clean up and remove unused platform shadow code.
      
              Minor edits by Simon, removed unused TextShadow struct.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b27f0e8
    • hausmann@webkit.org's avatar
      2008-06-24 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> · 1b973869
      hausmann@webkit.org authored
              Reviewed by Simon.
      
              https://bugs.webkit.org/show_bug.cgi?id=18459
      
              Implemented basic text-shadow support for the Qt port.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b973869
    • hausmann@webkit.org's avatar
      Fix the Qt build, adapt to various JSCore API changes. · 18c8dc99
      hausmann@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18c8dc99
    • ap@webkit.org's avatar
      Remove XMLHttpRequestProgressEvent.cpp from more project files. · d9249c5c
      ap@webkit.org authored
              * GNUmakefile.am:
              * WebCore.pro:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9249c5c
    • ap@webkit.org's avatar
      Reviewed by Cameron Zwarich. · 66868c0d
      ap@webkit.org authored
              Make ParserRefCountedCounter actually perform a leak check.
      
              * kjs/nodes.cpp:
              (KJS::ParserRefCountedCounter::~ParserRefCountedCounter): Check for leaks in destructor,
              not in constructor.
              (KJS::ParserRefCountedCounter::increment):
              (KJS::ParserRefCountedCounter::decrement):
              (KJS::ParserRefCounted::ParserRefCounted):
              (KJS::ParserRefCounted::~ParserRefCounted):
              While at it, also made counting thread-safe.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66868c0d
    • hausmann@webkit.org's avatar
      2008-06-24 Ariya Hidayat <ariya.hidayat@trolltech.com> · f8103d3a
      hausmann@webkit.org authored
              Reviewed by Simon.
      
              For the Qt port, fix linking with MinGW.
      
              * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8103d3a
    • cwzwarich@webkit.org's avatar
      2008-06-24 Cameron Zwarich <cwzwarich@uwaterloo.ca> · 2ccb78f6
      cwzwarich@webkit.org authored
              Reviewed by Oliver.
      
              Bug 19730: REGRESSION (r34497): Text in alerts in "Leisure suit Larry" is not wrapped
              <https://bugs.webkit.org/show_bug.cgi?id=19730>
      
              Do not convert the pair (less, jtrue) to jless when jtrue is a jump
              target. An example of this is when the condition of a while loop is a
              LogicalOrNode.
      
              JavaScriptCore:
      
              * VM/CodeGenerator.cpp:
              (KJS::CodeGenerator::emitLabel):
      
              LayoutTests:
      
              * fast/js/codegen-loops-logical-nodes-expected.txt: Added.
              * fast/js/codegen-loops-logical-nodes.html: Added.
              * fast/js/resources/codegen-loops-logical-nodes.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ccb78f6
    • hausmann@webkit.org's avatar
      2008-06-20 Ariya Hidayat <ariya.hidayat@trolltech.com> · 6b4c93f9
      hausmann@webkit.org authored
              Reviewed by Adam Roben.
      
              Fix compile with MinGW.
      
              * kjs/Shell.cpp:
              * wtf/Threading.h:
              (WTF::atomicIncrement):
              (WTF::atomicDecrement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b4c93f9
  3. 23 Jun, 2008 2 commits
    • mrowe@apple.com's avatar
      Prepration for returning memory to the OS on Windows. Track whether a portion... · 20c85fe3
      mrowe@apple.com authored
      Prepration for returning memory to the OS on Windows.  Track whether a portion of a span of memory was returned to the OS.
      If it was, ask that it be recommitted before returning it to the application as an allocated region.
      
      Reviewed by Oliver Hunt.
      
      * wtf/FastMalloc.cpp:
      (WTF::TCMalloc_PageHeap::New):  If the span was decommitted, ask that it be recommitted before returning it.
      (WTF::TCMalloc_PageHeap::AllocLarge):  Ditto.
      (WTF::TCMalloc_PageHeap::Carve):  When splitting a span, ensure that the decommitted state propogates to the two new spans.
      (WTF::TCMalloc_PageHeap::Delete):  When merging a span, ensure that the resulting span is marked as decommitted if any of the
      spans being merged were marked as decommitted.
      (WTF::TCMalloc_PageHeap::IncrementalScavenge):  Mark as decommitted after releasing the span.
      (WTF::TCMalloc_Central_FreeList::FetchFromSpans): Add an assertion to catch a decommitted span being returned to the application
      without first being recommitted.
      (WTF::TCMalloc_Central_FreeList::Populate): Ditto.
      * wtf/TCSystemAlloc.cpp: Stub out TCMalloc_SystemCommit.
      * wtf/TCSystemAlloc.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20c85fe3
    • mrowe@apple.com's avatar
      Remove the sample member of Span when NO_TCMALLOC_SAMPLES is defined. · 8ace5e01
      mrowe@apple.com authored
      Reviewed by Sam Weinig.
      
      * wtf/FastMalloc.cpp:
      (WTF::TCMalloc_PageHeap::Delete): Only update Span::sample if NO_TCMALLOC_SAMPLES is not defined.
      (WTF::TCMallocStats::do_free):  Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ace5e01