1. 23 Sep, 2011 2 commits
    • commit-queue@webkit.org's avatar
      .: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests · 90680248
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      Tests: fast/dom/scroll-element-to-rect-centered.html
             fast/dom/scroll-element-to-rect.html
      
      * WebCore.exp.in:
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollElementToRect):
      * page/FrameView.h:
      * testing/Internals.cpp:
      (WebCore::Internals::scrollElementToRect):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/chromium: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * public/WebView.h:
      (WebKit::WebView::scrollFocusedNodeIntoRect):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
      
      Source/WebKit2: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * fast/dom/scroll-element-to-rect-centered-expected.txt: Added.
      * fast/dom/scroll-element-to-rect-centered.html: Added.
      * fast/dom/scroll-element-to-rect-expected.txt: Added.
      * fast/dom/scroll-element-to-rect.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90680248
    • mhahnenberg@apple.com's avatar
      Add static version of JSCell::visitChildren · 982c9ea2
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68404
      
      Reviewed by Darin Adler.
      
      .: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * Source/autotools/symbols.filter:
      
      Source/JavaScriptCore: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * API/JSCallbackObject.h:
      (JSC::JSCallbackObject::visitChildrenVirtual):
      (JSC::JSCallbackObject::visitChildren):
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * debugger/DebuggerActivation.cpp:
      (JSC::DebuggerActivation::visitChildrenVirtual):
      (JSC::DebuggerActivation::visitChildren):
      * debugger/DebuggerActivation.h:
      * heap/MarkStack.cpp:
      (JSC::SlotVisitor::visitChildren):
      (JSC::SlotVisitor::drain):
      * runtime/Arguments.cpp:
      (JSC::Arguments::visitChildrenVirtual):
      (JSC::Arguments::visitChildren):
      * runtime/Arguments.h:
      * runtime/Executable.cpp:
      (JSC::EvalExecutable::visitChildrenVirtual):
      (JSC::EvalExecutable::visitChildren):
      (JSC::ProgramExecutable::visitChildrenVirtual):
      (JSC::ProgramExecutable::visitChildren):
      (JSC::FunctionExecutable::visitChildrenVirtual):
      (JSC::FunctionExecutable::visitChildren):
      * runtime/Executable.h:
      * runtime/GetterSetter.cpp:
      (JSC::GetterSetter::visitChildrenVirtual):
      (JSC::GetterSetter::visitChildren):
      * runtime/GetterSetter.h:
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::visitChildrenVirtual):
      (JSC::JSActivation::visitChildren):
      * runtime/JSActivation.h:
      * runtime/JSArray.cpp:
      (JSC::JSArray::visitChildrenVirtual):
      (JSC::JSArray::visitChildren):
      * runtime/JSArray.h:
      * runtime/JSBoundFunction.cpp:
      (JSC::JSBoundFunction::visitChildrenVirtual):
      (JSC::JSBoundFunction::visitChildren):
      * runtime/JSBoundFunction.h:
      * runtime/JSCell.h:
      (JSC::JSCell::visitChildrenVirtual):
      (JSC::JSCell::visitChildren):
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::visitChildrenVirtual):
      (JSC::JSFunction::visitChildren):
      * runtime/JSFunction.h:
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::visitChildrenVirtual):
      (JSC::JSGlobalObject::visitChildren):
      * runtime/JSGlobalObject.h:
      * runtime/JSObject.cpp:
      (JSC::JSObject::visitChildrenVirtual):
      (JSC::JSObject::visitChildren):
      * runtime/JSObject.h:
      (JSC::JSObject::visitChildrenDirect):
      * runtime/JSPropertyNameIterator.cpp:
      (JSC::JSPropertyNameIterator::visitChildrenVirtual):
      (JSC::JSPropertyNameIterator::visitChildren):
      * runtime/JSPropertyNameIterator.h:
      * runtime/JSStaticScopeObject.cpp:
      (JSC::JSStaticScopeObject::visitChildrenVirtual):
      (JSC::JSStaticScopeObject::visitChildren):
      * runtime/JSStaticScopeObject.h:
      * runtime/JSWrapperObject.cpp:
      (JSC::JSWrapperObject::visitChildrenVirtual):
      (JSC::JSWrapperObject::visitChildren):
      * runtime/JSWrapperObject.h:
      * runtime/NativeErrorConstructor.cpp:
      (JSC::NativeErrorConstructor::visitChildrenVirtual):
      (JSC::NativeErrorConstructor::visitChildren):
      * runtime/NativeErrorConstructor.h:
      * runtime/RegExpObject.cpp:
      (JSC::RegExpObject::visitChildrenVirtual):
      (JSC::RegExpObject::visitChildren):
      * runtime/RegExpObject.h:
      * runtime/ScopeChain.cpp:
      (JSC::ScopeChainNode::visitChildrenVirtual):
      (JSC::ScopeChainNode::visitChildren):
      * runtime/ScopeChain.h:
      * runtime/Structure.cpp:
      (JSC::Structure::visitChildrenVirtual):
      (JSC::Structure::visitChildren):
      * runtime/Structure.h:
      * runtime/StructureChain.cpp:
      (JSC::StructureChain::visitChildrenVirtual):
      (JSC::StructureChain::visitChildren):
      * runtime/StructureChain.h:
      
      Source/JavaScriptGlue: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * UserObjectImp.cpp:
      (UserObjectImp::visitChildrenVirtual):
      (UserObjectImp::visitChildren):
      * UserObjectImp.h:
      
      Source/WebCore: 
      
      No new tests.
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * WebCore.exp.in:
      * bindings/js/JSAttrCustom.cpp:
      (WebCore::JSAttr::visitChildrenVirtual):
      (WebCore::JSAttr::visitChildren):
      * bindings/js/JSAudioContextCustom.cpp:
      (WebCore::JSAudioContext::visitChildrenVirtual):
      (WebCore::JSAudioContext::visitChildren):
      * bindings/js/JSCSSRuleCustom.cpp:
      (WebCore::JSCSSRule::visitChildrenVirtual):
      (WebCore::JSCSSRule::visitChildren):
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      (WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
      (WebCore::JSCSSStyleDeclaration::visitChildren):
      * bindings/js/JSCanvasRenderingContextCustom.cpp:
      (WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
      (WebCore::JSCanvasRenderingContext::visitChildren):
      * bindings/js/JSDOMGlobalObject.cpp:
      (WebCore::JSDOMGlobalObject::visitChildrenVirtual):
      (WebCore::JSDOMGlobalObject::visitChildren):
      * bindings/js/JSDOMGlobalObject.h:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::visitChildrenVirtual):
      (WebCore::JSDOMWindow::visitChildren):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::visitChildrenVirtual):
      (WebCore::JSDOMWindowShell::visitChildren):
      * bindings/js/JSDOMWindowShell.h:
      * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
      (WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
      (WebCore::JSJavaScriptAudioNode::visitChildren):
      * bindings/js/JSMessageChannelCustom.cpp:
      (WebCore::JSMessageChannel::visitChildrenVirtual):
      (WebCore::JSMessageChannel::visitChildren):
      * bindings/js/JSMessagePortCustom.cpp:
      (WebCore::JSMessagePort::visitChildrenVirtual):
      (WebCore::JSMessagePort::visitChildren):
      * bindings/js/JSNamedNodeMapCustom.cpp:
      (WebCore::JSNamedNodeMap::visitChildrenVirtual):
      (WebCore::JSNamedNodeMap::visitChildren):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::JSNode::visitChildrenVirtual):
      (WebCore::JSNode::visitChildren):
      * bindings/js/JSNodeFilterCustom.cpp:
      (WebCore::JSNodeFilter::visitChildrenVirtual):
      (WebCore::JSNodeFilter::visitChildren):
      * bindings/js/JSNodeIteratorCustom.cpp:
      (WebCore::JSNodeIterator::visitChildrenVirtual):
      (WebCore::JSNodeIterator::visitChildren):
      * bindings/js/JSSVGElementInstanceCustom.cpp:
      (WebCore::JSSVGElementInstance::visitChildrenVirtual):
      (WebCore::JSSVGElementInstance::visitChildren):
      * bindings/js/JSSharedWorkerCustom.cpp:
      (WebCore::JSSharedWorker::visitChildrenVirtual):
      (WebCore::JSSharedWorker::visitChildren):
      * bindings/js/JSStyleSheetCustom.cpp:
      (WebCore::JSStyleSheet::visitChildrenVirtual):
      (WebCore::JSStyleSheet::visitChildren):
      * bindings/js/JSTreeWalkerCustom.cpp:
      (WebCore::JSTreeWalker::visitChildrenVirtual):
      (WebCore::JSTreeWalker::visitChildren):
      * bindings/js/JSWebGLRenderingContextCustom.cpp:
      (WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
      (WebCore::JSWebGLRenderingContext::visitChildren):
      * bindings/js/JSWorkerContextCustom.cpp:
      (WebCore::JSWorkerContext::visitChildrenVirtual):
      (WebCore::JSWorkerContext::visitChildren):
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::JSXMLHttpRequest::visitChildrenVirtual):
      (WebCore::JSXMLHttpRequest::visitChildren):
      * bindings/js/JSXPathResultCustom.cpp:
      (WebCore::JSXPathResult::visitChildrenVirtual):
      (WebCore::JSXPathResult::visitChildren):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::JSTestObj::visitChildrenVirtual):
      (WebCore::JSTestObj::visitChildren):
      * bindings/scripts/test/JS/JSTestObj.h:
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
      (JSC::Bindings::QtRuntimeObject::visitChildren):
      * bridge/qt/qt_runtime.cpp:
      (JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
      (JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
      * bridge/qt/qt_runtime.h:
      * workers/WorkerContext.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      982c9ea2
  2. 21 Sep, 2011 1 commit
    • jchaffraix@webkit.org's avatar
      Crash in RenderBox::paintMaskImages when GraphicsContext's painting is disabled · 3b543a32
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68133
      
      Reviewed by Darin Adler.
      
      .:
      
      * Source/autotools/symbols.filter: Added the mangled symbols needed for window.internals
      
      Source/WebCore:
      
      Tests: fast/css/webkit-mask-crash-fieldset-legend.html
             fast/css/webkit-mask-crash-figure.html
             fast/css/webkit-mask-crash-table.html
             fast/css/webkit-mask-crash-td-2.html
             fast/css/webkit-mask-crash-td.html
      
      GraphicsContext::getCTM crashes if called with a GraphicsContext that has painting
      disabled. RenderBox::paintMaskImages would thus crash if called in this condition.
      
      This change just modifies the different GraphicsContext::getCTM method to bail early
      if painting is disabled on the GraphicsContext. The rest of the change is exposing
      paintControlTints that exposes this.
      
      * WebCore.exp.in: Added symbols of the newly export window.internals function.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::updateControlTints): Split this function in 2 so that
      I can expose the internal paintControlTints.
      
      (WebCore::FrameView::paintControlTints):
      This is the one exposed to Internals as we want to be testable regardless of
      whether the platform supports control tints.
      
      * page/FrameView.h: Added paintControlTints.
      
      * testing/Internals.cpp:
      (WebCore::Internals::paintControlTints):
      * testing/Internals.h:
      * testing/Internals.idl:
      Added a way to force a fake painting so that we can easily reproduce the bugs.
      
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/qt/GraphicsContextQt.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/skia/GraphicsContextSkia.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/wince/GraphicsContextWinCE.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/wx/GraphicsContextWx.cpp:
      (WebCore::GraphicsContext::getCTM):
      Fixed all our back-end to exit early if painting is disabled.
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      Exported the new FrameView::paintControlTints function.
      
      LayoutTests:
      
      Those tests checks that we do not crash when calling internals.paintControlTints.
      
      * platform/mac/Skipped: Skipped 2 tests as they are hitting an ASSERT unrelated to
      this change on Mac.
      
      * fast/css/webkit-mask-crash-fieldset-legend-expected.txt: Added.
      * fast/css/webkit-mask-crash-fieldset-legend.html: Added.
      * fast/css/webkit-mask-crash-figure-expected.txt: Added.
      * fast/css/webkit-mask-crash-figure.html: Added.
      * fast/css/webkit-mask-crash-table-expected.txt: Added.
      * fast/css/webkit-mask-crash-table.html: Added.
      * fast/css/webkit-mask-crash-td-2-expected.txt: Added.
      * fast/css/webkit-mask-crash-td-2.html: Added.
      * fast/css/webkit-mask-crash-td-expected.txt: Added.
      * fast/css/webkit-mask-crash-td.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b543a32
  3. 07 Sep, 2011 1 commit
    • commit-queue@webkit.org's avatar
      Add test infrastructure to test rubber-banding overhang drawing along with... · a6e510e0
      commit-queue@webkit.org authored
      Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
      https://bugs.webkit.org/show_bug.cgi?id=67511
      
      Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-07
      Reviewed by Dimitri Glazkov.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Tests: platform/chromium-mac/rubberbanding/overhang-e.html
             platform/chromium-mac/rubberbanding/overhang-n.html
             platform/chromium-mac/rubberbanding/overhang-ne.html
             platform/chromium-mac/rubberbanding/overhang-nw.html
             platform/chromium-mac/rubberbanding/overhang-s.html
             platform/chromium-mac/rubberbanding/overhang-se.html
             platform/chromium-mac/rubberbanding/overhang-sw.html
             platform/chromium-mac/rubberbanding/overhang-w.html
      
      * WebCore.exp.in:
      * platform/ScrollableArea.h:
      * testing/Internals.cpp:
      (WebCore::Internals::setScrollViewPosition):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      * platform/chromium-mac/rubberbanding: Added.
      * platform/chromium-mac/rubberbanding/overhang-e-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-e-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-e.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-n-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-n-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-n.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-ne-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-ne-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-ne.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-nw-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-nw-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-nw.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-s-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-s-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-s.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-se-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-se-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-se.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-sw-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-sw-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-sw.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-w-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-w-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-w.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6e510e0
  4. 06 Sep, 2011 1 commit
    • rniwa@webkit.org's avatar
      REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on chromium · 73688cf4
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67453
      
      Reviewed by Kent Tamura.
      
      .: 
      
      Add symbols for internals.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: 
      
      Fixed the bug by updating inner text value in setSuggestedValue.
      
      Also added a suggestedValue and setSuggestedValue on window.internals for testing purposes.
      
      Test: fast/forms/suggested-value.html
      
      * WebCore.exp.in:
      * testing/Internals.cpp:
      (WebCore::Internals::suggestedValue):
      (WebCore::Internals::setSuggestedValue):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/chromium: 
      
      Chromium code incorrectly calls Node::isFocusable without updating layout, and was hitting assertions.
      Fix the assertion failure (and a potential crash) by updating layout in WebCore::isFocusable.
      
      * src/WebNode.cpp:
      (WebKit::WebNode::isFocusable):
      
      Source/WebKit2: 
      
      Add symbols for internals.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: 
      
      Added a regression test to ensure HTMLInputElement updates its inner text value when the suggested value is set.
      
      * fast/forms/suggested-value-expected.txt: Added.
      * fast/forms/suggested-value.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73688cf4
  5. 30 Aug, 2011 3 commits
  6. 19 Aug, 2011 1 commit
    • morrita@google.com's avatar
      .: Spell-checking doesn't recognize word boundaries on contests inserted by... · e6e56a6f
      morrita@google.com authored
      .: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      Add export for window.internals object.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      markMisspellingsAndBadGrammar() was using markSpelling() and markBadGrammar().
      But these are low-level API and caller should take care of word boundary.
      This change replaced these call with overloaded version of markMisspellingsAndBadGrammar(),
      which handles word boundary correctly.
      
      Test: editing/spelling/spelling-insert-html.html
      
      * WebCore.exp.in:
      * editing/Editor.cpp:
      (WebCore::Editor::markMisspellingsAndBadGrammar):
      * testing/Internals.cpp:
      (WebCore::Internals::markerCountOf): Added.
      (WebCore::Internals::markedRangeAt): Added.
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2: Spell-checking against execCommand() inserted HTML doesn't care word boundary.
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      Add exports for window.internals object.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      Existing expectation was wrong because of some markers on substrings of words.
      With this fix, Editor now rejects such markers.
      
      * editing/spelling/spelling-insert-html-expected.txt: Added.
      * editing/spelling/spelling-insert-html.html: Added.
      * platform/mac/editing/pasteboard/merge-after-delete-1-expected.png:
      * platform/mac/editing/pasteboard/merge-after-delete-2-expected.png:
      * platform/mac/editing/pasteboard/merge-after-delete-expected.png:
      * platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
      * platform/mac/editing/pasteboard/merge-end-list-expected.png:
      * platform/mac/editing/pasteboard/merge-end-table-expected.png:
      * platform/mac/editing/pasteboard/paste-text-008-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6e56a6f
  7. 09 Aug, 2011 1 commit
    • enne@google.com's avatar
      Add testing for --force-compositing-mode to windows.internal · 4d373182
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65777
      
      Reviewed by Adam Barth.
      
      .:
      
      Add exports for Document::settings().
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Test: platform/chromium/compositing/force-compositing-mode/force-composite-empty.html
      
      Move initial initialization to settings caching function so that RLC
      picks up changes to the force compositing mode flag.
      
      * WebCore.exp.in:
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::RenderLayerCompositor):
      (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
      (WebCore::RenderLayerCompositor::updateCompositingLayers):
      * testing/Internals.cpp:
      (WebCore::Internals::setForceCompositingMode):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      Add exports for Document::settings().
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      Add empty page to test that the root gets a graphics layer.
      
      * platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt: Added.
      * platform/chromium/compositing/force-compositing-mode/force-composite-empty.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d373182
  8. 01 Aug, 2011 2 commits
    • commit-queue@webkit.org's avatar
      .: REGRESSION (r39725?): Resources removed from document can not be freed... · 9acd5fe0
      commit-queue@webkit.org authored
      .: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
      https://bugs.webkit.org/show_bug.cgi?id=61006
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
      Reviewed by Antti Koivisto.
      
      Update exports for test harness.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: REGRESSION (r39725?): Resources removed from document can not be freed
      until the document is deleted
      https://bugs.webkit.org/show_bug.cgi?id=61006
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
      Reviewed by Antti Koivisto.
      
      Upon completing a load start a Timer to iterate through
      CachedResourceLoader's m_documentResources map to check for any items
      that have only one reference (thus being the reference in the map
      itself). The map should really be weak, but because the
      CachedResourceHandle achieves bookkeeping work in addition to
      reference counting, this is a simpler and more localized way to free
      the used memory while maintaining the other behaviour (when
      CachedResource is used as proxy).
      
      With this patch the testcase at
      https://bugs.webkit.org/attachment.cgi?id=93850 should no longer
      consume 400MB of ram on load. Test added for crash discovered in
      previous revision, but no tests for memory usage.
      
      Test: http/tests/inspector/network/disabled-cache-crash.html
      
      * WebCore.exp.in:
      * loader/cache/CachedResource.h:
      (WebCore::CachedResource::hasOneHandle):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::CachedResourceLoader):
      (WebCore::CachedResourceLoader::loadDone):
      (WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
      * loader/cache/CachedResourceLoader.h:
      * testing/Internals.cpp:
      (WebCore::Internals::disableMemoryCache):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
      https://bugs.webkit.org/show_bug.cgi?id=61006
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
      Reviewed by Antti Koivisto.
      
      Update exports for test harness.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=61006
      
      Test for CachedResourceLoader. Not caused by cache-disabling but very
      difficult to reproduce when cache is active, so use cache disable in
      inspector to exercise code.
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
      Reviewed by Antti Koivisto.
      
      * http/tests/inspector/network/disabled-cache-crash-expected.txt: Added.
      * http/tests/inspector/network/disabled-cache-crash.html: Added.
      * platform/gtk/Skipped:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9acd5fe0
    • hayato@chromium.org's avatar
      Add support for getting an element in shadow root by its id into a window.internals object. · 173c1ffd
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64587
      
      Reviewed by Hajime Morita.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Test: fast/dom/shadow/get-element-by-id-in-shadow-root.html
      
      * WebCore.exp.in:
      * testing/Internals.cpp:
      (WebCore::Internals::getElementByIdInShadowRoot):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      * fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt: Added.
      * fast/dom/shadow/get-element-by-id-in-shadow-root.html: Added.
      * fast/dom/shadow/resources/create-dom.js: Added.
      (createShadow):
      (createDom):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      173c1ffd
  9. 31 Jul, 2011 2 commits
  10. 18 Jul, 2011 1 commit
    • morrita@google.com's avatar
      .: [ShadowContentElement] forwarded node should be able to access its hosting content element. · d534c6d8
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      Added GTK symbols for new window.internals methods.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      - Introduced ShadowInclusionSet to manage included nodes to its includer content element.
        ShadowInclusionSet instance is owned by ShadowRoot.
      - Updated the set on inclusion list changes.
      - Used the set to retrieve the content element of NodeRenderingContext.
      
      There are also related refactoring and cleanup:
      - Renamed NodeRenderingContext::m_contentElement to m_includer
      - ShadowContentSelector::m_activeElement is no longer used, thus removed.
      
      Test: fast/dom/shadow/content-element-includer.html
      
      * WebCore.exp.in:
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      (WebCore::NodeRenderingContext::nextRenderer):
      (WebCore::NodeRenderingContext::previousRenderer):
      * dom/NodeRenderingContext.h:
      (WebCore::NodeRenderingContext::includer):
      * dom/ShadowContentElement.cpp:
      (WebCore::removeFromSet):
      (WebCore::addToSet):
      (WebCore::ShadowContentElement::attach):
      (WebCore::ShadowContentElement::detach):
      * dom/ShadowContentElement.h:
      (WebCore::ShadowInclusionSet::add):
      (WebCore::ShadowInclusionSet::remove):
      (WebCore::ShadowInclusionSet::isEmpty):
      (WebCore::ShadowInclusionSet::Translator::hash):
      (WebCore::ShadowInclusionSet::Translator::equal):
      (WebCore::ShadowInclusionSet::Hash::hash):
      (WebCore::ShadowInclusionSet::Hash::equal):
      (WebCore::ShadowInclusionSet::find):
      * dom/ShadowContentSelector.cpp:
      (WebCore::ShadowContentSelector::ShadowContentSelector):
      (WebCore::ShadowContentSelector::selectInclusion):
      * dom/ShadowContentSelector.h:
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::~ShadowRoot):
      (WebCore::ShadowRoot::includerFor):
      (WebCore::ShadowRoot::inclusions):
      (WebCore::ShadowRoot::ensureInclusions):
      * dom/ShadowRoot.h:
      (WebCore::toShadowRoot):
      * testing/Internals.cpp:
      (WebCore::Internals::includerFor):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      Exported additional symbols for window.internals object.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      - Added a new test.
      - Updated expectations. This change make ShadowContentElement availability on NodeRenderingContext
        more strict. that makes some redundant node disappeared.
      
      * fast/dom/shadow/content-element-includer-expected.txt: Added.
      * fast/dom/shadow/content-element-includer.html: Added.
      * platform/chromium-win/fast/html/details-nested-2-expected.txt:
      * platform/gtk/fast/html/details-nested-2-expected.txt:
      * platform/mac/fast/html/details-nested-2-expected.txt:
      * platform/qt/fast/html/details-nested-2-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d534c6d8
  11. 14 Jul, 2011 2 commits
    • morrita@google.com's avatar
      Unreviewed, rolling out r90976, r90981, and r90985. · 3d1224e7
      morrita@google.com authored
      http://trac.webkit.org/changeset/90976
      http://trac.webkit.org/changeset/90981
      http://trac.webkit.org/changeset/90985
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      build break
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      (WebCore::NodeRenderingContext::nextRenderer):
      (WebCore::NodeRenderingContext::previousRenderer):
      * dom/NodeRenderingContext.h:
      * dom/ShadowContentElement.cpp:
      (WebCore::ShadowContentElement::attach):
      (WebCore::ShadowContentElement::detach):
      * dom/ShadowContentElement.h:
      * dom/ShadowContentSelector.cpp:
      (WebCore::ShadowContentSelector::ShadowContentSelector):
      (WebCore::ShadowContentSelector::selectInclusion):
      (WebCore::ShadowContentSelector::willAttachContentFor):
      (WebCore::ShadowContentSelector::didAttachContent):
      (WebCore::ShadowContentSelector::activeElement):
      * dom/ShadowContentSelector.h:
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::~ShadowRoot):
      (WebCore::ShadowRoot::activeContentElement):
      * dom/ShadowRoot.h:
      * testing/Internals.cpp:
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      * fast/dom/shadow/content-element-includer-expected.txt: Removed.
      * fast/dom/shadow/content-element-includer.html: Removed.
      * platform/chromium-win/fast/html/details-nested-2-expected.txt:
      * platform/gtk/fast/html/details-nested-2-expected.txt:
      * platform/mac/fast/html/details-nested-2-expected.txt:
      * platform/qt/fast/html/details-nested-2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d1224e7
    • morrita@google.com's avatar
      Unreviewed attempt to build fix. · 2a8984ee
      morrita@google.com authored
      * Source/autotools/symbols.filter:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a8984ee
  12. 13 Jul, 2011 1 commit
    • morrita@google.com's avatar
      .: [ShadowContentElement] forwarded node should be able to access its hosting content element. · 3b337f86
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      Added GTK symbols for new window.internals methods.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      - Introduced ShadowInclusionSet to manage included nodes to its includer content element.
        ShadowInclusionSet instance is owned by ShadowRoot.
      - Updated the set on inclusion list changes.
      - Used the set to retrieve the content element of NodeRenderingContext.
      
      There are also related refactoring and cleanup:
      - Renamed NodeRenderingContext::m_contentElement to m_includer
      - ShadowContentSelector::m_activeElement is no longer used, thus removed.
      
      Test: fast/dom/shadow/content-element-includer.html
      
      * WebCore.exp.in:
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      (WebCore::NodeRenderingContext::nextRenderer):
      (WebCore::NodeRenderingContext::previousRenderer):
      * dom/NodeRenderingContext.h:
      (WebCore::NodeRenderingContext::includer):
      * dom/ShadowContentElement.cpp:
      (WebCore::removeFromSet): Added
      (WebCore::addToSet): Added
      (WebCore::ShadowContentElement::attach):
      (WebCore::ShadowContentElement::detach):
      * dom/ShadowContentElement.h:
      (WebCore::ShadowInclusionSet::add):
      (WebCore::ShadowInclusionSet::remove):
      (WebCore::ShadowInclusionSet::isEmpty):
      (WebCore::ShadowInclusionSet::Translator::hash):
      (WebCore::ShadowInclusionSet::Translator::equal):
      (WebCore::ShadowInclusionSet::Hash::hash):
      (WebCore::ShadowInclusionSet::Hash::equal):
      (WebCore::ShadowInclusionSet::find):
      * dom/ShadowContentSelector.cpp:
      (WebCore::ShadowContentSelector::ShadowContentSelector):
      (WebCore::ShadowContentSelector::selectInclusion):
      * dom/ShadowContentSelector.h:
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::~ShadowRoot):
      (WebCore::ShadowRoot::includerFor): Replaced activeElement()
      (WebCore::ShadowRoot::inclusions): Added
      (WebCore::ShadowRoot::ensureInclusions): Added
      * dom/ShadowRoot.h:
      (WebCore::toShadowRoot):
      * testing/Internals.cpp:
      (WebCore::Internals::includerFor):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      Exported additional symbols for window.internals object.
      
      * win/WebKit2.def:
      
      LayoutTests: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      - Added a new test.
      - Updated expectations. This change make ShadowContentElement availability on NodeRenderingContext
        more strict. that makes some redundant node disappeared.
      
      * fast/dom/shadow/content-element-includer-expected.txt: Added.
      * fast/dom/shadow/content-element-includer.html: Added.
      * platform/chromium-win/fast/html/details-nested-2-expected.txt:
      * platform/gtk/fast/html/details-nested-2-expected.txt:
      * platform/mac/fast/html/details-nested-2-expected.txt:
      * platform/qt/fast/html/details-nested-2-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b337f86
  13. 05 Jul, 2011 1 commit
    • vsevik@chromium.org's avatar
      2011-07-05 Vsevolod Vlasov <vsevik@chromium.org> · d8b27104
      vsevik@chromium.org authored
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Added GTK symbols for new window.internals methods.
      
              Reviewed by Pavel Feldman.
      
              * Source/autotools/symbols.filter:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Added tests for plugin content saving and replacing in NetworkResourcesData.
              Adjusted older tests to use new window.internals method setInspectorResourcesDataSizeLimits
              to ensure NetworkResourcesData is in the correct state before test.
      
              Reviewed by Pavel Feldman.
      
              * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-embed.html: Added.
              * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-xhr.html: Added.
              * http/tests/inspector/network/network-embed-expected.txt: Added.
              * http/tests/inspector/network/network-embed.html: Added.
              * http/tests/inspector/network/network-xhr-async-expected.txt:
              * http/tests/inspector/network/network-xhr-async.html:
              * http/tests/inspector/network/network-xhr-sync-expected.txt:
              * http/tests/inspector/network/network-xhr-sync.html:
              * http/tests/inspector/network/resources/cp1251.xml: Added.
              * http/tests/inspector/network/resources/plugin-data.php: Added.
              * http/tests/inspector/network/resources/resource.php:
              * http/tests/inspector/network/resources/utf8.xml: Added.
              * platform/chromium/test_expectations.txt:
      2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Now the data from didReceiveData callback is passed to inspector.
              It is then saved in NetworkResourcesData structure for plugin requests.
              Added window.internals.setInspectorResourcesDataSizeLimits() method
              for testing replacement logic.
      
              Reviewed by Pavel Feldman.
      
              Tests: http/tests/inspector/network/network-content-replacement-embed.html
                     http/tests/inspector/network/network-content-replacement-xhr.html
                     http/tests/inspector/network/network-embed.html
      
              * WebCore.exp.in:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didReceiveDataImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::didReceiveData):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::didReceiveData):
              (WebCore::InspectorResourceAgent::didFinishLoading):
              (WebCore::InspectorResourceAgent::setInitialXHRContent):
              (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
              (WebCore::InspectorResourceAgent::getResourceContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/NetworkResourcesData.cpp:
              (WebCore::NetworkResourcesData::ResourceData::ResourceData):
              (WebCore::NetworkResourcesData::ResourceData::setContent):
              (WebCore::NetworkResourcesData::ResourceData::purgeContent):
              (WebCore::NetworkResourcesData::ResourceData::createDecoder):
              (WebCore::NetworkResourcesData::ResourceData::dataLength):
              (WebCore::NetworkResourcesData::ResourceData::appendData):
              (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
              (WebCore::NetworkResourcesData::NetworkResourcesData):
              (WebCore::NetworkResourcesData::responseReceived):
              (WebCore::NetworkResourcesData::setResourceContent):
              (WebCore::NetworkResourcesData::maybeAddResourceData):
              (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
              (WebCore::NetworkResourcesData::data):
              (WebCore::NetworkResourcesData::clear):
              (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
              (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
              (WebCore::NetworkResourcesData::ensureFreeSpace):
              * inspector/NetworkResourcesData.h:
              (WebCore::NetworkResourcesData::ResourceData::hasContent):
              (WebCore::NetworkResourcesData::ResourceData::content):
              (WebCore::NetworkResourcesData::ResourceData::decoder):
              (WebCore::NetworkResourcesData::ResourceData::buffer):
              (WebCore::NetworkResourcesData::ResourceData::setBuffer):
              (WebCore::NetworkResourcesData::ResourceData::hasData):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype.get contentEncoded):
              * inspector/front-end/ResourcePreviewView.js:
              (WebInspector.ResourcePreviewView.prototype.contentLoaded):
              (WebInspector.ResourcePreviewView.prototype._createEmptyView):
              (WebInspector.ResourcePreviewView.prototype._createPreviewView):
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView.hasTextContent):
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::didReceiveData):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::willLoadMediaElementURL):
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::loadedResourceFromMemoryCache):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didReceiveData):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
              (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
              * loader/ResourceLoadNotifier.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::didReceiveData):
              * testing/Internals.cpp:
              (WebCore::Internals::setInspectorResourcesDataSizeLimits):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Added win symbols for new window.internals methods.
      
              Reviewed by Pavel Feldman.
      
              * win/WebKit2.def:
              * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8b27104
  14. 04 Jul, 2011 2 commits
    • commit-queue@webkit.org's avatar
      2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com> · 1e1df61f
      commit-queue@webkit.org authored
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * Source/autotools/symbols.filter:
      2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Removed.
              * http/tests/inspector/network/network-content-replacement-embed.html: Removed.
              * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Removed.
              * http/tests/inspector/network/network-content-replacement-xhr.html: Removed.
              * http/tests/inspector/network/network-embed-expected.txt: Removed.
              * http/tests/inspector/network/network-embed.html: Removed.
              * http/tests/inspector/network/network-xhr-async-expected.txt:
              * http/tests/inspector/network/network-xhr-async.html:
              * http/tests/inspector/network/network-xhr-sync-expected.txt:
              * http/tests/inspector/network/network-xhr-sync.html:
              * http/tests/inspector/network/resources/cp1251.xml: Removed.
              * http/tests/inspector/network/resources/plugin-data.php: Removed.
              * http/tests/inspector/network/resources/resource.php:
              * http/tests/inspector/network/resources/utf8.xml: Removed.
              * platform/chromium/test_expectations.txt:
      2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * WebCore.exp.in:
              * inspector/InspectorController.cpp:
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::didReceiveContentLength):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::didReceiveContentLength):
              (WebCore::InspectorResourceAgent::didFinishLoading):
              (WebCore::InspectorResourceAgent::setInitialXHRContent):
              (WebCore::InspectorResourceAgent::getResourceContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/NetworkResourcesData.cpp:
              (WebCore::NetworkResourcesData::ResourceData::ResourceData):
              (WebCore::NetworkResourcesData::ResourceData::content):
              (WebCore::NetworkResourcesData::ResourceData::appendContent):
              (WebCore::NetworkResourcesData::ResourceData::purgeContent):
              (WebCore::NetworkResourcesData::NetworkResourcesData):
              (WebCore::NetworkResourcesData::responseReceived):
              (WebCore::NetworkResourcesData::addResourceContent):
              (WebCore::NetworkResourcesData::data):
              (WebCore::NetworkResourcesData::clear):
              (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
              (WebCore::NetworkResourcesData::ensureFreeSpace):
              * inspector/NetworkResourcesData.h:
              (WebCore::NetworkResourcesData::ResourceData::hasContent):
              (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged):
              (WebCore::NetworkResourcesData::ResourceData::textEncodingName):
              (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
              * inspector/front-end/Resource.js:
              * inspector/front-end/ResourcePreviewView.js:
              (WebInspector.ResourcePreviewView.prototype.contentLoaded):
              (WebInspector.ResourcePreviewView.prototype._createInnerView):
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView.hasTextContent):
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::didReceiveData):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::willLoadMediaElementURL):
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::loadedResourceFromMemoryCache):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didReceiveData):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
              (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
              * loader/ResourceLoadNotifier.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::didReceiveData):
              * testing/Internals.cpp:
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * win/WebKit2.def:
              * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e1df61f
    • vsevik@chromium.org's avatar
      2011-07-04 Vsevolod Vlasov <vsevik@chromium.org> · 169a9b5d
      vsevik@chromium.org authored
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              * Source/autotools/symbols.filter:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-embed.html: Added.
              * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-xhr.html: Added.
              * http/tests/inspector/network/network-embed-expected.txt: Added.
              * http/tests/inspector/network/network-embed.html: Added.
              * http/tests/inspector/network/network-xhr-async-expected.txt:
              * http/tests/inspector/network/network-xhr-async.html:
              * http/tests/inspector/network/network-xhr-sync-expected.txt:
              * http/tests/inspector/network/network-xhr-sync.html:
              * http/tests/inspector/network/resources/cp1251.xml: Added.
              * http/tests/inspector/network/resources/plugin-data.php: Added.
              * http/tests/inspector/network/resources/resource.php:
              * http/tests/inspector/network/resources/utf8.xml: Added.
              * platform/chromium/test_expectations.txt:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              Tests: http/tests/inspector/network/network-content-replacement-embed.html
                     http/tests/inspector/network/network-content-replacement-xhr.html
                     http/tests/inspector/network/network-embed.html
      
              * WebCore.exp.in:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didReceiveDataImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::didReceiveData):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::didReceiveData):
              (WebCore::InspectorResourceAgent::didFinishLoading):
              (WebCore::InspectorResourceAgent::setInitialXHRContent):
              (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
              (WebCore::InspectorResourceAgent::getResourceContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/NetworkResourcesData.cpp:
              (WebCore::NetworkResourcesData::ResourceData::ResourceData):
              (WebCore::NetworkResourcesData::ResourceData::setContent):
              (WebCore::NetworkResourcesData::ResourceData::purgeContent):
              (WebCore::NetworkResourcesData::ResourceData::createDecoder):
              (WebCore::NetworkResourcesData::ResourceData::dataLength):
              (WebCore::NetworkResourcesData::ResourceData::appendData):
              (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
              (WebCore::NetworkResourcesData::NetworkResourcesData):
              (WebCore::NetworkResourcesData::responseReceived):
              (WebCore::NetworkResourcesData::setResourceContent):
              (WebCore::NetworkResourcesData::maybeAddResourceData):
              (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
              (WebCore::NetworkResourcesData::data):
              (WebCore::NetworkResourcesData::clear):
              (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
              (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
              (WebCore::NetworkResourcesData::ensureFreeSpace):
              * inspector/NetworkResourcesData.h:
              (WebCore::NetworkResourcesData::ResourceData::hasContent):
              (WebCore::NetworkResourcesData::ResourceData::content):
              (WebCore::NetworkResourcesData::ResourceData::decoder):
              (WebCore::NetworkResourcesData::ResourceData::buffer):
              (WebCore::NetworkResourcesData::ResourceData::setBuffer):
              (WebCore::NetworkResourcesData::ResourceData::hasData):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype.get contentEncoded):
              * inspector/front-end/ResourcePreviewView.js:
              (WebInspector.ResourcePreviewView.prototype.contentLoaded):
              (WebInspector.ResourcePreviewView.prototype._createEmptyView):
              (WebInspector.ResourcePreviewView.prototype._createPreviewView):
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView.hasTextContent):
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::didReceiveData):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::willLoadMediaElementURL):
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::loadedResourceFromMemoryCache):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didReceiveData):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
              (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
              * loader/ResourceLoadNotifier.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::didReceiveData):
              * testing/Internals.cpp:
              (WebCore::Internals::setInspectorResourcesDataSizeLimits):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              * win/WebKit2.def:
              * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      169a9b5d
  15. 24 Jun, 2011 1 commit
    • dominicc@chromium.org's avatar
      2011-06-24 Dominic Cooney <dominicc@chromium.org> · 958d2e44
      dominicc@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              * Source/autotools/symbols.filter: Export symbols for GTK.
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Update tests to use internals.{ensureShadowRoot, shadowRoot,
              shadowPseudoId, removeShadowRoot} instead of layoutTestController.
      
              * fast/dom/HTMLKeygenElement/keygen-expected.txt:
              * fast/dom/HTMLKeygenElement/keygen.html:
              * fast/dom/HTMLMeterElement/meter-clone-expected.txt:
              * fast/dom/HTMLMeterElement/meter-clone.html:
              * fast/dom/HTMLProgressElement/progress-clone-expected.txt:
              * fast/dom/HTMLProgressElement/progress-clone.html:
              * fast/dom/shadow/activeelement-should-be-shadowhost.html:
              * fast/dom/shadow/create-content-element.html:
              * fast/dom/shadow/gc-shadow-expected.txt:
              * fast/dom/shadow/gc-shadow.html:
              * fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: shadowRoot of non-element throws now, so verify new behavior.
              * fast/dom/shadow/layout-tests-can-access-shadow.html:
              * fast/dom/shadow/nodetype.html:
              * fast/dom/shadow/tab-order-iframe-and-shadow.html:
              * fast/events/shadow-boundary-crossing.html:
              * fast/forms/resources/common.js:
              (getValidationMessageBubbleNode):
              * fast/html/clone-keygen-expected.txt:
              * fast/html/clone-keygen.html:
              * fast/html/clone-range-expected.txt:
              * fast/html/clone-range.html:
              * fast/html/details-clone.html:
              * fullscreen/video-controls-override-expected.txt:
              * fullscreen/video-controls-override.html:
              * media/audio-controls-do-not-fade-out.html:
              * media/media-controls.js:
              (mediaControlsButtonCoordinates):
              * media/video-controls-in-media-document.html:
              * platform/win/Skipped: shadowRoot and friends now available on win.
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              * WebCore.exp.in: Exports for symbols used by WebCoreTestSupport.
              * testing/Internals.cpp: The new home of shadowRoot and friends.
              (WebCore::Internals::ensureShadowRoot):
              (WebCore::Internals::shadowRoot):
              (WebCore::Internals::removeShadowRoot):
              (WebCore::Internals::shadowPseudoId):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from Chromium API. These are not
              required any more.
      
              * public/WebElement.h:
              * src/WebElement.cpp:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow-DOM related methods from GTK DRT API. These are not
              required any more.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from Mac API. These are not
              required any more.
      
              * DOM/WebDOMOperations.mm:
              * DOM/WebDOMOperationsPrivate.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow-DOM related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow-DOM related methods from Qt DRT API. These are not
              required any more.
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from WebKit2 API. These are not
              required any more.
      
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
              * win/WebKit2.def: Re-exports for symbols used by WebCoreTestSupport.
              * win/WebKit2CFLite.def: Same for Cairo.
      2011-06-24  Dominic Cooney   <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
              removeShadowRoot from layoutTestController; these have been
              replaced by equivalents in window.internals instead.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      958d2e44
  16. 22 Jun, 2011 1 commit
    • japhet@chromium.org's avatar
      2011-06-22 Nate Chapin <japhet@chromium.org> · 94a630a0
      japhet@chromium.org authored
              Reviewed by Adam Barth.
      
              Add symbols required for window.internals.
              https://bugs.webkit.org/show_bug.cgi?id=62066
      
              * Source/autotools/symbols.filter:
      2011-06-22  Nate Chapin  <japhet@chromium.org>
      
              Reviewed by Adam Barth.
      
              Test updates for https://bugs.webkit.org/show_bug.cgi?id=62066.
      
              * fast/preloader/scan-body-from-head-import.html: Use window.internals.
              * fast/preloader/scan-body-from-head-script.html: Use window.internals.
              * http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt:
              * http/tests/loading/cross-origin-XHR-willLoadRequest.html:
              * http/tests/loading/preload-append-scan-expected.txt:
              * http/tests/loading/preload-append-scan.php: Use window.internals.
              * http/tests/misc/favicon-loads-with-icon-loading-override-expected.txt:
              * http/tests/misc/link-rel-icon-beforeload-expected.txt:
              * platform/chromium-linux/fast/preloader/scan-body-from-head-script-expected.txt:  Removed.
      2011-06-22  Nate Chapin  <japhet@chromium.org>
      
              Reviewed by Adam Barth.
      
              Don't let all subresources keep isLoadingInAPISense() from
              returning false, only requests that affect
              CachedResourceRequest::requestCount().
      
              Also, add a callback to Internals to determine whether
              a resource has been preloaded.
      
              https://bugs.webkit.org/show_bug.cgi?id=62066
      
              * WebCore.exp.in:
              * dom/Document.cpp: Add m_loadEventFinished.
              * dom/Document.h:
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::isLoadingInAPISense):
              * loader/cache/CachedResourceLoader.cpp:
              (WebCore::CachedResourceLoader::isPreloaded):
              * loader/cache/CachedResourceLoader.h:
              * testing/Internals.cpp:
              (WebCore::Internals::isPreloaded):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-06-22  Nate Chapin  <japhet@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add win symbols for new window.internals functionality.
              https://bugs.webkit.org/show_bug.cgi?id=62066
      
              * win/WebKit2.def:
      2011-06-22  Nate Chapin  <japhet@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add libsoup to libWebCoreInternals build.
              https://bugs.webkit.org/show_bug.cgi?id=62066
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94a630a0
  17. 20 Jun, 2011 2 commits
  18. 19 Jun, 2011 1 commit
    • morrita@google.com's avatar
      2011-06-19 MORITA Hajime <morrita@google.com> · 7837bc86
      morrita@google.com authored
              Reviewed by Dimitri Glazkov.
      
              The internals object should have createShadowContentElement()
              https://bugs.webkit.org/show_bug.cgi?id=62432
      
              * Source/autotools/symbols.filter: Added some more symbols necessary for
              window.internals to function to the global symbol list.
      
      2011-06-19  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              The internals object should have createShadowContentElement()
              https://bugs.webkit.org/show_bug.cgi?id=62432
      
              * fast/dom/shadow/create-content-element-expected.txt: Added.
              * fast/dom/shadow/create-content-element.html: Added.
      2011-06-19  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              The internals object should have createShadowContentElement()
              https://bugs.webkit.org/show_bug.cgi?id=62432
      
              This change:
              - added Internals::createShadowContentElement(), which creates,
                ShadowContentElement instance which includes all host children,
              - added Internals::elementRenderTreeAsText() to help content layout testing, and
              - Unabstracted ShadowContentElement by giving a default shouldInclude() implementation.
      
              Test: fast/dom/shadow/create-content-element.html
      
              * WebCore.exp.in:
              * dom/ShadowContentElement.cpp:
              (WebCore::ShadowContentElement::create): Added.
              (WebCore::ShadowContentElement::ShadowContentElement):
              (WebCore::ShadowContentElement::~ShadowContentElement):
              (WebCore::ShadowContentElement::shouldInclude): Gave a default implementation which always returns true.
              * dom/ShadowContentElement.h:
              * html/HTMLSummaryElement.cpp:
              (WebCore::SummaryContentElement::SummaryContentElement):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::externalRepresentation): Factored out for supportin per-element render tree dump.
              * rendering/RenderTreeAsText.h:
              * testing/Internals.cpp:
              (WebCore::Internals::createShadowContentElement): Added.
              (WebCore::Internals::elementRenderTreeAsText): dded.
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-06-19  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              The internals object should have createShadowContentElement()
              https://bugs.webkit.org/show_bug.cgi?id=62432
      
              * win/WebKit2.def: Added some more symbols necessary for
              window.internals to function to the global symbol list.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7837bc86
  19. 03 Jun, 2011 1 commit
  20. 04 Apr, 2011 1 commit
  21. 01 Jan, 2011 1 commit
  22. 27 Dec, 2010 1 commit
  23. 02 Dec, 2010 5 commits
  24. 25 Nov, 2010 2 commits
  25. 26 Oct, 2010 1 commit
    • tonikitoo@webkit.org's avatar
      [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea) · c574ee97
      tonikitoo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=48199
      
      Reviewed by Martin Robinson.
      Patch by Antonio Gomes <agomes@rim.com>
      
      .:
      
      * GNUmakefile.am: Added WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp|h to GTK+'s build system;
      * autotools/symbols.filter: Added DumpRenderTreeSupportGtk symbols to symbols.filter so they do not get
        filtered and get visible by DRT.
      
      WebKit/gtk:
      
      Implemented an initial version of the DumpRenderTreeSupportGtk class.
      The main idea is that it groups together the bodies of many LayoutTestController
      methods, so they can directly access WebCore features. This way we eliminate the
      need of adding APIs to WebKitGTK just to expand its test coverage through DRT.
      
      The DumpRenderTreeSupportGtk class so far includes a getter and setter for the WebKitTabToLinksPreferenceKey
      property as a sample implementation. Also it makes it possible to unskip fast/events/tab-focus-anchor.html and
      to fix stderr messages from all 22 spatial-navigation tests in fast/events/spatial-navigation.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::tabsToLinks):
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added.
      (DumpRenderTreeSupportGtk::DumpRenderTreeSupportGtk):
      (DumpRenderTreeSupportGtk::~DumpRenderTreeSupportGtk):
      (DumpRenderTreeSupportGtk::setDumpRenderTreeModeEnabled):
      (DumpRenderTreeSupportGtk::dumpRenderTreeModeEnabled): Getter to the WebKitTabToLinksPreferenceKey property.
      (DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain): Setter to the WebKitTabToLinksPreferenceKey property.
      (DumpRenderTreeSupportGtk::linksIncludedInFocusChain):
      * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added.
      
      WebKitTools:
      
      Implements support to WebKitTabToLinksPreferenceKey through LayoutTestController::overridePreference.
      The corresponding DumpRenderTreeSupportGtk method is called in the DRT context only.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (resetDefaultsToConsistentValues):
      (createWebView):
      * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
      (LayoutTestController::overridePreference):
      
      LayoutTests:
      
      * platform/gtk/Skipped: Unskiped fast/events/tab-focus-anchor.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c574ee97
  26. 28 Oct, 2009 1 commit
  27. 05 Apr, 2009 1 commit