1. 23 Sep, 2011 1 commit
    • commit-queue@webkit.org's avatar
      .: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests · 90680248
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      Tests: fast/dom/scroll-element-to-rect-centered.html
             fast/dom/scroll-element-to-rect.html
      
      * WebCore.exp.in:
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollElementToRect):
      * page/FrameView.h:
      * testing/Internals.cpp:
      (WebCore::Internals::scrollElementToRect):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/chromium: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * public/WebView.h:
      (WebKit::WebView::scrollFocusedNodeIntoRect):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
      
      Source/WebKit2: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * fast/dom/scroll-element-to-rect-centered-expected.txt: Added.
      * fast/dom/scroll-element-to-rect-centered.html: Added.
      * fast/dom/scroll-element-to-rect-expected.txt: Added.
      * fast/dom/scroll-element-to-rect.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90680248
  2. 21 Sep, 2011 1 commit
    • jchaffraix@webkit.org's avatar
      Crash in RenderBox::paintMaskImages when GraphicsContext's painting is disabled · 3b543a32
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68133
      
      Reviewed by Darin Adler.
      
      .:
      
      * Source/autotools/symbols.filter: Added the mangled symbols needed for window.internals
      
      Source/WebCore:
      
      Tests: fast/css/webkit-mask-crash-fieldset-legend.html
             fast/css/webkit-mask-crash-figure.html
             fast/css/webkit-mask-crash-table.html
             fast/css/webkit-mask-crash-td-2.html
             fast/css/webkit-mask-crash-td.html
      
      GraphicsContext::getCTM crashes if called with a GraphicsContext that has painting
      disabled. RenderBox::paintMaskImages would thus crash if called in this condition.
      
      This change just modifies the different GraphicsContext::getCTM method to bail early
      if painting is disabled on the GraphicsContext. The rest of the change is exposing
      paintControlTints that exposes this.
      
      * WebCore.exp.in: Added symbols of the newly export window.internals function.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::updateControlTints): Split this function in 2 so that
      I can expose the internal paintControlTints.
      
      (WebCore::FrameView::paintControlTints):
      This is the one exposed to Internals as we want to be testable regardless of
      whether the platform supports control tints.
      
      * page/FrameView.h: Added paintControlTints.
      
      * testing/Internals.cpp:
      (WebCore::Internals::paintControlTints):
      * testing/Internals.h:
      * testing/Internals.idl:
      Added a way to force a fake painting so that we can easily reproduce the bugs.
      
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/qt/GraphicsContextQt.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/skia/GraphicsContextSkia.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/wince/GraphicsContextWinCE.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/wx/GraphicsContextWx.cpp:
      (WebCore::GraphicsContext::getCTM):
      Fixed all our back-end to exit early if painting is disabled.
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      Exported the new FrameView::paintControlTints function.
      
      LayoutTests:
      
      Those tests checks that we do not crash when calling internals.paintControlTints.
      
      * platform/mac/Skipped: Skipped 2 tests as they are hitting an ASSERT unrelated to
      this change on Mac.
      
      * fast/css/webkit-mask-crash-fieldset-legend-expected.txt: Added.
      * fast/css/webkit-mask-crash-fieldset-legend.html: Added.
      * fast/css/webkit-mask-crash-figure-expected.txt: Added.
      * fast/css/webkit-mask-crash-figure.html: Added.
      * fast/css/webkit-mask-crash-table-expected.txt: Added.
      * fast/css/webkit-mask-crash-table.html: Added.
      * fast/css/webkit-mask-crash-td-2-expected.txt: Added.
      * fast/css/webkit-mask-crash-td-2.html: Added.
      * fast/css/webkit-mask-crash-td-expected.txt: Added.
      * fast/css/webkit-mask-crash-td.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b543a32
  3. 07 Sep, 2011 1 commit
    • commit-queue@webkit.org's avatar
      Add test infrastructure to test rubber-banding overhang drawing along with... · a6e510e0
      commit-queue@webkit.org authored
      Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
      https://bugs.webkit.org/show_bug.cgi?id=67511
      
      Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-07
      Reviewed by Dimitri Glazkov.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Tests: platform/chromium-mac/rubberbanding/overhang-e.html
             platform/chromium-mac/rubberbanding/overhang-n.html
             platform/chromium-mac/rubberbanding/overhang-ne.html
             platform/chromium-mac/rubberbanding/overhang-nw.html
             platform/chromium-mac/rubberbanding/overhang-s.html
             platform/chromium-mac/rubberbanding/overhang-se.html
             platform/chromium-mac/rubberbanding/overhang-sw.html
             platform/chromium-mac/rubberbanding/overhang-w.html
      
      * WebCore.exp.in:
      * platform/ScrollableArea.h:
      * testing/Internals.cpp:
      (WebCore::Internals::setScrollViewPosition):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      * platform/chromium-mac/rubberbanding: Added.
      * platform/chromium-mac/rubberbanding/overhang-e-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-e-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-e.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-n-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-n-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-n.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-ne-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-ne-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-ne.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-nw-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-nw-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-nw.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-s-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-s-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-s.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-se-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-se-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-se.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-sw-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-sw-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-sw.html: Added.
      * platform/chromium-mac/rubberbanding/overhang-w-expected.png: Added.
      * platform/chromium-mac/rubberbanding/overhang-w-expected.txt: Added.
      * platform/chromium-mac/rubberbanding/overhang-w.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6e510e0
  4. 06 Sep, 2011 2 commits
    • rniwa@webkit.org's avatar
      fast/forms/suggested-value-crash.html crashes on Windows · 8f35f0e6
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67688
      
      Reviewed by Adam Barth.
      
      Source/WebCore: 
      
      The crash was caused because functions in internals were accessing uninitialized QualifiedNames.
      Fixed the bug by avoiding to link to inputTag and textareaTag. Instead, we resort to toInputElement
      and string comparison.
      
      * testing/Internals.cpp:
      (WebCore::Internals::wasLastChangeUserEdit):
      (WebCore::Internals::suggestedValue):
      (WebCore::Internals::setSuggestedValue):
      
      Source/WebKit2: 
      
      Removed sybmols for inputTag and textareaTag. Added the symbol for StringImpl::equal.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f35f0e6
    • rniwa@webkit.org's avatar
      REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on chromium · 73688cf4
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67453
      
      Reviewed by Kent Tamura.
      
      .: 
      
      Add symbols for internals.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: 
      
      Fixed the bug by updating inner text value in setSuggestedValue.
      
      Also added a suggestedValue and setSuggestedValue on window.internals for testing purposes.
      
      Test: fast/forms/suggested-value.html
      
      * WebCore.exp.in:
      * testing/Internals.cpp:
      (WebCore::Internals::suggestedValue):
      (WebCore::Internals::setSuggestedValue):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/chromium: 
      
      Chromium code incorrectly calls Node::isFocusable without updating layout, and was hitting assertions.
      Fix the assertion failure (and a potential crash) by updating layout in WebCore::isFocusable.
      
      * src/WebNode.cpp:
      (WebKit::WebNode::isFocusable):
      
      Source/WebKit2: 
      
      Add symbols for internals.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: 
      
      Added a regression test to ensure HTMLInputElement updates its inner text value when the suggested value is set.
      
      * fast/forms/suggested-value-expected.txt: Added.
      * fast/forms/suggested-value.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73688cf4
  5. 30 Aug, 2011 1 commit
  6. 29 Aug, 2011 2 commits
  7. 19 Aug, 2011 1 commit
    • morrita@google.com's avatar
      .: Spell-checking doesn't recognize word boundaries on contests inserted by... · e6e56a6f
      morrita@google.com authored
      .: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      Add export for window.internals object.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      markMisspellingsAndBadGrammar() was using markSpelling() and markBadGrammar().
      But these are low-level API and caller should take care of word boundary.
      This change replaced these call with overloaded version of markMisspellingsAndBadGrammar(),
      which handles word boundary correctly.
      
      Test: editing/spelling/spelling-insert-html.html
      
      * WebCore.exp.in:
      * editing/Editor.cpp:
      (WebCore::Editor::markMisspellingsAndBadGrammar):
      * testing/Internals.cpp:
      (WebCore::Internals::markerCountOf): Added.
      (WebCore::Internals::markedRangeAt): Added.
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2: Spell-checking against execCommand() inserted HTML doesn't care word boundary.
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      Add exports for window.internals object.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      Existing expectation was wrong because of some markers on substrings of words.
      With this fix, Editor now rejects such markers.
      
      * editing/spelling/spelling-insert-html-expected.txt: Added.
      * editing/spelling/spelling-insert-html.html: Added.
      * platform/mac/editing/pasteboard/merge-after-delete-1-expected.png:
      * platform/mac/editing/pasteboard/merge-after-delete-2-expected.png:
      * platform/mac/editing/pasteboard/merge-after-delete-expected.png:
      * platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
      * platform/mac/editing/pasteboard/merge-end-list-expected.png:
      * platform/mac/editing/pasteboard/merge-end-table-expected.png:
      * platform/mac/editing/pasteboard/paste-text-008-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6e56a6f
  8. 09 Aug, 2011 1 commit
    • enne@google.com's avatar
      Add testing for --force-compositing-mode to windows.internal · 4d373182
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65777
      
      Reviewed by Adam Barth.
      
      .:
      
      Add exports for Document::settings().
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Test: platform/chromium/compositing/force-compositing-mode/force-composite-empty.html
      
      Move initial initialization to settings caching function so that RLC
      picks up changes to the force compositing mode flag.
      
      * WebCore.exp.in:
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::RenderLayerCompositor):
      (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
      (WebCore::RenderLayerCompositor::updateCompositingLayers):
      * testing/Internals.cpp:
      (WebCore::Internals::setForceCompositingMode):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      Add exports for Document::settings().
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      Add empty page to test that the root gets a graphics layer.
      
      * platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt: Added.
      * platform/chromium/compositing/force-compositing-mode/force-composite-empty.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d373182
  9. 01 Aug, 2011 2 commits
    • commit-queue@webkit.org's avatar
      .: REGRESSION (r39725?): Resources removed from document can not be freed... · 9acd5fe0
      commit-queue@webkit.org authored
      .: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
      https://bugs.webkit.org/show_bug.cgi?id=61006
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
      Reviewed by Antti Koivisto.
      
      Update exports for test harness.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: REGRESSION (r39725?): Resources removed from document can not be freed
      until the document is deleted
      https://bugs.webkit.org/show_bug.cgi?id=61006
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
      Reviewed by Antti Koivisto.
      
      Upon completing a load start a Timer to iterate through
      CachedResourceLoader's m_documentResources map to check for any items
      that have only one reference (thus being the reference in the map
      itself). The map should really be weak, but because the
      CachedResourceHandle achieves bookkeeping work in addition to
      reference counting, this is a simpler and more localized way to free
      the used memory while maintaining the other behaviour (when
      CachedResource is used as proxy).
      
      With this patch the testcase at
      https://bugs.webkit.org/attachment.cgi?id=93850 should no longer
      consume 400MB of ram on load. Test added for crash discovered in
      previous revision, but no tests for memory usage.
      
      Test: http/tests/inspector/network/disabled-cache-crash.html
      
      * WebCore.exp.in:
      * loader/cache/CachedResource.h:
      (WebCore::CachedResource::hasOneHandle):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::CachedResourceLoader):
      (WebCore::CachedResourceLoader::loadDone):
      (WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
      * loader/cache/CachedResourceLoader.h:
      * testing/Internals.cpp:
      (WebCore::Internals::disableMemoryCache):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
      https://bugs.webkit.org/show_bug.cgi?id=61006
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
      Reviewed by Antti Koivisto.
      
      Update exports for test harness.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=61006
      
      Test for CachedResourceLoader. Not caused by cache-disabling but very
      difficult to reproduce when cache is active, so use cache disable in
      inspector to exercise code.
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
      Reviewed by Antti Koivisto.
      
      * http/tests/inspector/network/disabled-cache-crash-expected.txt: Added.
      * http/tests/inspector/network/disabled-cache-crash.html: Added.
      * platform/gtk/Skipped:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9acd5fe0
    • hayato@chromium.org's avatar
      Add support for getting an element in shadow root by its id into a window.internals object. · 173c1ffd
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64587
      
      Reviewed by Hajime Morita.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Test: fast/dom/shadow/get-element-by-id-in-shadow-root.html
      
      * WebCore.exp.in:
      * testing/Internals.cpp:
      (WebCore::Internals::getElementByIdInShadowRoot):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      * fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt: Added.
      * fast/dom/shadow/get-element-by-id-in-shadow-root.html: Added.
      * fast/dom/shadow/resources/create-dom.js: Added.
      (createShadow):
      (createDom):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      173c1ffd
  10. 31 Jul, 2011 1 commit
  11. 18 Jul, 2011 1 commit
    • morrita@google.com's avatar
      .: [ShadowContentElement] forwarded node should be able to access its hosting content element. · d534c6d8
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      Added GTK symbols for new window.internals methods.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      - Introduced ShadowInclusionSet to manage included nodes to its includer content element.
        ShadowInclusionSet instance is owned by ShadowRoot.
      - Updated the set on inclusion list changes.
      - Used the set to retrieve the content element of NodeRenderingContext.
      
      There are also related refactoring and cleanup:
      - Renamed NodeRenderingContext::m_contentElement to m_includer
      - ShadowContentSelector::m_activeElement is no longer used, thus removed.
      
      Test: fast/dom/shadow/content-element-includer.html
      
      * WebCore.exp.in:
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      (WebCore::NodeRenderingContext::nextRenderer):
      (WebCore::NodeRenderingContext::previousRenderer):
      * dom/NodeRenderingContext.h:
      (WebCore::NodeRenderingContext::includer):
      * dom/ShadowContentElement.cpp:
      (WebCore::removeFromSet):
      (WebCore::addToSet):
      (WebCore::ShadowContentElement::attach):
      (WebCore::ShadowContentElement::detach):
      * dom/ShadowContentElement.h:
      (WebCore::ShadowInclusionSet::add):
      (WebCore::ShadowInclusionSet::remove):
      (WebCore::ShadowInclusionSet::isEmpty):
      (WebCore::ShadowInclusionSet::Translator::hash):
      (WebCore::ShadowInclusionSet::Translator::equal):
      (WebCore::ShadowInclusionSet::Hash::hash):
      (WebCore::ShadowInclusionSet::Hash::equal):
      (WebCore::ShadowInclusionSet::find):
      * dom/ShadowContentSelector.cpp:
      (WebCore::ShadowContentSelector::ShadowContentSelector):
      (WebCore::ShadowContentSelector::selectInclusion):
      * dom/ShadowContentSelector.h:
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::~ShadowRoot):
      (WebCore::ShadowRoot::includerFor):
      (WebCore::ShadowRoot::inclusions):
      (WebCore::ShadowRoot::ensureInclusions):
      * dom/ShadowRoot.h:
      (WebCore::toShadowRoot):
      * testing/Internals.cpp:
      (WebCore::Internals::includerFor):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      Exported additional symbols for window.internals object.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: [ShadowContentElement] forwarded node should be able to access its hosting content element.
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      Reviewed by Dimitri Glazkov.
      
      - Added a new test.
      - Updated expectations. This change make ShadowContentElement availability on NodeRenderingContext
        more strict. that makes some redundant node disappeared.
      
      * fast/dom/shadow/content-element-includer-expected.txt: Added.
      * fast/dom/shadow/content-element-includer.html: Added.
      * platform/chromium-win/fast/html/details-nested-2-expected.txt:
      * platform/gtk/fast/html/details-nested-2-expected.txt:
      * platform/mac/fast/html/details-nested-2-expected.txt:
      * platform/qt/fast/html/details-nested-2-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d534c6d8
  12. 14 Jul, 2011 2 commits
    • morrita@google.com's avatar
      Unreviewed, rolling out r90976, r90981, and r90985. · 3d1224e7
      morrita@google.com authored
      http://trac.webkit.org/changeset/90976
      http://trac.webkit.org/changeset/90981
      http://trac.webkit.org/changeset/90985
      https://bugs.webkit.org/show_bug.cgi?id=64251
      
      build break
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      (WebCore::NodeRenderingContext::nextRenderer):
      (WebCore::NodeRenderingContext::previousRenderer):
      * dom/NodeRenderingContext.h:
      * dom/ShadowContentElement.cpp:
      (WebCore::ShadowContentElement::attach):
      (WebCore::ShadowContentElement::detach):
      * dom/ShadowContentElement.h:
      * dom/ShadowContentSelector.cpp:
      (WebCore::ShadowContentSelector::ShadowContentSelector):
      (WebCore::ShadowContentSelector::selectInclusion):
      (WebCore::ShadowContentSelector::willAttachContentFor):
      (WebCore::ShadowContentSelector::didAttachContent):
      (WebCore::ShadowContentSelector::activeElement):
      * dom/ShadowContentSelector.h:
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::~ShadowRoot):
      (WebCore::ShadowRoot::activeContentElement):
      * dom/ShadowRoot.h:
      * testing/Internals.cpp:
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      * fast/dom/shadow/content-element-includer-expected.txt: Removed.
      * fast/dom/shadow/content-element-includer.html: Removed.
      * platform/chromium-win/fast/html/details-nested-2-expected.txt:
      * platform/gtk/fast/html/details-nested-2-expected.txt:
      * platform/mac/fast/html/details-nested-2-expected.txt:
      * platform/qt/fast/html/details-nested-2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d1224e7
    • morrita@google.com's avatar
      Unreviewed attempt at a build fix. · af9841e3
      morrita@google.com authored
      * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af9841e3
  13. 13 Jul, 2011 1 commit
    • bfulgham@webkit.org's avatar
      Standardize WinCairo conditionalized code under PLATFORM macro. · 5fcb8a1b
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64377
      
      Reviewed by Maciej Stachowiak.
      
      Source/JavaScriptCore: 
      
      * wtf/Platform.h: Update to use PLATFORM(WIN_CAIRO) for tests.
      
      Source/WebCore: 
      
      Update compile-time conditions that had previously used #ifdef
      of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).
      
      * WebCore.vcproj/WebCoreCairo.vsprops: Remove redundant declaration
        of WIN_CAIRO.
      * WebCore.vcproj/WebCoreDebugCairoCFLite.vsprops: Update to use
        the existing WinCairo.vsprops file.
      * WebCorePrefix.h: Update for new WTF_PLATFORM_WIN_CAIRO define.
      * config.h: Update to use PLATFORM(WIN_CAIRO).
      
      Tools: 
      
      Update compile-time conditions that had previously used #ifdef
      of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).
      
      * DumpRenderTree/config.h: Switch to PLATFORM(WIN_CAIRO)
      * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Remove redundant
        define of WIN_CAIRO=1.
      * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Add
        WinCairo.vsprops to set (to match Release build).
      
      WebKitLibraries: 
      
      * win/tools/vsprops/WinCairo.vsprops: Update to comply with PLATFORM
        macro definition (WTF_PLATFORM_WIN_CAIRO)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fcb8a1b
  14. 05 Jul, 2011 1 commit
    • vsevik@chromium.org's avatar
      2011-07-05 Vsevolod Vlasov <vsevik@chromium.org> · d8b27104
      vsevik@chromium.org authored
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Added GTK symbols for new window.internals methods.
      
              Reviewed by Pavel Feldman.
      
              * Source/autotools/symbols.filter:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Added tests for plugin content saving and replacing in NetworkResourcesData.
              Adjusted older tests to use new window.internals method setInspectorResourcesDataSizeLimits
              to ensure NetworkResourcesData is in the correct state before test.
      
              Reviewed by Pavel Feldman.
      
              * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-embed.html: Added.
              * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-xhr.html: Added.
              * http/tests/inspector/network/network-embed-expected.txt: Added.
              * http/tests/inspector/network/network-embed.html: Added.
              * http/tests/inspector/network/network-xhr-async-expected.txt:
              * http/tests/inspector/network/network-xhr-async.html:
              * http/tests/inspector/network/network-xhr-sync-expected.txt:
              * http/tests/inspector/network/network-xhr-sync.html:
              * http/tests/inspector/network/resources/cp1251.xml: Added.
              * http/tests/inspector/network/resources/plugin-data.php: Added.
              * http/tests/inspector/network/resources/resource.php:
              * http/tests/inspector/network/resources/utf8.xml: Added.
              * platform/chromium/test_expectations.txt:
      2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Now the data from didReceiveData callback is passed to inspector.
              It is then saved in NetworkResourcesData structure for plugin requests.
              Added window.internals.setInspectorResourcesDataSizeLimits() method
              for testing replacement logic.
      
              Reviewed by Pavel Feldman.
      
              Tests: http/tests/inspector/network/network-content-replacement-embed.html
                     http/tests/inspector/network/network-content-replacement-xhr.html
                     http/tests/inspector/network/network-embed.html
      
              * WebCore.exp.in:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didReceiveDataImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::didReceiveData):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::didReceiveData):
              (WebCore::InspectorResourceAgent::didFinishLoading):
              (WebCore::InspectorResourceAgent::setInitialXHRContent):
              (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
              (WebCore::InspectorResourceAgent::getResourceContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/NetworkResourcesData.cpp:
              (WebCore::NetworkResourcesData::ResourceData::ResourceData):
              (WebCore::NetworkResourcesData::ResourceData::setContent):
              (WebCore::NetworkResourcesData::ResourceData::purgeContent):
              (WebCore::NetworkResourcesData::ResourceData::createDecoder):
              (WebCore::NetworkResourcesData::ResourceData::dataLength):
              (WebCore::NetworkResourcesData::ResourceData::appendData):
              (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
              (WebCore::NetworkResourcesData::NetworkResourcesData):
              (WebCore::NetworkResourcesData::responseReceived):
              (WebCore::NetworkResourcesData::setResourceContent):
              (WebCore::NetworkResourcesData::maybeAddResourceData):
              (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
              (WebCore::NetworkResourcesData::data):
              (WebCore::NetworkResourcesData::clear):
              (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
              (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
              (WebCore::NetworkResourcesData::ensureFreeSpace):
              * inspector/NetworkResourcesData.h:
              (WebCore::NetworkResourcesData::ResourceData::hasContent):
              (WebCore::NetworkResourcesData::ResourceData::content):
              (WebCore::NetworkResourcesData::ResourceData::decoder):
              (WebCore::NetworkResourcesData::ResourceData::buffer):
              (WebCore::NetworkResourcesData::ResourceData::setBuffer):
              (WebCore::NetworkResourcesData::ResourceData::hasData):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype.get contentEncoded):
              * inspector/front-end/ResourcePreviewView.js:
              (WebInspector.ResourcePreviewView.prototype.contentLoaded):
              (WebInspector.ResourcePreviewView.prototype._createEmptyView):
              (WebInspector.ResourcePreviewView.prototype._createPreviewView):
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView.hasTextContent):
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::didReceiveData):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::willLoadMediaElementURL):
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::loadedResourceFromMemoryCache):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didReceiveData):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
              (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
              * loader/ResourceLoadNotifier.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::didReceiveData):
              * testing/Internals.cpp:
              (WebCore::Internals::setInspectorResourcesDataSizeLimits):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Added win symbols for new window.internals methods.
      
              Reviewed by Pavel Feldman.
      
              * win/WebKit2.def:
              * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8b27104
  15. 04 Jul, 2011 2 commits
    • commit-queue@webkit.org's avatar
      2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com> · 1e1df61f
      commit-queue@webkit.org authored
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * Source/autotools/symbols.filter:
      2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Removed.
              * http/tests/inspector/network/network-content-replacement-embed.html: Removed.
              * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Removed.
              * http/tests/inspector/network/network-content-replacement-xhr.html: Removed.
              * http/tests/inspector/network/network-embed-expected.txt: Removed.
              * http/tests/inspector/network/network-embed.html: Removed.
              * http/tests/inspector/network/network-xhr-async-expected.txt:
              * http/tests/inspector/network/network-xhr-async.html:
              * http/tests/inspector/network/network-xhr-sync-expected.txt:
              * http/tests/inspector/network/network-xhr-sync.html:
              * http/tests/inspector/network/resources/cp1251.xml: Removed.
              * http/tests/inspector/network/resources/plugin-data.php: Removed.
              * http/tests/inspector/network/resources/resource.php:
              * http/tests/inspector/network/resources/utf8.xml: Removed.
              * platform/chromium/test_expectations.txt:
      2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * WebCore.exp.in:
              * inspector/InspectorController.cpp:
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::didReceiveContentLength):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::didReceiveContentLength):
              (WebCore::InspectorResourceAgent::didFinishLoading):
              (WebCore::InspectorResourceAgent::setInitialXHRContent):
              (WebCore::InspectorResourceAgent::getResourceContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/NetworkResourcesData.cpp:
              (WebCore::NetworkResourcesData::ResourceData::ResourceData):
              (WebCore::NetworkResourcesData::ResourceData::content):
              (WebCore::NetworkResourcesData::ResourceData::appendContent):
              (WebCore::NetworkResourcesData::ResourceData::purgeContent):
              (WebCore::NetworkResourcesData::NetworkResourcesData):
              (WebCore::NetworkResourcesData::responseReceived):
              (WebCore::NetworkResourcesData::addResourceContent):
              (WebCore::NetworkResourcesData::data):
              (WebCore::NetworkResourcesData::clear):
              (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
              (WebCore::NetworkResourcesData::ensureFreeSpace):
              * inspector/NetworkResourcesData.h:
              (WebCore::NetworkResourcesData::ResourceData::hasContent):
              (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged):
              (WebCore::NetworkResourcesData::ResourceData::textEncodingName):
              (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
              * inspector/front-end/Resource.js:
              * inspector/front-end/ResourcePreviewView.js:
              (WebInspector.ResourcePreviewView.prototype.contentLoaded):
              (WebInspector.ResourcePreviewView.prototype._createInnerView):
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView.hasTextContent):
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::didReceiveData):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::willLoadMediaElementURL):
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::loadedResourceFromMemoryCache):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didReceiveData):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
              (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
              * loader/ResourceLoadNotifier.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::didReceiveData):
              * testing/Internals.cpp:
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * win/WebKit2.def:
              * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e1df61f
    • vsevik@chromium.org's avatar
      2011-07-04 Vsevolod Vlasov <vsevik@chromium.org> · 169a9b5d
      vsevik@chromium.org authored
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              * Source/autotools/symbols.filter:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-embed.html: Added.
              * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-xhr.html: Added.
              * http/tests/inspector/network/network-embed-expected.txt: Added.
              * http/tests/inspector/network/network-embed.html: Added.
              * http/tests/inspector/network/network-xhr-async-expected.txt:
              * http/tests/inspector/network/network-xhr-async.html:
              * http/tests/inspector/network/network-xhr-sync-expected.txt:
              * http/tests/inspector/network/network-xhr-sync.html:
              * http/tests/inspector/network/resources/cp1251.xml: Added.
              * http/tests/inspector/network/resources/plugin-data.php: Added.
              * http/tests/inspector/network/resources/resource.php:
              * http/tests/inspector/network/resources/utf8.xml: Added.
              * platform/chromium/test_expectations.txt:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              Tests: http/tests/inspector/network/network-content-replacement-embed.html
                     http/tests/inspector/network/network-content-replacement-xhr.html
                     http/tests/inspector/network/network-embed.html
      
              * WebCore.exp.in:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didReceiveDataImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::didReceiveData):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::didReceiveData):
              (WebCore::InspectorResourceAgent::didFinishLoading):
              (WebCore::InspectorResourceAgent::setInitialXHRContent):
              (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
              (WebCore::InspectorResourceAgent::getResourceContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/NetworkResourcesData.cpp:
              (WebCore::NetworkResourcesData::ResourceData::ResourceData):
              (WebCore::NetworkResourcesData::ResourceData::setContent):
              (WebCore::NetworkResourcesData::ResourceData::purgeContent):
              (WebCore::NetworkResourcesData::ResourceData::createDecoder):
              (WebCore::NetworkResourcesData::ResourceData::dataLength):
              (WebCore::NetworkResourcesData::ResourceData::appendData):
              (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
              (WebCore::NetworkResourcesData::NetworkResourcesData):
              (WebCore::NetworkResourcesData::responseReceived):
              (WebCore::NetworkResourcesData::setResourceContent):
              (WebCore::NetworkResourcesData::maybeAddResourceData):
              (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
              (WebCore::NetworkResourcesData::data):
              (WebCore::NetworkResourcesData::clear):
              (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
              (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
              (WebCore::NetworkResourcesData::ensureFreeSpace):
              * inspector/NetworkResourcesData.h:
              (WebCore::NetworkResourcesData::ResourceData::hasContent):
              (WebCore::NetworkResourcesData::ResourceData::content):
              (WebCore::NetworkResourcesData::ResourceData::decoder):
              (WebCore::NetworkResourcesData::ResourceData::buffer):
              (WebCore::NetworkResourcesData::ResourceData::setBuffer):
              (WebCore::NetworkResourcesData::ResourceData::hasData):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype.get contentEncoded):
              * inspector/front-end/ResourcePreviewView.js:
              (WebInspector.ResourcePreviewView.prototype.contentLoaded):
              (WebInspector.ResourcePreviewView.prototype._createEmptyView):
              (WebInspector.ResourcePreviewView.prototype._createPreviewView):
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView.hasTextContent):
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::didReceiveData):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::willLoadMediaElementURL):
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::loadedResourceFromMemoryCache):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didReceiveData):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
              (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
              * loader/ResourceLoadNotifier.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::didReceiveData):
              * testing/Internals.cpp:
              (WebCore::Internals::setInspectorResourcesDataSizeLimits):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              * win/WebKit2.def:
              * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      169a9b5d
  16. 25 Jun, 2011 1 commit
  17. 24 Jun, 2011 1 commit
    • dominicc@chromium.org's avatar
      2011-06-24 Dominic Cooney <dominicc@chromium.org> · 958d2e44
      dominicc@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              * Source/autotools/symbols.filter: Export symbols for GTK.
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Update tests to use internals.{ensureShadowRoot, shadowRoot,
              shadowPseudoId, removeShadowRoot} instead of layoutTestController.
      
              * fast/dom/HTMLKeygenElement/keygen-expected.txt:
              * fast/dom/HTMLKeygenElement/keygen.html:
              * fast/dom/HTMLMeterElement/meter-clone-expected.txt:
              * fast/dom/HTMLMeterElement/meter-clone.html:
              * fast/dom/HTMLProgressElement/progress-clone-expected.txt:
              * fast/dom/HTMLProgressElement/progress-clone.html:
              * fast/dom/shadow/activeelement-should-be-shadowhost.html:
              * fast/dom/shadow/create-content-element.html:
              * fast/dom/shadow/gc-shadow-expected.txt:
              * fast/dom/shadow/gc-shadow.html:
              * fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: shadowRoot of non-element throws now, so verify new behavior.
              * fast/dom/shadow/layout-tests-can-access-shadow.html:
              * fast/dom/shadow/nodetype.html:
              * fast/dom/shadow/tab-order-iframe-and-shadow.html:
              * fast/events/shadow-boundary-crossing.html:
              * fast/forms/resources/common.js:
              (getValidationMessageBubbleNode):
              * fast/html/clone-keygen-expected.txt:
              * fast/html/clone-keygen.html:
              * fast/html/clone-range-expected.txt:
              * fast/html/clone-range.html:
              * fast/html/details-clone.html:
              * fullscreen/video-controls-override-expected.txt:
              * fullscreen/video-controls-override.html:
              * media/audio-controls-do-not-fade-out.html:
              * media/media-controls.js:
              (mediaControlsButtonCoordinates):
              * media/video-controls-in-media-document.html:
              * platform/win/Skipped: shadowRoot and friends now available on win.
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              * WebCore.exp.in: Exports for symbols used by WebCoreTestSupport.
              * testing/Internals.cpp: The new home of shadowRoot and friends.
              (WebCore::Internals::ensureShadowRoot):
              (WebCore::Internals::shadowRoot):
              (WebCore::Internals::removeShadowRoot):
              (WebCore::Internals::shadowPseudoId):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from Chromium API. These are not
              required any more.
      
              * public/WebElement.h:
              * src/WebElement.cpp:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow-DOM related methods from GTK DRT API. These are not
              required any more.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from Mac API. These are not
              required any more.
      
              * DOM/WebDOMOperations.mm:
              * DOM/WebDOMOperationsPrivate.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow-DOM related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow-DOM related methods from Qt DRT API. These are not
              required any more.
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from WebKit2 API. These are not
              required any more.
      
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
              * win/WebKit2.def: Re-exports for symbols used by WebCoreTestSupport.
              * win/WebKit2CFLite.def: Same for Cairo.
      2011-06-24  Dominic Cooney   <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
              removeShadowRoot from layoutTestController; these have been
              replaced by equivalents in window.internals instead.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      958d2e44
  18. 20 Jun, 2011 1 commit
  19. 06 Jun, 2011 1 commit
  20. 15 Jan, 2011 1 commit
    • abarth@webkit.org's avatar
      Move WebKit2 into Source · be159d97
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52438
      
      Rubber-stamped by Eric Seidel.
      
      .: 
      
      Update reference to WebKit2.
      
      * DerivedSources.pro:
      * GNUmakefile.am:
      * Makefile:
      * Source/cmake/WebKitPackaging.cmake:
      * WebKit.pro:
      * configure.ac:
      
      Source/WebCore: 
      
      * WebCore.pro:
      
      Source/WebKit2: 
      
      * DerivedSources.pro:
      * GNUmakefile.am:
      * WebKit2.pro:
      * WebProcess.pro:
      * win/WebKit2.vcproj:
      * win/WebKit2WebProcess.vcproj:
      
      Tools: 
      
      * MiniBrowser/qt/MiniBrowser.pro:
      * Scripts/build-webkit:
      * Scripts/do-file-rename:
      * Scripts/do-webcore-rename:
      * Scripts/test-webkitpy:
      * Scripts/webkitdirs.pm:
      * Scripts/webkitpy/style/checker.py:
      * WebKitTestRunner/DerivedSources.pro:
      * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
      * WebKitTestRunner/qt/WebKitTestRunner.pro:
      
      WebKit/win: 
      
      Update reference to WebKit2.
      
      * WebKit.vcproj/WebKit.sln:
      
      Websites/bugs.webkit.org: 
      
      Remove WebKit2 from the list of top-level source directories.
      
      * PrettyPatch/PrettyPatch.rb:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be159d97
  21. 15 Jul, 2010 1 commit
    • bfulgham@webkit.org's avatar
      Patch for https://bugs.webkit.org/show_bug.cgi?id=42299 · 1a238f22
      bfulgham@webkit.org authored
      Correct WinCairo build for new WebKit2 project structure.
      
      Reviewed by Steve Falkenburg.
      
      WebKit/win: 
      
      * WebKit.vcproj/WebKit.sln:
      
      WebKit2: 
      
      * win/WebKit2Apple.vsprops: Put WebKit2.def here.
      * win/WebKit2CFLite.def: Added CFLite version of def file.
      * win/WebKit2CFLite.vsprops: Add new WebKit2CFLite.def here.
      * win/WebKit2Common.vsprops: Remove WebKit2.def definition as
        WinCairo and Apple need different versions of this.
      * win/WebKit2WebProcess.vcproj: Add a new Debug_Cairo target
        for the WebKit2WebProcess project.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a238f22
  22. 12 Jul, 2010 1 commit
    • sfalken@apple.com's avatar
      WebKit/win: <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL · 31f61300
      sfalken@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=40921
      
      Reviewed by Alice Liu.
      
      Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
      WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.
              
      This is a first step. We'll likely want to migrate the remainder of
      the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.
      
      * WebKit.vcproj/WebKit.def: Removed.
      * WebKit.vcproj/WebKit.make: Don't fail if WebKit doesn't produce a DLL.
      * WebKit.vcproj/WebKit.vcproj: Build WebKit as a static lib.
      Renamed project name to WebKitLib to avoid confusion and naming conflicts.
      Generate intermediate pdb file for debuggability of static lib.
      Removed DLL-related options.        
      * WebKit.vcproj/deleteButton.png: Removed.
      * WebKit.vcproj/deleteButtonPressed.png: Removed.
      * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Removed.
      * WebKit.vcproj/fsVideoAudioVolumeLow.png: Removed.
      * WebKit.vcproj/fsVideoExitFullscreen.png: Removed.
      * WebKit.vcproj/fsVideoPause.png: Removed.
      * WebKit.vcproj/fsVideoPlay.png: Removed.
      * WebKit.vcproj/missingImage.png: Removed.
      * WebKit.vcproj/nullplugin.png: Removed.
      * WebKit.vcproj/panEastCursor.png: Removed.
      * WebKit.vcproj/panIcon.png: Removed.
      * WebKit.vcproj/panNorthCursor.png: Removed.
      * WebKit.vcproj/panNorthEastCursor.png: Removed.
      * WebKit.vcproj/panNorthWestCursor.png: Removed.
      * WebKit.vcproj/panSouthCursor.png: Removed.
      * WebKit.vcproj/panSouthEastCursor.png: Removed.
      * WebKit.vcproj/panSouthWestCursor.png: Removed.
      * WebKit.vcproj/panWestCursor.png: Removed.
      * WebKit.vcproj/searchCancel.png: Removed.
      * WebKit.vcproj/searchCancelPressed.png: Removed.
      * WebKit.vcproj/searchMagnifier.png: Removed.
      * WebKit.vcproj/searchMagnifierResults.png: Removed.
      * WebKit.vcproj/textAreaResizeCorner.png: Removed.
      * WebKit.vcproj/verticalTextCursor.png: Removed.
      * WebKit.vcproj/zoomInCursor.png: Removed.
      * WebKit.vcproj/zoomOutCursor.png: Removed.
      
      WebKit2: <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL
      https://bugs.webkit.org/show_bug.cgi?id=40921
              
      Reviewed by Alice Liu.
      
      Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
      WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.
      
      This is a first step. We'll likely want to migrate the remainder of
      the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.
      
      * UIProcess/API/C/WKBase.h: Updated to new BUILDING_ name.
      * WebProcess/InjectedBundle/API/c/WKBundleBase.h: Updated to new BUILDING_ name.
      * WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp: Removed.
      * WebProcess/win/DllMain.cpp: Removed. Overlaps with implementation in WebKitLib.lib.
      * WebProcess/win/WebLocalizableStrings.cpp: Removed. Overlaps with implementation in WebKitLib.lib.
      * WebProcess/win/WebLocalizableStrings.h: Removed. Overlaps with implementation in WebKitLib.lib.
      * win/WebKit2.def: Added. Copied from WebKit project.
      * win/WebKit2.rc: Added resources previously in WebKit.
      * win/WebKit2.vcproj: Changed project name to WebKit so we will link output to WebKit.dll.
      Removed implementations overlapping with WebKitLib (WebCoreLocalizedStrings, DllMain, WebLocalizableStrings, WebProcessMain).
      * win/WebKit2Common.vsprops: Use a framework name of WebKit instead of WebKit2 to reflect project name.
      Renamed BUILDING_WEBKIT2 to BUILDING_WEBKIT since there is now just a single WebKit.dll.
      * win/WebKit2WebProcess.vcproj: Link against WebKit instead of WebKit2 due to renaming.        
      * win/deleteButton.png: Copied from ../WebKit/win/WebKit.vcproj/deleteButton.png.
      * win/deleteButtonPressed.png: Copied from ../WebKit/win/WebKit.vcproj/deleteButtonPressed.png.
      * win/fsVideoAudioVolumeHigh.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoAudioVolumeHigh.png.
      * win/fsVideoAudioVolumeLow.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoAudioVolumeLow.png.
      * win/fsVideoExitFullscreen.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoExitFullscreen.png.
      * win/fsVideoPause.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoPause.png.
      * win/fsVideoPlay.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoPlay.png.
      * win/missingImage.png: Copied from ../WebKit/win/WebKit.vcproj/missingImage.png.
      * win/nullplugin.png: Copied from ../WebKit/win/WebKit.vcproj/nullplugin.png.
      * win/panEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panEastCursor.png.
      * win/panIcon.png: Copied from ../WebKit/win/WebKit.vcproj/panIcon.png.
      * win/panNorthCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthCursor.png.
      * win/panNorthEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthEastCursor.png.
      * win/panNorthWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthWestCursor.png.
      * win/panSouthCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthCursor.png.
      * win/panSouthEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthEastCursor.png.
      * win/panSouthWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthWestCursor.png.
      * win/panWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panWestCursor.png.
      * win/searchCancel.png: Copied from ../WebKit/win/WebKit.vcproj/searchCancel.png.
      * win/searchCancelPressed.png: Copied from ../WebKit/win/WebKit.vcproj/searchCancelPressed.png.
      * win/searchMagnifier.png: Copied from ../WebKit/win/WebKit.vcproj/searchMagnifier.png.
      * win/searchMagnifierResults.png: Copied from ../WebKit/win/WebKit.vcproj/searchMagnifierResults.png.
      * win/textAreaResizeCorner.png: Copied from ../WebKit/win/WebKit.vcproj/textAreaResizeCorner.png.
      * win/verticalTextCursor.png: Copied from ../WebKit/win/WebKit.vcproj/verticalTextCursor.png.
      * win/zoomInCursor.png: Copied from ../WebKit/win/WebKit.vcproj/zoomInCursor.png.
      * win/zoomOutCursor.png: Copied from ../WebKit/win/WebKit.vcproj/zoomOutCursor.png.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31f61300
  23. 22 Feb, 2010 1 commit
  24. 18 Feb, 2010 1 commit
  25. 13 May, 2009 1 commit
    • dimich@chromium.org's avatar
      JavaScriptCore: · c85b91df
      dimich@chromium.org authored
      2009-05-13  Dmitry Titov  <dimich@chromium.org>
      
              Rubber-stamped by Mark Rowe.
      
              https://bugs.webkit.org/show_bug.cgi?id=25746
              Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
      
              * JavaScriptCore.exp:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
              * bytecode/SamplingTool.cpp:
              (JSC::SamplingThread::start):
              (JSC::SamplingThread::stop):
              * bytecode/SamplingTool.h:
              * wtf/CrossThreadRefCounted.h:
              (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
              (WTF::::ref):
              (WTF::::deref):
              * wtf/Threading.h:
              * wtf/ThreadingNone.cpp:
              * wtf/ThreadingPthreads.cpp:
              (WTF::threadMapMutex):
              (WTF::initializeThreading):
              (WTF::threadMap):
              (WTF::identifierByPthreadHandle):
              (WTF::establishIdentifierForPthreadHandle):
              (WTF::pthreadHandleForIdentifier):
              (WTF::clearPthreadHandleForIdentifier):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::detachThread):
              (WTF::currentThread):
              * wtf/ThreadingWin.cpp:
              (WTF::threadMapMutex):
              (WTF::initializeThreading):
              (WTF::threadMap):
              (WTF::storeThreadHandleByIdentifier):
              (WTF::threadHandleForIdentifier):
              (WTF::clearThreadHandleForIdentifier):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::detachThread):
              (WTF::currentThread):
              * wtf/gtk/ThreadingGtk.cpp:
              (WTF::threadMapMutex):
              (WTF::initializeThreading):
              (WTF::threadMap):
              (WTF::identifierByGthreadHandle):
              (WTF::establishIdentifierForThread):
              (WTF::threadForIdentifier):
              (WTF::clearThreadForIdentifier):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
              * wtf/qt/ThreadingQt.cpp:
              (WTF::threadMapMutex):
              (WTF::threadMap):
              (WTF::identifierByQthreadHandle):
              (WTF::establishIdentifierForThread):
              (WTF::clearThreadForIdentifier):
              (WTF::threadForIdentifier):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
      
      WebCore:
      
      2009-05-13  Dmitry Titov  <dimich@chromium.org>
      
              Rubber-stamped by Mark Rowe.
      
              https://bugs.webkit.org/show_bug.cgi?id=25746
              Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
      
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::matchFunc):
              (WebCore::openFunc):
              (WebCore::createStringParser):
              (WebCore::createMemoryParser):
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::open):
              * platform/sql/SQLiteDatabase.cpp:
              (WebCore::SQLiteDatabase::SQLiteDatabase):
              (WebCore::SQLiteDatabase::close):
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::DatabaseThread):
              (WebCore::DatabaseThread::start):
              (WebCore::DatabaseThread::databaseThread):
              * storage/LocalStorageThread.cpp:
              (WebCore::LocalStorageThread::LocalStorageThread):
              (WebCore::LocalStorageThread::start):
              (WebCore::LocalStorageThread::localStorageThread):
              (WebCore::LocalStorageThread::scheduleImport):
              (WebCore::LocalStorageThread::scheduleSync):
              (WebCore::LocalStorageThread::terminate):
              * workers/WorkerThread.cpp:
              (WebCore::WorkerThread::WorkerThread):
              (WebCore::WorkerThread::start):
      
      WebKit/win:
      
      2009-05-13  Dmitry Titov  <dimich@chromium.org>
      
              Rubber-stamped by Mark Rowe.
      
              https://bugs.webkit.org/show_bug.cgi?id=25746
              Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c85b91df
  26. 11 May, 2009 1 commit
    • dimich@chromium.org's avatar
      JavaScriptCore: · 558a0efc
      dimich@chromium.org authored
      2009-05-11  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              * wtf/Threading.h:
              (WTF::ThreadIdentifier::ThreadIdentifier):
              (WTF::ThreadIdentifier::isValid):
              (WTF::ThreadIdentifier::invalidate):
              (WTF::ThreadIdentifier::platformId):
              ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and
              methods that are used across the code on thread ids: construction, comparisons,
              check for 'valid' state etc. '0' is used as invalid id, which happens to just work
              with all platform-specific thread id implementations.
      
              All the following files repeatedly reflect the new ThreadIdentifier for each platform.
              We remove ThreadMap and threadMapMutex from all of them, remove the functions that
              populated/searched/cleared the map and add platform-specific comparison operators
              for ThreadIdentifier.
      
              There are specific temporary workarounds for Safari 4 beta on OSX and Win32 since the
              public build uses WTF threading functions with old type of ThreadingIdentifier.
              The next time Safari 4 is rebuilt, it will 'automatically' pick up the new type and new
              functions so the deprecated ones can be removed.
      
              * wtf/gtk/ThreadingGtk.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
      
              * wtf/ThreadingNone.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
      
              * wtf/ThreadingPthreads.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::detachThread):
              (WTF::currentThread):
              (WTF::waitForThreadCompletion): This is a workaround for Safari 4 beta on Mac.
              Safari 4 is linked against old definition of ThreadIdentifier so it treats it as uint32_t.
              This 'old' variant of waitForThreadCompletion takes uint32_t and has the old decorated name, so Safari can
              load it from JavaScriptCore library. The other functions (CurrentThread() etc) happen to match their previous
              decorated names and, while they return pthread_t now, it is a pointer which round-trips through a uint32_t.
              This function will be removed as soon as Safari 4 will release next public build.
      
              * wtf/qt/ThreadingQt.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
      
              * wtf/ThreadingWin.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal): All the platforms (except Windows) used a sequential
              counter as a thread ID and mapped it into platform ID. Windows was using native thread
              id and mapped it into thread handle. Since we can always obtain a thread handle
              by thread id, createThread now closes the handle.
              (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle,
              it means the thread already exited.
              (WTF::detachThread):
              (WTF::currentThread):
              (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now).
              (WTF::waitForThreadCompletionDeprecated): same.
              (WTF::currentThreadDeprecated): same.
              (WTF::createThreadDeprecated): same.
      
              * bytecode/SamplingTool.h:
              * bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
      
              * JavaScriptCore.exp: export lists - updated decorated names of the WTF threading functions
              since they now take a different type as a parameter.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions
              that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.
      
      WebCore:
      
      2009-05-11  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              Most of the change is in WTF.
              Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
              method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
              is now a class rather then an integer.
              Also, there is no need to initialize threadID in constructors to 0 now.
      
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
              since now ThreadIdentifier needs construction and we avoid having global initializers.
              (WebCore::matchFunc): use the new accessor function.
              (WebCore::openFunc): ditto.
              (WebCore::createStringParser): ditto.
              (WebCore::createMemoryParser): ditto.
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::open):
              * platform/sql/SQLiteDatabase.cpp:
              (WebCore::SQLiteDatabase::SQLiteDatabase):
              (WebCore::SQLiteDatabase::close):
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::start):
              (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
              * storage/LocalStorageThread.cpp:
              (WebCore::LocalStorageThread::start):
              (WebCore::LocalStorageThread::scheduleImport):
              (WebCore::LocalStorageThread::scheduleSync):
              (WebCore::LocalStorageThread::terminate):
              * workers/WorkerThread.cpp:
              (WebCore::WorkerThread::start):
              (WebCore::WorkerThread::WorkerThread):
              (WebCore::WorkerThread::start):
      
      WebKit/win:
      
      2009-05-11  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              Most of the change is in WTF and WebCore.
      
              * WebKit.vcproj/WebKit.def: replaced decorated names of WTF threading functions with new ones.
              Also, aliased the old implementations so the public Safari 4 beta can load the old WTF functions
              which it uses. Next time Safari 4 builds, it will pick up new functions and the deprecated ones
              can be removed.
              * WebKit.vcproj/WebKit_debug.def: same.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      558a0efc
  27. 08 May, 2009 1 commit
  28. 07 May, 2009 1 commit
    • dimich@chromium.org's avatar
      JavaScriptCore: · 4b43290e
      dimich@chromium.org authored
      2009-05-07  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              * wtf/Threading.h:
              (WTF::ThreadIdentifier::ThreadIdentifier):
              (WTF::ThreadIdentifier::isValid):
              (WTF::ThreadIdentifier::invalidate):
              (WTF::ThreadIdentifier::platformId):
              ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and
              methods that are used across the code on thread ids: construction, comparisons,
              check for 'valid' state etc. '0' is used as invalid id, which happens to just work
              with all platform-specific thread id implementations.
      
              All the following files repeatedly reflect the new ThreadIdentifier for each platform.
              We remove ThreadMap and threadMapMutex from all of them, remove the functions that
              populated/searched/cleared the map and add platform-specific comparison operators
              for ThreadIdentifier.
      
              * wtf/gtk/ThreadingGtk.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
      
              * wtf/ThreadingNone.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
      
              * wtf/ThreadingPthreads.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::detachThread):
              (WTF::currentThread):
      
              * wtf/qt/ThreadingQt.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
      
              * wtf/ThreadingWin.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal): All the platforms (except Windows) used a sequential
              counter as a thread ID and mapped it into platform ID. Windows was using native thread
              id and mapped it into thread handle. Since we can always obtain a thread handle
              by thread id, createThread now closes the handle.
              (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle,
              it means the thread already exited.
              (WTF::detachThread):
              (WTF::currentThread):
              (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now).
              (WTF::waitForThreadCompletionDeprecated): same.
              (WTF::currentThreadDeprecated): same.
              (WTF::createThreadDeprecated): same.
      
              * bytecode/SamplingTool.h:
              * bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
      
              * JavaScriptCore.exp: export lists - updated the WTF threading functions decorated names
              since they now take a different type as a parameter.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions
              that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.
      
      WebCore:
      
      2009-05-07  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              Most of the change is in WTF.
              Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
              method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
              is now a class rather then an integer.
              Also, there is no need to initialize threadID in constructors to 0 now.
      
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
              since now ThreadIdentifier needs construction and we avoid having global initializers.
              (WebCore::matchFunc): use the new accessor function.
              (WebCore::openFunc): ditto.
              (WebCore::createStringParser): ditto.
              (WebCore::createMemoryParser): ditto.
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::open):
              * platform/sql/SQLiteDatabase.cpp:
              (WebCore::SQLiteDatabase::SQLiteDatabase):
              (WebCore::SQLiteDatabase::close):
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::start):
              (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
              * storage/LocalStorageThread.cpp:
              (WebCore::LocalStorageThread::start):
              (WebCore::LocalStorageThread::scheduleImport):
              (WebCore::LocalStorageThread::scheduleSync):
              (WebCore::LocalStorageThread::terminate):
              * workers/WorkerThread.cpp:
              (WebCore::WorkerThread::start):
              (WebCore::WorkerThread::WorkerThread):
              (WebCore::WorkerThread::start):
      
      WebKit/win:
      
      2009-05-07  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              Most of the change is in WTF and WebCore.
      
              * WebKit.vcproj/WebKit.def: replaced decorated names of WTF threading functions with new ones.
              Also, aliased the old implementations so the public Safari 4 beta can load the old WTF functions
              which it uses. Next time Safari 4 builds, it will pick up new functions and the deprecated ones
              can be removed.
              * WebKit.vcproj/WebKit_debug.def: same.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b43290e
  29. 21 Apr, 2009 1 commit
    • sfalken@apple.com's avatar
      WebKit/win: · 77458d83
      sfalken@apple.com authored
      2009-04-21  Steve Falkenburg  <sfalken@apple.com>
      
              Add registry-free CoCreateInstance API for WebKit clients: WebKitCreateInstance.
      
              Manifest-based registry-free COM continues to work for clients that have embedded
              manifests with isolated COM information.
              
              Reviewed by Adam Roben.
      
              * WebKit.vcproj/WebKit.def: Added WebKitCreateInstance.
              * WebKit.vcproj/WebKit.vcproj: Link against rpcrt4.dll for UUID hashing.
              * WebKit.vcproj/WebKit_debug.def: Added WebKitCreateInstance.
              * WebKitCOMAPI.cpp: Added.
              (CLSIDHash::hash):
              (CLSIDHash::equal):
              (CLSIDHashTraits::constructDeletedValue):
              (CLSIDHashTraits::isDeletedValue):
              (classFactory):
              (WebKitCreateInstance): New API.
              * WebKitCOMAPI.h: Added.
      
      WebKitTools:
      
      2009-04-21  Steve Falkenburg  <sfalken@apple.com>
      
              Use new WebKitCreateInstance API instead of CoCreateInstance
              or COMPtr's createInstance to instantiate WebKit COM objects.
      
              Reviewed by Adam Roben.
      
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (initialize):
              (runTest):
              (createWebViewAndOffscreenWindow):
              (main):
              * DumpRenderTree/win/DumpRenderTree.vcproj:
              * DumpRenderTree/win/GCControllerWin.cpp:
              (GCController::collect):
              (GCController::collectOnAlternateThread):
              (GCController::getJSObjectCount):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::keepWebHistory):
              (LayoutTestController::webHistoryItemCount):
              (LayoutTestController::setIconDatabaseEnabled):
              * DumpRenderTree/win/WorkQueueItemWin.cpp:
              (LoadItem::invoke):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77458d83
  30. 20 Apr, 2009 1 commit
    • sfalken@apple.com's avatar
      JavaScriptCore: · 46fc85ac
      sfalken@apple.com authored
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
      
              Reviewed by Oliver Hunt.
      
              * API/JSBase.h: Export symbols with JS_EXPORT when using MSVC.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj: Build JavaScriptCore as a DLL instead of a static library.
              * config.h: Specify __declspec(dllexport/dllimport) appropriately when exporting data.
              * runtime/InternalFunction.h: Specify JS_EXPORTDATA on exported data.
              * runtime/JSArray.h: Specify JS_EXPORTDATA on exported data.
              * runtime/JSFunction.h: Specify JS_EXPORTDATA on exported data.
              * runtime/StringObject.h: Specify JS_EXPORTDATA on exported data.
              * runtime/UString.h: Specify JS_EXPORTDATA on exported data.
      
      WebCore:
      
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
      
              Reviewed by Oliver Hunt.
      
              * config.h: Specify __declspec(dllexport/dllimport) appropriately when exporting data.
      
      WebKit/cf:
      
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
              
              Reviewed by Oliver Hunt.
      
              * WebCoreSupport/WebInspectorClientCF.cpp: Workaround for lack of config.h in shared WebKit file (WebKit/win uses config.h from WebCore).
      
      WebKit/win:
      
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
      
              Reviewed by Oliver Hunt.
      
              * WebKit.vcproj/WebKit.def: Mark JavaScriptCore re-exports as deprecated.
              * WebKit.vcproj/WebKit.vcproj: Link against JavaScriptCore.dll
              * WebKit.vcproj/WebKit_debug.def: Mark JavaScriptCore re-exports as deprecated.
      
      WebKitLibraries:
      
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
      
              Reviewed by Oliver Hunt.
      
              * win/tools/vsprops/common.vsprops: Add BUILDING_{project} preprocessor define.
      
      WebKitTools:
      
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
      
              Reviewed by Oliver Hunt.
      
              * DumpRenderTree/config.h: Specify JS, WebKit exported data as __declspec(dllimport)
              * DumpRenderTree/win/DumpRenderTree.vcproj: Link against JavaScriptCore.dll
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46fc85ac
  31. 11 Mar, 2009 1 commit
  32. 25 Feb, 2009 1 commit
  33. 24 Feb, 2009 1 commit
  34. 02 Dec, 2008 1 commit
  35. 29 Oct, 2008 1 commit
    • sfalken@apple.com's avatar
      JavaScriptCore: · 621341ba
      sfalken@apple.com authored
      2008-10-29  Steve Falkenburg  <sfalken@apple.com>
      
              <rdar://problem/6326563> Crash on launch
      
              For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
              
              Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
              callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
              the explicit lock/unlock functions, we can avoid this.
              
              Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
              
              Reviewed by Darin Adler.
      
              * wtf/Threading.h:
              (WTF::lockAtomicallyInitializedStaticMutex):
              (WTF::unlockAtomicallyInitializedStaticMutex):
              * wtf/ThreadingWin.cpp:
              (WTF::lockAtomicallyInitializedStaticMutex):
              (WTF::unlockAtomicallyInitializedStaticMutex):
      
      WebKit/win:
      
      2008-10-29  Steve Falkenburg  <sfalken@apple.com>
      
              <rdar://problem/6326563> Crash on launch
              
              For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
              
              Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
              callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
              the explicit lock/unlock functions, we can avoid this.
              
              Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
              
              Reviewed by Darin Adler.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      621341ba