1. 23 Sep, 2011 6 commits
    • commit-queue@webkit.org's avatar
      .: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests · 90680248
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      Tests: fast/dom/scroll-element-to-rect-centered.html
             fast/dom/scroll-element-to-rect.html
      
      * WebCore.exp.in:
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollElementToRect):
      * page/FrameView.h:
      * testing/Internals.cpp:
      (WebCore::Internals::scrollElementToRect):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/chromium: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * public/WebView.h:
      (WebKit::WebView::scrollFocusedNodeIntoRect):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
      
      Source/WebKit2: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * fast/dom/scroll-element-to-rect-centered-expected.txt: Added.
      * fast/dom/scroll-element-to-rect-centered.html: Added.
      * fast/dom/scroll-element-to-rect-expected.txt: Added.
      * fast/dom/scroll-element-to-rect.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90680248
    • mrowe@apple.com's avatar
      Versioning. · 71e2a0a5
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71e2a0a5
    • commit-queue@webkit.org's avatar
      [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender · c5aed241
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68556
      
      Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
      
      Source/WebKit2:
      
      Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
      Reviewed by Darin Adler.
      
      * Shared/API/c/WKGeometry.h:
      (operator==):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::mouseEventSyncForTesting): initialize "handled"
      
      Tools:
      
      Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
      Reviewed by Darin Adler.
      
      * WebKitTestRunner/EventSenderProxy.h:
      * WebKitTestRunner/InjectedBundle/EventSendingController.h:
      * WebKitTestRunner/PlatformWebView.h:
      * WebKitTestRunner/mac/EventSenderProxy.mm:
      (WTR::EventSenderProxy::EventSenderProxy):
      (WTR::EventSenderProxy::leapForward):
      * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
      (WTR::EventSenderProxy::EventSenderProxy):
      (WTR::getMouseButton):
      (WTR::getModifiers):
      (WTR::EventSenderProxy::updateClickCountForButton):
      (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
      (WTR::EventSenderProxy::mouseDown):
      (WTR::EventSenderProxy::mouseUp):
      (WTR::EventSenderProxy::mouseMoveTo):
      (WTR::EventSenderProxy::leapForward):
      (WTR::EventSenderProxy::sendOrQueueEvent):
      (WTR::EventSenderProxy::replaySavedEvents):
      * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
      (WTR::PlatformWebView::postEvent):
      * WebKitTestRunner/qt/WebKitTestRunner.pro:
      
      LayoutTests:
      
      Unskip passed tests.
      
      Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
      Reviewed by Darin Adler.
      
      * platform/qt-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5aed241
    • andersca@apple.com's avatar
      Move WebHitTestResult files to Shared/ in the Xcode project · 3a8d816a
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68718
      
      Reviewed by Sam Weinig.
      
      * WebKit2.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a8d816a
    • andersca@apple.com's avatar
      Add OVERRIDE to overrides of virtual member functions in client classes · b4a311d2
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68702
      
      Reviewed by Darin Adler.
      
      Disable the warning in Xcode and VS2005 for using override and final when compiling as C++98,
      and remove WebEditorClient::isEditable, WebChromeClient::formDidFocus,
      WebChromeClient::formDidBlur and WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest since
      they have been removed from their respective base classes.
              
      * Configurations/Base.xcconfig:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      * WebProcess/WebCoreSupport/WebContextMenuClient.h:
      * WebProcess/WebCoreSupport/WebDatabaseManager.h:
      * WebProcess/WebCoreSupport/WebDragClient.h:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      * WebProcess/WebCoreSupport/WebGeolocationClient.h:
      * WebProcess/WebCoreSupport/WebInspectorClient.h:
      * WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
      * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
      * WebProcess/WebCoreSupport/WebPopupMenu.h:
      * WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
      * win/WebKit2Common.vsprops:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4a311d2
    • jesus@webkit.org's avatar
      [Qt][WK2] QtFileDownloader ctor shouldn't call QtFileDownloader::onReadyRead() · af391531
      jesus@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68696
      
      Reviewed by Andreas Kling.
      
      Instead of connecting signals and calling QtFileDownloader::onReadyRead()
      on its constructor, QtFileDownloader will now handle this in start().
      
      * WebProcess/Downloads/qt/DownloadQt.cpp:
      (WebKit::Download::start):
      * WebProcess/Downloads/qt/QtFileDownloader.cpp:
      (WebKit::QtFileDownloader::QtFileDownloader):
      (WebKit::QtFileDownloader::start):
      * WebProcess/Downloads/qt/QtFileDownloader.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af391531
  2. 22 Sep, 2011 7 commits
    • commit-queue@webkit.org's avatar
      [Qt] TouchWebView load test not running · 7fe919d6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68620
      
      Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-22
      Reviewed by Chang Shu.
      
      Load test was not executed since it was missing in pro file. Added tst_load.qml to qmltests.pro
      
      * UIProcess/API/qt/tests/qmltests/qmltests.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fe919d6
    • dino@apple.com's avatar
      Add ENABLE_CSS_FILTERS · fffa7502
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68652
      
      Reviewed by Simon Fraser.
      
      * Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:
      * Source/WebCore/Configurations/FeatureDefines.xcconfig:
      * Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:
      * Source/WebKit2/Configurations/FeatureDefines.xcconfig:
      * WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:
      * WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:
      * Tools/Scripts/build-webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fffa7502
    • simon.fraser@apple.com's avatar
      Add APIObjects for Size, Point, Rect · 5520f1ee
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68644
      
      Reviewed by Sam Weinig.
      
      Make APIObjects for size, point and rect so that they can be
      used in WKArrayRefs.
      
      Make some inline helper methods to create WKSize, WKPoint and WKRect
      types.
      
      * GNUmakefile.am:
      * Shared/API/c/WKBase.h:
      * Shared/API/c/WKGeometry.cpp: Copied from Source/WebKit2/Shared/API/c/WKGeometry.h.
      (WKSizeGetTypeID):
      (WKPointGetTypeID):
      (WKRectGetTypeID):
      (WKPointCreate):
      (WKSizeCreate):
      (WKRectCreate):
      (WKSizeGetValue):
      (WKPointGetValue):
      (WKRectGetValue):
      * Shared/API/c/WKGeometry.h:
      (WKPoint::WKPointMake):
      (WKPoint::WKSizeMake):
      (WKPoint::WKRectMake):
      * Shared/API/c/WKSharedAPICast.h:
      * Shared/APIObject.h:
      * Shared/UserMessageCoders.h:
      (WebKit::UserMessageEncoder::baseEncode):
      (WebKit::UserMessageDecoder::baseDecode):
      * Shared/WebGeometry.h: Added.
      (WebKit::WebSize::create):
      (WebKit::WebSize::size):
      (WebKit::WebSize::WebSize):
      (WebKit::WebSize::type):
      (WebKit::WebPoint::create):
      (WebKit::WebPoint::point):
      (WebKit::WebPoint::WebPoint):
      (WebKit::WebPoint::type):
      (WebKit::WebRect::create):
      (WebKit::WebRect::rect):
      (WebKit::WebRect::WebRect):
      (WebKit::WebRect::type):
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebKit2API.pri:
      * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5520f1ee
    • ap@apple.com's avatar
      [WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it · 2d0fed9a
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=68573
      
              Reviewed by Anders Carlsson.
      
              Re-landing with a slightly less aggressive check.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d0fed9a
    • hclam@chromium.org's avatar
      Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68081 · ecd7a05d
      hclam@chromium.org authored
      Fix scroll in page scaling mode.
      
      Reviewed by Simon Fraser.
      
      The following things are done in this patch:
      1. Rename Frame::pageScaleFactor() to Frame::frameScaleFactor() to better
         reflect its purpose.
      2. Frame::frameScaleFactor() returns the scale factor of this frame with
         respect to the container. So for the main frame it'll return the scale
         factor of the page, inner frames will return 1.0
      3. scrollBy(), scrollX() and scrollY() to take into account of the frame
         scale factor, causing incorrect coordinates reported to Javascript.
      
      Tests: fast/events/scale-and-scroll-body.html
             fast/events/scale-and-scroll-iframe-body.html
             fast/events/scale-and-scroll-iframe-window.html
             fast/events/scale-and-scroll-window.html
      
      * html/HTMLBodyElement.cpp:
      (WebCore::adjustForZoom):
      (WebCore::HTMLBodyElement::setScrollLeft):
      (WebCore::HTMLBodyElement::setScrollTop):
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::scrollX):
      (WebCore::DOMWindow::scrollY):
      (WebCore::DOMWindow::scrollTo):
      * page/Frame.cpp:
      (WebCore::Frame::frameScaleFactor): Return page's scale factor if this is
                                          main frame, otherwise 1.0
      * page/Frame.h:
      * page/FrameView.cpp:
      (WebCore::FrameView::applyOverflowToViewport):
      (WebCore::FrameView::scrollXForFixedPosition):
      (WebCore::FrameView::scrollYForFixedPosition):
      
      Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=68081
      Fix scroll in page scaling mode.
      
      Reviewed by Simon Fraser.
      
      * WebProcess/Plugins/PluginView.cpp: Rename pageScaleFactor to frameScaleFactor.
      (WebKit::PluginView::handleEvent):
      (WebKit::PluginView::viewGeometryDidChange):
      (WebKit::PluginView::clipRectInWindowCoordinates):
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68081
      Add layout test for page scale and scrolling.
      
      Reviewed by Simon Fraser.
      
      Add tests to cover the following cases:
      1. Scale and scroll window
      2. Scale and scroll document.body
      3. Scale and scroll iframe's contentWindow
      4. Scale and scroll iframe's contentDocument.body
      
      * fast/events/scale-and-scroll-body-expected.png: Added.
      * fast/events/scale-and-scroll-body-expected.txt: Added.
      * fast/events/scale-and-scroll-body.html: Added.
      * fast/events/scale-and-scroll-iframe-body-expected.png: Added.
      * fast/events/scale-and-scroll-iframe-body-expected.txt: Added.
      * fast/events/scale-and-scroll-iframe-body.html: Added.
      * fast/events/scale-and-scroll-iframe-window-expected.png: Added.
      * fast/events/scale-and-scroll-iframe-window-expected.txt: Added.
      * fast/events/scale-and-scroll-iframe-window.html: Added.
      * fast/events/scale-and-scroll-window-expected.png: Added.
      * fast/events/scale-and-scroll-window-expected.txt: Added.
      * fast/events/scale-and-scroll-window.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecd7a05d
    • jesus@webkit.org's avatar
      [Qt] Redirection overflow errors have wrong error domain · 255485dd
      jesus@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68612
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Redirection overflow currently puts the URL hostname in the errorDomain field.
      Now redirection overflow errors will be classified as "HTTP" errors.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyHandler::redirect):
      
      Source/WebKit2:
      
      Redirection overflow currently puts the URL hostname in the errorDomain field
      and therefore are treated as a QWebError::EngineError. From now on they
      will be treated as QWebError::HttpError, since their error domain was modified
      to "HTTP" in QNetworkReplyHandler::redirect().
      
      * UIProcess/API/qt/qweberror.cpp:
      (QWebError::type):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      255485dd
    • ossy@webkit.org's avatar
      REGRESSION(r95679): It broke everything. · c1528a03
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68611
      
      Unreviewed rolling out r95679 and r95690, because it broke everything.
      
      * UIProcess/API/mac/WKView.mm:
      (maybeCreateSandboxExtensionFromPasteboard):
      (-[WKView performDragOperation:]):
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::didPerformClientRedirect):
      (WebKit::WebContext::didPerformServerRedirect):
      (WebKit::WebContext::didUpdateHistoryTitle):
      (WebKit::WebContext::getPluginPath):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::reattachToWebProcessWithItem):
      (WebKit::WebPageProxy::initializeSandboxExtensionHandle):
      (WebKit::WebPageProxy::loadURL):
      (WebKit::WebPageProxy::loadURLRequest):
      (WebKit::WebPageProxy::loadHTMLString):
      (WebKit::WebPageProxy::loadAlternateHTMLString):
      (WebKit::WebPageProxy::goForward):
      (WebKit::WebPageProxy::goBack):
      (WebKit::WebPageProxy::goToBackForwardItem):
      (WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
      (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
      (WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
      (WebKit::WebPageProxy::decidePolicyForNavigationAction):
      (WebKit::WebPageProxy::decidePolicyForNewWindowAction):
      (WebKit::WebPageProxy::decidePolicyForResponse):
      (WebKit::WebPageProxy::didInitiateLoadForResource):
      (WebKit::WebPageProxy::didSendRequestForResource):
      (WebKit::WebPageProxy::didReceiveResponseForResource):
      (WebKit::WebPageProxy::missingPluginButtonClicked):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::WebProcessProxy):
      (WebKit::WebProcessProxy::addBackForwardItem):
      * UIProcess/WebProcessProxy.h:
      * UIProcess/cf/WebPageProxyCF.cpp:
      (WebKit::WebPageProxy::restoreFromSessionStateData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1528a03
  3. 21 Sep, 2011 10 commits
    • ap@apple.com's avatar
      [WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it · 69a5ce00
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=68573
      
              Unreviewed follow-up fix.
      
              * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
              Just like we allow null URLs, also allow empty strings.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69a5ce00
    • jchaffraix@webkit.org's avatar
      Crash in RenderBox::paintMaskImages when GraphicsContext's painting is disabled · 3b543a32
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68133
      
      Reviewed by Darin Adler.
      
      .:
      
      * Source/autotools/symbols.filter: Added the mangled symbols needed for window.internals
      
      Source/WebCore:
      
      Tests: fast/css/webkit-mask-crash-fieldset-legend.html
             fast/css/webkit-mask-crash-figure.html
             fast/css/webkit-mask-crash-table.html
             fast/css/webkit-mask-crash-td-2.html
             fast/css/webkit-mask-crash-td.html
      
      GraphicsContext::getCTM crashes if called with a GraphicsContext that has painting
      disabled. RenderBox::paintMaskImages would thus crash if called in this condition.
      
      This change just modifies the different GraphicsContext::getCTM method to bail early
      if painting is disabled on the GraphicsContext. The rest of the change is exposing
      paintControlTints that exposes this.
      
      * WebCore.exp.in: Added symbols of the newly export window.internals function.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::updateControlTints): Split this function in 2 so that
      I can expose the internal paintControlTints.
      
      (WebCore::FrameView::paintControlTints):
      This is the one exposed to Internals as we want to be testable regardless of
      whether the platform supports control tints.
      
      * page/FrameView.h: Added paintControlTints.
      
      * testing/Internals.cpp:
      (WebCore::Internals::paintControlTints):
      * testing/Internals.h:
      * testing/Internals.idl:
      Added a way to force a fake painting so that we can easily reproduce the bugs.
      
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/qt/GraphicsContextQt.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/skia/GraphicsContextSkia.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/wince/GraphicsContextWinCE.cpp:
      (WebCore::GraphicsContext::getCTM):
      * platform/graphics/wx/GraphicsContextWx.cpp:
      (WebCore::GraphicsContext::getCTM):
      Fixed all our back-end to exit early if painting is disabled.
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      Exported the new FrameView::paintControlTints function.
      
      LayoutTests:
      
      Those tests checks that we do not crash when calling internals.paintControlTints.
      
      * platform/mac/Skipped: Skipped 2 tests as they are hitting an ASSERT unrelated to
      this change on Mac.
      
      * fast/css/webkit-mask-crash-fieldset-legend-expected.txt: Added.
      * fast/css/webkit-mask-crash-fieldset-legend.html: Added.
      * fast/css/webkit-mask-crash-figure-expected.txt: Added.
      * fast/css/webkit-mask-crash-figure.html: Added.
      * fast/css/webkit-mask-crash-table-expected.txt: Added.
      * fast/css/webkit-mask-crash-table.html: Added.
      * fast/css/webkit-mask-crash-td-2-expected.txt: Added.
      * fast/css/webkit-mask-crash-td-2.html: Added.
      * fast/css/webkit-mask-crash-td-expected.txt: Added.
      * fast/css/webkit-mask-crash-td.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b543a32
    • ap@apple.com's avatar
      [WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it · c224f5b0
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=68573
      
              Reviewed by Anders Carlsson.
      
              * UIProcess/API/mac/WKView.mm:
              (maybeCreateSandboxExtensionFromPasteboard): Return a boolean, telling the caller whether
              an extension actually needed to be created
              (-[WKView performDragOperation:]): Tell process proxy when the process is going to get
              universal file read sandbox extension.
      
              * UIProcess/WebContext.cpp:
              (WebKit::WebContext::didPerformClientRedirect): Check the URLs.
              (WebKit::WebContext::didPerformServerRedirect): Ditto.
              (WebKit::WebContext::didUpdateHistoryTitle): Ditto.
              (WebKit::WebContext::getPluginPath): Ditto. Also, properly parse the URL - we can never
              assume that a string coming from WebProcess is a ParsedURLString.
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::reattachToWebProcessWithItem): Tell process proxy when the process
              is going to get universal file read sandbox extension.
              (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle): Changed to return a boolean,
              telling the caller whether an extension actually needed to be created.
              (WebKit::WebPageProxy::loadURL): Tell process proxy about extension.
              (WebKit::WebPageProxy::loadURLRequest): Ditto.
              (WebKit::WebPageProxy::loadHTMLString): Tell process proxy if a file URL was used as a base
              one for a string. In this case, WebKit2 assumes that WebProcess has access to a subdirectory,
              (typically, one where error page resources live), and can load from it.
              (WebKit::WebPageProxy::loadAlternateHTMLString): Ditto.
              (WebKit::WebPageProxy::goForward): Tell process proxy about extension.
              (WebKit::WebPageProxy::goBack): Tell process proxy about extension.
              (WebKit::WebPageProxy::goToBackForwardItem): Tell process proxy about extension.
              (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): Check the URL.
              (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
              (WebKit::WebPageProxy::didSameDocumentNavigationForFrame): Ditto.
              (WebKit::WebPageProxy::decidePolicyForNavigationAction): Ditto.
              (WebKit::WebPageProxy::decidePolicyForNewWindowAction): Ditto.
              (WebKit::WebPageProxy::decidePolicyForResponse): Ditto.
              (WebKit::WebPageProxy::didInitiateLoadForResource): Ditto.
              (WebKit::WebPageProxy::didSendRequestForResource): Ditto.
              (WebKit::WebPageProxy::didReceiveResponseForResource): Ditto.
              (WebKit::WebPageProxy::missingPluginButtonClicked): Ditto.
      
              * UIProcess/WebPageProxy.h: Changed initializeSandboxExtensionHandle() to return a bool,
              and renamed to maybeInitializeSandboxExtensionHandle (matching WKView counterpart).
      
              * UIProcess/WebProcessProxy.cpp:
              (WebKit::WebProcessProxy::WebProcessProxy): Initialize m_mayHaveUniversalFileReadSandboxExtension.
              It's going to be true if we ever granted an extension for "/".
              (WebKit::WebProcessProxy::willLoadHTMLStringWithBaseURL): Remember the path, we should expect
              that WebProcess will load subresources from it.
              (WebKit::WebProcessProxy::checkURLReceivedFromWebProcess): Check that it's reasonable to expect
              WebProcess send us a URL like this.
              (WebKit::WebProcessProxy::addBackForwardItem): Check the URLs.
      
              * UIProcess/WebProcessProxy.h: Added data members remembering what to expect from this process.
      
              * UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData):
              Tell process proxy when the process is going to get universal file read sandbox extension.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c224f5b0
    • jer.noble@apple.com's avatar
      Add settings to control the availability of the Web Audio API to WebKit and WebKit2. · 866bf69f
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68382
      
      Source/WebCore:
      
      Reviewed by Darin Adler.
      
      Only create a AudioContext object if the Web Audio feature is runtime-enabled in Settings.
      
      No new tests, as this feature is not yet enabled by default.
      
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::webkitAudioContext):
      
      Source/WebKit/mac:
      
      Reviewed by Darin Adler.
      
      Initialize the webAudioEnabled preference to NO by default.
      
      * WebView/WebPreferences.mm:
      (+[WebPreferences initialize]):
      
      Source/WebKit2:
      
      Add support for the webAudioEnabled preference in WebKit2.
      
      Reviewed by Darin Adler.
      
      * Shared/WebPreferencesStore.h: Add WebAudioEnabled getter and setter macro.
      * UIProcess/API/C/WKPreferences.cpp:
      (WKPreferencesSetWebAudioEnabled): Added.
      (WKPreferencesGetWebAudioEnabled): Added.
      * UIProcess/API/C/WKPreferences.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences): Update the webAudioEnabled preference.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      866bf69f
    • mitz@apple.com's avatar
      Use the prefix "WK" instead of "Web" for Objective-C classes defined in WebKit2. · 3d4ea40b
      mitz@apple.com authored
      Reviewed by Anders Carlsson.
      
      Renamed WebInspectorProxyObjCAdapter to WKWebInspectorProxyObjCAdapter.
      Renamed WebInspectorWKView to WKWebInspectorWKView.
      Renamed WebFindIndicatorWindowAnimation to WKFindIndicatorWindowAnimation.
      Renamed WebFindIndicatorView to WKFindIndicatorView.
      Renamed WebUserDataWrapper to WKUserDataWrapper.
      
      Updated the build phase checking for inappropriate Objective-C class names to disallow the prefix
      "Web" and only allow "WK".
      
      * UIProcess/API/mac/FindIndicatorWindow.h:
      * UIProcess/API/mac/FindIndicatorWindow.mm:
      (WebKit::FindIndicatorWindow::setFindIndicator):
      (WebKit::FindIndicatorWindow::startFadeOutTimerFired):
      * UIProcess/WebInspectorProxy.h:
      * UIProcess/mac/WebContextMenuProxyMac.mm:
      (-[WKMenuTarget forwardContextMenuAction:]):
      (WebKit::nsMenuItemVector):
      * UIProcess/mac/WebInspectorProxyMac.mm:
      (WebKit::WebInspectorProxy::platformCreateInspectorPage):
      (WebKit::WebInspectorProxy::platformOpen):
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
      (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d4ea40b
    • commit-queue@webkit.org's avatar
      [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions... · 9f9b29b3
      commit-queue@webkit.org authored
      [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
      https://bugs.webkit.org/show_bug.cgi?id=68108
      
      This patch implements the event sender mouse events through WebKit2 UIProcess which is
      closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
      platform as the first step so the existing code is still kept for other platforms.
      
      Source/WebKit2:
      
      Patch by Chang Shu <cshu@webkit.org> on 2011-09-21
      Reviewed by Darin Adler.
      
      * UIProcess/API/C/WKPage.cpp:
      (WKPageSetShouldSendEventsSynchronously):
      * UIProcess/API/C/WKPagePrivate.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
      (WebKit::WebPageProxy::handleMouseEvent):
      (WebKit::WebPageProxy::handleKeyboardEvent):
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::setShouldSendEventsSynchronously):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::mouseEventSyncForTesting):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      
      Tools:
      
      Patch by Chang Shu <cshu@webkit.org> on 2011-09-21
      Reviewed by Darin Adler.
      
      * WebKitTestRunner/EventSenderProxy.h:
      (WTR::EventSenderProxy::EventSenderProxy):
      (WTR::EventSenderProxy::leapForward):
      (WTR::EventSenderProxy::currentEventTime):
      * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
      (WTR::EventSendingController::EventSendingController):
      (WTR::EventSendingController::mouseDown):
      (WTR::EventSendingController::mouseUp):
      (WTR::EventSendingController::mouseMoveTo):
      (WTR::EventSendingController::leapForward):
      (WTR::EventSendingController::keyDown):
      * WebKitTestRunner/InjectedBundle/EventSendingController.h:
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
      * WebKitTestRunner/mac/EventSenderProxy.mm:
      (WTR::eventTypeForMouseButtonAndAction):
      (WTR::operator==):
      (WTR::EventSenderProxy::updateClickCountForButton):
      (WTR::EventSenderProxy::mouseDown):
      (WTR::EventSenderProxy::mouseUp):
      (WTR::EventSenderProxy::mouseMoveTo):
      (WTR::EventSenderProxy::keyDown):
      * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
      (WTR::EventSenderProxy::keyDown):
      (WTR::EventSenderProxy::mouseDown):
      (WTR::EventSenderProxy::mouseUp):
      (WTR::EventSenderProxy::mouseMoveTo):
      
      LayoutTests:
      
      Unskip the passed tests.
      
      Patch by Chang Shu <cshu@webkit.org> on 2011-09-21
      Reviewed by Darin Adler.
      
      * platform/mac-wk2/Skipped:
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f9b29b3
    • mitz@apple.com's avatar
      Source/JavaScriptCore: JavaScriptCore Part of: Prevent the WebKit frameworks... · 983efa1b
      mitz@apple.com authored
      Source/JavaScriptCore: JavaScriptCore Part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
      https://bugs.webkit.org/show_bug.cgi?id=68451
      
      Reviewed by Darin Adler.
      
      * JavaScriptCore.xcodeproj/project.pbxproj: Added a script build phase that invokes
      check-for-inappropriate-objc-class-names, allowing only class names prefixed with "JS".
      
      Source/WebCore: WebCore part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
      https://bugs.webkit.org/show_bug.cgi?id=68451
      
      Reviewed by Darin Adler.
      
      * WebCore.xcodeproj/project.pbxproj: Added a script build phase that invokes
      check-for-inappropriate-objc-class-names, allowing only class names prefixed with "DOM" or "Web".
      
      Source/WebKit: WebKit part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
      https://bugs.webkit.org/show_bug.cgi?id=68451
      
      Reviewed by Darin Adler.
      
      * WebKit.xcodeproj/project.pbxproj: Added a script build phase that invokes
      check-for-inappropriate-objc-class-names, allowing only class names prefixed with "Web" or "_Web".
      
      Source/WebKit2: WebKit2 part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
      https://bugs.webkit.org/show_bug.cgi?id=68451
      
      Reviewed by Darin Adler.
      
      * WebKit2.xcodeproj/project.pbxproj: Added a script build phase that invokes
      check-for-inappropriate-objc-class-names, allowing only class names prefixed with "WK" or "Web".
      
      Tools: Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
      https://bugs.webkit.org/show_bug.cgi?id=68451
      
      Reviewed by Darin Adler.
      
      * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
      Objective-C classes with names not having one of a list of prefixes
      passed on the command line.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      983efa1b
    • commit-queue@webkit.org's avatar
      [Qt][WK2] Implement Download support in WebProcess · e131cac9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68153
      
      Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-09-21
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Refactored QNetworkReplyHandler::finish() in order to add
      and use the static function QNetworkReplyHandler::errorForReply().
      This will be used by our Download implementation in WebKit2 (WebProcess)
      when handling ResourceError.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyHandler::finish):
      (WebCore::QNetworkReplyHandler::errorForReply):
      * platform/network/qt/QNetworkReplyHandler.h:
      * platform/network/qt/ResourceRequest.h:
      
      Source/WebKit2:
      
      We implement the necessary functions of Download.h, and our QtFileDownloader
      to handle all network communication and call the necessary functions of Download.
      
      We use the download policy for any MIME type not supported by WebKit. This
      behaves like Qt non-WebKit2 except that we don't force download when
      we encounter Content-Disposition: attachment. We still use the "filename="
      field for file name suggestion though.
      
      Based on original patches by: Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>,
      Jocelyn Turcotte <jocelyn.turcotte@nokia.com>, Simon Hausmann <simon.hausmann@nokia.com>
      and Zalan Bujtas <zalan.bujtas@nokia.com>.
      
      * UIProcess/API/qt/qweberror.cpp: Adding DownloadError
      (QWebError::type):
      * UIProcess/API/qt/qweberror.h: Adding DownloadError
      * WebKit2.pro:
      * WebProcess/Downloads/Download.cpp: Adding QtFileDownloader, Qt platform specific
      (WebKit::Download::Download):
      * WebProcess/Downloads/Download.h: Adding QtFileDownloader, Qt platform specific
      * WebProcess/Downloads/qt/DownloadQt.cpp:
      (WebKit::Download::start):
      (WebKit::Download::startWithHandle):
      (WebKit::Download::cancel):
      (WebKit::Download::platformInvalidate):
      (WebKit::Download::didDecideDestination):
      * WebProcess/Downloads/qt/QtFileDownloader.cpp: Added.
      (WebKit::QtFileDownloader::QtFileDownloader):
      (WebKit::QtFileDownloader::~QtFileDownloader):
      (WebKit::QtFileDownloader::determineFilename):
      (WebKit::QtFileDownloader::decidedDestination):
      (WebKit::QtFileDownloader::abortDownloadWritingAndEmitError):
      (WebKit::QtFileDownloader::onReadyRead):
      (WebKit::QtFileDownloader::onFinished):
      (WebKit::QtFileDownloader::onError):
      (WebKit::QtFileDownloader::cancel):
      * WebProcess/Downloads/qt/QtFileDownloader.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e131cac9
    • mrowe@apple.com's avatar
      <rdar://problem/9890932> "Open PDF in Preview" on two PDFs of the same name... · 38519bbc
      mrowe@apple.com authored
      <rdar://problem/9890932> "Open PDF in Preview" on two PDFs of the same name does nothing the second time
      
      The logic in PDFViewController::pathToPDFOnDisk that deals with constructing a unique
      file name if a file of the suggested name already exists was incorrect. It was appending
      the template used by mkstemps to the directory name component of the path rather than
      using it as a prefix on the filename portion of the path. This resulted in a template path
      like WebKitPDFs-ABCDEFXXXXXX-/foo.pdf where WebKitPDFs-ABCDEF/XXXXXX-foo.pdf was expected.
      
      Reviewed by Jon Honeycutt.
      
      * UIProcess/API/mac/PDFViewController.mm:
      (WebKit::PDFViewController::pathToPDFOnDisk): Append the template as a new path component,
      then append the suggested file name to that component.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38519bbc
    • abecsi@webkit.org's avatar
      [Qt] Remove Qt specific code from css/SelectorChecker.cpp · 6e1f6ccd
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67702
      
      Reviewed by Csaba Osztrogonác.
      
      Source/WebCore:
      
      No new tests needed.
      
      * css/SelectorChecker.cpp: Move Qt-specific code to the Qt-specific WebPlatformStrategies.
      (WebCore::SelectorChecker::determineLinkStateSlowCase):
      * platform/VisitedLinkStrategy.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebPlatformStrategies.h:
      * WebCoreSupport/WebPlatformStrategies.mm:
      (WebPlatformStrategies::isLinkVisited):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/WebPlatformStrategies.cpp: Check the Qt global history here, instead of a platform independent file.
      (WebPlatformStrategies::isLinkVisited):
      * WebCoreSupport/WebPlatformStrategies.h:
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebPlatformStrategies.cpp: Modify to match new prototype.
      (WebPlatformStrategies::isLinkVisited):
      * WebCoreSupport/WebPlatformStrategies.h: Ditto.
      
      Source/WebKit/wince:
      
      * WebCoreSupport/PlatformStrategiesWinCE.cpp:
      (PlatformStrategiesWinCE::addVisitedLink):
      * WebCoreSupport/PlatformStrategiesWinCE.h:
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Modify to match new prototype.
      (WebKit::WebPlatformStrategies::isLinkVisited):
      (WebKit::WebPlatformStrategies::addVisitedLink):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.h: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e1f6ccd
  4. 20 Sep, 2011 10 commits
    • andersca@apple.com's avatar
      Get rid of PluginView::setBoundsSize from WebKit2 · 6e9b5862
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68489
      
      Reviewed by Dan Bernstein.
      
      Remove m_boundsSize and the setter since they aren't used anywhere.
      
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/Plugins/PluginView.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e9b5862
    • commit-queue@webkit.org's avatar
      [Qt] QTouchWebView missing signal tests for loadProgress · 44aadf31
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68442
      
      Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-20
      Reviewed by Chang Shu.
      
      Added test case to check load progress signal for QTouchWebView
      
      * UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml: Added.
      * UIProcess/API/qt/tests/qmltests/qmltests.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44aadf31
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r95565. · 62fa0b55
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/95565
      https://bugs.webkit.org/show_bug.cgi?id=68470
      
      Broke builds (Requested by andersca on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-20
      
      Source/WebKit2:
      
      * GNUmakefile.am:
      * Shared/API/c/WKHitTestResult.cpp: Removed.
      * Shared/API/c/WKHitTestResult.h: Removed.
      * UIProcess/API/C/WebKit2.h:
      
      Tools:
      
      * MiniBrowser/gtk/BrowserWindow.c:
      (mouseDidMoveOverElement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62fa0b55
    • alexis.menard@openbossa.org's avatar
      [Qt] [WK2] Implement a persistent cookie storage. · 0da27b38
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65309
      
      Reviewed by Chang Shu.
      
      Source/WebCore:
      
      Implement a cookie storage for the Qt port on WebKit2.
      The implementation is using a SQLite database to store the cookies
      and restore them. It uses a static object as CookieJar is not an
      object but a set of global functions. The actual saving/restoring is on
      the WebProcess side where our network stack lives.
      
      Existing tests cover the new implementation. Unfortunately there is one
      case that we can't easily simulate : login in a website, make sure that the webprocess
      is not running and then going back to this website and see that we are logged.
      
      * WebCore.pri:
      * WebCore.pro:
      * platform/qt/CookieJarQt.cpp:
      (WebCore::getHostnamesWithCookies):
      (WebCore::deleteCookiesForHostname):
      (WebCore::deleteAllCookies):
      (WebCore::SharedCookieJarQt::shared):
      (WebCore::SharedCookieJarQt::create):
      (WebCore::SharedCookieJarQt::destroy):
      (WebCore::SharedCookieJarQt::getHostnamesWithCookies):
      (WebCore::SharedCookieJarQt::deleteCookiesForHostname):
      (WebCore::SharedCookieJarQt::deleteAllCookies):
      (WebCore::SharedCookieJarQt::SharedCookieJarQt):
      (WebCore::SharedCookieJarQt::~SharedCookieJarQt):
      (WebCore::SharedCookieJarQt::setCookiesFromUrl):
      (WebCore::SharedCookieJarQt::ensureDatabaseTable):
      (WebCore::SharedCookieJarQt::loadCookies):
      * platform/qt/CookieJarQt.h: Added.
      
      Source/WebKit2:
      
      Add parameter to the WebProcess creation to specify where cookies should be saved.
      It also use the new cookie storage implementation and set it to our network stack
      so cookies are used when using it.
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::encode):
      (WebKit::WebProcessCreationParameters::decode):
      * Shared/WebProcessCreationParameters.h:
      * UIProcess/qt/WebContextQt.cpp:
      (WebKit::WebContext::platformInitializeWebProcess):
      * WebProcess/qt/WebProcessQt.cpp:
      (WebKit::WebProcess::platformInitializeWebProcess):
      (WebKit::WebProcess::platformTerminate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0da27b38
    • commit-queue@webkit.org's avatar
      Source/WebKit2: Added WKHitTestResult API's. · 4accfe4f
      commit-queue@webkit.org authored
      WKHitTestResult API's are added. These API's can be used to
      get the hover'ed link/image/media URL as well as link lable and
      title.
      https://bugs.webkit.org/show_bug.cgi?id=68426
      
      Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-20
      Reviewed by Anders Carlsson.
      
      * GNUmakefile.am:
      * Shared/API/c/WKHitTestResult.cpp: Copied from Source/WebKit2/UIProcess/API/C/WebKit2.h.
      (WKHitTestResultGetTypeID):
      (WKHitTestResultCopyAbsoluteImageURL):
      (WKHitTestResultCopyAbsoluteLinkURL):
      (WKHitTestResultCopyAbsoluteMediaURL):
      (WKHitTestResultCopyLinkLabel):
      (WKHitTestResultCopyLinkTitle):
      * Shared/API/c/WKHitTestResult.h: Copied from Source/WebKit2/UIProcess/API/C/WebKit2.h.
      * UIProcess/API/C/WebKit2.h:
      
      Tools: Get hover'ed element URL from HitTest.
      
      mouseDidMoveOverElement now gets the hover'ed element link using
      WKHitTestResult API's.
      https://bugs.webkit.org/show_bug.cgi?id=68426
      
      Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-20
      Reviewed by Anders Carlsson.
      
      * MiniBrowser/gtk/BrowserWindow.c:
      (mouseDidMoveOverElement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4accfe4f
    • alexis.menard@openbossa.org's avatar
      [Qt][WK2] Add stubs for FULLSCREEN_API on Qt. · f48c8b28
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68444
      
      Reviewed by Andreas Kling.
      
      Create all the stubs necessary for enabling FULLSCREEN_API on the Qt port.
      
      Source/WebCore:
      
      No new tests : just stubs.
      
      * CodeGenerators.pri:
      * WebCore.pro:
      * features.pri:
      
      Source/WebKit2:
      
      * UIProcess/qt/WebFullScreenManagerProxyQt.cpp: Added.
      (WebKit::WebFullScreenManagerProxy::invalidate):
      (WebKit::WebFullScreenManagerProxy::enterFullScreen):
      (WebKit::WebFullScreenManagerProxy::exitFullScreen):
      (WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation):
      (WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation):
      (WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation):
      (WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation):
      (WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode):
      (WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode):
      (WebKit::WebFullScreenManagerProxy::getFullScreenRect):
      * WebKit2.pro:
      * WebProcess/FullScreen/qt: Added.
      * WebProcess/FullScreen/qt/WebFullScreenManagerQt.cpp: Added.
      (WebKit::WebFullScreenManagerQt::WebFullScreenManagerQt):
      (WebKit::WebFullScreenManager::create):
      (WebKit::WebFullScreenManagerQt::setRootFullScreenLayer):
      (WebKit::WebFullScreenManagerQt::beginEnterFullScreenAnimation):
      (WebKit::WebFullScreenManagerQt::beginExitFullScreenAnimation):
      * WebProcess/FullScreen/qt/WebFullScreenManagerQt.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f48c8b28
    • alexis.menard@openbossa.org's avatar
      [Qt][WK2] Export QNetworkReply in the QtWebKit QML module. · 94ed9645
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68401
      
      Reviewed by Simon Hausmann.
      
      Add QNetworkReply in the QtWebKit module. We use the enum QNetworkReply::NetworkError
      as the error code when the load fails. It is not used in the QtQuick module therefore
      the QML team thinks it should belong here. Also added some auto-tests to cover the
      loading errors.
      
      * UIProcess/API/qt/qmlplugin/plugin.cpp:
      (WebKit2QmlPlugin::registerTypes):
      * UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml: Added.
      * UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94ed9645
    • ossy@webkit.org's avatar
      Source/WebCore: [Qt][Mac] Buildfix after r95513. · d2994478
      ossy@webkit.org authored
      Forwarding headers for WebCore should be generated based on WebCore sources instead of WebKit2.
      
      Rubber-stamped by Andras Becsi.
      
      * DerivedSources.pro:
      * WebCore.pro: Add platform/mac/DisplaySleepDisabler.cpp to SOURCES.
      
      Source/WebKit2: [Qt][Mac] Buildfix after r95513.
      
      Rubber-stamped by Andras Becsi.
      
      * Scripts/generate-forwarding-headers.pl: Add mm file supporting.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2994478
    • commit-queue@webkit.org's avatar
      [Qt] QDesktopWebView missing loadProgress tests · feab3299
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68280
      
      Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-20
      Reviewed by Andreas Kling.
      
      Added test case to check load progress property and signal for QDesktopWebView
      
      * UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml: Added.
      * UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml: Added.
      * UIProcess/API/qt/tests/qmltests/qmltests.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      feab3299
    • carlosgc@webkit.org's avatar
      [GTK] WebProcess shouldn't use the GTK+ API · f7325f4b
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68062
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Move errors code that is common between webki1 and webkit2 to
      WebCore so that it can be shared.
      
      * GNUmakefile.list.am: Add new files to compilation.
      * platform/gtk/ErrorsGtk.cpp: Added.
      (WebCore::cancelledError):
      (WebCore::blockedError):
      (WebCore::cannotShowURLError):
      (WebCore::interruptedForPolicyChangeError):
      (WebCore::cannotShowMIMETypeError):
      (WebCore::fileDoesNotExistError):
      (WebCore::pluginWillHandleLoadError):
      * platform/gtk/ErrorsGtk.h: Added.
      
      Source/WebKit/gtk:
      
      Use WebCore API to create errors in frame loader.
      
      * WebCoreSupport/AssertMatchingEnums.cpp:
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::cancelledError):
      (WebKit::FrameLoaderClient::blockedError):
      (WebKit::FrameLoaderClient::cannotShowURLError):
      (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
      (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
      (WebKit::FrameLoaderClient::fileDoesNotExistError):
      (WebKit::FrameLoaderClient::pluginWillHandleLoadError):
      * webkit/webkiterror.cpp:
      (webkit_network_error_quark):
      (webkit_policy_error_quark):
      (webkit_plugin_error_quark):
      
      Source/WebKit/gtk/po:
      
      * POTFILES: Remove FrameLoaderGtk.cpp and add ErrorsGtk.cpp.
      
      Source/WebKit2:
      
      Use WebCore API to create errors in WebProcess.
      
      * GNUmakefile.am: Don't use webkit/webkierror.h.
      * WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:
      (WebKit::cancelledError):
      (WebKit::blockedError):
      (WebKit::cannotShowURLError):
      (WebKit::interruptedForPolicyChangeError):
      (WebKit::cannotShowMIMETypeError):
      (WebKit::fileDoesNotExistError):
      (WebKit::pluginWillHandleLoadError):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7325f4b
  5. 19 Sep, 2011 7 commits
    • mrowe@apple.com's avatar
      <http://webkit.org/b/68421> Stop calling UpdateSystemActivity in places where... · c3dd2be0
      mrowe@apple.com authored
      <http://webkit.org/b/68421> Stop calling UpdateSystemActivity in places where we hold power assertions that achieve the same effect
      
      On SnowLeopard and newer it's not necessary to call UpdateSystemActivity to prevent the screensaver from kicking
      in as the NoDisplaySleep assertion now has that effect. It's also not necessary to hold both a NoDisplaySleep and
      a NoIdleSleep assertion as the latter is implied by the former.
      
      Source/WebCore:
      
      Since there were multiple copies of the same code to disable display sleep spread across WebCore, WebKit and WebKit2
      this patch takes the approach of moving this functionality to a new DisplaySleepDisabler class that lives in WebCore.
      A class is used as it makes it easier to reason about the lifetime of the assertions and to ensure that the assertions will
      always be released when their owning objects go away.
      
      Reviewed by Dan Bernstein.
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/mac/DisplaySleepDisabler.cpp:
      (WebCore::DisplaySleepDisabler::DisplaySleepDisabler): Register for the NoDisplaySleep assertion, and start our
      system activity timer when on Leopard.
      (WebCore::DisplaySleepDisabler::~DisplaySleepDisabler): Unregister for the assertion.
      (WebCore::DisplaySleepDisabler::systemActivityTimerFired): Call UpdateSystemActivity to prevent the screensaver from
      triggering on Leopard.
      * platform/mac/DisplaySleepDisabler.h:
      (WebCore::DisplaySleepDisabler::create):
      * platform/mac/WebVideoFullscreenController.h:
      * platform/mac/WebVideoFullscreenController.mm:
      (-[WebVideoFullscreenController dealloc]):
      (-[WebVideoFullscreenController setupVideoOverlay:]): Remove the now-unnecessary explicit use of the WebCore namespace.
      (-[WebVideoFullscreenController mediaElement]): Ditto.
      (-[WebVideoFullscreenController setMediaElement:]): Ditto.
      (-[WebVideoFullscreenController windowDidExitFullscreen]): Ditto.
      (-[WebVideoFullscreenController updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
      display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
      disabler that we own.
      
      Source/WebKit/mac:
      
      Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WebFullScreenController.
      
      Reviewed by Dan Bernstein.
      
      * WebView/WebFullScreenController.h:
      * WebView/WebFullScreenController.mm:
      (-[WebFullScreenController dealloc]):
      (-[WebFullScreenController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
      display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
      disabler that we own.
      
      Source/WebKit2:
      
      Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WKFullScreenWindowController.
      
      Reviewed by Dan Bernstein.
      
      * UIProcess/mac/WKFullScreenWindowController.h:
      * UIProcess/mac/WKFullScreenWindowController.mm:
      (-[WKFullScreenWindowController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
      display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
      disabler that we own. Also adds a FIXME about an error that was noticed while working in this code.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3dd2be0
    • abarth@webkit.org's avatar
      Always enable ENABLE(EVENTSOURCE) · ff5a5ea0
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68414
      
      Reviewed by Eric Seidel.
      
      .:
      
      * Source/cmake/OptionsEfl.cmake:
      * Source/cmake/OptionsWinCE.cmake:
      * Source/cmakeconfig.h.cmake:
      * configure.ac:
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      EventSource seems to be here to stay.  This patch makes WebKit more
      hackable by removing this ENABLE macro, as discussed on webkit-dev.
      
      * Configurations/FeatureDefines.xcconfig:
      * GNUmakefile.am:
      * bindings/cpp/WebDOMEventTarget.cpp:
      (toWebKit):
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::eventSource):
      * bindings/js/JSEventSourceCustom.cpp:
      * bindings/js/JSEventTarget.cpp:
      (WebCore::toJS):
      (WebCore::toEventTarget):
      * bindings/js/JSWorkerContextCustom.cpp:
      (WebCore::JSWorkerContext::eventSource):
      * bindings/v8/V8DOMWrapper.cpp:
      (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
      * features.pri:
      * page/DOMWindow.idl:
      * page/EventSource.cpp:
      * page/EventSource.h:
      * page/EventSource.idl:
      * workers/WorkerContext.idl:
      
      Source/WebKit/chromium:
      
      * features.gypi:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Tools:
      
      * Scripts/build-webkit:
      
      WebKitLibraries:
      
      * win/tools/vsprops/FeatureDefines.vsprops:
      * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff5a5ea0
    • alexis.menard@openbossa.org's avatar
      [Qt] Unreviewed coding style fix. · e15cac14
      alexis.menard@openbossa.org authored
      * UIProcess/API/qt/qdesktopwebview.h:
      * UIProcess/API/qt/qtouchwebpage.h:
      * UIProcess/API/qt/qweberror.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e15cac14
    • alexis.menard@openbossa.org's avatar
      [Qt][WK2] Make loading errors API easier to use. · 389c4043
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68357
      
      Reviewed by Tor Arne Vestbø.
      
      Make the API to get loading errors easier to use. 95197 introduced
      a QJSValue API that is a bit opaque for the client code. Rather than
      using a dedicated object, we can just pass the needed information as
      parameters of the slot.
      
      * UIProcess/API/qt/qdesktopwebview.cpp:
      (QDesktopWebViewPrivate::loadDidFail):
      * UIProcess/API/qt/qdesktopwebview.h:
      * UIProcess/API/qt/qdesktopwebview_p.h:
      * UIProcess/API/qt/qtouchwebpage.h:
      * UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
      (tst_CommonViewTests::loadNonexistentFileUrl):
      * UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
      (WebViewAbstraction::WebViewAbstraction):
      (WebViewAbstraction::touchViewLoadFailed):
      (WebViewAbstraction::desktopViewLoadFailed):
      * UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
      * UIProcess/qt/QtWebPageProxy.cpp:
      (QtWebPageProxy::loadDidFail):
      * UIProcess/qt/TouchViewInterface.cpp:
      (WebKit::TouchViewInterface::loadDidFail):
      * UIProcess/qt/TouchViewInterface.h:
      * UIProcess/qt/ViewInterface.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      389c4043
    • mitz@apple.com's avatar
      Source/JavaScriptCore: JavaScriptCore part of [mac] WebKit contains... · f374f151
      mitz@apple.com authored
      Source/JavaScriptCore: JavaScriptCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
      https://bugs.webkit.org/show_bug.cgi?id=68323
      
      Reviewed by Sam Weinig.
      
      Renamed WTFMainThreadCaller to JSWTFMainThreadCaller.
      
      * wtf/mac/MainThreadMac.mm:
      (WTF::initializeMainThreadPlatform):
      (WTF::initializeMainThreadToProcessMainThreadPlatform):
      
      Source/WebCore: WebCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
      https://bugs.webkit.org/show_bug.cgi?id=68323
      
      Reviewed by Sam Weinig.
      
      Renamed AccessibilityObjectWrapper to WebAccessibilityObjectWrapper.
      Renamed CascadeList to WebCascadeList.
      Renamed CookieStorageObjCAdapter to WebCookieStorageObjCAdapter.
      Renamed LanguageChangeObserver to WebLanguageChangeObserver.
      Renamed ScrollAnimationHelperDelegate to WebScrollAnimationHelperDelegate.
      Renamed ScrollbarPainterControllerDelegate to WebScrollbarPainterControllerDelegate.
      Renamed ScrollbarPainterDelegate to WebScrollbarPainterDelegate.
      Renamed ScrollbarPartAnimation to WebScrollbarPartAnimation.
      Renamed ScrollbarPrefsObserver to WebScrollbarPrefsObserver.
      
      * WebCore.gyp/WebCore.gyp: Updated for the renaming of CascadeList to WebCascadeList.
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityObject.h:
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::attachWrapper):
      * accessibility/mac/AccessibilityObjectMac.mm:
      * accessibility/mac/AccessibilityObjectWrapper.h: Removed.
      * accessibility/mac/AccessibilityObjectWrapper.mm: Removed.
      * accessibility/mac/WebAccessibilityObjectWrapper.h: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.h.
      * accessibility/mac/WebAccessibilityObjectWrapper.mm: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm.
      (convertToNSArray):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
      (-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
      (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
      * platform/graphics/mac/ComplexTextControllerCoreText.mm:
      (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
      * platform/mac/Language.mm:
      (WebCore::platformDefaultLanguage):
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (-[WebScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
      (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
      * platform/mac/ScrollbarThemeMac.mm:
      (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
      * platform/network/mac/CookieStorageMac.mm:
      (WebCore::startObservingCookieChanges):
      
      Source/WebKit: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
      https://bugs.webkit.org/show_bug.cgi?id=68323
      
      Reviewed by Sam Weinig.
      
      Updated for the renaming of NonBlockingPanel to WebNonBlockingPanel.
      
      * English.lproj/WebJavaScriptTextInputPanel.nib/classes.nib: Removed.
      * English.lproj/WebJavaScriptTextInputPanel.nib/designable.nib: Added.
      * English.lproj/WebJavaScriptTextInputPanel.nib/info.nib: Removed.
      * English.lproj/WebJavaScriptTextInputPanel.nib/keyedobjects.nib:
      
      Source/WebKit/mac: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
      https://bugs.webkit.org/show_bug.cgi?id=68323
      
      Reviewed by Sam Weinig.
      
      Renamed NonBlockingPanel to WebNonBlockingPanel.
      Renamed ThreadEnabler to WebCocoaThreadingEnabler.
      Renamed PDFPrefUpdatingProxy to WebPDFPrefUpdatingProxy.
      
      * Misc/WebIconDatabase.mm:
      (+[WebCocoaThreadingEnabler enableThreading]):
      (importToWebCoreFormat):
      * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
      * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
      * Panels/WebAuthenticationPanel.h:
      * Panels/WebAuthenticationPanel.m: Renamed NonBlockingPanel to
      WebNonBlockingPanel. Because Safari 5.1 uses NonBlockingPanel, this will
      cause nightly builds to log an error message when showing the Safari
      HTTP authentication sheet and disable the Quit command while the sheet
      is disaplyed.
      * WebView/WebPDFView.mm:
      (-[WebPDFView initWithFrame:]):
      (-[WebPDFView _updatePreferencesSoon]):
      
      Source/WebKit2: WebKit2 part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
      https://bugs.webkit.org/show_bug.cgi?id=68323
      
      Reviewed by Sam Weinig.
      
      Renamed FullKeyboardAccessWatcher to WKFullKeyboardAccessWatcher.
      Renamed AccessibilityWebPageObject to WKAccessibilityWebPageObject.
      
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Removed.
      * WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Removed.
      * WebProcess/WebPage/mac/WKAccessibilityWebPageObject.h: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.h.
      * WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.mm.
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::platformInitialize):
      (WebKit::WebPage::accessibilityRemoteObject):
      * WebProcess/mac/FullKeyboardAccessWatcher.h: Removed.
      * WebProcess/mac/FullKeyboardAccessWatcher.mm: Removed.
      * WebProcess/mac/WKFullKeyboardAccessWatcher.h: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.h.
      * WebProcess/mac/WKFullKeyboardAccessWatcher.mm: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.mm.
      (+[WKFullKeyboardAccessWatcher fullKeyboardAccessEnabled]):
      * WebProcess/mac/WebProcessMac.mm:
      (WebKit::WebProcess::fullKeyboardAccessEnabled):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f374f151
    • caio.oliveira@openbossa.org's avatar
      [Qt] [WK2] Implement popup menus in QDesktopWebView using QComboBox · d836f3b9
      caio.oliveira@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67938
      
      Reviewed by Andreas Kling.
      
      Implement a WebPopupMenuProxy that uses QtWebComboBox (a QComboBox subclass we
      have for WK1). Then use this WebPopupMenuProxy in QDesktopWebView. The implementation
      explicitly avoids running a nested mainloop.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::showPopupMenu):
      Since we don't run a nested mainloop, we need to keep the client pointer to call
      valueChangedForPopupMenu().
      
      * UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp: Added.
      (WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
      (WebKit::WebPopupMenuProxyQtDesktop::~WebPopupMenuProxyQtDesktop):
      (WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):
      (WebKit::WebPopupMenuProxyQtDesktop::hidePopupMenu):
      (WebKit::WebPopupMenuProxyQtDesktop::setSelectedIndex):
      (WebKit::WebPopupMenuProxyQtDesktop::onPopupMenuHidden):
      (WebKit::WebPopupMenuProxyQtDesktop::populate):
      * UIProcess/qt/WebPopupMenuProxyQtDesktop.h: Added.
      (WebKit::WebPopupMenuProxyQtDesktop::create):
      * UIProcess/qt/qdesktopwebpageproxy.cpp:
      (QDesktopWebPageProxy::createPopupMenuProxy):
      * UIProcess/qt/qdesktopwebpageproxy.h:
      * WebKit2.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d836f3b9
    • carlosgc@webkit.org's avatar
      [GTK] Fix distcheck build · caee6bf6
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68241
      
      Reviewed by Martin Robinson.
      
      Source/JavaScriptCore:
      
      * GNUmakefile.list.am:
      
      Source/WebCore:
      
      * GNUmakefile.list.am:
      
      Source/WebKit2:
      
      * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      caee6bf6