1. 23 Sep, 2011 31 commits
    • commit-queue@webkit.org's avatar
      .: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests · 90680248
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      Tests: fast/dom/scroll-element-to-rect-centered.html
             fast/dom/scroll-element-to-rect.html
      
      * WebCore.exp.in:
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollElementToRect):
      * page/FrameView.h:
      * testing/Internals.cpp:
      (WebCore::Internals::scrollElementToRect):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/chromium: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * public/WebView.h:
      (WebKit::WebView::scrollFocusedNodeIntoRect):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
      
      Source/WebKit2: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
      https://bugs.webkit.org/show_bug.cgi?id=68198
      
      Patch by Varun Jain <varunjain@google.com> on 2011-09-23
      Reviewed by Dimitri Glazkov.
      
      * fast/dom/scroll-element-to-rect-centered-expected.txt: Added.
      * fast/dom/scroll-element-to-rect-centered.html: Added.
      * fast/dom/scroll-element-to-rect-expected.txt: Added.
      * fast/dom/scroll-element-to-rect.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90680248
    • mihaip@chromium.org's avatar
      Unreviewed, rolling out r95860. · 54ffaf76
      mihaip@chromium.org authored
      http://trac.webkit.org/changeset/95860
      https://bugs.webkit.org/show_bug.cgi?id=68648
      
      Breaks overhang rendering on Chromium Mac
      
      Source/WebCore:
      
      * platform/chromium/ScrollbarThemeChromium.cpp:
      * platform/chromium/ScrollbarThemeChromium.h:
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
      (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
      
      Source/WebKit/chromium:
      
      * features.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54ffaf76
    • dino@apple.com's avatar
      Add -webkit-filter to CSSPropertyNames · 335772d5
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68675
      
      Reviewed by Simon Fraser.
      
      Add property and rudimentary parsing for -webkit-filter. The
      property value isn't preserved anywhere yet. Add
      stub definition for computed style.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      (WebCore::CSSParser::parseFilter):
      * css/CSSParser.h:
      * css/CSSPropertyNames.in:
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      
      New test for rudimentary parsing of -webkit-filter.
      Since currently only the Apple port enables the
      feature, add this new test to the platform skip lists
      for GTK, QT and Chromium.
      
      * css3/filters/filter-property-expected.txt: Added.
      * css3/filters/filter-property.html: Added.
      * css3/filters/script-tests/TEMPLATE.html: Added.
      * css3/filters/script-tests/filter-property.js: Added.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/Skipped:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      335772d5
    • commit-queue@webkit.org's avatar
      Remove preserves3D() from CCLayerDelegate, replacing it by setting the · 04f485d6
      commit-queue@webkit.org authored
      value explicitly after creating a layer, or setting its delegate.
      https://bugs.webkit.org/show_bug.cgi?id=68295
      
      Patch by Antoine Labour <piman@chromium.org> on 2011-09-23
      Reviewed by James Robinson.
      
      Covered by compositing/ layeout tests.
      
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      (WebCore::GraphicsLayerChromium::setContentsToCanvas):
      (WebCore::GraphicsLayerChromium::setContentsToMedia):
      (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
      (WebCore::GraphicsLayerChromium::setupContentsLayer):
      * platform/graphics/chromium/GraphicsLayerChromium.h:
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::LayerChromium):
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore::LayerChromium::setPreserves3D):
      (WebCore::LayerChromium::preserves3D):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04f485d6
    • jchaffraix@webkit.org's avatar
      Implicit conversion double to float in ShadowBlur::adjustBlurRadius · 18bc6bc8
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68722
      
      Reviewed by Simon Fraser.
      
      * platform/graphics/ShadowBlur.cpp:
      (WebCore::ShadowBlur::adjustBlurRadius): Added 2 explicit
      conversions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18bc6bc8
    • mitz@apple.com's avatar
      <rdar://problem/10178576> REGRESSION (r95391): Crash in -[WebCascadeList... · 0190f2cc
      mitz@apple.com authored
      <rdar://problem/10178576> REGRESSION (r95391): Crash in -[WebCascadeList objectAtIndex:] when a font-family list contains missing fonts
      https://bugs.webkit.org/show_bug.cgi?id=68737
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Test: fast/text/combining-character-sequence-fallback-crash.html
      
      * platform/graphics/mac/ComplexTextControllerCoreText.mm:
      (-[WebCascadeList initWithFont:WebCore::character:]): Changed to intialize _count to the exact
      number of FontData instances in the fallback list rather than the number of font families in the
      font description.
      
      LayoutTests: 
      
      * fast/text/combining-character-sequence-fallback-crash-expected.txt: Added.
      * fast/text/combining-character-sequence-fallback-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0190f2cc
    • commit-queue@webkit.org's avatar
      [Chromium] Fix CSS 3D corner anti-aliasing. · 8aaef514
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68087
      
      Patch by David Reveman <reveman@chromium.org> on 2011-09-23
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Render sharp corners more correctly by adding bounding box
      edges to anti-aliasing shaders.
      
      Test: platform/chromium/compositing/3d-corners.html
      
      * platform/graphics/chromium/ShaderChromium.cpp:
      (WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
      (WebCore::FragmentShaderRGBATexClampAlphaAA::getShaderString):
      (WebCore::FragmentShaderRGBATexClampSwizzleAlphaAA::getShaderString):
      (WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):
      * platform/graphics/chromium/cc/CCRenderSurface.cpp:
      (WebCore::CCRenderSurface::drawLayer):
      (WebCore::CCRenderSurface::drawSurface):
      * platform/graphics/chromium/cc/CCRenderSurface.h:
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
      (WebCore::CCTiledLayerImpl::draw):
      (WebCore::CCTiledLayerImpl::drawTiles):
      * platform/graphics/chromium/cc/CCTiledLayerImpl.h:
      
      LayoutTests:
      
      Add a test to check sharp corner rendering of CSS 3D transformed
      elements.
      
      * platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Removed.
      * platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
      * platform/chromium-gpu-linux/platform/chromium/compositing/3d-corners-expected.png: Added.
      * platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
      * platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
      * platform/chromium/compositing/3d-corners-expected.txt: Added.
      * platform/chromium/compositing/3d-corners.html: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8aaef514
    • oliver@apple.com's avatar
      Make write barriers actually do something when enabled · 0cae6935
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68717
      
      Reviewed by Geoffrey Garen.
      
      ../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:
      
      Add a basic card marking style write barrier to JSC (currently
      turned off).  This requires two scratch registers in the JIT
      so there was some register re-arranging to satisfy that requirement.
      Happily this produced a minor perf bump in sunspider (~0.5%).
      
      Turning the barriers on causes an overall regression of around 1.5%
      
      * JavaScriptCore.exp:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * assembler/MacroAssemblerX86Common.h:
      (JSC::MacroAssemblerX86Common::store8):
      * assembler/X86Assembler.h:
      (JSC::X86Assembler::movb_i8m):
      * dfg/DFGJITCodeGenerator.cpp:
      (JSC::DFG::JITCodeGenerator::isKnownNotCell):
      (JSC::DFG::JITCodeGenerator::writeBarrier):
      (JSC::DFG::JITCodeGenerator::markCellCard):
      (JSC::DFG::JITCodeGenerator::cachedPutById):
      * dfg/DFGJITCodeGenerator.h:
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::tryCachePutByID):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * heap/CardSet.h: Added.
      (JSC::CardSet::CardSet):
      (JSC::::cardForAtom):
      (JSC::::cardMarkedForAtom):
      (JSC::::markCardForAtom):
      * heap/Heap.cpp:
      * heap/Heap.h:
      (JSC::Heap::addressOfCardFor):
      (JSC::Heap::writeBarrierFastCase):
      * heap/MarkedBlock.h:
      (JSC::MarkedBlock::setDirtyObject):
      (JSC::MarkedBlock::addressOfCardFor):
      (JSC::MarkedBlock::offsetOfCards):
      * jit/JIT.h:
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::emit_op_put_by_val):
      (JSC::JIT::emit_op_put_by_id):
      (JSC::JIT::privateCompilePutByIdTransition):
      (JSC::JIT::emit_op_put_scoped_var):
      (JSC::JIT::emit_op_put_global_var):
      (JSC::JIT::emitWriteBarrier):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::emit_op_put_by_val):
      (JSC::JIT::emit_op_put_by_id):
      (JSC::JIT::emitSlow_op_put_by_id):
      (JSC::JIT::privateCompilePutByIdTransition):
      (JSC::JIT::emit_op_put_scoped_var):
      (JSC::JIT::emit_op_put_global_var):
      
      ../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:
      
      Add a forwarding header, and fix an evaluation ordering
      issue that shows up if you try to use write barriers.
      
      * ForwardingHeaders/heap/CardSet.h: Added.
      * bindings/js/JSEventListener.h:
      (WebCore::JSEventListener::jsFunction):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cae6935
    • jamesr@google.com's avatar
      Avoid updating compositing state during paint · ef5cfe20
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68727
      
      Reviewed by Simon Fraser.
      
      We shouldn't update our compositing state in the middle of a paint. The call to
      updateCompositingAndLayerListsIfNeeded() was added to RenderLayer::paintLayer in r45715, which was intended to
      fix this exact issue. Based off the ChangeLog entries, I think that this was just a typo.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::paintLayer):
      (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::updateCompositingLayers):
      * rendering/RenderLayerCompositor.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef5cfe20
    • fsamuel@chromium.org's avatar
      Refactor paintOverhangAreas to allow non-Mac Chromium platforms to reuse code · 41ed8679
      fsamuel@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68648
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      No new tests because there's no change in functionality (yet).
      
      * platform/chromium/ScrollbarThemeChromium.cpp:
      (WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
      (WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
      (WebCore::ScrollbarThemeChromium::paintOverhangAreas):
      * platform/chromium/ScrollbarThemeChromium.h:
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
      
      Source/WebKit/chromium:
      
      * features.gypi:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41ed8679
    • ojan@chromium.org's avatar
      remove physical flex-flow values to match the updated spec · 68237c01
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68728
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::operator EFlexFlow):
      * css/CSSValueKeywords.in:
      * rendering/style/RenderStyleConstants.h:
      
      LayoutTests:
      
      * css3/flexbox/css-properties-expected.txt:
      * css3/flexbox/script-tests/css-properties.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68237c01
    • inferno@chromium.org's avatar
      Source/WebCore: Style not updated for :before, :after content · b16d1a4c
      inferno@chromium.org authored
      in ruby text.
      https://bugs.webkit.org/show_bug.cgi?id=68625
      
      Reviewed by Dave Hyatt.
      
      Test: fast/ruby/ruby-text-before-after-content.html
      
      * rendering/RenderRubyText.cpp:
      (WebCore::RenderRubyText::updateBeforeAfterContent):
      * rendering/RenderRubyText.h:
      
      LayoutTests: Style not updated for :before, :after content
      in ruby text.
      https://bugs.webkit.org/show_bug.cgi?id=68625
              
      Reviewed by Dave Hyatt.
      
      * fast/ruby/ruby-text-before-after-content-expected.png: Added.
      * fast/ruby/ruby-text-before-after-content-expected.txt: Added.
      * fast/ruby/ruby-text-before-after-content.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b16d1a4c
    • ojan@chromium.org's avatar
      refactor RenderFlexibleBox to use flex-flow aware methods · e3b8170b
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68665
      
      Reviewed by Tony Chang.
      
      This is just a refactor. Just move the all the code that needs to
      be flow aware into helper functions. Actually making them flow-aware
      can be done in a followup patch.
      
      * rendering/RenderBlock.cpp:
      * rendering/RenderBlock.h:
      Moved setLogicalLocationForChild into RenderFlexibleBox since that was the only caller.
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::hasOrthogonalFlow):
      (WebCore::RenderFlexibleBox::isHorizontalFlow):
      (WebCore::RenderFlexibleBox::isLeftToRightFlow):
      (WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
      (WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
      (WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
      (WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
      (WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
      (WebCore::RenderFlexibleBox::flowAwareAvailableLogicalWidth):
      (WebCore::RenderFlexibleBox::flowAwareBorderStart):
      (WebCore::RenderFlexibleBox::flowAwareBorderBefore):
      (WebCore::RenderFlexibleBox::flowAwareBorderAfter):
      (WebCore::RenderFlexibleBox::flowAwarePaddingStart):
      (WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
      (WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
      (WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
      (WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
      (WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
      (WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
      (WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
      (WebCore::RenderFlexibleBox::setFlowAwareLogicalLocationForChild):
      (WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
      (WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
      (WebCore::RenderFlexibleBox::marginStartStyleForChild):
      (WebCore::RenderFlexibleBox::marginEndStyleForChild):
      (WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
      (WebCore::RenderFlexibleBox::layoutInlineDirection):
      (WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
      (WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
      (WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
      (WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
      (WebCore::RenderFlexibleBox::setLogicalOverrideSize):
      (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
      * rendering/RenderFlexibleBox.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3b8170b
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=68719 · 1fb7d582
      hyatt@apple.com authored
              
      Push through multiple regions when an object doesn't fit in any of them. Unlike with pages and
      columns, when regions have a non-uniform height, we may need to push through multiple regions
      in order to find one that fits.
              
      Added an optimization for quickly noticing if regions do have a uniform height so that we can
      treat them like columns and pages if so.
      
      Also fixed the end line matchup to properly null out endLine when no next line box exists. The new
      layout tests I wrote to cover this feature exposed this crasher, so fixing it in order to land
      the new tests.
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Added new tests in fast/regions.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::adjustForUnsplittableChild):
      (WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
      (WebCore::RenderBlock::adjustLinePositionForPagination):
      * rendering/RenderBlock.h:
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::matchedEndLine):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::RenderFlowThread):
      (WebCore::RenderFlowThread::layout):
      * rendering/RenderFlowThread.h:
      
      LayoutTests: 
      
      * fast/regions/webkit-flow-float-pushed-to-last-region.html: Added.
      * fast/regions/webkit-flow-float-unable-to-push.html: Added.
      * platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
      * platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
      * platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
      * platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fb7d582
    • jchaffraix@webkit.org's avatar
      Redrawing dirty parts of a large table is very slow · 38e74af0
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64546
      
      Patch by Konstantin Scheglov <scheglov@google.com> on 2011-09-23
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Move CollapsedBorderValues into RenderTable.h.
      Calculate collapsed borders only once and re-use during paintObject().
      Invalidate cache when cell, row, row group, col, col group or table border is changed.
      
      Tests: fast/table/border-collapsing/cached-cell-append.html
             fast/table/border-collapsing/cached-cell-remove.html
             fast/table/border-collapsing/cached-change-cell-border-color.html
             fast/table/border-collapsing/cached-change-cell-border-width.html
             fast/table/border-collapsing/cached-change-col-border-color.html
             fast/table/border-collapsing/cached-change-col-border-width.html
             fast/table/border-collapsing/cached-change-colgroup-border-color.html
             fast/table/border-collapsing/cached-change-colgroup-border-width.html
             fast/table/border-collapsing/cached-change-row-border-color.html
             fast/table/border-collapsing/cached-change-row-border-width.html
             fast/table/border-collapsing/cached-change-table-border-color.html
             fast/table/border-collapsing/cached-change-table-border-width.html
             fast/table/border-collapsing/cached-change-tbody-border-color.html
             fast/table/border-collapsing/cached-change-tbody-border-width.html
      
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::RenderTable):
      (WebCore::RenderTable::styleDidChange): Invalidate cache on border change.
      (WebCore::RenderTable::layout): Invalidate cache if layout changed.
      (WebCore::RenderTable::recalcCollapsedBorders): Ensures that cache is valid.
      (WebCore::RenderTable::paintObject): Use cached collapsed borders.
      * rendering/RenderTable.h:
      (WebCore::RenderTable::invalidateCollapsedBorders): Accessor to mark cache invalid.
      (WebCore::RenderTable::currentBorderValue): Rename to use word "value".
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::styleDidChange): If border changed, invalidate cache.
      
      Rename to use word "value".
      (WebCore::addBorderStyle):
      (WebCore::RenderTableCell::collectBorderValues):
      (WebCore::compareBorderValuesForQSort):
      (WebCore::RenderTableCell::sortBorderValues):
      (WebCore::RenderTableCell::paintCollapsedBorder):
      * rendering/RenderTableCell.h:
      
      If border changed, invalidate cache.
      * rendering/RenderTableCol.cpp:
      (WebCore::RenderTableCol::styleDidChange):
      * rendering/RenderTableCol.h:
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::styleDidChange):
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::styleDidChange):
      
      LayoutTests:
      
      Tests for invalidating collapsed borders cache.
      
      * fast/table/border-collapsing/cached-cell-append-expected.png: Added.
      * fast/table/border-collapsing/cached-cell-append-expected.txt: Added.
      * fast/table/border-collapsing/cached-cell-append.html: Added.
      * fast/table/border-collapsing/cached-cell-remove-expected.png: Added.
      * fast/table/border-collapsing/cached-cell-remove-expected.txt: Added.
      * fast/table/border-collapsing/cached-cell-remove.html: Added.
      * fast/table/border-collapsing/cached-change-cell-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-cell-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-cell-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-cell-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-col-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-col-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-col-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-col-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-col-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-col-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-row-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-row-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-row-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-row-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-table-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-table-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-table-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-table-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-width.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38e74af0
    • mhahnenberg@apple.com's avatar
      Add static version of JSCell::visitChildren · 982c9ea2
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68404
      
      Reviewed by Darin Adler.
      
      .: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * Source/autotools/symbols.filter:
      
      Source/JavaScriptCore: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * API/JSCallbackObject.h:
      (JSC::JSCallbackObject::visitChildrenVirtual):
      (JSC::JSCallbackObject::visitChildren):
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * debugger/DebuggerActivation.cpp:
      (JSC::DebuggerActivation::visitChildrenVirtual):
      (JSC::DebuggerActivation::visitChildren):
      * debugger/DebuggerActivation.h:
      * heap/MarkStack.cpp:
      (JSC::SlotVisitor::visitChildren):
      (JSC::SlotVisitor::drain):
      * runtime/Arguments.cpp:
      (JSC::Arguments::visitChildrenVirtual):
      (JSC::Arguments::visitChildren):
      * runtime/Arguments.h:
      * runtime/Executable.cpp:
      (JSC::EvalExecutable::visitChildrenVirtual):
      (JSC::EvalExecutable::visitChildren):
      (JSC::ProgramExecutable::visitChildrenVirtual):
      (JSC::ProgramExecutable::visitChildren):
      (JSC::FunctionExecutable::visitChildrenVirtual):
      (JSC::FunctionExecutable::visitChildren):
      * runtime/Executable.h:
      * runtime/GetterSetter.cpp:
      (JSC::GetterSetter::visitChildrenVirtual):
      (JSC::GetterSetter::visitChildren):
      * runtime/GetterSetter.h:
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::visitChildrenVirtual):
      (JSC::JSActivation::visitChildren):
      * runtime/JSActivation.h:
      * runtime/JSArray.cpp:
      (JSC::JSArray::visitChildrenVirtual):
      (JSC::JSArray::visitChildren):
      * runtime/JSArray.h:
      * runtime/JSBoundFunction.cpp:
      (JSC::JSBoundFunction::visitChildrenVirtual):
      (JSC::JSBoundFunction::visitChildren):
      * runtime/JSBoundFunction.h:
      * runtime/JSCell.h:
      (JSC::JSCell::visitChildrenVirtual):
      (JSC::JSCell::visitChildren):
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::visitChildrenVirtual):
      (JSC::JSFunction::visitChildren):
      * runtime/JSFunction.h:
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::visitChildrenVirtual):
      (JSC::JSGlobalObject::visitChildren):
      * runtime/JSGlobalObject.h:
      * runtime/JSObject.cpp:
      (JSC::JSObject::visitChildrenVirtual):
      (JSC::JSObject::visitChildren):
      * runtime/JSObject.h:
      (JSC::JSObject::visitChildrenDirect):
      * runtime/JSPropertyNameIterator.cpp:
      (JSC::JSPropertyNameIterator::visitChildrenVirtual):
      (JSC::JSPropertyNameIterator::visitChildren):
      * runtime/JSPropertyNameIterator.h:
      * runtime/JSStaticScopeObject.cpp:
      (JSC::JSStaticScopeObject::visitChildrenVirtual):
      (JSC::JSStaticScopeObject::visitChildren):
      * runtime/JSStaticScopeObject.h:
      * runtime/JSWrapperObject.cpp:
      (JSC::JSWrapperObject::visitChildrenVirtual):
      (JSC::JSWrapperObject::visitChildren):
      * runtime/JSWrapperObject.h:
      * runtime/NativeErrorConstructor.cpp:
      (JSC::NativeErrorConstructor::visitChildrenVirtual):
      (JSC::NativeErrorConstructor::visitChildren):
      * runtime/NativeErrorConstructor.h:
      * runtime/RegExpObject.cpp:
      (JSC::RegExpObject::visitChildrenVirtual):
      (JSC::RegExpObject::visitChildren):
      * runtime/RegExpObject.h:
      * runtime/ScopeChain.cpp:
      (JSC::ScopeChainNode::visitChildrenVirtual):
      (JSC::ScopeChainNode::visitChildren):
      * runtime/ScopeChain.h:
      * runtime/Structure.cpp:
      (JSC::Structure::visitChildrenVirtual):
      (JSC::Structure::visitChildren):
      * runtime/Structure.h:
      * runtime/StructureChain.cpp:
      (JSC::StructureChain::visitChildrenVirtual):
      (JSC::StructureChain::visitChildren):
      * runtime/StructureChain.h:
      
      Source/JavaScriptGlue: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * UserObjectImp.cpp:
      (UserObjectImp::visitChildrenVirtual):
      (UserObjectImp::visitChildren):
      * UserObjectImp.h:
      
      Source/WebCore: 
      
      No new tests.
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * WebCore.exp.in:
      * bindings/js/JSAttrCustom.cpp:
      (WebCore::JSAttr::visitChildrenVirtual):
      (WebCore::JSAttr::visitChildren):
      * bindings/js/JSAudioContextCustom.cpp:
      (WebCore::JSAudioContext::visitChildrenVirtual):
      (WebCore::JSAudioContext::visitChildren):
      * bindings/js/JSCSSRuleCustom.cpp:
      (WebCore::JSCSSRule::visitChildrenVirtual):
      (WebCore::JSCSSRule::visitChildren):
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      (WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
      (WebCore::JSCSSStyleDeclaration::visitChildren):
      * bindings/js/JSCanvasRenderingContextCustom.cpp:
      (WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
      (WebCore::JSCanvasRenderingContext::visitChildren):
      * bindings/js/JSDOMGlobalObject.cpp:
      (WebCore::JSDOMGlobalObject::visitChildrenVirtual):
      (WebCore::JSDOMGlobalObject::visitChildren):
      * bindings/js/JSDOMGlobalObject.h:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::visitChildrenVirtual):
      (WebCore::JSDOMWindow::visitChildren):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::visitChildrenVirtual):
      (WebCore::JSDOMWindowShell::visitChildren):
      * bindings/js/JSDOMWindowShell.h:
      * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
      (WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
      (WebCore::JSJavaScriptAudioNode::visitChildren):
      * bindings/js/JSMessageChannelCustom.cpp:
      (WebCore::JSMessageChannel::visitChildrenVirtual):
      (WebCore::JSMessageChannel::visitChildren):
      * bindings/js/JSMessagePortCustom.cpp:
      (WebCore::JSMessagePort::visitChildrenVirtual):
      (WebCore::JSMessagePort::visitChildren):
      * bindings/js/JSNamedNodeMapCustom.cpp:
      (WebCore::JSNamedNodeMap::visitChildrenVirtual):
      (WebCore::JSNamedNodeMap::visitChildren):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::JSNode::visitChildrenVirtual):
      (WebCore::JSNode::visitChildren):
      * bindings/js/JSNodeFilterCustom.cpp:
      (WebCore::JSNodeFilter::visitChildrenVirtual):
      (WebCore::JSNodeFilter::visitChildren):
      * bindings/js/JSNodeIteratorCustom.cpp:
      (WebCore::JSNodeIterator::visitChildrenVirtual):
      (WebCore::JSNodeIterator::visitChildren):
      * bindings/js/JSSVGElementInstanceCustom.cpp:
      (WebCore::JSSVGElementInstance::visitChildrenVirtual):
      (WebCore::JSSVGElementInstance::visitChildren):
      * bindings/js/JSSharedWorkerCustom.cpp:
      (WebCore::JSSharedWorker::visitChildrenVirtual):
      (WebCore::JSSharedWorker::visitChildren):
      * bindings/js/JSStyleSheetCustom.cpp:
      (WebCore::JSStyleSheet::visitChildrenVirtual):
      (WebCore::JSStyleSheet::visitChildren):
      * bindings/js/JSTreeWalkerCustom.cpp:
      (WebCore::JSTreeWalker::visitChildrenVirtual):
      (WebCore::JSTreeWalker::visitChildren):
      * bindings/js/JSWebGLRenderingContextCustom.cpp:
      (WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
      (WebCore::JSWebGLRenderingContext::visitChildren):
      * bindings/js/JSWorkerContextCustom.cpp:
      (WebCore::JSWorkerContext::visitChildrenVirtual):
      (WebCore::JSWorkerContext::visitChildren):
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::JSXMLHttpRequest::visitChildrenVirtual):
      (WebCore::JSXMLHttpRequest::visitChildren):
      * bindings/js/JSXPathResultCustom.cpp:
      (WebCore::JSXPathResult::visitChildrenVirtual):
      (WebCore::JSXPathResult::visitChildren):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::JSTestObj::visitChildrenVirtual):
      (WebCore::JSTestObj::visitChildren):
      * bindings/scripts/test/JS/JSTestObj.h:
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
      (JSC::Bindings::QtRuntimeObject::visitChildren):
      * bridge/qt/qt_runtime.cpp:
      (JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
      (JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
      * bridge/qt/qt_runtime.h:
      * workers/WorkerContext.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      982c9ea2
    • mario@webkit.org's avatar
      [GTK] Remove extra space at the beginning of the last line. · 2f92fa4a
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68710
      
      Reviewed by Gustavo Noronha Silva.
      
      * platform/network/soup/SocketStreamHandleSoup.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f92fa4a
    • mario@webkit.org's avatar
      2011-09-23 Mario Sanchez Prada <msanchez@igalia.com> · 788e91d8
      mario@webkit.org authored
              [GTK] Fix coding style issues in ResourceRequestSoup.cpp
              https://bugs.webkit.org/show_bug.cgi?id=68707
      
              Reviewed by Xan Lopez.
      
              This patch fixes some issues as reported by check-webkit-style.
      
              * platform/network/soup/ResourceRequestSoup.cpp:
              (WebCore::ResourceRequest::updateFromSoupMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      788e91d8
    • ademar.reis@openbossa.org's avatar
      Unreviewed: [Qt] Workaround MSVC2010 problems when linking QtWebKit · 27450a40
      ademar.reis@openbossa.org authored
      Include MSVC2010 in the list of compilers where incremental
      build is disabled (INCREMENTAL:NO).
      
      Change suggested by Simo Falt <simo.falt@nokia.com>, already present
      in the Qt-4.8 repository where the problem was identified.
      
      * WebCore.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27450a40
    • darin@apple.com's avatar
      Try to fix warning seen in some 32-bit builds. · cd6ab6a4
      darin@apple.com authored
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::backgroundRectAdjustedForBleedAvoidance):
      Use an explicit cast for the conversion from a double to a LayoutUnit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd6ab6a4
    • vsevik@chromium.org's avatar
      Web Inspector: Clicking on error doesn't point on the correct line if user searched something · 1d437fed
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68627
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/front-end/SearchController.js:
      (WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):
      * inspector/front-end/inspector.js:
      (WebInspector._showAnchorLocationInPanel):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d437fed
    • vsevik@chromium.org's avatar
      Web Inspector: InspectorStyleSheet should use stylesheet's original url, not final one. · d73fec12
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68631
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Test: http/tests/inspector/styles/styles-redirected-css.html
      
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::resourceStyleSheetText):
      
      LayoutTests:
      
      * http/tests/inspector/elements-test.js:
      (initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem):
      (initialize_ElementTest.InspectorTest.getMatchedStylePropertyTreeItem):
      (initialize_ElementTest.InspectorTest.getFirstPropertyTreeItemForSection):
      * http/tests/inspector/styles/resources/styles-redirected-css.css: Added.
      (div):
      * http/tests/inspector/styles/resources/styles-redirected-css.php: Added.
      * http/tests/inspector/styles/styles-redirected-css-expected.txt: Added.
      * http/tests/inspector/styles/styles-redirected-css.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d73fec12
    • vsevik@chromium.org's avatar
      Web Inspector: XHRs requests with the same url as main resource should have correct category. · f915e783
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68646
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Test: http/tests/inspector/network/network-xhr-same-url-as-main-resource.html
      
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didReceiveResponse):
      
      LayoutTests:
      
      * http/tests/inspector/network/network-xhr-same-url-as-main-resource-expected.txt: Added.
      * http/tests/inspector/network/network-xhr-same-url-as-main-resource.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f915e783
    • vsevik@chromium.org's avatar
      Web Inspector: Add context menu action to navigate from resources panel resource to network panel. · 21504e64
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68657
      
      Reviewed by Yury Semikhatsky.
      
      * English.lproj/localizedStrings.js:
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkPanel.prototype.showAnchorLocation):
      (WebInspector.NetworkPanel.prototype.revealAndHighlightResource):
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
      (WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):
      * inspector/front-end/inspector.js:
      (WebInspector.openInNetworkPanelLabel):
      (WebInspector.openRequestInNetworkPanel):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21504e64
    • commit-queue@webkit.org's avatar
      [Gtk] Title attribute is not respected on option elements. · 2a36a479
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68615
      
      Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-23
      Reviewed by Martin Robinson.
      
      Set tooltip on PopupMenuGtk items created from GtkActions.
      
      * platform/gtk/GtkPopupMenu.cpp:
      (WebCore::GtkPopupMenu::appendItem): Added a call to gtk_widget_set_tooltip_text()
          to set the tooltip on menuitem. Tooltip text is retrieved from GtkAction.
      * platform/gtk/PopupMenuGtk.cpp:
      (WebCore::PopupMenuGtk::createGtkActionForMenuItem): Pass the tooltip text
          from client when creating a GtkAction.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a36a479
    • yael.aharon@nokia.com's avatar
      [Qt][Gtk] Wrong state when pausing a video in the "playing" event handler · 01f5bb70
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68589
      
      Reviewed by Philippe Normand.
      
      Source/WebCore:
      
      Test: media/video-playing-and-pause.html
      
      As suggested by Alexis Menard on IRC, query gstreamer's state instead of using a cached value
      in MediaPlayerGstreamerPrivate::paused().
      
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::MediaPlayerPrivateGStreamer::paused):
      
      LayoutTests:
      
      * media/video-playing-and-pause.html: Added.
      * media/video-paint-test.js:
      * platform/qt/media/video-playing-and-pause-expected.txt: Added.
      * platform/qt/media/video-playing-and-pause-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01f5bb70
    • podivilov@chromium.org's avatar
      Web Inspector: skip overlapping scripts when displaying concatenated content. · d40176bb
      podivilov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68144
      
      Source/WebCore:
      
      Dynamically appended script tags have wrong offsets and cause troubles building concatenated content.
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/SourceFile.js:
      (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
      (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
      
      LayoutTests:
      
      Reviewed by Pavel Feldman.
      
      * inspector/debugger/content-providers-expected.txt:
      * inspector/debugger/content-providers.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d40176bb
    • loislo@chromium.org's avatar
      Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel. · 49cb35ce
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68312
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel.prototype._createFileSelector):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49cb35ce
    • loislo@chromium.org's avatar
      Unreviewed, rolling out r95383. · 9805a63d
      loislo@chromium.org authored
      http://trac.webkit.org/changeset/95383
      https://bugs.webkit.org/show_bug.cgi?id=68690
      
      It broke WebInspector.Timeline.LoadFromFile feature.
      (Requested by loislo on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-23
      
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel.prototype._createFileSelector):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9805a63d
    • commit-queue@webkit.org's avatar
      use after free in WebCore::SVGTRefElement::updateReferencedText · 33937746
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67555
      
      Patch by Rob Buis <rbuis@rim.com> on 2011-09-23
      Reviewed by Nikolas Zimmermann.
      
      Source/WebCore:
      
      Event listeners can outlive the tref element that created them when
      the tref is cloned and then garbage collected, causing a dangling pointer to the
      tref. To fix this do not install event listener until the tref is inserted into the document.
      
      Test: svg/custom/tref-clone-crash.html
      
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::svgAttributeChanged):
      (WebCore::SVGTRefElement::insertedIntoDocument):
      * svg/SVGTRefElement.h:
      
      LayoutTests:
      
      Test that cloned tref does not cause a crash.
      
      * svg/custom/tref-clone-crash-expected.txt: Added.
      * svg/custom/tref-clone-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33937746
    • vsevik@chromium.org's avatar
      ASSERTION FAILED: documentLoader in... · 29510e29
      vsevik@chromium.org authored
      ASSERTION FAILED: documentLoader in WebKit/Source/WebCore/inspector/InspectorInstrumentation.cpp(597)
      https://bugs.webkit.org/show_bug.cgi?id=68291
      
      Reviewed by Tony Chang.
      
      * dom/Document.cpp:
      (WebCore::Document::finishedParsing):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
      (WebCore::InspectorInstrumentation::loadEventFiredImpl):
      * inspector/InspectorInstrumentation.h:
      (WebCore::InspectorInstrumentation::domContentLoadedEventFired):
      (WebCore::InspectorInstrumentation::loadEventFired):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchLoadEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29510e29
  2. 22 Sep, 2011 9 commits
    • tony@chromium.org's avatar
      implement -webkit-flex-order · a61f407d
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67432
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      flex-order can be an int (including negative), but we disallow the two
      smallest values so we can put the numbers into a hash set.
      
      Also, create two iterators: one that goes in render tree order (we use
      this for the first pass and to collect the possible flex order values)
      and one that goes in flex order.
      
      Test: css3/flexbox/flex-order.html
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::FlexOrderHashTraits::emptyValue):
      (WebCore::FlexOrderHashTraits::constructDeletedValue):
      (WebCore::FlexOrderHashTraits::isDeletedValue):
      (WebCore::RenderFlexibleBox::TreeOrderIterator::TreeOrderIterator): A simple iterator
          that goes in render tree order.
      (WebCore::RenderFlexibleBox::TreeOrderIterator::next):
      (WebCore::RenderFlexibleBox::TreeOrderIterator::reset):
      (WebCore::RenderFlexibleBox::TreeOrderIterator::flexOrderValues):
      (WebCore::RenderFlexibleBox::FlexOrderIterator::FlexOrderIterator): An iterator that
          goes in flex-order order.  Creating this involves sorting, so only create it once
          and pass it around.
      (WebCore::RenderFlexibleBox::FlexOrderIterator::first):
      (WebCore::RenderFlexibleBox::FlexOrderIterator::next):
      (WebCore::RenderFlexibleBox::FlexOrderIterator::reset):
      (WebCore::RenderFlexibleBox::layoutHorizontalBlock):
      (WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
      (WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
      (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
      * rendering/RenderFlexibleBox.h:
      
      LayoutTests:
      
      * css3/flexbox/flex-order-expected.png: Added.
      * css3/flexbox/flex-order-expected.txt: Added.
      * css3/flexbox/flex-order.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a61f407d
    • darin@apple.com's avatar
      Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius · 52da3ae5
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68667
      
      Reviewed by Simon Fraser.
      
      * platform/graphics/ShadowBlur.cpp:
      (WebCore::ShadowBlur::adjustBlurRadius): Use AffineTransform::xScale and
      AffineTransform::yScale instead of the custom code here that seems to do
      the same thing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52da3ae5
    • darin@apple.com's avatar
      Remove unneeded type conversion from background bleed code · ea860745
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68669
      
      Reviewed by Geoffrey Garen.
      
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::backgroundRectAdjustedForBleedAvoidance): Use ceil instead of ceilf
      and eliminate superflous conversion to float and use of FloatSize. Also added
      a "why" comment.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea860745
    • darin@apple.com's avatar
      Refactor checks for antialiasing lines to share a single function · afab5aa7
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68666
      
      Reviewed by Dan Bernstein.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::paintColumnRules): Call shouldAntialiasLines.
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintBorder): Ditto.
      (WebCore::RenderBoxModelObject::shouldAntialiasLines): Added.
      * rendering/RenderBoxModelObject.h: Added shouldAntialiasLines function.
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::paintOutlineForLine): Call shouldAntialiasLines.
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::paintCollapsedBorder): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afab5aa7
    • commit-queue@webkit.org's avatar
      Remove unused members from LayerChromium. · 706fc863
      commit-queue@webkit.org authored
      These members are never set, and never used.
      Other members that are set but not used have been left (we may use them
      later, e.g. m_opaque).
      https://bugs.webkit.org/show_bug.cgi?id=68297
      
      Patch by Antoine Labour <piman@chromium.org> on 2011-09-22
      Reviewed by James Robinson.
      
      No functional change, no new test needed.
      
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::LayerChromium):
      * platform/graphics/chromium/LayerChromium.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      706fc863
    • commit-queue@webkit.org's avatar
      Make XSSAuditor extract meaningful snippet from script blocks for comparison · 2e3b7d95
      commit-queue@webkit.org authored
      against the URL when checking for reflection.  Avoids getting caugh up in
      trailing comments.
      https://bugs.webkit.org/show_bug.cgi?id=68094
      
      Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-22
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Tests: http/tests/security/xssAuditor/script-tag-with-trailing-comment.html
             http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html
             http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html
      
      * html/parser/XSSAuditor.cpp:
      (WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
      (WebCore::XSSAuditor::extractCodeFragment):
      * html/parser/XSSAuditor.h:
      
      LayoutTests:
      
      * http/tests/security/xssAuditor/resources/echo-intertag.pl:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt: Added.
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment.html: Added.
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt: Added.
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html: Added.
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt: Added.
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e3b7d95
    • japhet@chromium.org's avatar
      Remove didReceiveAuthenticationChallenge() from SubresourceLoaderClient. · bd78d969
      japhet@chromium.org authored
      Instead, add a load-specific policy for showing the user authentication
      challenge down to ResourceLoaderOptions and enforce it in ResourceLoader.
      https://bugs.webkit.org/show_bug.cgi?id=65330
      
      Reviewed by Alexey Proskuryakov.
      
      No new tests, refactor only.
      
      * loader/DocumentThreadableLoader.cpp:
      * loader/DocumentThreadableLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/NetscapePlugInStreamLoader.cpp:
      * loader/ResourceLoadScheduler.h:
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
         For resource types that always send a challenge to the embedder,
         this patch doesn't change anything. For those that don't, we will
         always try to continue without credentials when they are forbidden
         and the platform supports it.
         When continuing without credentials was initially implemented in
         DocumentThreadableLoader, we sent the ThreadableLoaderClient a didFail(),
         then canceled the SubresourceLoader. This was necessary because of the
         quirks of ThreadableLoader cancellation (we sever the client/loader connections
         before the load actually cancels), but a simple didFail() should suffice at
         the ResourceLoader layer.
      * loader/ResourceLoaderOptions.h:
      * loader/SubresourceLoader.cpp:
      * loader/SubresourceLoader.h:
      * loader/SubresourceLoaderClient.h:
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedResourceLoader.cpp:
      * loader/cache/CachedResourceLoader.h:
      * loader/icon/IconLoader.cpp: The ResourceLoader implementation of
          didReceiveAuthenticationChallege means that IconLoader will now
          try to continue with credentials on platforms that support it,
          rather than just canceling outright. We still will never prompt
          for authentication for icons.
      * loader/icon/IconLoader.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd78d969
    • dino@apple.com's avatar
      Add ENABLE_CSS_FILTERS · fffa7502
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68652
      
      Reviewed by Simon Fraser.
      
      * Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:
      * Source/WebCore/Configurations/FeatureDefines.xcconfig:
      * Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:
      * Source/WebKit2/Configurations/FeatureDefines.xcconfig:
      * WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:
      * WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:
      * Tools/Scripts/build-webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fffa7502
    • andersca@apple.com's avatar
      Make sure to update scrollbars in ScrollView::setFrameRect · 8631d3d0
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68663
      
      Reviewed by Sam Weinig.
      
      Call updateScrollbars after setting the frame rect. This was previously done by the
      call to setBoundsSize from RenderWidget::setWidgetGeometry but setBoundsSize was removed
      completely in http://trac.webkit.org/changeset/95725.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::setFrameRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8631d3d0