GitLab

https://bugs.webkit.org/show_bug.cgi?id=115718

Reviewed by Martin Robinson.

.: 

* Source/autotools/FindDependencies.m4: Check for the upower-glib dependency if the feature is enabled.
* Source/autotools/PrintBuildConfiguration.m4: Print out the feature status.
* Source/autotools/ReadCommandLineArguments.m4: Check for the --enable-battery-status option. The deafult,
when the option is not given, is to disable the feature.
* Source/autotools/SetupWebKitFeatures.m4: Treat the ENABLE_BATTERY_STATUS define as configurable.
* Source/autotools/symbols.filter: Export a couple of symbols that are used in the WebCore internals library.

Source/WebCore: 

No new tests - no new functionality. The feature is not enabled yet, though all the relevant tests
pass when it is.

* GNUmakefile.am: Add the Modules/battery directory to the list of search paths for header inclusions.
Include the same directory under the IDL_PATH variable so the IDL files it contains are processed.
List these IDL files using a wildcard under the EXTRA_DIST list.
* GNUmakefile.list.am: Add the build targets for the module source files, IDLs and resulting JS bindings.
* bindings/gobject/GNUmakefile.am: Add the build targets for the GObject DOM bindings.

Tools: 

* Scripts/webkitdirs.pm:
(buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
through the --(enable|disable)-battery-status flag passed to configure.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115724

Reviewed by Ryosuke Niwa.

Update fast/js/global-constructors-attributes.html so that it lists all
global constructors instead of just a few.

* fast/js/global-constructors-attributes-expected.txt:
* fast/js/script-tests/global-constructors-attributes.js:
(classNameForObject):
(constructorPropertiesOnWindow):
* platform/efl/fast/js/global-constructors-attributes-expected.txt: Added.
* platform/gtk/fast/js/global-constructors-attributes-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115816

Reviewed by Joseph Pecoraro.

Fix the bug by instantiating the correct port object.

* Scripts/new-run-webkit-websocketserver:
(main):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

These tests should use testRunner, not layoutTestController.

* fast/js/parse-error-external-script-in-eval.html:
* fast/js/parse-error-external-script-in-new-Function.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115776

Reviewed by Anders Carlsson.

Source/WebCore:

I changed depth to more closely match what is in the CSS3 specification.
There may be a more optimal way to make it work, but this seems the most straightforward.

* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::RenderQuote): Initialize m_depth to -1 because that depth
is consistent with the empty string that is the initial value of the text. The
real depth will be calculated when the node is attached.
(WebCore::RenderQuote::originalText): Removed the "depth - 1" logic that
used to be done for close quotes. Instead, the updateDepth function now correctly
subtracts one for the close quote itself, not just afterward. Also added an early
exit when the depth is negative; these changes together fix the bug.
(WebCore::RenderQuote::attachQuote): Added a call to updateDepth even for the render
quote head, we now need that to set the depth either to 0 or to -1.
(WebCore::RenderQuote::detachQuote): Removed code to set m_depth to 0;  if we are not
resetting the text then m_depth should be left matching the text, otherwise updateDepth
might not do its job correctly if the quote is later re-attached. What matters is that
m_depth and the text are in sync.
(WebCore::RenderQuote::updateDepth): Changed updating logic in two ways. First,
compute the depth in a local variable rather than computing it in a data member
after first saving off the old value of the data member. That's clearer style.
Second, add the code to change negative depths to zero when propagating to the
next quote in the chain, which matches how the standard is written, and decrement
the depth of the close quote itself, not the quote after the close quote.

LayoutTests:

* TestExpectations: Expect success again on this test.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115769
        
Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/config.json:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        <rdar://problem/13776220> 13A451: PluginProcess(2225) deny file-read-data ~/Library/InputManagers
        <rdar://problem/13642510> PluginProcess logs sandbox violations initializing TextServices

        Reviewed by Anders Carlsson.

        * Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Allow more
        TextServices and NSInputManager directories.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=106183

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/track/track-remove-crash.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removedFrom): Set m_inActiveDocument to false so we
    do not process text track cues or dispatch related events.

LayoutTests:

* media/track/track-remove-crash-expected.txt: Added.
* media/track/track-remove-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubber-stamped by Beth Dakin.

BinarySemaphoreWin has been moved to WTF, but the original was never removed.

* Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubber-stamped by Beth Dakin.

ThreadingNone.cpp is empty and not used anywhere.

* wtf/ThreadingNone.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Removed.
* platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(concatenateAttributeAndValue): Switch to appendVector().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<http://webkit.org/b/5206>

Reviewed by Eric Seidel.

These issues were likely fixed in r89257 for Bug 62613.

* fast/js/parse-error-external-script-in-eval-expected.txt: Added.
* fast/js/parse-error-external-script-in-eval.html: Added.
* fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.
Note that the line number in this result is relative to the line
number of the second argument to the new Function() method.
* fast/js/parse-error-external-script-in-new-Function.html: Added.
* fast/js/resources/parse-error-external-script-in-eval.js: Added.
* fast/js/resources/parse-error-external-script-in-new-Function.js: Added.

* platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Added.
* platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115806

Reviewed by Brent Fulgham.

This function was not used anywhere so let's get rid of it.

* wtf/HashMap.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115740

Reviewed by Dean Jackson.

Source/WebCore: 

No new tests, covered by existing tests.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_closedCaptionsVisible
    to false immediately, it will be reset to the appropriate value if necessary.
(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
* html/HTMLMediaElement.h:

* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Remove 
    HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT) requirement. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
    AVFOUNDATION_MEDIA_SELECTION_GROUP
* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Ditto.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: 
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seek): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Ditto.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:  Ditto.

* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:  Ditto.
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::kind): Don't look at media characteristics, 
    a legacy CC track is always Captions.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isClosedCaptions): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::containsOnlyForcedSubtitles): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isMainProgramContent): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isEasyToRead): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label): Use different AVFoundation API on 10.7.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): AVFOUNDATION_TEXT_TRACK_SUPPORT ->
    AVFOUNDATION_MEDIA_SELECTION_GROUP.
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
    AVFOUNDATION_MEDIA_SELECTION_GROUP.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Support legacy CC tracks
    only on 10.8. AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): AVFOUNDATION_TEXT_TRACK_SUPPORT -> 
    AVFOUNDATION_MEDIA_SELECTION_GROUP

Source/WTF: 

* wtf/Platform.h: AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP

LayoutTests: 

* platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115802

Reviewed by Darin Adler.

Source/WebCore:

Test: css3/css-variable-definition.html

Modified the grammar to allow blank spaces before the colon on CSS
variable definitions.

* css/CSSGrammar.y.in:

LayoutTests:

New test to check that spaces are allowed before the color on CSS
variable definitions.

* css3/css-variable-definition-expected.html: Added.
* css3/css-variable-definition.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115799

Reviewed by Darin Adler.

HashTraits<RefPtr<P> >::peek() should consider passing of empty value which is
raw pointer equal to '0', and return it right away instead of converting it to RefPtr
and invoking get().

* wtf/HashTraits.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115733

Reviewed by Darin Adler.

Before the change both WTF::GenericHashTraits::passOut and WTF::GenericHashTraits::passOut
used to return the given argument always by value and that caused implicit extra
copying of the argument. It was OK as long as argument type T was POD, as compiler
could optimize it, but in case T was a class having non-trivial copy constructor the
extra copying of the argument could not have been obviated.

The proposed solution is to provide overloaded functions that accept non-temporary
values and return them by reference thus avoiding extra copying.

The proposed solution made an impact on the size of libjavascriptcore_efl.so (EFL
release build): the size decreased from 6554992 bytes to 6554560 bytes.

* wtf/HashTraits.h:
(WTF::GenericHashTraits::passOut):
(WTF::GenericHashTraits::peek):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115372

* platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: Added.
* platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: Added.
* platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: Added.
* platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/layer-full-repaint-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/reflection-table-layout-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-absolute-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-fixed-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/transform-table-layout-expected.txt: Added.
* platform/qt-5.0-wk2/svg/repaint/repaint-webkit-svg-shadow-container-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115791

Unreviewed EFL gardening

Skip fast/regions/ test cases which are failing after r149668.

Patch by Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> on 2013-05-08

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115754

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-08
Reviewed by Philippe Normand.

Covered by existing tests.

Revision 148840 fixed on-disk buffering being done when preload is set to none,
but memory buffering is still being done. That is because setting the state to
paused causes GStreamer to start loading the media, to gather information. Only
doing that when committing the load avoids that while maintaining the tested
behaviour unchanged.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

From Blink r149888 by <cevans@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149888>

* svg/SVGStyledElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115794

Reviewed by Jocelyn Turcotte.

Do not access a null pointer frame.

* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115785

* platform/qt/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed build fix.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unskip two spelling tests as they started passing after r149366.

* platform/efl-wk2/TestExpectations:
Unskip spelling-exactly-selected-word.html and
spelling-with-punctuation-selection.html

* platform/efl/TestExpectations:
Remove spelling tests from efl/TestExpectations as the failing tests
are already skipped for both efl-wk1 and global wk2.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115788

Reviewed by Kentaro Hara.

Remove [TransferList] extended attribute and corresponding tests as it has no
effect on the generated JSC bindings.

No new tests, no behavior change.

* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
* bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
* bindings/scripts/test/CPP/WebDOMTestTypedefs.h:
(WebDOMTestTypedefs):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterfacePrototype):
(JSTestSerializedScriptValueInterfaceConstructor):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore):
* bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
* bindings/scripts/test/ObjC/DOMTestTypedefs.h:
* bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
* bindings/scripts/test/TestSerializedScriptValueInterface.idl:
* bindings/scripts/test/TestTypedefs.idl:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

to the watchlist for Accessibility.

* Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
* Scripts/webkitpy/common/config/watchlist: Added myself.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Skip remaining Shadow DOM tests on the EFL port.

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115741

Reviewed by Benjamin Poulain.

Since r149112 std::move is used in AtomicString for compilers that
support rvalue references and this requires a standard library
implementing c++11 move semantics.
We only explicitely require c++11 for WebKit2, but since clang supports
rvalue references the build of subtargets using AtomicString fails because
of missing std::move.
It is safe to add CONFIG += c++11 for the whole project when using clang
since we explicitely disable c++11 for ANGLE that had probems with libc++.

* qmake/mkspecs/features/unix/default_pre.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115778

Reviewed by Benjamin Poulain.

Not sure why I missed this code last time, but found a bit more code that needs
to switch to the newer style adoptCF/NS.

* WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
(convertWebResourceDataToString): Use adoptCF.
(convertWebResourceResponseToDictionary): Ditto.
(createXMLStringFromWebArchiveData): Ditto.
* WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
(createCFURLResponseFromResponseData): Use adoptNS and adoptCF.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/gtk/TestExpectations: Adding failure expectations for CSS Regions tests
that regressed when converted into reftests in r149668.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115723

Patch by Dongseong Hwang <dongseong.hwang@intel.com> on 2013-05-08
Reviewed by Dean Jackson.

Source/WebCore:

WebKit r98985 set many arguments optional although the canvas spec[1] does not
indicate. So this patch corrects CanvasRenderingContext2D.idl to match the spec.

[1] http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/

Covered by existing tests:
  canvas/philip/tests/2d.missingargs.html
  fast/canvas/canvas-overloads-strokeRect.html
  inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html

* html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

When tests use <canvas> API with not enough arguments, TypeError
exception is fired now. So three tests are changed to match the canvas
spec.

* fast/canvas/canvas-overloads-strokeRect-expected.txt:
* fast/canvas/script-tests/canvas-overloads-strokeRect.js:
* platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/149271
https://bugs.webkit.org/show_bug.cgi?id=115780

The mangled symbols are now enforced through LDFLAGS
(Requested by zdobersek on #webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-05-08

* BuildSlaveSupport/gtk/daemontools-buildbot.conf:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115636

Reviewed by Ryosuke Niwa.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
while Chromium-specific, can't be removed just yet as there's more code that uses it.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115716

Reviewed by Andreas Kling.

WebNetworkInfoManager should inherit from WebProcessSupplement and should be used
as such by the WebProcess. This removes the need for the m_networkInfoManager member
variable in the WebProcess class and brings the WebNetworkInfoManager in line with
other manager classes of which instances are controlled by the WebProcess class.

* WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:
(WebKit::WebNetworkInfoManager::supplementName): Specify the supplement's name.
(WebKit):
* WebProcess/NetworkInfo/WebNetworkInfoManager.h:
(WebKit): Alphabetically reorder the two forwarding declarations.
(WebNetworkInfoManager): Inherit from the WebProcessSupplement interface.
* WebProcess/WebCoreSupport/WebNetworkInfoClient.cpp:
(WebKit::WebNetworkInfoClient::bandwidth): Access the WebNetworkInfoManager as a supplement.
(WebKit::WebNetworkInfoClient::metered): Ditto.
(WebKit::WebNetworkInfoClient::startUpdating): Ditto.
(WebKit::WebNetworkInfoClient::stopUpdating): Ditto.
(WebKit::WebNetworkInfoClient::networkInfoControllerDestroyed): Ditto.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Add the WebNetworkInfoManager instance as a supplement.
* WebProcess/WebProcess.h:
(WebProcess): Remove the m_networkInfoManager member variable and its getter method.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149720 268f45cc-cd09-0410-ab3c-d52691b4dbfc