1. 07 Sep, 2010 13 commits
    • kent.hansen@nokia.com's avatar
      2010-09-07 Kent Hansen <kent.hansen@nokia.com> · 8f8acc93
      kent.hansen@nokia.com authored
              Reviewed by Andreas Kling.
      
              [Qt] tst_QWebFrame::connectAndDisconnect() fails on WebKit trunk because __qt_sender__ is never set
              https://bugs.webkit.org/show_bug.cgi?id=44697
      
              When the signal handler is a JS function, __qt_sender__ is stuffed into a temporary
              object that's pushed onto the function's scope before the function is invoked, and
              popped again afterwards.
      
              We were pushing this new scope object _after_ calling JSFunction::getCallData(),
              and relying on JSC::call() to use the fresh scope chain from the function object.
              However, this is no longer the case; JSC::call() uses the scope chain passed in
              the CallData argument. Hence, we need to set up the scope before the function's
              CallData is queried.
      
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtConnectionObject::execute):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66875 268f45cc-cd09-0...
      8f8acc93
    • ossy@webkit.org's avatar
      [Qt] Add platform specific expected results for new passing tests. · b85186f8
      ossy@webkit.org authored
      Compared to Mac png files and Mac expected files.
      
      * platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.checksum: Added.
      * platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.png: Added.
      * platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
      * platform/qt/fast/forms/placeholder-stripped-expected.checksum: Added.
      * platform/qt/fast/forms/placeholder-stripped-expected.png: Added.
      * platform/qt/fast/forms/placeholder-stripped-expected.txt: Added.
      * platform/qt/fast/gradients/radial-centered-expected.checksum: Added.
      * platform/qt/fast/gradients/radial-centered-expected.png: Added.
      * platform/qt/fast/gradients/radial-centered-expected.txt: Added.
      * platform/qt/fast/multicol/float-paginate-expected.checksum: Added.
      * platform/qt/fast/multicol/float-paginate-expected.png: Added.
      * platform/qt/fast/multicol/float-paginate-expected.txt: Added.
      * platform/qt/fast/multicol/paginate-block-replaced-expected.checksum: Added.
      * platform/qt/fast/multicol/paginate-block-replaced-expected.png: Added.
      * platform/qt/fast/multicol/paginate-block-replaced-expected.txt: Added.
      * platform/qt/fast/repaint/multicol-repaint-expected.checksum: Added.
      * platform/qt/fast/repaint/multicol-repaint-expected.png: Added.
      * platform/qt/fast/repaint/multicol-repaint-expected.txt: Added.
      * platform/qt/fast/repaint/view-background-from-body-1-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-1-expected.checksum.
      * platform/qt/fast/repaint/view-background-from-body-1-expected.png: Copied from LayoutTests/platform/qt/svg/custom/use-property-synchronization-crash-expected.png.
      * platform/qt/fast/repaint/view-background-from-body-1-expected.txt: Copied from LayoutTests/platform/gtk/fast/repaint/view-background-from-body-1-expected.txt.
      * platform/qt/fast/repaint/view-background-from-body-2-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-2-expected.checksum.
      * platform/qt/fast/repaint/view-background-from-body-2-expected.png: Added.
      * platform/qt/fast/repaint/view-background-from-body-2-expected.txt: Copied from LayoutTests/platform/gtk/fast/repaint/view-background-from-body-2-expected.txt.
      * platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
      * platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
      * platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
      * platform/qt/svg/css/composite-shadow-text-expected.checksum: Added.
      * platform/qt/svg/css/composite-shadow-text-expected.png: Added.
      * platform/qt/svg/css/composite-shadow-text-expected.txt: Added.
      * platform/qt/svg/custom/bug45331-expected.checksum: Added.
      * platform/qt/svg/custom/bug45331-expected.png: Added.
      * platform/qt/svg/custom/bug45331-expected.txt: Added.
      * platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
      * platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
      * platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
      * platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
      * platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
      * platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
      * platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
      * platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
      * platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
      * platform/qt/svg/custom/marker-empty-path-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/marker-empty-path-expected.checksum.
      * platform/qt/svg/custom/marker-empty-path-expected.png: Added.
      * platform/qt/svg/custom/marker-empty-path-expected.txt: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-container-expected.png: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-root-expected.checksum: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-root-expected.png: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
      * platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
      * platform/qt/svg/custom/non-scaling-stroke-markers-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.checksum.
      * platform/qt/svg/custom/non-scaling-stroke-markers-expected.png: Added.
      * platform/qt/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
      * platform/qt/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
      * platform/qt/svg/custom/pattern-incorrect-tiling-expected.png: Added.
      * platform/qt/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
      * platform/qt/svg/custom/pattern-no-pixelation-expected.checksum: Added.
      * platform/qt/svg/custom/pattern-no-pixelation-expected.png: Added.
      * platform/qt/svg/custom/pattern-no-pixelation-expected.txt: Added.
      * platform/qt/svg/custom/use-font-face-crash-expected.checksum: Added.
      * platform/qt/svg/custom/use-font-face-crash-expected.png: Added.
      * platform/qt/svg/custom/use-font-face-crash-expected.txt: Added.
      * platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.checksum: Added.
      * platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
      * platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
      * platform/qt/transitions/svg-text-shadow-transition-expected.checksum: Added.
      * platform/qt/transitions/svg-text-shadow-transition-expected.png: Added.
      * platform/qt/transitions/svg-text-shadow-transition-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b85186f8
    • philn@webkit.org's avatar
      2010-09-07 Philippe Normand <pnormand@igalia.com> · 201ca758
      philn@webkit.org authored
              Unreviewed, build fix.
      
              webkit-patch command to find the ports covering a specific layout test
              https://bugs.webkit.org/show_bug.cgi?id=42832
      
              * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
              tests are present when building the expectations. This is needed
              for the unittests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      201ca758
    • philn@webkit.org's avatar
      2010-09-06 Philippe Normand <pnormand@igalia.com> · 43a8141e
      philn@webkit.org authored
              Reviewed by Adam Barth.
      
              webkit-patch command to find the ports covering a specific layout test
              https://bugs.webkit.org/show_bug.cgi?id=42832
      
              To use it: webkit-patch skipped-ports some/layout/test.html
      
              * Scripts/webkitpy/layout_tests/port/base.py:
              * Scripts/webkitpy/layout_tests/port/base_unittest.py:
              * Scripts/webkitpy/layout_tests/port/chromium.py:
              * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
              * Scripts/webkitpy/layout_tests/port/factory.py:
              * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
              * Scripts/webkitpy/layout_tests/port/test.py:
              * Scripts/webkitpy/layout_tests/port/webkit.py:
              * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
              * Scripts/webkitpy/tool/commands/queries.py:
              * Scripts/webkitpy/tool/commands/queries_unittest.py:
              * Scripts/webkitpy/tool/main.py:
              * Scripts/webkitpy/tool/mocktool.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43a8141e
    • tkent@chromium.org's avatar
      2010-09-07 Kent Tamura <tkent@chromium.org> · 0f75af21
      tkent@chromium.org authored
              Unreviewed, test expectation update.
      
              * platform/chromium/drt_expectations.txt: Remove a duplicated entry.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f75af21
    • commit-queue@webkit.org's avatar
      2010-09-07 Arno Renevier <arno@renevier.net> · f8734faf
      commit-queue@webkit.org authored
              Reviewed by Holger Freyther.
      
              gitignore *~ files and gtk *.pot files
              https://bugs.webkit.org/show_bug.cgi?id=45129
      
              * .gitignore:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8734faf
    • commit-queue@webkit.org's avatar
      2010-09-07 Kwang Yul Seo <skyul@company100.net> · 6fb1d39a
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Add ENABLE(INSPECTOR) guard in InspectorController::inspectorControllerForNode
              https://bugs.webkit.org/show_bug.cgi?id=45272
      
              Build fix.
      
              * inspector/InspectorController.h:
              (WebCore::InspectorController::inspectorControllerForNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fb1d39a
    • ukai@chromium.org's avatar
      Unreviewed. Build fix. · 4660b01e
      ukai@chromium.org authored
      Update test expectations for Chromium.
      
      * platform/chromium-linux/svg/custom/use-invalid-pattern-expected.txt: Added.
      * platform/chromium-mac/svg/custom/use-invalid-pattern-expected.txt: Added.
      * platform/chromium-win/svg/custom/use-invalid-pattern-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4660b01e
    • tkent@chromium.org's avatar
      2010-09-07 Kent Tamura <tkent@chromium.org> · a2da3898
      tkent@chromium.org authored
              Reviewed by Ojan Vafai.
      
              Fix wrong position calculation of fast/forms/listbox-selection.html
              https://bugs.webkit.org/show_bug.cgi?id=45285
      
              * fast/forms/script-tests/listbox-selection.js:
              (mouseDownOnSelect): Refer window.pageYOffset after sl.focus()
              call because focus() might scroll the page.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2da3898
    • tkent@chromium.org's avatar
      2010-09-07 Kent Tamura <tkent@chromium.org> · b39a2ff5
      tkent@chromium.org authored
              Unreviewed, test expectation update.
      
              Update DRT/Chromium expectations, and skip meter-percent-size.html
              for platforms without <meter> support.
      
              * platform/chromium/drt_expectations.txt:
              * platform/gtk/Skipped:
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b39a2ff5
    • commit-queue@webkit.org's avatar
      2010-09-07 Joerg Bornemann <joerg.bornemann@nokia.com> · a3551e3a
      commit-queue@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              Fix QtWebKit linker error on Windows CE 6.
              https://bugs.webkit.org/show_bug.cgi?id=43442
      
              Doesn't affect any tests.
      
              * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3551e3a
    • commit-queue@webkit.org's avatar
      2010-09-07 James Kozianski <koz@chromium.org> · 125a7b22
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Adds tests for percent-based attributes on the <meter> element.
      
              * fast/dom/HTMLMeterElement/meter-percent-size-expected.txt: Added.
              * fast/dom/HTMLMeterElement/meter-percent-size.html: Added.
      2010-09-07  James Kozianski  <koz@chromium.org>
      
              Reviewed by Kent Tamura.
      
              Crash rendering <meter/> with percent padding
              https://bugs.webkit.org/show_bug.cgi?id=45081
      
              Avoids a crash caused by RenderMeter checking its own dimensions to
              determine whether it needs layout. The crash is avoided by removing
              the check and always calling setNeedsLayout(true).
      
              Test: fast/dom/HTMLMeterElement/meter-percent-size.html
      
              * rendering/RenderIndicator.cpp:
              (WebCore::RenderIndicator::updateFromElement):
              * rendering/RenderIndicator.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      125a7b22
    • commit-queue@webkit.org's avatar
      2010-09-07 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> · a2a76702
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [NRWT] Add temp directory to all running drivers.
              https://bugs.webkit.org/show_bug.cgi?id=45261
      
              * Scripts/webkitpy/layout_tests/port/webkit.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2a76702
  2. 06 Sep, 2010 27 commits
    • abarth@webkit.org's avatar
      2010-09-06 Adam Barth <abarth@webkit.org> · eaa3d7e9
      abarth@webkit.org authored
              Reviewed by Sam Weinig.
      
              OOB read with svg polyline
              https://bugs.webkit.org/show_bug.cgi?id=45279
      
              In principle, attributeChanged can do anything.  If we supported more
              DOM mutation events, it could even run JavaScript.  That means we need
              to be prepared for the attribute map to change when running
              attributeChanged.  This patch makes this loop resilient to the
              attribute map changing by storing the list of changed attributes on the
              stack.
      
              Test: fast/parser/changing-attrbutes-crash.html
      
              * dom/Element.cpp:
              (WebCore::Element::setAttributeMap):
      2010-09-06  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              OOB read with svg polyline
              https://bugs.webkit.org/show_bug.cgi?id=45279
      
              Test what happens when SVG changes the attribute map out from under us.
      
              * fast/parser/changing-attrbutes-crash-expected.txt: Added.
              * fast/parser/changing-attrbutes-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaa3d7e9
    • dglazkov@chromium.org's avatar
      2010-09-06 Dimitri Glazkov <dglazkov@chromium.org> · 3faa4116
      dglazkov@chromium.org authored
              Reviewed by Kent Tamura.
      
              [Chromium/DRT] Empty out user stylesheet after each test run.
              https://bugs.webkit.org/show_bug.cgi?id=45282
      
              This should significantly cut down on the number of the mysterious flaky tests
              whose diffs looked like the page was blown up to a very lage size. This
              was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
              which set the base body font to 100px.
      
              Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
              the same thread failed.
      
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3faa4116
    • tkent@chromium.org's avatar
      2010-09-06 Kent Tamura <tkent@chromium.org> · f6cfb7ae
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [DRT/Chromium] Do not generate pixel results for text/plain resources
              https://bugs.webkit.org/show_bug.cgi?id=45253
      
              * platform/chromium/drt_expectations.txt: Remove slow-utf8-text.pl failure.
      2010-09-06  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              [DRT/Chromium] Do not generate pixel results for text/plain resources
              https://bugs.webkit.org/show_bug.cgi?id=45253
      
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6cfb7ae
    • ojan@chromium.org's avatar
      2010-09-06 Ojan Vafai <ojan@chromium.org> · 45ed6541
      ojan@chromium.org authored
              Reviewed by Kent Tamura.
      
              print out correct error when a DRT thread dies in NRWT
              https://bugs.webkit.org/show_bug.cgi?id=45281
      
              Not sure why, but with the parens, python 2.6.5 on Linux
              gives an error that raise takes 5 arguments and 0 were given.
              Didn't test other platforms or python versions, but putting it
              all on one line fixes it and correctly prints the exception
              from the DRT thread.
      
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45ed6541
    • eric@webkit.org's avatar
      2010-09-06 Eric Seidel <eric@webkit.org> · 951cb05c
      eric@webkit.org authored
              Unreviewed, just adding some emails from lists.webkit.org.
      
              Update committers.py to include emails from lists.webkit.org
              as found by the validate-committer-lists script.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      951cb05c
    • abarth@webkit.org's avatar
      2010-09-06 Adam Barth <abarth@webkit.org> · 1c3719bd
      abarth@webkit.org authored
              Small UI tweak to the reviewtool.  Make the Ok/Cancel buttons a bit
              bigger.
      
              * PrettyPatch/PrettyPatch.rb:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c3719bd
    • oliver@apple.com's avatar
      Windows build fix · 10a996c3
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10a996c3
    • abarth@webkit.org's avatar
      2010-09-06 Adam Barth <abarth@webkit.org> · ad2a069e
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              [reviewtool] Add a quick animation for opening/closing comment boxes
              https://bugs.webkit.org/show_bug.cgi?id=45278
      
              The 200ms animation slides in and out the line-by-line comment box.
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad2a069e
    • oliver@apple.com's avatar
      Windows build fix · 906a13cf
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      906a13cf
    • diegohcg@webkit.org's avatar
      2010-09-06 Diego Gonzalez <diegohcg@webkit.org> · c6aaea85
      diegohcg@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [Qt] Update NetworkAccessManager in Qt FrameNetworkingContext
              https://bugs.webkit.org/show_bug.cgi?id=45231
      
              Make possible to get the current QNAM when NetwokingContext request it.
      
              * WebCoreSupport/FrameNetworkingContextQt.cpp:
              (WebCore::FrameNetworkingContextQt::networkAccessManager):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6aaea85
    • oliver@apple.com's avatar
      Windows build fix · a9b4754a
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9b4754a
    • jschuh@chromium.org's avatar
      2010-09-06 Justin Schuh <jschuh@chromium.org> · 205a4802
      jschuh@chromium.org authored
              Unreviewed. Build fix.
      
              Update test expectations for Leopard.
      
              * platform/mac-leopard/svg/custom/use-invalid-pattern-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      205a4802
    • oliver@apple.com's avatar
      2010-09-05 Oliver Hunt <oliver@apple.com> · 8128fe1e
      oliver@apple.com authored
              Reviewed by Sam Weinig.
      
              SerializedScriptValue needs to use a flat storage mechanism
              https://bugs.webkit.org/show_bug.cgi?id=45244
      
              Export JSArray::put
      
              * JavaScriptCore.exp:
      2010-09-05  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Sam Weinig.
      
              SerializedScriptValue needs to use a flat storage mechanism
              https://bugs.webkit.org/show_bug.cgi?id=45244
      
              Add a few more test cases to cover the new branches in the
              rewritten serialization logic.
      
              * fast/dom/Window/window-postmessage-clone-expected.txt:
              * fast/dom/Window/window-postmessage-clone.html:
      2010-09-05  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Sam Weinig.
      
              SerializedScriptValue needs to use a flat storage mechanism
              https://bugs.webkit.org/show_bug.cgi?id=45244
      
              Rewrite the old tree to tree serialization logic to use
              flat storage.  Unfortunately this basically required a
              complete rewrite.
      
              * bindings/js/SerializedScriptValue.cpp:
              (WebCore::CloneBase::CloneBase):
              (WebCore::CloneBase::shouldTerminate):
              (WebCore::CloneBase::ticksUntilNextCheck):
              (WebCore::CloneBase::didTimeOut):
              (WebCore::CloneBase::throwStackOverflow):
              (WebCore::CloneBase::throwInterruptedException):
              (WebCore::CloneBase::fail):
              (WebCore::CloneSerializer::serialize):
              (WebCore::CloneSerializer::CloneSerializer):
              (WebCore::CloneSerializer::isArray):
              (WebCore::CloneSerializer::startObject):
              (WebCore::CloneSerializer::startArray):
              (WebCore::CloneSerializer::endObject):
              (WebCore::CloneSerializer::getSparseIndex):
              (WebCore::CloneSerializer::getProperty):
              (WebCore::CloneSerializer::dumpImmediate):
              (WebCore::CloneSerializer::dumpString):
              (WebCore::CloneSerializer::dumpIfTerminal):
              (WebCore::CloneSerializer::write):
              (WebCore::CloneSerializer::writeLittleEndian):
              (WebCore::CloneSerializer::writeStringIndex):
              (WebCore::CloneDeserializer::deserializeString):
              (WebCore::CloneDeserializer::deserialize):
              (WebCore::CloneDeserializer::CloneDeserializer):
              (WebCore::CloneDeserializer::throwValidationError):
              (WebCore::CloneDeserializer::isValid):
              (WebCore::CloneDeserializer::readLittleEndian):
              (WebCore::CloneDeserializer::read):
              (WebCore::CloneDeserializer::readStringIndex):
              (WebCore::CloneDeserializer::readString):
              (WebCore::CloneDeserializer::readStringData):
              (WebCore::CloneDeserializer::readTag):
              (WebCore::CloneDeserializer::putProperty):
              (WebCore::CloneDeserializer::readFile):
              (WebCore::CloneDeserializer::readTerminal):
              (WebCore::SerializedScriptValue::~SerializedScriptValue):
              (WebCore::SerializedScriptValue::SerializedScriptValue):
              (WebCore::SerializedScriptValue::create):
              (WebCore::SerializedScriptValue::toString):
              (WebCore::SerializedScriptValue::deserialize):
              (WebCore::SerializedScriptValue::nullValue):
              * bindings/js/SerializedScriptValue.h:
              * dom/MessagePortChannel.cpp:
              (WebCore::MessagePortChannel::EventData::EventData):
              * workers/WorkerMessagingProxy.cpp:
              (WebCore::MessageWorkerContextTask::MessageWorkerContextTask):
              (WebCore::MessageWorkerTask::MessageWorkerTask):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8128fe1e
    • abarth@webkit.org's avatar
      2010-09-06 Adam Barth <abarth@webkit.org> · 1414c99f
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              [reviewtool] Add a field for overall comments
              https://bugs.webkit.org/show_bug.cgi?id=45273
      
              This patch does a couple logically separate things that could be
              separated into smaller patches:
      
              1) This patch adds an "overall comments" field where you can enter
                 overall comments about the patch.  These comments appear at the top
                 of the bugzilla posting.  Currently, these aren't redisplayed when
                 viewing the patch, but I plan to add that in a future patch.
      
              2) This patch renames some of the CSS classes to more consistently
                 follow the camelCase style that PrettyPatch uses.
      
              3) This patch moves the "prepare comments" button to the left of the
                 toolbar and renames is to "publish comments".  This makes more sense
                 when you scroll to the bottom of the page and enter in some overall
                 comments.
      
              4) When you attempt to add a comment to a line that already has a
                 "frozen" comment, we now unfreeze the comment instead of doing
                 nothing.  The old behavior was kind of frustrating if you didn't
                 know that you could unfreeze a comment by clicking on it.
      
              * PrettyPatch/PrettyPatch.rb:
                  - Update CSS.
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1414c99f
    • mrobinson@webkit.org's avatar
      2010-09-06 Martin Robinson <mrobinson@igalia.com> · c6c1079a
      mrobinson@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] ScrollbarThemeGtk should be enabled for interior frame scrollbars
              https://bugs.webkit.org/show_bug.cgi?id=45046
      
              Make interior frame scrollbars "fully-fake," which means they do not rely
              at all on GTK+ for painting or behavior, but instead are typical WebCore
              scrollbars drawn according to the GTK+ theme. Move ScrollbarGtk to
              MainFrameScrollbarGtk and remove all logic in that file dealing with interior
              frame scrollbars.
      
              No new tests, as this is already covered by pixel tests for scrollbars,
              which were added in r66605.
      
              * GNUmakefile.am: Update sources list.
              * platform/ScrollView.h: Change the adjustment members to be smart pointers.
              * platform/Scrollbar.cpp: Enable THUMB_POSITION_AFFECTS_BUTTONS for GTK+ as well.
              * platform/gtk/MainFrameScrollbarGtk.cpp: Added.
              (MainFrameScrollbarGtk::create): Create a MainFrameScrollbarGtk instead of ScrollbarGtk.
              (MainFrameScrollbarGtk::MainFrameScrollbarGtk):
              (MainFrameScrollbarGtk::~MainFrameScrollbarGtk):
              (MainFrameScrollbarGtk::attachAdjustment):
              (MainFrameScrollbarGtk::detachAdjustment):
              (MainFrameScrollbarGtk::updateThumbPosition):
              (MainFrameScrollbarGtk::updateThumbProportion):
              (MainFrameScrollbarGtk::gtkValueChanged):
              (MainFrameScrollbarGtk::paint):
              * platform/gtk/MainFrameScrollbarGtk.h: Added.
              * platform/gtk/ScrollViewGtk.cpp:
              (WebCore::ScrollView::platformInit): Remove unnecessary initialization
              because of smart pointer change.
              (WebCore::ScrollView::createScrollbar): Instead of creating ScrollbarGtk for
              interior frame scrollbars, create a normal WebCore scrollbar.
              (WebCore::ScrollView::setGtkAdjustments): Added an extra assert which ensures
              that this method is never called with a non-null adjustment on an interior frame
              scrollbar.
              (WebCore::ScrollView::platformAddChild): Remove logic for interior frame scrollbars.
              (WebCore::ScrollView::platformRemoveChild): Remove logic for interior frame scrollbars.
              (WebCore::ScrollView::visibleContentRect): Use a more accurate guard for detecting
              transitionary states when accessing parent widgets. Explcitly guard against interior
              frame ScrollView's trying to determine size based on parent widgets.
              (WebCore::ScrollView::setScrollbarModes): This method was out of sync with the one
              it copy-and-pasted from. Update it and change the logic to do the right thing for
              interior frame scrollbars.
              * platform/gtk/ScrollbarGtk.cpp: Removed.
              * platform/gtk/ScrollbarGtk.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6c1079a
    • jschuh@chromium.org's avatar
      2010-09-06 Justin Schuh <jschuh@chromium.org> · 32370f5c
      jschuh@chromium.org authored
              Reviewed by Nikolas Zimmermann.
      
              Make SVG PendingResources use RefPtr
              https://bugs.webkit.org/show_bug.cgi?id=43587
      
              Convert SVGDocumentExtensions::m_pendingResources to use a RefPtr for 
              pending elements instead of a raw pointer so that pending elements can't
              be freed prematurely.
      
              Test: svg/custom/use-invalid-pattern.svg
      
              * rendering/RenderSVGResourceContainer.cpp:
              (WebCore::RenderSVGResourceContainer::registerResource):
              * svg/SVGDocumentExtensions.cpp:
              (WebCore::SVGDocumentExtensions::addPendingResource):
              (WebCore::SVGDocumentExtensions::removePendingResource):
              * svg/SVGDocumentExtensions.h:
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::insertedIntoDocument):
      2010-09-06  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Nikolas Zimmermann.
      
              Test that an invalid pending resource pattern doesn't crash
              https://bugs.webkit.org/show_bug.cgi?id=43587
      
              * platform/mac-snowleopard/svg: Added.
              * platform/mac-snowleopard/svg/custom: Added.
              * platform/mac-snowleopard/svg/custom/use-invalid-pattern-expected.txt: Added.
              * svg/custom/use-invalid-pattern.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32370f5c
    • commit-queue@webkit.org's avatar
      2010-09-06 Chao-ying Fu <fu@mips.com> · a10b3572
      commit-queue@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Support JSVALUE32_64 on MIPS
              https://bugs.webkit.org/show_bug.cgi?id=43999
      
              Add missing functions to support JSVALUE32_64 on MIPS.
              Remove JSVALUE32 as the default for MIPS.
      
              * assembler/MIPSAssembler.h:
              (JSC::MIPSAssembler::divd):
              (JSC::MIPSAssembler::mthc1):
              (JSC::MIPSAssembler::cvtwd):
              * assembler/MacroAssemblerMIPS.h:
              (JSC::MacroAssemblerMIPS::neg32):
              (JSC::MacroAssemblerMIPS::branchOr32):
              (JSC::MacroAssemblerMIPS::set8):
              (JSC::MacroAssemblerMIPS::loadDouble):
              (JSC::MacroAssemblerMIPS::divDouble):
              (JSC::MacroAssemblerMIPS::convertInt32ToDouble):
              (JSC::MacroAssemblerMIPS::branchDouble):
              (JSC::MacroAssemblerMIPS::branchConvertDoubleToInt32):
              (JSC::MacroAssemblerMIPS::zeroDouble):
              * jit/JIT.h:
              * jit/JITOpcodes32_64.cpp:
              (JSC::JIT::privateCompileCTINativeCall):
              * jit/JITPropertyAccess32_64.cpp:
              (JSC::JIT::privateCompilePutByIdTransition):
              * jit/JITStubs.cpp:
              (JSC::JITThunks::JITThunks):
              * jit/JITStubs.h:
              * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a10b3572
    • mrobinson@webkit.org's avatar
      2010-09-06 Martin Robinson <mrobinson@igalia.com> · e60e1764
      mrobinson@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] ScrollbarThemeGtk should support secondary steppers
              https://bugs.webkit.org/show_bug.cgi?id=44791
      
              Add support to ScrollbarThemeGtk for drawing alternate steppers. Adjust
              the algorithms for calculating forward and back button rects, if they
              are active in the theme. Expose this information via GtkScrollbarMetrics.
      
              * platform/gtk/ScrollbarThemeGtk.cpp:
              (WebCore::ScrollbarThemeGtk::updateThemeProperties): Access the secondary stepper properties
              of GtkScrollbarMetrics when updating the style cache.
              (WebCore::ScrollbarThemeGtk::backButtonRect): Account for alternate steppers.
              (WebCore::ScrollbarThemeGtk::forwardButtonRect): Ditto.
              (WebCore::ScrollbarThemeGtk::trackRect): Ditto.
              (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
              * platform/gtk/ScrollbarThemeGtk.h:
              * platform/gtk/gtk2drawing.c: Expose whether or not the style uses alternate steppers
              via GtkScrollbarMetrics.
              * platform/gtk/gtkdrawing.h: Added fields to GtkScrollbarMetrics.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e60e1764
    • robert@webkit.org's avatar
      Fix compile failure in r66843 · 312bb28b
      robert@webkit.org authored
      Revert to original patch in bugzilla. Leave bug open for
      discussion on potential removal of double utf8 conversion.
      
      https://bugs.webkit.org/show_bug.cgi?id=45240
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      312bb28b
    • robert@webkit.org's avatar
      2010-09-06 Robert Hogan <robert@webkit.org> · 27aeb88f
      robert@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] utf8 encoding of console() messages
      
              Unskip:
              http/tests/security/xssAuditor/embed-tag-null-char.html
              http/tests/security/xssAuditor/object-embed-tag-null-char.html
      
              Both tests failed because Qt's implementation of String::format()
              is casting a utf8 result to String, which assumes latin1 in
              its constructor. So instead of casting a QString to a String, use
              StringImpl::create() instead. Unfortunately, this involves a lot
              of extra casts but the end result is correct.
      
              https://bugs.webkit.org/show_bug.cgi?id=45240
      
              * wtf/text/WTFString.cpp:
              (WTF::String::format):
      2010-09-06  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] utf8 encoding of console() messages
      
              Unskip:
              http/tests/security/xssAuditor/embed-tag-null-char.html
              http/tests/security/xssAuditor/object-embed-tag-null-char.html
      
              Both tests failed because Qt's implementation of String::format()
              is casting a utf8 result to String, which assumes latin1 in
              its constructor. So instead of casting a QString to a String, use
              StringImpl::create() instead. Unfortunately, this involves a lot
              of extra casts but the end result is correct.
      
              https://bugs.webkit.org/show_bug.cgi?id=45240
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27aeb88f
    • jschuh@chromium.org's avatar
      2010-09-06 Justin Schuh <jschuh@chromium.org> · 2bfe1fd5
      jschuh@chromium.org authored
              Unreviewed. Build fix.
      
              Update test expectations for Chromium Mac.
      
              * platform/chromium-mac/svg/custom/use-invalid-style-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bfe1fd5
    • tonyg@chromium.org's avatar
      2010-09-06 Tony Gentilcore <tonyg@chromium.org> · d299d8a7
      tonyg@chromium.org authored
              Reviewed by Adam Barth.
      
              Implement HTML5 definition of document.readyState
              https://bugs.webkit.org/show_bug.cgi?id=45119
      
              * fast/dom/Document/readystate-expected.txt: Added.
              * fast/dom/Document/readystate.html: Added. Reads readyState inline script, external script, deferred script, DOMContentLoaded, onload, and dynamic post-onload script.
      2010-09-06  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Adam Barth.
      
              Implement HTML5 definition of document.readyState
              https://bugs.webkit.org/show_bug.cgi?id=45119
      
              The legacy behavior was "loading" -> "loaded" -> "complete". The new
              HTML5 behavior is "loading" -> "interactive" -> "complete". There is
              some potential for this to cause compat problems if for instance a
              page expects readyState to be "loaded" during the DOMContentLoaded event.
      
              Test: fast/dom/Document/readystate.html
      
              * dom/Document.cpp:
              (WebCore::Document::Document): Initial value is Complete because according to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-readystate,
              when a Document is created the initial value is "complete" unless it has a parser associated with it, in which case it is "loading".
              So the ctor starts it Complete, and when the parser is created it is flipped to Loading.
              (WebCore::Document::readyState):
              (WebCore::Document::setReadyState):
              (WebCore::Document::implicitOpen):
              (WebCore::Document::finishedParsing): Ensure that XML and HTML parser have transition to Stopping state.
              * dom/Document.h:
              * dom/DocumentParser.cpp:
              (WebCore::DocumentParser::prepareToStopParsing): Previously this was being called when parsing had stopped.
              It is better to ensure it is only called while parsing.
              * dom/XMLDocumentParser.cpp:
              (WebCore::XMLDocumentParser::end): Transition to stopping before calling document finishedParsiong().
              * html/parser/HTMLDocumentParser.cpp:
              (WebCore::HTMLDocumentParser::prepareToStopParsing): Set state to interactive before running deferred scripts.
              This method is also called when parsing fragments, so we need to ensure it isn't done in that case.
              (WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd): Added. Break out this part s that notifyFinished doesn't go through
              the additional steps of pumping tokenizer, setting the state, etc.
              (WebCore::HTMLDocumentParser::notifyFinished): Now that prepareToStopParsing is split up, we must protect. It also makes sense to add a couple of ASSERTs.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::stopLoading): It looks like an aborted load should never transition to "complete" according the HTML5. I've left the legacy behavior for now though.
              (WebCore::FrameLoader::checkCompleted): The FrameLoader now sets the state on the Document instead of the Document polling the FrameLoader.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d299d8a7
    • antonm@chromium.org's avatar
      2010-09-06 Anton Muhin <antonm@chromium.org> · f49851c9
      antonm@chromium.org authored
              Reviewed by Adam Barth.
      
              [v8] Inline hot methods for V8 to WebCore and back conversions
              https://bugs.webkit.org/show_bug.cgi?id=45270
      
              Inline fast paths of hot functions performing conversions from V8 wrappers
              to WebCore native objects and back.
              That slightly increases the size of binary (within 0.1% for both Ubuntu
              and Windows, but those builds are slightly different from official ones),
              but gives performance boost (3--5% on Windows, up to 8% on Ubuntu).
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::V8DOMWindowShell::initContextIfNeeded):
              * bindings/v8/V8DOMWindowShell.h:
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::getWrapperSlow):
              * bindings/v8/V8DOMWrapper.h:
              (WebCore::V8DOMWrapper::getWrapper):
              * bindings/v8/custom/V8NodeCustom.cpp:
              (WebCore::toV8Slow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f49851c9
    • commit-queue@webkit.org's avatar
      2010-09-06 Ryuan Choi <ryuan.choi@samsung.com> · 07e1356e
      commit-queue@webkit.org authored
              Unreviewed build fix.
      
              [EFL] REGRESSION(66794) Need to fix build break.
              https://bugs.webkit.org/show_bug.cgi?id=45241
      
              Add dummy class(FrameNetworkingContextEfl) like GTK+ port and implement
              as EFL style.
      
              * WebCoreSupport/FrameLoaderClientEfl.cpp:
              (WebCore::FrameLoaderClientEfl::createNetworkingContext):
              * WebCoreSupport/FrameNetworkingContextEfl.h: Added.
              (WebCore::FrameNetworkingContextEfl::create):
              (WebCore::FrameNetworkingContextEfl::coreFrame):
              (WebCore::FrameNetworkingContextEfl::FrameNetworkingContextEfl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07e1356e
    • abarth@webkit.org's avatar
      2010-09-06 Adam Barth <abarth@webkit.org> · cbecfb3b
      abarth@webkit.org authored
              [reviewtool] Tweak the ok button to cancel the comment if the comment
              is empty.  Previously we would get into a bad state where a line had a
              comment but there was no longer any way to access it.
      
              * code-review.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbecfb3b
    • commit-queue@webkit.org's avatar
      2010-09-06 Jonathan Dixon <joth@chromium.org> · 7fba61bc
      commit-queue@webkit.org authored
              Reviewed by Jeremy Orlow.
      
              Add new interface and empty impl. as precursor to bug 45112
              https://bugs.webkit.org/show_bug.cgi?id=45257
      
              * public/WebGeolocationServiceBridge.h:
              (WebKit::WebGeolocationServiceBridge::~WebGeolocationServiceBridge):
              * src/WebGeolocationServiceBridgeImpl.cpp:
              (WebKit::WebGeolocationServiceBridgeImpl::onWebGeolocationServiceDestroyed):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fba61bc
    • commit-queue@webkit.org's avatar
      2010-09-06 Shane Stephens <shanestephens@google.com> · 35bcdf7b
      commit-queue@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [Crash] <animateMotion> element directly inside <symbol> element causes crash when referenced by <use>
              https://bugs.webkit.org/show_bug.cgi?id=44750
      
              Added test case to demonstrate crash bug.
      
              * svg/dom/symbol-embeddedAnimation-expected.txt: Added.
              * svg/dom/symbol-embeddedAnimation.svg: Added.
      2010-09-06  Shane Stephens  <shanestephens@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              [Crash] <animateMotion> element directly inside <symbol> element causes crash when referenced by <use>
              https://bugs.webkit.org/show_bug.cgi?id=44750
      
              Fixes crash by checking for null transforms and skipping update step
              when appropriate.
      
              Test: svg/dom/symbol-embeddedAnimation.svg
      
              * svg/SVGAnimateMotionElement.cpp:
              (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35bcdf7b