1. 02 Oct, 2013 15 commits
    • weinig@apple.com's avatar
      CTTE: DOMWrapperWorlds should be passed around by reference · 8f716033
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122206
      
      Reviewed by Andreas Kling.
      
      ../WebCore: 
      
      * bindings/js/DOMWrapperWorld.cpp:
      (WebCore::DOMWrapperWorld::DOMWrapperWorld):
      (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
      (WebCore::DOMWrapperWorld::clearWrappers):
      (WebCore::normalWorld):
      (WebCore::mainThreadNormalWorld):
      * bindings/js/DOMWrapperWorld.h:
      (WebCore::debuggerWorld):
      (WebCore::pluginWorld):
      (WebCore::currentWorld):
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
      * bindings/js/JSCSSValueCustom.cpp:
      (WebCore::JSCSSValueOwner::finalize):
      * bindings/js/JSDOMBinding.h:
      (WebCore::wrapperOwner):
      (WebCore::wrapperContext):
      (WebCore::getInlineCachedWrapper):
      (WebCore::setInlineCachedWrapper):
      (WebCore::clearInlineCachedWrapper):
      (WebCore::getCachedWrapper):
      (WebCore::cacheWrapper):
      (WebCore::uncacheWrapper):
      (WebCore::jsStringWithCache):
      * bindings/js/JSDOMGlobalObject.cpp:
      (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
      (WebCore::toJSDOMGlobalObject):
      * bindings/js/JSDOMGlobalObject.h:
      (WebCore::JSDOMGlobalObject::world):
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::JSDOMWindowBase):
      (WebCore::toJSDOMWindow):
      * bindings/js/JSDOMWindowBase.h:
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::JSDOMWindowShell):
      (WebCore::JSDOMWindowShell::setWindow):
      (WebCore::toJSDOMWindowShell):
      * bindings/js/JSDOMWindowShell.h:
      (WebCore::JSDOMWindowShell::create):
      (WebCore::JSDOMWindowShell::world):
      * bindings/js/JSErrorHandler.cpp:
      (WebCore::JSErrorHandler::JSErrorHandler):
      * bindings/js/JSErrorHandler.h:
      (WebCore::JSErrorHandler::create):
      * bindings/js/JSEventListener.cpp:
      (WebCore::JSEventListener::JSEventListener):
      (WebCore::JSEventListener::handleEvent):
      * bindings/js/JSEventListener.h:
      (WebCore::JSEventListener::create):
      (WebCore::JSEventListener::isolatedWorld):
      * bindings/js/JSInjectedScriptHostCustom.cpp:
      (WebCore::getJSListenerFunctions):
      * bindings/js/JSLazyEventListener.cpp:
      (WebCore::JSLazyEventListener::JSLazyEventListener):
      * bindings/js/JSLazyEventListener.h:
      * bindings/js/JSMutationCallback.cpp:
      (WebCore::JSMutationCallback::JSMutationCallback):
      (WebCore::JSMutationCallback::call):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::JSNodeOwner::finalize):
      * bindings/js/JSPluginElementFunctions.h:
      (WebCore::pluginElementCustomGetOwnPropertySlot):
      * bindings/js/JSWorkerGlobalScopeBase.cpp:
      (WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
      * bindings/js/ScheduledAction.cpp:
      (WebCore::ScheduledAction::create):
      (WebCore::ScheduledAction::ScheduledAction):
      (WebCore::ScheduledAction::execute):
      * bindings/js/ScheduledAction.h:
      (WebCore::ScheduledAction::ScheduledAction):
      * bindings/js/ScriptCachedFrameData.cpp:
      (WebCore::ScriptCachedFrameData::restore):
      * bindings/js/ScriptCachedFrameData.h:
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::~ScriptController):
      (WebCore::ScriptController::destroyWindowShell):
      (WebCore::ScriptController::createWindowShell):
      (WebCore::ScriptController::evaluateInWorld):
      (WebCore::ScriptController::getAllWorlds):
      (WebCore::ScriptController::initScript):
      (WebCore::ScriptController::executeScriptInWorld):
      (WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
      * bindings/js/ScriptController.h:
      (WebCore::ScriptController::windowShell):
      (WebCore::ScriptController::existingWindowShell):
      (WebCore::ScriptController::globalObject):
      * bindings/js/ScriptDebugServer.cpp:
      (WebCore::ScriptDebugServer::isContentScript):
      * bindings/js/ScriptState.cpp:
      (WebCore::execStateFromNode):
      (WebCore::execStateFromPage):
      * bindings/js/ScriptState.h:
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::SerializedScriptValue::transferArrayBuffers):
      * bindings/js/WebCoreJSClientData.h:
      (WebCore::WebCoreJSClientData::WebCoreJSClientData):
      (WebCore::WebCoreJSClientData::normalWorld):
      (WebCore::WebCoreJSClientData::getAllWorlds):
      (WebCore::WebCoreJSClientData::rememberWorld):
      (WebCore::WebCoreJSClientData::forgetWorld):
      * bindings/js/WebCoreTypedArrayController.cpp:
      (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      * dom/Document.cpp:
      (WebCore::Document::ensurePlugInsInjectedScript):
      * dom/Document.h:
      * dom/DocumentStyleSheetCollection.cpp:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::ensureIsolatedWorld):
      (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
      (WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
      * html/HTMLMediaElement.h:
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::plugInImageElementIsolatedWorld):
      (WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::didClearWindowObjectInWorld):
      * inspector/InspectorAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::didClearWindowObjectInWorld):
      * inspector/InspectorController.h:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::buildObjectForEventListener):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
      * inspector/InspectorInstrumentation.h:
      (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
      * inspector/InspectorPageAgent.h:
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
      (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
      (WebCore::FrameLoader::dispatchGlobalObjectAvailableInAllWorlds):
      * loader/FrameLoader.h:
      * loader/FrameLoaderClient.h:
      (WebCore::FrameLoaderClient::dispatchGlobalObjectAvailable):
      * page/CaptionUserPreferencesMediaAF.cpp:
      * page/DOMWindowExtension.cpp:
      (WebCore::DOMWindowExtension::DOMWindowExtension):
      * page/DOMWindowExtension.h:
      (WebCore::DOMWindowExtension::create):
      (WebCore::DOMWindowExtension::world):
      * page/Frame.cpp:
      (WebCore::Frame::injectUserScripts):
      (WebCore::Frame::injectUserScriptsForWorld):
      * page/Frame.h:
      * page/PageGroup.cpp:
      (WebCore::PageGroup::addUserScriptToWorld):
      (WebCore::PageGroup::addUserStyleSheetToWorld):
      (WebCore::PageGroup::removeUserScriptFromWorld):
      (WebCore::PageGroup::removeUserStyleSheetFromWorld):
      (WebCore::PageGroup::removeUserScriptsFromWorld):
      (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
      * page/PageGroup.h:
      
      ../WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
      * WebCoreSupport/FrameLoaderClientEfl.h:
      
      ../WebKit/gtk: 
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
      * WebCoreSupport/FrameLoaderClientGtk.h:
      
      ../WebKit/mac: 
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
      (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
      (WebKit::NetscapePluginInstanceProxy::evaluate):
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      * WebView/WebFrame.mm:
      (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
      (-[WebFrame _globalContextForScriptWorld:]):
      (-[WebFrame jsWrapperForNode:inScriptWorld:]):
      * WebView/WebScriptWorld.mm:
      (+[WebScriptWorld standardWorld]):
      (+[WebScriptWorld findOrCreateWorld:]):
      * WebView/WebScriptWorldInternal.h:
      * WebView/WebView.mm:
      (-[WebView _injectOutlookQuirksScript]):
      (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
      (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
      (+[WebView _removeUserScriptFromGroup:world:url:]):
      (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
      (+[WebView _removeUserScriptsFromGroup:world:]):
      (+[WebView _removeUserStyleSheetsFromGroup:world:]):
      
      ../WebKit/win: 
      
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebScriptWorld.cpp:
      (WebScriptWorld::standardWorld):
      (WebScriptWorld::findOrCreateWorld):
      * WebScriptWorld.h:
      (WebScriptWorld::world):
      
      ../WebKit/wince: 
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::dispatchDidClearWindowObjectInWorld):
      * WebCoreSupport/FrameLoaderClientWinCE.h:
      
      ../WebKit2: 
      
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
      (WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
      (WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
      * WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
      (WebKit::InjectedBundleScriptWorld::getOrCreate):
      (WebKit::InjectedBundleScriptWorld::normalWorld):
      (WebKit::InjectedBundleScriptWorld::coreWorld):
      * WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::windowScriptNPObject):
      (WebKit::PluginView::pluginElementNPObject):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
      (WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f716033
    • zandobersek@gmail.com's avatar
      1cef0abe
    • commit-queue@webkit.org's avatar
      [CSS Regions] Activate all regions to have layers, as CSS Regions create a new stacking context · df35f20a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121828
      
      Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-10-02
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      The CSS Regions specification says "CSS Regions create a new stacking context." (http://dev.w3.org/csswg/css-regions/).
      
      Divs that create stacking contexts are painted after the divs that don't create stacking contexts.
      
      Test: fast/regions/layers/stacking-context-paint-order.html: While the existing region-sibling-paint-order.html
      test verifies that regions paint correctly when the next sibling also creates a stacking context, this new test
      verifies that regions paint correctly when the next sibling doesn't create a stacking context.
      
      * rendering/RenderBlock.cpp: Remove code that is not needed now that all regions have layers.
      * rendering/RenderBlock.h: Remove code that is not needed now that all regions have layers.
      * rendering/RenderBox.cpp: Remove code that is not needed now that all regions have layers.
      * rendering/RenderBox.h: Remove code that is not needed now that all regions have layers.
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::updateLayerToRegionMappings): Remove code that is not needed now that all regions have layers.
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::RenderRegion):
      * rendering/RenderRegion.h:
      (WebCore::RenderRegion::requiresLayer): Always. CSS Regions create Stacking Contexts. RenderMultiColumnSet
      implements its own behaviour so the behaviour of each class is contained within its own files.
      * rendering/RenderMultiColumnSet.h:
      (WebCore::RenderMultiColumnSet::requiresLayer): RenderMultiColumnSet derives from RenderRegion, but unlike the
      CSS Regions specification, the Multi-Columns CSS specification states that the column boxes do not establish new
      Stacking Contexts.
      * rendering/RenderTreeAsText.cpp:
      (WebCore::writeRenderRegionList): There's no need to output " hasLayer" since all regions now have layers.
      
      LayoutTests:
      
      For the ref tests, the divs in the expected results coresponding to the regions now have a CSS style causing
      them to also create Stacking Contexts.
      
      Most of the tests in fast/regions/layers/ have been deleted because they aren't relevant anymore.
      
      The change in most of the *-expected.txt files is that the " hasLayer" part has been removed (since all regions
      now have layers).
      
      Platform (efl, efl-wk2, gtk, mac-lion, mac-wk2, qt, qt-wk2) specific expectated results need to be generated again.
      
      * fast/regions/autoheight-regions-mark-expected.txt:
      * fast/regions/flow-content-basic-expected.html: Added. The test is now a ref test.
      * fast/regions/flow-content-basic-vertical-expected.html: Added. The test is now a ref test.
      * fast/regions/flow-content-basic-vertical-rl-expected.html: Added.The test is now a ref test.
      * fast/regions/flow-content-basic-vertical-rl.html:
      * fast/regions/flow-content-basic-vertical.html:
      * fast/regions/flow-content-basic.html:
      * fast/regions/flows-dependency-dynamic-remove-expected.txt:
      * fast/regions/flows-dependency-same-flow-expected.txt:
      * fast/regions/layers/dynamic-layer-added-with-no-layout-expected.png: Removed.
      * fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Removed.
      * fast/regions/layers/dynamic-layer-added-with-no-layout.html: Removed.
      * fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.png: Removed.
      * fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Removed.
      * fast/regions/layers/dynamic-layer-removed-with-no-layout.html: Removed.
      * fast/regions/layers/regions-promoted-to-layers-expected.png: Removed.
      * fast/regions/layers/regions-promoted-to-layers-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.png: Removed.
      * fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-horizontal-bt.html: Removed.
      * fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.png: Removed.
      * fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-vertical-lr.html: Removed.
      * fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.png: Removed.
      * fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-vertical-rl.html: Removed.
      * fast/regions/layers/regions-promoted-to-layers.html: Removed.
      * fast/regions/layers/stacking-context-paint-order-expected.html: Added.
      * fast/regions/layers/stacking-context-paint-order.html: Added. While the existing region-sibling-paint-order.html
      test verifies that regions paint correctly when the next sibling also creates a stacking context, this new test
      verifies that regions paint correctly when the next sibling doesn't create a stacking context.
      * fast/regions/region-sibling-paint-order-expected.html:
      * fast/regions/region-sibling-paint-order.html:
      * fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
      * fast/repaint/region-painting-composited-element-expected.html:
      * fast/repaint/region-painting-in-composited-view-expected.html:
      * fast/repaint/region-painting-in-composited-view.html:
      * fast/repaint/region-painting-via-layout-expected.txt:
      * platform/efl-wk2/TestExpectations:
      * platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
      * platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
      * platform/efl/TestExpectations:
      * platform/efl/fast/regions/autoheight-regions-mark-expected.png: Removed.
      * platform/efl/fast/regions/autoheight-regions-mark-expected.txt: Removed.
      * platform/efl/fast/regions/flow-content-basic-expected.png: Removed. The test is now a ref test.
      * platform/efl/fast/regions/flow-content-basic-expected.txt: Removed.
      * platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Removed.
      * platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
      * platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
      * platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
      * platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
      * platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
      * platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
      * platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
      * platform/efl/fast/regions/region-dynamic-after-before-expected.txt:
      * platform/efl/fast/regions/region-generated-content-before-after-expected.txt:
      * platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Removed.
      * platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
      * platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
      * platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
      * platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
      * platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
      * platform/efl/fast/repaint/region-painting-invalidation-expected.png: Removed.
      * platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Removed.
      * platform/efl/fast/repaint/region-painting-via-layout-expected.png: Removed.
      * platform/efl/fast/repaint/region-painting-via-layout-expected.txt: Removed.
      * platform/gtk/TestExpectations:
      * platform/gtk/fast/regions/autoheight-regions-mark-expected.png: Removed.
      * platform/gtk/fast/regions/autoheight-regions-mark-expected.txt: Removed.
      * platform/gtk/fast/regions/flow-content-basic-expected.png: Removed.
      * platform/gtk/fast/regions/flow-content-basic-expected.txt: Removed.
      * platform/gtk/fast/regions/flow-content-basic-vertical-expected.png: Removed.
      * platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
      * platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
      * platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
      * platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
      * platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
      * platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
      * platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
      * platform/gtk/fast/regions/region-dynamic-after-before-expected.txt:
      * platform/gtk/fast/regions/region-generated-content-before-after-expected.txt:
      * platform/gtk/fast/regions/text-region-split-small-pagination-expected.png: Removed.
      * platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
      * platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
      * platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
      * platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
      * platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
      * platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
      * platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
      * platform/gtk/fast/repaint/region-painting-invalidation-expected.png: Removed.
      * platform/gtk/fast/repaint/region-painting-invalidation-expected.txt: Removed.
      * platform/gtk/fast/repaint/region-painting-via-layout-expected.png: Removed.
      * platform/gtk/fast/repaint/region-painting-via-layout-expected.txt: Removed.
      * platform/mac-lion/TestExpectations:
      * platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
      * platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
      * platform/mac-wk2/TestExpectations:
      * platform/mac/fast/regions/flow-content-basic-expected.png: Removed.
      * platform/mac/fast/regions/flow-content-basic-expected.txt: Removed.
      * platform/mac/fast/regions/flow-content-basic-vertical-expected.png: Removed.
      * platform/mac/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
      * platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
      * platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
      * platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
      * platform/mac/fast/regions/region-dynamic-after-before-expected.txt:
      * platform/mac/fast/regions/region-generated-content-before-after-expected.txt:
      * platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
      * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
      * platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
      * platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
      * platform/mac/fast/repaint/region-painting-invalidation-expected.txt:
      * platform/qt-wk2/TestExpectations:
      * platform/qt-wk2/fast/regions/flow-content-basic-expected.png: Removed.
      * platform/qt-wk2/fast/regions/flow-content-basic-vertical-expected.png: Removed.
      * platform/qt-wk2/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
      * platform/qt-wk2/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
      * platform/qt-wk2/fast/regions/text-region-split-small-pagination-expected.png: Removed.
      * platform/qt-wk2/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
      * platform/qt-wk2/fast/repaint/region-painting-invalidation-expected.png: Removed.
      * platform/qt-wk2/fast/repaint/region-painting-invalidation-expected.txt: Removed.
      * platform/qt-wk2/fast/repaint/region-painting-via-layout-expected.png: Removed.
      * platform/qt/TestExpectations:
      * platform/qt/fast/regions/autoheight-regions-mark-expected.png: Removed.
      * platform/qt/fast/regions/autoheight-regions-mark-expected.txt: Removed.
      * platform/qt/fast/regions/flow-content-basic-expected.png: Removed.
      * platform/qt/fast/regions/flow-content-basic-expected.txt: Removed.
      * platform/qt/fast/regions/flow-content-basic-vertical-expected.png: Removed.
      * platform/qt/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
      * platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
      * platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
      * platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
      * platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
      * platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
      * platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
      * platform/qt/fast/regions/text-region-split-small-pagination-expected.png: Removed.
      * platform/qt/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
      * platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
      * platform/qt/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
      * platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
      * platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
      * platform/qt/fast/repaint/region-painting-invalidation-expected.png: Removed.
      * platform/qt/fast/repaint/region-painting-invalidation-expected.txt: Removed.
      * platform/qt/fast/repaint/region-painting-via-layout-expected.png: Removed.
      * platform/qt/fast/repaint/region-painting-via-layout-expected.txt: Removed.
      * platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
      * platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df35f20a
    • reni@webkit.org's avatar
      HTML listbox is not resized horizontally when zooming · e0782495
      reni@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=20445
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      If any style changes happens on a HTMLSelectElement, we need to set the m_optionsChanged property
      of its renderer (RenderListBox) otherwise its size won't follow the changed content.
      
      Test: fast/transforms/listbox-zoom.html
      
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::didRecalcStyle):
      * html/HTMLSelectElement.h:
      
      LayoutTests:
      
      A test with a zoomed listbox is added to check whether the styleChange is catched.
      
      * fast/transforms/listbox-zoom.html: Added.
      * fast/transforms/listbox-zoom-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0782495
    • graouts@apple.com's avatar
      Web Inspector: highlight newly added console messages in the Activity Viewer · 208a24a1
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122093
      
      Reviewed by Joseph Pecoraro.
      
      Fade the appropriate console log button in the Activity Viewer for a short duration
      to call attention to it when its count is incremented. The animation may be restarted
      in-flight if the count is incremented as we were pulsing the opacity.
      
      * UserInterface/DashboardView.css:
      (.toolbar .dashboard > .item.pulsing):
      (@-webkit-keyframes console-item-pulse):
      New pulse animation for a console item in the Activity Viewer, the new "pulsing" CSS
      class is applied in WebInspector.DashboardView.prototype._setConsoleItemValue().
      
      * UserInterface/DashboardView.js:
      (WebInspector.DashboardView.prototype.set logs):
      (WebInspector.DashboardView.prototype.set issues):
      (WebInspector.DashboardView.prototype.set errors):
      Refactor setters to use the new WebInspector.DashboardView.prototype._setConsoleItemValue()
      method.
      
      (WebInspector.DashboardView.prototype._setConsoleItemValue):
      We now set the ivar backing console item values in this new refactored method and additionally
      apply an animation to the DOM element for the given item if its value is incremented such that
      it pulses, subtly calling out the developer's attention to it.
      
      * UserInterface/Utilities.js:
      New Element.prototype.recalculateStyles() method to abstract the hack required to force
      a style recalc on a given element.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      208a24a1
    • commit-queue@webkit.org's avatar
      contenteditable justify commands applied to next paragraph as well · dcfed98f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90611
      
      Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-01
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      When the selection extends from first paragraph to start of next
      paragraph then Justify command is applied to both the paragraph,
      Instead it should be applied only to first paragraph.
      
      Co-author: Sudarshan C P <sudarshan.cp@samsung.com>
      
      Test: editing/execCommand/contenteditable-justify-next-paragraph.html
      
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::applyBlockStyle):
      Adjusted visibleEnd to previous position.
      
      LayoutTests:
      
      Added a test for selecting one paragraph and the beginning of another
      paragraph to ensure that only the first fully-selected paragraph should
      be justified when justifying the selection.
      
      * editing/execCommand/align-in-span-expected.txt: Updated.
      * editing/execCommand/contenteditable-justify-next-paragraph-expected.txt: Added.
      * editing/execCommand/contenteditable-justify-next-paragraph.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcfed98f
    • ap@apple.com's avatar
      Flaky Test: media/media-element-play-after-eos.html · 84ca3f74
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115048
      
      * platform/mac/TestExpectations: Marking as such.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84ca3f74
    • akling@apple.com's avatar
      Move mouse event dispatch from Node to Element. · 6fcecbbd
      akling@apple.com authored
      <https://webkit.org/b/122203>
      
      Reviewed by Anders Carlsson.
      
      We never dispatch mouse events on text or other non-element nodes,
      so move the related logic to using Element.
      
      Node::dispatchMouseEvent() moves to Element. I also changed the
      relatedTarget argument to be an Element* since the related target
      is never a Node either.
      
      Most of this patch is *Node -> *Element renames in EventHandler.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fcecbbd
    • gyuyoung.kim@samsung.com's avatar
      Generate toCSSFooValue for CSS child values · 2ab68261
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122157
      
      Reviewed by Darin Adler.
      
      As a step to cleanup static_cast<> for CSSFooValue, this patch adds toCSSFooValue()
      for "CSSAspectRatioValue, CSSBorderImageSliceValue, CSSFunctionValue, CSSInheritedValue,
      CSSValueList, CSSVariableValue, and CSSFontFaceSrcValue".
      
      To use CSS_VALUE_TYPE_CASTS, isFunctionValue(), isFontFaceSrcValue() are added to
      generate toCSSFunctionValue, toCSSFontFaceSrcValue().
      
      No new tests, no behavior changes.
      
      * css/CSSAspectRatioValue.h:
      * css/CSSBorderImageSliceValue.h:
      * css/CSSFontFaceSrcValue.h:
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::addFontFaceRule):
      * css/CSSFunctionValue.h:
      * css/CSSInheritedValue.h:
      * css/CSSParser.cpp:
      (WebCore::filterProperties):
      (WebCore::CSSParser::addFillValue):
      (WebCore::CSSParser::addAnimationValue):
      (WebCore::CSSParser::createFontFaceRule):
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::wrapValueInCommaSeparatedList):
      * css/CSSToStyleMap.cpp:
      (WebCore::CSSToStyleMap::mapNinePieceImage):
      (WebCore::CSSToStyleMap::mapNinePieceImageSlice):
      * css/CSSValue.cpp:
      (WebCore::CSSValue::destroy):
      * css/CSSValue.h:
      (WebCore::CSSValue::isFunctionValue):
      (WebCore::CSSValue::isFontFaceSrcValue):
      * css/CSSValueList.h:
      (WebCore::CSSValueListInspector::CSSValueListInspector):
      * css/CSSVariableValue.h:
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::ApplyPropertyFillLayer::applyValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyValue):
      (WebCore::ApplyPropertyCounter::applyValue):
      (WebCore::ApplyPropertyCursor::applyValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
      (WebCore::ApplyPropertyAspectRatio::applyValue):
      (WebCore::ApplyPropertyImageResolution::applyValue):
      (WebCore::ApplyPropertyTextIndent::applyValue):
      * css/MediaQueryEvaluator.cpp:
      (WebCore::compareAspectRatioValue):
      * css/SVGCSSStyleSelector.cpp:
      (WebCore::StyleResolver::applySVGProperty):
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::getLayeredShorthandValue):
      * css/StyleResolver.cpp:
      (WebCore::createGridPosition):
      (WebCore::StyleResolver::applyProperty):
      (WebCore::StyleResolver::parseCustomFilterParameter):
      (WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
      * editing/EditingStyle.cpp:
      (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
      (WebCore::EditingStyle::mergeStyle):
      (WebCore::StyleChange::extractTextStyles):
      (WebCore::diffTextDecorations):
      * editing/EditorCommand.cpp:
      (WebCore::executeToggleStyleInList):
      * svg/SVGFontFaceElement.cpp:
      (WebCore::SVGFontFaceElement::rebuildFontFace):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ab68261
    • fpizlo@apple.com's avatar
      FTL should use the new version of LLVM MCJIT memory manager APIs that take a SectionName · eb804561
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122193
      
      Source/JavaScriptCore: 
      
      Reviewed by Geoffrey Garen.
              
      Update our usage of the LLVM C API since the API is about to change.
      
      * ftl/FTLCompile.cpp:
      (JSC::FTL::mmAllocateCodeSection):
      (JSC::FTL::mmAllocateDataSection):
      
      WebKitLibraries: 
      
      Reviewed by Geoffrey Garen.
      
      * LLVMIncludesMountainLion.tar.bz2:
      * LLVMLibrariesMountainLion.tar.bz2:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb804561
    • fpizlo@apple.com's avatar
      REGRESSION(156464): 50% regression on SunSpider/string-fasta · 4d456e7b
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122202
      
      Source/JavaScriptCore: 
      
      Unreviewed, roll out r156464.
              
      This is a progression on string-fasta, since it fixes the regression.
      
      * bytecode/UnlinkedCodeBlock.cpp:
      (JSC::UnlinkedFunctionExecutable::paramString):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::BytecodeGenerator):
      * bytecompiler/BytecodeGenerator.h:
      (JSC::BytecodeGenerator::emitExpressionInfo):
      * bytecompiler/NodesCodegen.cpp:
      (JSC::ForInNode::emitBytecode):
      (JSC::FuncExprNode::emitBytecode):
      * parser/ASTBuilder.h:
      (JSC::ASTBuilder::createFormalParameterList):
      (JSC::ASTBuilder::createForInLoop):
      (JSC::ASTBuilder::addVar):
      * parser/NodeConstructors.h:
      (JSC::CommaNode::CommaNode):
      (JSC::ParameterNode::ParameterNode):
      (JSC::ForInNode::ForInNode):
      * parser/Nodes.cpp:
      (JSC::FunctionParameters::create):
      (JSC::FunctionParameters::FunctionParameters):
      (JSC::FunctionParameters::~FunctionParameters):
      * parser/Nodes.h:
      (JSC::ExpressionNode::isDotAccessorNode):
      (JSC::CommaNode::append):
      (JSC::ParameterNode::ident):
      (JSC::FunctionParameters::at):
      (JSC::FunctionParameters::identifiers):
      * parser/Parser.cpp:
      (JSC::::Parser):
      (JSC::::parseVarDeclaration):
      (JSC::::parseVarDeclarationList):
      (JSC::::parseForStatement):
      (JSC::::parseFormalParameters):
      (JSC::::parseAssignmentExpression):
      * parser/Parser.h:
      (JSC::Scope::declareParameter):
      (JSC::Parser::declareParameter):
      * parser/SyntaxChecker.h:
      (JSC::SyntaxChecker::createFormalParameterList):
      (JSC::SyntaxChecker::createForInLoop):
      (JSC::SyntaxChecker::operatorStackPop):
      * runtime/JSONObject.cpp:
      * runtime/JSONObject.h:
      
      LayoutTests: 
      
      Unreviewed, roll out r156464.
      
      * js/destructuring-assignment-expected.txt: Removed.
      * js/destructuring-assignment.html: Removed.
      * js/mozilla/strict/13.1-expected.txt:
      * js/mozilla/strict/regress-532254-expected.txt:
      * js/mozilla/strict/script-tests/13.1.js:
      * js/regress/destructuring-arguments-expected.txt: Removed.
      * js/regress/destructuring-arguments-length-expected.txt: Removed.
      * js/regress/destructuring-arguments-length.html: Removed.
      * js/regress/destructuring-arguments.html: Removed.
      * js/regress/destructuring-swap-expected.txt: Removed.
      * js/regress/destructuring-swap.html: Removed.
      * js/regress/script-tests/destructuring-arguments-length.js: Removed.
      * js/regress/script-tests/destructuring-arguments.js: Removed.
      * js/regress/script-tests/destructuring-swap.js: Removed.
      * js/script-tests/destructuring-assignment.js: Removed.
      * sputnik/Conformance/13_Function_Definition/S13_A5.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d456e7b
    • timothy@apple.com's avatar
      Fix singular labels for test failures. · f5c9a5cc
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122200
      
      Reviewed by Joseph Pecoraro.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
      (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5c9a5cc
    • timothy@apple.com's avatar
      Don't keep appending iterations each time the queue updates. · 11657937
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122198
      
      Reviewed by Joseph Pecoraro.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
      (BuildbotQueue.prototype.update):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11657937
    • timothy@apple.com's avatar
      Properly sort iterations in the Dashboard by revision for out-of-order queues. · 9aaf2526
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122196
      
      Reviewed by Brent Fulgham.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
      (BuildbotIteration):
      (BuildbotIteration.prototype.update):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
      (BuildbotQueue.prototype.update):
      (BuildbotQueue.prototype.sortIterations):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aaf2526
    • weinig@apple.com's avatar
      Convert PageGroup to using std::unique_ptr · e8dfefaf
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122184
      
      Reviewed by Anders Carlsson.
      
      * page/CaptionUserPreferences.cpp:
      * page/CaptionUserPreferences.h:
      * page/CaptionUserPreferencesMediaAF.cpp:
      * page/CaptionUserPreferencesMediaAF.h:
      * page/Frame.cpp:
      * page/GroupSettings.h:
      * page/Page.cpp:
      * page/PageGroup.cpp:
      * page/PageGroup.h:
      * page/UserScriptTypes.h:
      * page/UserStyleSheetTypes.h:
      * workers/DedicatedWorkerGlobalScope.h:
      * workers/DedicatedWorkerThread.cpp:
      * workers/DedicatedWorkerThread.h:
      * workers/SharedWorkerGlobalScope.cpp:
      * workers/SharedWorkerGlobalScope.h:
      * workers/SharedWorkerThread.cpp:
      * workers/SharedWorkerThread.h:
      * workers/WorkerGlobalScope.cpp:
      * workers/WorkerGlobalScope.h:
      * workers/WorkerThread.cpp:
      * workers/WorkerThread.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8dfefaf
  2. 01 Oct, 2013 25 commits
    • timothy@apple.com's avatar
      Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations. · 620e8573
      timothy@apple.com authored
      Also fix some URLs to not have extras slashes and add a page title.
      
      https://bugs.webkit.org/show_bug.cgi?id=122192
      
      Reviewed by Joseph Pecoraro.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
      (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
      (WebKitBuildbot.prototype.buildLogURLForIteration):
      (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
      (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      620e8573
    • timothy_horton@apple.com's avatar
      Tiled drawing GraphicsLayer tree dumps should match non-tiled more closely · 203cdfa0
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122172
      
      Reviewed by Anders Carlsson.
      
      No new tests, but will be tested by all of the compositing tests after bug 121859 lands.
      
      * platform/graphics/GraphicsLayer.cpp:
      (WebCore::GraphicsLayer::dumpProperties):
      Only dump drawsContent and backgroundColor if the client says we should.
      Provide the ability to skip over a layer in the dump, making it appear as if that layer's
      children are direct decendents of that layer's parent.
      
      * platform/graphics/GraphicsLayerClient.h:
      (WebCore::GraphicsLayerClient::shouldSkipLayerInDump): Added.
      (WebCore::GraphicsLayerClient::shouldDumpPropertyForLayer): Added.
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::shouldSkipLayerInDump):
      Added. Always skip the root tile cache's flattening layer, as it is
      uninteresting and does not exist in the non-tiled-drawing compositing case.
      
      (WebCore::RenderLayerBacking::shouldDumpPropertyForLayer):
      Don't dump drawsContent on the root tile cache.
      Don't dump backgroundcolor on the root tile cache, unless it is non-white.
      This may require some WebKit2-specific rebaselines, but they will occur later.
      
      * rendering/RenderLayerBacking.h:
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::updateBacking):
      (WebCore::RenderLayerCompositor::layerTreeAsText):
      If the root tile cache has no composited children, don't dump anything,
      to match the traditional case where we drop out of compositing when
      we have no reason to be compositing. Except, do dump the root tile cache's
      layers if we're specifically being asked to dump tile caches.
      
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
      * platform/mac-wk2/tiled-drawing/sticky/sticky-layers-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
      * platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration-expected.txt:
      * platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
      * platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
      * platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
      Rebaseline some tests given these changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      203cdfa0
    • fpizlo@apple.com's avatar
      Variable event stream (for DFG OSR exit) should be explicit about where on the... · ee4d8a7a
      fpizlo@apple.com authored
      Variable event stream (for DFG OSR exit) should be explicit about where on the stack a SetLocal put a value
      https://bugs.webkit.org/show_bug.cgi?id=122178
      
      Reviewed by Geoffrey Garen.
              
      Now if the DFG stores the value of a variable into the stack explicitly via a SetLocal,
      it will record where on the stack it stored the value in addition to recording where on
      the stack the bytecode would have done the SetLocal. Previously it just recorded the
      format and the bytecode variable. Recording just the bytecode variable is currently fine
      since the DFG always executes SetLocal's to the same stack location that the bytecode
      would have used. But that prevents stack compression (webkit.org/b/122024) so this patch
      allows the SetLocal to say both the bytecode variable that we're speaking of and the
      actual stack location to which the SetLocal stored the value.
              
      This had to touch a lot of code, so I took the opportunity to also resolve
      webkit.org/b/108019.
      
      * bytecode/Operands.h:
      (JSC::Operands::hasOperand):
      * dfg/DFGFlushFormat.h:
      (JSC::DFG::dataFormatFor):
      * dfg/DFGMinifiedID.h:
      (JSC::DFG::MinifiedID::bits):
      (JSC::DFG::MinifiedID::invalidID):
      (JSC::DFG::MinifiedID::otherInvalidID):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compileMovHint):
      (JSC::DFG::SpeculativeJIT::compileInlineStart):
      (JSC::DFG::SpeculativeJIT::compileCurrentBlock):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::recordSetLocal):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGValueSource.cpp:
      (JSC::DFG::ValueSource::dump):
      * dfg/DFGValueSource.h:
      (JSC::DFG::ValueSource::ValueSource):
      (JSC::DFG::ValueSource::forFlushFormat):
      (JSC::DFG::ValueSource::forDataFormat):
      (JSC::DFG::ValueSource::isSet):
      (JSC::DFG::ValueSource::kind):
      (JSC::DFG::ValueSource::valueRecovery):
      (JSC::DFG::ValueSource::id):
      (JSC::DFG::ValueSource::virtualRegister):
      * dfg/DFGVariableEvent.cpp:
      (JSC::DFG::VariableEvent::dump):
      (JSC::DFG::VariableEvent::dumpSpillInfo):
      * dfg/DFGVariableEvent.h:
      (JSC::DFG::VariableEvent::fillGPR):
      (JSC::DFG::VariableEvent::fillPair):
      (JSC::DFG::VariableEvent::fillFPR):
      (JSC::DFG::VariableEvent::spill):
      (JSC::DFG::VariableEvent::death):
      (JSC::DFG::VariableEvent::setLocal):
      (JSC::DFG::VariableEvent::movHint):
      (JSC::DFG::VariableEvent::id):
      (JSC::DFG::VariableEvent::gpr):
      (JSC::DFG::VariableEvent::tagGPR):
      (JSC::DFG::VariableEvent::payloadGPR):
      (JSC::DFG::VariableEvent::fpr):
      (JSC::DFG::VariableEvent::spillRegister):
      (JSC::DFG::VariableEvent::bytecodeRegister):
      (JSC::DFG::VariableEvent::machineRegister):
      (JSC::DFG::VariableEvent::variableRepresentation):
      * dfg/DFGVariableEventStream.cpp:
      (JSC::DFG::VariableEventStream::reconstruct):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee4d8a7a
    • commit-queue@webkit.org's avatar
      FTL: split overflow checks into non-overflow arithmetic and an additional call... · 0e3c2688
      commit-queue@webkit.org authored
      FTL: split overflow checks into non-overflow arithmetic and an additional call to the overflow intrinsic check.
      https://bugs.webkit.org/show_bug.cgi?id=122170
      
      Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-01
      Reviewed by Filip Pizlo.
      
      Overflow intrinsics are preventing SCEV and other LLVM analysis passes from analyzing loops. This patch changes the FTL-IR gen by splitting arithmetic calculations into two parts:
      1. Generate the arithmetic calculation (that may overflow)
      2. Generate the overflow check (that is only used by the OSR-exit logic).
      
      We trust LLVM (SelectionDAG) to merge these calculations into a single opcode.
      
      This JS function:
      
      function foo() {
          for (i=0; i < 10000000; i++) { }
      }
      
      Is now compiled into this LLVM-IR:
      
      "OSR exit continuation for @24<Int32>":           ; preds = %"Block #0", %"OSR exit continuation for @24<Int32>2"
        %4 = phi i64 [ %10, %"OSR exit continuation for @24<Int32>2" ], [ -281474976710656, %"Block #0" ]
        %5 = trunc i64 %4 to i32
        %6 = add i32 %5, 1
        %7 = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %5, i32 1)
        %8 = extractvalue { i32, i1 } %7, 1
        br i1 %8, label %"OSR exit failCase for @24<Int32>1", label %"OSR exit continuation for @24<Int32>2"
      
       And into this assembly:
      
      LBB0_1:                                 ## %OSR exit continuation for @24<Int32>
                                      ## =>This Inner Loop Header: Depth=1
          movl  %ecx, %esi
          incl  %esi
          jo  LBB0_4
      
      * ftl/FTLLowerDFGToLLVM.cpp:
      (JSC::FTL::LowerDFGToLLVM::compileAddSub):
      (JSC::FTL::LowerDFGToLLVM::compileArithMul):
      (JSC::FTL::LowerDFGToLLVM::compileArithNegate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e3c2688
    • mrowe@apple.com's avatar
      <http://webkit.org/b/122190> WebKit2 APIs returning CF and NS types should... · 86346d7c
      mrowe@apple.com authored
      <http://webkit.org/b/122190> WebKit2 APIs returning CF and NS types should explicitly declare whether they return retained objects.
      
      This make the APIs easier to use under ARC and can help out the static analyzer.
      
      Reviewed by Anders Carlsson.
      
      * Shared/API/c/cf/WKErrorCF.h:
      * Shared/API/c/cf/WKStringCF.h:
      * Shared/API/c/cf/WKURLCF.h:
      * Shared/API/c/cg/WKImageCG.h:
      * Shared/API/c/mac/WKURLRequestNS.h:
      * Shared/API/c/mac/WKURLResponseNS.h:
      * UIProcess/API/C/cg/WKIconDatabaseCG.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86346d7c
    • joone.hur@intel.com's avatar
      Quirksmode: CSS1: WebKit fails dynamic :first-letter test · 4132693e
      joone.hur@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=15602
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      CSS first-letter property does not work properly when the first letter is changed
      by DOM scripting.
      This patch allows to check if the existing first-letter is no longer the
      first-letter. In this case, it deletes the old first-letter object and creates
      a new one. For the remaining text, the oldRemainingText object is used
      again for containing the full text(first letter + remaining text).
      
      Test: fast/css/first-letter-block-change.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateFirstLetter):
      
      LayoutTests:
      
      Add a test case that ensures that CSS first-letter property should work
      properly when the first letter is changed by DOM scripting.
      
      * fast/css/first-letter-block-change.html: Added.
      * platform/efl/TestExpectations:
      * platform/gtk-wk1/fast/css/first-letter-block-change-expected.png: Added.
      * platform/gtk-wk2/fast/css/first-letter-block-change-expected.png: Added.
      * platform/gtk/fast/css/first-letter-block-change-expected.txt: Added.
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4132693e
    • bfulgham@apple.com's avatar
      [Win] Unreviewed gardening. · 9654c28f
      bfulgham@apple.com authored
      * platform/win/TestExpectations: Update TestExpectations for two crashes that were not
      previously logged, one image-only failure, another broken test due to the media changes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9654c28f
    • ap@apple.com's avatar
      [Mac] Set NSApplication current event while sending events directly to views · 9ea7a8f3
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122179
      
      Reviewed by Darin Adler.
      
      DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
      which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
      use the current event.
      
      * DumpRenderTree/mac/EventSendingController.mm:
      (-[EventSendingController mouseDown:withModifiers:]):
      (-[EventSendingController mouseUp:withModifiers:]):
      (-[EventSendingController mouseMoveToX:Y:]):
      (-[EventSendingController mouseScrollByX:andY:continuously:]):
      (-[EventSendingController contextClick]):
      (-[EventSendingController keyDown:withModifiers:withLocation:]):
      * WebKitTestRunner/mac/EventSenderProxy.mm:
      (WTR::EventSenderProxy::mouseDown):
      (WTR::EventSenderProxy::mouseUp):
      (WTR::EventSenderProxy::mouseMoveTo):
      (WTR::EventSenderProxy::keyDown):
      (WTR::EventSenderProxy::mouseScrollBy):
      Update the current event. We were already using the SPI in WebKit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ea7a8f3
    • commit-queue@webkit.org's avatar
      Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope. · 9a81e307
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122183
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-10-01
      Reviewed by Timothy Hatcher.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
      (BuildbotIteration.prototype.update):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a81e307
    • antti@apple.com's avatar
      Make tests for renderer base types non-virtual · e7f589e8
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122185
      
      Reviewed by Dave Hyatt.
      
      Make isRenderFoo() functions for commonly tested base types use bit flags instead of virtual calls.
      This is faster and we have space in RenderElement.
              
      These bits are not mutully exclusive. For testing leaf types we can add an enum.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7f589e8
    • roger_fong@apple.com's avatar
      [Windows] Unreviewed gardening. Skip fast/events/drag-and-drop-autoscroll-inner-frame.html. · 9c586c50
      roger_fong@apple.com authored
      Drag and drop does not work on Windows DRT.
      
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c586c50
    • timothy@apple.com's avatar
      Tweaks to the Buildbot Dashboard · d496015f
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122169
      
      Reviewed by Alexey Proskuryakov.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
      (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
      (BuildbotQueueView.prototype.revisionLinksForIteration):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
      (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
      (WebKitBuildbot.prototype.buildLogURLForIteration):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d496015f
    • bfulgham@apple.com's avatar
      [Win] Unreviewed build fix after r156730. · 7d63fc2e
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122021
      
      * platform/win/TestExpectations: Disable a number of tests broken by the switch to the new
      CSS/JS-based media controls.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d63fc2e
    • commit-queue@webkit.org's avatar
      Consolidate multiple OSRExit calls into one. · 9cc40b1a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122168
      
      Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-01
      Reviewed by Filip Pizlo.
      
      * ftl/FTLLowerDFGToLLVM.cpp:
      (JSC::FTL::LowerDFGToLLVM::compileArithMul):
      (JSC::FTL::LowerDFGToLLVM::compileArithDiv):
      (JSC::FTL::LowerDFGToLLVM::compileArithMod):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cc40b1a
    • rniwa@webkit.org's avatar
      Cleanup Document::dispatchFullScreenChangeOrErrorEvent · ceaabaee
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122143
      
      Reviewed by Antti Koivisto.
      
      Reduce the code duplication by extracting dispatchFullScreenChangeOrErrorEvent.
      
      * dom/Document.cpp:
      (WebCore::Document::fullScreenChangeDelayTimerFired):
      (WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Extracted.
      * dom/Document.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ceaabaee
    • ap@apple.com's avatar
      fast/forms/search-event-delay.html is flakey · 6f540b20
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=53990
      
      * TestExpectations: Marking as such.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f540b20
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r156725. · 8cb1f57c
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/156725
      https://bugs.webkit.org/show_bug.cgi?id=122176
      
      broke all the mismatch tests again (Requested by thorton on
      #webkit).
      
      Tools:
      
      * WebKitTestRunner/mac/PlatformWebViewMac.mm:
      (WTR::PlatformWebView::PlatformWebView):
      
      LayoutTests:
      
      * platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Removed.
      * platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cb1f57c
    • bfulgham@apple.com's avatar
      Source/WebCore: [Win] Implement the media controls in JavaScript · dd53e679
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122166
      
      Reviewed by Jer Noble.
      
      * DerivedSources.make: Uncomment feature flag test.
      * WebCore.vcxproj/WebCore.vcxproj: Add new media control implementation files.
      Also cleaned up some misplaced files in the project tree.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      * WebCore.vcxproj/WebCoreCommon.props: Add missing include path for the
      mediacontrols path.
      * WebCore.vcxproj/copyForwardingHeaders.cmd: Add Modules/mediacontrols to copied headers.
      * rendering/RenderThemeWin.cpp: Add missing include for UserAgentScripts.
      
      WebKitLibraries: [Win] Implement the media controls in JavaScript.
      https://bugs.webkit.org/show_bug.cgi?id=122166
      
      Reviewed by Jer Noble.
      
      * win/tools/vsprops/FeatureDefines.props: Activate the
      ENABLE_MEDIA_CONTROLS_SCRIPT flag.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd53e679
    • commit-queue@webkit.org's avatar
      Source/WebCore: Added adoptCOM to COMPtr on Windows. · 288d7158
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122069
      
      Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
      Reviewed by Brent Fulgham.
      
      * platform/win/COMPtr.h:
      (adoptCOM): Added.
      
      Source/WebKit/win: Implemented createWebViewWithRequest in WinLauncher.
      https://bugs.webkit.org/show_bug.cgi?id=122069
      
      Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
      Reviewed by Brent Fulgham.
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::createWindow):
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::dispatchCreatePage):
      Pass request url from the NavigationAction to createWebViewWithRequest.
      
      Tools: Implemented createWebViewWithRequest in WinLauncher.
      https://bugs.webkit.org/show_bug.cgi?id=122069
      
      Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
      Reviewed by Brent Fulgham.
      
      * WinLauncher/PrintWebUIDelegate.cpp:
      (PrintWebUIDelegate::createWebViewWithRequest): Added.
      * WinLauncher/PrintWebUIDelegate.h:
      Removed createWebViewWithRequest stub.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      288d7158
    • graouts@apple.com's avatar
      Web Inspector: evaluate and show a popover for selected text in JS source when paused · d1aecf01
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122151
      
      Reviewed by Joseph Pecoraro.
      
      Identify if the hovered token is contained within the text selection (if any) and use
      the selection as the hovered expression to allow the user to select text and hover it
      to see what it evaluates to.
      
      * UserInterface/CodeMirrorTokenTrackingController.js:
      (WebInspector.CodeMirrorTokenTrackingController.prototype.highlightRange):
      Check we're trying to highlight a different range before removing the highlight
      and applying the new one, this prevents the marked text from flashing if it's
      being re-hovered which would easily happen when hovering multiple tokens within
      the same selection.
      
      (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
      In the case where there is selected text, check whether the hovered token is at least
      partially contained within the selection, and if so use the selection text as the
      hovered expression to evaluate.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1aecf01
    • graouts@apple.com's avatar
      Console buttons don’t show after page reload · 0f949982
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116515
      
      Reviewed by Darin Adler.
      
      The correct display of navigation items in the ContentBrowser is contingent on
      the ContentViewContainer's _backForwardList being up-to-date when the navigation
      items are retrieved from it. However, when the main resource changes (in this case
      the user refreshes the browser), calls are made to ContentViewContainer's
      closeAllContentViewsOfPrototype() which may modify the _backForwardList but doesn't
      necessarily notify of a change to the currentContentView since we may be still showing
      the same view in case it wasn't directly related to the main resource, for instance
      the console log.
      
      We now check if the _backForwardList is changed as a result of calling
      closeAllContentViewsOfPrototype() and in that case also dispatch the
      CurrentContentViewDidChange event which will restore the correct state
      for the back/forward buttons and navigation items of the navigation bar.
      
      * UserInterface/ContentViewContainer.js:
      (WebInspector.ContentViewContainer.prototype.closeAllContentViewsOfPrototype):
      Track changes to the _backForwardList and dispatch the CurrentContentViewDidChange
      event in case such changes happened.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f949982
    • jer.noble@apple.com's avatar
      Unreviewed build fix; The addedFunction and removedFunction arguments to... · 1c81affb
      jer.noble@apple.com authored
      Unreviewed build fix; The addedFunction and removedFunction arguments to determineChangedTracksFromNewTracksAndOldItems
      were reversed, exposing an underlying, existing bug in AudioTrackPrivate and VideoTrack private. Give a default (null)
      value to AudioTrackPrivate::m_client and VideoTrackPrivate::m_client and fix the ordering of arguments in
      determineChangedTracksFromNewTracksAndOldItems.
      
      * platform/graphics/AudioTrackPrivate.h:
      (WebCore::AudioTrackPrivate::AudioTrackPrivate):
      * platform/graphics/VideoTrackPrivate.h:
      (WebCore::VideoTrackPrivate::VideoTrackPrivate):
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::determineChangedTracksFromNewTracksAndOldItems):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c81affb
    • timothy_horton@apple.com's avatar
      [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing · ba082ec1
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122006
      <rdar://problem/15095197>
      
      Reviewed by Dean Jackson.
      
      * WebKitTestRunner/mac/PlatformWebViewMac.mm:
      (WTR::PlatformWebView::PlatformWebView):
      Layer-back the root view in WebKitTestRunner's window, to work around a bug
      where the window server snapshot API returns blank snapshots.
      
      Re-landing after r156724, this should not break everything now.
      
      Add a test that ensures that WebKitTestRunner's snapshots are not
      completely blank with tiled drawing enabled.
      
      * platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
      * platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba082ec1
    • timothy_horton@apple.com's avatar
      [mac] 1x emulation on Retina hardware shouldn't use SPI · bf0819b0
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122152
      <rdar://problem/15119384>
      
      Reviewed by Anders Carlsson.
      
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (createWebViewAndOffscreenWindow):
      (main):
      * DumpRenderTree/mac/DumpRenderTreeWindow.h:
      * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
      * WebKitTestRunner/mac/PlatformWebViewMac.mm:
      (WTR::PlatformWebView::PlatformWebView):
      * WebKitTestRunner/mac/main.mm:
      (main):
      Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf0819b0
    • fpizlo@apple.com's avatar
      SpeculativeJIT::m_arguments/m_variables are vestiges of a time long gone · 3937f523
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122140
      
      Reviewed by Darin Adler.
              
      Just killing code.
      
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::SpeculativeJIT):
      (JSC::DFG::SpeculativeJIT::compileInlineStart):
      (JSC::DFG::SpeculativeJIT::compileCurrentBlock):
      (JSC::DFG::SpeculativeJIT::checkArgumentTypes):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::recordSetLocal):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3937f523