1. 24 Aug, 2010 40 commits
    • tony@chromium.org's avatar
      2010-08-24 Tony Chang <tony@chromium.org> · 8f3e3280
      tony@chromium.org authored
              Reviewed by Eric Seidel.
      
              [chromium] fix the platform result fallback order on mac/win
              https://bugs.webkit.org/show_bug.cgi?id=44483
      
              * Scripts/webkitpy/layout_tests/port/google_chrome.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f3e3280
    • joepeck@webkit.org's avatar
      2010-08-24 Joseph Pecoraro <joepeck@webkit.org> · 8b4beca5
      joepeck@webkit.org authored
              Reviewed by Mark Rowe.
      
              Web Inspector: RemoteInspectorFrontend can be renamed to InspectorFrontend
              https://bugs.webkit.org/show_bug.cgi?id=44499
      
              Follow-up. No longer generate the RemoteInspectorFrontend files, just
              generate the required InspectorFrontend files.
      
              * DerivedSources.make:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b4beca5
    • joepeck@webkit.org's avatar
      2010-08-20 Joseph Pecoraro <joepeck@webkit.org> · 514c5cf4
      joepeck@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Backend Should Provide Full Supported CSS Properties List
              https://bugs.webkit.org/show_bug.cgi?id=40886
      
              This allows the backend to send the front-end its complete list of
              supported CSS Properties. This is used in CSS Autocompletion and
              CSS Syntax Highlighting to show which styles are supported.
      
              * css/makeprop.pl: moved CSS properties to the header file.
              * inspector/Inspector.idl: expose getSupportedCSSProperties.
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::getSupportedCSSProperties):
              * inspector/InspectorDOMAgent.h:
              * inspector/front-end/CSSCompletions.js:
              (WebInspector.CSSCompletions._firstIndexOfPrefix): handle a possible error case before properties have loaded.
              (WebInspector.CSSCompletions._load): fill up the special array with the received properties.
              * inspector/front-end/SourceCSSTokenizer.js:
              (WebInspector.SourceCSSTokenizer): use the list of support properties from the backend.
              * inspector/front-end/SourceCSSTokenizer.re2js:
              * inspector/front-end/inspector.js: request the list of supported CSS properties on load.
              (WebInspector.doLoadedDone):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      514c5cf4
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · 34ff1f7c
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Delete LegacyHTMLTreeBuilder
              https://bugs.webkit.org/show_bug.cgi?id=44554
      
              There were some free functions in LegacyHTMLTreeBuilder that needed a
              new home.  I've put them in HTMLTreeBuilder, but they'll probably need
              a better home eventually.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/Document.cpp:
              (WebCore::shouldCreateImplicitHead):
              * dom/DocumentParser.h:
              * dom/ScriptableDocumentParser.h:
              * html/HTMLConstructionSite.cpp:
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElement::removedFromTree):
              * html/HTMLInputElement.cpp:
              * html/HTMLMeterElement.cpp:
              * html/HTMLProgressElement.cpp:
              * html/HTMLTreeBuilder.cpp:
              (WebCore::serializeForNumberType):
              (WebCore::parseToDoubleForNumberType):
              * html/HTMLTreeBuilder.h:
              * html/HTMLViewSourceParser.h:
              * html/LegacyHTMLTreeBuilder.cpp: Removed.
              * html/LegacyHTMLTreeBuilder.h: Removed.
              * html/StepRange.cpp:
              * html/ValidityState.cpp:
              * rendering/RenderSlider.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34ff1f7c
    • ojan@chromium.org's avatar
      2010-08-24 Ojan Vafai <ojan@chromium.org> · ec7a0944
      ojan@chromium.org authored
              Reviewed by Tony Chang.
      
              perf tests are flaky
              https://bugs.webkit.org/show_bug.cgi?id=44199
      
              Speculative fix for perf test flakiness. Use chromium.Interval
              to get a microsecond granularity timer. If this does end up
              reducing flakiness, then we can expose something similar for
              JSC and/or layoutTestController.
      
              * resources/magnitude-perf.js:
              (Magnitude._runIteration):
              (Magnitude):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec7a0944
    • commit-queue@webkit.org's avatar
      2010-08-24 Pavel Podivilov <podivilov@chromium.org> · c4ccfd1e
      commit-queue@webkit.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: show DOM breakpoints in sidebar pane
              https://bugs.webkit.org/show_bug.cgi?id=44424
      
              * inspector/dom-breakpoints.html:
      2010-08-24  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: show DOM breakpoints in sidebar pane
              https://bugs.webkit.org/show_bug.cgi?id=44424
      
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.BreakpointManager.prototype._setBreakpoint):
              (WebInspector.BreakpointManager.prototype._breakpointRemoved):
              (WebInspector.BreakpointManager.prototype._setBreakpointOnBackend):
              (WebInspector.Breakpoint.prototype.set enabled):
              (WebInspector.Breakpoint.prototype.set condition):
              (WebInspector.Breakpoint.prototype.remove):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.BreakpointsSidebarPane):
              (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype._breakpointRemoved):
              (WebInspector.BreakpointsSidebarPane.prototype._contextMenuEventFired):
              (WebInspector.BreakpointItem):
              (WebInspector.BreakpointItem.prototype.element):
              (WebInspector.BreakpointItem.prototype.remove):
              (WebInspector.BreakpointItem.prototype._checkboxClicked):
              (WebInspector.BreakpointItem.prototype._enableChanged):
              (WebInspector.BreakpointItem.prototype._removed):
              (WebInspector.JSBreakpointItem):
              (WebInspector.JSBreakpointItem.prototype._textChanged):
              (WebInspector.DOMBreakpointItem):
              (WebInspector.DOMBreakpointItem.prototype.compareTo):
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMBreakpointManager):
              (WebInspector.DOMBreakpointManager.prototype.setBreakpoint):
              (WebInspector.DOMBreakpointManager.prototype.removeBreakpointsForNode):
              (WebInspector.DOMBreakpointManager.prototype._breakpointRemoved):
              (WebInspector.DOMBreakpoint):
              (WebInspector.DOMBreakpoint.prototype.get enabled):
              (WebInspector.DOMBreakpoint.prototype.set enabled):
              (WebInspector.DOMBreakpoint.prototype.remove):
              * inspector/front-end/ElementsPanel.js:
              (WebInspector.ElementsPanel):
              (WebInspector.ElementsPanel.prototype.reset):
              * inspector/front-end/ElementsTreeOutline.js:
              (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
              * inspector/front-end/ScriptView.js:
              (WebInspector.ScriptView):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype._breakpointAdded):
              (WebInspector.ScriptsPanel.prototype.reset):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              (WebInspector.SourceFrame.prototype.set visible):
              (WebInspector.SourceFrame.prototype.addBreakpoint):
              (WebInspector.SourceFrame.prototype._breakpointRemoved):
              (WebInspector.SourceFrame.prototype._addBreakpointToSource):
              (WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
              (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
              (WebInspector.SourceFrame.prototype._contextMenu):
              (WebInspector.SourceFrame.prototype._mouseDown):
              * inspector/front-end/SourceView.js:
              (WebInspector.SourceView):
              (WebInspector.SourceView.prototype.updateLocalContent):
              * inspector/front-end/inspector.js:
              (WebInspector.createJSBreakpointsSidebarPane.breakpointAdded):
              (WebInspector.createJSBreakpointsSidebarPane):
              (WebInspector.createDOMBreakpointsSidebarPane.breakpointAdded):
              (WebInspector.createDOMBreakpointsSidebarPane):
              (WebInspector.doLoadedDone):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4ccfd1e
    • senorblanco@chromium.org's avatar
      2010-08-24 Stephen White <senorblanco@chromium.org> · 3cb5b10d
      senorblanco@chromium.org authored
              Reviewed by Dumitru Daniliuc.
      
              Speculative fix for layout test failures on Chrome/Linux.
              https://bugs.webkit.org/show_bug.cgi?id=44550
      
              Tests fast/canvas/arc-crash.html, fast/canvas/canvas-state-intact-after-putImageData.html, and fast/canvas/toDataURL-supportedTypes.html are failing on Chrome/Linux.  Can't repro the failure locally, but this fix can't hurt.
      
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::paintRenderingResultsToCanvas):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cb5b10d
    • dumi@chromium.org's avatar
      WebCore: Fix the NodeFilter wrapper and the binding for acceptNode. · 95948cdf
      dumi@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=44542
      
      Reviewed by Dimitri Glazkov.
      
      * bindings/v8/V8DOMWrapper.cpp:
      (WebCore::V8DOMWrapper::wrapNativeNodeFilter): This function
      should always create a filter. V8NodeFilterCondition::acceptNode()
      will check if the given object can be used as a filter, and throw
      an exception if it can't.
      * bindings/v8/V8NodeFilterCondition.cpp:
      (WebCore::V8NodeFilterCondition::acceptNode): Update this binding
      to do the same thing that the JS binding does.
      
      LayoutTests: acceptNode-filter.html should pass after this patch.
      https://bugs.webkit.org/show_bug.cgi?id=44542
      
      Reviewed by Dimitri Glazkov.
      
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95948cdf
    • tony@chromium.org's avatar
      2010-08-24 Tony Chang <tony@chromium.org> · 76a530ae
      tony@chromium.org authored
              Reviewed by Ojan Vafai.
      
              [chromium] linux layout test results for svg tests
              https://bugs.webkit.org/show_bug.cgi?id=44303
      
              * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
              * platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
              * platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
              * platform/chromium-linux/svg/carto.net/slider-expected.checksum:
              * platform/chromium-linux/svg/carto.net/slider-expected.png:
              * platform/chromium-linux/svg/carto.net/textbox-expected.checksum:
              * platform/chromium-linux/svg/carto.net/textbox-expected.png:
              * platform/chromium-linux/svg/carto.net/window-expected.txt: Added.
              * platform/chromium-linux/svg/custom/coords-relative-units-transforms-expected.checksum:
              * platform/chromium-linux/svg/custom/coords-relative-units-transforms-expected.png: Added.
              * platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
              * platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png:
              * platform/chromium-linux/svg/hixie/perf/003-expected.txt: Added.
              * platform/chromium-linux/svg/hixie/perf/004-expected.txt: Added.
              * platform/chromium-linux/svg/hixie/perf/005-expected.txt: Added.
              * platform/chromium-linux/svg/hixie/perf/006-expected.txt: Added.
              * platform/chromium-linux/svg/hixie/text/003b-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76a530ae
    • tony@chromium.org's avatar
      2010-08-24 Tony Chang <tony@chromium.org> · cfa5e34b
      tony@chromium.org authored
              Reviewed by Ojan Vafai.
      
              [chromium] linux baselines for a few svg tests
              https://bugs.webkit.org/show_bug.cgi?id=44286
      
              These are all font differences from the windows and mac results.  On
              Linux, we have stronger anti-aliasing of fonts than windows although
              we match the windows font metrics (which is why these are only pixel
              results).
      
              * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
              * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
              * platform/chromium/drt_expectations.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfa5e34b
    • simon.fraser@apple.com's avatar
      2010-08-24 Simon Fraser <simon.fraser@apple.com> · bfe28066
      simon.fraser@apple.com authored
              Reviewed by Tony Chang.
      
              After r65681, caret no longer displays promptly while editing form fields
              https://bugs.webkit.org/show_bug.cgi?id=44294
      
              The caret no longer eagerly updates its rect on every paint, so we have
              to manually update it after scrolling the selection into view when
              the selection changes.
      
              Tested by the pixel results of fast/forms/input-text-scroll-left-on-blur.html
      
              * page/Frame.cpp:
              (WebCore::Frame::revealSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfe28066
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · 36b62525
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove redundant call to OwnPtr::clear
              https://bugs.webkit.org/show_bug.cgi?id=44548
      
              As pointed out by Darin, this call to clear is not needed.
      
              * editing/TextIterator.cpp:
              (WebCore::plainTextToMallocAllocatedBuffer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36b62525
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · db146971
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              HTMLTokenizer::create
              https://bugs.webkit.org/show_bug.cgi?id=44477
      
              * html/HTMLDocumentParser.cpp:
              (WebCore::HTMLDocumentParser::HTMLDocumentParser):
              * html/HTMLPreloadScanner.cpp:
              (WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
              (WebCore::HTMLPreloadScanner::scan):
              (WebCore::HTMLPreloadScanner::processToken):
              * html/HTMLPreloadScanner.h:
              * html/HTMLTokenizer.h:
              (WebCore::HTMLTokenizer::create):
              * html/HTMLViewSourceParser.cpp:
              (WebCore::HTMLViewSourceParser::HTMLViewSourceParser):
              (WebCore::HTMLViewSourceParser::pumpTokenizer):
              (WebCore::HTMLViewSourceParser::updateTokenizerState):
              * html/HTMLViewSourceParser.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db146971
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · acfadba8
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove references to LegacyHTMLTreebuilder from HTMLTreeBuilder
              https://bugs.webkit.org/show_bug.cgi?id=44544
      
              * html/HTMLDocumentParser.cpp:
              * html/HTMLDocumentParser.h:
              * html/HTMLTreeBuilder.cpp:
              (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
              (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
              (WebCore::HTMLTreeBuilder::FragmentParsingContext::document):
              (WebCore::HTMLTreeBuilder::constructTreeFromToken):
              (WebCore::HTMLTreeBuilder::finished):
              * html/HTMLTreeBuilder.h:
              (WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acfadba8
    • mrowe@apple.com's avatar
      Set the install path of WebKit2.framework to the build directory for debug and release builds · ca6676d3
      mrowe@apple.com authored
      to match our other frameworks.
      
      Rubber-stamped by Sam Weinig.
      
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca6676d3
    • xan@webkit.org's avatar
      2010-08-24 Xan Lopez <xlopez@igalia.com> · ef9fcb9e
      xan@webkit.org authored
              Build fix, strike 2.
      
              The unit tests are C files, so put the flag in global_cflags.
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef9fcb9e
    • simon.fraser@apple.com's avatar
      2010-08-24 Simon Fraser <simon.fraser@apple.com> · d5e70656
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              Add test for a NodeFilter throwing
              https://bugs.webkit.org/show_bug.cgi?id=44480
      
              The TreeWalker DOM spec says that an exception thrown inside the NodeFilter should
              propagate out to the caller. This tests that.
      
              * fast/dom/TreeWalker/filter-throw-expected.txt: Added.
              * fast/dom/TreeWalker/filter-throw.html: Added.
              * fast/dom/TreeWalker/script-tests/filter-throw.js: Added.
              (walker.document.createTreeWalker):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5e70656
    • xan@webkit.org's avatar
      2010-08-24 Xan Lopez <xlopez@igalia.com> · 7799c02a
      xan@webkit.org authored
              Try to fix GTK+ build.
      
              Move GTK_API_VERSION_2 define to here, since we want to use it
              outside of WebCore/WebKit.
      
              * GNUmakefile.am:
      
      WebCore:
      
      2010-08-24  Xan Lopez  <xlopez@igalia.com>
      
              Try to fix GTK+ build.
      
              Move GTK_API_VERSION_2 define out.
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7799c02a
    • simon.fraser@apple.com's avatar
      2010-08-24 Simon Fraser <simon.fraser@apple.com> · ff8a152a
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              TreeWalker traversal order is wrong when skipping and rejecting
              https://bugs.webkit.org/show_bug.cgi?id=44377
      
              TreeWalker's nextSibling() and previousSibling() behaved incorrectly
              when traversing down a subtree where all nodes are skipped; it backed all
              the way up to the root of the subtree, then jump to the subtree's parentNode.
              This would skip later siblings.
      
              Fix by resetting 'node' when traversing to children so that node = node->parentNode()
              gets the correct node later.
      
              Test: fast/dom/TreeWalker/traversal-skip-most.html
      
              * dom/TreeWalker.cpp:
              (WebCore::TreeWalker::previousSibling):
              (WebCore::TreeWalker::nextSibling):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff8a152a
    • xan@webkit.org's avatar
      WebKit/gtk: · 87bee73a
      xan@webkit.org authored
      2010-08-24  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              Set a device to the event struct when building with GTK+ 3.x, it's
              mandatory.
      
              * tests/testcopyandpaste.c:
              (runPasteTestCallback):
      
      WebKitTools:
      
      2010-08-24  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              Set a device to the event struct when building with GTK+ 3.x, it's
              mandatory.
      
              * DumpRenderTree/gtk/EventSender.cpp:
              (keyDownCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87bee73a
    • commit-queue@webkit.org's avatar
      2010-08-24 Hans Wennborg <hans@chromium.org> · d1db06cc
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              Remove null-checks from DeviceOrientationController
              https://bugs.webkit.org/show_bug.cgi?id=44504
      
              Remove checks for m_client being NULL from DeviceOrientationController.
              It will never be NULL, and this is checked by an ASSERT on construction.
      
              Will be covered by layout tests for device orientation.
      
              * dom/DeviceOrientationController.cpp:
              (WebCore::DeviceOrientationController::timerFired):
              (WebCore::DeviceOrientationController::addListener):
              (WebCore::DeviceOrientationController::removeListener):
              (WebCore::DeviceOrientationController::removeAllListeners):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1db06cc
    • mrobinson@webkit.org's avatar
      2010-08-24 Martin Robinson <mrobinson@igalia.com> · 60ee7c62
      mrobinson@webkit.org authored
              Build fix for GTK+.
      
              * tests/testkeyevents.c:
              (key_press_event_cb):
              (key_release_event_cb):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60ee7c62
    • mrobinson@webkit.org's avatar
      2010-08-24 Martin Robinson <mrobinson@igalia.com> · afebf269
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
              https://bugs.webkit.org/show_bug.cgi?id=44534
      
              Fix an issue where a GdkEvent* is treated like a GdkEvent.
      
              * tests/testkeyevents.c:
              (key_press_event_cb):
              (key_release_event_cb):
      2010-08-24  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
              https://bugs.webkit.org/show_bug.cgi?id=44534
      
              Fix two double-frees introduced in my previous commit.
      
              * DumpRenderTree/gtk/EventSender.cpp:
              (contextClickCallback): Copy the event before using it again.
              (keyDownCallback): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afebf269
    • senorblanco@chromium.org's avatar
      2010-08-24 Stephen White <senorblanco@chromium.org> · 1bcb34b8
      senorblanco@chromium.org authored
              Reviewed by Kenneth Russell.
      
              Fix accelerated 2d canvas with accelerated compositing off.
              https://bugs.webkit.org/show_bug.cgi?id=44525
      
              Tested by running with --enable-accelerated-2d-canvas with
              --enable-accelerated-compositing off.
              ImageBuffer::copyImage changes covered by
              LayoutTests/fast/canvas/canvas-pattern-*.html.
      
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::paint):
              Extend the accelerated compositing check and the readback for
              non-accelerated compositing to accelerated 2D canvas also.
              * html/canvas/CanvasRenderingContext.cpp:
              * html/canvas/CanvasRenderingContext.h:
              (WebCore::CanvasRenderingContext::paintsIntoCanvasBuffer):
              Move this logic from WebGL to common canvas context code.
              * html/canvas/WebGLRenderingContext.h:
              Remove implementation of paintsIntoCanvasBuffer.
              * platform/graphics/skia/ImageBufferSkia.cpp:
              (WebCore::ImageBuffer::copyImage):
              When copying the image for patterns, sync the software canvas.
              * platform/graphics/skia/PlatformContextSkia.cpp:
              (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
              Use SkDevice::eraseColor() to clear the canvas for mixed mode rendering.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bcb34b8
    • oliver@apple.com's avatar
      2010-08-24 Oliver Hunt <oliver@apple.com> · 8f76c6e5
      oliver@apple.com authored
              Reviewed by Beth Dakin.
      
              Make overflow guards in UString::utf8 explicit
              https://bugs.webkit.org/show_bug.cgi?id=44540
      
              Add an explicit overflow check prior to allocating our buffer,
              rather than implicitly relying on the guard in convertUTF16ToUTF8.
      
              * runtime/UString.cpp:
              (JSC::UString::utf8):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f76c6e5
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · 7c5e65d5
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Deploy adoptPtr in WebCore/editing
              https://bugs.webkit.org/show_bug.cgi?id=44501
      
              * editing/Editor.cpp:
              (WebCore::Editor::Editor):
              * editing/TextIterator.cpp:
              (WebCore::plainTextToMallocAllocatedBuffer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c5e65d5
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · d7b3ddf0
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Deploy adoptPtr in WebCore/history
              https://bugs.webkit.org/show_bug.cgi?id=44502
      
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::HistoryItem):
              (WebCore::HistoryItem::addRedirectURL):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7b3ddf0
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · d34b6002
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Partial deployment of adoptPtr to WebCore/html
              https://bugs.webkit.org/show_bug.cgi?id=44507
      
              Deploy adoptPtr to some more places in WebCore/html.  The big chunk
              that I haven't done yet is createRenderer, but that's going to be a big
              patch unto itself.
      
              * html/HTMLFormCollection.cpp:
              (WebCore::HTMLFormCollection::formCollectionInfo):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::addElementAlias):
              * html/HTMLInputElement.cpp:
              (WebCore::createTypeMap):
              (WebCore::HTMLInputElement::setInputType):
              (WebCore::HTMLInputElement::parseMappedAttribute):
              (WebCore::HTMLInputElement::attach):
              (WebCore::HTMLInputElement::preDispatchEventHandler):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::parseMappedAttribute):
              (WebCore::HTMLObjectElement::attach):
              * html/HTMLToken.h:
              (WebCore::HTMLToken::beginDOCTYPE):
              * html/HTMLVideoElement.cpp:
              (WebCore::HTMLVideoElement::attach):
              (WebCore::HTMLVideoElement::parseMappedAttribute):
              * html/ValidityState.h:
              (WebCore::ValidityState::create):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d34b6002
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · e5a57d8c
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Partial deployment of adoptPtr to WebCore/html
              https://bugs.webkit.org/show_bug.cgi?id=44507
      
              There's a lot of places that need adoptPtr in WebCore/html.  This patch
              does some of them.  More will follow.
      
              * html/FileThreadTask.h:
              (WebCore::FileThreadTask0::create):
              (WebCore::FileThreadTask1::create):
              (WebCore::FileThreadTask2::create):
              (WebCore::FileThreadTask3::create):
              * html/HTMLAreaElement.cpp:
              (WebCore::HTMLAreaElement::mapMouseEvent):
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::getContext):
              * html/HTMLElementStack.cpp:
              (WebCore::HTMLElementStack::insertAbove):
              (WebCore::HTMLElementStack::pushCommon):
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::parseMappedAttribute):
              (WebCore::HTMLEmbedElement::attach):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5a57d8c
    • mrobinson@webkit.org's avatar
      2010-08-24 Martin Robinson <mrobinson@igalia.com> · 2227d9e3
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
              https://bugs.webkit.org/show_bug.cgi?id=44534
      
              * tests/testcopyandpaste.c:
              (runPasteTestCallback): Switch to using gdk_event_new and also reference the GdkWindow.
              when setting it on the event. It is dereferenced by gdk_event_free(...).
              * tests/testhittestresult.c:
              (load_status_cb): Switch to using gdk_event_new.
      2010-08-24  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
              https://bugs.webkit.org/show_bug.cgi?id=44534
      
              * DumpRenderTree/gtk/EventSender.cpp:
              (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
              when setting it on the event. It is dereferenced by gdk_event_free(...).
              (contextClickCallback): Ditto.
              (mouseDownCallback): Ditto.
              (mouseUpCallback): Ditto.
              (mouseMoveToCallback): Ditto.
              (mouseWheelToCallback): Ditto.
              (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
              (dispatchEvent): Ditto. Also free the event when we are done with it.
              (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2227d9e3
    • simon.fraser@apple.com's avatar
      2010-08-24 Simon Fraser <simon.fraser@apple.com> · aaa04f1e
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              TreeWalker traversal order is wrong when skipping and rejecting
              https://bugs.webkit.org/show_bug.cgi?id=44377
      
              Add some tests for TreeWalker with node filters that skip and reject.
      
              * fast/dom/TreeWalker/script-tests/traversal-reject.js: Added.
              (rejectB1Filter.acceptNode):
              (rejectB2Filter.acceptNode):
              * fast/dom/TreeWalker/script-tests/traversal-skip.js: Added.
              (skipB1Filter.acceptNode):
              (skipB2Filter.acceptNode):
              * fast/dom/TreeWalker/traversal-reject-expected.txt: Added.
              * fast/dom/TreeWalker/traversal-reject.html: Added.
              * fast/dom/TreeWalker/traversal-skip-expected.txt: Added.
              * fast/dom/TreeWalker/traversal-skip.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aaa04f1e
    • weinig@apple.com's avatar
      Improve comment for Simon. · 4257f3c5
      weinig@apple.com authored
      Reviewed by Simon Fraser.
      
      * editing/Editor.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4257f3c5
    • weinig@apple.com's avatar
      Paste event fires twice for mac WebKit · bea95cea
      weinig@apple.com authored
      <rdar://problem/8094611>
      https://bugs.webkit.org/show_bug.cgi?id=44535
      
      Reviewed by Oliver Hunt.
      
      WebCore: 
      
      The mac implementation of paste in WebKit was accidentally calling 
      Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
      in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).
      Use the new pasteAsPlainTextBypassingDHTML function to bypass the
      second call.
      
      Test: editing/pasteboard/paste-event-only-once.html
      
      * WebCore.exp.in:
      * editing/Editor.cpp:
      (WebCore::Editor::pasteAsPlainTextBypassingDHTML): 
      * editing/Editor.h:
      Expose a function which just pastes using from the general pasteboard,
      bypassing all the checking and DHTML pasting.
      
      WebKit/mac: 
      
      The mac implementation of paste in WebKit was accidentally calling 
      Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
      in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).
      Use the new pasteAsPlainTextBypassingDHTML function to bypass the
      second call.
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView paste:]):
      
      LayoutTests: 
      
      * editing/pasteboard/paste-event-only-once-expected.txt: Added.
      * editing/pasteboard/paste-event-only-once.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bea95cea
    • japhet@chromium.org's avatar
      2010-08-24 Nate Chapin <japhet@chromium.org> · 6f9682ba
      japhet@chromium.org authored
              Unreviewed.
      
              Chromium build fix (add a #include missing in PingLoader.cpp)
      
              * loader/PingLoader.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f9682ba
    • japhet@chromium.org's avatar
      2010-08-24 Nate Chapin <japhet@chromium.org> · bc213021
      japhet@chromium.org authored
              Reviewed by David Levin.
      
              Allow image loads triggered from unload handlers to run entirely
              independently of any other loads or navigations.
      
              https://bugs.webkit.org/show_bug.cgi?id=30457
      
              Test: http/tests/navigation/image-load-in-unload-handler.html
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::requestImage): Use PingLoader for image
                  loads in unload handlers.
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::pageDismissalEventBeingDispatched):
              * loader/PingLoader.cpp: Added.
              (WebCore::PingLoader::loadImage): Set the appropriate
                  headers for an image load in unload handler (since we're
                  not using SubresourceLoader, we need to do this manually here).
              (WebCore::PingLoader::PingLoader):
              * loader/PingLoader.h: Added.
              (WebCore::PingLoader::~PingLoader):
              (WebCore::PingLoader::didReceiveResponse):
              (WebCore::PingLoader::didReceiveData):
              (WebCore::PingLoader::didFinishLoading):
              (WebCore::PingLoader::didFail):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc213021
    • pfeldman@chromium.org's avatar
      2010-08-24 Pavel Feldman <pfeldman@chromium.org> · 28325c78
      pfeldman@chromium.org authored
              Not reviewed: fix new inspector test expectation.
      
              * inspector/styles-computed-trace-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28325c78
    • weinig@apple.com's avatar
      Update profile. · ff7153a2
      weinig@apple.com authored
      Reviewed by John Sullivan.
      
      * WebProcess/com.apple.WebProcess.sb:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff7153a2
    • demarchi@webkit.org's avatar
      2010-08-24 Lukasz Slachciak <l.slachciak@samsung.com> · 44711641
      demarchi@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [EFL] Extended EFL WebView API to allow enable/disable Frame Flattening
              https://bugs.webkit.org/show_bug.cgi?id=44253
      
              * ewk/ewk_view.cpp:
              (ewk_view_setting_enable_frame_flattening_get):
              (ewk_view_setting_enable_frame_flattening_set):
              * ewk/ewk_view.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44711641
    • demarchi@webkit.org's avatar
      2010-08-24 Lucas De Marchi <lucas.demarchi@profusion.mobi> · de4b3e9b
      demarchi@webkit.org authored
              [EFL] Unreviewed build fix after r65891.
      
              r65891 renamed RemoteInspectorFrontend to InspectorFrontend. Rename
              accordingly in CMake build system.
      
              * cmake/WebKitGenerators.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de4b3e9b
    • pfeldman@chromium.org's avatar
      2010-08-24 Pavel Feldman <pfeldman@chromium.org> · f8a73757
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Trace to the style that contributes to
              the computed styles panel.
              https://bugs.webkit.org/show_bug.cgi?id=44448
      
              Test: inspector/styles-computed-trace.html
      
              * English.lproj/localizedStrings.js:
              * inspector/front-end/Section.js:
              (WebInspector.Section.prototype.set subtitle):
              (WebInspector.Section.prototype.get subtitleAsTextForTest):
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylesSidebarPane.prototype._refreshUpdate):
              (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
              (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
              (WebInspector.StylesSidebarPane.prototype._refreshSectionsForStyleRules):
              (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
              (WebInspector.StylePropertiesSection.linkifyUncopyable):
              (WebInspector.StylePropertiesSection):
              (WebInspector.StylePropertiesSection.prototype.isPropertyInherited):
              (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
              (WebInspector.StylePropertiesSection.prototype.isPropertyDisabled):
              (WebInspector.StylePropertiesSection.prototype.update):
              (WebInspector.StylePropertiesSection.prototype.onpopulate):
              (WebInspector.ComputedStylePropertiesSection):
              (WebInspector.ComputedStylePropertiesSection.prototype.collapse):
              (WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):
              (WebInspector.ComputedStylePropertiesSection.prototype.update):
              (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
              (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
              (WebInspector.BlankStylePropertiesSection):
              * inspector/front-end/inspector.css:
              (.styles-section a::before):
              * inspector/front-end/inspector.js:
              (WebInspector.documentClick.followLink):
              (WebInspector.documentClick):
              (WebInspector.linkifyResourceAsNode):
      2010-08-24  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Trace to the style that contributes to
              the computed styles panel.
              https://bugs.webkit.org/show_bug.cgi?id=44448
      
              * inspector/elements-panel-styles-expected.txt:
              * inspector/elements-tests.js:
              (frontend_getSelectedElementStyles):
              (frontend_dumpStyleTreeItem):
              * inspector/styles-computed-trace-expected.txt: Added.
              * inspector/styles-computed-trace.html: Added.
              * inspector/styles-disable-inherited-expected.txt:
              * inspector/styles-disable-inherited.html:
              * inspector/styles-disable-then-delete-expected.txt:
              * inspector/styles-source-lines-inline-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8a73757